Re: [edk2] [PATCH] ShellPkg: Move UnicodeCollation2 Protcol locate out of UefiShellLib constructor

And pushed. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Wednesday, October 05, 2016 1:58 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Tapan

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

as soon as the lib calls into the shell anyways. This was already true since the protocol was not present for the API to work with... -Jaben > -Original Message- > From: Tim Lewis [mailto:tim.le...@insyde.com] > Sent: Wednesday, October 05, 2016 2:33 PM > To: Carsey, Jabe

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

Behalf Of > Tim Lewis > Sent: Wednesday, October 05, 2016 2:07 PM > To: af...@apple.com; Laszlo Ersek <ler...@redhat.com> > Cc: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel-01 de...@ml01.01.org>; Leif Lindholm <leif.lindh...@arm.com> > Subject: Re: [edk2] Ass

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

drew Fish > Sent: Wednesday, October 05, 2016 2:06 PM > To: Daniil Egranov <daniil.egra...@arm.com> > Cc: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel-01 de...@lists.01.org>; Leif Lindholm <leif.lindh...@arm.com> > Subject: Re: [edk2] Assert in

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

ctober 05, 2016 1:25 PM > To: Laszlo Ersek <ler...@redhat.com>; Andrew Fish <af...@apple.com>; > Daniil Egranov <daniil.egra...@arm.com> > Cc: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel-01 de...@ml01.01.org>; Leif Lindholm <leif.lindh...@arm.com> &

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

Tapan, Could this be a side effect of your patch? Should we allow the UefiShellLib to continue without this protocol and then return an error only when the OpenFile is called? Also, it looks like we never properly initialize mUnicodeCollationProtocol. We check for NULL in Constructor, but

Re: [edk2] [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

: Rothman, Michael A Sent: Monday, October 03, 2016 11:36 AM To: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t..

Re: [edk2] [PATCH v2] ShellPkg/Shell: Update CRC32 in the EFI System Table header

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> And pushed. > -Original Message- > From: Shah, Tapan [mailto:tapands...@hpe.com] > Sent: Monday, October 03, 2016 9:39 AM > To: Shia, Cinnamon <cinnamon.s...@hpe.com>; edk2-devel@lists.01.org > Cc: Carsey, Ja

Re: [edk2] [Patch] ShellPkg/Hexedit: Fix FreePool() ASSERT() when writing disk

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, September 28, 2016 7:52 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@in

Re: [edk2] [PATCH] ShellPkg/Shell: Update CRC32 in the EFI System Table header

Why add a CpuBreakPoint()? > -Original Message- > From: Cinnamon Shia [mailto:cinnamon.s...@hpe.com] > Sent: Monday, October 03, 2016 9:14 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu > <ruiyu...@intel.com>; Cinnam

Re: [edk2] [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

it for itself (and it works). I think it just needs clarification so people can depend on the current implementation not changing. -Jaben From: Ni, Ruiyu Sent: Thursday, September 29, 2016 9:13 PM To: Carsey, Jaben <jaben.car...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Kin

Re: [edk2] [PATCH 00/11] Remove unnecessary EFIAPI

I have no objection. Can you explain the benefit or just remove confusion? Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Friday, September 30, 2016 1:18 AM > To:

Re: [edk2] How to open a file by it's full path in UEFI

Apparently all the good threads happen at night for me... Kesheva, There are a few functions in the ShellLib that call into the UEFI Shell binary to help you. Some of these are duplicates of what others suggested, but I figured I would elaborate. ShellOpenFileMetaArg - open a file or group of

Re: [edk2] [PATCH] ShellPkg: Enhance 'cls' command to change the background and foreground colors

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> And pushing now. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Tapan Shah > Sent: Friday, September 23, 2016 9:03 AM > To: edk2-devel@lists.01.org > Cc:

Re: [edk2] [PATCH] ShellPkg: Update help output for disconnect command

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> And commited. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Friday, September 23, 2016 9:10 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Tapan

Re: [edk2] [PATCH] ShellPkg: Add '-nc' flag support in 'disconnect' command

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> And commited. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Thursday, September 22, 2016 12:49 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Tapan

Re: [edk2] [PATCH] ShellPkg: Expand special output file to include "NULL" and case insensitive

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> And commited. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Thursday, September 22, 2016 12:13 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Tapan

Re: [edk2] [PATCH] ShellPkg: Remove current working dir path ".; " from 'path' variable

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> And commited. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Wednesday, September 21, 2016 2:30 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Tapan

Re: [edk2] [PATCH] ShellPkg: Add Persistent Memory support in 'memmap' command

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> And commited. > -Original Message- > From: Shah, Tapan [mailto:tapands...@hpe.com] > Sent: Thursday, September 22, 2016 2:15 PM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org > Subject

Re: [edk2] [PATCH] ShellPkg: Add Persistent Memory support in 'memmap' command

Can you reply with your attestation and signed off by lines? > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Thursday, September 22, 2016 1:16 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Tapan Shah

Re: [edk2] [PATCH] ShellPkg: Expand special output file to include "NULL" and case insensitive

separate? -Jaben > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Thursday, September 22, 2016 9:14 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Tapan Shah > <tapands...@hpe.com> > Subject: [PATCH

Re: [edk2] [PATCH 0/2] ShellPkg: fix assertion failure encountered with "devtree" and "dh -d -v"

Thanks and for the Series. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Thursday, September 08, 2016 9:14 AM > To: edk2-de...@ml01.01.or

Re: [edk2] [PATCH v2] ShellPkg: pci -i -_e to print next capability

Commited. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Abdul Lateef Attar > Sent: Friday, September 09, 2016 11:32 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2] ShellPkg: pci -i -_e to print next capability > Importance:

Re: [edk2] [PATCH] ShellPkg: pci -i -_e to print next capability

Change Looks good. Can you please clarify the commit message on why to change -_e type? Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Abdul Lateef Attar > Sent: Monday, September 05,

Re: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Wednesday, August 31, 2016 6:09 PM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com> > Subje

Re: [edk2] [patch] ShellPkg: Add the check of parameter number in "DrvCfg" command

, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com> > Subject: RE: [edk2] [patch] ShellPkg: Add the check of parameter number in > "DrvCfg" command > Importance: High > > Reviewed-by: Tapan Shah <tapands...@hpe.com> > > -Orig

Re: [edk2] I found a fun bug in the Shell today. Looks like we have been getting lucky?

Doh! Thanks! I didn't realize that was the bug. I will have to finally learn that servers name one of these days... > -Original Message- > From: af...@apple.com [mailto:af...@apple.com] > Sent: Thursday, August 25, 2016 9:08 AM > To: Carsey, Jaben <jaben.car...@intel.

Re: [edk2] I found a fun bug in the Shell today. Looks like we have been getting lucky?

Andrew, Can you file a Bugzilla issue so we can track this issue properly? -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Andrew Fish > Sent: Wednesday, August 24, 2016 6:26 PM > To: edk2-devel > Subject:

Re: [edk2] [PATCH 1/2] StdLib/LibC: avoid LTO code for compiler intrinsics

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Michael Zimmermann > Sent: Monday, August 08, 2016 4:24 AM > To: Ard Biesheuvel <ard.biesheu...@linaro.org> >

Re: [edk2] [PATCH 2/2] StdLib/LibC ARM AARCH64: do not redefine compiler intrinsics

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, August 08, 2016 4:12 AM > To: edk2-devel@lists.01.org; edk2-li...@mc2research.org; Carsey, Jaben > <jaben.car...@inte

Re: [edk2] Shell version 2.2

version. -Jaben > -Original Message- > From: Tim Lewis [mailto:tim.le...@insyde.com] > Sent: Friday, August 5, 2016 11:36 AM > To: Carsey, Jaben <jaben.car...@intel.com>; Meenakshi Aggarwal > <meenakshi.aggar...@nxp.com>; edk2-devel@lists.01.org de...@ml01.01.org>

Re: [edk2] Shell version 2.2

I think that that version (2.1) is correct for the version of the protocol. The protocol API was not changed for the UEFI Shell 2.2. That is the current version and should support the 2.2 spec. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [PATCH] ShellPkg SmbiosView: Show "SocketDesignation" instead of "Socket" for Type 4

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Friday, August 5, 2016 2:02 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Chan, Amy <amy.c...@intel.com>; Ni, > Ruiyu

Re: [edk2] [Patch 3/3] ShellPkg: Correct files with CRLF line ending

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Thursday, July 28, 2016 1:46 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com> > Subject:

Re: [edk2] [PATCH 0/5] Additional fixes for the assertion removal work

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Wu, Hao A > Sent: Thursday, July 21, 2016 8:31 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject: RE:

Re: [edk2] [PATCH v3 0/5] Fix echo to display special characters

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Monday, July 18, 2016 3:10 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v3 0/5] Fix echo to display special

Re: [edk2] [PATCH] ShellPkg: Fix VS2010/2012 build failure

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bi, > Dandan > Sent: Monday, July 18, 2016 8:07 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH]

Re: [edk2] [PATCH v2 00/27] ShellPkg: Handle memory allocation failure

Patch series - Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Thursday, July 14, 2016 7:40 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2 00/27] ShellPkg:

Re: [edk2] [patch] ShellPkg: Fix issue about Ifconfig6 -r command.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, July 13, 2016 9:32 PM > To: Zhang, Lubo <lubo.zh...@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>; edk2-devel@lists.01.org > Cc: Ye,

Re: [edk2] [PATCH 08/27] ShellPkg/ConsistMapping.c: Handle memory allocation failure

> -Original Message- > From: Ni, Ruiyu > Sent: Thursday, July 14, 2016 2:30 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject: [PATCH 08/27] ShellPkg/ConsistMapping.c: Handle memory > allocation failure > Importanc

Re: [edk2] [PATCH 00/27] ShellPkg: Handle memory allocation failure

Please check copyright. I notice that at minimum EfiCompress.c and LoadPciRom need an update. I think #8 has an error. Replied to that email separately. Is it worth moving "IfConfig6FreeArgList" to a shared library? Looked like there were 2 copies... Otherwise for the series Reviewed-By:

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

12:13 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: edk2-devel-01 <edk2-de...@ml01.01.org>; Laszlo Ersek > <ler...@redhat.com>; Qiu, Shumin <shumin@intel.com> > Subject: RE: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side > effects in

Re: [edk2] [PATCH 16/16] ShellPkg: Series of patches to fix typos - apropriate to appropriate

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 07, 2016 12:48 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > <shumin@intel.co

Re: [edk2] [PATCH 06/16] StdLib: Series of patches to fix typos - availabe to available

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 07, 2016 12:48 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Daryl McDaniel li...@mc2research.org>

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

We should see why If and Else are using this different API for sure. I don't remember why. I would be happy to remove it completely if there is no objection. -Jaben > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, July 07, 2016 1:20 AM > To: Carsey, Jabe

Re: [edk2] [PATCH 1/2] Revert "ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable"

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Wednesday, July 06, 2016 9:37 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Gao, Liming

Re: [edk2] [PATCH 2/2] Revert "ShellPkg: Make the USB mouse behavior in 'edit' consistent with 'hexedit'."

Hehe... no problem. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, July 06, 2016 9:52 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject: RE: [PATCH 2/2]

Re: [edk2] StdLib usage for drivers?

Sounds good. So how about you contribute that coolness? :) > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Tim Lewis > Sent: Wednesday, July 06, 2016 2:21 PM > To: Carsey, Jaben <jaben.car...@intel.com>; af...@apple

Re: [edk2] StdLib usage for drivers?

Tim Lewis > Sent: Wednesday, July 06, 2016 2:09 PM > To: Carsey, Jaben <jaben.car...@intel.com>; af...@apple.com > Cc: edk2-devel@lists.01.org; Michael Zimmermann > <sigmaepsilo...@gmail.com>; Daryl McDaniel (edk2-li...@mc2research.org) > <edk2-li...@mc2research.

Re: [edk2] StdLib usage for drivers?

ht. Using FS0: based mapping in a driver is very scary to me. -Jaben > -Original Message- > From: Tim Lewis [mailto:tim.le...@insyde.com] > Sent: Wednesday, July 06, 2016 1:58 PM > To: Carsey, Jaben <jaben.car...@intel.com>; af...@apple.com > Cc: edk2-devel@l

Re: [edk2] StdLib usage for drivers?

.fo_mkdir= _ShellMkdir; LibC/Uefi/Devices/UefiShell/daShell.c:825: Stream->Abstraction.fo_rename = _ShellRename; LibC/Uefi/Devices/UefiShell/daShell.c:826: Stream->Abstraction.fo_lseek= _ShellSeek; From: af...@apple.com [mailto:af...@apple.com] Sent: Wednesday, July 06, 2016 1:4

Re: [edk2] StdLib usage for drivers?

you have. From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] Sent: Wednesday, July 06, 2016 1:32 PM To: Carsey, Jaben <jaben.car...@intel.com> Cc: Andrew Fish <af...@apple.com>; Marvin Häuser <marvin.haeu...@outlook.com>; edk2-devel@lists.01.org; edk2-li...@mc2resear

Re: [edk2] StdLib usage for drivers?

rvin.haeu...@outlook.com>; edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com>; edk2-li...@mc2research.org Subject: Re: [edk2] StdLib usage for drivers? Importance: High Andrew, the problem with multiple library instances is that this does only work globally and it gets in yo

Re: [edk2] [PATCH] [ShellPkg/UefiHandleParsingLib]: Fix GUID dereference

vel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > <shumin@intel.com> > Subject: [edk2] [PATCH] [ShellPkg/UefiHandleParsingLib]: Fix GUID > dereference > Importance: High > > Print's "%g" argument requires a EFI_GUID poin

Re: [edk2] [PATCH 7/7] ShellPkg-UefiShellTftpCommandLib: Replace compiler builtin

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Shi, Steven > Sent: Tuesday, June 28, 2016 8:19 AM > To: edk2-devel@lists.01.org; Gao, Liming > Cc: Kinney, Michael D

Re: [edk2] [PATCH] ShellPkg: UefiHandleParsingLib: remove tautological comparison

Reviewed-by: Jaben Carsey -Jaben > On Jun 30, 2016, at 2:05 PM, Laszlo Ersek wrote: > > The code being removed in this patch dates back to git commit a405b86d274d > (Sep 14, 2010; "udk2010.up2.shell initial release."). The condition always >

Re: [edk2] weird ShellPkg line

Odd for sure! That little block will be added to my low priority chopping queue. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Michael Zimmermann > Sent: Thursday, June 30, 2016 8:48 AM > To: Carsey, Jaben <jaben.car.

Re: [edk2] weird ShellPkg line

Zimmermann <sigmaepsilo...@gmail.com> Cc: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin <shumin@intel.com> Subject: RE: [edk2] weird ShellPkg line Importance: High Hi, yes that’s right. I found those TRUE-Asserts on various other projects as

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, June 30, 2016 4:07 AM > To: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > <shumin@intel.com> > Cc: e

Re: [edk2] [PATCH v2] ShellPkg: Fix 'echo' cannot display the special characters correctly.

Very nice. I like this much more. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> Ray, what do you think? -Jaben > -Original Message- > From: Qiu, Shumin > Sent: Wednesday, June 22, 2016 1:51 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@i

Re: [edk2] [PATCH] ShellPkg: Fix 'echo' cannot display the special characters correctly.

ecial handle in ParseCommandLineToArgs for ‘echo’ command. -Shumin From: Carsey, Jaben Sent: Tuesday, June 21, 2016 10:56 PM To: Qiu, Shumin; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> Cc: Ni, Ruiyu; Carsey, Jaben Subject: RE: [PATCH] ShellPkg: Fix 'echo' cannot display the special cha

Re: [edk2] [PATCH] ShellPkg: Fix 'echo' cannot display the special characters correctly.

21, 2016 7:47 AM To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com> Subject: RE: [PATCH] ShellPkg: Fix 'echo' cannot display the special characters correctly. Importance: High Hi Jaben, 'echo' should not use ShellParameterProtoc

Re: [edk2] [PATCH] ShellPkg: Fix 'echo' cannot display the special characters correctly.

Maybe then we should add an API to ShellCommandLib to get the raw command line? From: Qiu, Shumin Sent: Tuesday, June 21, 2016 7:55 AM To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com> Subject: RE: [PATCH] ShellPkg: Fix 'echo' ca

Re: [edk2] [PATCH] ShellPkg: Fix 'echo' cannot display the special characters correctly.

ndStatus != NULL) { > + *CommandStatus = Status; From: Qiu, Shumin Sent: Monday, June 20, 2016 8:21 PM To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com> Subject: RE: [PATCH] ShellPkg: Fix 'echo' cannot display the special cha

Re: [edk2] [PATCH] ShellPkg: Fix 'echo' cannot display the special characters correctly.

, 2016 12:30 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> > Subject: [PATCH] ShellPkg: Fix 'echo' cannot display the special characters > correctly. > Importanc

Re: [edk2] [PATCH v2 0/2] ShellPkg: Use ".." to indicate device path is partially displayed

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, June 17, 2016 2:22 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-de...@ml01.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject: Re: [edk2] [PATCH v2 0/2] ShellPk

Re: [edk2] [PATCH] ShellPkg/UefiHandleParsing: Show handle's loaded image device path

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Friday, June 17, 2016 12:59 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > <shumin@intel.com> > Subj

Re: [edk2] [PATCH v2 0/2] ShellPkg: Use ".." to indicate device path is partially displayed

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Wednesday, June 15, 2016 8:20 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2 0/2] ShellPkg: Use ".." to

Re: [edk2] [PATCH 0/8] Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr

t;; Kinney, Michael D <michael.d.kin...@intel.com>; > Dong, Eric <eric.d...@intel.com>; Tian, Feng <feng.t...@intel.com>; Ni, > Ruiyu <ruiyu...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin > <jiaxin...@intel.com>; Carsey, Jaben <jaben.car...

Re: [edk2] [PATCH V2 0/3] Remove TimerLib dependency from DP

com>; Zeng, Star <star.z...@intel.com>; > edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Gao, Liming > <liming@intel.com> > Subject: Re: [edk2] [PATCH V2 0/3] Remove TimerLib dependency from DP > Importance: High > > Series reviewed b

[edk2] propose 3 new UserExtensions in the INF specification

All, I would like to propose 3 new UserExtensions in the INF specification. These would be optional sections that can be used to convey additional information about the module. This additional meta data is not expected to be used by the build. This is used by additional tools to help verify

Re: [edk2] [PATCH V2 2/3] PerformancePkg Dp_App: Remove TimerLib dependency

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Wednesday, June 08, 2016 3:24 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car

Re: [edk2] [PATCH V2 3/3] ShellPkg UefiDpLib: Remove TimerLib dependency

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Wednesday, June 08, 2016 3:24 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com>; Yao, Jiewen > <jiewen@intel.com>; Cinnamon Sh

Re: [edk2] [PATCH] MdePkg/BaseLib: Add 2 more safe string functions.

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiewen Yao > Sent: Thursday, June 02, 2016 7:39 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Yao,

Re: [edk2] Memory Consumption after BLT (GOP)

-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Rafael Machado > Sent: Wednesday, June 01, 2016 10:33 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] Memory Consumption after BLT (GOP) > Importance: High > > The

Re: [edk2] StdLib for EFI DRIVER type

StdLib also supports apps not in the shell environment. You can certainly port many the APIs to work for drivers. The goal of StdLib is to support existing applications being moved to UEFI environment. That does not really apply to drivers. What is the issue that you are finding a StdLib

Re: [edk2] [PATCH v1 1/1] ShellPkg/App: Fix memory leak and save resources.

Marvin, I will review your patches this week. -Jaben > -Original Message- > From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] > Sent: Thursday, May 19, 2016 1:20 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject:

Re: [edk2] [PATCH v1 1/1] ShellPkg/App: Fix memory leak and save resources.

Can we safely remove the ASSERt now? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marvin Häuser > Sent: Thursday, May 19, 2016 12:04 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>

Re: [edk2] System Table and more

Those pointers are dependent on library constructors from associated libraries. You need to correctly include the library to make them function. The table pointer in your module's entry point should always be valid though. -Jaben > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

unhelpful. I like return values way more than I do asserts. The same way we have libraries in EDKII that have constructors and no destructors which means they are risky and potentially useless for any code that must support unload. -Jaben > On May 18, 2016, at 9:57 AM, Carsey, Jaben <jab

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

rom: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Carsey, Jaben > Sent: Wednesday, May 18, 2016 11:25 AM > To: Palmer, Thomas <thomas.pal...@hpe.com>; jim_dai...@dell.com; > edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com&g

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

> -Original Message- > From: Palmer, Thomas [mailto:thomas.pal...@hpe.com] > Sent: Wednesday, May 18, 2016 9:21 AM > To: jim_dai...@dell.com; Carsey, Jaben <jaben.car...@intel.com>; edk2- > de...@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Thomas Palmer > Sent: Wednesday, May 18, 2016 9:01 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Yao, Jiewen > ; Gao, Liming

Re: [edk2] [Patch] Use a local variable to cache the pointer.

Amended for commit. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jordan Justen > Sent: Thursday, May 12, 2016 3:20 PM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org > Cc: Qiu, Shumin <shum

Re: [edk2] [Patch] ShellPkg: Add argument to set block size for tftp command.

Why write the function UintnToAscDec to convert UINTN to ascii string? PrintLib can do that for you. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Fu, Siyuan > Sent: Thursday, May 05, 2016 7:33 PM > To: edk2-devel@lists.01.org &

Re: [edk2] [PATCH] ShellPkg: Remove debug message in release binaries.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Wednesday, May 04, 2016 11:05 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com> >

Re: [edk2] [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer library instance error!"

Thanks! > -Original Message- > From: Zeng, Star > Sent: Monday, May 02, 2016 9:39 PM > To: Carsey, Jaben <jaben.car...@intel.com>; Cinnamon Shia > <cinnamon.s...@hpe.com>; edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin@intel.com>; samer.el-haj-m

Re: [edk2] [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer library instance error!"

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Monday, May 02, 2016 1:25 AM > To: Cinnamon Shia <cinnamon.s...@hpe.com>; edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin@intel.com>; Carsey, Jaben >

Re: [edk2] [PATCH] PerformancePkg Dp_App: Delete InitCumulativeData()

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Shia, Cinnamon [mailto:cinnamon.s...@hpe.com] > Sent: Monday, May 02, 2016 2:23 AM > To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.

Re: [edk2] [PATCH] ShellPkg UefiDpLib: Delete one comment introduced by 196ccda08fc4

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Shia, Cinnamon > Sent: Monday, May 02, 2016 2:23 AM > To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists

Re: [edk2] [RFC] MdeModulePkg, ShellPkg: increase TFTP block size

I missed that the default was from the RFC. I agree with you. -Jaben > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Friday, April 29, 2016 11:00 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: Marcin Wojtas <m...@s

[edk2] [review]Please review changes to UNI file format document

Updated UNI spec to remove info specific to some consumers, not format. Updated UNI spec to allow non-ascii characters in strings. Cc: Qiu Shumin > Cc: Erik Bjorge Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer library instance error!"

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Thursday, April 28, 2016 7:42 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car

Re: [edk2] [PATCH 2/2] PerformancePkg/Dp_App: Fix the error message "Timer library instance error!"

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Thursday, April 28, 2016 7:42 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car

Re: [edk2] [RFC] MdeModulePkg, ShellPkg: increase TFTP block size

Maybe we should have a PCD control the default value so that people who build it can set it as per their own best value. Adding a parameter seems like a great (but separate) solution. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of

Re: [edk2] accessing IP info. set using ifconfig shell command in EFI application.

You could look at the source code for that command since you know that does what you want. It's located here: ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > devendra rawat > Sent:

Re: [edk2] [PATCH 1/3] MdeModulePkg: PiDxeS3BootScriptLib: honor PcdAcpiS3Enable

<jaben.car...@intel.com> > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, April 27, 2016 1:12 PM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel-01 de...@ml01.01.org> > Cc: Ni, Ruiyu <ruiyu...@intel.com&g

Re: [edk2] [PATCH] ShellPkg: Fix pci command for '_e' option

Done. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Attar, Abdul Lateef > Sent: Tuesday, April 26, 2016 3:42 AM > To: Qiu, Shumin <shumin@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>; Ni, Ruiyu &l

Re: [edk2] [PATCH 1/3] MdeModulePkg: PiDxeS3BootScriptLib: honor PcdAcpiS3Enable

Laszlo, Does the library destructor not get called? Shouldn't that destructor unregister the protocol notify and leave the callback pointer in DXE core correct? -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent:

Re: [edk2] [PATCH] ShellPkg: Fix typos and EDK2 coding style issues

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El- > Haj-Mahmoud, Samer > Sent: Wednesday, April 27, 2016 8:11 AM > To: Shah, Tapan <tapands...@hpe.com>; edk2-deve

<    1   2   3   4   5   6   7   >