Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2011-05-10 Thread Andrea Aime
On Tue, May 10, 2011 at 3:22 AM, Ben Caradoc-Davies ben.caradoc-dav...@csiro.au wrote: +1. Some things are hard to test (GUI, network [e.g. JDBC]), so rather than an absolute rule for for all modules, those falling below 40% for offline tests may have to refer to online tests or special

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2011-05-10 Thread Andrea Aime
On Mon, May 9, 2011 at 10:56 AM, Ben Caradoc-Davies ben.caradoc-dav...@csiro.au wrote: Aha: I found my canonical source for the 40% threshold: Andrea. :-) On 18/05/10 16:02, Ben Caradoc-Davies wrote: All the docs and much of the test coverage is in GeoServer. Ah, much of the test coverage

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2011-05-09 Thread Ben Caradoc-Davies
Aha: I found my canonical source for the 40% threshold: Andrea. :-) On 18/05/10 16:02, Ben Caradoc-Davies wrote: All the docs and much of the test coverage is in GeoServer. Ah, much of the test coverage where it cannot be measured... ugh... does it go beyond 40% with the tests in Geotools? --

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2011-05-09 Thread Jody Garnett
Given that Andrea is the source of all truth (or was it the Pope? someone in italy). Could we make a motion to update the developers guide with a consistent target of 40%? -- Jody Garnett On Monday, 9 May 2011 at 6:56 PM, Ben Caradoc-Davies wrote: Aha: I found my canonical source for the

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2011-05-09 Thread Michael Bedward
On 9 May 2011 20:18, Jody Garnett jody.garn...@gmail.com wrote: Could we make a motion to update the developers guide with a consistent target of 40%? It should be 42 Michael -- WhatsUp Gold - Download Free Network

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2011-05-09 Thread Jody Garnett
Okay I will say +1 to that :-) Seriously we are supposed to follow the change procedure to make modifications to the developers guide; in this case where it is inconsistent I would like to just do a patch. -- Jody Garnett On Monday, 9 May 2011 at 9:03 PM, Michael Bedward wrote: On 9 May

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2011-05-09 Thread Ben Caradoc-Davies
+1. Some things are hard to test (GUI, network [e.g. JDBC]), so rather than an absolute rule for for all modules, those falling below 40% for offline tests may have to refer to online tests or special pleading. Some modules have low coverage in their own tests but are massively covered by

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2010-05-18 Thread Andrea Aime
Ben Caradoc-Davies ha scritto: The GeoTools module gt-app-schema has now been included in GeoServer releases since October 2009. I propose to promote it (and the proposed gt-app-schema-resolver) to extension. The old unsupported/app-schema will remain to house gt-webservice and other

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2010-05-18 Thread Ben Caradoc-Davies
On 18/05/10 14:38, Andrea Aime wrote: How is the test coverage? OK. All encoding test are in GeoServer. Is it a single module or multimodule? Multiple. gt-app-schema, gt-app-schema-resolver (coming soon), gt-sample-data-access (for testing). You are the maintainer for all of them? Yes.

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2010-05-18 Thread Andrea Aime
Ben Caradoc-Davies ha scritto: On 18/05/10 14:38, Andrea Aime wrote: How is the test coverage? OK. All encoding test are in GeoServer. Is it a single module or multimodule? Multiple. gt-app-schema, gt-app-schema-resolver (coming soon), gt-sample-data-access (for testing). You are

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2010-05-18 Thread Ben Caradoc-Davies
On 18/05/10 16:11, Andrea Aime wrote: Ok, this goes against the graduation rules, you don't have the necessary testing coverage. So, I thought, why am I waving my hands when I should be measuring the coverage? Turns out it is much better than I thought (gt-app-schema on trunk, before

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2010-05-18 Thread Jody Garnett
I view this as one of the stars we use to evaluate things (ie things we care about as a community) rather then a complete down check. The fact that the coverage is being checked with a nightly build somewhere means that any incidental breakage will be found out quickly right? We do not demand

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2010-05-18 Thread Andrea Aime
Jody Garnett ha scritto: I view this as one of the stars we use to evaluate things (ie things we care about as a community) rather then a complete down check. The fact that the coverage is being checked with a nightly build somewhere means that any incidental breakage will be found out

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2010-05-18 Thread Jody Garnett
On 18/05/2010, at 10:44 PM, Andrea Aime wrote: Jody Garnett ha scritto: check. The fact that the coverage is being checked with a nightly build somewhere means that any incidental breakage will be found out quickly right? Coverage being checked nightly? This is news to me. I though he

[Geotools-devel] Proposal: move app-schema from unsupported to extension

2010-05-17 Thread Ben Caradoc-Davies
The GeoTools module gt-app-schema has now been included in GeoServer releases since October 2009. I propose to promote it (and the proposed gt-app-schema-resolver) to extension. The old unsupported/app-schema will remain to house gt-webservice and other unreleased code. gt-app-schema is

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2010-05-17 Thread Jody Garnett
Exciting Ben, We do ask that one page be available in the geotools user guide; even if it just links off to docs you have written in geoserver. Any of my other questions can be answered as you fill in the pages you already found: - code coverage - review.apt - documentation - etc... Should we

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2010-05-17 Thread Michael Bedward
On 18 May 2010 11:46, Jody Garnett wrote: indeed there may be some overlap with recent work Micheal was doing. Me ? Michael -- ___ Geotools-devel mailing list

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2010-05-17 Thread Jody Garnett
You. Reni had worked on some of the symbology encoding functions earlier; and they were used as a base for some of the mapping functions. One I did with her involved reading in a property for (or csv file?) and the function would look up a value in the file ... The same approach could be used

Re: [Geotools-devel] Proposal: move app-schema from unsupported to extension

2010-05-17 Thread Michael Bedward
On 18 May 2010 12:47, Jody Garnett wrote: You. Reni had worked on some of the symbology encoding functions earlier; and they were used as a base for some of the mapping functions. One I did with her involved reading in a property for (or csv file?) and the function would look up a value