[gwt-contrib] Re: PatternValidator matches the whole input string. (issue1378801)

LGTM. It is strange that the pattern has to match the whole string. I would have expected for the developer to be in control of that by using "^" and "$" as needed. http://gwt-code-reviews.appspot.com/1378801/diff/1/user/src/com/google/gwt/validation/client/constraints/PatternValidator.java File

[gwt-contrib] Re: WebAppCreator now has the ability to create apps from templates. (issue1371808)

Submitted as of r9819 http://gwt-code-reviews.appspot.com/1371808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: WebAppCreator now has the ability to create apps from templates. (issue1371808)

http://gwt-code-reviews.appspot.com/1371808/diff/1003/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/client/_moduleShortName_.javasrc File user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/client/_moduleShortName_.javasrc (right): http

[gwt-contrib] Re: WebAppCreator now has the ability to create apps from templates. (issue1371808)

http://gwt-code-reviews.appspot.com/1371808/diff/1/user/src/com/google/gwt/user/tools/WebAppCreator.java File user/src/com/google/gwt/user/tools/WebAppCreator.java (right): http://gwt-code-reviews.appspot.com/1371808/diff/1/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode154 user/sr

[gwt-contrib] Re: WebAppCreator now has the ability to create apps from templates. (issue1371808)

http://gwt-code-reviews.appspot.com/1371808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] WebAppCreator now has the ability to create apps from templates. (issue1371808)

Reviewers: jlabanca, pdr, jwren, Description: WebAppCreator now has the ability to create apps from templates. It can also mix different templates to generate the sample app based on the value passed with a '-templates' parameter. The sample app has now been separated into five templates: - The

[gwt-contrib] Re: Adding a constructor overload to CellTable that takes a loading indicator widget. For legacy sup... (issue1371805)

LGTM http://gwt-code-reviews.appspot.com/1371805/diff/3002/user/src/com/google/gwt/user/cellview/client/CellTable.java File user/src/com/google/gwt/user/cellview/client/CellTable.java (right): http://gwt-code-reviews.appspot.com/1371805/diff/3002/user/src/com/google/gwt/user/cellview/client/Cel

[gwt-contrib] Re: To prevent infinite loops, the Bean Validation implementation must ignore (issue1367802)

LGTM On 2011/03/01 05:40:57, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1367802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Only validate a constraint annotation once. (issue1373802)

LGTM http://gwt-code-reviews.appspot.com/1373802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove @Override for JDK 1.5 compliance. (issue1370802)

LGTM On 2011/02/28 19:03:00, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1370802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Select the correct constraint validator (issue1368801)

LGTM with unrelated nit. http://gwt-code-reviews.appspot.com/1368801/diff/2002/user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java File user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java (right): http://gwt-code-reviews.appspot.com/1368801/diff

[gwt-contrib] Re: Select the correct constraint validator (issue1368801)

LGTM with unrelated nit. On 2011/02/28 07:01:18, Nick Chalko wrote: PTALN http://gwt-code-reviews.appspot.com/1368801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Report ValidationExceptions at compile time for constrained methods (issue1354807)

LGTM with nits. http://gwt-code-reviews.appspot.com/1354807/diff/10/5001 File user/src/com/google/gwt/validation/rebind/BeanHelper.java (right): http://gwt-code-reviews.appspot.com/1354807/diff/10/5001#newcode52 user/src/com/google/gwt/validation/rebind/BeanHelper.java:52: public static final F

[gwt-contrib] Re: Changes the distributed eclipse .launch files to use DevMode instead of HostedMode. (issue1352808)

LGTM++ http://gwt-code-reviews.appspot.com/1352808/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing insert/remove bugs in StackLayoutPanel. Insert always appends to the end. Remove does n... (issue1359803)

LGTM On 2011/02/17 15:56:46, jlabanca wrote: http://gwt-code-reviews.appspot.com/1359803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added validation jars to 'devmode' and 'test.dev' targets in ant webAppCreator templates (issue1352807)

Submitted as of r9736 http://gwt-code-reviews.appspot.com/1352807/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Added validation jars to 'devmode' and 'test.dev' targets in ant webAppCreator templates (issue1352807)

Reviewers: rjrjr, Nick Chalko, Description: Added validation jars to 'devmode' and 'test.dev' targets in ant webAppCreator templates Fixes Issue 5950. Please review this at http://gwt-code-reviews.appspot.com/1352807/show Affected files: M user/src/com/google/gwt/user/tools/project.ant.xmlsr

[gwt-contrib] Re: Added validation jars to all calls to GWTC to provide classes rquired by (issue1342803)

ping On 2011/02/09 15:23:23, rchandia wrote: On 2011/02/08 19:02:29, rjrjr wrote: > Don't you need to make the same changes to samples/expenses/pom.xml? Done. http://gwt-code-reviews.appspot.com/1342803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added missing validation jars to gwt-user.jar. Fixes Issue 5950. (issue1323803)

ping On 2011/02/09 15:22:04, rchandia wrote: Removed the hibernate validation implementation as it is not necessary. I guess we need to decide between adding stuff to gwt-user.jar with this approach or to add the respective jars to each gwtc invocation as in: http://gwt-code

[gwt-contrib] Re: Sort the top level validator class to handle most specific classes first. (issue1346804)

LGTM http://gwt-code-reviews.appspot.com/1346804/diff/1/5 File user/test/org/hibernate/jsr303/tck/tests/constraints/constraintcomposition/TckTestValidatorFactory.java (right): http://gwt-code-reviews.appspot.com/1346804/diff/1/5#newcode37 user/test/org/hibernate/jsr303/tck/tests/constraints/con

[gwt-contrib] Re: Fix TestUtil.PathImpl to correctly test for non matching (issue1352801)

LGTM http://gwt-code-reviews.appspot.com/1352801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added validation jars to all calls to GWTC to provide classes rquired by (issue1342803)

On 2011/02/08 19:02:29, rjrjr wrote: Don't you need to make the same changes to samples/expenses/pom.xml? Done. http://gwt-code-reviews.appspot.com/1342803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added missing validation jars to gwt-user.jar. Fixes Issue 5950. (issue1323803)

, rchandia wrote: http://gwt-code-reviews.appspot.com/1323803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added missing validation jars to gwt-user.jar. Fixes Issue 5950. (issue1323803)

http://gwt-code-reviews.appspot.com/1323803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added validation jars to all calls to GWTC to provide classes rquired by (issue1342803)

http://gwt-code-reviews.appspot.com/1342803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added validation jars to all calls to GWTC to provide classes rquired by (issue1342803)

On 2011/02/08 18:36:31, rjrjr wrote: webAppCreator generates a pom.xml? When did that start happening? Somewhere before GWT 2.1 for Google I/O 2010. Added at revision r8234: http://code.google.com/p/google-web-toolkit/source/detail?spec=svn9690&r=8234 http://gwt-code-reviews.appspot.com/1342

[gwt-contrib] Re: Added validation jars to all calls to GWTC to provide classes rquired by (issue1342803)

On 2011/02/07 23:01:25, drfibonacci wrote: From a maven perspective, this is a much better solution than bundling validation classes in gwt-user.jar. However, will the changes to .classpathsrc and/or the gwtc ant target affect the GWT compiler when called from the maven plugin? Nothing in t

[gwt-contrib] Re: Undeprecating DockPanel because it is still useful and fulfills a purpose that DockLayoutPanel c... (issue1346802)

On 2011/02/08 13:51:09, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/1346802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Turn off a test because of issue 5882. (issue1344801)

LGTM On 2011/02/07 21:03:48, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1344801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Added validation jars to all calls to GWTC to provide classes rquired by (issue1342803)

Reviewers: rjrjr, Nick Chalko, drfibonacci, Description: Added validation jars to all calls to GWTC to provide classes rquired by client-side validation. Fixes Issue 5950. Please review this at http://gwt-code-reviews.appspot.com/1342803/show Affected files: M distro-source/build.xml M sam

[gwt-contrib] Re: Handle Validation of Cascaded Generic properties. (issue1343801)

LGTM, with nits http://gwt-code-reviews.appspot.com/1343801/diff/1/8 File user/src/com/google/gwt/validation/rebind/Util.java (right): http://gwt-code-reviews.appspot.com/1343801/diff/1/8#newcode93 user/src/com/google/gwt/validation/rebind/Util.java:93: * @return Remove empty tags http://gwt-c

[gwt-contrib] Added missing validation jars to gwt-user.jar. Fixes Issue 5950. (issue1323803)

Reviewers: rjrjr, Nick Chalko, Description: Added missing validation jars to gwt-user.jar. Fixes Issue 5950. Please review this at http://gwt-code-reviews.appspot.com/1323803/show Affected files: M user/build.xml Index: user/build.xml ===

[gwt-contrib] Re: Add test org.hibernate.jsr303.tck.tests.validation.graphnavigation.GraphNavigationGwtTest (issue1332801)

LGTM On 2011/01/27 20:44:18, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1332801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Warn users of JRE 1.5 that their days are numbered (issue1328802)

LGTM On 2011/01/27 04:48:37, bobv wrote: LGTM http://gwt-code-reviews.appspot.com/1328802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Turn off test that is failing in IE (issue1285802)

LGTM On 2011/01/26 18:51:16, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1285802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix NPE in samples/expenses (issue1326801)

LGTM On 2011/01/26 16:50:26, rjrjr wrote: http://gwt-code-reviews.appspot.com/1326801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix NPE in samples/expenses (issue1326801)

LGTM On 2011/01/26 05:55:35, drfibonacci wrote: LGTM http://gwt-code-reviews.appspot.com/1326801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add more TCK tests (issue1298802)

LGTM On 2011/01/26 06:42:12, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1298802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing a bug in CellBrowser where the user must click on an element twice to focus on it and ena... (issue1290803)

LGTM On 2011/01/25 22:20:56, jlabanca wrote: http://gwt-code-reviews.appspot.com/1290803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updates DTRF to show the use of ServiceLocators and Locators. (issue1299801)

Submitted as of r9609 On 2011/01/25 18:39:13, rchandia wrote: http://gwt-code-reviews.appspot.com/1299801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updates DTRF to show the use of ServiceLocators and Locators. (issue1299801)

http://gwt-code-reviews.appspot.com/1299801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: If some unrecoverable failure happens during validation, a ValidationException is raised. (issue1295803)

LGTM On 2011/01/25 14:21:45, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1295803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Throw an IllegalErgumentException if the property name is invalid. (issue1287802)

LGTM. With nits. http://gwt-code-reviews.appspot.com/1287802/diff/1/2 File user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java (right): http://gwt-code-reviews.appspot.com/1287802/diff/1/2#newcode91 user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.jav

[gwt-contrib] Re: Updates DTRF to show the use of ServiceLocators and Locators. (issue1299801)

http://gwt-code-reviews.appspot.com/1299801/diff/1/2 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/PersonEditor.java (right): http://gwt-code-reviews.appspot.com/1299801/diff/1/2#newcode59 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/Pe

[gwt-contrib] Re: Updates DTRF to show the use of ServiceLocators and Locators. (issue1299801)

http://gwt-code-reviews.appspot.com/1299801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Include class level constraints in the BeanDescriptor. (issue1319801)

LGTM. Wit nits. http://gwt-code-reviews.appspot.com/1319801/diff/1/3 File user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java (right): http://gwt-code-reviews.appspot.com/1319801/diff/1/3#newcode499 user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.jav

[gwt-contrib] Re: Turn on the null groups tests, now the gwt null varargs bug is fixed. (issue1288803)

LGTM On 2011/01/20 05:31:31, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1288803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Implement spec section 2.2. Applying multiple constraints of the same type. (issue1288802)

LGTM. With nits http://gwt-code-reviews.appspot.com/1288802/diff/3001/4001 File user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java (right): http://gwt-code-reviews.appspot.com/1288802/diff/3001/4001#newcode82 user/src/com/google/gwt/validation/rebind/GwtSpecificValidator

[gwt-contrib] Re: Removes a Java 1.6-ism. (issue1304801)

Submitted as of r9563 On 2011/01/18 19:23:21, knorton wrote: lgtm. thanks. http://gwt-code-reviews.appspot.com/1304801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Removes a Java 1.6-ism. (issue1304801)

Reviewers: knorton, Description: Removes a Java 1.6-ism. Please review this at http://gwt-code-reviews.appspot.com/1304801/show Affected files: M user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java Index: user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTes

[gwt-contrib] Re: Mark some test as Failing. Note these test only fail on IE. (issue1303801)

LGTM On 2011/01/18 18:35:52, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1303801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Updates DTRF to show the use of ServiceLocators and Locators. (issue1299801)

Reviewers: rjrjr, Description: Updates DTRF to show the use of ServiceLocators and Locators. - Added editors to modify person schedules - Schedule is now a RF Entity and TimeSlot is now a VO - ScheduleLocator interfaces with "non standard" getKey and getRevision methods - ScheduleService provides

[gwt-contrib] Re: Add a @TestNotCompatible for tests where the test code is not GWT compatible. (issue1298801)

LGTM On 2011/01/17 22:53:06, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1298801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Match Classes to validate in the order specified in the GwtValidaiton (issue1294802)

LGTM On 2011/01/17 20:28:44, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1294802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Move the TCK report task to user/build.xml and (issue1288801)

LGTM http://gwt-code-reviews.appspot.com/1288801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix a generics compile error on OSX java 1.6 (issue1289801)

Submitted as of r9550 On 2011/01/14 17:19:46, Nick Chalko wrote: Bug report http://code.google.com/p/google-web-toolkit/issues/detail?id=5876 http://gwt-code-reviews.appspot.com/1289801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Move the TCK report task to user/build.xml and (issue1288801)

I do not think moving countMarkedTests.sh into the build is a good idea. Would you mind leaving the script out until there is a platform agnostic alternative? On 2011/01/14 00:47:40, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1288801/show -- http://groups.google.com/group/Google-

[gwt-contrib] Re: Fix a generics compile error on OSX java 1.6 (issue1289801)

LGTM On 2011/01/14 01:17:55, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1289801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Handle validation of cascaded Arrays, Iterables and Maps. (issue1282801)

LGTM. with nits http://gwt-code-reviews.appspot.com/1282801/diff/1/4 File user/src/com/google/gwt/validation/client/impl/PathImpl.java (right): http://gwt-code-reviews.appspot.com/1282801/diff/1/4#newcode44 user/src/com/google/gwt/validation/client/impl/PathImpl.java:44: nodes.addAll(originalPa

[gwt-contrib] Re: Move all TCK test to users/test so they are run by the continuos build. (issue1267801)

/application/TckTest.gwt.xml:22: Oh, I've got you now. On 2011/01/12 00:49:55, Nick Chalko wrote: On 2011/01/11 19:02:46, rchandia wrote: > These includes and excludes should not be necessary I am explicitly only including java files in this package not subpackages. http://gwt-code-reviews.app

[gwt-contrib] Re: Move all TCK test to users/test so they are run by the continuos build. (issue1267801)

The module definitions need some more work now that the super source files are in test-super http://gwt-code-reviews.appspot.com/1267801/diff/10001/11106 File user/test/org/hibernate/jsr303/tck/tests/constraints/application/TckTest.gwt.xml (right): http://gwt-code-reviews.appspot.com/1267801/di

[gwt-contrib] Re: Move all TCK test to users/test so they are run by the continuos build. (issue1267801)

http://gwt-code-reviews.appspot.com/1267801/diff/3001/4077 File user/build.xml (right): http://gwt-code-reviews.appspot.com/1267801/diff/3001/4077#newcode128 user/build.xml:128: http://gwt-code-reviews.appspot.com/1267801/diff/3001/4089 File user/test/org/hibernate/jsr303/tck/Jsr303Tck.gwt.xml (

[gwt-contrib] Re: Test the type of a value before casting it. (issue1261801)

Sorry, forgot to send the the nits. http://gwt-code-reviews.appspot.com/1261801/diff/1/6 File samples/validationtck/test/org/hibernate/jsr303/tck/tests/validation/ValidateValueGwtTest.java (right): http://gwt-code-reviews.appspot.com/1261801/diff/1/6#newcode66 samples/validationtck/test/org/hib

[gwt-contrib] Re: Test the type of a value before casting it. (issue1261801)

LGTM. With nits. On 2011/01/06 00:28:40, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1261801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Move all tests to org/hibernate/jsr303/tck (issue1255801)

LGTM On 2011/01/05 06:49:29, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1255801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Patch MethodBinding.collectMissingTypes for IOOBE (issue1252801)

LGTM On 2011/01/04 17:11:31, conroy wrote: http://gwt-code-reviews.appspot.com/1252801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Mark test as Failing or NotSupported (issue1245801)

LGTM On 2011/01/03 05:09:04, Nick Chalko wrote: Take a look again when you are back from Vacation. http://gwt-code-reviews.appspot.com/1245801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Mark test as Failing or NotSupported (issue1245801)

http://gwt-code-reviews.appspot.com/1245801/diff/1/2 File samples/validationtck/build.xml (right): http://gwt-code-reviews.appspot.com/1245801/diff/1/2#newcode140 samples/validationtck/build.xml:140: executable="${basedir}/countMarkedTests.sh" I think this breaks support for non-unix users. htt

[gwt-contrib] Re: Use instanceof to find the right top level GwtSpecificValidator. (issue1239802)

LGTM On 2010/12/23 04:39:40, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1239802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix an NPE in SimpleRequestProcessor when a client request has no invocations. (issue1242801)

LGTM On 2010/12/22 16:37:51, bobv wrote: http://gwt-code-reviews.appspot.com/1242801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Select the correct ConstraintValidator for the bean type. (issue1238801)

LGTM On 2010/12/21 01:20:30, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1238801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Move all the TCK to the test dir in preparation for (issue1239801)

LGTM. Notice that in user/ supersource goes into user/super and supersource tests go into user/test-super. On 2010/12/21 04:26:56, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1239801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Basic MessageIntrpolation. (issue1230801)

LGTM On 2010/12/20 22:10:00, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1230801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Basic MessageIntrpolation. (issue1230801)

Patch set 1 contains a number of unreplied comments. On 2010/12/20 20:41:11, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1230801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: beanType is a Class, no need to call getClass to compare it to a class. (issue1233801)

LGTM On 2010/12/19 08:34:31, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1233801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the property name to the path. (issue1233802)

LGTM On 2010/12/19 08:52:36, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1233802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Basic MessageIntrpolation. (issue1230801)

http://gwt-code-reviews.appspot.com/1230801/diff/1/3 File samples/validation/ValidationMesssges-i18n (right): http://gwt-code-reviews.appspot.com/1230801/diff/1/3#newcode1 samples/validation/ValidationMesssges-i18n:1: #!/bin/sh I think this file does not need to be committed. http://gwt-code-re

[gwt-contrib] Re: Handle composite constraints. (issue1231801)

LGTM On 2010/12/17 19:43:44, Nick Chalko wrote: On Fri, Dec 17, 2010 at 8:52 AM, wrote: > Compiling the validation sample (with ant) produces the following > warning (is that intended?): > > [java] [WARN] No ConstraintValidator of > > Constr

[gwt-contrib] Re: Handle composite constraints. (issue1231801)

Compiling the validation sample (with ant) produces the following warning (is that intended?): [java] [WARN] No ConstraintValidator of ConstraintDescriptorImpl{annotation=com.google.gwt.sample.validation.shared.Zip, payloads=[], hasComposingConstraints=false, isReportAsSing

[gwt-contrib] Re: Public: GWT emulation for the normal Validation Bootstrap. (issue1208801)

LGTM. With JavaDoc nits. http://gwt-code-reviews.appspot.com/1208801/diff/3001/4002 File samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4002#newcode34 samples/validation/src/com/google/gwt/sample

[gwt-contrib] Re: Public: Generate BeanDescriptors for GWT Validation. (issue1212801)

LGTM On 2010/12/11 00:38:11, Nick Chalko wrote: [JSR 303 TCK Result] 31 of 258 (12.02%) Pass with 10 Failures and 13 Errors. http://gwt-code-reviews.appspot.com/1212801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes rebased guava library without using JarJar (issue1213801)

Submitted as of r9412 On 2010/12/13 21:22:20, rice wrote: LGTM http://gwt-code-reviews.appspot.com/1213801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Ensure that primitive values can be used as RequestFactory proxy properties. (issue1216801)

LGTM http://gwt-code-reviews.appspot.com/1216801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fixes rebased guava library without using JarJar (issue1213801)

Reviewers: rice, Description: Fixes rebased guava library without using JarJar Fixes Issue http://code.google.com/p/google-web-toolkit/issues/detail?id=5708 Review by: r...@google.com Please review this at http://gwt-code-reviews.appspot.com/1213801/show Affected files: M dev/build.xml Ind

[gwt-contrib] Re: Removing call to RootLayoutPanel#get() in SplitLayoutPanel so that it does not force the creatio... (issue1210801)

LGTM http://gwt-code-reviews.appspot.com/1210801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: Use jsni to access private fields and methods. (issue1206801)

LGTM On 2010/12/10 00:24:23, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1206801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: Use jsni to access private fields and methods. (issue1206801)

LGTM except for checkstyle errors. http://gwt-code-reviews.appspot.com/1206801/diff/1/2 File samples/validation/src/com/google/gwt/sample/validation/shared/Person.java (right): http://gwt-code-reviews.appspot.com/1206801/diff/1/2#newcode38 samples/validation/src/com/google/gwt/sample/validation

[gwt-contrib] Re: Public: Check constraints against the field or property that has the actual annotation. (issue1185801)

LGTM. With nits. http://gwt-code-reviews.appspot.com/1185801/diff/1/3 File samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/ValidationRequirementTest.java (right): http://gwt-code-reviews.appspot.com/1185801/diff/1/3#newcode53 samples/validationtck/test/com

[gwt-contrib] Re: Fixes two issues (issue1181802)

urn Double.valueOf(object.toString()); > > + return > Math.rint(NumberFormat.getDecimalFormat().parse(object.toString())); > } catch (NumberFormatException e) { > throw new ParseException(e.getMessage(), 0); > } > > On 2010/12/02 22:45:38, rchan

[gwt-contrib] Re: Fixes two issues (issue1181802)

This is actually a repost of tboryer's patch originally submitted at: http://gwt-code-reviews.appspot.com/1181802 On 2010/12/02 22:33:23, rchandia wrote: http://gwt-code-reviews.appspot.com/1181802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 5663: DoubleParser rounds values to integers (issue1170801)

Re posting as http://gwt-code-reviews.appspot.com/1181802 Ovet there I changed the test to use 123.5 to avoid roundoff issues. On 2010/12/01 16:55:56, jat wrote: On Wed, Dec 1, 2010 at 11:52 AM, Ray Ryan wrote: > I'll get it in today, thanks very much for the patch.

[gwt-contrib] Fixes two issues (issue1181802)

Reviewers: conroy, rjrjr, jat, tbroyer, Description: Fixes two issues Issue 5460: Scaffold app expenses does not store decimal values Issue 5663: DoubleParser rounds values to integers Thanks to t.bro...@gmail.com Please review this at http://gwt-code-reviews.appspot.com/1181802/show Affected

[gwt-contrib] Re: Remove a couple of JDK 1.6-isms (issue1178801)

LGTM On 2010/12/02 16:30:32, rice wrote: http://gwt-code-reviews.appspot.com/1178801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: Add a custom report format. (issue1169801)

LGTM On 2010/12/02 05:31:09, Nick Chalko wrote: [JSR 303 TCK Result] 4 Pass 6 Fail 32 Error from a total of 259 tests for a success rate of 1.54%. http://gwt-code-reviews.appspot.com/1169801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: Handle fields marked @Valid (issue1142801)

LGTM with nits. http://gwt-code-reviews.appspot.com/1142801/diff/1/8 File user/src/com/google/gwt/validation/rebind/BeanHelper.java (right): http://gwt-code-reviews.appspot.com/1142801/diff/1/8#newcode78 user/src/com/google/gwt/validation/rebind/BeanHelper.java:78: * @param bean Remove @param o

[gwt-contrib] Re: Add ServiceLocator API to allow service methods to be invoked on non-static methods. (issue1162801)

LGTM http://gwt-code-reviews.appspot.com/1162801/diff/7001/8001 File user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java (right): http://gwt-code-reviews.appspot.com/1162801/diff/7001/8001#newcode223 user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java:223:

[gwt-contrib] Re: Add a definitive test for enum properties in RequestFactory. (issue1164801)

LGTM On 2010/11/30 21:14:04, bobv wrote: http://gwt-code-reviews.appspot.com/1164801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Eliminate hotspots in ProxyAutoBean code by memoizing data. (issue1161801)

LGTM with a nit http://gwt-code-reviews.appspot.com/1161801/diff/1/3 File user/src/com/google/gwt/autobean/server/ProxyAutoBean.java (right): http://gwt-code-reviews.appspot.com/1161801/diff/1/3#newcode241 user/src/com/google/gwt/autobean/server/ProxyAutoBean.java:241: } Useless if. http://gwt

[gwt-contrib] Re: Make ListEditorWrapper update its backing on flush(). (issue1159801)

Commited as of r9305 On 2010/11/30 17:31:54, rchandia wrote: http://gwt-code-reviews.appspot.com/1159801/diff/1/2 File user/src/com/google/gwt/editor/client/adapters/ListEditorWrapper.java (right): http://gwt-code-reviews.appspot.com/1159801/diff/1/2#newcode33 user/src/com/google/gwt

[gwt-contrib] Re: Make ListEditorWrapper update its backing on flush(). (issue1159801)

http://gwt-code-reviews.appspot.com/1159801/diff/1/2 File user/src/com/google/gwt/editor/client/adapters/ListEditorWrapper.java (right): http://gwt-code-reviews.appspot.com/1159801/diff/1/2#newcode33 user/src/com/google/gwt/editor/client/adapters/ListEditorWrapper.java:33: private final List wor

<    1   2   3   4   5   6   7   >