On 4/27/06, Mikhail Loenko [EMAIL PROTECTED] wrote:
As far as most of serialization tests extend SerializationTest then
having serialization test cases included into a regular unit tests
would cause that ALL the tests will extend SerializationTest that is
not very good.
Well, it is easy to
Mikhail Loenko wrote:
Paulex,
we have at least 8 categories of tests:
running from classpath or bootclasspath
implementation specific or independent
testing org.apache.harmony.* or java.*
Could you please list how all the tests will be named
Mikhail,
OK, let me try. I'm not
Mikhail Loenko wrote:
The problem is the tests will be mixed like that:
org.apache.harmony.security.asn1 -- tests in bootclasspath
org.apache.harmony.security.cert -- tests in bootclasspath
org.apache.harmony.security.tests -- tests in classpath
org.apache.harmony.security.x509 -- tests in
Mikhail Loenko wrote:
Geir,
The problem is that no one yet suggested a consistent solution
that would fit for all the tests and would not get into packages like
org.apache.harmony.security.tests.org.apache.harmony.security.util
Everybody seems to agree that SOME implementation specific
Stepan Mishura wrote:
Hi,
I'd like to discuss naming conventions for serialization tests - does it
make sense to separate serialization tests from unit tests?
I actually don't know. What are the pros/cons?
geir
-
Terms
Mark Hindess wrote:
On 27 April 2006 at 13:35, Mikhail Loenko [EMAIL PROTECTED] wrote:
The problem is the tests will be mixed like that:
org.apache.harmony.security.asn1 -- tests in bootclasspath
org.apache.harmony.security.cert -- tests in bootclasspath
org.apache.harmony.security.tests --
On 27 April 2006 at 3:16, Geir Magnusson Jr [EMAIL PROTECTED] wrote:
Mikhail Loenko wrote:
The question is where we put 'classpath' test. If we put them into
o.a.h.module.tests.[package under test] we result in that ugly
package names like
o.a.h.security.tests.o.a.h.security.util
Mark Hindess wrote:
Paulex wrote:
I consider the module name is optional and can be removed
I think we should consider the module name a mandatory part of the
prefix (for classes where we have the freedom to specify the prefix
obviously). It's mandatory for the o.a.h classlib classes it
We have all the docs for HARMONY-114 and they are in SVN
Please vote to accept or reject this codebase into the Apache Harmony
class library :
[ ] + 1 Accept
[ ] -1 Reject (provide reason below)
Lets let this run 3 days unless a) someone states they need more time or
b) we get all
+1 from me
Geir Magnusson Jr wrote:
We have all the docs for HARMONY-114 and they are in SVN
Please vote to accept or reject this codebase into the Apache Harmony
class library :
[ ] + 1 Accept
[ ] -1 Reject (provide reason below)
Lets let this run 3 days unless a) someone states they
Paulex,
As I understand form your comment to bug-333 you have a profound effect
on ICU4J team :), aren't you?
Please take a look at Tatyana's Harmony-62 bug. As far as I understand a
bug is in ICU4J(com.ibm.icu.text.BreakIterator)
Could you, please, let me know who can take care of it?
Best
Geir Magnusson Jr wrote:
Geir Magnusson Jr wrote:
George Harley wrote:
Of course, the text module has only implementation-independent
tests that designed to be run from classpath. For modules that have
got implementation-specific tests then I suppose we could use
something like
Mikhail Loenko wrote:
If it's separated, I'm OK with it
Can you suggest dir names?
Great!
Either boot or injected(as Mark said) sounds good keyword to me. so it
can be one of below:
1. src/test.injected/
2. src/test/injected
3. src/test.boot/
4. src/test/boot
Mmm...seems injected is
Paulex Yang wrote:
Mikhail Loenko wrote:
If it's separated, I'm OK with it
Can you suggest dir names?
Great!
Either boot or injected(as Mark said) sounds good keyword to me. so it
can be one of below:
1. src/test.injected/
2. src/test/injected
3. src/test.boot/
4. src/test/boot
George Harley wrote:
Geir Magnusson Jr wrote:
Geir Magnusson Jr wrote:
George Harley wrote:
Of course, the text module has only implementation-independent
tests that designed to be run from classpath. For modules that have
got implementation-specific tests then I suppose we could use
On 27 April 2006 at 4:00, Geir Magnusson Jr [EMAIL PROTECTED] wrote:
We have all the docs for HARMONY-114 and they are in SVN
Please vote to accept or reject this codebase into the Apache Harmony
class library :
[ ] + 1 Accept
[ ] -1 Reject (provide reason below)
Lets let this run 3
Geir Magnusson Jr wrote:
Paulex Yang wrote:
Mikhail Loenko wrote:
If it's separated, I'm OK with it
Can you suggest dir names?
Great!
Either boot or injected(as Mark said) sounds good keyword to me. so
it can be one of below:
1. src/test.injected/
2. src/test/injected
3.
+1
Tim
Geir Magnusson Jr wrote:
We have all the docs for HARMONY-114 and they are in SVN
Please vote to accept or reject this codebase into the Apache Harmony
class library :
[ ] + 1 Accept
[ ] -1 Reject (provide reason below)
Lets let this run 3 days unless a) someone states they
Paulex,
Thanks for the explanation. So we should wait some decisions regarding
rule differences.
Regards,
Svetlana
-Original Message-
From: Paulex Yang [mailto:[EMAIL PROTECTED]
Sent: Thursday, April 27, 2006 5:34 PM
To: harmony-dev@incubator.apache.org
Subject: [Fwd: Re: What can be
Mark Hindess wrote:
On 27 April 2006 at 4:00, Geir Magnusson Jr [EMAIL PROTECTED] wrote:
We have all the docs for HARMONY-114 and they are in SVN
Please vote to accept or reject this codebase into the Apache Harmony
class library :
[ ] + 1 Accept
[ ] -1 Reject (provide reason below)
Geir Magnusson Jr wrote:
George Harley wrote:
Geir Magnusson Jr wrote:
Geir Magnusson Jr wrote:
George Harley wrote:
Of course, the text module has only implementation-independent
tests that designed to be run from classpath. For modules that
have got implementation-specific tests
And how would you split 1,2,4,5 between these two folders?
Thanks,
Mikhail
2006/4/27, Paulex Yang [EMAIL PROTECTED]:
Mikhail Loenko wrote:
If it's separated, I'm OK with it
Can you suggest dir names?
Great!
Either boot or injected(as Mark said) sounds good keyword to me. so it
can
George Harley wrote:
Geir Magnusson Jr wrote:
George Harley wrote:
Geir Magnusson Jr wrote:
Geir Magnusson Jr wrote:
George Harley wrote:
Of course, the text module has only implementation-independent
tests that designed to be run from classpath. For modules that
have got
: Mark Hindess
Assignee: Mikhail Loenko
Priority: Trivial
Attachments: 20060427.update.diff, exclude.specific.test.files.diff
The use of **/TargetTest.java exclusions means we are excluding
tests that work just because
they have the same file name. For example,
modules/archive/make/common
://issues.apache.org/jira/browse/HARMONY-404
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Mark Hindess
Assignee: Mikhail Loenko
Priority: Trivial
Attachments: 20060427.update.diff, exclude.specific.test.files.diff
The use of **/TargetTest.java
+1
Mikhail
2006/4/27, Geir Magnusson Jr [EMAIL PROTECTED]:
We have all the docs for HARMONY-114 and they are in SVN
Please vote to accept or reject this codebase into the Apache Harmony
class library :
[ ] + 1 Accept
[ ] -1 Reject (provide reason below)
Lets let this run 3 days unless
Mikhail,
Spec writes:
Charsets are named by strings composed of the following characters:
The uppercase letters 'A' through 'Z' ('\u0041' through '\u005a'),
The lowercase letters 'a' through 'z' ('\u0061' through '\u007a'),
The digits '0' through '9' ('\u0030' through '\u0039'),
The dash
On 4/27/06, Geir Magnusson Jr wrote:
Stepan Mishura wrote:
Hi,
I'd like to discuss naming conventions for serialization tests - does it
make sense to separate serialization tests from unit tests?
I actually don't know. What are the pros/cons?
I'd propose to separate them. It
Key: HARMONY-404
URL: http://issues.apache.org/jira/browse/HARMONY-404
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Mark Hindess
Assignee: Mikhail Loenko
Priority: Trivial
Attachments: 20060427
Samoilenko, Svetlana V wrote:
Paulex,
Thanks for the explanation. So we should wait some decisions regarding
rule differences.
I suggest that if anyone has the time they look at configuring the ICU
break iterator to behave like the RI's.
Regards,
Tim
-Original Message-
From:
Geir Magnusson Jr wrote:
We have all the docs for HARMONY-114 and they are in SVN
Please vote to accept or reject this codebase into the Apache Harmony
class library :
+1 from me. I think it should probably be a separate (peer) project
from JCHEVM and classlib, e.g., under harmony/enhanced.
+1
-Stepan.
On 4/27/06, Geir Magnusson Jr wrote:
We have all the docs for HARMONY-114 and they are in SVN
Please vote to accept or reject this codebase into the Apache Harmony
class library :
[ ] + 1 Accept
[ ] -1 Reject (provide reason below)
Lets let this run 3 days unless a)
'.internal.' is used to denote packages containing types that are wholly
the business of a particular module; whereas non-internal packages
contain types that can be called from other modules (e.g. utilities) and
are expected to be stable.
In OSGi speak, we will export all packages that are *not*
I say leave them mixed. We are no more likely to want to run
serialization tests separately than we are locking tests etc. and trying
to layout the tests on disk to represent all the different metadata
about each test case is not going to work.
Regards,
Tim
Stepan Mishura wrote:
On 4/27/06,
As I understand most of them now separated.
We may either 'leave them' or 'mixed' , not both :)
So what did you mean?
Thanks,
Mikhail
2006/4/27, Tim Ellison [EMAIL PROTECTED]:
I say leave them mixed. We are no more likely to want to run
serialization tests separately than we are locking
On 4/27/06, Tim Ellison [EMAIL PROTECTED] wrote:
I say leave them mixed. We are no more likely to want to run
serialization tests separately than we are locking tests etc. and trying
to layout the tests on disk to represent all the different metadata
about each test case is not going to work.
On 4/27/06, Anton Avtamonov [EMAIL PROTECTED] wrote:
On 4/27/06, Tim Ellison [EMAIL PROTECTED] wrote:
I say leave them mixed. We are no more likely to want to run
serialization tests separately than we are locking tests etc. and trying
to layout the tests on disk to represent all the
On 4/27/06, Mikhail Loenko [EMAIL PROTECTED] wrote:
As I understand most of them now separated.
We may either 'leave them' or 'mixed' , not both :)
Yeah, quick search gave 93 files for extends SerializationTest search mask :-)
--
Anton Avtamonov,
Intel Middleware Products Division
Mikhail Loenko wrote:
As I understand most of them now separated.
If they are 'mostly separated' then they are 'mixed' right ;-) ?
(only teasing)
We may either 'leave them' or 'mixed' , not both :)
So what did you mean?
I mean don't treat them specially, mix them in with other tests.
Daniel,
Yeah, structurizing is always good. :)
a) You provided an excellent list of spec issues. Sure, I'll reply to it
soon.
b) Well, cross-review could be a good and interesting idea, however I'm
not sure it would give us much significant information to make
decisions. I think we should care
+1
George
Geir Magnusson Jr wrote:
We have all the docs for HARMONY-114 and they are in SVN
Please vote to accept or reject this codebase into the Apache Harmony
class library :
[ ] + 1 Accept
[ ] -1 Reject (provide reason below)
Lets let this run 3 days unless a) someone states they
Anton Avtamonov wrote:
On 4/27/06, Anton Avtamonov [EMAIL PROTECTED] wrote:
On 4/27/06, Tim Ellison [EMAIL PROTECTED] wrote:
I say leave them mixed. We are no more likely to want to run
serialization tests separately than we are locking tests etc. and trying
to layout the tests on
Mikhail Loenko wrote:
And how would you split 1,2,4,5 between these two folders?
I thought it is obvious.
test 1,2,4 goes to src/test
test 5 goes to src/impltest (internl/injected/boot anything is fine)
and all implementation goes to src/main
and they can be compiled to corresponding bin
Then how to run only independent tests?
Such a run would make sense to validate the tests or
if we switch to different RI version
Thanks,
Mikhail
2006/4/28, Paulex Yang [EMAIL PROTECTED]:
Mikhail Loenko wrote:
And how would you split 1,2,4,5 between these two folders?
I thought it is
Mikhail Loenko wrote:
Then how to run only independent tests?
Such a run would make sense to validate the tests or
if we switch to different RI version
It should be easy for ant script to identify independent tests by
package name convention, e.g, we have a keyword API for the
independent
Tim Ellison wrote:
Samoilenko, Svetlana V wrote:
Paulex,
Thanks for the explanation. So we should wait some decisions regarding
rule differences.
I suggest that if anyone has the time they look at configuring the ICU
break iterator to behave like the RI's.
Hello Tim,
I'd like
+1
-Original Message-
From: Geir Magnusson Jr [mailto:[EMAIL PROTECTED]
Sent: Thursday, April 27, 2006 3:00 AM
To: harmony-dev@incubator.apache.org
Subject: [VOTE] Acceptance of HARMONY-114 : rough draft of files that glue
Harmony Class Lib to JCHEVM native methods
We have all
Hi Paulex
2006/4/28, Paulex Yang [EMAIL PROTECTED]:
Mikhail Loenko wrote:
Then how to run only independent tests?
Such a run would make sense to validate the tests or
if we switch to different RI version
It should be easy for ant script to identify independent tests by
package name
So if you fix bug in java.io.ObjectInputStream then you have to run all
tests for all modules because tests for serialization mixed with other
tests. Are you OK with this?
Thanks,
Stepan
On 4/27/06, Tim Ellison wrote:
I say leave them mixed. We are no more likely to want to run
serialization
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Mark Hindess
Assignee: Mikhail Loenko
Priority: Trivial
Attachments: 20060427.update.diff, exclude.specific.test.files.diff
The use of **/TargetTest.java exclusions means we are excluding
tests
On 4/28/06, Stepan Mishura [EMAIL PROTECTED] wrote:
So if you fix bug in java.io.ObjectInputStream then you have to run all
tests for all modules because tests for serialization mixed with other
tests. Are you OK with this?
Why? I hope tests for ObjectInputStream provide enough coverage to
On 4/27/06, Anton Avtamonov wrote:
On 4/27/06, Tim Ellison wrote:
I say leave them mixed. We are no more likely to want to run
serialization tests separately than we are locking tests etc. and trying
to layout the tests on disk to represent all the different metadata
about each test
2006/4/27, Anton Avtamonov [EMAIL PROTECTED]:
On 4/27/06, Tim Ellison [EMAIL PROTECTED] wrote:
I say leave them mixed. We are no more likely to want to run
serialization tests separately than we are locking tests etc. and trying
to layout the tests on disk to represent all the different
53 matches
Mail list logo
