iamsanjay commented on PR #2689:
URL: https://github.com/apache/solr/pull/2689#issuecomment-2377494703
We have already taken a step towards achieving immutability for
Http2SolrClient by deprecating addListenerFactory. As I mentioned earlier, the
next step should be to ensure that the securi
iamsanjay commented on PR #2689:
URL: https://github.com/apache/solr/pull/2689#issuecomment-2377485484
Of course I am not suggesting this change for now. But still want to share
my concern here.
The ability to add a listener factory after initialization introduces the
potential for
dsmiley commented on PR #2689:
URL: https://github.com/apache/solr/pull/2689#issuecomment-2375837529
I'm in favor of a CoreContainer.newHttpSolrClient(String url) method that
the caller should close and that which uses a common underlying HttpClient
instance / connection-pool underneath.
gerlowskija commented on PR #2689:
URL: https://github.com/apache/solr/pull/2689#issuecomment-2375060453
All the approaches have downsides for sure, but for me personally, object
allocation and the 'Closeable'-burden seem like the lesser evils.
> unnecessary object creation
"Cl
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1775604953
##
solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1775595008
##
solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
iamsanjay commented on PR #2689:
URL: https://github.com/apache/solr/pull/2689#issuecomment-2374579550
> Wdyt about saving `getDefaultHttpClient()` take in a baseUrl, so that the
returned instance can take advantage of all SolrClient methods "out of the box"?
>
> (Also - am I missing
gerlowskija commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1775500138
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi
return this.distributedCo
gerlowskija commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1775285594
##
solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1774390477
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi
return this.distributedColl
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1774390477
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi
return this.distributedColl
dsmiley commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1766878358
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi
return this.distributedCollec
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1766118550
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi
return this.distributedColl
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1766116768
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi
return this.distributedColl
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1766116768
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi
return this.distributedColl
dsmiley commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1752562414
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi
return this.distributedCollec
dsmiley commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1752552453
##
solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dsmiley commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1750643762
##
solr/core/src/test/org/apache/solr/core/TestCoreContainer.java:
##
@@ -1131,6 +1132,48 @@ public void testCoreInitFailuresOnReload() throws
Exception {
cc.shutdow
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1750442293
##
solr/core/src/test/org/apache/solr/core/TestCoreContainer.java:
##
@@ -1131,6 +1132,48 @@ public void testCoreInitFailuresOnReload() throws
Exception {
cc.shutd
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1750406272
##
solr/core/src/test/org/apache/solr/core/TestCoreContainer.java:
##
@@ -1131,6 +1132,48 @@ public void testCoreInitFailuresOnReload() throws
Exception {
cc.shutd
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1750400090
##
solr/core/src/test/org/apache/solr/core/TestCoreContainer.java:
##
@@ -1131,6 +1132,48 @@ public void testCoreInitFailuresOnReload() throws
Exception {
cc.shutd
dsmiley commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1750378062
##
solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java:
##
@@ -40,107 +34,55 @@
*
* @lucene.internal
*/
-class HttpSolrClientProvider implements Solr
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1746871199
##
solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
dsmiley commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1745829882
##
solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dsmiley commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1745827217
##
solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dsmiley commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1745826245
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi
return this.distributedCollec
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1745483402
##
solr/core/src/java/org/apache/solr/core/HttpSolrClientProvider.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1745440775
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi
return this.distributedColl
dsmiley commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1744236940
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi
return this.distributedCollec
dsmiley commented on PR #2689:
URL: https://github.com/apache/solr/pull/2689#issuecomment-2326707800
OK RE not subclassing SolrClientCache.
Despite CoreContainer's code size, I think it's reasonable to have a
getHttpSolrClient on it as it's important and used widely enough (and I expe
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1742194558
##
solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java:
##
@@ -347,22 +348,27 @@ PublicKey fetchPublicKeyFromRemote(String nodename) {
HttpEnti
dsmiley commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1742191640
##
solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java:
##
@@ -347,22 +348,27 @@ PublicKey fetchPublicKeyFromRemote(String nodename) {
HttpEntity
iamsanjay commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1742146196
##
solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java:
##
@@ -347,22 +348,27 @@ PublicKey fetchPublicKeyFromRemote(String nodename) {
HttpEnti
iamsanjay commented on PR #2689:
URL: https://github.com/apache/solr/pull/2689#issuecomment-2326587995
An alternative would be to introduce another class and add a method in
CoreContainer to return that class. However, we already have the
`UpdateShardHandler` class which exactly does the sa
iamsanjay commented on PR #2689:
URL: https://github.com/apache/solr/pull/2689#issuecomment-2326571320
I don't think we should extend SolrClientCache. While we're looking for a
new home for the default HTTP client and have agreed that UpdateShardHandler
isn't the right place, the same appli
dsmiley commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1742021681
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java:
##
@@ -169,6 +169,10 @@ public synchronized SolrClient getHttpSolrClient(String
bas
iamsanjay commented on PR #2689:
URL: https://github.com/apache/solr/pull/2689#issuecomment-2325100679
I still need to adjust how the HTTP client is initialized, but is this
aligned with what you had in mind when you suggested extending SolrClientCache
in [this
discussion](https://github.c
iamsanjay opened a new pull request, #2689:
URL: https://github.com/apache/solr/pull/2689
https://issues.apache.org/jira/browse/SOLR-16503
Spin Off #2351
Many HTTP requests currently rely on the default client from
UpdateShardHandler. However, it has been noted that UpdateShar
38 matches
Mail list logo
