[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523375614 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java ## @@ -311,6 +314,8 @@ public void run() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523372464 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java ## @@ -1000,7 +1012,17 @@ public void restore(f

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523337785 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/SubscriptionInfo.java ## @@ -115,6 +119,10 @@ private Subscri

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523337226 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java ## @@ -1000,7 +1012,17 @@ public void restore(fina

[GitHub] [kafka] ijuma commented on a change in pull request #9566: KAFKA-10618: Update to Uuid class

ijuma commented on a change in pull request #9566: URL: https://github.com/apache/kafka/pull/9566#discussion_r523336595 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/types/Struct.java ## @@ -266,12 +266,12 @@ public Long getLong(String name) { r

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523334732 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamRepartitionIntegrationTest.java ## @@ -144,6 +143,7 @@ public void whenSh

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523334335 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java ## @@ -311,6 +314,8 @@ public void run() {

[jira] [Commented] (KAFKA-10721) Rewrite topology to allow for overlapping unequal topic subscriptions

[ https://issues.apache.org/jira/browse/KAFKA-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231904#comment-17231904 ] A. Sophie Blee-Goldman commented on KAFKA-10721: I agree. However, there

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523327338 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +375,93 @@ public void setUncaughtExceptionHandler(final T

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523327104 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +375,93 @@ public void setUncaughtExceptionHandler(final Thre

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523322776 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java ## @@ -1000,7 +1012,17 @@ public void restore(f

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523319677 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamRepartitionIntegrationTest.java ## @@ -144,6 +143,7 @@ public void whe

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523311219 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/SubscriptionInfo.java ## @@ -115,6 +119,10 @@ private Subs

[jira] [Commented] (KAFKA-10721) Rewrite topology to allow for overlapping unequal topic subscriptions

[ https://issues.apache.org/jira/browse/KAFKA-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231897#comment-17231897 ] Matthias J. Sax commented on KAFKA-10721: - Interesting idea. I guess the current

[jira] [Commented] (KAFKA-10722) Timestamped store is used even if not desired

[ https://issues.apache.org/jira/browse/KAFKA-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231896#comment-17231896 ] Matthias J. Sax commented on KAFKA-10722: - [~fml2], what you describe is not a b

[jira] [Resolved] (KAFKA-7107) Ability to configure state store for JoinWindows in KStream-KStream join

[ https://issues.apache.org/jira/browse/KAFKA-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-7107. --- Resolution: Duplicate > Ability to configure state store for JoinWindows in K

[jira] [Assigned] (KAFKA-9126) Extend `StreamJoined` to allow more store configs

[ https://issues.apache.org/jira/browse/KAFKA-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leah Thomas reassigned KAFKA-9126: -- Assignee: Leah Thomas > Extend `StreamJoined` to allow more store configs > --

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523303062 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java ## @@ -311,6 +314,8 @@ public void run() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523302976 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java ## @@ -311,6 +314,8 @@ public void run() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523296833 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +375,93 @@ public void setUncaughtExceptionHandler(final T

[jira] [Updated] (KAFKA-10723) LogManager shutdown error handler doesn't shutdown all internal thread pools

[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Updated] (KAFKA-10723) LogManager shutdown error handler doesn't shutdown all internal thread pools

[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Updated] (KAFKA-10723) LogManager shutdown error handler doesn't shutdown all internal thread pools

[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Updated] (KAFKA-10723) LogManager shutdown error handler doesn't shutdown all internal thread pools

[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r523292295 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -589,6 +589,10 @@ private void subscribeConsumer

[jira] [Updated] (KAFKA-10723) LogManager shutdown error handler doesn't shutdown all internal thread pools

[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in LogManager has the shortcoming that

[jira] [Created] (KAFKA-10723) LogManager shutdown error handler doesn't shutdown all internal thread pools

Kowshik Prakasam created KAFKA-10723: Summary: LogManager shutdown error handler doesn't shutdown all internal thread pools Key: KAFKA-10723 URL: https://issues.apache.org/jira/browse/KAFKA-10723

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523069611 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +375,93 @@ public void setUncaughtExceptionHandler(final Thre

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r523284354 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -711,6 +723,9 @@ private[log] class Cleaner(val id: Int, shallowOffsetOfMaxTim

[jira] [Updated] (KAFKA-10722) Timestamped store is used even if not desired

[ https://issues.apache.org/jira/browse/KAFKA-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fml2 updated KAFKA-10722: - Description: I have a stream which I then group and aggregate (this results in a KTable). When aggregating, I e

[jira] [Updated] (KAFKA-10722) Timestamped store is used even if not desired

[ https://issues.apache.org/jira/browse/KAFKA-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fml2 updated KAFKA-10722: - Description: I have a stream which I then group and aggregate (this results in a KTable). When aggregating, I e

[jira] [Updated] (KAFKA-10722) Timestamped store is used even if not desired

[ https://issues.apache.org/jira/browse/KAFKA-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fml2 updated KAFKA-10722: - Description: I have a stream which I then group and aggregate (this results in a KTable). When aggregating, I e

[jira] [Updated] (KAFKA-10722) Timestamped store is used even if not desired

[ https://issues.apache.org/jira/browse/KAFKA-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fml2 updated KAFKA-10722: - Description: I have a stream which I then group and aggregate (this results in a KTable). When aggregating, I e

[jira] [Updated] (KAFKA-10722) Timestamped store is used even if not desired

[ https://issues.apache.org/jira/browse/KAFKA-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fml2 updated KAFKA-10722: - Description: I have a stream which I then group and aggregate (this results in a KTable). When aggregating, I e

[GitHub] [kafka] guozhangwang commented on a change in pull request #9569: KAFKA-10687: make ProduceRespone only returns INVALID_PRODUCER_EPOCH

guozhangwang commented on a change in pull request #9569: URL: https://github.com/apache/kafka/pull/9569#discussion_r523277419 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -713,6 +715,8 @@ public void sendOffsetsToTransaction(M

[jira] [Assigned] (KAFKA-10674) Brokers should know the active controller ApiVersion after enabling KIP-590 forwarding

[ https://issues.apache.org/jira/browse/KAFKA-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reassigned KAFKA-10674: --- Assignee: Boyang Chen > Brokers should know the active controller ApiVersion after enabling

[GitHub] [kafka] fml2 opened a new pull request #9594: Improve JavaDoc in KeyValueBytesStoreSupplier

fml2 opened a new pull request #9594: URL: https://github.com/apache/kafka/pull/9594 In the JavaDoc, the implemented interface was described inaccurately. Also, the ordered list was formatted as plain text, not as html "ol". No testing necessary since only a comment was changed.

[jira] [Updated] (KAFKA-6687) Allow to read a topic multiple times

[ https://issues.apache.org/jira/browse/KAFKA-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-6687: -- Fix Version/s: 2.8.0 > Allow to read a topic multiple times > -

[GitHub] [kafka] ableegoldman commented on pull request #9582: KAFKA-6687: rewrite topology to allow reading the same topic multiple times in the DSL

ableegoldman commented on pull request #9582: URL: https://github.com/apache/kafka/pull/9582#issuecomment-727069085 Merged to trunk This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Updated] (KAFKA-10722) Timestamped store is used even if not desired

[ https://issues.apache.org/jira/browse/KAFKA-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fml2 updated KAFKA-10722: - Description: I have a stream which I then group and aggregate (this results in a KTable). When aggregating, I e

[GitHub] [kafka] ableegoldman merged pull request #9582: KAFKA-6687: rewrite topology to allow reading the same topic multiple times in the DSL

ableegoldman merged pull request #9582: URL: https://github.com/apache/kafka/pull/9582 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on pull request #9582: KAFKA-6687: rewrite topology to allow reading the same topic multiple times in the DSL

ableegoldman commented on pull request #9582: URL: https://github.com/apache/kafka/pull/9582#issuecomment-727067902 Two unrelated flaky test failures: `EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]` `DynamicConnectionQuotaTest.testDynamicListenerConnectionCreat

[GitHub] [kafka] jsancio commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jsancio commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r523267025 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -711,6 +723,9 @@ private[log] class Cleaner(val id: Int, shallowOffsetOfMaxTim

[GitHub] [kafka] jsancio commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jsancio commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r523267025 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -711,6 +723,9 @@ private[log] class Cleaner(val id: Int, shallowOffsetOfMaxTim

[jira] [Created] (KAFKA-10722) Timestamped store is used even if not desired

fml2 created KAFKA-10722: Summary: Timestamped store is used even if not desired Key: KAFKA-10722 URL: https://issues.apache.org/jira/browse/KAFKA-10722 Project: Kafka Issue Type: Bug Compo

[GitHub] [kafka] abbccdda commented on a change in pull request #9569: KAFKA-10687: make ProduceRespone only returns INVALID_PRODUCER_EPOCH

abbccdda commented on a change in pull request #9569: URL: https://github.com/apache/kafka/pull/9569#discussion_r523264487 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -713,6 +715,8 @@ public void sendOffsetsToTransaction(Map o

[GitHub] [kafka] jsancio commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jsancio commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r523262472 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1306,7 +1309,7 @@ class Log(@volatile private var _dir: File, // in an unclean manner with

[GitHub] [kafka] jsancio commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jsancio commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r523262141 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -711,6 +723,9 @@ private[log] class Cleaner(val id: Int, shallowOffsetOfMaxTim

[jira] [Commented] (KAFKA-7421) Deadlock in Kafka Connect

[ https://issues.apache.org/jira/browse/KAFKA-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231842#comment-17231842 ] Kyle Leiby commented on KAFKA-7421: --- We are currently running a container whose base im

[GitHub] [kafka] ableegoldman commented on pull request #9489: MINOR: demote "Committing task offsets" log to DEBUG

ableegoldman commented on pull request #9489: URL: https://github.com/apache/kafka/pull/9489#issuecomment-727043278 Merged to trunk. Waiting to cherrypick to 2.7 branch until 2.7.0 release has completed This is an automated

[GitHub] [kafka] ableegoldman merged pull request #9489: MINOR: demote "Committing task offsets" log to DEBUG

ableegoldman merged pull request #9489: URL: https://github.com/apache/kafka/pull/9489 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on pull request #9489: MINOR: demote "Committing task offsets" log to DEBUG

ableegoldman commented on pull request #9489: URL: https://github.com/apache/kafka/pull/9489#issuecomment-727042137 Two flaky tests: `PurgeRepartitionTopicIntegrationTest.shouldRestoreState` `SslSelectorTest.testCloseOldestConnection`

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r523233325 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1306,7 +1309,7 @@ class Log(@volatile private var _dir: File, // in an unclean manner with

[GitHub] [kafka] guozhangwang commented on a change in pull request #9569: KAFKA-10687: make ProduceRespone only returns INVALID_PRODUCER_EPOCH

guozhangwang commented on a change in pull request #9569: URL: https://github.com/apache/kafka/pull/9569#discussion_r523232452 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -713,6 +715,8 @@ public void sendOffsetsToTransaction(M

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r523231421 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -711,6 +723,9 @@ private[log] class Cleaner(val id: Int, shallowOffsetOfMaxTim

[GitHub] [kafka] abbccdda commented on a change in pull request #9569: KAFKA-10687: make ProduceRespone only returns INVALID_PRODUCER_EPOCH

abbccdda commented on a change in pull request #9569: URL: https://github.com/apache/kafka/pull/9569#discussion_r523102604 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -713,6 +715,8 @@ public void sendOffsetsToTransaction(Map o

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r523195958 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -538,6 +539,14 @@ private[log] class Cleaner(val id: Int, for (group <- groupedSegme

[GitHub] [kafka] jsancio commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jsancio commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r523177211 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1306,7 +1309,7 @@ class Log(@volatile private var _dir: File, // in an unclean manner with

[GitHub] [kafka] abbccdda commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

abbccdda commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r523184916 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ## @@ -208,7 +209,9 @@ class BrokerToControllerRequestThread(net

[GitHub] [kafka] abbccdda commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

abbccdda commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r523184916 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ## @@ -208,7 +209,9 @@ class BrokerToControllerRequestThread(net

[GitHub] [kafka] ableegoldman commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow reading the same topic multiple times in the DSL

ableegoldman commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r523183821 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java ## @@ -314,6 +317,50 @@ public void buildAn

[jira] [Created] (KAFKA-10721) Rewrite topology to allow for overlapping unequal topic subscriptions

A. Sophie Blee-Goldman created KAFKA-10721: -- Summary: Rewrite topology to allow for overlapping unequal topic subscriptions Key: KAFKA-10721 URL: https://issues.apache.org/jira/browse/KAFKA-10721

[GitHub] [kafka] abbccdda commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

abbccdda commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r523183433 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ## @@ -208,7 +209,9 @@ class BrokerToControllerRequestThread(net

[GitHub] [kafka] ableegoldman commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow reading the same topic multiple times in the DSL

ableegoldman commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r523175703 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -410,18 +410,6 @@ public final voi

[GitHub] [kafka] ableegoldman commented on pull request #9583: [KAFKA-10705]: Make state stores not readable by others

ableegoldman commented on pull request #9583: URL: https://github.com/apache/kafka/pull/9583#issuecomment-726978481 Cherrypicked to 2.6, will wait for 2.7.0 release to finish up before merging to 2.7 This is an automated mes

[GitHub] [kafka] C0urante commented on a change in pull request #9549: KIP-145: Add SMTs, HeaderFrom, DropHeaders and InsertHeader

C0urante commented on a change in pull request #9549: URL: https://github.com/apache/kafka/pull/9549#discussion_r523161370 ## File path: connect/transforms/src/test/java/org/apache/kafka/connect/transforms/HeaderFromTest.java ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache

[jira] [Updated] (KAFKA-10705) Avoid World Readable RocksDB

[ https://issues.apache.org/jira/browse/KAFKA-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-10705: --- Fix Version/s: 2.6.2 > Avoid World Readable RocksDB > --

[jira] [Resolved] (KAFKA-10705) Avoid World Readable RocksDB

[ https://issues.apache.org/jira/browse/KAFKA-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-10705. Resolution: Fixed > Avoid World Readable RocksDB > ---

[GitHub] [kafka] ableegoldman merged pull request #9583: [KAFKA-10705]: Make state stores not readable by others

ableegoldman merged pull request #9583: URL: https://github.com/apache/kafka/pull/9583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (KAFKA-10720) Add note to Transformation docs to avoid mutating records or their members

Chris Egerton created KAFKA-10720: - Summary: Add note to Transformation docs to avoid mutating records or their members Key: KAFKA-10720 URL: https://issues.apache.org/jira/browse/KAFKA-10720 Project:

[GitHub] [kafka] C0urante commented on a change in pull request #9549: KIP-145: Add SMTs, HeaderFrom, DropHeaders and InsertHeader

C0urante commented on a change in pull request #9549: URL: https://github.com/apache/kafka/pull/9549#discussion_r523147909 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/HeaderFrom.java ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Sof

[jira] [Updated] (KAFKA-10705) Avoid World Readable RocksDB

[ https://issues.apache.org/jira/browse/KAFKA-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-10705: --- Fix Version/s: 2.7.1 2.8.0 > Avoid World Readable RocksDB

[GitHub] [kafka] ableegoldman commented on a change in pull request #9583: [KAFKA-10705]: Make state stores not readable by others

ableegoldman commented on a change in pull request #9583: URL: https://github.com/apache/kafka/pull/9583#discussion_r523142600 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -102,6 +107,15 @@ public StateDirectory(fin

[GitHub] [kafka] lct45 commented on a change in pull request #9583: [KAFKA-10705]: Make state stores not readable by others

lct45 commented on a change in pull request #9583: URL: https://github.com/apache/kafka/pull/9583#discussion_r523137877 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -102,6 +107,15 @@ public StateDirectory(final Stre

[jira] [Commented] (KAFKA-10405) Flaky Test org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState

[ https://issues.apache.org/jira/browse/KAFKA-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231709#comment-17231709 ] A. Sophie Blee-Goldman commented on KAFKA-10405: https://github.com/apac

[GitHub] [kafka] ableegoldman commented on a change in pull request #9583: [KAFKA-10705]: Make state stores not readable by others

ableegoldman commented on a change in pull request #9583: URL: https://github.com/apache/kafka/pull/9583#discussion_r523130136 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -102,6 +107,15 @@ public StateDirectory(fin

[jira] [Created] (KAFKA-10719) MirrorMaker2 fails to update its runtime configuration

Peter Sinoros-Szabo created KAFKA-10719: --- Summary: MirrorMaker2 fails to update its runtime configuration Key: KAFKA-10719 URL: https://issues.apache.org/jira/browse/KAFKA-10719 Project: Kafka

[jira] [Comment Edited] (KAFKA-10710) MirrorMaker 2 creates all combinations of herders

[ https://issues.apache.org/jira/browse/KAFKA-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231633#comment-17231633 ] Julien C edited comment on KAFKA-10710 at 11/13/20, 5:05 PM: -

[GitHub] [kafka] vvcephei commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

vvcephei commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523089743 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +375,93 @@ public void setUncaughtExceptionHandler(final Threa

[jira] [Commented] (KAFKA-10710) MirrorMaker 2 creates all combinations of herders

[ https://issues.apache.org/jira/browse/KAFKA-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231633#comment-17231633 ] Julien C commented on KAFKA-10710: -- Results with fix provided in PR:   {{}} {code:jav

[GitHub] [kafka] cadonna commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

cadonna commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523080590 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +375,93 @@ public void setUncaughtExceptionHandler(final Thread

[GitHub] [kafka] cadonna commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow reading the same topic multiple times in the DSL

cadonna commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r523061696 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -410,18 +410,6 @@ public final void add

[GitHub] [kafka] lct45 commented on a change in pull request #9583: [KAFKA-10705]: Make state stores not readable by others

lct45 commented on a change in pull request #9583: URL: https://github.com/apache/kafka/pull/9583#discussion_r523055221 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -102,6 +107,15 @@ public StateDirectory(final Stre

[GitHub] [kafka] cadonna commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

cadonna commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r523028163 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +375,93 @@ public void setUncaughtExceptionHandler(final Thread

[GitHub] [kafka] twobeeb edited a comment on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

twobeeb edited a comment on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-726846099 After fixing the issue : [2020-11-13 15:53:53,935] INFO creating herder for replica_CENTRAL->replica_ZAR (org.apache.kafka.connect.mirror.MirrorMaker) [2020-1

[GitHub] [kafka] lct45 commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow reading the same topic multiple times in the DSL

lct45 commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r523044318 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -410,18 +410,6 @@ public final void addSo

[GitHub] [kafka] twobeeb commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

twobeeb commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-726846099 After fixing the issue : [root@lnx001385 log]# cat kafka-mirror-maker.log | grep herder [2020-11-13 15:53:53,935] INFO creating herder for replica_CENTRAL->replica_Z

[jira] [Commented] (KAFKA-10717) ACL authorization log when consumer requires all topics

[ https://issues.apache.org/jira/browse/KAFKA-10717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231585#comment-17231585 ] Ismael Juma commented on KAFKA-10717: - Thanks for the report. Can you still see this

[GitHub] [kafka] lct45 commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow reading the same topic multiple times in the DSL

lct45 commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r523006855 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java ## @@ -314,6 +317,50 @@ public void buildAndOptimi

[jira] [Commented] (KAFKA-10713) Surprising behaviour when bootstrap servers are separated by semicolons

[ https://issues.apache.org/jira/browse/KAFKA-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231332#comment-17231332 ] Tom Bentley commented on KAFKA-10713: - [~Jack-Lee] I took [~mimaison]'s point to be

[GitHub] [kafka] tombentley opened a new pull request #9593: KAFKA-10713: Stricter protocol parsing in hostnames

tombentley opened a new pull request #9593: URL: https://github.com/apache/kafka/pull/9593 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testin

[GitHub] [kafka] tombentley commented on pull request #9593: KAFKA-10713: Stricter protocol parsing in hostnames

tombentley commented on pull request #9593: URL: https://github.com/apache/kafka/pull/9593#issuecomment-726661732 @mimaison would you be able to take a look? This is an automated message from the Apache Git Service. To respon

[jira] [Commented] (KAFKA-10713) Surprising behaviour when bootstrap servers are separated by semicolons

[ https://issues.apache.org/jira/browse/KAFKA-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231324#comment-17231324 ] Tom Bentley commented on KAFKA-10713: - The problem is this regex in {{Utils}} {nofor

[jira] [Commented] (KAFKA-10713) Surprising behaviour when bootstrap servers are separated by semicolons

[ https://issues.apache.org/jira/browse/KAFKA-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231322#comment-17231322 ] lqjacklee commented on KAFKA-10713: --- the bootstrap.servers should configured with Spli

[GitHub] [kafka] cadonna commented on pull request #9582: KAFKA-6687: rewrite topology to allow reading the same topic multiple times in the DSL

cadonna commented on pull request #9582: URL: https://github.com/apache/kafka/pull/9582#issuecomment-726597853 > I do think there's some possible followup work to further improve the situation (see my comment above) but I would say that's it's different enough to merit creating separate fo

[GitHub] [kafka] cadonna commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow reading the same topic multiple times in the DSL

cadonna commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r522782299 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java ## @@ -895,6 +899,103 @@ public void shouldUseSpecifiedNameForAggrega

[GitHub] [kafka] cadonna commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow reading the same topic multiple times in the DSL

cadonna commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r522778010 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamSourceNode.java ## @@ -71,6 +78,22 @@ public Pattern topicPatter

[jira] [Updated] (KAFKA-10718) ValueToKey transformation failed when encountering null value

[ https://issues.apache.org/jira/browse/KAFKA-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YUNHAO MU updated KAFKA-10718: -- Description:  ValueToKey transformation failed when encountering null value {code:java} ERROR WorkerSi

[GitHub] [kafka] cadonna commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow reading the same topic multiple times in the DSL

cadonna commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r522775434 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java ## @@ -314,6 +317,50 @@ public void buildAndOpti

[GitHub] [kafka] cadonna commented on a change in pull request #9583: [KAFKA-10705]: Make state stores not readable by others

cadonna commented on a change in pull request #9583: URL: https://github.com/apache/kafka/pull/9583#discussion_r522770608 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -102,6 +107,15 @@ public StateDirectory(final St

  1   2   >