[jira] [Updated] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2021-04-20 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Bischel updated KAFKA-12671: --- Priority: Critical (was: Major) > Out of order processing with a transactional producer

[GitHub] [kafka] vamossagar12 commented on pull request #10542: KAFKA-12313: Streamling windowed Deserialiser configs.

2021-04-20 Thread GitBox
vamossagar12 commented on pull request #10542: URL: https://github.com/apache/kafka/pull/10542#issuecomment-823770411 hey @ableegoldman , plz review whenever you get the chance.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-12699) Streams no longer overrides the java default uncaught exception handler

2021-04-20 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326223#comment-17326223 ] Walker Carlson commented on KAFKA-12699: I would not say its a bug per-say but I just wanted

[jira] [Commented] (KAFKA-12699) Streams no longer overrides the java default uncaught exception handler

2021-04-20 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326215#comment-17326215 ] A. Sophie Blee-Goldman commented on KAFKA-12699: To be fair, I think claiming that this

[GitHub] [kafka] cmccabe commented on pull request #10564: MINOR: clean up some replication code

2021-04-20 Thread GitBox
cmccabe commented on pull request #10564: URL: https://github.com/apache/kafka/pull/10564#issuecomment-823736138 @junrao : BTW, when do you think we should change away from a working leader to the preferred leader? I guess when auto leader balancing is enabled and we're doing a

[GitHub] [kafka] chia7712 merged pull request #10402: MINOR: Remove unthrown exceptions, fix typo, etc.

2021-04-20 Thread GitBox
chia7712 merged pull request #10402: URL: https://github.com/apache/kafka/pull/10402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-20 Thread GitBox
cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617160661 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1053,61 @@ void

[GitHub] [kafka] ableegoldman merged pull request #10571: HOTFIX: remove unimplemented SPILL_TO_DISK buffer full strategy

2021-04-20 Thread GitBox
ableegoldman merged pull request #10571: URL: https://github.com/apache/kafka/pull/10571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] ableegoldman commented on pull request #10571: HOTFIX: remove unimplemented SPILL_TO_DISK buffer full strategy

2021-04-20 Thread GitBox
ableegoldman commented on pull request #10571: URL: https://github.com/apache/kafka/pull/10571#issuecomment-823722622 Just the usual unrelated failures in `RaftClusterTest` and `MirrorConnectorsIntegrationTest` -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ableegoldman opened a new pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-20 Thread GitBox
ableegoldman opened a new pull request #10573: URL: https://github.com/apache/kafka/pull/10573 Deprecates and logs a warning upon usage of the following: - StreamsConfig.EXACTLY_ONCE - StreamsConfig.EXACTLY_ONCE_BETA - Producer#sendOffsetsToTransaction(Map offsets, String

[GitHub] [kafka] cmccabe edited a comment on pull request #10572: Add GlobalTopicCount and GlobalPartitionCount metrics to Quorum Controller

2021-04-20 Thread GitBox
cmccabe edited a comment on pull request #10572: URL: https://github.com/apache/kafka/pull/10572#issuecomment-823721422 Hi @dielhennr, thanks for the PR! I think it would be simpler to have `ControllerMetrics#setGlobalTopicsCount` / `ControllerMetrics#globalTopicsCount` rather than

[GitHub] [kafka] cmccabe commented on pull request #10572: Add GlobalTopicCount and GlobalPartitionCount metrics to Quorum Controller

2021-04-20 Thread GitBox
cmccabe commented on pull request #10572: URL: https://github.com/apache/kafka/pull/10572#issuecomment-823721422 Hi @dielhennr, thanks for the PR! I think it would be simpler to have `ControllerMetrics#setGlobalTopicsCount` / `ControllerMetrics#globalTopicsCount` rather than inc /

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10565: KAFKA-12691: Add case where task can be considered idling

2021-04-20 Thread GitBox
wcarlson5 commented on a change in pull request #10565: URL: https://github.com/apache/kafka/pull/10565#discussion_r617150453 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -692,6 +699,7 @@ public boolean process(final

[GitHub] [kafka] mjsax commented on pull request #10565: KAFKA-12691: Add case where task can be considered idling

2021-04-20 Thread GitBox
mjsax commented on pull request #10565: URL: https://github.com/apache/kafka/pull/10565#issuecomment-823719998 Btw: can we add some tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on a change in pull request #10565: KAFKA-12691: Add case where task can be considered idling

2021-04-20 Thread GitBox
mjsax commented on a change in pull request #10565: URL: https://github.com/apache/kafka/pull/10565#discussion_r617150002 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -692,6 +699,7 @@ public boolean process(final long

[GitHub] [kafka] mjsax commented on pull request #10569: KAFKA-12696: Adds standardized getters to LagInfo class

2021-04-20 Thread GitBox
mjsax commented on pull request #10569: URL: https://github.com/apache/kafka/pull/10569#issuecomment-823712852 This PR proposes a public API change and a KIP is required before it could be merged. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (KAFKA-12696) Add standard getters to LagInfo class to allow automatic serialization

2021-04-20 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12696: Labels: needs-kip (was: ) > Add standard getters to LagInfo class to allow automatic

[jira] [Commented] (KAFKA-12696) Add standard getters to LagInfo class to allow automatic serialization

2021-04-20 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326192#comment-17326192 ] Matthias J. Sax commented on KAFKA-12696: - [~mihasya] – two comments: # This ticket propose a

[jira] [Commented] (KAFKA-12695) KStream.toTable must be extended to allow for a specific Serde

2021-04-20 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326191#comment-17326191 ] Matthias J. Sax commented on KAFKA-12695: - Thanks for reporting this. Seems that there is a gap

[jira] [Created] (KAFKA-12700) The admin.listeners config has wonky valid values in the docs

2021-04-20 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-12700: -- Summary: The admin.listeners config has wonky valid values in the docs Key: KAFKA-12700 URL: https://issues.apache.org/jira/browse/KAFKA-12700

[jira] [Updated] (KAFKA-12695) KStream.toTable must be extended to allow for a specific Serde

2021-04-20 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12695: Labels: scala (was: ) > KStream.toTable must be extended to allow for a specific Serde

[jira] [Created] (KAFKA-12699) Streams no longer overrides the java default uncaught exception handler

2021-04-20 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12699: -- Summary: Streams no longer overrides the java default uncaught exception handler Key: KAFKA-12699 URL: https://issues.apache.org/jira/browse/KAFKA-12699

[jira] [Commented] (KAFKA-12666) Fix flaky kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic

2021-04-20 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326190#comment-17326190 ] Matthias J. Sax commented on KAFKA-12666: - Different method:

[jira] [Commented] (KAFKA-12511) Flaky test DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota()

2021-04-20 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326188#comment-17326188 ] Matthias J. Sax commented on KAFKA-12511: - Failed again:

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-20 Thread GitBox
mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r617136596 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java ## @@ -73,6 +76,7 @@ public boolean

[jira] [Commented] (KAFKA-12697) Add GlobalTopicCount and GlobalPartitionCount metrics to QuorumController

2021-04-20 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326184#comment-17326184 ] Ryan Dielhenn commented on KAFKA-12697: --- https://github.com/apache/kafka/pull/10572 > Add

[GitHub] [kafka] dielhennr opened a new pull request #10572: Add GlobalTopicCount and GlobalPartitionCount metrics to Quorum Controller

2021-04-20 Thread GitBox
dielhennr opened a new pull request #10572: URL: https://github.com/apache/kafka/pull/10572 Added GlobalTopicCount and GlobalPartitionCount metrics to the QuorumController. The metrics are calculated by counting records as they are replayed e.g. replay(TopicRecord),

[GitHub] [kafka] junrao commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-20 Thread GitBox
junrao commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617093936 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1053,61 @@ void

[GitHub] [kafka] ableegoldman commented on pull request #10571: HOTFIX: remove unimplemented SPILL_TO_DISK buffer full strategy

2021-04-20 Thread GitBox
ableegoldman commented on pull request #10571: URL: https://github.com/apache/kafka/pull/10571#issuecomment-823663124 Can I get a quick +1 @wcarlson5 @lct45 @cadonna @rodesai @vvcephei -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] ableegoldman opened a new pull request #10571: HOTFIX: remove unimplemented SPILL_TO_DISK buffer full strategy

2021-04-20 Thread GitBox
ableegoldman opened a new pull request #10571: URL: https://github.com/apache/kafka/pull/10571 We haven't yet found the time to implement spill-to-disk for the suppression buffer, so we should remove the `SPILL_TO_DISK` enum to avoid confusion. Technically this enum is in an internal

[GitHub] [kafka] cmccabe commented on a change in pull request #10561: KAFKA-12686 AlterIsr and LeaderAndIsr race condition

2021-04-20 Thread GitBox
cmccabe commented on a change in pull request #10561: URL: https://github.com/apache/kafka/pull/10561#discussion_r617078726 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1341,13 +1335,15 @@ class Partition(val topicPartition: TopicPartition,

[jira] [Updated] (KAFKA-12682) Kraft MetadataPartitionsBuilder _localChanged and _localRemoved out of order

2021-04-20 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-12682: Labels: kip-500 (was: ) > Kraft MetadataPartitionsBuilder _localChanged and

[GitHub] [kafka] ableegoldman commented on a change in pull request #10544: KAFKA-12648: minimum changes for error handling namedTopologies

2021-04-20 Thread GitBox
ableegoldman commented on a change in pull request #10544: URL: https://github.com/apache/kafka/pull/10544#discussion_r617027950 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -471,6 +472,10 @@ private void replaceStreamThread(final

[GitHub] [kafka] wcarlson5 commented on pull request #10543: KAFKA-12648: tag uses of StreamsException to add Named to

2021-04-20 Thread GitBox
wcarlson5 commented on pull request #10543: URL: https://github.com/apache/kafka/pull/10543#issuecomment-823594600 https://github.com/apache/kafka/pull/10544 I have a draft for the other part as well -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (KAFKA-10154) Issue in updating metadata if not exists during sending message to different topics

2021-04-20 Thread Taras Danylchuk (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326101#comment-17326101 ] Taras Danylchuk commented on KAFKA-10154: - We are experiencing the same issue when trying to

[GitHub] [kafka] ableegoldman opened a new pull request #10570: MINOR: Bump to latest version 2.6.2

2021-04-20 Thread GitBox
ableegoldman opened a new pull request #10570: URL: https://github.com/apache/kafka/pull/10570 To be merged once the release artifacts for 2.6.2 show up in Maven central -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] rhauch commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-20 Thread GitBox
rhauch commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r617008391 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -208,6 +220,21 @@ protected void

[GitHub] [kafka] kpatelatwork commented on pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-20 Thread GitBox
kpatelatwork commented on pull request #10549: URL: https://github.com/apache/kafka/pull/10549#issuecomment-823575141 @rhauch Good suggestions, I applied them to the PR. When you get time could you please review if they look good? -- This is an automated message from the Apache

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-20 Thread GitBox
kpatelatwork commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r617005037 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -208,6 +220,21 @@ protected

[jira] [Commented] (KAFKA-12696) Add standard getters to LagInfo class to allow automatic serialization

2021-04-20 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326075#comment-17326075 ] A. Sophie Blee-Goldman commented on KAFKA-12696: Thanks for the PR [~mihasya]. You need

[jira] [Assigned] (KAFKA-12696) Add standard getters to LagInfo class to allow automatic serialization

2021-04-20 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12696: -- Assignee: Mikhail Panchenko > Add standard getters to LagInfo class

[GitHub] [kafka] rhauch commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-20 Thread GitBox
rhauch commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r616994286 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -208,6 +220,21 @@ protected void

[GitHub] [kafka] ableegoldman commented on pull request #10543: KAFKA-12648: tag uses of StreamsException to add Named to

2021-04-20 Thread GitBox
ableegoldman commented on pull request #10543: URL: https://github.com/apache/kafka/pull/10543#issuecomment-823549804 Thanks for the draft -- I haven't looked through it in detail but I think I got the gist of it. One thing I’m wondering is whether we need to track down and update each

[GitHub] [kafka] mihasya commented on pull request #10569: KAFKA-12696: Adds standardized getters to LagInfo class

2021-04-20 Thread GitBox
mihasya commented on pull request #10569: URL: https://github.com/apache/kafka/pull/10569#issuecomment-823541177 @vvcephei Looks like you merged the original code. Hoping this is pretty easy, but let me know if I missed anything. Cheers. -- This is an automated message from the Apache

[jira] [Commented] (KAFKA-12696) Add standard getters to LagInfo class to allow automatic serialization

2021-04-20 Thread Mikhail Panchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326051#comment-17326051 ] Mikhail Panchenko commented on KAFKA-12696: --- PR: https://github.com/apache/kafka/pull/10569 >

[GitHub] [kafka] mihasya opened a new pull request #10569: KAFKA-12696: Adds standardized getters to LagInfo class

2021-04-20 Thread GitBox
mihasya opened a new pull request #10569: URL: https://github.com/apache/kafka/pull/10569 This allows Jackson and other serialization libraries to serialize this object without any additional annotation, wrapping, injection etc. Existing methods are now marked as deprecated. Tests

[GitHub] [kafka] kpatelatwork edited a comment on pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-20 Thread GitBox
kpatelatwork edited a comment on pull request #10530: URL: https://github.com/apache/kafka/pull/10530#issuecomment-822663074 @tombentley could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Created] (KAFKA-12698) CVE-2019-25013 vulnerability reported in Kafka

2021-04-20 Thread priya Vijay (Jira)
priya Vijay created KAFKA-12698: --- Summary: CVE-2019-25013 vulnerability reported in Kafka Key: KAFKA-12698 URL: https://issues.apache.org/jira/browse/KAFKA-12698 Project: Kafka Issue Type:

[jira] [Created] (KAFKA-12697) Add GlobalTopicCount and GlobalPartitionCount metrics to QuorumController

2021-04-20 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-12697: - Summary: Add GlobalTopicCount and GlobalPartitionCount metrics to QuorumController Key: KAFKA-12697 URL: https://issues.apache.org/jira/browse/KAFKA-12697 Project:

[GitHub] [kafka] kpatelatwork removed a comment on pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-20 Thread GitBox
kpatelatwork removed a comment on pull request #10530: URL: https://github.com/apache/kafka/pull/10530#issuecomment-819667966 @kkonstantine and @rhauch Could one of you please review and merge this. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] junrao commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-20 Thread GitBox
junrao commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r616879405 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataContextSerdes.java ## @@ -0,0

[GitHub] [kafka] dejan2609 edited a comment on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration (`testRuntime` -->> `testRuntimeClasspath`)

2021-04-20 Thread GitBox
dejan2609 edited a comment on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-821968689 > Could we reintroduce a configuration that behaves the same as `testRuntime` did before it was removed? @ijuma Can you please expand on this ? Are you

[GitHub] [kafka] kpatelatwork edited a comment on pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-20 Thread GitBox
kpatelatwork edited a comment on pull request #10530: URL: https://github.com/apache/kafka/pull/10530#issuecomment-823359381 @tombentley Thanks for the comments, I resolved all of them :). When you get time could you please review again to see if it looks good? -- This is an automated

[GitHub] [kafka] kowshik commented on pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

2021-04-20 Thread GitBox
kowshik commented on pull request #10478: URL: https://github.com/apache/kafka/pull/10478#issuecomment-823441394 I checked the failed tests in CI this morning and none of them are related with this PR: ``` org.apache.kafka.connect.*

[jira] [Updated] (KAFKA-12696) Add standard getters to LagInfo class to allow automatic serialization

2021-04-20 Thread Mikhail Panchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Panchenko updated KAFKA-12696: -- Remaining Estimate: 0.5h (was: 5m) Original Estimate: 0.5h (was: 5m) > Add

[jira] [Commented] (KAFKA-12696) Add standard getters to LagInfo class to allow automatic serialization

2021-04-20 Thread Mikhail Panchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325947#comment-17325947 ] Mikhail Panchenko commented on KAFKA-12696: --- The [contributing

[jira] [Created] (KAFKA-12696) Add standard getters to LagInfo class to allow automatic serialization

2021-04-20 Thread Mikhail Panchenko (Jira)
Mikhail Panchenko created KAFKA-12696: - Summary: Add standard getters to LagInfo class to allow automatic serialization Key: KAFKA-12696 URL: https://issues.apache.org/jira/browse/KAFKA-12696

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-20 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r616851984 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataContextSerdes.java ## @@ -0,0

[jira] [Resolved] (KAFKA-12553) Refactor Log layer recovery logic

2021-04-20 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-12553. - Fix Version/s: 3.0.0 Resolution: Fixed merged the PR to trunk > Refactor Log layer recovery

[GitHub] [kafka] junrao merged pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

2021-04-20 Thread GitBox
junrao merged pull request #10478: URL: https://github.com/apache/kafka/pull/10478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] kpatelatwork commented on pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-20 Thread GitBox
kpatelatwork commented on pull request #10549: URL: https://github.com/apache/kafka/pull/10549#issuecomment-823396793 Thanks @rhauch very good suggestions. I applied all of them. Please check again. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-20 Thread GitBox
kpatelatwork commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r616821920 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -208,6 +223,19 @@ protected

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-20 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-823384191 @ableegoldman Did you have time to look at it? Let me know if you need more context on my comments. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] kpatelatwork commented on pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-20 Thread GitBox
kpatelatwork commented on pull request #10530: URL: https://github.com/apache/kafka/pull/10530#issuecomment-823359381 @tombentley Thanks for the comments, I resolved all of them :). Could you please review again and merge? -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-20 Thread GitBox
kpatelatwork commented on a change in pull request #10530: URL: https://github.com/apache/kafka/pull/10530#discussion_r616783892 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java ## @@ -369,9 +370,31 @@ else if (serverConnector

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10565: KAFKA-12691: Add case where task can be considered idling

2021-04-20 Thread GitBox
wcarlson5 commented on a change in pull request #10565: URL: https://github.com/apache/kafka/pull/10565#discussion_r616777330 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -692,6 +699,7 @@ public boolean process(final

[GitHub] [kafka] rhauch commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-20 Thread GitBox
rhauch commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r616765881 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -153,12 +156,25 @@ public

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-20 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r616762075 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -118,20 +142,47 @@ final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-20 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r616759894 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java ## @@ -0,0 +1,849 @@ +/* + * Licensed to

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-20 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r616758960 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -60,20 +83,44 @@ } private class

[GitHub] [kafka] rhauch commented on pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

2021-04-20 Thread GitBox
rhauch commented on pull request #10549: URL: https://github.com/apache/kafka/pull/10549#issuecomment-823335289 Several green builds (but failures on publishing results), and one Streams unit test failure unrelated to this PR (or Connect). -- This is an automated message from the Apache

[GitHub] [kafka] mumrah commented on a change in pull request #10561: KAFKA-12686 AlterIsr and LeaderAndIsr race condition

2021-04-20 Thread GitBox
mumrah commented on a change in pull request #10561: URL: https://github.com/apache/kafka/pull/10561#discussion_r616723660 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1341,13 +1335,15 @@ class Partition(val topicPartition: TopicPartition,

[GitHub] [kafka] alecthomas commented on pull request #10567: Ensure `ignorable` is a boolean value.

2021-04-20 Thread GitBox
alecthomas commented on pull request #10567: URL: https://github.com/apache/kafka/pull/10567#issuecomment-823235137 It does yes. I found it because I'm looking at generating encoders/decoders from these files. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] dajac commented on pull request #10567: Ensure `ignorable` is a boolean value.

2021-04-20 Thread GitBox
dajac commented on pull request #10567: URL: https://github.com/apache/kafka/pull/10567#issuecomment-823233560 @alecthomas Thanks for the patch. How have you found this? Does it cause any failures? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (KAFKA-12695) KStream.toTable must be extended to allow for a specific Serde

2021-04-20 Thread Yura Nosenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yura Nosenko updated KAFKA-12695: - Description: KStream.toTable seems to not be as useful as it can.`KStream.toTable` seems to

[jira] [Created] (KAFKA-12695) KStream.toTable must be extended to allow for a specific Serde

2021-04-20 Thread Yura Nosenko (Jira)
Yura Nosenko created KAFKA-12695: Summary: KStream.toTable must be extended to allow for a specific Serde Key: KAFKA-12695 URL: https://issues.apache.org/jira/browse/KAFKA-12695 Project: Kafka

[jira] [Updated] (KAFKA-12695) KStream.toTable must be extended to allow for a specific Serde

2021-04-20 Thread Yura Nosenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yura Nosenko updated KAFKA-12695: - Description: KStream.toTable seems to not be as useful as it can.`KStream.toTable` seems to

[GitHub] [kafka] showuon edited a comment on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-20 Thread GitBox
showuon edited a comment on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-816379867 @ableegoldman , please help review this PR. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] tombentley commented on a change in pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-20 Thread GitBox
tombentley commented on a change in pull request #10530: URL: https://github.com/apache/kafka/pull/10530#discussion_r616468886 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java ## @@ -369,9 +370,31 @@ else if (serverConnector !=

[GitHub] [kafka] cadonna opened a new pull request #10568: KAFKA-8897: Upgrade RocksDB

2021-04-20 Thread GitBox
cadonna opened a new pull request #10568: URL: https://github.com/apache/kafka/pull/10568 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] kowshik commented on pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

2021-04-20 Thread GitBox
kowshik commented on pull request #10478: URL: https://github.com/apache/kafka/pull/10478#issuecomment-823118678 Thanks for the review @junrao and @satishd! I've updated this PR after rebasing onto latest commit in trunk. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dongjinleekr commented on pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-04-20 Thread GitBox
dongjinleekr commented on pull request #10428: URL: https://github.com/apache/kafka/pull/10428#issuecomment-823105420 Hi @cadonna, Here is the fix. 1. Added a license header to eclipse-formatter.xml. 2. Re-add line break formatting with 200 characters. (It resolved lots of

[GitHub] [kafka] highluck commented on pull request #9640: KAFKA-10283; Consolidate client-level and consumer-level assignment within ClientState

2021-04-20 Thread GitBox
highluck commented on pull request #9640: URL: https://github.com/apache/kafka/pull/9640#issuecomment-823100171 @guozhangwang The code has been modified. Thank you for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] chia7712 merged pull request #10551: MINOR: Fix nonsense test line from TopicCommandTest

2021-04-20 Thread GitBox
chia7712 merged pull request #10551: URL: https://github.com/apache/kafka/pull/10551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-04-20 Thread GitBox
dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r616452256 ## File path: eclipse-formatter.xml ## @@ -0,0 +1,52 @@ + Review comment: OMG, I omitted it in the last update. :sweat: -- This is an

[GitHub] [kafka] wenbingshen commented on pull request #10551: MINOR: Fix nonsense test line from TopicCommandTest

2021-04-20 Thread GitBox
wenbingshen commented on pull request #10551: URL: https://github.com/apache/kafka/pull/10551#issuecomment-823076892 > @wenbingshen thanks for your patch. LGTM > > Could you revise the title of this PR? I'd like to merge it tomorrow. I think the failed test is unrelated to

[GitHub] [kafka] alecthomas opened a new pull request #10567: Ensure `ignorable` is a boolean value.

2021-04-20 Thread GitBox
alecthomas opened a new pull request #10567: URL: https://github.com/apache/kafka/pull/10567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [kafka] showuon edited a comment on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-20 Thread GitBox
showuon edited a comment on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-823030049 jenkins test results after my change: **(avg. 2 sec)** ``` Build / JDK 8 and Scala 2.12 / testLargeAssignmentAndGroupWithUniformSubscription() | 1.8 sec | Passed

[GitHub] [kafka] Naros opened a new pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

2021-04-20 Thread GitBox
Naros opened a new pull request #10566: URL: https://github.com/apache/kafka/pull/10566 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[jira] [Commented] (KAFKA-12464) Enhance constrained sticky Assign algorithm

2021-04-20 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325546#comment-17325546 ] Luke Chen commented on KAFKA-12464: --- Another improvement is implemented (check

[GitHub] [kafka] showuon edited a comment on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-20 Thread GitBox
showuon edited a comment on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-822975764 @ableegoldman (cc. @guozhangwang) After completing the sticky general assignor improvement (https://github.com/apache/kafka/pull/10552), I started to think... why

[GitHub] [kafka] showuon commented on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-20 Thread GitBox
showuon commented on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-823030049 jenkins test results after my change: **(avg. 2 sec)** ``` Build / JDK 8 and Scala 2.12 / testLargeAssignmentAndGroupWithUniformSubscription() | 1.8 sec | Passed Build

[jira] [Updated] (KAFKA-12694) Specifying a struct-based defaultValue on a SchemaBuilder causes a DataException

2021-04-20 Thread Chris Cranford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Cranford updated KAFKA-12694: --- Description: When making a call to {{SchemaBuilder#defaultValue(Object)}} a

[jira] [Updated] (KAFKA-12694) Specifying a struct-based defaultValue on a SchemaBuilder causes a DataException

2021-04-20 Thread Chris Cranford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Cranford updated KAFKA-12694: --- Description: When making a call to {{SchemaBuilder#defaultValue(Object)}} a

[jira] [Created] (KAFKA-12694) Specifying a struct-based defaultValue on a SchemaBuilder causes a DataException

2021-04-20 Thread Chris Cranford (Jira)
Chris Cranford created KAFKA-12694: -- Summary: Specifying a struct-based defaultValue on a SchemaBuilder causes a DataException Key: KAFKA-12694 URL: https://issues.apache.org/jira/browse/KAFKA-12694

[GitHub] [kafka] dongjinleekr commented on pull request #10472: KAFKA-12613: Inconsistencies between Kafka Config and Log Config

2021-04-20 Thread GitBox
dongjinleekr commented on pull request #10472: URL: https://github.com/apache/kafka/pull/10472#issuecomment-823019302 @guozhangwang @kkonstantine Could you have a look? I think this issue should be addressed in 3.0.0. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] guozhangwang commented on a change in pull request #10460: KAFKA-10357: Use validate and setup during internal topics creation

2021-04-20 Thread GitBox
guozhangwang commented on a change in pull request #10460: URL: https://github.com/apache/kafka/pull/10460#discussion_r616386557 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -374,194 +356,18 @@ private String

[GitHub] [kafka] chia7712 commented on pull request #10402: MINOR: Remove unthrown exceptions, fix typo, etc.

2021-04-20 Thread GitBox
chia7712 commented on pull request #10402: URL: https://github.com/apache/kafka/pull/10402#issuecomment-822997580 > This PR seems already approved but not merged yet. Could you have a look? oh, sorry for neglecting this PR :( Will commit it if QA pass. -- This is an

[GitHub] [kafka] dongjinleekr commented on pull request #7891: MINOR: Group KafkaController, ReplicaManager metrics in documentation

2021-04-20 Thread GitBox
dongjinleekr commented on pull request #7891: URL: https://github.com/apache/kafka/pull/7891#issuecomment-822996611 @tombentley Could you have a look? This PR addresses some trivial glitches in the documentation. -- This is an automated message from the Apache Git Service. To respond to