dongjinleekr commented on pull request #10402:
URL: https://github.com/apache/kafka/pull/10402#issuecomment-823825975
@chia7712 🙇🙇🙇
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
[
https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326297#comment-17326297
]
dengziming commented on KAFKA-12701:
Describe a topic using topicId is not supported
[
https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming reassigned KAFKA-12701:
--
Assignee: dengziming
> NPE in MetadataRequest when using topic IDs
>
chia7712 commented on pull request #10561:
URL: https://github.com/apache/kafka/pull/10561#issuecomment-823812473
@mumrah thanks for this patch.
> Clearing unsent ISR updates is not really necessary after a leader
election since the updates will fail due to a stale leader epoch.
Travis Bischel created KAFKA-12701:
--
Summary: NPE in MetadataRequest when using topic IDs
Key: KAFKA-12701
URL: https://issues.apache.org/jira/browse/KAFKA-12701
Project: Kafka
Issue Type: B
[
https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Travis Bischel updated KAFKA-12671:
---
Priority: Critical (was: Major)
> Out of order processing with a transactional producer can
vamossagar12 commented on pull request #10542:
URL: https://github.com/apache/kafka/pull/10542#issuecomment-823770411
hey @ableegoldman , plz review whenever you get the chance..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
[
https://issues.apache.org/jira/browse/KAFKA-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326223#comment-17326223
]
Walker Carlson commented on KAFKA-12699:
I would not say its a bug per-say but I
[
https://issues.apache.org/jira/browse/KAFKA-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326215#comment-17326215
]
A. Sophie Blee-Goldman commented on KAFKA-12699:
To be fair, I think cla
cmccabe commented on pull request #10564:
URL: https://github.com/apache/kafka/pull/10564#issuecomment-823736138
@junrao : BTW, when do you think we should change away from a working leader
to the preferred leader?
I guess when auto leader balancing is enabled and we're doing a perio
chia7712 merged pull request #10402:
URL: https://github.com/apache/kafka/pull/10402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
cmccabe commented on a change in pull request #10564:
URL: https://github.com/apache/kafka/pull/10564#discussion_r617160661
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -1119,6 +1053,61 @@ void validateManualPartitionAss
ableegoldman merged pull request #10571:
URL: https://github.com/apache/kafka/pull/10571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
ableegoldman commented on pull request #10571:
URL: https://github.com/apache/kafka/pull/10571#issuecomment-823722622
Just the usual unrelated failures in `RaftClusterTest` and
`MirrorConnectorsIntegrationTest`
--
This is an automated message from the Apache Git Service.
To respond to th
ableegoldman opened a new pull request #10573:
URL: https://github.com/apache/kafka/pull/10573
Deprecates and logs a warning upon usage of the following:
- StreamsConfig.EXACTLY_ONCE
- StreamsConfig.EXACTLY_ONCE_BETA
- Producer#sendOffsetsToTransaction(Map offsets, String consumerGr
cmccabe edited a comment on pull request #10572:
URL: https://github.com/apache/kafka/pull/10572#issuecomment-823721422
Hi @dielhennr, thanks for the PR!
I think it would be simpler to have `ControllerMetrics#setGlobalTopicsCount`
/ `ControllerMetrics#globalTopicsCount` rather than i
cmccabe commented on pull request #10572:
URL: https://github.com/apache/kafka/pull/10572#issuecomment-823721422
Hi @dielhennr, thanks for the PR!
I think it would be simpler to have `ControllerMetrics#setGlobalTopicsCount`
/ `ControllerMetrics#globalTopicsCount` rather than inc / de
wcarlson5 commented on a change in pull request #10565:
URL: https://github.com/apache/kafka/pull/10565#discussion_r617150453
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -692,6 +699,7 @@ public boolean process(final lo
mjsax commented on pull request #10565:
URL: https://github.com/apache/kafka/pull/10565#issuecomment-823719998
Btw: can we add some tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
mjsax commented on a change in pull request #10565:
URL: https://github.com/apache/kafka/pull/10565#discussion_r617150002
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -692,6 +699,7 @@ public boolean process(final long w
mjsax commented on pull request #10569:
URL: https://github.com/apache/kafka/pull/10569#issuecomment-823712852
This PR proposes a public API change and a KIP is required before it could
be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
[
https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12696:
Labels: needs-kip (was: )
> Add standard getters to LagInfo class to allow automatic seri
[
https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326192#comment-17326192
]
Matthias J. Sax commented on KAFKA-12696:
-
[~mihasya] – two comments:
# This ti
[
https://issues.apache.org/jira/browse/KAFKA-12695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326191#comment-17326191
]
Matthias J. Sax commented on KAFKA-12695:
-
Thanks for reporting this. Seems that
A. Sophie Blee-Goldman created KAFKA-12700:
--
Summary: The admin.listeners config has wonky valid values in the
docs
Key: KAFKA-12700
URL: https://issues.apache.org/jira/browse/KAFKA-12700
Pro
[
https://issues.apache.org/jira/browse/KAFKA-12695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12695:
Labels: scala (was: )
> KStream.toTable must be extended to allow for a specific Serde
Walker Carlson created KAFKA-12699:
--
Summary: Streams no longer overrides the java default uncaught
exception handler
Key: KAFKA-12699
URL: https://issues.apache.org/jira/browse/KAFKA-12699
Project
[
https://issues.apache.org/jira/browse/KAFKA-12666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326190#comment-17326190
]
Matthias J. Sax commented on KAFKA-12666:
-
Different method: {{testCreateCluster
[
https://issues.apache.org/jira/browse/KAFKA-12511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326188#comment-17326188
]
Matthias J. Sax commented on KAFKA-12511:
-
Failed again:
[https://github.com/ap
mjsax commented on a change in pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#discussion_r617136596
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java
##
@@ -73,6 +76,7 @@
public boolean
[
https://issues.apache.org/jira/browse/KAFKA-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326184#comment-17326184
]
Ryan Dielhenn commented on KAFKA-12697:
---
https://github.com/apache/kafka/pull/1057
dielhennr opened a new pull request #10572:
URL: https://github.com/apache/kafka/pull/10572
Added GlobalTopicCount and GlobalPartitionCount metrics to the
QuorumController.
The metrics are calculated by counting records as they are replayed e.g.
replay(TopicRecord), replay(RemoveTop
junrao commented on a change in pull request #10564:
URL: https://github.com/apache/kafka/pull/10564#discussion_r617093936
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -1119,6 +1053,61 @@ void validateManualPartitionAssi
ableegoldman commented on pull request #10571:
URL: https://github.com/apache/kafka/pull/10571#issuecomment-823663124
Can I get a quick +1 @wcarlson5 @lct45 @cadonna @rodesai @vvcephei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
ableegoldman opened a new pull request #10571:
URL: https://github.com/apache/kafka/pull/10571
We haven't yet found the time to implement spill-to-disk for the suppression
buffer, so we should remove the `SPILL_TO_DISK` enum to avoid confusion.
Technically this enum is in an internal pack
cmccabe commented on a change in pull request #10561:
URL: https://github.com/apache/kafka/pull/10561#discussion_r617078726
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1341,13 +1335,15 @@ class Partition(val topicPartition: TopicPartition,
isrSta
[
https://issues.apache.org/jira/browse/KAFKA-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-12682:
Labels: kip-500 (was: )
> Kraft MetadataPartitionsBuilder _localChanged and _localRemoved
ableegoldman commented on a change in pull request #10544:
URL: https://github.com/apache/kafka/pull/10544#discussion_r617027950
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -471,6 +472,10 @@ private void replaceStreamThread(final Throwab
wcarlson5 commented on pull request #10543:
URL: https://github.com/apache/kafka/pull/10543#issuecomment-823594600
https://github.com/apache/kafka/pull/10544 I have a draft for the other part
as well
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326101#comment-17326101
]
Taras Danylchuk commented on KAFKA-10154:
-
We are experiencing the same issue wh
ableegoldman opened a new pull request #10570:
URL: https://github.com/apache/kafka/pull/10570
To be merged once the release artifacts for 2.6.2 show up in Maven central
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
rhauch commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r617008391
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##
@@ -208,6 +220,21 @@ protected void i
kpatelatwork commented on pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#issuecomment-823575141
@rhauch Good suggestions, I applied them to the PR.
When you get time could you please review if they look good?
--
This is an automated message from the Apache Gi
kpatelatwork commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r617005037
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##
@@ -208,6 +220,21 @@ protected
[
https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326075#comment-17326075
]
A. Sophie Blee-Goldman commented on KAFKA-12696:
Thanks for the PR [~mih
[
https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman reassigned KAFKA-12696:
--
Assignee: Mikhail Panchenko
> Add standard getters to LagInfo class t
rhauch commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r616994286
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##
@@ -208,6 +220,21 @@ protected void i
ableegoldman commented on pull request #10543:
URL: https://github.com/apache/kafka/pull/10543#issuecomment-823549804
Thanks for the draft -- I haven't looked through it in detail but I think I
got the gist of it. One thing I’m wondering is whether we need to track down
and update each and
mihasya commented on pull request #10569:
URL: https://github.com/apache/kafka/pull/10569#issuecomment-823541177
@vvcephei Looks like you merged the original code. Hoping this is pretty
easy, but let me know if I missed anything. Cheers.
--
This is an automated message from the Apache Gi
[
https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326051#comment-17326051
]
Mikhail Panchenko commented on KAFKA-12696:
---
PR:Â https://github.com/apache/kaf
mihasya opened a new pull request #10569:
URL: https://github.com/apache/kafka/pull/10569
This allows Jackson and other serialization libraries to serialize this
object without any additional annotation, wrapping, injection etc.
Existing methods are now marked as deprecated. Tests
kpatelatwork edited a comment on pull request #10530:
URL: https://github.com/apache/kafka/pull/10530#issuecomment-822663074
@tombentley could you please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
priya Vijay created KAFKA-12698:
---
Summary: CVE-2019-25013 vulnerability reported in Kafka
Key: KAFKA-12698
URL: https://issues.apache.org/jira/browse/KAFKA-12698
Project: Kafka
Issue Type: Bug
Ryan Dielhenn created KAFKA-12697:
-
Summary: Add GlobalTopicCount and GlobalPartitionCount metrics to
QuorumController
Key: KAFKA-12697
URL: https://issues.apache.org/jira/browse/KAFKA-12697
Project:
kpatelatwork removed a comment on pull request #10530:
URL: https://github.com/apache/kafka/pull/10530#issuecomment-819667966
@kkonstantine and @rhauch Could one of you please review and merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
junrao commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r616879405
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataContextSerdes.java
##
@@ -0,0 +1,12
dejan2609 edited a comment on pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#issuecomment-821968689
> Could we reintroduce a configuration that behaves the same as
`testRuntime` did before it was removed?
@ijuma Can you please expand on this ? Are you referring
kpatelatwork edited a comment on pull request #10530:
URL: https://github.com/apache/kafka/pull/10530#issuecomment-823359381
@tombentley Thanks for the comments, I resolved all of them :). When you get
time could you please review again to see if it looks good?
--
This is an automated me
kowshik commented on pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#issuecomment-823441394
I checked the failed tests in CI this morning and none of them are related
with this PR:
```
org.apache.kafka.connect.*
kafka.admin.ResetConsumerGroupOffsetTest.test
[
https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Panchenko updated KAFKA-12696:
--
Remaining Estimate: 0.5h (was: 5m)
Original Estimate: 0.5h (was: 5m)
> Add stan
[
https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325947#comment-17325947
]
Mikhail Panchenko commented on KAFKA-12696:
---
The [contributing
docs|https://c
Mikhail Panchenko created KAFKA-12696:
-
Summary: Add standard getters to LagInfo class to allow automatic
serialization
Key: KAFKA-12696
URL: https://issues.apache.org/jira/browse/KAFKA-12696
Proj
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r616851984
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataContextSerdes.java
##
@@ -0,0 +1,1
[
https://issues.apache.org/jira/browse/KAFKA-12553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-12553.
-
Fix Version/s: 3.0.0
Resolution: Fixed
merged the PR to trunk
> Refactor Log layer recovery logi
junrao merged pull request #10478:
URL: https://github.com/apache/kafka/pull/10478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
kpatelatwork commented on pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#issuecomment-823396793
Thanks @rhauch very good suggestions. I applied all of them. Please check
again.
--
This is an automated message from the Apache Git Service.
To respond to the message,
kpatelatwork commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r616821920
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##
@@ -208,6 +223,19 @@ protected
yeralin commented on pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#issuecomment-823384191
@ableegoldman Did you have time to look at it? Let me know if you need more
context on my comments.
--
This is an automated message from the Apache Git Service.
To respond to th
kpatelatwork commented on pull request #10530:
URL: https://github.com/apache/kafka/pull/10530#issuecomment-823359381
@tombentley Thanks for the comments, I resolved all of them :). Could you
please review again and merge?
--
This is an automated message from the Apache Git Service.
To r
kpatelatwork commented on a change in pull request #10530:
URL: https://github.com/apache/kafka/pull/10530#discussion_r616783892
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java
##
@@ -369,9 +370,31 @@ else if (serverConnector !
wcarlson5 commented on a change in pull request #10565:
URL: https://github.com/apache/kafka/pull/10565#discussion_r616777330
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -692,6 +699,7 @@ public boolean process(final lo
rhauch commented on a change in pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#discussion_r616765881
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java
##
@@ -153,12 +156,25 @@ public PluginCl
spena commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r616762075
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java
##
@@ -118,20 +142,47 @@
final ProcessorGraphN
spena commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r616759894
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java
##
@@ -0,0 +1,849 @@
+/*
+ * Licensed to th
spena commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r616758960
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##
@@ -60,20 +83,44 @@
}
private class K
rhauch commented on pull request #10549:
URL: https://github.com/apache/kafka/pull/10549#issuecomment-823335289
Several green builds (but failures on publishing results), and one Streams
unit test failure unrelated to this PR (or Connect).
--
This is an automated message from the Apache
mumrah commented on a change in pull request #10561:
URL: https://github.com/apache/kafka/pull/10561#discussion_r616723660
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1341,13 +1335,15 @@ class Partition(val topicPartition: TopicPartition,
isrStat
alecthomas commented on pull request #10567:
URL: https://github.com/apache/kafka/pull/10567#issuecomment-823235137
It does yes. I found it because I'm looking at generating encoders/decoders
from these files.
--
This is an automated message from the Apache Git Service.
To respond to the
dajac commented on pull request #10567:
URL: https://github.com/apache/kafka/pull/10567#issuecomment-823233560
@alecthomas Thanks for the patch. How have you found this? Does it cause any
failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
[
https://issues.apache.org/jira/browse/KAFKA-12695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yura Nosenko updated KAFKA-12695:
-
Description:
KStream.toTable seems to not be as useful as it can.`KStream.toTable` seems to
not
Yura Nosenko created KAFKA-12695:
Summary: KStream.toTable must be extended to allow for a specific
Serde
Key: KAFKA-12695
URL: https://issues.apache.org/jira/browse/KAFKA-12695
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-12695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yura Nosenko updated KAFKA-12695:
-
Description:
KStream.toTable seems to not be as useful as it can.`KStream.toTable` seems to
not
showuon edited a comment on pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#issuecomment-816379867
@ableegoldman , please help review this PR. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
tombentley commented on a change in pull request #10530:
URL: https://github.com/apache/kafka/pull/10530#discussion_r616468886
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java
##
@@ -369,9 +370,31 @@ else if (serverConnector !=
cadonna opened a new pull request #10568:
URL: https://github.com/apache/kafka/pull/10568
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade n
kowshik commented on pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#issuecomment-823118678
Thanks for the review @junrao and @satishd! I've updated this PR after
rebasing onto latest commit in trunk.
--
This is an automated message from the Apache Git Service.
To re
dongjinleekr commented on pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#issuecomment-823105420
Hi @cadonna, Here is the fix.
1. Added a license header to eclipse-formatter.xml.
2. Re-add line break formatting with 200 characters. (It resolved lots of
formatt
highluck commented on pull request #9640:
URL: https://github.com/apache/kafka/pull/9640#issuecomment-823100171
@guozhangwang
The code has been modified.
Thank you for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chia7712 merged pull request #10551:
URL: https://github.com/apache/kafka/pull/10551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r616452256
##
File path: eclipse-formatter.xml
##
@@ -0,0 +1,52 @@
+
Review comment:
OMG, I omitted it in the last update. :sweat:
--
This is an au
wenbingshen commented on pull request #10551:
URL: https://github.com/apache/kafka/pull/10551#issuecomment-823076892
> @wenbingshen thanks for your patch. LGTM
>
> Could you revise the title of this PR? I'd like to merge it tomorrow.
I think the failed test is unrelated to thi
alecthomas opened a new pull request #10567:
URL: https://github.com/apache/kafka/pull/10567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
showuon edited a comment on pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#issuecomment-823030049
jenkins test results after my change: **(avg. 2 sec)**
```
Build / JDK 8 and Scala 2.12 /
testLargeAssignmentAndGroupWithUniformSubscription() | 1.8 sec | Passed
Naros opened a new pull request #10566:
URL: https://github.com/apache/kafka/pull/10566
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade not
[
https://issues.apache.org/jira/browse/KAFKA-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325546#comment-17325546
]
Luke Chen commented on KAFKA-12464:
---
Another improvement is implemented (check
https:
showuon edited a comment on pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#issuecomment-822975764
@ableegoldman (cc. @guozhangwang)
After completing the sticky general assignor improvement
(https://github.com/apache/kafka/pull/10552), I started to think... why don't
showuon commented on pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#issuecomment-823030049
jenkins test results after my change: **(avg. 2 sec)**
```
Build / JDK 8 and Scala 2.12 /
testLargeAssignmentAndGroupWithUniformSubscription() | 1.8 sec | Passed
Build /
[
https://issues.apache.org/jira/browse/KAFKA-12694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Cranford updated KAFKA-12694:
---
Description:
When making a call to {{SchemaBuilder#defaultValue(Object)}} a
{{DataException
[
https://issues.apache.org/jira/browse/KAFKA-12694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Cranford updated KAFKA-12694:
---
Description:
When making a call to {{SchemaBuilder#defaultValue(Object)}} a
{{DataException
Chris Cranford created KAFKA-12694:
--
Summary: Specifying a struct-based defaultValue on a SchemaBuilder
causes a DataException
Key: KAFKA-12694
URL: https://issues.apache.org/jira/browse/KAFKA-12694
100 matches
Mail list logo
