[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1341666380 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1341666380 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1341662210 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignorSelection.java: ## @@ -56,7 +57,7 @@ public static AssignorSelection defaultAssignor() {

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1340176254 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337639317 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337428627 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337309504 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -58,7 +59,7 @@ public class HeartbeatRequestManagerTest

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337295428 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -173,24 +194,22 @@ public void

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337282860 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337282271 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337278130 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java: ## @@ -59,4 +59,20 @@ public interface MembershipManager { * current

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337275381 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337275381 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337269007 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337265790 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337263803 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337258265 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337239851 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337238424 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337235694 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1337234985 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1335307959 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1335309021 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1335307959 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1335304701 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1335297785 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1335295791 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -115,25 +115,37 @@ public int memberEpoch() { @Override

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1335289660 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334668800 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334659219 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334657428 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334652824 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334645635 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334636930 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334633010 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334633010 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1334626047 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -190,13 +194,23 @@ public DefaultBackgroundThread(final Time

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1333629206 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1333624789 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignorSelection.java: ## @@ -79,6 +80,9 @@ public int hashCode() { @Override public

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1333624789 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignorSelection.java: ## @@ -79,6 +80,9 @@ public int hashCode() { @Override public

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1332115559 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -115,25 +114,30 @@ public int memberEpoch() { @Override

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1332115559 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -115,25 +114,30 @@ public int memberEpoch() { @Override

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1332093119 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1332077647 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1332069325 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1332064354 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1332041024 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -168,28 +171,41 @@ public DefaultBackgroundThread(final Time

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1332038622 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -168,28 +171,41 @@ public DefaultBackgroundThread(final Time

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1332033928 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -106,7 +108,8 @@ public class DefaultBackgroundThread extends

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1332033298 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignorSelection.java: ## @@ -79,6 +80,9 @@ public int hashCode() { @Override public

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1332028195 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignorSelection.java: ## @@ -30,12 +31,12 @@ public class AssignorSelection { public enum

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1331997791 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java: ## @@ -59,4 +59,21 @@ public interface MembershipManager { * current

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1331948509 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -158,27 +165,27 @@ private void onSuccess(final

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1331944957 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -146,8 +152,9 @@ private void onFailure(final Throwable

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1331828912 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -146,8 +152,9 @@ private void onFailure(final Throwable

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1331811249 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -158,27 +165,27 @@ private void onSuccess(final

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1331809403 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -115,31 +115,34 @@ public int memberEpoch() { @Override

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1330319691 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1330319691 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1330246922 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -136,6 +136,12 @@ public void

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1329227271 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1329227271 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1326478655 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1326463429 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1326089090 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1326031428 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1325999433 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -168,28 +171,41 @@ public DefaultBackgroundThread(final Time

[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1325999433 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -168,28 +171,41 @@ public DefaultBackgroundThread(final Time