dajac commented on PR #14640:
URL: https://github.com/apache/kafka/pull/14640#issuecomment-1857500665
The failed tests are not related. Merged it to trunk and 3.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dajac merged PR #14640:
URL: https://github.com/apache/kafka/pull/14640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kirktrue commented on PR #14640:
URL: https://github.com/apache/kafka/pull/14640#issuecomment-1856833962
Closing and reopening due to Jenkins fussiness:
> ERROR: Cannot resume build because FlowNode 88 for FlowHead 1 could not be
loaded. This is expected to happen when using the
kirktrue closed pull request #14640: KAFKA-15276: Implement event plumbing for
ConsumerRebalanceListener callbacks
URL: https://github.com/apache/kafka/pull/14640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kirktrue commented on PR #14640:
URL: https://github.com/apache/kafka/pull/14640#issuecomment-1856317514
Build failed yet again because code couldn't be `git clone`-ed. Closing and
reopening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
kirktrue closed pull request #14640: KAFKA-15276: Implement event plumbing for
ConsumerRebalanceListener callbacks
URL: https://github.com/apache/kafka/pull/14640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kirktrue closed pull request #14640: KAFKA-15276: Implement event plumbing for
ConsumerRebalanceListener callbacks
URL: https://github.com/apache/kafka/pull/14640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kirktrue commented on PR #14640:
URL: https://github.com/apache/kafka/pull/14640#issuecomment-1856279206
Build failed because code couldn't be `git clone`-ed. Closing and reopening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kirktrue commented on PR #14640:
URL: https://github.com/apache/kafka/pull/14640#issuecomment-1856019514
> @kirktrue The last build has compilation errors. Could you please check?
Fixed.
Oddly I couldn't get it to break locally until I re-sync'ed my fork and
merged in `trunk`
dajac commented on PR #14640:
URL: https://github.com/apache/kafka/pull/14640#issuecomment-1855524192
@kirktrue The last build has compilation errors. Could you please check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424320386
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -169,7 +169,7 @@ class PlaintextConsumerTest extends BaseConsumerTest {
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424297697
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424300228
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -860,6 +871,78 @@ public void testGroupMetadataUpdateSingleCall()
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424285645
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -860,6 +871,78 @@ public void
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424283196
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +791,297 @@ public void
dajac commented on PR #14640:
URL: https://github.com/apache/kafka/pull/14640#issuecomment-1852268804
@kirktrue Thanks for your effort on this one. We are almost there. We need
to resolve the open comments. I also left a new and small ones. Could you also
resolve the conflicts?
--
This
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424116779
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -860,6 +871,78 @@ public void testGroupMetadataUpdateSingleCall()
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424109566
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +791,297 @@ public void
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424104151
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424081933
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424042648
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
kirktrue commented on PR #14640:
URL: https://github.com/apache/kafka/pull/14640#issuecomment-1851280653
A [quick search on
Jira](https://issues.apache.org/jira/issues/?jql=project%20%3D%20KAFKA%20AND%20text%20~%20%22testCoordinatorFailover%22)
shows that `testCoordinatorFailover` is a
kirktrue commented on PR #14640:
URL: https://github.com/apache/kafka/pull/14640#issuecomment-1851277041
@dajac—I've made the requested changes. Can you take another look?
The latest test run had the usual suspects of flaky tests, plus two that
stood out:
- Build / JDK 17 and
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1423245926
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -177,34 +202,37 @@ public void process(final BackgroundEvent
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1423135362
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -177,34 +202,37 @@ public void process(final BackgroundEvent
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1423134165
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +791,297 @@ public void
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1423128358
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerUtils.java:
##
@@ -224,4 +224,21 @@ else if (t instanceof KafkaException)
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1423127956
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1499,6 +1575,149 @@ private void subscribeInternal(Collection
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1423064727
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1499,6 +1575,149 @@ private void subscribeInternal(Collection
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1423062667
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1422704717
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1422677966
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
dajac commented on PR #14640:
URL: https://github.com/apache/kafka/pull/14640#issuecomment-1849773951
@kirktrue I just replied to the open comments and left more comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1422269556
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -177,34 +202,37 @@ public void process(final BackgroundEvent event) {
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1422136734
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1499,6 +1575,149 @@ private void subscribeInternal(Collection
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1422131602
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -113,16 +113,15 @@ public void process(ApplicationEvent
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421561676
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -169,7 +169,7 @@ class PlaintextConsumerTest extends BaseConsumerTest {
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421557841
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -180,12 +179,12 @@ private void process(final
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421508998
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421255375
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421255309
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackCompletedEvent.java:
##
@@ -0,0 +1,102 @@
+/*
+ *
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421255259
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1497,6 +1606,66 @@ private void subscribeInternal(Collection
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421253120
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421201698
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -113,16 +113,15 @@ public void
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421200769
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421200092
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -42,7 +42,11 @@
import
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421173308
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421165461
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421148323
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackCompletedEvent.java:
##
@@ -0,0 +1,102 @@
+/*
+ *
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1420118120
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackNeededEvent.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1420084904
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackCompletedEvent.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1420082801
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -180,12 +179,12 @@ private void process(final
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1420078858
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1420064193
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -971,12 +989,59 @@ private CompletableFuture
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419795598
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -971,12 +989,59 @@ private CompletableFuture
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419782648
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackNeededEvent.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419768887
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -180,12 +179,12 @@ private void process(final
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419471126
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -169,7 +169,7 @@ class PlaintextConsumerTest extends BaseConsumerTest {
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419470226
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419469606
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419466482
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419466253
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackCompletedEvent.java:
##
@@ -0,0 +1,102 @@
+/*
+ *
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419463055
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -180,12 +179,12 @@ private void process(final
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419459827
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -979,12 +1026,124 @@ private CompletableFuture
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419219318
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -971,12 +989,59 @@ private CompletableFuture
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419257433
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -979,12 +1026,124 @@ private CompletableFuture
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419257433
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -979,12 +1026,124 @@ private CompletableFuture
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419219318
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -971,12 +989,59 @@ private CompletableFuture
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419165645
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -971,12 +989,59 @@ private CompletableFuture
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419087369
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackNeededEvent.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1418677356
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1497,6 +1606,66 @@ private void subscribeInternal(Collection
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1418643128
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackNeededEvent.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1416158929
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackNeededEvent.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1416124293
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackNeededEvent.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1415971670
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackNeededEvent.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1415963877
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -979,12 +1026,124 @@ private CompletableFuture
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1415957086
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -650,7 +693,7 @@ boolean reconcile() {
kirktrue commented on PR #14640:
URL: https://github.com/apache/kafka/pull/14640#issuecomment-1841154914
Closing and reopening to force a new build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kirktrue opened a new pull request, #14640:
URL: https://github.com/apache/kafka/pull/14640
Added logic for coordinating the invocation of the
`ConsumerRebalanceListener` callback invocations between the background thread
(in `MembershipManagerImpl`) and the application thread
kirktrue closed pull request #14640: KAFKA-15276: Implement event plumbing for
ConsumerRebalanceListener callbacks
URL: https://github.com/apache/kafka/pull/14640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1415930727
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerRebalanceListenerInvoker.java:
##
@@ -66,15 +66,15 @@ Exception
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1414752935
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -183,6 +183,10 @@ public NetworkClientDelegate.PollResult
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1414752641
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1376,6 +1425,66 @@ private void subscribeInternal(Collection
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1414627626
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1376,6 +1425,66 @@ private void subscribeInternal(Collection
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1414626549
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerRebalanceListenerMethodName.java:
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1414625883
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -650,7 +693,7 @@ boolean reconcile() {
philipnee commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1414525826
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1376,6 +1425,66 @@ private void subscribeInternal(Collection
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1414403961
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -979,12 +1026,124 @@ private CompletableFuture
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1412693090
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -979,12 +1026,124 @@ private CompletableFuture
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1412428498
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -181,11 +183,13 @@ private void process(final
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1412391352
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -198,11 +202,13 @@ private void
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1412390835
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -181,11 +183,13 @@ private void process(final
dajac commented on PR #14640:
URL: https://github.com/apache/kafka/pull/14640#issuecomment-1835695981
@kirktrue Thanks for the PR. Could you please update the description? The
current one looks pretty outdated.
--
This is an automated message from the Apache Git Service.
To respond to
93 matches
Mail list logo
