[PATCH 0/2] Fix for a bug and a kernel-doc warning in Xilinx DWC3

2021-04-08 Thread Manish Narani
This patch series resolves a kernel-doc warning and a clk freeing bug that was causing a crash. This patch series is on top of: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/usb/dwc3?id=84770f028fabab4cb66188d583ed12652f30576b Manish Narani (2): usb: dwc3

[PATCH 1/2] usb: dwc3: Resolve kernel-doc warning for Xilinx DWC3 driver

2021-04-08 Thread Manish Narani
The kernel-doc run gave a warning for Xilinx DWC3 driver: drivers/usb/dwc3/dwc3-xilinx.c:27: warning: expecting prototype for dwc3(). Prototype was for XLNX_USB_PHY_RST_EN() instead Basically it was due to an extra '*' in line:2. This patch fixes the same. Signed-off-by: Manish Narani

[PATCH 2/2] usb: dwc3: xilinx: Remove the extra freeing of clocks

2021-04-08 Thread Manish Narani
The clocks are configured by devm_clk_bulk_get_all() in this driver. In case of any error the clocks freeing will be handled automatically. There is no need to explicitly free the clocks. Fix the same. Fixes: 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms") Signed-off-by: Man

RE: [RFC PATCH] sdhci: arasan: Add runtime PM support

2018-03-29 Thread Manish Narani
; linux-arm- > ker...@lists.infradead.org; linux-kernel@vger.kernel.org; shawn.lin@rock- > chips.com; Manish Narani > Subject: Re: [RFC PATCH] sdhci: arasan: Add runtime PM support > > On 2018/3/29 13:48, naraniman...@gmail.com wrote: > > From: Manish Narani > > > > Thi

[RFC PATCH 2/3] dt: bindings: Add SD tap value properties details

2018-06-07 Thread Manish Narani
This patch adds details of SD tap value properties in device tree. Signed-off-by: Manish Narani --- .../devicetree/bindings/mmc/arasan,sdhci.txt | 26 ++ 1 file changed, 26 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b

[RFC PATCH 1/3] arm64: zynqmp: dt: Add support for setting SD tap delays

2018-06-07 Thread Manish Narani
This patch adds support for setting SD tap delays from Device Tree. Earlier, these tap values were made static via macros in the driver. So changing the tap values in the device tree makes the driver free from handling different tap values inside it. Signed-off-by: Manish Narani --- arch/arm64

[RFC PATCH 3/3] sdhci: arasan: Add support to read Tap Delay values from DT

2018-06-07 Thread Manish Narani
This patch adds support for reading Tap Delay values from Device Tree and write them via eemi calls. The macros containing these tap delay values are removed from the driver. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 131 + 1 file

RE: [RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-02-08 Thread Manish Narani
Hi Michael, > -Original Message- > From: Michael Grzeschik > Sent: Tuesday, February 9, 2021 5:26 AM > To: Manish Narani > Cc: devicet...@vger.kernel.org; p.za...@pengutronix.de; ba...@kernel.org; > gre...@linuxfoundation.org; linux-...@vger.kernel.org; linux- > k

RE: [RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-02-25 Thread Manish Narani
HI Michael, > -Original Message- > From: Michael Grzeschik > Sent: Monday, February 22, 2021 9:01 PM > To: Manish Narani > Cc: gre...@linuxfoundation.org; robh...@kernel.org; Michal Simek > ; ba...@kernel.org; p.za...@pengutronix.de; > devicet...@v

[PATCH v4] phy: zynqmp: Handle the clock enable/disable properly

2021-03-24 Thread Manish Narani
The current driver is not handling the clock enable/disable operations properly. The clocks need to be handled correctly by enabling or disabling at appropriate places. This patch adds code to handle the same. Signed-off-by: Manish Narani Reviewed-by: Laurent Pinchart --- drivers/phy/xilinx

RE: [PATCH v3] phy: zynqmp: Handle the clock enable/disable properly

2021-03-24 Thread Manish Narani
Hi Laurent, Thank you so much for the review. > -Original Message- > From: Laurent Pinchart > Sent: Wednesday, March 24, 2021 8:38 AM > To: Manish Narani > Cc: kis...@ti.com; vk...@kernel.org; Michal Simek ; > linux-kernel@vger.kernel.org; linux-arm-ker...@lists.

[PATCH v3] phy: zynqmp: Handle the clock enable/disable properly

2021-03-23 Thread Manish Narani
The current driver is not handling the clock enable/disable operations properly. The clocks need to be handled correctly by enabling or disabling at appropriate places. This patch adds code to handle the same. Signed-off-by: Manish Narani --- drivers/phy/xilinx/phy-zynqmp.c | 57

[PATCH v4 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-03-16 Thread Manish Narani
should be changed to PIPE clock in order to make the USB controller work. There is a register added in Xilinx USB controller register space for the same. Signed-off-by: Manish Narani --- drivers/usb/dwc3/Kconfig | 9 + drivers/usb/dwc3/Makefile | 1 + drivers/usb/dwc3/dwc3-of

[PATCH v4 0/2] Add a separate DWC3 OF driver for Xilinx platforms

2021-03-16 Thread Manish Narani
for devm_phy_get - Documented resets in dt-bindings Manish Narani (2): dt-bindings: usb: dwc3-xilinx: Add documentation for Versal DWC3 Controller usb: dwc3: Add driver for Xilinx platforms .../devicetree/bindings/usb/dwc3-xilinx.txt| 28 +- drivers/usb/dwc3/Kconfig

[PATCH v4 1/2] dt-bindings: usb: dwc3-xilinx: Add documentation for Versal DWC3 Controller

2021-03-16 Thread Manish Narani
Add documentation for Versal DWC3 controller. Add required property 'reg' for the same. Also add optional properties for snps,dwc3. Signed-off-by: Manish Narani Reviewed-by: Rob Herring --- .../devicetree/bindings/usb/dwc3-xilinx.txt| 28 -- 1 file c

RE: [PATCH v2] phy: zynqmp: Handle the clock enable/disable properly

2021-03-17 Thread Manish Narani
Gentle Ping! > -Original Message- > From: Manish Narani > Sent: Tuesday, March 9, 2021 4:48 PM > To: laurent.pinch...@ideasonboard.com; kis...@ti.com; vk...@kernel.org; > Michal Simek > Cc: linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; git

[PATCH] mmc: sdhci-of-arasan: Add pinctrl support to the driver

2020-11-17 Thread Manish Narani
Driver should be able to handle optional pinctrl setting. Signed-off-by: Michal Simek Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci

RE: [PATCH] mmc: sdhci-of-arasan: Add pinctrl support to the driver

2020-11-19 Thread Manish Narani
Hi Uffe/Michal, > -Original Message- > From: Michal Simek > Sent: Wednesday, November 18, 2020 11:54 PM > To: Ulf Hansson ; Manish Narani > > Cc: Michal Simek ; Adrian Hunter > ; Linux ARM ker...@lists.infradead.org>; linux-...@vger.kernel.org; Linux Ker

[PATCH] phy: zynqmp: Handle the clock enable/disable properly

2021-03-08 Thread Manish Narani
The current driver is not handling the clock enable/disable operations properly. The clocks need to be handled correctly by enabling or disabling at appropriate places. This patch adds code to handle the same. Signed-off-by: Manish Narani --- drivers/phy/xilinx/phy-zynqmp.c | 40

RE: [RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-01-22 Thread Manish Narani
Hi Michael, > -Original Message- > From: Michael Grzeschik > Sent: Friday, January 22, 2021 1:39 PM > To: Manish Narani > Cc: devicet...@vger.kernel.org; ker...@pengutronix.de; ba...@kernel.org; > gre...@linuxfoundation.org; linux-...@vger.kernel.org; Michal Sime

RE: [PATCH] phy: zynqmp: Handle the clock enable/disable properly

2021-03-09 Thread Manish Narani
Hi Laurent, Thank you for the review. > -Original Message- > From: Laurent Pinchart > Sent: Tuesday, March 9, 2021 1:37 AM > To: Manish Narani > Cc: Anurag Kumar Vulisha ; kis...@ti.com; > vk...@kernel.org; Michal Simek ; linux- > ker...@vger.kern

[PATCH v2] phy: zynqmp: Handle the clock enable/disable properly

2021-03-09 Thread Manish Narani
The current driver is not handling the clock enable/disable operations properly. The clocks need to be handled correctly by enabling or disabling at appropriate places. This patch adds code to handle the same. Signed-off-by: Manish Narani --- drivers/phy/xilinx/phy-zynqmp.c | 57

[RESEND PATCH v3 0/2] Add a separate DWC3 OF driver for Xilinx platforms

2020-12-14 Thread Manish Narani
- Improved description of some register operations to avoid confusion - Updated commit log for patch 2/2 for better clarity. Changes in v3: - Removed snps,enable-hibernation property from the devicetree binding. Manish Narani (2): dt-bindings: usb: dwc3

[RESEND PATCH v3 1/2] dt-bindings: usb: dwc3-xilinx: Add documentation for Versal DWC3 Controller

2020-12-14 Thread Manish Narani
Add documentation for Versal DWC3 controller. Add required property 'reg' for the same. Also add optional properties for snps,dwc3. Signed-off-by: Manish Narani Reviewed-by: Rob Herring --- .../devicetree/bindings/usb/dwc3-xilinx.txt | 17 +++-- 1 file changed, 15

[RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2020-12-14 Thread Manish Narani
should be changed to PIPE clock in order to make the USB controller work. There is a register added in Xilinx USB controller register space for the same. Signed-off-by: Manish Narani --- drivers/usb/dwc3/Kconfig | 9 + drivers/usb/dwc3/Makefile | 1 + drivers/usb/dwc3/dwc3-of

RE: [PATCH v2 01/11] dt-bindings: mmc: arasan: Update documentation for SD Card Clock

2019-08-23 Thread Manish Narani
Hi Heiko/Uffe, > -Original Message- > From: Heiko Stuebner > Sent: Thursday, August 22, 2019 11:53 PM > To: Ulf Hansson ; linux-...@vger.kernel.org > Cc: Manish Narani ; Rob Herring ; > mark.rutl...@arm.com; Michal Simek ; > adrian.hun...@intel.com; christo

RE: [PATCH v2 01/11] dt-bindings: mmc: arasan: Update documentation for SD Card Clock

2019-08-19 Thread Manish Narani
Hi Uffe, > -Original Message- > From: Ulf Hansson > Sent: Thursday, July 25, 2019 6:31 PM > To: Manish Narani > Cc: Rob Herring ; mark.rutl...@arm.com; > he...@sntech.de; Michal Simek ; > adrian.hun...@intel.com; christoph.muell...@theobroma-systems.com; > p

[PATCH v3 0/8] Arasan SDHCI enhancements and ZynqMP Tap Delays Handling

2019-10-16 Thread Manish Narani
readable Changes in v3: - Reverted "Replaced the deprecated calls to clock framework APIs" - Removed devm_clk_get() call which was added in v2 Manish Narani (8): mmc: sdhci-of-arasan: Separate out clk related data to another structure dt-bindings: mmc: aras

[PATCH v3 1/8] mmc: sdhci-of-arasan: Separate out clk related data to another structure

2019-10-16 Thread Manish Narani
To improve the code readability, use two different structs, one for clock provider data and one for mmc platform data. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 31 -- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH v3 8/8] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-10-16 Thread Manish Narani
Apart from taps set by auto tuning, ZynqMP platform has feature to set the tap values manually. Add support to set tap delay values in HW via ZynqMP SoC framework. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 206 - 1 file changed, 204

[PATCH v3 5/8] mmc: sdhci-of-arasan: Add support to set clock phase delays for SD

2019-10-16 Thread Manish Narani
same. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 91 ++ 1 file changed, 91 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index f77f884f44a4..9b2b7b6399b3 100644 --- a/drivers/mmc/host

[PATCH v3 4/8] dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI

2019-10-16 Thread Manish Narani
Add optional propeties for Arasan SDHCI which are used to set clk delays for different speed modes in the controller. Signed-off-by: Manish Narani --- .../devicetree/bindings/mmc/arasan,sdhci.txt | 15 +++ 1 file changed, 15 insertions(+) diff --git a/Documentation/devicetree

[PATCH v3 2/8] dt-bindings: mmc: arasan: Update Documentation for the input clock

2019-10-16 Thread Manish Narani
Add documentation for an optional input clock which is essentially used in sampling the input data coming from the card. Signed-off-by: Manish Narani --- Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH v3 3/8] mmc: sdhci-of-arasan: Add sampling clock for a phy to use

2019-10-16 Thread Manish Narani
There are some operations like setting the clock delays may need to have two clocks, one for output path and one for input path. Adding input path clock for some phys to use. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 151 + 1 file changed

[PATCH v3 6/8] firmware: xilinx: Add SDIO Tap Delay nodes

2019-10-16 Thread Manish Narani
Add tap delay nodes for setting SDIO Tap Delays on ZynqMP platform. Signed-off-by: Manish Narani --- include/linux/firmware/xlnx-zynqmp.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx

[PATCH v3 7/8] dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller

2019-10-16 Thread Manish Narani
dd documentation for 'xlnx,zynqmp-8.9a' SDHCI controller and optional properties followed by example. Signed-off-by: Manish Narani Reviewed-by: Rob Herring --- .../devicetree/bindings/mmc/arasan,sdhci.txt | 19 +++ 1 file changed, 19 insertions(+) diff --git a/Doc

[PATCH v3] arm64: zynqmp: Add ZynqMP SDHCI compatible string

2019-10-17 Thread Manish Narani
Add the new compatible string for ZynqMP SD Host Controller for its use in the Arasan SDHCI driver for some of the ZynqMP specific operations. Add required properties for the same. Signed-off-by: Manish Narani --- This patch depends on the below series of patches: https://lkml.org/lkml/2019/10

RE: [PATCH v3 4/8] dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI

2019-10-18 Thread Manish Narani
Hi Rob, Thank you so much for the review. Please find my comments inline below. Thanks, Manish > -Original Message- > From: Rob Herring > Sent: Thursday, October 17, 2019 11:53 PM > To: Manish Narani > Cc: ulf.hans...@linaro.org; mark.rutl...@arm.com; adrian.hun...@inte

[PATCH v4 0/3] Add Xilinx AMS Driver

2019-04-22 Thread Manish Narani
confusion - Removed unused NULL arguments as suggested in v3 patch review - Addressed comments on Device Tree property naming Manish Narani (3): dt-bindings: iio: adc: Add Xilinx AMS binding documentation iio: adc: Add Xilinx AMS driver arm64: zynqmp: DT: Add Xilinx AMS node

[PATCH v4 3/3] arm64: zynqmp: DT: Add Xilinx AMS node

2019-04-22 Thread Manish Narani
The Xilinx AMS includes an ADC as well as on-chip sensors that can be used to sample external and monitor on-die operating conditions, such as temperature and supply voltage levels. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 26 ++ 1 file

[PATCH v4 2/3] iio: adc: Add Xilinx AMS driver

2019-04-22 Thread Manish Narani
channels for measuring external voltages. The voltage and temperature monitoring channels also have event capability which allows to generate an interrupt when their value falls below or raises above a set threshold. Signed-off-by: Manish Narani --- drivers/iio/adc/Kconfig | 10 + drivers

[PATCH v4 1/3] dt-bindings: iio: adc: Add Xilinx AMS binding documentation

2019-04-22 Thread Manish Narani
Xilinx AMS have several ADC channels that can be used for measurement of different voltages and temperatures. Document the same in the bindings. Signed-off-by: Manish Narani --- .../devicetree/bindings/iio/adc/xilinx-ams.txt | 183 + 1 file changed, 183 insertions

RE: [PATCH v2 00/11] Arasan SDHCI enhancements and ZynqMP Tap Delays Handling

2019-07-15 Thread Manish Narani
Ping! > -Original Message- > From: Manish Narani > Sent: Monday, July 1, 2019 11:00 AM > To: ulf.hans...@linaro.org; robh...@kernel.org; mark.rutl...@arm.com; > he...@sntech.de; Michal Simek ; > adrian.hun...@intel.com; christoph.muell...@theobroma-systems.c

RE: [PATCH v2 01/11] dt-bindings: mmc: arasan: Update documentation for SD Card Clock

2019-07-23 Thread Manish Narani
Hi Rob, Thanks a lot for the review! > -Original Message- > From: Rob Herring > Sent: Tuesday, July 23, 2019 3:24 AM > To: Manish Narani > Cc: ulf.hans...@linaro.org; mark.rutl...@arm.com; he...@sntech.de; Michal > Simek ; adrian.hun...@intel.com; > christo

RE: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-17 Thread Manish Narani
Hi Uffe, Thanks for the review. Please find my comments below. > -Original Message- > From: Ulf Hansson > Sent: Monday, June 17, 2019 8:29 PM > To: Michal Simek > Cc: Manish Narani ; Rob Herring > ; Mark Rutland ; Adrian > Hunter ; Rajan Vaja ; Jolly > Shah ; N

RE: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-19 Thread Manish Narani
Hi Uffe, > -Original Message- > From: Ulf Hansson > Sent: Monday, June 17, 2019 5:51 PM [...] > > The "const struct zynqmp_eemi_ops *eemi_ops; should then be moved into > a clock provider specific struct, which is assigned when calling > sdhci_arasan_register_sdclk. I understand that al

[PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-11 Thread Manish Narani
-defined Tap Delay Values. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 173 - 1 file changed, 172 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index b12abf9..7af6cec

[PATCH 2/3] dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller

2019-06-11 Thread Manish Narani
Add documentation for 'xlnx,zynqmp-8.9a' SDHCI controller and optional properties followed by example. Signed-off-by: Manish Narani --- .../devicetree/bindings/mmc/arasan,sdhci.txt | 32 ++ 1 file changed, 32 insertions(+) diff --git a/Documentation/

[PATCH 1/3] firmware: xilinx: Add SDIO Tap Delay API

2019-06-11 Thread Manish Narani
Add API for setting SDIO Tap Delays on ZynqMP platforms. Signed-off-by: Manish Narani --- drivers/firmware/xilinx/zynqmp.c | 32 include/linux/firmware/xlnx-zynqmp.h | 17 - 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a

[PATCH 0/3] Add ZynqMP SD Clock Tap Delays configuration support

2019-06-11 Thread Manish Narani
This patch series adds support to configure SD tap delays on ZynqMP platforms using Xilinx firmware driver and clock framework APIs. Manish Narani (3): firmware: xilinx: Add SDIO Tap Delay API dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller mmc: sdhci-of-arasan: A

[PATCH] arm64: zynqmp: Add ZynqMP SDHCI compatible string

2019-06-11 Thread Manish Narani
Add the new compatible string for ZynqMP SD Host Controller for its use in the Arasan SDHCI driver for some of the ZynqMP specific operations. Add required properties for the same. Signed-off-by: Manish Narani --- This patch depends on the below series of patches: https://lkml.org/lkml/2019/6/11

RE: [PATCH v2 09/11] firmware: xilinx: Add SDIO Tap Delay APIs

2019-07-01 Thread Manish Narani
Hi Jolly, > -Original Message- > From: Jolly Shah > Sent: Monday, July 1, 2019 11:36 PM > To: Manish Narani ; ulf.hans...@linaro.org; > robh...@kernel.org; mark.rutl...@arm.com; he...@sntech.de; Michal Simek > ; adrian.hun...@intel.com; > christoph.muell...@

[PATCH v2 04/11] mmc: sdhci-of-arasan: Separate out clk related data to another structure

2019-06-30 Thread Manish Narani
To improve the code readability, use two different structs, one for clock provider data and one for mmc platform data. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 35 +++ 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a

[PATCH v2 02/11] arm64: dts: rockchip: Add optional clock property indicating sdcard clock

2019-06-30 Thread Manish Narani
As devm_clk_register() is deprecated in the clock framework, it is mandatory to use devm_clk_get() for getting the clock. This patch adds sdcard clock which will be used for the same. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++-- 1 file changed, 2

[PATCH v2 09/11] firmware: xilinx: Add SDIO Tap Delay APIs

2019-06-30 Thread Manish Narani
Add APIs for setting SDIO Tap Delays on ZynqMP platform. Signed-off-by: Manish Narani --- drivers/firmware/xilinx/zynqmp.c | 48 include/linux/firmware/xlnx-zynqmp.h | 15 ++- 2 files changed, 62 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 03/11] mmc: sdhci-of-arasan: Replace deprecated clk API calls

2019-06-30 Thread Manish Narani
The clk framework APIs devm_clk_register and of_clk_add_provider, which are used here, are deprecated. Replace the calls with the new API calls. Also add an API call devm_clk_get() to get the clock from DT. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 21

[PATCH v2 10/11] dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller

2019-06-30 Thread Manish Narani
Add documentation for 'xlnx,zynqmp-8.9a' SDHCI controller and optional properties followed by example. Signed-off-by: Manish Narani --- .../devicetree/bindings/mmc/arasan,sdhci.txt | 19 +++ 1 file changed, 19 insertions(+) diff --git a/Documentation/

[PATCH v2 00/11] Arasan SDHCI enhancements and ZynqMP Tap Delays Handling

2019-06-30 Thread Manish Narani
readable This patch series contains a DT patch, which I think should be there to maintain the order of commits. Manish Narani (11): dt-bindings: mmc: arasan: Update documentation for SD Card Clock arm64: dts: rockchip: Add optional clock property indicating sdcard clock mmc: sdhci-of-arasan

[PATCH v2 11/11] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-30 Thread Manish Narani
Apart from taps set by auto tuning, ZynqMP platform has feature to set the tap values manually. Add support to set tap delay values in HW via ZynqMP SoC framework. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 200 - 1 file changed

[PATCH v2 05/11] dt-bindings: mmc: arasan: Update Documentation for the input clock

2019-06-30 Thread Manish Narani
Add documentation for an optional input clock which is essentially used in sampling the input data coming from the card. Signed-off-by: Manish Narani --- Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a

[PATCH v2 01/11] dt-bindings: mmc: arasan: Update documentation for SD Card Clock

2019-06-30 Thread Manish Narani
ck from controller to the card. Signed-off-by: Manish Narani --- Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/

[PATCH v2 08/11] mmc: sdhci-of-arasan: Add support to set clock phase delays for SD

2019-06-30 Thread Manish Narani
same. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 91 ++ 1 file changed, 91 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 9513813..a545221 100644 --- a/drivers/mmc/host/sdhci

[PATCH v2 06/11] mmc: sdhci-of-arasan: Add sampling clock for a phy to use

2019-06-30 Thread Manish Narani
There are some operations like setting the clock delays may need to have two clocks, one for output path and one for input path. Adding input path clock for some phys to use. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 118 ++--- 1 file

[PATCH v2 07/11] dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI

2019-06-30 Thread Manish Narani
Add optional propeties for Arasan SDHCI which are used to set clk delays for different speed modes in the controller. Signed-off-by: Manish Narani --- Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 15 +++ 1 file changed, 15 insertions(+) diff --git a/Documentation

[PATCH v2] arm64: zynqmp: Add ZynqMP SDHCI compatible string

2019-06-30 Thread Manish Narani
Add the new compatible string for ZynqMP SD Host Controller for its use in the Arasan SDHCI driver for some of the ZynqMP specific operations. Add required properties for the same. Signed-off-by: Manish Narani --- This patch depends on the below series of patches: https://lkml.org/lkml/2019/7/1

RE: [PATCH v2 00/11] Arasan SDHCI enhancements and ZynqMP Tap Delays Handling

2019-07-21 Thread Manish Narani
Gentle Ping! > -Original Message- > From: Manish Narani > Sent: Monday, July 15, 2019 12:46 PM > To: Manish Narani ; ulf.hans...@linaro.org; > robh...@kernel.org; mark.rutl...@arm.com; he...@sntech.de; Michal Simek > ; adrian.hun...@intel.com; > christoph.muell...@

[PATCH v2 3/4] iio: adc: Add Xilinx AMS driver

2018-09-14 Thread Manish Narani
channels for measuring external voltages. The voltage and temperature monitoring channels also have event capability which allows to generate an interrupt when their value falls below or raises above a set threshold. Signed-off-by: Manish Narani --- drivers/iio/adc/Kconfig | 10 + drivers

[PATCH v2 0/4] Add Xilinx AMS Driver

2018-09-14 Thread Manish Narani
t_irq() and handled respective error conditions - Moved contents of xilinx-ams.h to inline with xilinx-ams.c - Patch-1 - Addressed Documentation style comments Manish Narani (4): dt-bindings: iio: adc: Add Xilinx AMS binding documentation iio: Documentation: A

[PATCH v2 4/4] arm64: zynqmp: DT: Add Xilinx AMS node

2018-09-14 Thread Manish Narani
The Xilinx AMS includes an ADC as well as on-chip sensors that can be used to sample external and monitor on-die operating conditions, such as temperature and supply voltage levels. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 26 ++ 1 file

[PATCH v2 2/4] iio: Documentation: Add Xilinx AMS sysfs documentation

2018-09-14 Thread Manish Narani
Add documentation for xilinx-ams driver. This contains information about various voltages and temperatures on PS (Processing System), PL (Programmable Logic) and AMS Control Block. Signed-off-by: Manish Narani --- .../ABI/testing/sysfs-bus-iio-adc-xilinx-ams | 246 + 1

[PATCH v2 1/4] dt-bindings: iio: adc: Add Xilinx AMS binding documentation

2018-09-14 Thread Manish Narani
Xilinx AMS have several ADC channels that can be used for measurement of different voltages and temperatures. Document the same in the bindings. Signed-off-by: Manish Narani --- .../devicetree/bindings/iio/adc/xilinx-ams.txt | 180 + 1 file changed, 180 insertions

RE: [PATCH v7 2/7] edac: synps: Add platform specific structures for ddrc controller

2018-09-24 Thread Manish Narani
Hi Boris, Thanks for the review. > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Friday, September 21, 2018 2:37 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; mche...@kernel.org; > Michal Simek ; leoyang...@nx

RE: [PATCH v7 2/7] edac: synps: Add platform specific structures for ddrc controller

2018-09-24 Thread Manish Narani
Hi Boris, Thanks for the review. > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Friday, September 21, 2018 2:46 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; mche...@kernel.org; > Michal Simek ; leoyang...@nx

RE: [PATCH v7 5/7] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-09-24 Thread Manish Narani
Hi Boris, Thanks for the review. > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Friday, September 21, 2018 6:26 PM > On Mon, Sep 17, 2018 at 07:55:03PM +0530, Manish Narani wrote: > > Add EDAC ECC support for ZynqMP DDRC IP. The IP supports interrupts > > for corr

RE: [PATCH v7 4/7] edac: synopsys: Add macro defines for ZynqMP DDRC

2018-09-24 Thread Manish Narani
Hi Boris, Thanks for the review. > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Monday, September 24, 2018 2:52 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; mche...@kernel.org; > Michal Simek ; leoyang...@nx

RE: [PATCH] sdhci: arasan: Add runtime PM support

2018-09-24 Thread Manish Narani
Ping! > -Original Message- > From: Manish Narani [mailto:manish.nar...@xilinx.com] > Sent: Tuesday, September 18, 2018 8:34 PM > To: adrian.hun...@intel.com; Michal Simek ; > ulf.hans...@linaro.org > Cc: linux-...@vger.kernel.org; linux-arm-ker...@lists.infradead

RE: [PATCH 1/3] dt-bindings: iio: adc: Add Xilinx AMS binding documentation

2018-09-06 Thread Manish Narani
Hi Rob, Thanks for the review. Please see my comments inline. > From: Rob Herring [mailto:r...@kernel.org] > Sent: Tuesday, September 4, 2018 6:48 AM > To: Manish Narani > > On Thu, Aug 30, 2018 at 03:52:17PM +0530, Manish Narani wrote: > > Xilinx AMS have several ADC chan

RE: [PATCH 1/3] dt-bindings: iio: adc: Add Xilinx AMS binding documentation

2018-09-06 Thread Manish Narani
Hi Jonathan, Thanks for the review! > -Original Message- > From: Jonathan Cameron [mailto:ji...@kernel.org] > Sent: Sunday, September 2, 2018 11:45 PM > To: Manish Narani > Cc: knaac...@gmx.de; l...@metafoo.de; pme...@pmeerw.net; > robh...@kernel.org; mark.rutl...@arm

RE: [PATCH 2/3] iio: adc: Add Xilinx AMS driver

2018-09-06 Thread Manish Narani
Hi Jonathan, Thanks a lot for the review. Please see my response inline. > -Original Message- > From: Jonathan Cameron [mailto:ji...@kernel.org] > Sent: Monday, September 3, 2018 1:27 AM > To: Manish Narani > Cc: knaac...@gmx.de; l...@metafoo.de; pme...@pmeerw.net; >

RE: [PATCH v5 2/4] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-09-06 Thread Manish Narani
Hi Rob, > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Tuesday, September 4, 2018 7:46 PM > To: Manish Narani > Cc: mark.rutl...@arm.com; Michal Simek ; > b...@alien8.de; mche...@kernel.org; leoyang...@nxp.com; > amit.kuche...@linar

RE: [PATCH v5 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-09-06 Thread Manish Narani
Hi Boris, Thanks a lot for the review. Please see my comments inline. > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Tuesday, September 4, 2018 10:28 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; Michal Simek > ;

RE: [PATCH v5 3/4] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-09-06 Thread Manish Narani
Hi Boris, Thanks for the review. > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Wednesday, September 5, 2018 3:50 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; Michal Simek > ; mche...@kernel.org; leoyang...@nxp

RE: [PATCH v7 1/7] edac: synopsys: Fix code comments and naming convention

2018-09-18 Thread Manish Narani
Hi Boris, Thanks a lot for the review. > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Tuesday, September 18, 2018 1:23 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; mche...@kernel.org; > Michal Simek ;

RE: [PATCH v7 2/7] edac: synps: Add platform specific structures for ddrc controller

2018-09-18 Thread Manish Narani
Hi Boris, Thanks for your continuous guidance. > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Tuesday, September 18, 2018 1:25 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; mche...@kernel.org; > Michal Simek ;

RE: [PATCH v7 2/7] edac: synps: Add platform specific structures for ddrc controller

2018-09-19 Thread Manish Narani
Hi Boris, > -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Wednesday, September 19, 2018 4:46 PM > To: Manish Narani > Cc: robh...@kernel.org; mark.rutl...@arm.com; mche...@kernel.org; > Michal Simek ; leoyang...@nxp.com; > sudeep.ho..

[RFC PATCH v2 2/4] firmware: xilinx: Add macros and API for SD tap delays

2018-09-20 Thread Manish Narani
Add ZynqMP firmware SD tap delay macros and API for setting tap values. Signed-off-by: Manish Narani --- include/linux/firmware/xlnx-zynqmp.h | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux

[RFC PATCH v2 3/4] sdhci: arasan: Add support to read and set tap delays from DT for ZynqMP

2018-09-20 Thread Manish Narani
-defined Tap Delay Values. Signed-off-by: Manish Narani --- drivers/firmware/xilinx/Makefile| 1 + drivers/firmware/xilinx/zynqmp-tap-delays.c | 39 + drivers/mmc/host/sdhci-of-arasan.c | 215 include/linux/firmware/xlnx-zynqmp.h| 4

[RFC PATCH v2 4/4] arm64: zynqmp: Add 'xlnx,mio-bank' property in SDHCI node

2018-09-20 Thread Manish Narani
Add a required property indicating the MIO Bank number for SDHCI controller in ZynqMP. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi

[RFC PATCH v2 1/4] dt: bindings: Add SD tap value properties details for 'xlnx,zynqmp-8.9a'

2018-09-20 Thread Manish Narani
Add documentation for MIO bank required property and Tap Delays optional properties in devicetree bindings. Signed-off-by: Manish Narani --- .../devicetree/bindings/mmc/arasan,sdhci.txt | 19 +++ 1 file changed, 19 insertions(+) diff --git a/Documentation/devicetree

[RFC PATCH v2 0/4] Add support for SD Tap Delay setting for ZynqMP

2018-09-20 Thread Manish Narani
the property name - Changed order of the patches : DT binding change -> driver change -> DT change Manish Narani (4): dt: bindings: Add SD tap value properties details for 'xlnx,zynqmp-8.9a' firmware: xilinx: Add macros and API for SD tap delays sdhci: arasan: Add support

[PATCH v5 4/4] arm64: zynqmp: Add DDRC node

2018-08-31 Thread Manish Narani
Add ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at 0xFD090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v5 3/4] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC

2018-08-31 Thread Manish Narani
changes are also done for better readability. Signed-off-by: Manish Narani --- drivers/edac/Kconfig |2 +- drivers/edac/synopsys_edac.c | 1054 +- 2 files changed, 937 insertions(+), 119 deletions(-) diff --git a/drivers/edac/Kconfig b/drivers/edac

[PATCH v5 2/4] dt: bindings: Document ZynqMP DDRC in Synopsys documentation

2018-08-31 Thread Manish Narani
Add information of ZynqMP DDRC which reports the single bit errors that are corrected and the double bit errors that are detected. Signed-off-by: Manish Narani --- .../bindings/memory-controllers/synopsys.txt | 27 ++ 1 file changed, 22 insertions(+), 5 deletions

[PATCH v5 1/4] edac: synps: Add platform specific structures for ddrc controller

2018-08-31 Thread Manish Narani
Add platform specific structures, so that we can add different IP support later using quirks. Signed-off-by: Manish Narani --- drivers/edac/synopsys_edac.c | 78 +--- 1 file changed, 59 insertions(+), 19 deletions(-) diff --git a/drivers/edac

[PATCH v5 0/4] EDAC: Enhancements to Synopsys EDAC driver

2018-08-31 Thread Manish Narani
e unnecessary check for match data in probe() in (1/4) - Some Indentation changes for better readability in (1/4) and (3/4) - Removed repeated code in (3/4) - Used 'zynq' and 'zynqmp' instead of 'synps_enh_edac' in function names Manish Naran

[RFC PATCH] iio: adc: Add Xilinx AMS driver

2018-03-15 Thread Manish Narani
channels for measuring external voltages. The voltage and temperature monitoring channels also have event capability which allows to generate an interrupt when their value falls below or raises above a set threshold. Signed-off-by: Manish Narani --- drivers/iio/adc/Kconfig | 10

RE: [RFC PATCH] usb: dwc3: add support for OTG driver compilation

2017-01-04 Thread Manish Narani
Hi Felipe, > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Wednesday, January 04, 2017 7:01 PM > Hi, > > Manish Narani writes: > > This patch adds support for OTG driver compilation and object file > > creation > > > > Signed-off-by: Manish Narani

RE: [RFC PATCH] usb: dwc3: host: add support for OTG in DWC3 host driver

2017-01-05 Thread Manish Narani
Hi Felipe, > -Original Message- > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Wednesday, January 04, 2017 7:03 PM > > Hi, > > Manish Narani writes: > > This patch adds support for OTG host mode initialization in DWC3 host > > driver. Before

RE: [RFC PATCH] usb: host: xhci: plat: add support for otg_set_host() call

2017-01-01 Thread Manish Narani
Ping !! -Original Message- From: Manish Narani [mailto:manish.nar...@xilinx.com] Sent: Thursday, December 15, 2016 1:24 PM To: mathias.ny...@intel.com; gre...@linuxfoundation.org; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Cc: Anurag Kumar Vulisha ; Punnaiah Choudary Kalluri

RE: [RFC PATCH] usb: host: xhci: plat: add support for otg_set_host() call

2017-01-02 Thread Manish Narani
planning to add DWC3 OTG driver after this patch is added. Please let me know your valuable suggestions on this. Thanks, Manish -Original Message- From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] Sent: Monday, January 02, 2017 2:53 PM To: Manish Narani Cc: Manish

<    1   2   3   >