Re: [Meego-handset] [dialer] New branch pushed for "headless" work

2011-03-22 Thread Arun Ravindran
Hi Shane, Michael and Arun, others who care... I have pushed Michaels patchset to a new public branch called "topic/headless", and am requesting that you guys coordinate your respective work towards the eventual merge into master on this branch. For others that have been waiting (alterego for

Re: [Meego-handset] [dialer] New branch pushed for "headless" work

2011-03-23 Thread Arun Ravindran
On 03/23/2011 12:33 AM, ext Michael Demeter wrote: See inline On Tue, Mar 22, 2011 at 9:50 AM, Shane Bryan wrote: On Tue, 22 Mar 2011 17:04:04 +0200 Arun Ravindran wrote: 1) the dialer.desktop file changes as described in the README.txt are not working. I had to comment X-Osso-Service

Re: [Meego-handset] [dialer] New branch pushed for "headless" work

2011-03-23 Thread Arun Ravindran
Hi Michael, See inline On Tue, Mar 22, 2011 at 9:50 AM, Shane Bryan wrote: On Tue, 22 Mar 2011 17:04:04 +0200 Arun Ravindran wrote: 1) the dialer.desktop file changes as described in the README.txt are not working. I had to comment X-Osso-Service=com.meego.dialer, to make it work from

Re: [Meego-handset] [dialer] New branch pushed for "headless" work

2011-03-23 Thread Arun Ravindran
Hi Shane/Michael, Hi Michael, See inline On Tue, Mar 22, 2011 at 9:50 AM, Shane Bryan wrote: On Tue, 22 Mar 2011 17:04:04 +0200 Arun Ravindran wrote: 1) the dialer.desktop file changes as described in the README.txt are not working. I had to comment X-Osso-Service=com.meego.dialer, to

Re: [Meego-handset] [dialer] New branch pushed for "headless" work

2011-03-23 Thread Arun Ravindran
Hi Shane/Michael, Hi Michael, See inline On Tue, Mar 22, 2011 at 9:50 AM, Shane Bryan wrote: On Tue, 22 Mar 2011 17:04:04 +0200 Arun Ravindran wrote: 1) the dialer.desktop file changes as described in the README.txt are not working. I had to comment X-Osso-Service=com.meego.dialer, to

Re: [Meego-handset] [Patch] [Dialer] Regarding BMC#14618

2011-03-25 Thread Arun Ravindran
From db460626b303ab3ef514217bb3266b9a108dfc96 Mon Sep 17 00:00:00 2001 From: Arun Ravindran Date: Thu, 24 Mar 2011 17:34:50 +0200 Subject: [PATCH] Fix for BMC#14618 If you look at my commit history, I really preferre more details in the commit message, and it makes it easier to track why changes are

Re: [Meego-handset] New ofono 0.45 (was Fwd: [meego-commits] 15306 accepted: devel:connectivity/ofono)

2011-03-27 Thread Arun Ravindran
Hi, Hi Voice/SMS guys and girls, There has been a new ofono 0.45 admitted to the development project of connectivity, would it be possible to get this quickly tested so we can confirm there's no problems on N900 in case it gets submitted to Trunk:Testing? Just tested basic call handling (MO,

Re: [Meego-handset] [PATCH] Fixed: BNC#14618 Not support end whole conference call by pressing end button one time Signed-off-by: Arun Ravindran

2011-03-28 Thread Arun Ravindran
Hi, On Mon, Mar 28, 2011 at 12:34 PM, wrote: +void CallItem::callMultiPartyChanged() +{ +TRACE +emit multiPartyChanged(); +} after: + connect(call,SIGNAL(multiPartyChanged()),this,SLOT(callMultiPartyChanged())); The "call" object here is CallProxy* Used as: CallPro

Re: [Meego-handset] [PATCH] Fixed: BNC#14618 Not support end whole conference call by pressing end button one time Signed-off-by: Arun Ravindran

2011-03-28 Thread Arun Ravindran
Hi, On Mon, Mar 28, 2011 at 12:34 PM, wrote: +void CallItem::callMultiPartyChanged() +{ +TRACE +emit multiPartyChanged(); +} after: + connect(call,SIGNAL(multiPartyChanged()),this,SLOT(callMultiPartyChanged())); The "call" object here is CallProxy* Used as: CallPro

Re: [Meego-handset] [PATCH] Fixed: BNC#14618 Not support end whole conference call by pressing end button one time Signed-off-by: Arun Ravindran

2011-04-04 Thread Arun Ravindran
Hi Shane, On Mon, 28 Mar 2011 14:34:42 +0300 ext-arun.1.ravind...@nokia.com wrote: From: Arun Ravindran Added handling of multipart property in the call proxy, call item and callitem model by adding a signal to be emited for the property changes. This signal is handled in call manager now

Re: [Meego-handset] [PATCH] Fixed: BNC#14618 Not support end whole conference call by pressing end button one time Signed-off-by: Arun Ravindran

2011-04-05 Thread Arun Ravindran
Hi Shane, We can do this one of two ways: 1) I apply these as is (with the only caveat being to please make the commit message more concise and to the point) I saw your patch, and it looks better. The key merge key handling is more robust now, please apply this as is. 2) You resubmit the

Re: [Meego-handset] [Patch] Fixed: BMC# 8559 - Non-emergency call (Was: Dialer: Emergency Call Support Patches Try 1)

2011-04-05 Thread Arun Ravindran
Hi Shane, This fixes the behavior where the user is able to make normal call > even if there is no SIM. > As you know the emergency call support is non existent in oFono, at > least we filter the call attempt here. Arun, OK, I've re-worked your patch for BMC#8559, making changes per my prev

Re: [Meego-handset] [Patch] Fixed: BMC# 8559 - Non-emergency call (Was: Dialer: Emergency Call Support Patches Try 1)

2011-04-05 Thread Arun Ravindran
Hi Shane, On Tue, 5 Apr 2011 11:38:29 +0300 Arun Ravindran wrote: One observation I have though is that this is really quite un-testable (at least AFAICS) on the master branch because the only way right now to put the modem into "flight" mode is to offline it, but this will

Re: [Meego-handset] ANNOUNCING: Dialer 'headless' branch has been merged into master

2011-05-02 Thread Arun Ravindran
Hi Shane, With the latest dialer 0.2.1 from OBS, i could never get an incoming call indication. There are 2 issues 1) In the new dialer.desktop file, i had to comment X-Osso-Service=com.meego.dialer, in order to make it start from home screen. Hmm, I though we had solved this and/or were unable

Re: [Meego-handset] ANNOUNCING: Dialer 'headless' branch has been merged into master

2011-05-02 Thread Arun Ravindran
Hi Shane, With the latest dialer 0.2.1 from OBS, i could never get an incoming call indication. There are 2 issues 1) In the new dialer.desktop file, i had to comment X-Osso-Service=com.meego.dialer, in order to make it start from home screen. Hmm, I though we had solved this and/or were unable

Re: [Meego-handset] [PATCH] Patch:Fix for unable to see alert dialog for MT call Signed-off-by: Arun Ravindran

2011-05-03 Thread Arun Ravindran
Hi Shane, This patch emits a signal from callmanager, when a call is added to prepare the UI. The signal is handled in dialer application to release the ui from prestart state. --- src/callmanager.cpp |3 +++ src/callmanager.h |1 + src/dialerapplication.cpp | 11

[Meego-handset] [PATCH] Fixed: BMC#17327, Unable to end the hold conference call if still exist an active call in Dialer app Signed-off-by: Arun Ravindran

2011-05-16 Thread Arun Ravindran
The root cause of this issue was an improper button update. where DialerApplication::handleCallsChanged() calls, m_mainWindow->activateWindow(), but button update happens only if the dialer was not visible previously by the function void MainWindow::onDisplayEntered(). With this patch the update b