Attach patch enables DSD128 playback for the dsf DSD decoder.
Patch is against mpd-0.18.
NB it seems the dsdiff decoder in mpd-0.18 has problems detecting files
(tested on F19 x86_64). Can anyone confirm?
Jurgen
From 4fb59871f937dd215cfce5cf16f8cd547aa71f9a Mon Sep 17 00:00:00 2001
From: Jurgen
Hi,
Hi Jurgen and all,
I am the lead developer of Voyage MPD and I experience the same issue
(hang
at the end of playing) when replaying the .dff files downloaded from
2l.no.
More specifically, the mpd process consume 100% of a single core.
If I convert those problematic files to .dsf
On Sat, 2012-10-06 at 17:27 +0200, Max Kellermann wrote:
On 2012/10/05 09:10, Jurgen Kramer gtmkra...@xs4all.nl wrote:
If added these checks to dsdlib_tag_id3():
+ /* Prevent broken files causing problems */
+ if (is-offset = is-size)
+ return;
+
+ count = is-size - is-offset
On Thu, 2012-10-04 at 23:02 +0200, Max Kellermann wrote:
On 2012/10/04 18:35, Jurgen Kramer gtmkra...@xs4all.nl wrote:
I went through the e-mails, I do not recall you having problems with
dsdiff_handle_native_tag().
You made the same mistake twice. Maybe I didn't point you to the
second
On Thu, 2012-10-04 at 09:59 +0200, Max Kellermann wrote:
On 2012/09/28 09:29, Jurgen Kramer gtmkra...@xs4all.nl wrote:
Patch to enable tag support for DSDIFF and DSF DSD decoders. Sent to Max
on 19/09. Post here for completeness.
Fails to build:
src/decoder/dsdlib.c:130:9: error: use
Patch to enable tag support for DSDIFF and DSF DSD decoders. Sent to Max
on 19/09. Post here for completeness.
http://git.musicpd.org/cgit/gtmkramer/mpd.git/commit/?id=9488b05134cf8ce0d595ffa2186bde22476b2afd
Jurgen
It seems configure.ac needs adjusting for main.c - Main.cxx.
diff --git a/configure.ac b/configure.ac
index 80cd64f..f7599f4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7,7 +7,7 @@ VERSION_MINOR=18
VERSION_REVISION=0
VERSION_EXTRA=0
-AC_CONFIG_SRCDIR([src/main.c])
On Mon, 2012-09-03 at 23:09 +0200, Max Kellermann wrote:
On 2012/08/21 20:01, Jurgen Kramer gtmkra...@xs4all.nl wrote:
Can you use dsdlib_tag_id3() for a DoS attack? This looks like it
could easily cause a stack overflow:
+ count = is-size - is-offset;
+ id3_byte_t dsdid3
On Mon, 2012-08-20 at 08:44 +0200, Max Kellermann wrote:
On 2012/08/16 18:18, Jurgen Kramer gtmkra...@xs4all.nl wrote:
Lots of activity in git. Just a reminder for above commit.
Memory leak in dsdlib_tag_id3().
Fixed. Added id3_tag_delete
Can you use dsdlib_tag_id3() for a DoS attack
Updated version of my patch to add tag support to the DSD decoders.
Now uses scan_id3_tag() to add id3 tags (the comment in src/tag_id3.c/h
for scan_id3_tag() may need smartening up).
No more warnings when compiling with id3 support disabled.
Removes unneeded code when compiling without id3
On Thu, 2012-08-09 at 18:29 +0200, Max Kellermann wrote:
On 2012/08/09 18:04, Jurgen Kramer gtmkra...@xs4all.nl wrote:
Excerpt:
In file included from src/input/ffmpeg_input_plugin.c:26:0:
/usr/include/ffmpeg/libavformat/avformat.h:158:1: error: ???AVMetadata??? is
deprecated (declared
On Tue, 2012-08-07 at 20:02 +0200, Max Kellermann wrote:
On 2012/08/03 15:22, Jurgen Kramer gtmkra...@xs4all.nl wrote:
Commit:
http://git.musicpd.org/cgit/gtmkramer/mpd.git/commit/?id=0156b6b1717bfc3c43fee6a6a6c6249f2abcb753
Repo:
http://git.musicpd.org/cgit/gtmkramer/mpd.git/
Fails
On Fri, 2012-08-03 at 15:22 +0200, Jurgen Kramer wrote:
Commit:
http://git.musicpd.org/cgit/gtmkramer/mpd.git/commit/?id=0156b6b1717bfc3c43fee6a6a6c6249f2abcb753
Repo:
http://git.musicpd.org/cgit/gtmkramer/mpd.git/
My repo is not in sync with master (won't matter for this patch) how do
I
While preparing my next patch for current git I get:
Generating configuration files for mpd, please wait
aclocal-1.11 -I m4 -I /usr/local/share/aclocal
autoheader
automake-1.11 --add-missing
configure.ac:61: installing `./config.guess'
configure.ac:61: installing `./config.sub'
Commit:
http://git.musicpd.org/cgit/gtmkramer/mpd.git/commit/?id=0156b6b1717bfc3c43fee6a6a6c6249f2abcb753
Repo:
http://git.musicpd.org/cgit/gtmkramer/mpd.git/
My repo is not in sync with master (won't matter for this patch) how do
I keep in sync?
Just do a pull of master and push to my git?
I have created a new patch to split the DSDIFF decoder into separate
decoders for DSF and DFF files. Common functions have been moved to a
newly created dsdlib. No new features have been added, these will follow
(tags, song duration) with the next update.
The changes are pushed to my repo.
Request for a MPD git account.
1. real name: Jurgen Kramer
2. email address: gtmkra...@xs4all.nl
3. preferred user name: gtmkramer
4. projects you wish to work on: MPD [master/mpd.git]
5. SSH public key: attached.
Thanks,
Jurgen
ssh-rsa
[resend, previous mail held for moderation due to being
'oversized' (41.4k). Attached patch as gzip file]
This patch splits the DSDIFF decoder into two seperate decoders as
discussed a while back. It creates a new decoder for DSF files and moves
functions common to both decoders to a new library
On Sun, 2012-05-13 at 13:19 +0200, Jurgen Kramer wrote:
I need some pointers how to add an id3 tag in the 'scan_stream' function
of a decoder. Since I last used it there were some changes to the mpd
tagging code.
I managed to add a songs duration using 'tag_handler_invoke_duration'.
But I
I need some pointers how to add an id3 tag in the 'scan_stream' function
of a decoder. Since I last used it there were some changes to the mpd
tagging code.
I managed to add a songs duration using 'tag_handler_invoke_duration'.
But I am a bit lost how to add an id3 tag (struct id3_tag).
Any
Version 4 of my patch to add DSF support to the DSDIFF
decoder plugin.
This time I have taken a different approach and created a new
read_metadata function specific for reading DSF files. This saves an
indent (and for me a lot of indent nightmares) and also useful for
splitting the DSF and DFF
On Mon, 2012-04-23 at 21:56 +0200, Max Kellermann wrote:
On 2012/04/06 12:52, Jurgen Kramer gtmkra...@xs4all.nl wrote:
The attached patch fixes playback for DSD-over-USB. Without this patch
MPD uses a frame size of 2 (stereo files) while the actual needed frame
size for the used output
Attached patch is a *pre* version of v4 of the patch to add support for
DSF files. Fixing the white space warnings was fairly easy after
switching editors and using the supplied git commands.
I changed the struct comments, hopefully now correct (modeled after a
version of a supported doxygen
On Mon, 2012-04-23 at 19:09 +0200, Max Kellermann wrote:
On 2012/04/21 13:29, Jurgen Kramer gtmkra...@xs4all.nl wrote:
- Adhered to max 80 colom width
This is not doxygen syntax, and is barely readable. Please use
doxygen syntax for documenting struct attributes.
- Fixed indents
Attached is version 3 of the patch which adds support for
DSF files to the DSDIFF decoder. It can be used in
conjunction with DSD2PCM and DSD-over-USB.
This version should address the concerns with v2.
Changes from v2 patch:
- Adhered to max 80 colom width
- Fixed indents (hopefully correctly)
-
On Thu, 2012-04-19 at 01:22 +0200, Max Kellermann wrote:
On 2012/04/14 17:07, Jurgen Kramer gtmkra...@xs4all.nl wrote:
Patch to update doc/user.xml to reflect added support for DSF
files to the dsdiff decoder.
Not merging because the DSF patch hasn't been merged yet (see my
question
On Thu, 2012-04-19 at 17:49 +0200, Max Kellermann wrote:
On 2012/04/19 17:41, Jurgen Kramer gtmkra...@xs4all.nl wrote:
I do not mind putting DSF file format support in a separate decoder
plugin. Having two separate decoders would probably yield better
readable and therefore better
Attached is version 2 of the patch which adds support for
DSF files to the DSDIFF decoder. It can be used in
conjunction with DSD2PCM and DSD-over-USB.
Changes from v1 patch:
- Removed currently unused variables
- Removed warning messages
- Included update to doc/user.xml
As agreed upon with
Attached patch adds support for DSF files to the DSDIFF decoder. It can
be used in conjunction with DSD2PCM and DSD-over-USB.
Further planned enhancements:
- song time for both DSF and DFF files
- Implement rewind/fast forward
- Add support for DSF native tags and ID3 tags
To test this with an
Patch to update doc/user.xml to reflect added support for DSF
files to the dsdiff decoder.
Jurgen
diff --git a/doc/user.xml b/doc/user.xml
index cd36528..46d9c11 100644
--- a/doc/user.xml
+++ b/doc/user.xml
@@ -782,7 +782,7 @@ systemctl start mpd.socket/programlisting
The attached patch fixes playback for DSD-over-USB. Without this patch
MPD uses a frame size of 2 (stereo files) while the actual needed frame
size for the used output sample format is 8 (sample formats S24_P32 and
S32).
Maybe this is not the proper/complete solution but will at least allow
users
was referring to the sample size not the enum values
for the different types of formats.
On Wed, Apr 4, 2012 at 11:18 AM, Max Kellermann m...@duempel.org wrote:
On 2012/04/02 18:23, Jurgen Kramer gtmkra...@xs4all.nl wrote:
After much digging around I managed to get sound working but the timing
On Mon, 2012-04-02 at 18:36 +0200, Jurgen Kramer wrote:
Hi,
Attached patch updates the documentation. Modified the links to the
documentation of the DSD-over-USB standard version 1.1.
JR will make the link live later today.
Link to DSD-over-USB standard version 1.1 document is no live
Hi,
As a follow up on my previous mails regarding the slowdown issue with
DSD-over-USB. With the current mpd-git code DSD-over-USB the connected
device won't lock into DSD mode. I found out it is not receiving enough
data per time period.
In MPD clients this is visible in that it takes mpd 4
Hi,
Attached patch updates the documentation. Modified the links to the
documentation of the DSD-over-USB standard version 1.1.
JR will make the link live later today.
---
doc/user.xml |4 ++--
src/pcm_dsd_usb.h |5 +++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff
Hi,
Attached patch adds support for DSD-over-USB version 1.0 and removes
support for the old pre-v1 standard. Patch is against current git.
---
src/pcm_dsd_usb.c | 33 -
1 files changed, 28 insertions(+), 5 deletions(-)
Jurgen
diff --git a/src/pcm_dsd_usb.c
On Wed, 2012-03-28 at 17:13 +0200, Jurgen Kramer wrote:
My guess this is either a timing issue (hopefully not) or
somehow/somewhere the DAC gets non-DSD-over-USB frames every few frames.
Max,
I've added tons of debug prints to the code trying to find the cause of
the problem (DAC rapid
On Tue, 2012-03-27 at 21:52 +0200, Max Kellermann wrote:
On 2012/03/27 19:44, Jurgen Kramer gtmkra...@xs4all.nl wrote:
Hmm something odd is going on when using the new code. My dac switches
rapidly between DSD and 176.4 mode not producing any sound.
I don't see rapid switches in that log
On Tue, 2012-03-27 at 08:19 +0200, Max Kellermann wrote:
I've added a fallback, the ALSA output will now attempt to use S32
playback, and left-shift all 24-bit samples by 8 bit in that case.
It's still the old standard.
Hmm something odd is going on when using the new code. My dac switches
On Mon, 2012-03-26 at 19:36 +0200, Max Kellermann wrote:
On 2012/03/26 19:28, Jurgen Kramer gtmkra...@xs4all.nl wrote:
The closest I got is link which a sent to the list a while ago:
http://www.audiostream.com/content/usb-link-dsd-audio-pcm-frames-andres-koch
It isn't as clear as a 'real
On Mon, 2012-03-26 at 19:43 +0200, Max Kellermann wrote:
On 2012/03/26 19:37, Jurgen Kramer gtmkra...@xs4all.nl wrote:
In code it looks like this :-) The lower 8-bits are not used so
basically it's still a 24-bit sample (that sort of details you would
want to find in a standard).
So I
On Fri, 2012-03-23 at 14:24 +0200, adel...@freemail.gr wrote:
I had to use plughw to get past that error.
plughw only works if I use my SOtM USB-to-SPDIF converter. It does not
work when I use the firewire interface.
So using current mpg git DSD-over-usb output to my Mytek DAC works when
using
On Sat, 2012-03-24 at 13:16 -0400, Jesus R wrote:
Thanks for that tip! I have it working now with plughw as well...
I just did a quick addition (proof-of-concept) to pcm_dsd_usb.c to let
it support version 1 of the dsd-over-usb spec (0x05 and 0xFA markers)
and it works :-). This means support
On Thu, 2012-03-22 at 17:23 +0100, Jurgen Kramer wrote:
I took a quick look at the code, it seems it supports the pre-1.0
version of the standard (0xAA markers). I'll give it a test tomorow. My
DAC supports both version 1.0 and pre-1.0.
Jurgen
OK I just test the new code, unfortunately
On Thu, 2012-03-22 at 14:23 +0200, adel...@freemail.gr wrote:
Hi ,
I've been testing the latest git with DSD over USB support this morning.
I'm using an XMOS UAC2 board with modified firmware supporting v1.0 of
the dCS suggested standard.
FYI. It seems there is now a version 1.0 of the DSD-over-USB 'standard'.
I noticed they changed the marker bytes. See link:
http://www.audiostream.com/content/usb-link-dsd-audio-pcm-frames-andres-koch
Once the basic framework we talked about is in place I'll add support
for version 1.0 of the
On Sat, 2012-02-04 at 03:59 -0800, Bobby Beever wrote:
Ok, great, I prefer this as well.
@Jurgen, @Jesus, I am willing to start the work for the first DSD patch is
that alright with you guys?
@Bobby, that's fine by me. If you lay down the ground work, I'll pitch
in my part. Good to see
Hi,
I hereby sent a series of patches to add my new DSD decoder I talked
about last December. The decoder supports outputting
DSD data over PCM according to the proposed
'DSD-over-USB' standard by dCS. It reads raw DSD data
from DFF (Philips) and DSF (Sony) formatted DSD files
and sends the DSD
.
+ */
+
+/* \file
+ *
+ * This plugin decodes DSDIFF data (SACD) embedded in DFF files and outputs it to
+ * DSD-over-USB spec packed PCM
+ * Used DSDIFF specs:
+ * http://www.sonicstudio.com/pdf/dsd/DSDIFF_1.5_Spec.pdf
+ *
+ * Adapted from dsdiff_decoder_plugin.c by Jurgen Kramer to output to packed DSD
dsdnative.h
+
+/* 09-Dec-11 Jurgen Kramer
+ * dsd2pcm.c converted to output native DSD (packed according to dCS spec) instead of PCM
+ * Tested with Mytek Stereo192-DSD DAC (using Linux snd-dice firewire driver)
+ * 24-bit dCS spec will be put in SAMPLE_FORMAT_S32
+ *
+ * 22-Jan-12 Jurgen Kramer
This patch adds the decoder to mpd (part1)
---
src/conf.h |1 +
src/decoder_list.c |2 ++
2 files changed, 3 insertions(+), 0 deletions(-)
Jurgen
diff --git a/src/conf.h b/src/conf.h
index 815c739..8f936d3 100644
--- a/src/conf.h
+++ b/src/conf.h
@@ -75,6 +75,7 @@
#define
make the new decoder known to the decoder_list
---
src/decoder_list.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Jurgen
diff --git a/src/decoder_list.c b/src/decoder_list.c
index c987403..6fa4c00 100644
--- a/src/decoder_list.c
+++ b/src/decoder_list.c
@@ -48,7 +48,7 @@
Final patch.
---
Makefile.am |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
Jurgen
diff --git a/Makefile.am b/Makefile.am
index 00edcfd..c603aa9 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -460,6 +460,9 @@ libdecoder_plugins_a_SOURCES = \
src/decoder/dsdiff_decoder_plugin.c \
Hi,
There are now several DACs which support native DSD plackback using the
'dCS DSD' spec. I've crafted a mpd decoder module, based on the
dsdiff_decoder_pluging and dsd2pcm available in svn, which outputs
packed DSD. But now I wondering how to go forward with this and get my
code integrated
On Fri, 2011-12-09 at 15:04 +0100, Max Kellermann wrote:
On 2011/12/09 14:55, Jurgen Kramer gtmkra...@xs4all.nl wrote:
Hi,
There are now several DACs which support native DSD plackback using the
'dCS DSD' spec. I've crafted a mpd decoder module, based on the
dsdiff_decoder_pluging
55 matches
Mail list logo
