The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing focus
handling with event propagation. Since #852, `KeyHandler.setFocusVisible` is
also called from mouse and touch event handlers, which makes the purpose of the
class even less pronounced.
Moving the focus-related
On Wed, 23 Nov 2022 23:06:45 GMT, John Hendrikx wrote:
>> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/ControlSkinFactory.java
>> line 287:
>>
>>> 285: .map(d -> new Object[] {d, })
>>> 286: .collect(toList());
>>> 287:
On Thu, 24 Nov 2022 00:12:04 GMT, Andy Goryachev wrote:
> It makes no sense to enable the warning and not fix all the warnings in the
> code. I would like to see 0 warnings in the problem list.
The warning is for all unnecessary casts, which removes a lot of clutter. If,
in some special
On Thu, 24 Nov 2022 00:01:10 GMT, Nir Lisker wrote:
> so I don't think that the warning should be disabled.
It makes no sense to enable the warning and not fix all the warnings in the
code. I would like to see 0 warnings in the problem list.
-
PR:
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
On Tue, 22 Nov 2022 18:39:43 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
> This PR adds style themes as a first-class concept to OpenJFX. A style theme
> is a collection of stylesheets and the logic that governs them. Style themes
> can respond to OS notifications and update their stylesheets dynamically.
> This PR also re-implements Caspian and Modena as style
On Wed, 23 Nov 2022 23:27:21 GMT, Kevin Rushforth wrote:
>> could we just create a method in Util instead of dragging multi-line
>> construct across the tests?
>>
>> e.g. `Util.loadStubToolkit()` ?
>
> Yes, but this is now getting to be a bit out of scope for this PR. Even
> adding the
On Wed, 23 Nov 2022 20:32:34 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293119: newline
>
> tests/manual/tester/src/module-info.java line 1:
>
>> 1: module andy_test {
>
> If you
On Wed, 23 Nov 2022 23:21:52 GMT, Andy Goryachev wrote:
>> I wouldn't recommend that, since it will then obscure the main reason for
>> this call -- to load the toolkit (honestly, the cast was probably an
>> afterthought). So this would be OK:
>>
>>
>> tk =
On Wed, 23 Nov 2022 23:14:52 GMT, Kevin Rushforth wrote:
>> I can replace these with an assert:
>>
>> assertTrue(Toolkit.getToolkit() instanceof StubToolkit);
>
> I wouldn't recommend that, since it will then obscure the main reason for
> this call -- to load the toolkit (honestly, the
On Wed, 23 Nov 2022 23:09:55 GMT, John Hendrikx wrote:
>>> As for this PR, I don't mind leaving it as is or reverting these changes. I
>>> don't think that a CCE is realistic here.
>>
>> I agree that this isn't a good test design. I was just pointing out why it
>> isn't (in theory) a
On Tue, 22 Nov 2022 18:54:39 GMT, John Hendrikx wrote:
>> Note: I ran into a `javac` compiler bug while replacing types with diamond
>> operators (ecj has no issues). I had two options, add a
>> `SuppressWarnings("unused")` or to use a lambda instead of a method
>> reference to make `javac`
On Wed, 23 Nov 2022 22:57:07 GMT, Kevin Rushforth wrote:
>> This looks like bad test design. If the toolkit needs to be of a specific
>> type when running tests, then check that this is the case once before
>> running all the tests. As for this PR, I don't mind leaving it as is or
>>
On Wed, 23 Nov 2022 22:36:36 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert instanceof changes and replace with null checks
>
>
On Wed, 23 Nov 2022 22:00:16 GMT, Nir Lisker wrote:
>> Yes, good catch, fixed.
>
> Eclipse's quick fix is to replace the `instanceof` check with a `null` check,
> did it not suggest the same for you?
I was to quick on the trigger and removed it myself, not Eclipse fault.
-
PR:
On Wed, 23 Nov 2022 22:48:43 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/chart/CategoryAxisTest.java
>> line 122:
>>
>>> 120:
>>> 121: @Test public void checkCategorySpacingReadOnlyCannotBind() {
>>> 122:
On Wed, 23 Nov 2022 22:50:17 GMT, Nir Lisker wrote:
> As for this PR, I don't mind leaving it as is or reverting these changes. I
> don't think that a CCE is realistic here.
I agree that this isn't a good test design. I was just pointing out why it
isn't (in theory) a completely compatible
On Tue, 22 Nov 2022 19:04:00 GMT, Kevin Rushforth wrote:
>> Not needed in the setup, if it is `null` later or throws an exception the
>> test failure is clear enough.
>>
>> Also a bit out of scope of this PR.
>
> Yes, adding an assert does seem out of scope of this PR, although Andy
> comment
On Wed, 23 Nov 2022 22:40:31 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert instanceof changes and replace with null checks
>
>
On Tue, 22 Nov 2022 18:54:39 GMT, John Hendrikx wrote:
>> Note: I ran into a `javac` compiler bug while replacing types with diamond
>> operators (ecj has no issues). I had two options, add a
>> `SuppressWarnings("unused")` or to use a lambda instead of a method
>> reference to make `javac`
On Wed, 23 Nov 2022 19:15:03 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293119: newline
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ConstrainedColumnResizeBase.java
On Tue, 22 Nov 2022 18:54:39 GMT, John Hendrikx wrote:
>> Note: I ran into a `javac` compiler bug while replacing types with diamond
>> operators (ecj has no issues). I had two options, add a
>> `SuppressWarnings("unused")` or to use a lambda instead of a method
>> reference to make `javac`
On Wed, 23 Nov 2022 19:26:18 GMT, Andy Goryachev wrote:
>> This PR fixes a bug where multi-level focus is not correctly preserved.
>> The original implementation incorrectly assumed that there can only be a
>> single focused node in the scene graph, which is not the case when a branch
>> of
On Mon, 21 Nov 2022 23:32:52 GMT, Andy Goryachev wrote:
>> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
>> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>>
>> We propose to address all these issues by replacing the old column resize
>> algorithm
On Mon, 21 Nov 2022 23:32:52 GMT, Andy Goryachev wrote:
>> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
>> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>>
>> We propose to address all these issues by replacing the old column resize
>> algorithm
On Tue, 22 Nov 2022 18:48:41 GMT, John Hendrikx wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/FXVKSkin.java
>> line 858:
>>
>>> 856: protected void sendKeyEvents() {
>>> 857: Node target = fxvk.getAttachedNode();
>>> 858:
>>
>> same
On Sat, 19 Nov 2022 18:01:41 GMT, Michael Strauß wrote:
> This PR fixes a bug where multi-level focus is not correctly preserved.
> The original implementation incorrectly assumed that there can only be a
> single focused node in the scene graph, which is not the case when a branch
> of the
On Tue, 22 Nov 2022 18:52:32 GMT, John Hendrikx wrote:
>> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446:
>>
>>> 1444: @Override
>>> 1445: public void processEndElement() throws IOException {
>>> 1446: super.processEndElement();
>>
>> I
On Mon, 21 Nov 2022 23:32:52 GMT, Andy Goryachev wrote:
>> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
>> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>>
>> We propose to address all these issues by replacing the old column resize
>> algorithm
On Wed, 23 Nov 2022 16:30:00 GMT, Ambarish Rapte wrote:
> Update copyright year for files modified in year 2022.
This pull request has now been integrated.
Changeset: 66626f58
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx17u/commit/66626f58852fd6cd3ac6bd106f0b3a44926f06bd
On Wed, 23 Nov 2022 16:52:09 GMT, Ambarish Rapte wrote:
> Update copyright year for files modified in year 2022.
This pull request has now been integrated.
Changeset: 2aa567dc
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx11u/commit/2aa567dcdca4c410e4abbfedf02e4cb46709f98f
On Wed, 23 Nov 2022 17:18:47 GMT, Andy Goryachev wrote:
>> Introduction
>>
>> There is a number of places where various listeners (strong as well as weak)
>> are added, to be later disconnected in one go. For example, Skin
>> implementations use dispose() method to clean up the listeners
On Wed, 23 Nov 2022 16:30:00 GMT, Ambarish Rapte wrote:
> Update copyright year for files modified in year 2022.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.org/jfx17u/pull/101
On Wed, 23 Nov 2022 16:52:09 GMT, Ambarish Rapte wrote:
> Update copyright year for files modified in year 2022.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.org/jfx11u/pull/124
On Wed, 23 Nov 2022 17:18:47 GMT, Andy Goryachev wrote:
>> Introduction
>>
>> There is a number of places where various listeners (strong as well as weak)
>> are added, to be later disconnected in one go. For example, Skin
>> implementations use dispose() method to clean up the listeners
On Wed, 23 Nov 2022 16:03:44 GMT, Andy Goryachev wrote:
>> Agreed.
>
> any suggestions? Disconnectable? HasDisconnect?
will decide later
-
PR: https://git.openjdk.org/jfx/pull/908
On Wed, 23 Nov 2022 08:09:54 GMT, Florian Kirmaier
wrote:
>> Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added
>> a unit-test for it.
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8256397
>> run test: `./gradlew --continue -PFULL_TEST=true controls:test --tests
> Introduction
>
> There is a number of places where various listeners (strong as well as weak)
> are added, to be later disconnected in one go. For example, Skin
> implementations use dispose() method to clean up the listeners installed in
> the corresponding Control (sometimes using
>
Update copyright year for files modified in year 2022.
-
Commit messages:
- copyright year update 2022
Changes: https://git.openjdk.org/jfx11u/pull/124/files
Webrev: https://webrevs.openjdk.org/?repo=jfx11u=124=00
Issue: https://bugs.openjdk.org/browse/JDK-8295725
Stats: 116
On Wed, 23 Nov 2022 07:21:02 GMT, John Hendrikx wrote:
>> But you don't know that without looking. Really, though, if I were going to
>> make a readability argument, it's the divisor that should be a double
>> constant, since then there is no question that the division is happen in
>> double.
On Tue, 22 Nov 2022 23:58:14 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 28 additional
>>
Update copyright year for files modified in year 2022.
-
Commit messages:
- copyright year update 2022
Changes: https://git.openjdk.org/jfx17u/pull/101/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=101=00
Issue: https://bugs.openjdk.org/browse/JDK-8295725
Stats: 146
On Tue, 22 Nov 2022 23:43:24 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 28 additional
>>
On Wed, 23 Nov 2022 13:35:01 GMT, Marius Hanl wrote:
>> I made a [similar
>> comment](https://github.com/openjdk/jfx/pull/908#pullrequestreview-1168974400)
>> about not using the `I` prefix earlier. Before this can be considered for
>> public API (which won't be soon), this interface will
On Mon, 21 Nov 2022 23:32:52 GMT, Andy Goryachev wrote:
>> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
>> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>>
>> We propose to address all these issues by replacing the old column resize
>> algorithm
On Wed, 23 Nov 2022 00:57:11 GMT, Alexander Matveev
wrote:
> This is regression from
> [JDK-8043352](https://bugs.openjdk.org/browse/JDK-8043352).
> [JDK-8043352](https://bugs.openjdk.org/browse/JDK-8043352) moved clearing
> pending events in progress buffer when upstream sends EOS. We need
That seems reasonable to me, so let's stick with "when".
-- Kevin
On 11/21/2022 4:21 PM, John Hendrikx wrote:
I'm still leaning towards just "when" mainly because its short and,
although perhaps not 100% accurate, recognizable enough like `map` or
`flatMap` would be. I think once it is in
On Wed, 23 Nov 2022 13:28:33 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/IDisconnectable.java
>> line 34:
>>
>>> 32: */
>>> 33: @FunctionalInterface
>>> 34: public interface IDisconnectable {
>>
>> I'm still in favor of remove the `I` in
On Wed, 23 Nov 2022 13:03:00 GMT, Marius Hanl wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 28 additional
>> commits
On Wed, 23 Nov 2022 09:45:53 GMT, Ambarish Rapte wrote:
> Clean backport.
This pull request has now been integrated.
Changeset: 516bce01
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx11u/commit/516bce013e7d071bd04b4e4ed1f4c8b861394d71
Stats: 3 lines in 3 files changed:
On Tue, 22 Nov 2022 20:22:06 GMT, Andy Goryachev wrote:
>> Introduction
>>
>> There is a number of places where various listeners (strong as well as weak)
>> are added, to be later disconnected in one go. For example, Skin
>> implementations use dispose() method to clean up the listeners
On Tue, 22 Nov 2022 20:29:10 GMT, Kevin Rushforth wrote:
> Nearly clean backport, except for the changes in
> `gradle/verification.metadata`, since that file doesn't exist in jfx11u, and
> a trivial merge conflict in the updated copyright line in 3 files.
>
> CI build run on all three
On Tue, 22 Nov 2022 20:27:57 GMT, Kevin Rushforth wrote:
> Nearly clean backport, except for the changes in
> `gradle/verification.metadata`, since that file doesn't exist in jfx11u.
>
> CI build run on all three platforms.
This pull request has now been integrated.
Changeset: fb072e56
On Tue, 22 Nov 2022 20:31:23 GMT, Kevin Rushforth wrote:
> Not a clean backport. The one line change to `build.properties` applied
> cleanly. The other two files, `gradle/verification.metadata` and the GitHub
> actions script, don't exist in jfx11u.
>
> CI build run on Linux.
This pull
On Mon, 21 Nov 2022 23:32:52 GMT, Andy Goryachev wrote:
>> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
>> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>>
>> We propose to address all these issues by replacing the old column resize
>> algorithm
On Tue, 22 Nov 2022 20:22:06 GMT, Andy Goryachev wrote:
>> Introduction
>>
>> There is a number of places where various listeners (strong as well as weak)
>> are added, to be later disconnected in one go. For example, Skin
>> implementations use dispose() method to clean up the listeners
Clean backport.
-
Commit messages:
- 8294722: FX: Update copyright year in docs, readme files to 2023
Changes: https://git.openjdk.org/jfx11u/pull/123/files
Webrev: https://webrevs.openjdk.org/?repo=jfx11u=123=00
Issue: https://bugs.openjdk.org/browse/JDK-8294722
Stats: 3
On Wed, 23 Nov 2022 08:49:42 GMT, Ambarish Rapte wrote:
> Clean backport, Verified on Mac and Windows
This pull request has now been integrated.
Changeset: e00d4fbb
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx11u/commit/e00d4fbbfe7d588d5acd84212f616824ddda5127
Stats:
Clean backport, Verified on Mac and Windows
-
Commit messages:
- 8293795: [Accessibility] [Win] [Narrator] Exceptions when deleting text with
continous key press in TextArea and TextField
Changes: https://git.openjdk.org/jfx11u/pull/122/files
Webrev:
On Tue, 22 Nov 2022 18:37:50 GMT, Ambarish Rapte wrote:
> Clean backport, verified on Mac and Windows.
This pull request has now been integrated.
Changeset: 088509eb
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx11u/commit/088509eb5dd2122aa4e5f3d2b3e592923fbf1f12
Stats:
On Tue, 22 Nov 2022 18:36:08 GMT, Ambarish Rapte wrote:
> Clean backport, tested on Mac and Windows.
This pull request has now been integrated.
Changeset: c66931b8
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx11u/commit/c66931b83acdd864b517af8039514aed51b35179
Stats:
On Tue, 22 Nov 2022 18:06:03 GMT, Ambarish Rapte wrote:
> Not clean compared to jfx mainline.
> But clean when backported from jfx17u.
> Created this PR using commit hash from jfx17u.
>
> The `@since` tag still needs to modified, trying this fist commit to test if
> the PR will be marked as
On Tue, 22 Nov 2022 20:31:23 GMT, Kevin Rushforth wrote:
> Not a clean backport. The one line change to `build.properties` applied
> cleanly. The other two files, `gradle/verification.metadata` and the GitHub
> actions script, don't exist in jfx11u.
>
> CI build run on Linux.
Marked as
On Tue, 22 Nov 2022 20:27:57 GMT, Kevin Rushforth wrote:
> Nearly clean backport, except for the changes in
> `gradle/verification.metadata`, since that file doesn't exist in jfx11u.
>
> CI build run on all three platforms.
Marked as reviewed by arapte (Reviewer).
-
PR:
On Tue, 22 Nov 2022 20:29:10 GMT, Kevin Rushforth wrote:
> Nearly clean backport, except for the changes in
> `gradle/verification.metadata`, since that file doesn't exist in jfx11u, and
> a trivial merge conflict in the updated copyright line in 3 files.
>
> CI build run on all three
On Wed, 23 Nov 2022 08:09:54 GMT, Florian Kirmaier
wrote:
>> Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added
>> a unit-test for it.
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8256397
>> run test: `./gradlew --continue -PFULL_TEST=true controls:test --tests
On Fri, 18 Nov 2022 03:19:03 GMT, Michael Strauß wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK_8256397
>> Fixed more issues with the multiple selection model change events, and
>> verified them with
> Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added
> a unit-test for it.
> ticket: https://bugs.openjdk.java.net/browse/JDK-8256397
> run test: `./gradlew --continue -PFULL_TEST=true controls:test --tests
> "*MultipleSelectionModelImplTest*"`
Florian Kirmaier has
> Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added
> a unit-test for it.
> ticket: https://bugs.openjdk.java.net/browse/JDK-8256397
> run test: `./gradlew --continue -PFULL_TEST=true controls:test --tests
> "*MultipleSelectionModelImplTest*"`
Florian Kirmaier has
On Tue, 22 Nov 2022 18:39:43 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Tue, 22 Nov 2022 22:21:11 GMT, Kevin Rushforth wrote:
>> good catch - I think the change is not equivalent. It should be either
>>
>> 4L * physicalWidth * physicalHeight;
>>
>>
>> or
>>
>>
>> ((long)physicalWidth) * physicalHeight * 4L;
>>
>>
>> the proposed change might result in
73 matches
Mail list logo
