Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-10 Thread Heikki Linnakangas
Simon Riggs wrote: When the WAL starts streaming the *primary* can immediately perform synchronous replication, i.e. commit waits for transfer. Until the standby has obtained all the missing log files, it's not up-to-date, and there's no guarantee that it can finish the replay. For example,

Re: [HACKERS] Function with default value not replacing old definition of the function

2008-12-10 Thread Rushabh Lathia
On Thu, Dec 11, 2008 at 12:59 PM, Pavel Stehule <[EMAIL PROTECTED]>wrote: > 2008/12/11 Rushabh Lathia <[EMAIL PROTECTED]>: > > > > > > On Thu, Dec 11, 2008 at 12:40 PM, Pavel Stehule <[EMAIL PROTECTED] > > > > wrote: > >> > >> Hello > >> > >> > >> when you created function, we cannot check default

Re: [HACKERS] Function with default value not replacing old definition of the function

2008-12-10 Thread Pavel Stehule
2008/12/11 Rushabh Lathia <[EMAIL PROTECTED]>: > > > On Thu, Dec 11, 2008 at 12:40 PM, Pavel Stehule <[EMAIL PROTECTED]> > wrote: >> >> Hello >> >> >> when you created function, we cannot check defaults, because we don't >> know if anybody use default or not. And when you call function, then >> pos

Re: [HACKERS] Function with default value not replacing old definition of the function

2008-12-10 Thread Rushabh Lathia
On Thu, Dec 11, 2008 at 12:40 PM, Pavel Stehule <[EMAIL PROTECTED]>wrote: > Hello > > 2008/12/11 Rushabh Lathia <[EMAIL PROTECTED]>: > > Hi, > > > > Testcase: (8.4 CVS head) > > > > > > CREATE OR REPLACE FUNCTION myfunc(y int) > > RETURNS INTEGER AS $$ > >select 100; > >

Re: [HACKERS] PLUGINS Functionlity in Win32 build scripts

2008-12-10 Thread MUHAMMAD ASIF
I am on it , I understand your concern. I will send you the sample code and pldebugger details to test the logic ASAP .Thanks.> Date: Tue, 9 Dec 2008 23:36:42 -0500> From: [EMAIL PROTECTED]> To: [EMAIL PROTECTED]> Subject: Re: [HACKERS] PLUGINS Functionlity in Win32 build scripts> CC: pgsql-ha

Re: [HACKERS] Function with default value not replacing old definition of the function

2008-12-10 Thread Pavel Stehule
Hello 2008/12/11 Rushabh Lathia <[EMAIL PROTECTED]>: > Hi, > > Testcase: (8.4 CVS head) > > > CREATE OR REPLACE FUNCTION myfunc(y int) > RETURNS INTEGER AS $$ >select 100; > $$ language sql; > > CREATE OR REPLACE FUNCTION myfunc(y int, x integer DEFAULT 100) > RETURNS INT

Re: [HACKERS] Function with default value not replacing old definition of the function

2008-12-10 Thread Rushabh Lathia
On Thu, Dec 11, 2008 at 12:33 PM, Peter Eisentraut <[EMAIL PROTECTED]> wrote: > Rushabh Lathia wrote: > >> Hi, >> >> Testcase: (8.4 CVS head) >> >> >> CREATE OR REPLACE FUNCTION myfunc(y int) >> RETURNS INTEGER AS $$ >> select 100; >> $$ language sql; >> >> CREATE OR REPLAC

Re: [HACKERS] Function with default value not replacing old definition of the function

2008-12-10 Thread Peter Eisentraut
Rushabh Lathia wrote: Hi, Testcase: (8.4 CVS head) CREATE OR REPLACE FUNCTION myfunc(y int) RETURNS INTEGER AS $$ select 100; $$ language sql; CREATE OR REPLACE FUNCTION myfunc(y int, x integer DEFAULT 100) RETURNS INTEGER AS $$ select 200; $$ language sql; select

[HACKERS] Function with default value not replacing old definition of the function

2008-12-10 Thread Rushabh Lathia
Hi, Testcase: (8.4 CVS head) CREATE OR REPLACE FUNCTION myfunc(y int) RETURNS INTEGER AS $$ select 100; $$ language sql; CREATE OR REPLACE FUNCTION myfunc(y int, x integer DEFAULT 100) RETURNS INTEGER AS $$ select 200; $$ language sql; select myfunc(10); myfunc --

Re: [HACKERS] Multiplexing SUGUSR1

2008-12-10 Thread Heikki Linnakangas
Fujii Masao wrote: On Thu, Dec 11, 2008 at 10:55 AM, Fujii Masao <[EMAIL PROTECTED]> wrote: I will update the patch based on yours, and add the support for auxiliary processes into it. Or, should I leave renewal of the patch to you? Of course, if you don't have time, I will do. I can do it,

Re: [HACKERS] build failure in pgevent

2008-12-10 Thread ITAGAKI Takahiro
Peter Eisentraut <[EMAIL PROTECTED]> wrote: > On Thursday 11 December 2008 07:19:00 ITAGAKI Takahiro wrote: > > I enconterd build failure in mingw. > > Do we need a rule for win32ver.rc in pgevent/Makefile ? > > It should be in src/makefiles/Makefile.win32. It was recently moved. Do you > per

Re: [HACKERS] build failure in pgevent

2008-12-10 Thread Peter Eisentraut
On Thursday 11 December 2008 07:19:00 ITAGAKI Takahiro wrote: > I enconterd build failure in mingw. > Do we need a rule for win32ver.rc in pgevent/Makefile ? It should be in src/makefiles/Makefile.win32. It was recently moved. Do you perhaps have a partial CVS update? -- Sent via pgsql-hacker

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread Bruce Momjian
Bruce Momjian wrote: > Let me outline the simplest API, assuming we are using table-level > granularity for the security columns. > > CREATE TABLE would support > > WITH (ROWACL = TRUE/FALSE); > > for row-level acl and: > > WITH (SECEXT = TRUE/FALSE); > > for SE-Linux, with 'SECEXT

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread Bruce Momjian
Bruce Momjian wrote: > KaiGai Kohei wrote: > > >>CREATE TABLE t ( > > >>a int, > > >>b text > > >>) WITH (ROW_LEVEL_ACL=ON); Let me outline the simplest API, assuming we are using table-level granularity for the security columns. CREATE TABLE would support WIT

[HACKERS] build failure in pgevent

2008-12-10 Thread ITAGAKI Takahiro
Hello, I enconterd build failure in mingw. Do we need a rule for win32ver.rc in pgevent/Makefile ? make[3]: Entering directory `/d/projects/head/src/bin/pgevent' make[3]: *** No rule to make target `win32ver.rc', needed by `pgmsgevent.o'. Stop. make[3]: Leaving directory `/d/projects/head/

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread Bruce Momjian
KaiGai Kohei wrote: > >>> Here is our OID column on some rows but not others: > >>> > >>> test=> CREATE TABLE test (x INT) WITH oids; > >>> CREATE TABLE > >>> test=> INSERT INTO test VALUES (1); > >>> INSERT 16392 1 > >>> test=> ALTER TABLE test SET WITHOUT OIDS; > >>> ALTER TABLE > >>>

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread Bruce Momjian
KaiGai Kohei wrote: > >>CREATE TABLE t ( > >>a int, > >>b text > >>) WITH (ROW_LEVEL_ACL=ON); > > > > As I mentioned below, this might not be necessary, meaning that row > > security is enabled for rows where you set the row security value and > > does not need to be tu

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread KaiGai Kohei
> I am unclear how hard it would be to allow it to be > controlled via INSERT, meaning it would be present only if the row had a > SEC value supplied. It is impossible, and not suitable for SE-PostgreSQL. The HeapTuple is allocated prior to fetch INSERT'ed value. In addition, SE-PostgreSQL ass

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread KaiGai Kohei
Bruce Momjian wrote: KaiGai Kohei wrote: Let's decide exactly what configure options, GUC options, system catalog changes, and user-visible SQL command syntax we are going to use for the patch before you recode anything. The guest of PGACE security framework should be chosen by configure option

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread Bruce Momjian
KaiGai Kohei wrote: > Bruce Momjian wrote: > > Bruce Momjian wrote: > >> Second, system catalogs; are you going to have separate columns for > >> SQL-level row security and SE-Linux security? If so, is the SE-Linux > >> column only going to be created by the --enable-selinux build? If so, > >> th

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread Bruce Momjian
KaiGai Kohei wrote: > > Let's decide exactly what configure options, GUC options, system catalog > > changes, and user-visible SQL command syntax we are going to use for the > > patch before you recode anything. > > The guest of PGACE security framework should be chosen by configure option. > It a

Re: [HACKERS] benchmarking the query planner

2008-12-10 Thread Robert Haas
> Yeah, that would be fast. To see a quadratic case you need MCV arrays > that have little or no overlap of common values --- then each element of > the first will be compared (in vain) to all or most of the elements in > the second. Ah, that makes sense. Here's a test case based on Greg's. Thi

Re: [HACKERS] Multiplexing SUGUSR1

2008-12-10 Thread Fujii Masao
Hi, On Thu, Dec 11, 2008 at 10:55 AM, Fujii Masao <[EMAIL PROTECTED]> wrote: > Hi, > >> My version doesn't have support for auxiliary processes. Does the >> synchronous replication patch need that? > > Yes, the background writer also generates the WAL like a backend, > so it has to be able to comm

Re: [HACKERS] Multiplexing SUGUSR1

2008-12-10 Thread Fujii Masao
Hi, > My version doesn't have support for auxiliary processes. Does the > synchronous replication patch need that? Yes, the background writer also generates the WAL like a backend, so it has to be able to communicate with walsender. > On closer look, I don't see anything setting ProcSignalData.p

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread KaiGai Kohei
Bruce Momjian wrote: Bruce Momjian wrote: Second, system catalogs; are you going to have separate columns for SQL-level row security and SE-Linux security? If so, is the SE-Linux column only going to be created by the --enable-selinux build? If so, that is going to mean that the /data director

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread KaiGai Kohei
Bruce Momjian wrote: KaiGai Kohei wrote: But your larger point is that SQL-row-level security should always be available, which I just posted about. If so, it should be hardcoded on somewhere, no need to be implemented as a guest of PGACE security framework. Its purpose is to implement enhanced

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread Bruce Momjian
Bruce Momjian wrote: > Second, system catalogs; are you going to have separate columns for > SQL-level row security and SE-Linux security? If so, is the SE-Linux > column only going to be created by the --enable-selinux build? If so, > that is going to mean that the /data directory is going to be

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread Aidan Van Dyk
* Zdenek Kotala <[EMAIL PROTECTED]> [081210 12:29]: >> No, the standard way to deal with such issues is to set up two buildfarm >> members. This would be a 100% waste of cycles for gcc-based members >> anyway, since gcc generates the same code with or without -g. However, >> for compilers where

Re: [HACKERS] WIP: default values for function parameters

2008-12-10 Thread Pavel Stehule
2008/12/10 Tom Lane <[EMAIL PROTECTED]>: > "Pavel Stehule" <[EMAIL PROTECTED]> writes: >> next argument - if we accept AS for param names, then we introduce >> nonconsistent behave with SQL/XML functions. > >> select xmlforest(c1, c2 as foo, c3) -- there foo isn't doesn't mean >> "use it as param f

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread Andrew Dunstan
Zdenek Kotala wrote: Tom Lane napsal(a): [EMAIL PROTECTED] writes: On Wed, 10 Dec 2008, Heikki Linnakangas wrote: BTW, why does this work on warthog buildfarm member? Different compiler version? it's configured with --enable-debug. Maybe run_build.pl should run twice, onece with --enable-

Re: [HACKERS] PostgreSQL 8.3.4 reproducible crash

2008-12-10 Thread Jeff Davis
On Wed, 2008-12-10 at 14:12 -0500, Tom Lane wrote: > create domain d as int; > create view v as select '-1'::d; > alter domain d add constraint "c" check (value > 0); > select * from v; > > Right now you get an error at the SELECT, but that seems a bit > surprising. It's e

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread Peter Eisentraut
On Wednesday 10 December 2008 19:36:38 Tom Lane wrote: > Zdenek Kotala <[EMAIL PROTECTED]> writes: > > Tom Lane napsal(a): > >> No, the standard way to deal with such issues is to set up two buildfarm > >> members. > > > > I think current infrastructures is not good for it. For example I would > >

Re: [HACKERS] portability of "designated initializers"

2008-12-10 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Do we need a struct, or can we get away with storing the values directly > in RelationData? Something like this: The intention behind having a separate struct was that there could possibly be different sets of reloptions for different types of relation

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-10 Thread Jeff Davis
On Wed, 2008-12-10 at 20:04 +, Simon Riggs wrote: > > They might care a lot about PITR > > though, and that would be impossible if you lose the archive. > > Agreed, yes we need it as an option. > > > Do you see a cost to allowing all of the options listed by Fujii Masao? > > I haven't argued

Re: [HACKERS] portability of "designated initializers"

2008-12-10 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > I've already modified your patch a bit ... please send your updated > > patch so I can merge it into mine. However, my changes were also > > relatively minor. Since Tom wants it to be entirely rewritten then > > maybe merging minor

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-10 Thread Simon Riggs
On Wed, 2008-12-10 at 21:02 +0200, Heikki Linnakangas wrote: > Simon Riggs wrote: > > * cooperation: if wal receiver is a server process we can reasonably > > communicate the current WAL limit via shared memory. That gives us > > smooth flow of WAL between receiver and replay (startup process) rat

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-10 Thread Jeff Davis
On Wed, 2008-12-10 at 09:48 +, Simon Riggs wrote: > What is complicated about having the archive on the standby server? > If the storage on the standby fails, you would lose the archive, right? I think there's a use case for having two identical servers, and just setting them up to replicat

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-10 Thread Simon Riggs
On Wed, 2008-12-10 at 11:52 -0800, Jeff Davis wrote: > On Wed, 2008-12-10 at 09:48 +, Simon Riggs wrote: > > What is complicated about having the archive on the standby server? > > > > If the storage on the standby fails, you would lose the archive, right? As well as the standby itself pre

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-10 Thread Aidan Van Dyk
* Simon Riggs <[EMAIL PROTECTED]> [081210 14:58]: > I think you just went down the same path I did before. (That's a good > sign). > > When the WAL starts streaming the *primary* can immediately perform > synchronous replication, i.e. commit waits for transfer. The *standby* > has an initial lag

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-10 Thread Simon Riggs
On Wed, 2008-12-10 at 20:52 +0200, Heikki Linnakangas wrote: > Simon Riggs wrote: > > On Wed, 2008-12-10 at 14:39 +0200, Heikki Linnakangas wrote: > > > >> For a solution that doesn't depend on the file-based log shipping, I > >> think we'll need a way for the standby to request a certain starti

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread Martijn van Oosterhout
On Wed, Dec 10, 2008 at 06:27:05PM +0100, Zdenek Kotala wrote: > I think current infrastructures is not good for it. For example I would > like to compile postgres on one machine with three different compiler and > in 32 or 64 mode. Should I have 6 animals? I think better idea is to have > one a

Re: [HACKERS] PostgreSQL 8.3.4 reproducible crash

2008-12-10 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > I propose that we simply add add a NULL-check there: Certainly not. A read-only function has no business causing a snapshot to become established. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@po

Re: [HACKERS] PostgreSQL 8.3.4 reproducible crash

2008-12-10 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > I think the right fix is to ensure that ActiveSnapshot is set. The proximate cause is certainly lack of a snapshot, but I think there might be some other interesting issues here too. The crash comes when the SQL-language domain check function demands a

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread Bruce Momjian
KaiGai Kohei wrote: > > But your larger point is that SQL-row-level security should always be > > available, which I just posted about. > > If so, it should be hardcoded on somewhere, no need to be implemented > as a guest of PGACE security framework. Its purpose is to implement > enhanced securit

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-10 Thread Heikki Linnakangas
Simon Riggs wrote: * cooperation: if wal receiver is a server process we can reasonably communicate the current WAL limit via shared memory. That gives us smooth flow of WAL between receiver and replay (startup process) rather than a burst of activity each time a file arrives. That helps smooth p

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-10 Thread Heikki Linnakangas
Simon Riggs wrote: On Wed, 2008-12-10 at 14:39 +0200, Heikki Linnakangas wrote: For a solution that doesn't depend on the file-based log shipping, I think we'll need a way for the standby to request a certain starting point for the streaming when it connects. When the standby starts, it would

Re: [HACKERS] PostgreSQL 8.3.4 reproducible crash

2008-12-10 Thread Alvaro Herrera
Heikki Linnakangas wrote: > Dmitry Koterov wrote: >> select '(1)'::bug1.composite; > > Reproducible on 8.2 as well. And HEAD too. > because ActiveSnapshot is NULL. ActiveSnapshot has not yet been set, > because the input function and domain checking is done in the parse > analyze phase. I t

Re: [HACKERS] WAL documentation changes

2008-12-10 Thread Josh Berkus
First, none of the general purpose filesystems I've seen so far do data journalling per default, since it's a huge performance penalty, even for non-RDBMS workloads. The feature you talk about is ext3 specific (and should be pointed out as such) and only disables write ordering, meaning that met

Re: [HACKERS] benchmarking the query planner

2008-12-10 Thread Tom Lane
"Robert Haas" <[EMAIL PROTECTED]> writes: > On Mon, Dec 8, 2008 at 10:24 AM, Gregory Stark <[EMAIL PROTECTED]> wrote: >> I tried a different query, trying to get quadratic growth and again failed. >> It > The profiling results I sent the other day show an exactly-linear > increase in the number o

Re: [HACKERS] Regexps vs. locale

2008-12-10 Thread Tom Lane
Andrew Gierth <[EMAIL PROTECTED]> writes: > "Tom" == Tom Lane <[EMAIL PROTECTED]> writes: > Tom> It's not so much intentional as that no one has gotten around to > Tom> making it work. The difficulty is that the wide-char codes we > Tom> are using might not match what the functions expect, >

Re: [HACKERS] WIP: default values for function parameters

2008-12-10 Thread Tom Lane
"Pavel Stehule" <[EMAIL PROTECTED]> writes: > next argument - if we accept AS for param names, then we introduce > nonconsistent behave with SQL/XML functions. > select xmlforest(c1, c2 as foo, c3) -- there foo isn't doesn't mean > "use it as param foo", It could be read as meaning that, I think.

Re: [HACKERS] WIP: default values for function parameters

2008-12-10 Thread Pavel Stehule
2008/12/10 Tom Lane <[EMAIL PROTECTED]>: > "Pavel Stehule" <[EMAIL PROTECTED]> writes: >> look again >> select c as foo from tab ... >> select fce(c as foo) from tab ... > >> when you use AS as param names specification, you change meaning of >> some construct via used context? > > Uh, what's your

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread Tom Lane
Zdenek Kotala <[EMAIL PROTECTED]> writes: > Tom Lane napsal(a): >> No, the standard way to deal with such issues is to set up two buildfarm >> members. > I think current infrastructures is not good for it. For example I would like > to > compile postgres on one machine with three different compi

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] wrote: >> Never saw a problem with gcc, hp-ux, darwin or M$? > Sure, that's not what I was saying. My point is, when there's a bug in > one version of a compiler, we shouldn't try to adapt PostgreSQL to that > bug. Instead, we sh

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread Zdenek Kotala
Tom Lane napsal(a): [EMAIL PROTECTED] writes: On Wed, 10 Dec 2008, Heikki Linnakangas wrote: BTW, why does this work on warthog buildfarm member? Different compiler version? it's configured with --enable-debug. Maybe run_build.pl should run twice, onece with --enable-debug once without. N

Re: [HACKERS] WIP: default values for function parameters

2008-12-10 Thread Pavel Stehule
2008/12/10 Tom Lane <[EMAIL PROTECTED]>: > "Pavel Stehule" <[EMAIL PROTECTED]> writes: >> 2008/12/10 Bruce Momjian <[EMAIL PROTECTED]>: >>> Well, that is interesting, but in SQL we already use 'AS' in most places >>> where we want to assign a label to a value, so it seems AS is more >>> logical for

Re: [HACKERS] WIP: default values for function parameters

2008-12-10 Thread Tom Lane
"Pavel Stehule" <[EMAIL PROTECTED]> writes: > look again > select c as foo from tab ... > select fce(c as foo) from tab ... > when you use AS as param names specification, you change meaning of > some construct via used context? Uh, what's your point? AS changes the meaning too. For example in

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread Tom Lane
[EMAIL PROTECTED] writes: > On Wed, 10 Dec 2008, Heikki Linnakangas wrote: >> BTW, why does this work on warthog buildfarm member? Different compiler >> version? >> > it's configured with --enable-debug. > Maybe run_build.pl should run twice, onece with --enable-debug once > without. No, the st

Re: [HACKERS] WIP: default values for function parameters

2008-12-10 Thread Tom Lane
"Pavel Stehule" <[EMAIL PROTECTED]> writes: > 2008/12/10 Bruce Momjian <[EMAIL PROTECTED]>: >> Well, that is interesting, but in SQL we already use 'AS' in most places >> where we want to assign a label to a value, so it seems AS is more >> logical for SQL at this point. > Question is - what is la

Re: [HACKERS] Simple postgresql.conf wizard

2008-12-10 Thread Kevin Grittner
>>> Tom Lane <[EMAIL PROTECTED]> wrote: > [ a bit off-topic for the thread, but ... ] > > "Kevin Grittner" <[EMAIL PROTECTED]> writes: >> I'll attach the query and plan. You'll note that the query looks a >> little odd, especially all the (1=1) tests. > > FWIW, it would be better to use "TRUE"

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-10 Thread Simon Riggs
On Wed, 2008-12-10 at 14:39 +0200, Heikki Linnakangas wrote: > In the current form, is there any reason why walreceiver needs to be > an integrated server process? Couldn't it just be a stand-alone > program that connects to the primary and writes the received records > to the right WAL file? The

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-10 Thread Simon Riggs
On Wed, 2008-12-10 at 14:39 +0200, Heikki Linnakangas wrote: > For a solution that doesn't depend on the file-based log shipping, I > think we'll need a way for the standby to request a certain starting > point for the streaming when it connects. When the standby starts, it > would first recov

Re: [HACKERS] ALTER composite type does not work, but ALTER TABLE which ROWTYPE is used as a type - works fine

2008-12-10 Thread Andrew Chernow
Andrew Dunstan wrote: This whole debate seems moot. We're not going to remove composite types created with CREATE TYPE, so the rest is irrelevant. We don't have the luxury of revisiting such decisions made many years ago, whether or not you think they were good. You can always fix someth

Re: [HACKERS] ALTER composite type does not work, but ALTER TABLE which ROWTYPE is used as a type - works fine

2008-12-10 Thread Alvaro Herrera
Merlin Moncure escribió: > On Wed, Dec 10, 2008 at 9:05 AM, Alvaro Herrera > <[EMAIL PROTECTED]> wrote: > > I disagree that CREATE TABLE should be (or should have been) used to > > create types. Someday we might need to expand the work we do for that > > case in a different direction than tables,

Re: [HACKERS] ALTER composite type does not work, but ALTER TABLE which ROWTYPE is used as a type - works fine

2008-12-10 Thread Andrew Dunstan
Merlin Moncure wrote: On Wed, Dec 10, 2008 at 9:05 AM, Alvaro Herrera <[EMAIL PROTECTED]> wrote: Merlin Moncure escribió: Bruce Momjian <[EMAIL PROTECTED]>http://momjian.us OK, so what should the TODO item be? On Wed, Dec 10, 2008 at 7:44 AM, Robert Haas <[EMAIL

Re: [HACKERS] ALTER composite type does not work, but ALTER TABLE which ROWTYPE is used as a type - works fine

2008-12-10 Thread Merlin Moncure
On Wed, Dec 10, 2008 at 9:05 AM, Alvaro Herrera <[EMAIL PROTECTED]> wrote: > Merlin Moncure escribió: >> >> Bruce Momjian <[EMAIL PROTECTED]>http://momjian.us >> >> OK, so what should the TODO item be? >> On Wed, Dec 10, 2008 at 7:44 AM, Robert Haas <[EMAIL PROTECTED]> wrote: >> > Allow A

Re: [HACKERS] ALTER composite type does not work, but ALTER TABLE which ROWTYPE is used as a type - works fine

2008-12-10 Thread Robert Haas
On Wed, Dec 10, 2008 at 8:00 AM, Bruce Momjian <[EMAIL PROTECTED]> wrote: > Robert Haas wrote: >> Allow ALTER TYPE to add, rename, change the type of, and drop columns? > > That seems kind of vague because my first reaction is that a type > doesn't have columns, but you are talking about composite

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread Heikki Linnakangas
[EMAIL PROTECTED] wrote: On Wed, 10 Dec 2008, Heikki Linnakangas wrote: I find it pretty scary to work around compiler bugs like this. Who knows what other code it miscompiles. Can you reduce fsm_search_avail into a small stand-alone test program, and file a bug report with the compiler vendor

Re: [HACKERS] ALTER composite type does not work, but ALTER TABLE which ROWTYPE is used as a type - works fine

2008-12-10 Thread Alvaro Herrera
Merlin Moncure escribió: > >> Bruce Momjian <[EMAIL PROTECTED]>http://momjian.us > >> OK, so what should the TODO item be? > On Wed, Dec 10, 2008 at 7:44 AM, Robert Haas <[EMAIL PROTECTED]> wrote: > > Allow ALTER TYPE to add, rename, change the type of, and drop columns? > > That's proba

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread ohp
On Wed, 10 Dec 2008, Heikki Linnakangas wrote: Date: Wed, 10 Dec 2008 13:00:31 +0200 From: Heikki Linnakangas <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Cc: Tom Lane <[EMAIL PROTECTED]>, Zdenek Kotala <[EMAIL PROTECTED]>, pgsql-hackers list Subject: Re: [HACKERS] cvs head initdb hangs on uni

Re: [HACKERS] WIP: default values for function parameters

2008-12-10 Thread Pavel Stehule
2008/12/10 Bruce Momjian <[EMAIL PROTECTED]>: > Pavel Stehule wrote: >> >> PL/pgSQL < PL/SQL < ADA so using '=>' is only consistent and natural. >> >> And it is my goal. >> > >> > Well, that is interesting, but in SQL we already use 'AS' in most places >> > where we want to assign a label to a valu

Re: [HACKERS] WIP: default values for function parameters

2008-12-10 Thread Bruce Momjian
Pavel Stehule wrote: > >> PL/pgSQL < PL/SQL < ADA so using '=>' is only consistent and natural. > >> And it is my goal. > > > > Well, that is interesting, but in SQL we already use 'AS' in most places > > where we want to assign a label to a value, so it seems AS is more > > logical for SQL at this

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread KaiGai Kohei
Bruce Momjian wrote: Peter Eisentraut wrote: KaiGai Kohei wrote: I don't agree. What is the reason why? It has been unclear for me. The PGACE security framework is designed to allow users to choose an enhanced security mechanism from some of provided options. (Currently, we have sepgsql and ro

Re: [HACKERS] WIP: default values for function parameters

2008-12-10 Thread Pavel Stehule
2008/12/10 Bruce Momjian <[EMAIL PROTECTED]>: > Pavel Stehule wrote: >> > >> > How would a user recognise which of these are legal operator names? >> > >> > Incidentally -- EDB selling Oracle compatibility may put me in a >> > questionable >> > position here -- the more Oracle incompatibilities in

Re: [HACKERS] PostgreSQL 8.3.4 reproducible crash

2008-12-10 Thread Heikki Linnakangas
Dmitry Koterov wrote: Hello. Here is the SQL to reproduce the server crash: CREATE SCHEMA bug1 AUTHORIZATION postgres; SET search_path = bug1, pg_catalog; CREATE FUNCTION bug1.domain_check (integer) RETURNS boolean AS $body$ SELECT $1 <> 0 $body$ LANGUAGE sql IMMUTABLE STRICT; CREATE DOMAIN

Re: [HACKERS] ALTER composite type does not work, but ALTER TABLE which ROWTYPE is used as a type - works fine

2008-12-10 Thread Merlin Moncure
>> Bruce Momjian <[EMAIL PROTECTED]>http://momjian.us >> OK, so what should the TODO item be? On Wed, Dec 10, 2008 at 7:44 AM, Robert Haas <[EMAIL PROTECTED]> wrote: > Allow ALTER TYPE to add, rename, change the type of, and drop columns? That's probably the consensus view. Personally,

Re: [HACKERS] ALTER composite type does not work, but ALTER TABLE which ROWTYPE is used as a type - works fine

2008-12-10 Thread Bruce Momjian
Robert Haas wrote: > Allow ALTER TYPE to add, rename, change the type of, and drop columns? That seems kind of vague because my first reaction is that a type doesn't have columns, but you are talking about composite types, right? I have added this TODO item: Allow ALTER TYPE on composite

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread KaiGai Kohei
Bruce Momjian wrote: KaiGai Kohei wrote: Bruce Momjian wrote: Tom Lane wrote: KaiGai Kohei <[EMAIL PROTECTED]> writes: Bruce Momjian wrote: I assume that could just be always enabled. It is not "always" enabled. When we build it with SE-PostgreSQL feature, rest of enhanced security features

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread Bruce Momjian
Peter Eisentraut wrote: > KaiGai Kohei wrote: > > I don't agree. What is the reason why? It has been unclear for me. > > > > The PGACE security framework is designed to allow users to choose > > an enhanced security mechanism from some of provided options. > > (Currently, we have sepgsql and rowac

Re: [HACKERS] ALTER composite type does not work, but ALTER TABLE which ROWTYPE is used as a type - works fine

2008-12-10 Thread Robert Haas
Allow ALTER TYPE to add, rename, change the type of, and drop columns? ...Robert On Wed, Dec 10, 2008 at 6:36 AM, Bruce Momjian <[EMAIL PROTECTED]> wrote: > Robert Haas wrote: >> > Well, new features that have a perfectly acceptable and usable >> > workaround typically have a fairly low priority

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread Peter Eisentraut
KaiGai Kohei wrote: I don't agree. What is the reason why? It has been unclear for me. The PGACE security framework is designed to allow users to choose an enhanced security mechanism from some of provided options. (Currently, we have sepgsql and rowacl.) It is quite natural that one is disabled

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-10 Thread Heikki Linnakangas
Simon Riggs wrote: On Wed, 2008-12-10 at 14:51 +0900, Fujii Masao wrote: For clarity: the user can choose the strategy of archiving from the following. 1) each primary and standby archives 2) only primary archives 3) only standby archives 4) no server archives Those are all possible, but they

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread KaiGai Kohei
Greg Stark wrote: Is there any reason it's easier to do as a configure option instead of an initdb option or better yet a per-database option? SE-PostgreSQL needs "libselinux" to communicate with SELinux, however, it is not available for non-SELinux'ed platforms. The reason we're shying away f

Re: [HACKERS] WIP: default values for function parameters

2008-12-10 Thread Bruce Momjian
Pavel Stehule wrote: > > > > How would a user recognise which of these are legal operator names? > > > > Incidentally -- EDB selling Oracle compatibility may put me in a > > questionable > > position here -- the more Oracle incompatibilities in stock Postgres the > > better for us. But afaik we do

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread Bruce Momjian
KaiGai Kohei wrote: > Bruce Momjian wrote: > > Tom Lane wrote: > >> KaiGai Kohei <[EMAIL PROTECTED]> writes: > >>> Bruce Momjian wrote: > I assume that could just be always enabled. > >>> It is not "always" enabled. When we build it with SE-PostgreSQL feature, > >>> rest of enhanced security f

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread Greg Stark
Is there any reason it's easier to do as a configure option instead of an initdb option or better yet a per-database option? The reason we're shying away from configure options for functionality changes is that more and more users are getting pistgres from binary distributions. Which option

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread KaiGai Kohei
Bruce Momjian wrote: Tom Lane wrote: KaiGai Kohei <[EMAIL PROTECTED]> writes: Bruce Momjian wrote: I assume that could just be always enabled. It is not "always" enabled. When we build it with SE-PostgreSQL feature, rest of enhanced security features (includes the row-level ACL) are disabled

[HACKERS] PostgreSQL 8.3.4 reproducible crash

2008-12-10 Thread Dmitry Koterov
Hello. Here is the SQL to reproduce the server crash: CREATE SCHEMA bug1 AUTHORIZATION postgres; SET search_path = bug1, pg_catalog; CREATE FUNCTION bug1.domain_check (integer) RETURNS boolean AS $body$ SELECT $1 <> 0 $body$ LANGUAGE sql IMMUTABLE STRICT; CREATE DOMAIN bug1."domain" AS intege

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread Bruce Momjian
Peter Eisentraut wrote: > Heikki Linnakangas wrote: > > I find it pretty scary to work around compiler bugs like this. Who knows > > what other code it miscompiles. Can you reduce fsm_search_avail into a > > small stand-alone test program, and file a bug report with the compiler > > vendor? > >

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread Bruce Momjian
Heikki Linnakangas wrote: > [EMAIL PROTECTED] wrote: > > On Tue, 9 Dec 2008, Tom Lane wrote: > >> Hmm. It looks to me like the compiler is getting confused by the > >> interaction between nodeno, leftnodeno, and rightnodeno. Try this > >> patch to see if it gets around it. (This is a tad better

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread Peter Eisentraut
Heikki Linnakangas wrote: I find it pretty scary to work around compiler bugs like this. Who knows what other code it miscompiles. Can you reduce fsm_search_avail into a small stand-alone test program, and file a bug report with the compiler vendor? BTW, why does this work on warthog buildfar

Re: [HACKERS] ALTER composite type does not work, but ALTER TABLE which ROWTYPE is used as a type - works fine

2008-12-10 Thread Bruce Momjian
Robert Haas wrote: > > Well, new features that have a perfectly acceptable and usable > > workaround typically have a fairly low priority of fixing :-) > > Putting something in the TODO list doesn't make it a priority. But it > indicates that it's something that the community would like to see >

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread Bruce Momjian
Tom Lane wrote: > KaiGai Kohei <[EMAIL PROTECTED]> writes: > > Bruce Momjian wrote: > >> I assume that could just be always enabled. > > > It is not "always" enabled. When we build it with SE-PostgreSQL feature, > > rest of enhanced security features (includes the row-level ACL) are > > disabled a

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1268)

2008-12-10 Thread Bruce Momjian
Simon Riggs wrote: > > On Tue, 2008-12-09 at 03:33 +0900, KaiGai Kohei wrote: > > Tom Lane wrote: > > > KaiGai Kohei <[EMAIL PROTECTED]> writes: > > >> Bruce Momjian wrote: > > >>> I assume that could just be always enabled. > > > > > >> It is not "always" enabled. When we build it with SE-Postgr

Re: [HACKERS] WAL documentation changes

2008-12-10 Thread Bruce Momjian
Michael Renner wrote: > Hi, > > the comment WRT WAL recovery and FS journals [1] is a bit misleading in > it's current form. > > First, none of the general purpose filesystems I've seen so far do data > journalling per default, since it's a huge performance penalty, even for > non-RDBMS workloads

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread Heikki Linnakangas
[EMAIL PROTECTED] wrote: On Tue, 9 Dec 2008, Tom Lane wrote: Hmm. It looks to me like the compiler is getting confused by the interaction between nodeno, leftnodeno, and rightnodeno. Try this patch to see if it gets around it. (This is a tad better anyway since it avoids examining the right c

Re: [HACKERS] Multiplexing SUGUSR1

2008-12-10 Thread Heikki Linnakangas
Fujii Masao wrote: Hi, On Wed, Dec 10, 2008 at 1:43 AM, Tom Lane <[EMAIL PROTECTED]> wrote: Heikki Linnakangas <[EMAIL PROTECTED]> writes: I'm surprised you feel that way. You suggested earlier (http://archives.postgresql.org/message-id/[EMAIL PROTECTED]) that a solution that only works for pr

Re: [HACKERS] Multiplexing SUGUSR1

2008-12-10 Thread Heikki Linnakangas
Fujii Masao wrote: Hi, On Wed, Dec 10, 2008 at 1:43 AM, Tom Lane <[EMAIL PROTECTED]> wrote: Heikki Linnakangas <[EMAIL PROTECTED]> writes: I'm surprised you feel that way. You suggested earlier (http://archives.postgresql.org/message-id/[EMAIL PROTECTED]) that a solution that only works for pr

Re: [HACKERS] Multiplexing SUGUSR1

2008-12-10 Thread Fujii Masao
Hi, On Wed, Dec 10, 2008 at 1:43 AM, Tom Lane <[EMAIL PROTECTED]> wrote: > Heikki Linnakangas <[EMAIL PROTECTED]> writes: >> I'm surprised you feel that way. You suggested earlier >> (http://archives.postgresql.org/message-id/[EMAIL PROTECTED]) >> that a solution that only works for processes atta

Re: [HACKERS] cvs head initdb hangs on unixware

2008-12-10 Thread ohp
Dear Tom, On Tue, 9 Dec 2008, Tom Lane wrote: Date: Tue, 09 Dec 2008 13:24:21 -0500 From: Tom Lane <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Cc: Zdenek Kotala <[EMAIL PROTECTED]>, Heikki Linnakangas <[EMAIL PROTECTED]>, pgsql-hackers list Subject: Re: [HACKERS] cvs head initdb hangs on

  1   2   >