Re: [HACKERS] Mail thread references in commits

* Tom Lane (t...@sss.pgh.pa.us) wrote: > Andres Freund writes: > > This: > > >> Discussion: > >> https://postgr.es/m/20161128182113.6527.58...@wrigleys.postgresql.org > >> Discussion: > >> https://postgr.es/m/CA+renyUEE29=X01JXdz8_TQvo6n9=2xoebbrnq8rklyr+kj...@mail.gmail.com > > > still looks

Re: [HACKERS] Mail thread references in commits

Andres Freund writes: > This: >> Discussion: >> https://postgr.es/m/20161128182113.6527.58...@wrigleys.postgresql.org >> Discussion: >> https://postgr.es/m/CA+renyUEE29=X01JXdz8_TQvo6n9=2xoebbrnq8rklyr+kj...@mail.gmail.com > still looks better than: >> Discussion: >> http://www.postgresql.or

Re: [HACKERS] Mail thread references in commits

On 2016-12-01 18:12:34 -0500, Tom Lane wrote: > Robert Haas writes: > > On Thu, Dec 1, 2016 at 4:33 PM, Tom Lane wrote: > >> When and if somebody tries to game that, we can do something about it, > >> but I'm not very worried. It's not like it's not trivial to get your > >> company's name, or $b

Re: [HACKERS] Mail thread references in commits

Robert Haas writes: > On Thu, Dec 1, 2016 at 4:33 PM, Tom Lane wrote: >> When and if somebody tries to game that, we can do something about it, >> but I'm not very worried. It's not like it's not trivial to get your >> company's name, or $badword of your choice, into the archives already. > Sur

Re: [HACKERS] Mail thread references in commits

On 2016-12-01 18:05:19 -0500, Tom Lane wrote: > ... the shortener isn't really doing anything for us. You end up with a > line longer than 80 characters with message-IDs generated by either gmail > or the bug report form, for instance these examples from recent commits: Still seems quite useful t

Re: [HACKERS] Mail thread references in commits

Stephen Frost writes: > Further, we seem agreed that URLs are what we want to have in the > commits rather than just the message-ID. If we're set on doing that, then ... > The question on the table at the moment seems to be if we want to use > https://postgr.es/m/ or https://postgresql.org/messa

Re: [HACKERS] Mail thread references in commits

All, * Tom Lane (t...@sss.pgh.pa.us) wrote: > I think this is a straw man. We've already decided to use message-IDs > as the basic identity of messages for this purpose; other proposals > were considered before and rejected as too inconvenient. I tend to agree with Tom on this, for better or wor

Re: [HACKERS] Mail thread references in commits

On Thu, Dec 1, 2016 at 4:33 PM, Tom Lane wrote: > Robert Haas writes: >> On Wed, Nov 30, 2016 at 1:50 PM, Greg Stark wrote: >>> I can't say I feel especially strongly either way on this but just to >>> toss out a small thing that might make a small difference >>> >>> If you happen to know ho

Re: [HACKERS] Mail thread references in commits

Robert Haas writes: > On Wed, Nov 30, 2016 at 1:50 PM, Greg Stark wrote: >> I can't say I feel especially strongly either way on this but just to >> toss out a small thing that might make a small difference >> >> If you happen to know how your message-ids are generated then you >> might be a

Re: [HACKERS] Mail thread references in commits

On Wed, Nov 30, 2016 at 1:50 PM, Greg Stark wrote: > On 30 November 2016 at 16:19, Andrew Dunstan wrote: >> >> https://www.postgresql.org/message-id/cab7npqthydyf-fo+fzvxrhz-7_hptm4rodbcsy9-noqhvet...@mail.gmail.com >> >> I'll be interested to know if it breaks anyone's MUA. If it doesn't all we

Re: [HACKERS] Mail thread references in commits

On 30 November 2016 at 16:19, Andrew Dunstan wrote: > > https://www.postgresql.org/message-id/cab7npqthydyf-fo+fzvxrhz-7_hptm4rodbcsy9-noqhvet...@mail.gmail.com > > I'll be interested to know if it breaks anyone's MUA. If it doesn't all we > will be arguing about are aesthetics, and I'm a firm bel

Re: [HACKERS] Mail thread references in commits

On 11/30/2016 10:46 AM, Heikki Linnakangas wrote: Agreed. I just did my first commit with the shortened URL, and I didn't like it. If we want to use URLs, let's use the canonical https://www.postgresql.org/message-id/ format. Do we know of an actual length limit that is useful to aim for?

Re: [HACKERS] Mail thread references in commits

On 11/30/2016 04:52 PM, Peter Eisentraut wrote: On 11/27/16 8:37 AM, Magnus Hagander wrote: Ok, we now have it. https://postgr.es/m/messageid will redirect to that messageid in the main archives. I like the idea of recording the location of the discussion, but I'm not fond of the URL shortener

Re: [HACKERS] Mail thread references in commits

On 11/27/16 8:37 AM, Magnus Hagander wrote: > Ok, we now have it. https://postgr.es/m/messageid will redirect to that > messageid in the main archives. I like the idea of recording the location of the discussion, but I'm not fond of the URL shortener. Besides the general problem that URL shorteni

Re: [HACKERS] Mail thread references in commits

On 11/28/2016 09:49 AM, Alvaro Herrera wrote: Magnus Hagander wrote: I don't really read perl enough to take it apart. But http://git.kernel.org/cgit/git/git.git/tree/gitweb/gitweb.perl is the code (we're probably on an older version). I'm guessing it's coming out of format_log_line ( http://

Re: [HACKERS] Mail thread references in commits

Magnus Hagander wrote: > I don't really read perl enough to take it apart. But > http://git.kernel.org/cgit/git/git.git/tree/gitweb/gitweb.perl is the code > (we're probably on an older version). I'm guessing it's coming out of > format_log_line ( > http://git.kernel.org/cgit/git/git.git/tree/gitw

Re: [HACKERS] Mail thread references in commits

On Mon, Nov 28, 2016 at 3:36 AM, Tom Lane wrote: > Magnus Hagander writes: > > Ok, we now have it. https://postgr.es/m/messageid will redirect to that > > messageid in the main archives. > > I pushed a patch using this new convention: > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commi

Re: [HACKERS] Mail thread references in commits

Magnus Hagander writes: > Ok, we now have it. https://postgr.es/m/messageid will redirect to that > messageid in the main archives. I pushed a patch using this new convention: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=dafa0848da11260e9510c699e7060171336cb550 While the UR

Re: [HACKERS] Mail thread references in commits

On Mon, Nov 21, 2016 at 11:04 AM, Magnus Hagander wrote: > On Sun, Nov 20, 2016 at 11:02 PM, Andrew Dunstan > wrote: > >> >> >> On 11/20/2016 11:34 AM, Magnus Hagander wrote: >> >>> >>> >>> >>> I'm prepared to go along with this if there's general agreement. >>> However, maybe we should

Re: [HACKERS] Mail thread references in commits

On Sun, Nov 20, 2016 at 11:02 PM, Andrew Dunstan wrote: > > > On 11/20/2016 11:34 AM, Magnus Hagander wrote: > >> >> >> >> I'm prepared to go along with this if there's general agreement. >> However, maybe we should make it actually work first, because I >> get a 404 from >> >> ht

Re: [HACKERS] Mail thread references in commits

On 11/19/2016 06:38 PM, Tom Lane wrote: Andrew Dunstan writes: Every proposal along these lines strikes me as making more unobvious hoops for people to jump through. We're just reinventing the wheel here because we don't like the color of the standard wheels that some email MUAs produce. Yeah

Re: [HACKERS] Mail thread references in commits

On 11/20/2016 11:34 AM, Magnus Hagander wrote: I'm prepared to go along with this if there's general agreement. However, maybe we should make it actually work first, because I get a 404 from http://postgr.es/m/29df5b73-d823-ade4-cb17-47142742a...@dunslane.net

Re: [HACKERS] Mail thread references in commits

On 11/20/2016 03:59 PM, Andrew Dunstan wrote: > > On 11/20/2016 06:55 AM, Magnus Hagander wrote: >> >> We can replace the website part with a http://postgr.es/m/ >> which will make it a bit shorter and still as easy to generate from >> the client side and to search off. It'd be trivial to do, and

Re: [HACKERS] Mail thread references in commits

On Sun, Nov 20, 2016 at 5:26 PM, Tom Lane wrote: > Andrew Dunstan writes: > > On 11/20/2016 06:55 AM, Magnus Hagander wrote: > >> We can replace the website part with a http://postgr.es/m/ > >> which will make it a bit shorter and still as easy to generate from > >> the client side and to search

Re: [HACKERS] Mail thread references in commits

Andrew Dunstan writes: > On 11/20/2016 06:55 AM, Magnus Hagander wrote: >> We can replace the website part with a http://postgr.es/m/ >> which will make it a bit shorter and still as easy to generate from >> the client side and to search off. > That's 19 extra characters, less 2 if you remove t

Re: [HACKERS] Mail thread references in commits

On Sun, Nov 20, 2016 at 3:59 PM, Andrew Dunstan wrote: > > > On 11/20/2016 06:55 AM, Magnus Hagander wrote: > >> >> >> We can replace the website part with a http://postgr.es/m/ >> which will make it a bit shorter and still as easy to generate from the >> client side and to search off. It'd be tr

Re: [HACKERS] Mail thread references in commits

On 11/20/2016 06:55 AM, Magnus Hagander wrote: We can replace the website part with a http://postgr.es/m/ which will make it a bit shorter and still as easy to generate from the client side and to search off. It'd be trivial to do, and since there is no state held at the forwarder for it,

Re: [HACKERS] Mail thread references in commits

On Sat, Nov 19, 2016 at 5:38 PM, Tom Lane wrote: > Andrew Dunstan writes: > > On 11/19/2016 10:11 AM, Stephen Frost wrote: > >> That's actually not the case if we use a hash, because the client could > >> figure out what the hash is before sending it. > > > The fact that it could possibly be don

Re: [HACKERS] Mail thread references in commits

My solution requires that everything have an issue. E.g., hackers becomes a tracker. Sincerely, Jd On Nov 19, 2016 09:04, "Tom Lane" wrote: > "Joshua D. Drake" writes: > > I wonder if now is the time (again) to consider an issue tracker. > > That would make the problem at hand worse, not bett

Re: [HACKERS] Mail thread references in commits

"Joshua D. Drake" writes: > I wonder if now is the time (again) to consider an issue tracker. That would make the problem at hand worse, not better, because you'd get nothing at all for cases that were too trivial to make an issue tracker entry for, or that the committer couldn't be bothered to g

Re: [HACKERS] Mail thread references in commits

Andrew Dunstan writes: > On 11/19/2016 10:11 AM, Stephen Frost wrote: >> That's actually not the case if we use a hash, because the client could >> figure out what the hash is before sending it. > The fact that it could possibly be done is not a good reason for doing > it. Quite. I will *not*

Re: [HACKERS] Mail thread references in commits

On 11/17/2016 01:02 PM, Andrew Dunstan wrote: I love seeing references to email threads in commit messages. It would make them a lot friendlier though if a full http URL were included instead of just a Message-ID, i.e. instead of put . I kno

Re: [HACKERS] Mail thread references in commits

On 11/19/2016 10:11 AM, Stephen Frost wrote: * Magnus Hagander (mag...@hagander.net) wrote: On Nov 19, 2016 15:33, "Andrew Dunstan" wrote: I can think of at least one scenario where you might not easily have access to any invented ID - you're the author and you have mailing list me-too turn

Re: [HACKERS] Mail thread references in commits

* Magnus Hagander (mag...@hagander.net) wrote: > On Nov 19, 2016 15:33, "Andrew Dunstan" wrote: > > I can think of at least one scenario where you might not easily have > access to any invented ID - you're the author and you have mailing list > me-too turned off, so you don't have anything that th

Re: [HACKERS] Mail thread references in commits

On Nov 19, 2016 15:33, "Andrew Dunstan" wrote: > > > > On 11/19/2016 07:36 AM, Stephen Frost wrote: >> >> Magnus, >> >> * Magnus Hagander (mag...@hagander.net) wrote: >>> >>> On Sat, Nov 19, 2016 at 1:07 AM, Stephen Frost wrote: * Magnus Hagander (mag...@hagander.net) wrote: > >

Re: [HACKERS] Mail thread references in commits

On 11/19/2016 07:36 AM, Stephen Frost wrote: Magnus, * Magnus Hagander (mag...@hagander.net) wrote: On Sat, Nov 19, 2016 at 1:07 AM, Stephen Frost wrote: * Magnus Hagander (mag...@hagander.net) wrote: It would make the URLs actually short, but as mentioned upthread, that wouldn't work at a

Re: [HACKERS] Mail thread references in commits

Magnus, * Magnus Hagander (mag...@hagander.net) wrote: > On Sat, Nov 19, 2016 at 1:07 AM, Stephen Frost wrote: > > * Magnus Hagander (mag...@hagander.net) wrote: > > > It would make the URLs actually short, but as mentioned upthread, that > > > wouldn't work at all if offline. So it'd be a tradeo

Re: [HACKERS] Mail thread references in commits

On Sat, Nov 19, 2016 at 1:07 AM, Stephen Frost wrote: > Magnus, > > * Magnus Hagander (mag...@hagander.net) wrote: > > It would make the URLs actually short, but as mentioned upthread, that > > wouldn't work at all if offline. So it'd be a tradeoff between those, but > > so are pretty much all ot

Re: [HACKERS] Mail thread references in commits

On 11/18/2016 09:05 PM, Andres Freund wrote: On November 18, 2016 1:06:18 PM PST, Tom Lane wrote: I think it's important to have the message-ID in cleartext. I do ask of that offline or at least locally. So I won't use something that makes that uncomfortable. I agree. My original propo

Re: [HACKERS] Mail thread references in commits

On Fri, Nov 18, 2016 at 6:05 PM, Andres Freund wrote: > I do ask of that offline or at least locally. So I won't use something that > makes that uncomfortable. No committer here. But I do search for mails using the discussion ID present in the log message by querying in my local mail box copy on

Re: [HACKERS] Mail thread references in commits

On November 18, 2016 1:06:18 PM PST, Tom Lane wrote: >Robert Haas writes: >> On Thu, Nov 17, 2016 at 10:43 PM, Joshua Drake >wrote: >>> Why not hash the URL? Something like: >>> Http://postgresopen.org/archive/743257890976432 > >> I suggested that upthread... > >Don't like the hashing idea bec

Re: [HACKERS] Mail thread references in commits

On 11/18/2016 07:07 PM, Stephen Frost wrote: Magnus, * Magnus Hagander (mag...@hagander.net) wrote: It would make the URLs actually short, but as mentioned upthread, that wouldn't work at all if offline. So it'd be a tradeoff between those, but so are pretty much all other options that don't

Re: [HACKERS] Mail thread references in commits

On 11/18/16 4:35 PM, Magnus Hagander wrote: Another option would be to teach the URL shortener about our messages specifically, and just use an internal surrogate key we already have for them. That way it could be something like the current Planet URLs (which can be for example http://postgr.es/p

Re: [HACKERS] Mail thread references in commits

Magnus, * Magnus Hagander (mag...@hagander.net) wrote: > It would make the URLs actually short, but as mentioned upthread, that > wouldn't work at all if offline. So it'd be a tradeoff between those, but > so are pretty much all other options that don't include the full message-id. This is a bit

Re: [HACKERS] Mail thread references in commits

On Fri, Nov 18, 2016 at 11:08 PM, Alvaro Herrera wrote: > Tom Lane wrote: > > > AFAICS the proposal here is to go from, eg, > > > > Discussion: whht8...@mail.gmail.com> > > > > to > > > > Discussion: https://www.postgresql.org/message-id/CAF4Au4w6rrH_ > j1bvvhzposrihcog7sgj3lsx0ty8zdwhht8...@mai

Re: [HACKERS] Mail thread references in commits

Tom Lane wrote: > AFAICS the proposal here is to go from, eg, > > Discussion: > > > to > > Discussion: > https://www.postgresql.org/message-id/caf4au4w6rrh_j1bvvhzposrihcog7sgj3lsx0ty8zdwhht8...@mail.gmail.com > > which is annoying, but the line was overlength already. Maybe we could > dro

Re: [HACKERS] Mail thread references in commits

Robert Haas writes: > On Thu, Nov 17, 2016 at 10:43 PM, Joshua Drake wrote: >> Why not hash the URL? Something like: >> Http://postgresopen.org/archive/743257890976432 > I suggested that upthread... Don't like the hashing idea because that would be useless for searching, eg, one's own local mai

Re: [HACKERS] Mail thread references in commits

Sorry didn't see it. On Nov 18, 2016 12:44, "Robert Haas" wrote: > On Thu, Nov 17, 2016 at 10:43 PM, Joshua Drake > wrote: > > Why not hash the URL? Something like: > > > > Http://postgresopen.org/archive/743257890976432 > > I suggested that upthread... > > -- > Robert Haas > EnterpriseDB: http

Re: [HACKERS] Mail thread references in commits

On Thu, Nov 17, 2016 at 10:43 PM, Joshua Drake wrote: > Why not hash the URL? Something like: > > Http://postgresopen.org/archive/743257890976432 I suggested that upthread... -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers

Re: [HACKERS] Mail thread references in commits

On Fri, Nov 18, 2016 at 1:38 AM, Alvaro Herrera wrote: > Tom Lane wrote: >> Andrew Dunstan writes: >> > I love seeing references to email threads in commit messages. It would >> > make them a lot friendlier though if a full http URL were included >> > instead of just a Message-ID, >> >> I've inte

Re: [HACKERS] Mail thread references in commits

Why not hash the URL? Something like: Http://postgresopen.org/archive/743257890976432 Where the hash is derived from the message if? On Nov 17, 2016 17:40, "Alvaro Herrera" wrote: > > Tom Lane wrote: > > Andrew Dunstan writes: > > > I love seeing references to email threads in commit messages.

Re: [HACKERS] Mail thread references in commits

Tom Lane wrote: > Andrew Dunstan writes: > > I love seeing references to email threads in commit messages. It would > > make them a lot friendlier though if a full http URL were included > > instead of just a Message-ID, > > I've intentionally not done that, because it does not seem very > futu

Re: [HACKERS] Mail thread references in commits

On 11/17/2016 04:06 PM, Andres Freund wrote: On November 17, 2016 1:02:38 PM PST, Andrew Dunstan wrote: I love seeing references to email threads in commit messages. It would make them a lot friendlier though if a full http URL were included instead of just a Message-ID, i.e. instead of put

Re: [HACKERS] Mail thread references in commits

Andrew Dunstan writes: > I love seeing references to email threads in commit messages. It would > make them a lot friendlier though if a full http URL were included > instead of just a Message-ID, I've intentionally not done that, because it does not seem very future-proof. The message ids wil

Re: [HACKERS] Mail thread references in commits

Robert Haas wrote: > On Thu, Nov 17, 2016 at 4:06 PM, Andres Freund wrote: > > On November 17, 2016 1:02:38 PM PST, Andrew Dunstan > > wrote: > >>I love seeing references to email threads in commit messages. It would > >>make them a lot friendlier though if a full http URL were included > >>inst

Re: [HACKERS] Mail thread references in commits

Andrew Dunstan wrote: > I love seeing references to email threads in commit messages. It would make > them a lot friendlier though if a full http URL were included instead of > just a Message-ID, i.e. instead of put > . I know this is a > bit

Re: [HACKERS] Mail thread references in commits

On Thu, Nov 17, 2016 at 4:06 PM, Andres Freund wrote: > On November 17, 2016 1:02:38 PM PST, Andrew Dunstan > wrote: >>I love seeing references to email threads in commit messages. It would >>make them a lot friendlier though if a full http URL were included >>instead of just a Message-ID, i.e.

[HACKERS] Mail thread references in commits

I love seeing references to email threads in commit messages. It would make them a lot friendlier though if a full http URL were included instead of just a Message-ID, i.e. instead of put . I know this is a bit more trouble. but not that m

Re: [HACKERS] Mail thread references in commits

On November 17, 2016 1:02:38 PM PST, Andrew Dunstan wrote: >I love seeing references to email threads in commit messages. It would >make them a lot friendlier though if a full http URL were included >instead of just a Message-ID, i.e. instead of put >