[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-12 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. IMPALA-6643: Add REFRESH fine-grained privilege With this patch,

[Impala-ASF-CR] Removing (broken) retries from split-hbase.sh.

2018-03-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9588 ) Change subject: Removing (broken) retries from split-hbase.sh. .. Patch Set 1:

[Impala-ASF-CR] Removing (broken) retries from split-hbase.sh.

2018-03-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9588 Change subject: Removing (broken) retries from split-hbase.sh. .. Removing (broken) retries from split-hbase.sh. The retries in

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-12 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. Patch Set 2: (8 comments)

[Impala-ASF-CR] :IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0

2018-03-12 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Tianyi Wang, John Russell, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9540 to look at the new patch set (#3). Change subject: :IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. Patch Set 2: This failure was a Kudu side issue tracked and fixed in

[Impala-ASF-CR] IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT

2018-03-12 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9030 ) Change subject: IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

2018-03-12 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 ) Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution .. Patch Set 3:

[Impala-ASF-CR] IMPALA-6638: Reduce file handle cache lock contention

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9576 ) Change subject: IMPALA-6638: Reduce file handle cache lock contention .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6638: Reduce file handle cache lock contention

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9576 ) Change subject: IMPALA-6638: Reduce file handle cache lock contention .. IMPALA-6638: Reduce file handle cache lock

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6610: Add inspection and warning for LDAP password in Impala shell when authentication fails

2018-03-12 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Add inspection and warning for LDAP password in Impala shell when authentication fails .. Patch Set 9: (3

[Impala-ASF-CR] IMPALA-6610: Add inspection and warning for LDAP password in Impala shell when authentication fails

2018-03-12 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Add inspection and warning for LDAP password in Impala shell when authentication fails .. Patch Set 9:

[Impala-ASF-CR] IMPALA-6610: Add inspection and warning for LDAP password in Impala shell when authentication fails

2018-03-12 Thread Donghui Xu (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9506 to look at the new patch set (#9). Change subject: IMPALA-6610: Add inspection and warning for LDAP password in Impala shell when authentication fails

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. IMPALA-6576: Add metrics for data

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 1: > Do any of those benchmarks verify compile time performance? The

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 10: I need to take another pass

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 17: Code-Review+1 Did anyone else want to take a

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9395 ) Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9395 ) Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. IMPALA-6341, IMPALA-5917:

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-12 Thread Vincent Tran (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#17). Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 5: (3 comments) Thanks for the new patchset. I need to

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-12 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 16: (4 comments) Changed the name of the e2e

[Impala-ASF-CR] IMPALA-6589: remove invalid DCHECK in parquet reader

2018-03-12 Thread Tim Armstrong (Code Review)
Hello Pranay Singh, Lars Volker, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9556 to look at the new patch set (#3). Change subject: IMPALA-6589: remove invalid DCHECK in parquet reader

[Impala-ASF-CR] IMPALA-6589: remove invalid DCHECK in parquet reader

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9556 ) Change subject: IMPALA-6589: remove invalid DCHECK in parquet reader .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 16: (1 comment)

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. IMPALA-6405: Error when string to decimal cast

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-12 Thread Lars Volker (Code Review)
Hello Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9530 to look at the new patch set (#2). Change subject: IMPALA-6405: Error when string to decimal cast overflows

[Impala-ASF-CR] IMPALA-6638: Reduce file handle cache lock contention

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9576 ) Change subject: IMPALA-6638: Reduce file handle cache lock contention .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-12 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9134 to look at the new patch set (#5). Change subject: IMPALA-5717: Support for reading ORC data files ..

[Impala-ASF-CR] IMPALA-6638: Reduce file handle cache lock contention

2018-03-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9576 ) Change subject: IMPALA-6638: Reduce file handle cache lock contention .. Patch Set 4: Code-Review+2 Rebase, carry +2 -- To view,

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-12 Thread Zach Amsden (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9525 to look at the new patch set (#2). Change subject: IMPALA-6389: Make '\0' delimited text files work ..

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. IMPALA-6609: Fix ownership of

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 5: I wasn't happy with the metric naming, I

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 3: (1

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9562 to look at the new patch set (#5). Change subject: IMPALA-6576: Add metrics for data stream service memory usage

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 3: (1 comment) Please

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 3: > (1 comment)

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-12 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9590 to look at the new patch set (#3). Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail.

[Impala-ASF-CR] IMPALA-6638: Reduce file handle cache lock contention

2018-03-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9576 ) Change subject: IMPALA-6638: Reduce file handle cache lock contention .. Patch Set 3: Code-Review+2 Thanks, the new comments make it

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 2: (1

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-12 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9590 to look at the new patch set (#2). Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail.

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9590 Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. IMPALA-6498:

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-12 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9589 Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. IMPALA-6643: Add REFRESH fine-grained privilege With this patch,

[Impala-ASF-CR] IMPALA-3040: add logging to test caching ddl

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9579 ) Change subject: IMPALA-3040: add logging to test_caching_ddl .. IMPALA-3040: add logging to test_caching_ddl We don't

[Impala-ASF-CR] IMPALA-3040: add logging to test caching ddl

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9579 ) Change subject: IMPALA-3040: add logging to test_caching_ddl .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6638: Reduce file handle cache lock contention

2018-03-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9576 ) Change subject: IMPALA-6638: Reduce file handle cache lock contention .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-6638: Reduce file handle cache lock contention

2018-03-12 Thread Joe McDonnell (Code Review)
Hello Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9576 to look at the new patch set (#3). Change subject: IMPALA-6638: Reduce file handle cache lock contention

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 16: I started a dry run of the merge just in

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 16: (5 comments) I think this should be the

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9395 ) Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-03-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9395 ) Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6621: Improve set lookup performance for in-predicate evaluation

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9570 ) Change subject: IMPALA-6621: Improve set lookup performance for in-predicate evaluation .. Patch Set 1: (1 comment) Out of

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 1: Do any of those benchmarks verify compile time performance? -- To

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 4: Code-Review+1 Thanks for the reviews. PS4

[Impala-ASF-CR] IMPALA-6638: Reduce file handle cache lock contention

2018-03-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9576 ) Change subject: IMPALA-6638: Reduce file handle cache lock contention .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-03-12 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. IMPALA-6479: Update DESCRIBE to respect column privileges

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-03-12 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 1: (22 comments) Changes applied.

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-12 Thread Grant Henke (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9578 to look at the new patch set (#2). Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates ..

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9584 Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. IMPALA-5980: Upgrade to LLVM 5.0.1 Highlighting a few changes in LLVM: - Minor

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

2018-03-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 ) Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution .. Patch Set 1: (1

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

2018-03-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Alex Rodoni, John Russell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9211 to look at the new patch set (#2). Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6638: Reduce file handle cache lock contention

2018-03-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9576 ) Change subject: IMPALA-6638: Reduce file handle cache lock contention .. Patch Set 2: Code-Review+1 (3 comments) Thanks for the

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 3: Code-Review+1 (1 comment) Feel free to

[Impala-ASF-CR] IMPALA-6610: Impala shell fetches the value of ldap password cmd incorrectly

2018-03-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 ) Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly .. Patch Set 8: (3 comments)

[Impala-ASF-CR] IMPALA-3040: add logging to test caching ddl

2018-03-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9579 ) Change subject: IMPALA-3040: add logging to test_caching_ddl .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-3040: add logging to test caching ddl

2018-03-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9579 ) Change subject: IMPALA-3040: add logging to test_caching_ddl .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3040: add logging to test caching ddl

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9579 Change subject: IMPALA-3040: add logging to test_caching_ddl .. IMPALA-3040: add logging to test_caching_ddl We don't currently have

[Impala-ASF-CR] IMPALA-6638: Reduce file handle cache lock contention

2018-03-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9576 ) Change subject: IMPALA-6638: Reduce file handle cache lock contention .. Patch Set 1: (1 comment) > (1 comment) > > This change can

[Impala-ASF-CR] IMPALA-6638: Reduce file handle cache lock contention

2018-03-12 Thread Joe McDonnell (Code Review)
Hello Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9576 to look at the new patch set (#2). Change subject: IMPALA-6638: Reduce file handle cache lock contention ..

[Impala-ASF-CR] IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL

2018-03-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9484 ) Change subject: IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL .. Patch Set 4: Added a dependency on a patch for IMPALA-6635

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL

2018-03-12 Thread Grant Henke (Code Review)
Hello Thomas Tauber-Marshall, Dimitris Tsirogiannis, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9484 to look at the new patch set (#4). Change subject: IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. Patch Set 1: Started

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-12 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9578 Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. IMPALA-6635: Add DECIMAL type to Kudu predicates Change-Id:

[Impala-ASF-CR] IMPALA-6638: Reduce file handle cache lock contention

2018-03-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9576 ) Change subject: IMPALA-6638: Reduce file handle cache lock contention .. Patch Set 1: (1 comment) This change can increase the

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 8: (16 comments) Thanks for taking a look,

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-12 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#8). Change subject: IMPALA-3866: Improve error reporting for scratch write errors

  1   2   >