[Impala-ASF-CR] Remove references to the $IMPALA HOME/thirdparty directory

2019-04-23 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13092 ) Change subject: Remove references to the $IMPALA_HOME/thirdparty directory .. Patch Set 1: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] Fix critique-gerrit-review to ignore shell/ext-py

2019-04-23 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13093 ) Change subject: Fix critique-gerrit-review to ignore shell/ext-py .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog

2019-04-19 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 ) Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog .. Patch Set 4: Code-Review+2 (3 comments) Carry

[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog

2019-04-19 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13065 ) Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog .. IMPALA-8293 (Part 1): Move SentryProxy out of Cata

[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog

2019-04-18 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13065 ) Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog .. IMPALA-8293 (Part 1): Move SentryProxy out of Cata

[Impala-ASF-CR] IMPALA-8149 : Add support for alter database events

2019-04-18 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13049 ) Change subject: IMPALA-8149 : Add support for alter_database events .. Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog

2019-04-18 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13065 Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog .. IMPALA-8293 (Part 1): Move SentryProxy out of Cat

[Impala-ASF-CR] IMPALA-8293: Support for Ranger cache invalidation

2019-04-18 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12748 ) Change subject: IMPALA-8293: Support for Ranger cache invalidation .. Patch Set 6: I'm abandoning this CR because it contains refactor

[Impala-ASF-CR] IMPALA-8293: Support for Ranger cache invalidation

2019-04-18 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has abandoned this change. ( http://gerrit.cloudera.org:8080/12748 ) Change subject: IMPALA-8293: Support for Ranger cache invalidation .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/12748 To unsubs

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 ) Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201 .. Patch Set 11: Code-Review+1 > Patch Set 10: > > Hi Fredy, was wonderin

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/13002 ) Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201 .. IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201 This patch bumps the CDP_

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/13002 ) Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201 .. IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201 This patch bumps the CDP_

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 ) Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201 .. Patch Set 10: This is ready for review. -- To view, visit http://ger

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/13002 ) Change subject: Bump CDP_BUILD_NUMBER to 1013201 .. Bump CDP_BUILD_NUMBER to 1013201 This patch bumps the CDP_BUILD_NUMBER to 1013201. Th

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 ) Change subject: Bump CDP_BUILD_NUMBER to 1013201 .. Patch Set 8: Updated .gitignore. -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13002 ) Change subject: Bump CDP_BUILD_NUMBER to 1013201 .. Bump CDP_BUILD_NUMBER to 1013201 This patch bumps the CDP_BUILD_NUMBER to 1013201. Th

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/13002 ) Change subject: Bump CDP_BUILD_NUMBER to 1013201 .. Bump CDP_BUILD_NUMBER to 1013201 This patch bumps the CDP_BUILD_NUMBER to 1013201. Th

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 ) Change subject: Bump CDP_BUILD_NUMBER to 1013201 .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/13002/5/bin/bootstra

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13002 ) Change subject: Bump CDP_BUILD_NUMBER to 1013201 .. Bump CDP_BUILD_NUMBER to 1013201 This patch bumps the CDP_BUILD_NUMBER to 1013201. Th

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 ) Change subject: Bump CDP_BUILD_NUMBER to 1013201 .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/13002/3/bin/bootstra

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13002 ) Change subject: Bump CDP_BUILD_NUMBER to 1013201 .. Bump CDP_BUILD_NUMBER to 1013201 This patch bumps the CDP_BUILD_NUMBER to 1013201. Th

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. IMPALA-8363: Deny access when colum

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 8: Code-Review+2 Rebas

[Impala-ASF-CR] WIP: Bump CDP BUILD NUMBER to 1020239

2019-04-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13002 Change subject: WIP: Bump CDP_BUILD_NUMBER to 1020239 .. WIP: Bump CDP_BUILD_NUMBER to 1020239 This patch bumps the CDP_BUILD_NUMBER to

[Impala-ASF-CR] WIP: Bump CDP BUILD NUMBER to 1020239

2019-04-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 ) Change subject: WIP: Bump CDP_BUILD_NUMBER to 1020239 .. Patch Set 2: WIP. The build 1020239 is broken. -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 7: (4 comments) http:

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. IMPALA-8363: Deny access when colum

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. IMPALA-6718: Add support for column-level permissions on

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. Patch Set 5: (3 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. IMPALA-6718: Add support for column-level permissions on

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5

2019-04-12 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5 .. Patch Set 6: Code-Review+1 (1 comment) LGTM http://gerrit

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 2: (6 comments) Thanks for the patch! http://g

[Impala-ASF-CR] IMPALA-8363: Fix E2E start with impala log dir

2019-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: Fix E2E start with impala_log_dir .. Patch Set 2: Thanks for the fix. -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-8363: Fix E2E start with impala log dir

2019-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: Fix E2E start with impala_log_dir .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12989 ) Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. IMPALA-8365: Add test coverage for

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 ) Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. Patch Set 3: Code-Review+2 Carr

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 ) Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. Patch Set 3: (1 comment) http:

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12989 ) Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. IMPALA-8365: Add test coverage for

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12989 Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. IMPALA-8365: Add test coverage fo

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. Patch Set 6: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. Patch Set 7: Code-Review+2 (2 comments) Carry Bharath's +2. http://g

[Impala-ASF-CR] [IMPALA-8227] Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: [IMPALA-8227] Add support for WITH GRANT OPTION with Ranger .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. IMPALA-8385: Refactor Sentry admin user check This patch moves the hardc

[Impala-ASF-CR] This change bumps the CDH BUILD VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed for t

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12965 ) Change subject: This change bumps the CDH_BUILD_VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed for the u

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/12963/5/

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. IMPALA-8385: Refactor Sentry admin user check This patch moves the hardc

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 6: (7 comments) The n

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. IMPALA-8363: Deny access when colum

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. IMPALA-8385: Refactor Sentry admin user check This patch moves the hardc

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12963 Change subject: IMPALA-8385: Refactor Sentry admin user check .. IMPALA-8385: Refactor Sentry admin user check This patch moves the hard

[Impala-ASF-CR] Add impala group.json to .gitignore

2019-04-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12964 Change subject: Add impala_group.json to .gitignore .. Add impala_group.json to .gitignore This patch adds ranger/setup/impala_group.jso

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. IMPALA-6718: Add support for column-level permissions on

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12959 Change subject: IMPALA-6718: Add support for column-level permissions on views .. IMPALA-6718: Add support for column-level permissions o

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 4: (1 comment) http:/

[Impala-ASF-CR] IMPALA-8393: Skip ranger setup for unsupported environments

2019-04-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12957 ) Change subject: IMPALA-8393: Skip ranger setup for unsupported environments .. Patch Set 6: Code-Review+2 Thanks for the fix. -- To v

[Impala-ASF-CR] IMPALA-8393: setup-ranger in create-load-data.sh breaks for clusters

2019-04-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12957 ) Change subject: IMPALA-8393: setup-ranger in create-load-data.sh breaks for clusters .. Patch Set 2: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 4: (1 comment) http:/

[Impala-ASF-CR] IMPALA-8363: fix e2e start with impala log dir

2019-04-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: fix e2e start with impala_log_dir .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12935/1

[Impala-ASF-CR] IMPALA-8363: fix e2e start with impala log dir

2019-04-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: fix e2e start with impala_log_dir .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12935/

[Impala-ASF-CR] IMPALA-8363: fix e2e start with impala log dir

2019-04-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: fix e2e start with impala_log_dir .. Patch Set 1: Just couple nits. LGTM. -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 4: Bharath, this is re

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. IMPALA-8363: Deny access when colum

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 3: (4 comments) http:

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. IMPALA-8363: Deny access when colum

[Impala-ASF-CR] IMPALA-8226: Add grant/revoke to/from group for Ranger

2019-04-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12914 ) Change subject: IMPALA-8226: Add grant/revoke to/from group for Ranger .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12930/2

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. IMPALA-8363: Deny access when colum

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12927 Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. IMPALA-8363: Deny access when colu

[Impala-ASF-CR] IMPALA-8226: Add grant/revoke to/from group for Ranger

2019-04-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12914 ) Change subject: IMPALA-8226: Add grant/revoke to/from group for Ranger .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-8226: Add grant/revoke to/from group for Ranger

2019-04-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12914 ) Change subject: IMPALA-8226: Add grant/revoke to/from group for Ranger .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] Bump Postgres JDBC driver version to 9.4, update connection strings

2019-04-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: Bump Postgres JDBC driver version to 9.4, update connection strings .. Patch Set 1: (4 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8226: Add grant/revoke to/from group for Ranger

2019-04-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12914 ) Change subject: IMPALA-8226: Add grant/revoke to/from group for Ranger .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-8226: Add grant/revoke to/from group for Ranger

2019-04-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12914 ) Change subject: IMPALA-8226: Add grant/revoke to/from group for Ranger .. Patch Set 3: (2 comments) Can you add tests in ParserTest an

[Impala-ASF-CR] IMPALA-8312 : Alter database operations have race condition

2019-03-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12789 ) Change subject: IMPALA-8312 : Alter database operations have race condition .. Patch Set 10: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-8312 : Alter database operations have race condition

2019-03-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12789 ) Change subject: IMPALA-8312 : Alter database operations have race condition .. Patch Set 9: (1 comment) Just a nit for constants. I'm

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should support flag names

2019-03-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should support flag names .. Patch Set 7: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8368: Fix exception thrown by create database/table with Ranger enabled

2019-03-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12878 ) Change subject: IMPALA-8368: Fix exception thrown by create database/table with Ranger enabled .. Patch Set 3: Code-Review+2 -- To vi

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should support flag names

2019-03-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should support flag names .. IMPALA-8330: Impala shell config file should support fl

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should support flag names

2019-03-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should support flag names .. Patch Set 7: Code-Review+1 (2 comments) Carry +1 fr

[Impala-ASF-CR] IMPALA-8368: Fix exception thrown by create database or create table with Ranger enabled

2019-03-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12878 ) Change subject: IMPALA-8368: Fix exception thrown by create database or create table with Ranger enabled .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-8368: Fix exception thrown by create database with Ranger enabled

2019-03-28 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12878 ) Change subject: IMPALA-8368: Fix exception thrown by create database with Ranger enabled .. Patch Set 1: (2 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-8293: Support for Ranger cache invalidation

2019-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12748 ) Change subject: IMPALA-8293: Support for Ranger cache invalidation .. IMPALA-8293: Support for Ranger cache invalidation This patch adds

[Impala-ASF-CR] IMPALA-8293: Support for Ranger cache invalidation

2019-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12748 ) Change subject: IMPALA-8293: Support for Ranger cache invalidation .. Patch Set 5: Todd/Bharath, this is ready for review. -- To view

[Impala-ASF-CR] IMPALA-8293: Support for Ranger cache invalidation

2019-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12748 ) Change subject: IMPALA-8293: Support for Ranger cache invalidation .. IMPALA-8293: Support for Ranger cache invalidation This patch adds

[Impala-ASF-CR] IMPALA-8345 : Add option to set up minicluster to use Hive 3

2019-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12846 ) Change subject: IMPALA-8345 : Add option to set up minicluster to use Hive 3 .. Patch Set 10: Code-Review+2 (1 comment) I saw few +1s

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should support flag names

2019-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should support flag names .. Patch Set 6: Updated the CR to no longer be a breaki

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should support flag names

2019-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should support flag names .. IMPALA-8330: Impala shell config file should support fl

[Impala-ASF-CR] IMPALA-8225: Add Ranger support for grant/revoke privilege to/from user

2019-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12769 ) Change subject: IMPALA-8225: Add Ranger support for grant/revoke privilege to/from user .. Patch Set 10: Code-Review+2 Thanks for all

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-8225: Add Ranger support for grant/revoke privilege to/from user

2019-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12769 ) Change subject: IMPALA-8225: Add Ranger support for grant/revoke privilege to/from user .. Patch Set 8: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-8345 : Add option to set up minicluster to use Hive 3

2019-03-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12846 ) Change subject: IMPALA-8345 : Add option to set up minicluster to use Hive 3 .. Patch Set 9: (5 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-8225: Add Ranger support for grant/revoke privilege to/from user

2019-03-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12769 ) Change subject: IMPALA-8225: Add Ranger support for grant/revoke privilege to/from user .. Patch Set 6: (4 comments) Mostly nits. LGT

[Impala-ASF-CR] IMPALA-8225: Add Ranger support for grant/revoke privilege to/from user

2019-03-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12769 ) Change subject: IMPALA-8225: Add Ranger support for grant/revoke privilege to/from user .. Patch Set 5: (18 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog

2019-03-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12859 ) Change subject: IMPALA-8362: Increase authorization test coverage with local catalog .. Patch Set 3: Code-Review+2 (4 comments) Carry

[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog

2019-03-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12859 ) Change subject: IMPALA-8362: Increase authorization test coverage with local catalog .. IMPALA-8362: Increase authorization test coverage

[Impala-ASF-CR] IMPALA-8362: Increase authorization test coverage with local catalog

2019-03-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12859 Change subject: IMPALA-8362: Increase authorization test coverage with local catalog .. IMPALA-8362: Increase authorization test coverag

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:80

<    1   2   3   4   5   6   7   8   9   10   >