[Impala-ASF-CR] IMPALA-11203: Fix build by re-adding imports removed in clashing commits

2022-03-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has abandoned this change. ( http://gerrit.cloudera.org:8080/18357 ) Change subject: IMPALA-11203: Fix build by re-adding imports removed in clashing commits .. Abandoned Duplicates https://gerrit.cloudera.org/

[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client

2022-03-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 ) Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client .. Patch Set 7: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-111218: TestIcebergTable.test table load time for many files flaky

2022-04-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18376 ) Change subject: IMPALA-111218: TestIcebergTable.test_table_load_time_for_many_files flaky .. Patch Set 1: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-11341: Print error log files when data-loading fails

2022-06-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18597 ) Change subject: IMPALA-11341: Print error log files when data-loading fails .. Patch Set 1: Code-Review+2 LGTM -- To view, visit ht

[Impala-ASF-CR] IMPALA-11330: Add test for missing iceberg metadata directory.

2022-08-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18818 Change subject: IMPALA-11330: Add test for missing iceberg metadata directory. .. IMPALA-11330: Add test for missing iceberg metadata d

[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality

2022-08-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 ) Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality .. Patch Set 1: (3 comments) Quick comments... http://

[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality

2022-08-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 ) Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality .. Patch Set 2: Code-Review+2 (1 comment) Doc is very c

[Impala-ASF-CR] IMPALA-9999: Switch to GCC 10.4

2022-09-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18134 ) Change subject: IMPALA-: Switch to GCC 10.4 .. Patch Set 14: Code-Review+1 LGTM -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-9999: Switch to GCC 10.4

2022-09-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18134 ) Change subject: IMPALA-: Switch to GCC 10.4 .. Patch Set 14: Code-Review+2 +2 based on addressing Csaba's comments -- To view,

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19002 Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. IMPALA-11482: Alter Table Execute Rollback for Iceber

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-17 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19002 to look at the new patch set (#4). Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tabl

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-17 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19002 to look at the new patch set (#5). Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tabl

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. IMPALA-11482: Alter Table Execute Rollback for Iceberg

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. IMPALA-11482: Alter Table Execute Rollback for Iceberg

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. Patch Set 6: (7 comments) Thanks for the review co

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-10-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. IMPALA-11482: Alter Table Execute Rollback for Iceberg

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-10-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. Patch Set 8: (7 comments) Thank for the useful com

[Impala-ASF-CR] IMPALA-11304: impala-shell make the client retry attempts configurable

2022-10-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19105 ) Change subject: IMPALA-11304: impala-shell make the client retry attempts configurable .. Patch Set 5: (3 comments) This looks good

[Impala-ASF-CR] IMPALA-11304: impala-shell make the client retry attempts configurable

2022-10-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19105 ) Change subject: IMPALA-11304: impala-shell make the client retry attempts configurable .. Patch Set 6: Code-Review+2 LGTM -- To vi

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 7: (4 comments) A few nits http://gerrit.clo

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-11-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 8: Code-Review+2 LGTM (I think all other revie

[Impala-ASF-CR] IMPALA-11726 Make impala-shell work with kerberos authentication

2022-11-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19248 ) Change subject: IMPALA-11726 Make impala-shell work with kerberos authentication .. Patch Set 3: (3 comments) Quick comments http:/

[Impala-ASF-CR] IMPALA-11901: Support COPY TESTCASE in local catalog mode

2023-07-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20110 ) Change subject: IMPALA-11901: Support COPY TESTCASE in local catalog mode .. Patch Set 4: (7 comments) Looks good, I have a few smal

[Impala-ASF-CR] IMPALA-12326: Add WaitForLocalServer in StatestoreSubscriber::Start

2023-08-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20297 ) Change subject: IMPALA-12326: Add WaitForLocalServer in StatestoreSubscriber::Start .. Patch Set 2: Code-Review+2 LGTM -- To view,

[Impala-ASF-CR] IMPALA-11901: Support COPY TESTCASE in local catalog mode

2023-08-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20110 ) Change subject: IMPALA-11901: Support COPY TESTCASE in local catalog mode .. Patch Set 5: Code-Review+2 Thanks for the change, LGTM

[Impala-ASF-CR] IMPALA-12228: Simulate the failure of an iceberg transaction.

2023-08-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20306 Change subject: IMPALA-12228: Simulate the failure of an iceberg transaction. .. IMPALA-12228: Simulate the failure of an iceberg trans

[Impala-ASF-CR] IMPALA-12332: Undo IMPALA-8615 as the corresponding configs have been removed

2023-08-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20308 Change subject: IMPALA-12332: Undo IMPALA-8615 as the corresponding configs have been removed .. IMPALA-12332: Undo IMPALA-8615 as the

[Impala-ASF-CR] IMPALA-12340: Fix flaky test two catalogd with force active

2023-08-08 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20323 ) Change subject: IMPALA-12340: Fix flaky test_two_catalogd_with_force_active .. Patch Set 2: Code-Review+2 LGTM -- To view, visit ht

[Impala-ASF-CR] [docs] Add note about REFRESH for tables in custom catalog

2023-08-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20328 ) Change subject: [docs] Add note about REFRESH for tables in custom catalog .. Patch Set 1: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-12335: [DOCS] Add documentation about the DELETE statement

2023-08-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20361 ) Change subject: IMPALA-12335: [DOCS] Add documentation about the DELETE statement .. Patch Set 1: (1 comment) Read through once, lo

[Impala-ASF-CR] IMPALA-12335: [DOCS] Add documentation about the DELETE statement

2023-08-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20361 ) Change subject: IMPALA-12335: [DOCS] Add documentation about the DELETE statement .. Patch Set 2: Code-Review+2 (1 comment) LGTM h

[Impala-ASF-CR] IMPALA-12228: Simulate the failure of an iceberg transaction.

2023-08-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20306 ) Change subject: IMPALA-12228: Simulate the failure of an iceberg transaction. .. Patch Set 1: (1 comment) Thanks for the review htt

[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy

2023-08-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20419 ) Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy .. Patch Set 1: Code-Revi

[Impala-ASF-CR] IMPALA-12411: Fix data race in expr-test teardown

2023-09-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20474 ) Change subject: IMPALA-12411: Fix data race in expr-test teardown .. Patch Set 3: Code-Review+2 LGTM, thanks for finding this -- To

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 1: (3 comments) I read through and this looks like an

[Impala-ASF-CR] IMPALA-12318: Add a flag option for http spnego dedicated keytab file.

2023-09-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20269 ) Change subject: IMPALA-12318: Add a flag option for http spnego dedicated keytab file. .. Patch Set 10: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 2: Code-Review+1 LGTM, can give +2, waiting to see if

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 3: Code-Review+2 LGTM now Noemi and Peter have given +

[Impala-ASF-CR] IMPALA-12477: Make Iceberg planFiles() use multiple threads

2023-09-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20523 ) Change subject: IMPALA-12477: Make Iceberg planFiles() use multiple threads .. Patch Set 3: (2 comments) I read through quickly htt

[Impala-ASF-CR] IMPALA-12477: Make Iceberg planFiles() use multiple threads

2023-09-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20523 ) Change subject: IMPALA-12477: Make Iceberg planFiles() use multiple threads .. Patch Set 4: Code-Review+1 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-11-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 1: (11 comments) I read through once a

[Impala-ASF-CR] IMPALA-12552: Fix Kerberos authentication issue that occurs in python 3 environment when kerberos host fqdn option is used

2023-11-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20691 ) Change subject: IMPALA-12552: Fix Kerberos authentication issue that occurs in python 3 environment when kerberos_host_fqdn option is used

[Impala-ASF-CR] IMPALA-12579: Add logs for loading table list in catalogd startup

2023-11-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20734 ) Change subject: IMPALA-12579: Add logs for loading table list in catalogd startup .. Patch Set 1: Code-Review+2 LGTM -- To view, v

[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time

2023-11-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 ) Change subject: IMPALA-12577: Correctly update last-synced-event-time .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-12486: Add catalog metrics for metadata loading

2023-11-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20673 ) Change subject: IMPALA-12486: Add catalog metrics for metadata loading .. Patch Set 2: (6 comments) A few nits and questions only h

[Impala-ASF-CR] IMPALA-12577: Correctly update last-synced-event-time

2023-11-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20732 ) Change subject: IMPALA-12577: Correctly update last-synced-event-time .. Patch Set 3: Code-Review+2 carry forward +2 -- To view, vi

[Impala-ASF-CR] IMPALA-12486: Add catalog metrics for metadata loading

2023-11-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20673 ) Change subject: IMPALA-12486: Add catalog metrics for metadata loading .. Patch Set 6: Code-Review+2 LGTM as other reviewers have giv

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20753 ) Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg tables .. Patch Set 1: (1 comment) Read through once a

[Impala-ASF-CR] IMPALA-12426: Adds the backend InternalServer class.

2023-12-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20524 ) Change subject: IMPALA-12426: Adds the backend InternalServer class. .. Patch Set 21: (6 comments) Saving my questions at end of day

[Impala-ASF-CR] IMPALA-12426: Adds the backend InternalServer class.

2023-12-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20524 ) Change subject: IMPALA-12426: Adds the backend InternalServer class. .. Patch Set 21: (8 comments) Just some tidying up and question

[Impala-ASF-CR] IMPALA-12426: Adds the backend InternalServer class.

2023-12-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20524 ) Change subject: IMPALA-12426: Adds the backend InternalServer class. .. Patch Set 25: Code-Review+2 Thanks for all the work! -- To

[Impala-ASF-CR] IMPALA-12614: Use atomics for 64-bit host metrics

2023-12-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20776 ) Change subject: IMPALA-12614: Use atomics for 64-bit host metrics .. Patch Set 1: Code-Review+2 LGTM, thanks for the quick fix -- T

[Impala-ASF-CR](asf-site) IMPALA-12619: Update Impala website to reduce emphasis on Hadoop

2023-12-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20782 Change subject: IMPALA-12619: Update Impala website to reduce emphasis on Hadoop .. IMPALA-12619: Update Impala website to reduce empha

[Impala-ASF-CR] IMPALA-12618: Update README.md to reduce emphasis on Hadoop

2023-12-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20783 Change subject: IMPALA-12618: Update README.md to reduce emphasis on Hadoop .. IMPALA-12618: Update README.md to reduce emphasis on Had

[Impala-ASF-CR] IMPALA-12618: Update README.md to reduce emphasis on Hadoop

2023-12-13 Thread Andrew Sherman (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20783 to look at the new patch set (#2). Change subject: IMPALA-12618: Update README.md to reduce emphasis on Hadoop

[Impala-ASF-CR](asf-site) IMPALA-12619: Update Impala website to reduce emphasis on Hadoop

2023-12-13 Thread Andrew Sherman (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20782 to look at the new patch set (#3). Change subject: IMPALA-12619: Update Impala website to reduce emphasis on Hadoop ...

[Impala-ASF-CR](asf-site) IMPALA-12619: Update Impala website to reduce emphasis on Hadoop

2023-12-14 Thread Andrew Sherman (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20782 to look at the new patch set (#4). Change subject: IMPALA-12619: Update Impala website to reduce emphasis on Hadoop ...

[Impala-ASF-CR] IMPALA-12632: Use Atomics for CpuUsageRatio counters

2023-12-14 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20798 Change subject: IMPALA-12632: Use Atomics for CpuUsageRatio counters .. IMPALA-12632: Use Atomics for CpuUsageRatio counters Now that

[Impala-ASF-CR] Revert "IMPALA-11805: Fix LLVM memory manager bytes allocated"

2023-12-14 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20796 ) Change subject: Revert "IMPALA-11805: Fix LLVM memory manager bytes allocated" .. Patch Set 1: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-12632: Use Atomics for CpuUsageRatio counters

2023-12-14 Thread Andrew Sherman (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20798 to look at the new patch set (#2). Change subject: IMPALA-12632: Use Atomics for CpuUsageRatio counters

[Impala-ASF-CR] IMPALA-12629: Fix Iceberg V2 tests in non-HDFS environment

2023-12-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20803 ) Change subject: IMPALA-12629: Fix Iceberg V2 tests in non-HDFS environment .. Patch Set 1: Code-Review+2 LGTM -- To view, visit htt

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2023-12-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20818 ) Change subject: IMPALA-12653: Update documentation about the UPDATE statement .. Patch Set 2: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR](asf-site) IMPALA-12619: Update Impala website to reduce emphasis on Hadoop

2023-12-19 Thread Andrew Sherman (Code Review)
Hello Quanlong Huang, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20782 to look at the new patch set (#5). Change subject: IMPALA-12619: Update Impala website to reduce emphasis on Hadoop

[Impala-ASF-CR](asf-site) IMPALA-12619: Update Impala website to reduce emphasis on Hadoop

2023-12-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20782 ) Change subject: IMPALA-12619: Update Impala website to reduce emphasis on Hadoop .. Patch Set 4: (2 comments) Thanks for the review

[Impala-ASF-CR](asf-site) IMPALA-12619: Update Impala website to reduce emphasis on Hadoop

2023-12-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20782 ) Change subject: IMPALA-12619: Update Impala website to reduce emphasis on Hadoop .. Patch Set 5: (2 comments) Thanks Michael, so if

[Impala-ASF-CR](asf-site) IMPALA-12619: Update Impala website to reduce emphasis on Hadoop

2023-12-19 Thread Andrew Sherman (Code Review)
Hello Quanlong Huang, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20782 to look at the new patch set (#6). Change subject: IMPALA-12619: Update Impala website to reduce emphasis on Hadoop

[Impala-ASF-CR](asf-site) IMPALA-12619: Update Impala website to reduce emphasis on Hadoop

2023-12-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20782 ) Change subject: IMPALA-12619: Update Impala website to reduce emphasis on Hadoop .. Patch Set 6: Code-Review+2 -- To view, visit htt

[Impala-ASF-CR](asf-site) IMPALA-12619: Update Impala website to reduce emphasis on Hadoop

2023-12-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20782 ) Change subject: IMPALA-12619: Update Impala website to reduce emphasis on Hadoop .. IMPALA-12619: Update Impala website to red

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2023-12-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20818 ) Change subject: IMPALA-12653: Update documentation about the UPDATE statement .. Patch Set 4: (1 comment) impala_iceberg.xml looks g

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2023-12-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20818 ) Change subject: IMPALA-12653: Update documentation about the UPDATE statement .. Patch Set 6: Code-Review+1 LGTM, can give +2 but wai

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2023-12-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20818 ) Change subject: IMPALA-12653: Update documentation about the UPDATE statement .. Patch Set 6: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-12742: (Addendum) add interop tests for DATE-partitioned Iceberg tables

2024-01-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20976 ) Change subject: IMPALA-12742: (Addendum) add interop tests for DATE-partitioned Iceberg tables .. Patch Set 1: Code-Review+2 LGTM

[Impala-ASF-CR] IMPALA-12787: Concurrent DELETE and UPDATE operations on Iceberg tables can be problematic

2024-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20999 ) Change subject: IMPALA-12787: Concurrent DELETE and UPDATE operations on Iceberg tables can be problematic .. Patch Set 2: Code-Revie

[Impala-ASF-CR] IMPALA-12787: Concurrent DELETE and UPDATE operations on Iceberg tables can be problematic

2024-02-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20999 ) Change subject: IMPALA-12787: Concurrent DELETE and UPDATE operations on Iceberg tables can be problematic .. Patch Set 2: (1 commen

[Impala-ASF-CR] IMPALA-12805: Avoid problems of HIVE-27114 without configuration changes

2024-02-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21028 Change subject: IMPALA-12805: Avoid problems of HIVE-27114 without configuration changes .. IMPALA-12805: Avoid problems of HIVE-27114

[Impala-ASF-CR] IMPALA-12805: Avoid problems of HIVE-27114 without configuration changes

2024-02-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has abandoned this change. ( http://gerrit.cloudera.org:8080/21028 ) Change subject: IMPALA-12805: Avoid problems of HIVE-27114 without configuration changes .. Abandoned Abandoning as it seems that HIVE-27114

[Impala-ASF-CR] IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase

2024-02-14 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21034 Change subject: IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase .. IMPALA-12816: Remove exclusion of Netty t

[Impala-ASF-CR] IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase

2024-02-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21034 ) Change subject: IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase .. Patch Set 2: Looks like flaky IMPALA-19

[Impala-ASF-CR] IMPALA-12808: test iceberg deletes and updates failed by timeout error

2024-02-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21033 ) Change subject: IMPALA-12808: test_iceberg_deletes_and_updates failed by timeout error .. Patch Set 1: Code-Review+2 LGTM thanks for

[Impala-ASF-CR] IMPALA-12426: Adds the Impala built-in functions prettyprint duration and prettyprint memory.

2024-02-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21038 ) Change subject: IMPALA-12426: Adds the Impala built-in functions prettyprint_duration and prettyprint_memory. .. Patch Set 2: (1 com

[Impala-ASF-CR] IMPALA-12426: Adds the Impala built-in functions prettyprint duration and prettyprint memory.

2024-02-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21038 ) Change subject: IMPALA-12426: Adds the Impala built-in functions prettyprint_duration and prettyprint_memory. .. Patch Set 4: (1 com

[Impala-ASF-CR] IMPALA-12598: Allow multiple equality field id lists for Iceberg tables

2024-02-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20951 ) Change subject: IMPALA-12598: Allow multiple equality field id lists for Iceberg tables .. Patch Set 5: Code-Review+1 (1 comment) R

[Impala-ASF-CR] IMPALA-12824: Adds built-in functions prettyprint duration and prettyprint bytes.

2024-02-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21038 ) Change subject: IMPALA-12824: Adds built-in functions prettyprint_duration and prettyprint_bytes. .. Patch Set 8: Code-Review+1 (3 c

[Impala-ASF-CR] IMPALA-12824: Adds built-in functions prettyprint duration and prettyprint bytes.

2024-02-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21038 ) Change subject: IMPALA-12824: Adds built-in functions prettyprint_duration and prettyprint_bytes. .. Patch Set 9: Code-Review+2 Than

[Impala-ASF-CR] IMPALA-12838: Adds exec options parameter to single node perf run.py

2024-02-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21054 ) Change subject: IMPALA-12838: Adds exec_options parameter to single_node_perf_run.py .. Patch Set 1: Code-Review+2 LGTM -- To view

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-03-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21083 ) Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax .. Patch Set 1: (2 comments) This is a welcome addition, I

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-03-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21083 ) Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax .. Patch Set 2: (4 comments) Thanks for the restructure. A

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-03-08 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21083 ) Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax .. Patch Set 3: Code-Review+2 LGTM (though I think you shoul

[Impala-ASF-CR] IMPALA-12264: Add limit on number of HS2 sessions per user.

2024-03-08 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21128 Change subject: IMPALA-12264: Add limit on number of HS2 sessions per user. .. IMPALA-12264: Add limit on number of HS2 sessions per us

[Impala-ASF-CR] IMPALA-12264: Add limit on number of HS2 sessions per user.

2024-03-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21128 ) Change subject: IMPALA-12264: Add limit on number of HS2 sessions per user. .. Patch Set 1: CDPD-58529 / IMPALA-12264 requests that w

[Impala-ASF-CR] IMPALA-12264: Add limit on number of HS2 sessions per user.

2024-03-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21128 ) Change subject: IMPALA-12264: Add limit on number of HS2 sessions per user. .. Patch Set 2: (4 comments) Ideally we we might throttl

[Impala-ASF-CR] IMPALA-12264: Add limit on number of HS2 sessions per user.

2024-03-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21128 ) Change subject: IMPALA-12264: Add limit on number of HS2 sessions per user. .. IMPALA-12264: Add limit on number of HS2 sessions per use

[Impala-ASF-CR] IMPALA-12893: (part 1) Specify 'format-version' explicitly in Iceberg tests

2024-03-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21167 ) Change subject: IMPALA-12893: (part 1) Specify 'format-version' explicitly in Iceberg tests .. Patch Set 1: Code-Review+2 LGTM --

[Impala-ASF-CR] IMPALA-12540: Query Live Table

2024-03-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 ) Change subject: IMPALA-12540: Query Live Table .. Patch Set 41: (19 comments) All looks good, I have a few nits and questions http:

[Impala-ASF-CR] IMPALA-12626: Add Tables Queried to profile/history

2024-03-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20886 ) Change subject: IMPALA-12626: Add Tables Queried to profile/history .. Patch Set 25: (2 comments) I read through quickly http://ger

[Impala-ASF-CR] IMPALA-12264: Add limit on number of HS2 sessions per user.

2024-03-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21128 ) Change subject: IMPALA-12264: Add limit on number of HS2 sessions per user. .. IMPALA-12264: Add limit on number of HS2 sessions per use

[Impala-ASF-CR] IMPALA-12264: Add limit on number of HS2 sessions per user.

2024-03-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21128 ) Change subject: IMPALA-12264: Add limit on number of HS2 sessions per user. .. Patch Set 3: (12 comments) Thanks for the thoughtful

[Impala-ASF-CR] IMPALA-12540: Query Live Table

2024-03-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 ) Change subject: IMPALA-12540: Query Live Table .. Patch Set 44: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/20762

[Impala-ASF-CR] IMPALA-12807: Add support for mold linker

2024-03-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21121 ) Change subject: IMPALA-12807: Add support for mold linker .. Patch Set 3: Code-Review+2 LGTM Tested full builds and ran from IDE --

[Impala-ASF-CR] IMPALA-12426: Switches the duration fields to be stored in decimal seconds.

2024-03-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21203 ) Change subject: IMPALA-12426: Switches the duration fields to be stored in decimal seconds. .. Patch Set 2: (3 comments) Quick comm

<    1   2   3   4   5   6   7   >