[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16613 Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. IMPALA-10244: Make non-scalable failures to dequeue

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. IMPALA-10244: Make non-scalable failures to dequeue o

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. Patch Set 2: (3 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. IMPALA-10244: Make non-scalable failures to dequeue o

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. Patch Set 2: (2 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. Patch Set 2: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. IMPALA-10244: Make non-scalable failures to dequeue o

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. Patch Set 2: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-10303: Fix warnings from impala-shell with --quiet

2020-10-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16673 ) Change subject: IMPALA-10303: Fix warnings from impala-shell with --quiet .. Patch Set 2: Code-Review+2 LGTM -- To view, visit http

[Impala-ASF-CR] IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4

2020-11-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16700 ) Change subject: IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4 .. Patch Set 2: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell

2020-11-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16702 Change subject: IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell .. IMPALA-10309: Use sleep time from a Retry-Af

[Impala-ASF-CR] IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell

2020-11-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16702 ) Change subject: IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell .. IMPALA-10309: Use sleep time from a Retry-Aft

[Impala-ASF-CR] IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell

2020-11-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16702 ) Change subject: IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell .. IMPALA-10309: Use sleep time from a Retry-Aft

[Impala-ASF-CR] IMPALA-10249: Fix the flaky TestImpalaShell.test queries closed test.

2020-11-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16743 Change subject: IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed test. .. IMPALA-10249: Fix the flaky TestImpalaShell.t

[Impala-ASF-CR] IMPALA-10373: Run impala docker containers with uid/gid 1000

2020-12-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16807 ) Change subject: IMPALA-10373: Run impala docker containers with uid/gid 1000 .. Patch Set 1: Code-Review+2 LGTM -- To view, visit h

[Impala-ASF-CR] IMPALA-10447: Add a newline when exporting shell output to a file.

2021-01-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16966 Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. .. IMPALA-10447: Add a newline when exporting shell

[Impala-ASF-CR] IMPALA-10447: Add a newline when exporting shell output to a file.

2021-01-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16966 ) Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. .. IMPALA-10447: Add a newline when exporting shell

[Impala-ASF-CR] IMPALA-10447: Add a newline when exporting shell output to a file.

2021-01-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16966 ) Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. .. IMPALA-10447: Add a newline when exporting shell

[Impala-ASF-CR] IMPALA-10397 : Reduce flakiness in test single workload

2021-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17028 ) Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload .. Patch Set 1: Code-Review+2 (2 comments) LGTM, a few cosme

[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality

2022-08-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 ) Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality .. Patch Set 2: Code-Review+2 (1 comment) Doc is very c

[Impala-ASF-CR] IMPALA-9999: Switch to GCC 10.4

2022-09-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18134 ) Change subject: IMPALA-: Switch to GCC 10.4 .. Patch Set 14: Code-Review+1 LGTM -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-9999: Switch to GCC 10.4

2022-09-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18134 ) Change subject: IMPALA-: Switch to GCC 10.4 .. Patch Set 14: Code-Review+2 +2 based on addressing Csaba's comments -- To view,

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19002 Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. IMPALA-11482: Alter Table Execute Rollback for Iceber

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-17 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19002 to look at the new patch set (#4). Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tabl

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-17 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19002 to look at the new patch set (#5). Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tabl

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. IMPALA-11482: Alter Table Execute Rollback for Iceberg

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. IMPALA-11482: Alter Table Execute Rollback for Iceberg

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. Patch Set 6: (7 comments) Thanks for the review co

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-10-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. IMPALA-11482: Alter Table Execute Rollback for Iceberg

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-10-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. Patch Set 8: (7 comments) Thank for the useful com

[Impala-ASF-CR] IMPALA-11304: impala-shell make the client retry attempts configurable

2022-10-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19105 ) Change subject: IMPALA-11304: impala-shell make the client retry attempts configurable .. Patch Set 5: (3 comments) This looks good

[Impala-ASF-CR] IMPALA-11304: impala-shell make the client retry attempts configurable

2022-10-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19105 ) Change subject: IMPALA-11304: impala-shell make the client retry attempts configurable .. Patch Set 6: Code-Review+2 LGTM -- To vi

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 7: (4 comments) A few nits http://gerrit.clo

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-11-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 8: Code-Review+2 LGTM (I think all other revie

[Impala-ASF-CR] IMPALA-11726 Make impala-shell work with kerberos authentication

2022-11-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19248 ) Change subject: IMPALA-11726 Make impala-shell work with kerberos authentication .. Patch Set 3: (3 comments) Quick comments http:/

[Impala-ASF-CR] [tools] Add inline pom.py script for development

2022-12-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 ) Change subject: [tools] Add inline_pom.py script for development .. Patch Set 4: Code-Review+2 (3 comments) Looks good, please carry

[Impala-ASF-CR] IMPALA-11767: Catch exceptions for invalid paths in Hudi search

2022-12-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19312 ) Change subject: IMPALA-11767: Catch exceptions for invalid paths in Hudi search .. Patch Set 1: Code-Review+2 (2 comments) LGTM htt

[Impala-ASF-CR] IMPALA-11715: test resource limits kudu fails

2022-12-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19288 ) Change subject: IMPALA-11715: test_resource_limits_kudu fails .. Patch Set 2: Code-Review+2 LGTM, thanks -- To view, visit http://g

[Impala-ASF-CR] IMPALA-11767: Ignore exceptions for invalid paths in Hudi search

2022-12-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19312 ) Change subject: IMPALA-11767: Ignore exceptions for invalid paths in Hudi search .. Patch Set 3: Code-Review+2 Thanks for the quick f

[Impala-ASF-CR] IMPALA-11787: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality

2022-12-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19354 ) Change subject: IMPALA-11787: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality .

[Impala-ASF-CR] IMPALA-11787, IMPALA-11516: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality

2022-12-14 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19354 ) Change subject: IMPALA-11787, IMPALA-11516: Cardinality estimate for UNION in Iceberg position-delete plans can double the actual table cardinality ...

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2022-12-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19380 Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. IMPALA-10893: Use old schema during iceberg time travel. B

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2022-12-20 Thread Andrew Sherman (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19380 to look at the new patch set (#2). Change subject: IMPALA-10893: Use old schema during iceberg time travel. ...

[Impala-ASF-CR] IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test

2022-12-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19373 ) Change subject: IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test .. Patch Set 4: Code-Review+2

[Impala-ASF-CR] IMPALA-11811: Avoid storing unregistered predicate objects in a Map

2022-12-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19390 Change subject: IMPALA-11811: Avoid storing unregistered predicate objects in a Map .. IMPALA-11811: Avoid storing unregistered predic

[Impala-ASF-CR] IMPALA-11375 Impala shell outputs details of each RPC

2023-01-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19388 ) Change subject: IMPALA-11375 Impala shell outputs details of each RPC .. Patch Set 9: (22 comments) Generally looks good... http://

[Impala-ASF-CR] IMPALA-11375 Impala shell outputs details of each RPC

2023-01-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19388 ) Change subject: IMPALA-11375 Impala shell outputs details of each RPC .. Patch Set 11: Code-Review+1 (3 comments) LGTM http://gerri

[Impala-ASF-CR] IMPALA-11808: Add support for reload event in catalogD

2023-01-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19378 ) Change subject: IMPALA-11808: Add support for reload event in catalogD .. Patch Set 13: (7 comments) Some spelling nits http://gerr

[Impala-ASF-CR] IMPALA-11808: Add support for reload event in catalogD

2023-01-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19378 ) Change subject: IMPALA-11808: Add support for reload event in catalogD .. Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-11808: Add support for reload event in catalogD

2023-01-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19378 ) Change subject: IMPALA-11808: Add support for reload event in catalogD .. Patch Set 16: Code-Review+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-11827: do not cache admission control service's IP address in impalad

2023-01-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19403 ) Change subject: IMPALA-11827: do not cache admission control service's IP address in impalad .. Patch Set 2: Code-Review+2 LGTM --

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-06 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19380 to look at the new patch set (#3). Change subject: IMPALA-10893: Use old schema during iceberg time travel. ..

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-06 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19380 to look at the new patch set (#4). Change subject: IMPALA-10893: Use old schema during iceberg time travel. ..

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 2: (5 comments) Thanks for review comments. h

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 4: (3 comments) Thanks for the comments http:

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. IMPALA-10893: Use old schema during iceberg time travel. Be

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19380 to look at the new patch set (#6). Change subject: IMPALA-10893: Use old schema during iceberg time travel. ..

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 6: Code-Review+2 Carry forward +2 -- To view,

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 6: Verify tests fail in test_time_travel. It se

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-11 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19380 to look at the new patch set (#7). Change subject: IMPALA-10893: Use old schema during iceberg time travel. ..

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 7: The gerrit-verify-dryrun tests run the docke

[Impala-ASF-CR] IMPALA-11375 Impala shell outputs details of each RPC

2023-01-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19388 ) Change subject: IMPALA-11375 Impala shell outputs details of each RPC .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates

2023-01-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19419 ) Change subject: IMPALA-11826: Avoid calling planFiles() on Iceberg V2 tables when there are no predicates .. Patch Set 2: Code-Review

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19420 Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. IMPALA-11835: [DOCS] Document th

[Impala-ASF-CR] IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol.

2023-01-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19428 ) Change subject: IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol. .. Patch Set 3: (11 comments) A few quick

[Impala-ASF-CR] IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol.

2023-01-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19428 ) Change subject: IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol. .. Patch Set 3: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables

2023-01-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19397 ) Change subject: IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables .. Patch Set 6: (3 comments) This seems a v

[Impala-ASF-CR] IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol.

2023-01-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19428 ) Change subject: IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol. .. Patch Set 6: (3 comments) A few more ni

[Impala-ASF-CR] IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol.

2023-01-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19428 ) Change subject: IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol. .. Patch Set 6: (2 comments) More comments

[Impala-ASF-CR] IMPALA-11617: Pool service should be made aware of cpu core limit

2023-01-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 ) Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit .. Patch Set 4: (1 comment) Just questions, I'm n

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. IMPALA-11835: [DOCS] Document tha

[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19447 Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. IMPALA-11862: [DOCS] Document the default val

[Impala-ASF-CR] IMPALA-11617: Pool service should be made aware of cpu core limit

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 ) Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit .. Patch Set 5: Code-Review+2 Thanks for the answe

[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 ) Change subject: IMPALA-11856: Use POST requests to set log level .. Patch Set 20: Code-Review+2 (3 comments) LGTM, thanks for this c

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. IMPALA-11835: [DOCS] Document tha

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. Patch Set 2: (1 comment) Than

[Impala-ASF-CR] IMPALA-11662: Improve 'refresh iceberg tbl on oss' performance

2023-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19379 ) Change subject: IMPALA-11662: Improve 'refresh iceberg_tbl_on_oss' performance .. Patch Set 9: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. IMPALA-11862: [DOCS] Document the default valu

[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 2: (2 comments) Thanks for comme

[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 2: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-11859: Add bytes-read-encrypted metric

2023-01-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19461 ) Change subject: IMPALA-11859: Add bytes-read-encrypted metric .. Patch Set 3: Code-Review+2 LGTM -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol.

2023-02-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19428 ) Change subject: IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol. .. Patch Set 7: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-11913: Upgrade datatables to 1.13.2

2023-02-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19489 ) Change subject: IMPALA-11913: Upgrade datatables to 1.13.2 .. Patch Set 1: Code-Review+2 I built the change and looked at the webui a

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

2023-02-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19509 Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing. .. IMPALA-11509: Prevent query hanging when Iceb

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

2023-02-16 Thread Andrew Sherman (Code Review)
Hello Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19509 to look at the new patch set (#2). Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing. .

[Impala-ASF-CR] IMPALA-11922 Verify JWKS URL server TLS certificate by default.

2023-02-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19503 ) Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default. .. Patch Set 6: (11 comments) Mostly comments about

[Impala-ASF-CR] IMPALA-11509: Prevent query hanging when Iceberg metadata is missing.

2023-02-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 ) Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing. .. Patch Set 2: (2 comments) Thanks for the r

[Impala-ASF-CR] IMPALA-11922 Verify JWKS URL server TLS certificate by default.

2023-02-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19503 ) Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default. .. Patch Set 8: Code-Review+1 LGTM -- To view, visi

[Impala-ASF-CR] IMPALA-11922 Verify JWKS URL server TLS certificate by default.

2023-02-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19503 ) Change subject: IMPALA-11922 Verify JWKS URL server TLS certificate by default. .. Patch Set 8: Code-Review+2 Oh I see Alexey gave +1

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-02-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19509 ) Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing. .. IMPALA-11509: Prevent queries hanging when I

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-02-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 ) Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing. .. Patch Set 2: (2 comments) Narrowed the s

[Impala-ASF-CR] IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

2023-02-23 Thread Andrew Sherman (Code Review)
Hello Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19509 to look at the new patch set (#4). Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing.

[Impala-ASF-CR] IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg

2023-02-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19530 ) Change subject: IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg .. Patch Set 2: (7 comments) I did a quick read

[Impala-ASF-CR] IMPALA-11945: Fix Flaky Test in JwtHttpTest

2023-02-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19536 ) Change subject: IMPALA-11945: Fix Flaky Test in JwtHttpTest .. Patch Set 4: (1 comment) I have a suggestion which you can push back

[Impala-ASF-CR] WIP IMPALA-11947: Bump GBN to get Iceberg change #6074

2023-02-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19538 Change subject: WIP IMPALA-11947: Bump GBN to get Iceberg change #6074 .. WIP IMPALA-11947: Bump GBN to get Iceberg change #6074 We ne

[Impala-ASF-CR] IMPALA-11945: Fix Flaky Test in JwtHttpTest

2023-02-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19536 ) Change subject: IMPALA-11945: Fix Flaky Test in JwtHttpTest .. Patch Set 5: Code-Review+1 LGTM, I'll let Riza take this to +2 -- To

[Impala-ASF-CR] IMPALA-11947: Bump GBN to get Iceberg change #6074

2023-02-26 Thread Andrew Sherman (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19538 to look at the new patch set (#2). Change subject: IMPALA-11947: Bump GBN to get Iceberg change #6074 .. I

[Impala-ASF-CR] IMPALA-11479: Add Java unit tests for IcebergUtil.

2023-02-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19541 Change subject: IMPALA-11479: Add Java unit tests for IcebergUtil. .. IMPALA-11479: Add Java unit tests for IcebergUtil. This does not

[Impala-ASF-CR] rm line

2023-02-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19542 Change subject: rm line .. rm line Change-Id: I9e265a2174d2a8550de81dfde1d2f767ff96642f --- M fe/src/test/java/org/apache/impala/util/

[Impala-ASF-CR] IMPALA-11479: Add Java unit tests for IcebergUtil.

2023-02-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has abandoned this change. ( http://gerrit.cloudera.org:8080/19541 ) Change subject: IMPALA-11479: Add Java unit tests for IcebergUtil. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/19541 To unsu

<    1   2   3   4   5   6   7   >