[Impala-ASF-CR] IMPALA-8071: Initial unified backend test framework

2019-02-07 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12124 to look at the new patch set (#8). Change subject: IMPALA-8071: Initial unified backend test framework .

[Impala-ASF-CR] IMPALA-8071: Initial unified backend test framework

2019-02-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12124 ) Change subject: IMPALA-8071: Initial unified backend test framework .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

2019-02-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 ) Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag .. Patch Set 4: (1 comment) One small comment, then I thi

[Impala-ASF-CR] IMPALA-8071: Initial unified backend test framework

2019-02-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12124 ) Change subject: IMPALA-8071: Initial unified backend test framework .. IMPALA-8071: Initial unified backend test framework The

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

2019-02-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 ) Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag .. Patch Set 5: It looks like the patch got auto-formatted

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

2019-02-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 ) Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag .. Patch Set 5: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-8186: script to configure docker network

2019-02-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12452 ) Change subject: IMPALA-8186: script to configure docker network .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/1245

[Impala-ASF-CR] Turn off shell debug tracing for create-load-data.sh

2019-02-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12398 ) Change subject: Turn off shell debug tracing for create-load-data.sh .. Patch Set 2: Code-Review+2 Rebase, carry +2 -- To view, visi

[Impala-ASF-CR] IMPALA-8193: Fix python 2.6 issue in junit prune notrun.py

2019-02-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12479 Change subject: IMPALA-8193: Fix python 2.6 issue in junit_prune_notrun.py .. IMPALA-8193: Fix python 2.6 issue in junit_prune_notrun.py

[Impala-ASF-CR] IMPALA-8189: Disable flaky scanner test on S3

2019-02-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12478 ) Change subject: IMPALA-8189: Disable flaky scanner test on S3 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-8214: Fix bad plan in load nested.py

2019-02-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12519 ) Change subject: IMPALA-8214: Fix bad plan in load_nested.py .. Patch Set 3: Code-Review+2 Thanks for taking this on. Looks good. --

[Impala-ASF-CR] IMPALA-8235: avoid TIME MS in runtime profile

2019-02-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12544 ) Change subject: IMPALA-8235: avoid TIME_MS in runtime profile .. Patch Set 2: Code-Review+2 Thanks for fixing this! -- To view, visi

[Impala-ASF-CR] IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning

2019-02-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12543 ) Change subject: IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning .. Patch Set 4: (1 comment) Thanks for workin

[Impala-ASF-CR] IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning

2019-02-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12543 ) Change subject: IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning .. Patch Set 5: (2 comments) One small thing.

[Impala-ASF-CR] IMPALA-8178: Disable file handle cache for HDFS erasure coded files

2019-02-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12552 Change subject: IMPALA-8178: Disable file handle cache for HDFS erasure coded files .. IMPALA-8178: Disable file handle cache for HDFS

[Impala-ASF-CR] IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning

2019-02-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12543 ) Change subject: IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning .. Patch Set 6: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-8178: Disable file handle cache for HDFS erasure coded files

2019-02-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12552 ) Change subject: IMPALA-8178: Disable file handle cache for HDFS erasure coded files .. Patch Set 1: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8178: Disable file handle cache for HDFS erasure coded files

2019-02-21 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12552 to look at the new patch set (#2). Change subject: IMPALA-8178: Disable file handle cache for HDFS erasure coded files ..

[Impala-ASF-CR] IMPALA-8178: Disable file handle cache for HDFS erasure coded files

2019-02-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12552 ) Change subject: IMPALA-8178: Disable file handle cache for HDFS erasure coded files .. Patch Set 2: Code-Review+2 Carrying +2 -- To

[Impala-ASF-CR] IMPALA-8178: Disable file handle cache for HDFS erasure coded files

2019-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12552 ) Change subject: IMPALA-8178: Disable file handle cache for HDFS erasure coded files .. IMPALA-8178: Disable file handle cache

[Impala-ASF-CR] IMPALA-8188: Fix DiskInfo::GetDeviceNames() for NVME disks

2019-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12557 Change subject: IMPALA-8188: Fix DiskInfo::GetDeviceNames() for NVME disks .. IMPALA-8188: Fix DiskInfo::GetDeviceNames() for NVME disks

[Impala-ASF-CR] IMPALA-8188: Fix DiskInfo::GetDeviceNames() for NVME disks

2019-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12557 ) Change subject: IMPALA-8188: Fix DiskInfo::GetDeviceNames() for NVME disks .. Patch Set 1: > Could you extract the function and add a

[Impala-ASF-CR] IMPALA-8188: Fix DiskInfo::GetDeviceNames() for NVME disks

2019-02-22 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12557 to look at the new patch set (#2). Change subject: IMPALA-8188: Fix DiskInfo::GetDeviceNames() for NVME disks ..

[Impala-ASF-CR] IMPALA-8247: Fix tests missing from unified backend executable

2019-02-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12584 Change subject: IMPALA-8247: Fix tests missing from unified backend executable .. IMPALA-8247: Fix tests missing from unified backend ex

[Impala-ASF-CR] IMPALA-8247: Fix tests missing from unified backend executable

2019-02-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12584 ) Change subject: IMPALA-8247: Fix tests missing from unified backend executable .. IMPALA-8247: Fix tests missing from unified b

[Impala-ASF-CR] IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps

2019-02-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12593 ) Change subject: IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps .. Patch Set 1: (1 comment) Thanks for taking thi

[Impala-ASF-CR] IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps

2019-02-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12593 ) Change subject: IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps .. Patch Set 2: Code-Review+2 Thanks! -- To view

[Impala-ASF-CR] IMPALA-8250: Fix a handful of JNI usage errors.

2019-02-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12582 ) Change subject: IMPALA-8250: Fix a handful of JNI usage errors. .. Patch Set 2: Code-Review+2 Thanks! -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-8188: Fix DiskInfo::GetDeviceNames() for NVME disks

2019-02-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12557 ) Change subject: IMPALA-8188: Fix DiskInfo::GetDeviceNames() for NVME disks .. IMPALA-8188: Fix DiskInfo::GetDeviceNames() for N

[Impala-ASF-CR] IMPALA-8249: End-to-end test framework doesn't read aggregated counters properly

2019-02-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12589 ) Change subject: IMPALA-8249: End-to-end test framework doesn't read aggregated counters properly .. Patch Set 1: (2 comments) Thanks

[Impala-ASF-CR] Make error message for backend test validation more clear

2019-02-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 ) Change subject: Make error message for backend test validation more clear .. Patch Set 1: (1 comment) Thanks for working on this! I

[Impala-ASF-CR] Make error message for backend test validation more clear

2019-02-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 ) Change subject: Make error message for backend test validation more clear .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] Make error message for backend test validation more clear

2019-02-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 ) Change subject: Make error message for backend test validation more clear .. Patch Set 3: Let's flip this around. I'll do an upload an

[Impala-ASF-CR] Usability fixups for the unified backend test executable

2019-02-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#4) to the change originally created by Lars Volker. ( http://gerrit.cloudera.org:8080/12620 ) Change subject: Usability fixups for the unified backend test executable .. Usability fix

[Impala-ASF-CR] IMPALA-8249: End-to-end test framework doesn't read aggregated counters properly

2019-03-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12589 ) Change subject: IMPALA-8249: End-to-end test framework doesn't read aggregated counters properly .. Patch Set 4: Code-Review+2 (1 com

[Impala-ASF-CR] IMPALA-8003: Improve logging for diskspace errors from dataload

2019-03-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12399 ) Change subject: IMPALA-8003: Improve logging for diskspace errors from dataload .. Patch Set 1: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-8003: Improve logging for diskspace errors from dataload

2019-03-01 Thread Joe McDonnell (Code Review)
Hello Laszlo Gaal, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12399 to look at the new patch set (#2). Change subject: IMPALA-8003: Improve logging for diskspace errors from dataload ...

[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure

2019-03-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 ) Change subject: IMPALA-7988: addendum: tolerate docker stop failure .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure

2019-03-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 ) Change subject: IMPALA-7988: addendum: tolerate docker stop failure .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-7988: addendum: tolerate docker stop failure

2019-03-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 ) Change subject: IMPALA-7988: addendum: tolerate docker stop failure .. Patch Set 1: Code-Review+2 Makes sense. -- To view, visit htt

[Impala-ASF-CR] Simplify JNI exception-handling macros.

2019-03-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12659 ) Change subject: Simplify JNI exception-handling macros. .. Patch Set 1: Code-Review+2 This makes sense, upgrading to +2. -- To view,

[Impala-ASF-CR] Generate JUnitXML if a command run by CMake fails

2019-03-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12668 Change subject: Generate JUnitXML if a command run by CMake fails .. Generate JUnitXML if a command run by CMake fails This wraps each

[Impala-ASF-CR] Fix code coverage argument to bin/run-all-tests.sh

2019-03-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12673 Change subject: Fix code coverage argument to bin/run-all-tests.sh .. Fix code coverage argument to bin/run-all-tests.sh The run-all-te

[Impala-ASF-CR] Fix code coverage argument to bin/run-all-tests.sh

2019-03-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12673 ) Change subject: Fix code coverage argument to bin/run-all-tests.sh .. Fix code coverage argument to bin/run-all-tests.sh The r

[Impala-ASF-CR] IMPALA-8147: part 2: Remove make impala.sh

2019-03-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12556 ) Change subject: IMPALA-8147: part 2: Remove make_impala.sh .. Patch Set 1: Code-Review+2 Good to see this cleaned up! -- To view, vi

[Impala-ASF-CR] IMPALA-8250: Clean up JNI warnings.

2019-03-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12660 ) Change subject: IMPALA-8250: Clean up JNI warnings. .. Patch Set 4: Code-Review+2 Thanks! -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12730 Change subject: IMPALA-337: Add support for POST to the webserver .. IMPALA-337: Add support for POST to the webserver In order to supp

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12730 ) Change subject: IMPALA-337: Add support for POST to the webserver .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/12

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-12 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12730 to look at the new patch set (#2). Change subject: IMPALA-337: Add support for POST to the webserver .. IM

[Impala-ASF-CR] IMPALA-8003: Improve logging for diskspace errors from dataload

2019-03-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12399 ) Change subject: IMPALA-8003: Improve logging for diskspace errors from dataload .. Patch Set 2: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-8003: Improve logging for diskspace errors from dataload

2019-03-12 Thread Joe McDonnell (Code Review)
Hello Laszlo Gaal, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12399 to look at the new patch set (#3). Change subject: IMPALA-8003: Improve logging for diskspace errors from dataload ...

[Impala-ASF-CR] IMPALA-8303: Generate JUnitXML for ASAN failures

2019-03-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12733 Change subject: IMPALA-8303: Generate JUnitXML for ASAN failures .. IMPALA-8303: Generate JUnitXML for ASAN failures This modifies bin/

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

2019-03-12 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12668 to look at the new patch set (#2). Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails .

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12724 ) Change subject: Add missing sudo call to `service postgresql start` .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] Use test -x to check for ntp-wait

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12726 ) Change subject: Use test -x to check for ntp-wait .. Patch Set 1: Code-Review+1 This looks good to me. Quick question: Is this a cosme

[Impala-ASF-CR] Set correct permissions for ~/.ssh files

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12725 ) Change subject: Set correct permissions for ~/.ssh files .. Patch Set 1: (2 comments) Thanks for working on this! For this one, can y

[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Patch Set 1: (1 comment) Let me

[Impala-ASF-CR] Use test -x to check for ntp-wait

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12726 ) Change subject: Use test -x to check for ntp-wait .. Patch Set 1: > > This looks good to me. Quick question: Is this a cosmetic issue

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-13 Thread Joe McDonnell (Code Review)
Hello Andrew Sherman, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12730 to look at the new patch set (#3). Change subject: IMPALA-337: Add support for POST to the webserver ..

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12730 ) Change subject: IMPALA-337: Add support for POST to the webserver .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/127

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-13 Thread Joe McDonnell (Code Review)
Hello Andrew Sherman, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12730 to look at the new patch set (#4). Change subject: IMPALA-337: Add support for POST to the webserver ..

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12730 ) Change subject: IMPALA-337: Add support for POST to the webserver .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12

[Impala-ASF-CR] IMPALA-8303: Generate JUnitXML for ASAN failures

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12733 ) Change subject: IMPALA-8303: Generate JUnitXML for ASAN failures .. IMPALA-8303: Generate JUnitXML for ASAN failures This modi

[Impala-ASF-CR] IMPALA-8305: Generate JUnitXML for DCHECK failures

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12751 Change subject: IMPALA-8305: Generate JUnitXML for DCHECK failures .. IMPALA-8305: Generate JUnitXML for DCHECK failures DCHECKs log at

[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Patch Set 1: > > (1 comment) > >

[Impala-ASF-CR] IMPALA-8176: Convert more backend tests to the unified executable

2019-03-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12759 Change subject: IMPALA-8176: Convert more backend tests to the unified executable .. IMPALA-8176: Convert more backend tests to the uni

[Impala-ASF-CR] IMPALA-8305: Generate JUnitXML for DCHECK failures

2019-03-14 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12751 to look at the new patch set (#2). Change subject: IMPALA-8305: Generate JUnitXML for DCHECK failures .. I

[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script

2019-03-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Patch Set 2: Code-Review+2 Thanks

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12730 ) Change subject: IMPALA-337: Add support for POST to the webserver .. IMPALA-337: Add support for POST to the webserver In orde

[Impala-ASF-CR] IMPALA-8314 Set correct permissions for ~/.ssh files

2019-03-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12725 ) Change subject: IMPALA-8314 Set correct permissions for ~/.ssh files .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-8307 Use test -x to check for ntp-wait

2019-03-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12726 ) Change subject: IMPALA-8307 Use test -x to check for ntp-wait .. Patch Set 2: Code-Review+2 Thanks! -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-8003: Improve logging for diskspace errors from dataload

2019-03-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12399 ) Change subject: IMPALA-8003: Improve logging for diskspace errors from dataload .. Patch Set 3: (2 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

2019-03-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 ) Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails .. Patch Set 2: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

2019-03-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 ) Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails .. Patch Set 3: Code-Review+1 Rebased, carry +1 -- To

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

2019-03-15 Thread Joe McDonnell (Code Review)
Hello David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12668 to look at the new patch set (#3). Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails

[Impala-ASF-CR] IMPALA-8305: Generate JUnitXML for DCHECK failures

2019-03-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12751 ) Change subject: IMPALA-8305: Generate JUnitXML for DCHECK failures .. IMPALA-8305: Generate JUnitXML for DCHECK failures DCHEC

[Impala-ASF-CR] IMPALA-8320: Handle psutil error in tests

2019-03-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12792 ) Change subject: IMPALA-8320: Handle psutil error in tests .. Patch Set 1: Code-Review+2 (1 comment) Thank you for fixing this. http:

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

2019-03-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12724 ) Change subject: Add missing sudo call to `service postgresql start` .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

2019-03-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 ) Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails .. Patch Set 4: Code-Review+1 Rebased, carry +1 -- To

[Impala-ASF-CR] Add extra TRACE calls for cancellation code path

2019-03-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12832 ) Change subject: Add extra TRACE calls for cancellation code path .. Patch Set 1: Thanks for working on this. Taking a look. For my own

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 ) Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading .. Patch Set 2: Code-Review+2 Thanks for fixing this!

[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws

2019-03-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws .. Patch Set 5: (2 comments) I'm ready to +2

[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws

2019-03-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws .. Patch Set 6: Code-Review+2 Thanks for this

[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script

2019-03-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Move DEBIAN_FRONTEND=nonin

[Impala-ASF-CR] IMPALA-8307 Use test -x to check for ntp-wait

2019-03-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12726 ) Change subject: IMPALA-8307 Use test -x to check for ntp-wait .. IMPALA-8307 Use test -x to check for ntp-wait Running ntp-wai

[Impala-ASF-CR] Use 'wget http://169.254.169.254/' to determine if we're running in aws

2019-03-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws .. Use 'wget http://169.254.169.254/'

[Impala-ASF-CR] Add missing sudo call to `service postgresql start`

2019-03-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12724 ) Change subject: Add missing sudo call to `service postgresql start` .. Add missing sudo call to `service postgresql start` Cha

[Impala-ASF-CR] IMPALA-8314 Set correct permissions for ~/.ssh files

2019-03-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12725 ) Change subject: IMPALA-8314 Set correct permissions for ~/.ssh files .. IMPALA-8314 Set correct permissions for ~/.ssh files W

[Impala-ASF-CR] IMPALA-8359: Fix coverage data generation for impalads

2019-03-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12858 ) Change subject: IMPALA-8359: Fix coverage data generation for impalads .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-03-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12885 Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. IMPALA-8371: Return appropriate error code for

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-03-28 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12885 to look at the new patch set (#2). Change subject: IMPALA-8371: Return appropriate error code for unified backend tests ..

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-03-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 1: (9 comments) http://gerrit.clou

[Impala-ASF-CR] Improve error handling for validation of unified backend executable

2019-03-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12895 Change subject: Improve error handling for validation of unified backend executable .. Improve error handling for validation of unified

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 2: (2 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 3: Code-Review+1 Carry +1 -- To v

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-02 Thread Joe McDonnell (Code Review)
Hello Andrew Sherman, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12885 to look at the new patch set (#3). Change subject: IMPALA-8371: Return appropriate error code for unified backend tests ..

[Impala-ASF-CR] IMPALA-8360: Fix race conditions in thread-pool-test

2019-04-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12916 Change subject: IMPALA-8360: Fix race conditions in thread-pool-test .. IMPALA-8360: Fix race conditions in thread-pool-test There are

[Impala-ASF-CR] IMPALA-8359: Fix coverage data generation for impalads

2019-04-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12858 ) Change subject: IMPALA-8359: Fix coverage data generation for impalads .. Patch Set 4: Code-Review+2 Thanks for fixing this! -- To v

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-05 Thread Joe McDonnell (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12885 to look at the new patch set (#5). Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 4: (2 comments) http://gerrit.clou

<    1   2   3   4   5   6   7   8   9   10   >