[kudu-CR] [kudu-jepsen] added more info on troubleshooting

2017-05-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [kudu-jepsen] added more info on troubleshooting .. [kudu-jepsen] added more info on troubleshooting Added more information on distinguishing 'errors'

[kudu-CR] [kudu-jepsen] added more info on troubleshooting

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] added more info on troubleshooting .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6774 To unsubscribe,

[kudu-CR] KUDU-1949. Maintenance Manager should trigger flushes earlier

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1949. Maintenance Manager should trigger flushes earlier .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6802 To

[kudu-CR] KUDU-1970: node density integration test

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1970: node density integration test .. Patch Set 9: (1 comment)

[kudu-CR] Fix bug in incorrect response rebuilding on tablet bootstrap

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Fix bug in incorrect response rebuilding on tablet bootstrap .. Patch Set 5: (2 comments)

[kudu-CR] Fix bug in incorrect response rebuilding on tablet bootstrap

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#6). Change subject: Fix bug in incorrect response rebuilding on tablet bootstrap .. Fix bug in incorrect response rebuilding on tablet bootstrap This fixes the bug described

[kudu-CR](branch-1.3.x) KUDU-1993: fixed validation of 'grouped' gflags

2017-05-04 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6806 to review the following change. Change subject: KUDU-1993: fixed validation of 'grouped' gflags ..

[kudu-CR] KUDU-1993: fixed validation of 'grouped' gflags

2017-05-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: KUDU-1993: fixed validation of 'grouped' gflags .. KUDU-1993: fixed validation of 'grouped' gflags Added generic implementation for grouped gflags

[kudu-CR] KUDU-1927 [master] always send IPKI CA certificate

2017-05-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1927 [master] always send IPKI CA certificate .. Patch Set 6: > Looking back over old JIRAs. This is still relevant, right Alexey? > Just waiting on

[kudu-CR](branch-1.3.x) KUDU-1981 Kudu should run at hosts len(FQDN) > 64

2017-05-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: KUDU-1981 Kudu should run at hosts len(FQDN) > 64 .. KUDU-1981 Kudu should run at hosts len(FQDN) > 64 This is a fix for KUDU-1981: with security

[kudu-CR] KUDU-1993: fixed validation of 'grouped' gflags

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1993: fixed validation of 'grouped' gflags .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6795 To unsubscribe, visit

[kudu-CR] KUDU-1993: fixed validation of 'grouped' gflags

2017-05-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1993: fixed validation of 'grouped' gflags .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6795/5/build-support/lsan-suppressions.txt File

[kudu-CR] KUDU-1993: fixed validation of 'grouped' gflags

2017-05-04 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6795 to look at the new patch set (#7). Change subject: KUDU-1993: fixed validation of 'grouped' gflags .. KUDU-1993:

[kudu-CR](branch-1.3.x) KUDU-1981 Kudu should run at hosts len(FQDN) > 64

2017-05-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1981 Kudu should run at hosts len(FQDN) > 64 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6805 To unsubscribe,

[kudu-CR] KUDU-1993: fixed validation of 'grouped' gflags

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1993: fixed validation of 'grouped' gflags .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6795/5/build-support/lsan-suppressions.txt File

[kudu-CR](branch-1.3.x) KUDU-1981 Kudu should run at hosts len(FQDN) > 64

2017-05-04 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6805 to review the following change. Change subject: KUDU-1981 Kudu should run at hosts len(FQDN) > 64 ..

[kudu-CR] KUDU-1993: fixed validation of 'grouped' gflags

2017-05-04 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6795 to look at the new patch set (#6). Change subject: KUDU-1993: fixed validation of 'grouped' gflags .. KUDU-1993:

[kudu-CR] KUDU-1993: fixed validation of 'grouped' gflags

2017-05-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1993: fixed validation of 'grouped' gflags .. Patch Set 5: (12 comments) http://gerrit.cloudera.org:8080/#/c/6795/5/build-support/lsan-suppressions.txt

[kudu-CR] KUDU-1970: node density integration test

2017-05-04 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6662 to look at the new patch set (#11). Change subject: KUDU-1970: node density integration test ..

[kudu-CR] cfile set: avoid Status allocation for row not found

2017-05-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: cfile_set: avoid Status allocation for row not found .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6804/2/src/kudu/tablet/cfile_set.cc File

[kudu-CR] KUDU-1970: node density integration test

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1970: node density integration test .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/6662/9/src/kudu/integration-tests/dense_node-itest.cc

[kudu-CR] cfile set: avoid Status allocation for row not found

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: cfile_set: avoid Status allocation for row not found .. Patch Set 2: Code-Review+2 (2 comments)

[kudu-CR] KUDU-1949. Maintenance Manager should trigger flushes earlier

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1949. Maintenance Manager should trigger flushes earlier .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6802 To unsubscribe,

[kudu-CR] KUDU-1993: fixed validation of 'grouped' gflags

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1993: fixed validation of 'grouped' gflags .. Patch Set 5: (11 comments) http://gerrit.cloudera.org:8080/#/c/6795/5/build-support/lsan-suppressions.txt File

[kudu-CR] KUDU-1927 [master] always send IPKI CA certificate

2017-05-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1927 [master] always send IPKI CA certificate .. Patch Set 6: Looking back over old JIRAs. This is still relevant, right Alexey? Just waiting on review? --

[kudu-CR] Fix bug in incorrect response rebuilding on tablet bootstrap

2017-05-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix bug in incorrect response rebuilding on tablet bootstrap .. Patch Set 5: (2 comments)

[kudu-CR] cfile set: avoid Status allocation for row not found

2017-05-04 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6804 to look at the new patch set (#2). Change subject: cfile_set: avoid Status allocation for row not found

[kudu-CR] WIP: cfile set: avoid Status allocation for row not found

2017-05-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: cfile_set: avoid Status allocation for row not found .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6804/1/src/kudu/tablet/cfile_set.cc

[kudu-CR] KUDU-1949. Maintenance Manager should trigger flushes earlier

2017-05-04 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6802 to look at the new patch set (#2). Change subject: KUDU-1949. Maintenance Manager should trigger flushes earlier

[kudu-CR] WIP: cfile set: avoid Status allocation for row not found

2017-05-04 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6804 to review the following change. Change subject: WIP: cfile_set: avoid Status allocation for row not found ..

[kudu-CR] WIP: KUDU-1949. Maintenance Manager should trigger flushes earlier

2017-05-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1949. Maintenance Manager should trigger flushes earlier .. Patch Set 1: > If you're already going to run some benchmarks, could you roll into this >

[kudu-CR] KUDU-1843. Client UUIDs should be cryptographically random

2017-05-04 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1843. Client UUIDs should be cryptographically random .. Patch Set 2: Code-Review-1 I still think this is a bad idea. At the very least, this patch needs to

[kudu-CR] [kudu-jepsen] added more info on troubleshooting

2017-05-04 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6774 to look at the new patch set (#5). Change subject: [kudu-jepsen] added more info on troubleshooting ..

[kudu-CR] [kudu-jepsen] added more info on troubleshooting

2017-05-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [kudu-jepsen] added more info on troubleshooting .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6774/4/java/kudu-jepsen/README.adoc File

[kudu-CR] Fix bug in incorrect response rebuilding on tablet bootstrap

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Fix bug in incorrect response rebuilding on tablet bootstrap .. Patch Set 5: Verified+1 unrelated failure in ClientTest.TestScannerKeepAlive -- To view,

[kudu-CR] KUDU-1843. Client UUIDs should be cryptographically random

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1843. Client UUIDs should be cryptographically random .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6347 To

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 26: (25 comments)

[kudu-CR] KUDU-1993: fixed validation of 'grouped' gflags

2017-05-04 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6795 to look at the new patch set (#5). Change subject: KUDU-1993: fixed validation of 'grouped' gflags .. KUDU-1993:

[kudu-CR] KUDU-1993: fixed validation of 'grouped' gflags

2017-05-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1993: fixed validation of 'grouped' gflags .. Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/6795/3//COMMIT_MSG Commit Message: Line 19:

[kudu-CR] KUDU-1993: fixed validation of 'grouped' gflags

2017-05-04 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6795 to look at the new patch set (#4). Change subject: KUDU-1993: fixed validation of 'grouped' gflags .. KUDU-1993:

[kudu-CR] Rename TabletPeer to TabletReplica

2017-05-04 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Rename TabletPeer to TabletReplica .. Rename TabletPeer to TabletReplica This class was confusingly named. This changes the class names as well as all

[kudu-CR] Rename TabletPeer to TabletReplica

2017-05-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Rename TabletPeer to TabletReplica .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6794 To unsubscribe, visit

[kudu-CR] tablet: revert batch-check-presence optimization for UPDATE/DELETE

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: tablet: revert batch-check-presence optimization for UPDATE/DELETE .. Patch Set 1: (1 comment) still want this reviewed? (had an old unposted comment

[kudu-CR] [kudu-jepsen] added more info on troubleshooting

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [kudu-jepsen] added more info on troubleshooting .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6774/4/java/kudu-jepsen/README.adoc File

[kudu-CR] WIP KUDU-1826 add propagated timestamp to sync client

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP KUDU-1826 add propagated timestamp to sync client .. Patch Set 1: (1 comment)

[kudu-CR] WIP: KUDU-1949. Maintenance Manager should trigger flushes earlier

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-1949. Maintenance Manager should trigger flushes earlier .. Patch Set 1: looks good, waiting for those results -- To view, visit

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-04 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#17). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952

[kudu-CR] Fix bug in incorrect response rebuilding on tablet bootstrap

2017-05-04 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5489 to look at the new patch set (#5). Change subject: Fix bug in incorrect response rebuilding on tablet bootstrap ..

[kudu-CR] Fix bug in incorrect response rebuilding on tablet bootstrap

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Fix bug in incorrect response rebuilding on tablet bootstrap .. Patch Set 4: (8 comments)

[kudu-CR] Rename TabletPeer to TabletReplica

2017-05-04 Thread Mike Percy (Code Review)
Hello Will Berkeley, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6794 to look at the new patch set (#3). Change subject: Rename TabletPeer to TabletReplica

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-05-04 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6630 to look at the new patch set (#14). Change subject: WIP: KUDU-463. Add checksumming to cfile .. WIP: KUDU-463. Add

[kudu-CR] Rename TabletPeer to TabletReplica

2017-05-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Rename TabletPeer to TabletReplica .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6794 To unsubscribe, visit

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-04 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#16). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952

[kudu-CR] Rename TabletPeer to TabletReplica

2017-05-04 Thread Mike Percy (Code Review)
Hello Will Berkeley, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6794 to look at the new patch set (#2). Change subject: Rename TabletPeer to TabletReplica

[kudu-CR] Rename TabletPeer to TabletReplica

2017-05-04 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Rename TabletPeer to TabletReplica .. Patch Set 1: Yeah these kinds of patches have a short shelf life! Rebasing manually. -- To view, visit

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-05-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/6630/13/src/kudu/cfile/cfile_writer.cc File

[kudu-CR] [util] introduced custom gflags validators

2017-05-04 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [util] introduced custom gflags validators .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6795/3/src/kudu/rpc/messenger.cc File

[kudu-CR](branch-1.3.x) KUDU-1964. security: avoid calling ERR clear error() defensively

2017-05-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1964. security: avoid calling ERR_clear_error() defensively .. KUDU-1964. security: avoid calling ERR_clear_error() defensively This changes

[kudu-CR] Rename TabletPeer to TabletReplica

2017-05-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Rename TabletPeer to TabletReplica .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6794 To unsubscribe, visit

[kudu-CR] docs: Shorten top-level headings in Troubleshooting Guide

2017-05-04 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: docs: Shorten top-level headings in Troubleshooting Guide .. docs: Shorten top-level headings in Troubleshooting Guide The top level headings in the

[kudu-CR] WIP: KUDU-1949. Maintenance Manager should trigger flushes earlier

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: KUDU-1949. Maintenance Manager should trigger flushes earlier .. Patch Set 1: If you're already going to run some benchmarks, could you roll into this change

[kudu-CR] docs: Add breakpad documentation to user guide

2017-05-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: docs: Add breakpad documentation to user guide .. docs: Add breakpad documentation to user guide Change-Id: I05275aab0196dbf8fc37da320a0bf34662606a14

[kudu-CR] docs: Add breakpad documentation to user guide

2017-05-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: Add breakpad documentation to user guide .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6504 To unsubscribe, visit

[kudu-CR] WIP: KUDU-1949. Maintenance Manager should trigger flushes earlier

2017-05-04 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6802 to review the following change. Change subject: WIP: KUDU-1949. Maintenance Manager should trigger flushes earlier

[kudu-CR] tablet copy: Ensure no data loss on tablet copy failure

2017-05-04 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: tablet copy: Ensure no data loss on tablet copy failure .. tablet copy: Ensure no data loss on tablet copy failure This patch adds an integration test to

[kudu-CR] KUDU-1853 (redux). tablet copy: Don't orphan blocks on failure

2017-05-04 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: KUDU-1853 (redux). tablet copy: Don't orphan blocks on failure .. KUDU-1853 (redux). tablet copy: Don't orphan blocks on failure Previously, if a tablet

[kudu-CR] [flaky tests] Address LSAN false positives

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: [flaky tests] Address LSAN false positives .. [flaky tests] Address LSAN false positives Some tests, like external_mini_cluster-itest, are now

[kudu-CR] [flaky tests] Address LSAN false positives

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [flaky tests] Address LSAN false positives .. Patch Set 4: Code-Review+2 just rebased, keeping the +2 -- To view, visit

[kudu-CR] [flaky tests] Address LSAN false positives

2017-05-04 Thread David Ribeiro Alves (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6320 to look at the new patch set (#4). Change subject: [flaky tests] Address LSAN false positives ..

[kudu-CR] [flaky tests] Address LSAN false positives

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [flaky tests] Address LSAN false positives .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6320/3/src/kudu/util/striped64.cc File

[kudu-CR] env: add WriteV() API

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: env: add WriteV() API .. env: add WriteV() API Adds WriteV() methods to RWFile and WritableFile that allows writing multiple data Slices in one call. The

[kudu-CR] Silence clang -Waddress-of-packed-member warning

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Silence clang -Waddress-of-packed-member warning .. Silence clang -Waddress-of-packed-member warning macOS/clang 4.0 builds have become polluted

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/6636/15/src/kudu/fs/block_manager-test.cc File

[kudu-CR] KUDU-1853 (redux). tablet copy: Don't orphan blocks on failure

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1853 (redux). tablet copy: Don't orphan blocks on failure .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6733 To

[kudu-CR] env: add WriteV() API

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: env: add WriteV() API .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6800 To unsubscribe, visit

[kudu-CR] Fix bug in incorrect response rebuilding on tablet bootstrap

2017-05-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix bug in incorrect response rebuilding on tablet bootstrap .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/5489/4/src/kudu/tablet/row_op.cc

[kudu-CR] env: add WriteV() API

2017-05-04 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6800 to look at the new patch set (#4). Change subject: env: add WriteV() API .. env: add WriteV() API Adds WriteV()

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 14: (27 comments) I moved the definition of DataDirGroup back to the .h since it's used by one of

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-04 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#15). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952

[kudu-CR] Test for bug in exactly-once during tablet bootstrap

2017-05-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Test for bug in exactly-once during tablet bootstrap .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5417 To unsubscribe, visit

[kudu-CR] Test for bug in exactly-once during tablet bootstrap

2017-05-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Test for bug in exactly-once during tablet bootstrap .. Test for bug in exactly-once during tablet bootstrap Here's a regression test for the bug which

[kudu-CR] Rename TabletPeer to TabletReplica

2017-05-04 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Rename TabletPeer to TabletReplica .. Patch Set 1: I am not planning on fixing these tidy nits because this is mostly an automated patch and these are all

[kudu-CR] Silence clang -Waddress-of-packed-member warning

2017-05-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Silence clang -Waddress-of-packed-member warning .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6693 To unsubscribe, visit

[kudu-CR] [flaky tests] Address LSAN false positives

2017-05-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [flaky tests] Address LSAN false positives .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6320/3/src/kudu/util/striped64.cc File

[kudu-CR] KUDU-1970: node density integration test

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1970: node density integration test .. Patch Set 10: (4 comments)

[kudu-CR] env: add WriteV() API

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: env: add WriteV() API .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6800/3/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line

[kudu-CR] env: add WriteV() API

2017-05-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: env: add WriteV() API .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/6800/1/src/kudu/cfile/cfile_writer.cc File src/kudu/cfile/cfile_writer.cc:

[kudu-CR] env: add WriteV() API

2017-05-04 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6800 to look at the new patch set (#3). Change subject: env: add WriteV() API .. env: add WriteV() API Adds WriteV()

[kudu-CR](branch-1.3.x) KUDU-1964. security: avoid calling ERR clear error() defensively

2017-05-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6801 Change subject: KUDU-1964. security: avoid calling ERR_clear_error() defensively .. KUDU-1964. security: avoid calling ERR_clear_error()

[kudu-CR] env: add WriteV() API

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: env: add WriteV() API .. Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/6800/1/src/kudu/cfile/cfile_writer.cc File src/kudu/cfile/cfile_writer.cc:

[kudu-CR] env: add WriteV() API

2017-05-04 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6800 to look at the new patch set (#2). Change subject: env: add WriteV() API .. env: add WriteV() API Adds WriteV()

[kudu-CR] [util] introduced custom gflags validators

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] introduced custom gflags validators .. Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/6795/3//COMMIT_MSG Commit Message: Line 19: This

[kudu-CR] env: add WriteV() API

2017-05-04 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/6800 Change subject: env: add WriteV() API .. env: add WriteV() API Adds WriteV() methods to RWFile and WritableFile that allows writing

[kudu-CR] spark: add support for fault tolerant scanner

2017-05-04 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: spark: add support for fault tolerant scanner .. Patch Set 5: (2 comments)

[kudu-CR] spark: add support for fault tolerant scanner

2017-05-04 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6782 to look at the new patch set (#5). Change subject: spark: add support for fault tolerant scanner .. spark: add

[kudu-CR] [flaky tests] Address LSAN false positives

2017-05-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [flaky tests] Address LSAN false positives .. Patch Set 3: As stated in the commit message I couldn't repro this on dist-test after many tries. Still

[kudu-CR] [flaky tests] Address LSAN false positives

2017-05-04 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6320 to look at the new patch set (#3). Change subject: [flaky tests] Address LSAN false positives .. [flaky tests]

[kudu-CR] [util] introduced custom gflags validators

2017-05-04 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6795 to look at the new patch set (#3). Change subject: [util] introduced custom gflags validators .. [util] introduced

[kudu-CR] env: unify ReadV and Read code paths

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: env: unify ReadV and Read code paths .. env: unify ReadV and Read code paths Reduces similar and duplicate code by directing read calls to use the ReadV

[kudu-CR] env: unify ReadV and Read code paths

2017-05-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: env: unify ReadV and Read code paths .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6799 To unsubscribe, visit

  1   2   >