[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-23 Thread Hao Hao (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7701 to look at the new patch set (#4). Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. K

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit http

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit http://gerrit

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7701/1//COMMIT_MSG Commit Message: PS1, Line 11: sync

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-23 Thread Hao Hao (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7701 to look at the new patch set (#3). Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. K

[kudu-CR] KUDU-1894 fixed deadlock in client.Connection

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1894 fixed deadlock in client.Connection .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7765/4/java/kudu-client/src/main/java/org/apache/k

[kudu-CR] subprocess: even more robust fix for asynchronous signals

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: subprocess: even more robust fix for asynchronous signals .. subprocess: even more robust fix for asynchronous signals Another x1000 loop of raft_consensus

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/7701/1//COMMIT_MSG Commit Message: PS1, Line 9: into

[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy

2017-08-23 Thread Hao Hao (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7701 to look at the new patch set (#2). Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy .. K

[kudu-CR] KUDU-1894 fixed deadlock in client.Connection

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1894 fixed deadlock in client.Connection .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7765/4/java/kudu-client/src/main/java/org/apache/k

[kudu-CR] KUDU-2039 Fix the table count in the /tables page of master webUI

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-2039 Fix the table count in the /tables page of master webUI .. KUDU-2039 Fix the table count in the /tables page of master webUI The table count tha

[kudu-CR] KUDU-1894 fixed deadlock in client.Connection

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1894 fixed deadlock in client.Connection .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/7765/4/java/kudu-client/src/main/java/org/apache/

[kudu-CR] KUDU-1894 fixed deadlock in client.Connection

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#5). Change subject: KUDU-1894 fixed deadlock in client.Connection .. KUDU-1894 fixed deadlock in client.Connection Due to the reverse order of acquiring of the Connection.lock and som

[kudu-CR] disk failure: don't open tablets on failed disks

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: disk failure: don't open tablets on failed disks .. Patch Set 6: I retriggered this one too -- To view, visit http://gerrit.cloudera.org:8080/7766 To unsubscribe,

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: I retriggered the build -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit ht

[kudu-CR](branch-1.3.x) log block manager: use unsigned int for next block id

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: use unsigned int for next_block_id_ .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7798 To unsubscribe, visit h

[kudu-CR](branch-1.2.x) log block manager: use unsigned int for next block id

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: use unsigned int for next_block_id_ .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7799 To unsubscribe, visit h

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support tombstoned voting This patch makes it possible for tombstoned tablet replicas to vote in Raft ele

[kudu-CR](branch-1.4.x) log block manager: use unsigned int for next block id

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: use unsigned int for next_block_id_ .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7797 To unsubscribe, visit h

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 13: I did an analysis of failed raft_consensus-itest failures before and after this patch. There was no change in

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6960 To unsubscribe, visit http://gerrit.clou

[kudu-CR] [java] KUDU-2103 Canonicalize hostnames in client

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java] KUDU-2103 Canonicalize hostnames in client .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7757/4/java/kudu-client/src/test/java/org/apache

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: Failure seems to be a bunch of clock sync errors in DEBUG mode. -- To view, visit http://gerrit.cloude

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit http://ger

[kudu-CR] subprocess: even more robust fix for asynchronous signals

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: subprocess: even more robust fix for asynchronous signals .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7561 To unsubscribe, vis

[kudu-CR](branch-1.2.x) log block manager: use unsigned int for next block id

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7799 Change subject: log block manager: use unsigned int for next_block_id_ .. log block manager: use unsigned int for next_block_id_ KUDU-1538

[kudu-CR](branch-1.4.x) log block manager: use unsigned int for next block id

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7797 Change subject: log block manager: use unsigned int for next_block_id_ .. log block manager: use unsigned int for next_block_id_ KUDU-1538

[kudu-CR](branch-1.3.x) log block manager: use unsigned int for next block id

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7798 Change subject: log block manager: use unsigned int for next_block_id_ .. log block manager: use unsigned int for next_block_id_ KUDU-1538

[kudu-CR] KUDU-1894 fixed deadlock in client.Connection

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1894 fixed deadlock in client.Connection .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/7765/4/java/kudu-client/src/main/java/org/apache/ku

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit http://gerrit

[kudu-CR] disk failure: don't open tablets on failed disks

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: disk failure: don't open tablets on failed disks .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7766 To unsubscribe, visit http://

[kudu-CR] log block manager: use unsigned int for next block id

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: log block manager: use unsigned int for next_block_id_ .. log block manager: use unsigned int for next_block_id_ KUDU-1538 introduced 'next_block_id_' to k

[kudu-CR] subprocess: even more robust fix for asynchronous signals

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: subprocess: even more robust fix for asynchronous signals .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7561/6/src/kudu/util/subprocess-test.cc F

[kudu-CR] subprocess: even more robust fix for asynchronous signals

2017-08-23 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7561 to look at the new patch set (#7). Change subject: subprocess: even more robust fix for asynchronous signals .. sub

[kudu-CR] subprocess: even more robust fix for asynchronous signals

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: subprocess: even more robust fix for asynchronous signals .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7561/6/src/kudu/util/subprocess-test.cc

[kudu-CR] subprocess: even more robust fix for asynchronous signals

2017-08-23 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7561 to look at the new patch set (#6). Change subject: subprocess: even more robust fix for asynchronous signals .. sub

[kudu-CR] log block manager: use unsigned int for next block id

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: log block manager: use unsigned int for next_block_id_ .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7796 To unsubscribe, visit

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 30: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7207 To unsubscribe, visit http:/

[kudu-CR] Give more context on errors reading cfiles

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Give more context on errors reading cfiles .. Give more context on errors reading cfiles Recently, a user reported an error loading a tablet in which the

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 30: (1 comment) http://gerrit.cloudera.org:8080/#/c/7207/29/src/kudu/fs/log_block_manager.cc File src/ku

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-23 Thread Hao Hao (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#30). Change subject: KUDU-1943: Add BlockTransaction to Block Manager ..

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 29: (1 comment) http://gerrit.cloudera.org:8080/#/c/7207/29/src/kudu/fs/log_block_manager.cc File src

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/7784/5/src/kudu/fs/block_manager_util.cc File src/kudu

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 29: (3 comments) http://gerrit.cloudera.org:8080/#/c/7207/28/src/kudu/fs/log_block_manager.cc File src/k

[kudu-CR] disk failure: don't open tablets on failed disks

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: don't open tablets on failed disks .. Patch Set 5: (6 comments) I'm using a cluster verifier, but it doesn't quite work if you mix around the block

[kudu-CR] disk failure: don't open tablets on failed disks

2017-08-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7766 to look at the new patch set (#6). Change subject: disk failure: don't open tablets on failed disks .. disk failure

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7784 to look at the new patch set (#6). Change subject: open FS layout in presence of disk failure ..

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-23 Thread Hao Hao (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#29). Change subject: KUDU-1943: Add BlockTransaction to Block Manager ..

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/4/src/kudu/fs/block_manager_util.h File sr

[kudu-CR] log block manager: use unsigned int for next block id

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: use unsigned int for next_block_id_ .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7796 To unsubscribe, visit h

[kudu-CR] log block manager: use unsigned int for next block id

2017-08-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: log block manager: use unsigned int for next_block_id_ .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/7796/2//COMMIT_MSG Commit Message: PS2, Line

[kudu-CR] log block manager: use unsigned int for next block id

2017-08-23 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7796 to look at the new patch set (#3). Change subject: log block manager: use unsigned int for next_block_id_ .. log bl

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/5/src/kudu/fs/log_block_manager-test.cc File src

[kudu-CR] log block manager: use unsigned int for next block id

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: log block manager: use unsigned int for next_block_id_ .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7796/2/src/kudu/fs/log_block_manager.h Fi

[kudu-CR] add outputmetric collecting for the kudu data writing

2017-08-23 Thread caiconghui (Code Review)
caiconghui has posted comments on this change. Change subject: add outputmetric collecting for the kudu data writing .. Patch Set 1: @Kudu Jenkins, ok.I try to find the public api for collecting from spark, but failed. The sc

[kudu-CR] log block manager: use unsigned int for next block id

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: use unsigned int for next_block_id_ .. Patch Set 2: (1 comment) The test failures are unrelated; some test machine clocks are unsynchronized fo

[kudu-CR] log block manager: use unsigned int for next block id

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: log block manager: use unsigned int for next_block_id_ .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7796/2//COMMIT_MSG Commit Message: PS2,

[kudu-CR] gradle: target JRE 7 compatibility

2017-08-23 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: gradle: target JRE 7 compatibility .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7785/1/java/gradle/compile.gradle File java/gradle/compile.grad

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 13: Well, actually, let me hit raft_consensus-itest a little harder. It's possible that I made it flaky and hadn't

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 13: The new tests still look good. 100% reliable after 100 loops w/ TSAN + 8x stress: tombstoned_voting-itest: h

[kudu-CR] [cmake] introduce 'pb-gen' and 'krpc-gen' targets

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [cmake] introduce 'pb-gen' and 'krpc-gen' targets .. Patch Set 4: Verified+1 unrelated flake in AdminCliTest.TestMoveTablet -- To view, visit http://gerrit.cl

[kudu-CR] [cmake] introduce 'pb-gen' and 'krpc-gen' targets

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [cmake] introduce 'pb-gen' and 'krpc-gen' targets .. [cmake] introduce 'pb-gen' and 'krpc-gen' targets Introduced new targets to generate protobuf stubs

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7784/5/src/kudu/fs/block_manager_util.cc File src/ku

[kudu-CR] log block manager: use unsigned int for next block id

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: use unsigned int for next_block_id_ .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/7796/2//COMMIT_MSG Commit Message: PS2, Li

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit http://gerrit

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 28: (3 comments) http://gerrit.cloudera.org:8080/#/c/7207/28/src/kudu/fs/log_block_manager.cc File sr

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 13: > lgtm. Did you do any last test loop of the relevant tests after the > latest round of changes? Thanks for t

[kudu-CR] disk failure: don't open tablets on failed disks

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: disk failure: don't open tablets on failed disks .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/7766/4/src/kudu/integration-tests/disk_failure-it

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/4/src/kudu/fs/block_manager_util.h File src/kudu/fs

[kudu-CR] log block manager: use unsigned int for next block id

2017-08-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: log block manager: use unsigned int for next_block_id_ .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7796/1//COMMIT_MSG Commit Message: Line 14: i

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-23 Thread Hao Hao (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#28). Change subject: KUDU-1943: Add BlockTransaction to Block Manager ..

[kudu-CR] log block manager: use unsigned int for next block id

2017-08-23 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7796 to look at the new patch set (#2). Change subject: log block manager: use unsigned int for next_block_id_ .. log bl

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/4/src/kudu/fs/block_manager_util.h File sr

[kudu-CR](branch-1.3.x) [build-support] IWYU build configuration for Jenkins

2017-08-23 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [build-support] IWYU build configuration for Jenkins .. [build-support] IWYU build configuration for Jenkins In this branch, the IWYU target is jus

[kudu-CR](branch-1.4.x) [build-support] IWYU build configuration for Jenkins

2017-08-23 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [build-support] IWYU build configuration for Jenkins .. [build-support] IWYU build configuration for Jenkins In this branch, the IWYU target is jus

[kudu-CR](branch-1.3.x) [build-support] IWYU build configuration for Jenkins

2017-08-23 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [build-support] IWYU build configuration for Jenkins .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7779 To unsubscribe, v

[kudu-CR](branch-1.2.x) [build-support] IWYU build configuration for Jenkins

2017-08-23 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [build-support] IWYU build configuration for Jenkins .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7778 To unsubscribe, v

[kudu-CR](branch-1.4.x) [build-support] IWYU build configuration for Jenkins

2017-08-23 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [build-support] IWYU build configuration for Jenkins .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7780 To unsubscribe, v

[kudu-CR](branch-1.2.x) [build-support] IWYU build configuration for Jenkins

2017-08-23 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [build-support] IWYU build configuration for Jenkins .. [build-support] IWYU build configuration for Jenkins In this branch, the IWYU target is jus

[kudu-CR] disk failure: don't open tablets on failed disks

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: don't open tablets on failed disks .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7766/4/src/kudu/fs/file_block_manager.cc File sr

[kudu-CR] disk failure: don't open tablets on failed disks

2017-08-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7766 to look at the new patch set (#5). Change subject: disk failure: don't open tablets on failed disks .. disk failure

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: (16 comments) http://gerrit.cloudera.org:8080/#/c/7784/3//COMMIT_MSG Commit Message: PS3, Line 20: man

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7784 to look at the new patch set (#5). Change subject: open FS layout in presence of disk failure ..

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 13: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6960 To unsubscribe, visit http://gerrit.cl

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 13: Code-Review+1 lgtm. Did you do any last test loop of the relevant tests after the latest round of changes? -

[kudu-CR] [cmake] introduce 'pb-gen' and 'krpc-gen' targets

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [cmake] introduce 'pb-gen' and 'krpc-gen' targets .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/ To unsubscribe, visit http:/

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: Code-Review+1 Don't have anything to add to David/Mike's comments. -- To view, visit http://gerrit.clou

[kudu-CR] [cmake] introduce 'pb-gen' and 'krpc-gen' targets

2017-08-23 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/ to look at the new patch set (#4). Change subject: [cmake] introduce 'pb-gen' and 'krpc-gen' targets .. [cmake] int

[kudu-CR] Give more context on errors reading cfiles

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Give more context on errors reading cfiles .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7620 To unsubscribe, visit http://gerrit

[kudu-CR] server: fix crash when Shutdown is called before Init

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: server: fix crash when Shutdown is called before Init .. server: fix crash when Shutdown is called before Init This SIGSEGV suggests unconditional access t

[kudu-CR] log block manager: use unsigned int for next block id

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: use unsigned int for next_block_id_ .. Patch Set 1: (3 comments) I've been wondering whether this deserves a standalone test. I'm inclined to s

[kudu-CR] Give more context on errors reading cfiles

2017-08-23 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Andrew Wong, Grant Henke, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7620 to look at the new patch set (#2). Change subject: Give more context on errors reading cfiles ...

[kudu-CR] Revert "KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout"

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Revert "KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout" .. Patch Set 1: Code-Review+2 Going to just +2 this since it's a revert -- To view, v

[kudu-CR] Revert "KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout"

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Revert "KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout" .. Revert "KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout"

[kudu-CR] Revert "KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout"

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Revert "KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout" .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7788 To u

[kudu-CR] server: fix crash when Shutdown is called before Init

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: server: fix crash when Shutdown is called before Init .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7795 To unsubscribe, visit h

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/4/src/kudu/fs/block_manager_util.h Fi

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/3/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/f

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 3: (5 comments) A quick first pass http://gerrit.cloudera.org:8080/#/c/7784/3//COMMIT_MSG Commit Messag

[kudu-CR](branch-1.2.x) [build-support] IWYU build configuration for Jenkins

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [build-support] IWYU build configuration for Jenkins .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7778 To unsubscribe, visit htt

  1   2   >