Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6968
to look at the new patch set (#16).
Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric
...
Will Berkeley has posted comments on this change.
Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric
..
Patch Set 15:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6968/13/src/kudu/consensus/consensus_meta
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric
..
Patch Set 15:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6968/16/src/kudu/consensus/log-test.cc
Fi
Adar Dembo has posted comments on this change.
Change subject: Add a simple benchmark to create 1M blocks and reopen LBM
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8006/1/src/kudu/fs/log_block_manager-tes
Adar Dembo has posted comments on this change.
Change subject: ref_counted: fix move constructors to actually move
..
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8002/2/src/kudu/gutil/ref_counted
Adar Dembo has posted comments on this change.
Change subject: log_block_manager: switch from google::sparse_hash_map to
sparsepp
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8007/1//COMMIT_MSG
Commit Mess
Adar Dembo has posted comments on this change.
Change subject: log_block_manager: switch from google::sparse_hash_map to
sparsepp
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8007/1//COMMIT_MSG
Commit Messa
Adar Dembo has posted comments on this change.
Change subject: log_block_manager: use move semantics to fill in the block map
..
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8008/1/src/kudu/fs/log
Adar Dembo has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/env_posix.cc
File src/kudu/ut
Dan Burkert has posted comments on this change.
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Patch Set 3:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/7985/3/src/kudu/integr
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7985
to look at the new patch set (#4).
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Adar Dembo has posted comments on this change.
Change subject: WIP: pb_util: avoid repeated stat() calls reading files
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8010/1/src/kudu/util/pb_util.cc
File src/k
Adar Dembo has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/env_posix.cc
File src/kudu/uti
Dan Burkert has posted comments on this change.
Change subject: catalog_manager: various boring cleanup
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7990/2/src/kudu/master/catalog_manager.cc
File src/kudu/ma
Adar Dembo has posted comments on this change.
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7985/3/src
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7990
to look at the new patch set (#3).
Change subject: catalog_manager: various boring cleanup
..
catalog_manager: vari
Adar Dembo has posted comments on this change.
Change subject: catalog_manager: various boring cleanup
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7990/2/src/kudu/master/catalog_manager.cc
File src/kudu/mas
Dan Burkert has posted comments on this change.
Change subject: catalog_manager: fix unprotected data access in
TableInfo::AddRemoveTablets
..
Patch Set 1:
yikes. does this indicate a lack of test coverage around concurrent a
Dan Burkert has posted comments on this change.
Change subject: catalog_manager: fix unprotected data access in
TableInfo::AddRemoveTablets
..
Patch Set 1:
Code looks good.
--
To view, visit http://gerrit.cloudera.org:8080/7
Dan Burkert has posted comments on this change.
Change subject: catalog_manager: various boring cleanup
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7990/3/src/kudu/master/catalog_manager.cc
File src/kudu/ma
Dan Burkert has posted comments on this change.
Change subject: KUDU-2137: protect against concurrent schema version change and
tablet drop
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7996/2/src/kudu/maste
Dan Burkert has posted comments on this change.
Change subject: KUDU-2137: protect against concurrent schema version change and
tablet drop
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7996/2/src/kudu/maste
Dan Burkert has posted comments on this change.
Change subject: ref_counted: fix move constructors to actually move
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8002
To unsubscribe, visit htt
Adar Dembo has posted comments on this change.
Change subject: catalog_manager: fix unprotected data access in
TableInfo::AddRemoveTablets
..
Patch Set 2:
> yikes. does this indicate a lack of test coverage around
> concurre
Adar Dembo has posted comments on this change.
Change subject: KUDU-2137: protect against concurrent schema version change and
tablet drop
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7996/2/src/kudu/master
Dan Burkert has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 1:
I don't want to block merging this, but we might want to think about this is a
bigger context. Th
Adar Dembo has posted comments on this change.
Change subject: catalog_manager: various boring cleanup
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7990/3/src/kudu/master/catalog_manager.cc
File src/kudu/mas
Dan Burkert has posted comments on this change.
Change subject: Avoid a few allocations while reading PBC files
..
Patch Set 1:
gsl::span : std::vector
as
Slice (or gsl::string_span) : std::string
--
To view, visit http://g
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7996
to look at the new patch set (#3).
Change subject: KUDU-2137: protect against concurrent schema version change and
tablet drop
.
Dan Burkert has posted comments on this change.
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7985/3/src/kudu/integra
Dan Burkert has posted comments on this change.
Change subject: KUDU-2137: protect against concurrent schema version change and
tablet drop
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7996
Dan Burkert has posted comments on this change.
Change subject: catalog_manager: fix unprotected data access in
TableInfo::AddRemoveTablets
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7995
Dan Burkert has posted comments on this change.
Change subject: catalog_manager: fix unprotected data access in
TableInfo::AddRemoveTablets
..
Patch Set 2:
gotcha; sounds good.
--
To view, visit http://gerrit.cloudera.org:80
Dan Burkert has posted comments on this change.
Change subject: catalog_manager: various boring cleanup
..
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7990/3/src/kudu/master/catalog_manager.cc
Fi
Alexey Serbin has posted comments on this change.
Change subject: catalog_manager: fix unprotected data access in
TableInfo::AddRemoveTablets
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7995/2/src/kudu/uti
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7985
to look at the new patch set (#5).
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Alexey Serbin has posted comments on this change.
Change subject: catalog_manager: fix unprotected data access in
TableInfo::AddRemoveTablets
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7995/2/src/kudu/mas
Adar Dembo has posted comments on this change.
Change subject: catalog_manager: fix unprotected data access in
TableInfo::AddRemoveTablets
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7995/2/src/kudu/maste
Adar Dembo has posted comments on this change.
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7985
To
Dan Burkert has posted comments on this change.
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Patch Set 5: Verified+1
ignoring iwyu failure; looks wrong to me.
--
To view, visit
Adar Dembo has submitted this change and it was merged.
Change subject: catalog_manager: various boring cleanup
..
catalog_manager: various boring cleanup
Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
Reviewed-on: http:/
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7995
to look at the new patch set (#3).
Change subject: catalog_manager: fix unprotected data access in
TableInfo::AddRemoveTablets
...
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7995
to look at the new patch set (#4).
Change subject: catalog_manager: fix unprotected data access in
TableInfo::AddRemoveTablets
...
Hello Jean-Daniel Cryans, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8013
to review the following change.
Change subject: Update website for 1.5.0 release
..
Update website
Dan Burkert has posted comments on this change.
Change subject: KUDU-2137: protect against concurrent schema version change and
tablet drop
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7996
Dan Burkert has posted comments on this change.
Change subject: catalog_manager: fix unprotected data access in
TableInfo::AddRemoveTablets
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7995
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2137: protect against concurrent schema version change and
tablet drop
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/799
Alexey Serbin has posted comments on this change.
Change subject: catalog_manager: fix unprotected data access in
TableInfo::AddRemoveTablets
..
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7995/
Adar Dembo has submitted this change and it was merged.
Change subject: catalog_manager: fix unprotected data access in
TableInfo::AddRemoveTablets
..
catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets
Adar Dembo has submitted this change and it was merged.
Change subject: KUDU-2137: protect against concurrent schema version change and
tablet drop
..
KUDU-2137: protect against concurrent schema version change and tablet drop
Hello Mike Percy, Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8016
to review the following change.
Change subject: KUDU-2125: Tablet copy client does not retry on failures
..
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8017
Change subject: [tests] de-flaking catalog_manager_tsk-itest
..
[tests] de-flaking catalog_manager_tsk-itest
After recent updates the ca
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8016
to look at the new patch set (#2).
Change subject: KUDU-2125: Tablet copy client does not retry on failures
..
KUDU
Dan Burkert has posted comments on this change.
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Patch Set 6: Verified+1
ignore bogus iwyu
--
To view, visit http://gerrit.cloudera.
Dan Burkert has posted comments on this change.
Change subject: KUDU-2125: Tablet copy client does not retry on failures
..
Patch Set 2: Verified+1
bogus iwyu
--
To view, visit http://gerrit.cloudera.org:8080/8016
To unsubscr
Adar Dembo has posted comments on this change.
Change subject: [tests] de-flaking catalog_manager_tsk-itest
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8017/1//COMMIT_MSG
Commit Message:
Did you try loopi
Adar Dembo has posted comments on this change.
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7985
To
Alexey Serbin has posted comments on this change.
Change subject: [tests] de-flaking catalog_manager_tsk-itest
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8017/1//COMMIT_MSG
Commit Message:
> Did you try
Adar Dembo has posted comments on this change.
Change subject: KUDU-2125: Tablet copy client does not retry on failures
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8016/2/src/kudu/integration-tests/cluster
Alexey Serbin has posted comments on this change.
Change subject: [tests] de-flaking catalog_manager_tsk-itest
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8017/1/src/kudu/integration-tests/catalog_manager_t
Dan Burkert has posted comments on this change.
Change subject: KUDU-2125: Tablet copy client does not retry on failures
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8016/2/src/kudu/integration-tests/cluste
Dan Burkert has uploaded a new patch set (#3).
Change subject: KUDU-2125: Tablet copy client does not retry on failures
..
KUDU-2125: Tablet copy client does not retry on failures
Change-Id: I7c8454fc600a841bd15306a2b3b06ddf5313
Adar Dembo has posted comments on this change.
Change subject: KUDU-2125: Tablet copy client does not retry on failures
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8016/2/src/kudu/integration-tests/tablet_c
Dan Burkert has posted comments on this change.
Change subject: KUDU-2125: Tablet copy client does not retry on failures
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8016/2/src/kudu/integration-tests/tablet_
Hello Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7985
to look at the new patch set (#7).
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
Adar Dembo has posted comments on this change.
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7985
To
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8019
Change subject: KUDU-2141. master: Remove DCHECK when tablet report has no
opid_index
..
KUDU-2141. master: Remove DCHECK when tablet repor
Andrew Wong has posted comments on this change.
Change subject: [tests] de-flaking catalog_manager_tsk-itest
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8017/1/src/kudu/integration-tests/catalog_manager_ts
Adar Dembo has posted comments on this change.
Change subject: KUDU-2141. master: Remove DCHECK when tablet report has no
opid_index
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8019
To unsu
Andrew Wong has posted comments on this change.
Change subject: KUDU-2141. master: Remove DCHECK when tablet report has no
opid_index
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8019
To uns
Mike Percy has submitted this change and it was merged.
Change subject: KUDU-2141. master: Remove DCHECK when tablet report has no
opid_index
..
KUDU-2141. master: Remove DCHECK when tablet report has no opid_index
Commit 2108
71 matches
Mail list logo