[kudu-CR] client: avoid accessing state after scheduling retry

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12170 ) Change subject: client: avoid accessing state after scheduling retry .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] client: avoid accessing state after scheduling retry

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12170 ) Change subject: client: avoid accessing state after scheduling retry .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12

[kudu-CR] client: avoid accessing state after scheduling retry

Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12170 to look at the new patch set (#5). Change subject: client: avoid accessing state after scheduling retry

[kudu-CR] client: avoid accessing state after scheduling retry

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12170 ) Change subject: client: avoid accessing state after scheduling retry .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12

[kudu-CR] client: avoid accessing state after scheduling retry

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12170 ) Change subject: client: avoid accessing state after scheduling retry .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[kudu-CR] [docs] Add docs for rack/location-awareness

Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. [docs] Add docs for rack/location-awareness I stuck to the name

[kudu-CR] [docs] Add docs for rack/location-awareness

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] client: avoid accessing state after scheduling retry

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12170 ) Change subject: client: avoid accessing state after scheduling retry .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] client: avoid accessing state after scheduling retry

Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12170 to look at the new patch set (#4). Change subject: client: avoid accessing state after scheduling retry

[kudu-CR] client: avoid accessing state after scheduling retry

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12170 ) Change subject: client: avoid accessing state after scheduling retry .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12

[kudu-CR] generic iterators: assorted cleanup

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12156 ) Change subject: generic_iterators: assorted cleanup .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12156/4/src/kudu/c

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 18: Code-Review+2 -- To view, visit http://gerrit.cloudera

[kudu-CR] client: avoid accessing state after scheduling retry

Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12170 to look at the new patch set (#3). Change subject: client: avoid accessing state after scheduling retry

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#18). Change subject: KUDU-2636: LBM supports deleting dead containers

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/12075/17/s

[kudu-CR] generic iterators: prep for MergeIterator dominance

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12196 ) Change subject: generic_iterators: prep for MergeIterator dominance .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/121

[kudu-CR] generic iterators: basic MergeIterator dominance

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12197 ) Change subject: generic_iterators: basic MergeIterator dominance .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/12197

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/12075/

[kudu-CR] generic iterators: basic MergeIterator dominance

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12197 ) Change subject: generic_iterators: basic MergeIterator dominance .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12197/4

[kudu-CR] client: avoid KLOG EVERY N SECS with ScopedCleanup

Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12170 to look at the new patch set (#2). Change subject: client: avoid KLOG_EVERY_N_SECS with ScopedCleanup ..

[kudu-CR] generic iterators: move MergeIterState into the header

Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/12195 ) Change subject: generic_iterators: move MergeIterState into the header .. Abandoned Superceded by http://gerrit.cloudera.org:8080/12223 -- To view,

[kudu-CR] generic iterators: move MergeIterState into the header

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12195 ) Change subject: generic_iterators: move MergeIterState into the header .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] generic iterators: prep for MergeIterator dominance

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12196 ) Change subject: generic_iterators: prep for MergeIterator dominance .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/121

[kudu-CR] generic iterators: short-circuit MergeIterState::PullNextBlock

Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12157 to look at the new patch set (#8). Change subject: generic_iterators: short-circuit MergeIterState::PullNextBlock

[kudu-CR] switch all iterators to unique ptr

Hello Mike Percy, Grant Henke, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/1 to review the following change. Change subject: switch all iterators to unique_ptr .. switch

[kudu-CR] generic iterators: assorted cleanup

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12156 ) Change subject: generic_iterators: assorted cleanup .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/12156/3/src/kudu/co

[kudu-CR] generic iterators: assorted cleanup

Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12156 to look at the new patch set (#4). Change subject: generic_iterators: assorted cleanup ...

[kudu-CR] generic iterators: basic MergeIterator dominance

Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12197 to look at the new patch set (#5). Change subject: generic_iterators: basic MergeIterator dominance ..

[kudu-CR] generic iterators: short-circuit MergeIterState::PullNextBlock

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12157 ) Change subject: generic_iterators: short-circuit MergeIterState::PullNextBlock .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8

[kudu-CR] generic iterators: prep for MergeIterator dominance

Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12196 to look at the new patch set (#5). Change subject: generic_iterators: prep for MergeIterator dominance ...

[kudu-CR] generic iterators: move iterator declarations into cc file

Hello Mike Percy, Grant Henke, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12223 to review the following change. Change subject: generic_iterators: move iterator declarations into cc file ..

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#17). Change subject: KUDU-2636: LBM supports deleting dead containers

[kudu-CR] [docs] Add docs for rack/location-awareness

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12219/3/d

[kudu-CR] [docs] Add docs for rack/location-awareness

Hello Alexey Serbin, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12219 to look at the new patch set (#4). Change subject: [docs] Add docs for rack/location-awareness ...

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/12075/12/

[kudu-CR] [docs] Add docs for rack/location-awareness

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12219/2/do

[kudu-CR] [docs] Add docs for rack/location-awareness

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] [docs] Add docs for rack/location-awareness

Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. Removed reviewer Kudu Jenkins. -- To view, visit http://gerrit.c

[kudu-CR] [docs] Add docs for rack/location-awareness

Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12219 to look at the new patch set (#3). Change subject: [docs] Add docs for rack/location-awareness .

[kudu-CR] [docs] Add docs for rack/location-awareness

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/12219/1/

[kudu-CR] docs: Add Gerrit HTTP endpoint instructions

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12218 ) Change subject: docs: Add Gerrit HTTP endpoint instructions .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] [docs] Add docs for rack/location-awareness

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#

[kudu-CR] docs: Add Gerrit HTTP endpoint instructions

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12218 ) Change subject: docs: Add Gerrit HTTP endpoint instructions .. Patch Set 2: Updated the rendering noted in Patch Set 1 -- To view, visi

[kudu-CR] docs: Add Gerrit HTTP endpoint instructions

Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12218 to look at the new patch set (#2). Change subject: docs: Add Gerrit HTTP endpoint instructions .. docs:

[kudu-CR] docs: Add Gerrit HTTP endpoint instructions

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12218 ) Change subject: docs: Add Gerrit HTTP endpoint instructions .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/12218/1/doc

[kudu-CR] [scripts] Add initial test scripts for backup/restore testing

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12212 ) Change subject: [scripts] Add initial test scripts for backup/restore testing .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:80

[kudu-CR] [examples] a small update on SparkExample

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12208 ) Change subject: [examples] a small update on SparkExample .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] [docs] Add docs for rack/location-awareness

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/12219/2/do

[kudu-CR] [docs] Add docs for rack/location-awareness

Will Berkeley has removed a vote on this change. Change subject: [docs] Add docs for rack/location-awareness .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12219 To unsubscribe, vis

[kudu-CR] [docs] Add docs for rack/location-awareness

Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. Removed reviewer Kudu Jenkins. -- To view, visit http://gerrit.c

[kudu-CR] [docs] Add docs for rack/location-awareness

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/12219/1

[kudu-CR] [docs] Add docs for rack/location-awareness

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] [docs] Add docs for rack/location-awareness

Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12219 to look at the new patch set (#2). Change subject: [docs] Add docs for rack/location-awareness .

[kudu-CR] docs: Add Gerrit HTTP endpoint instructions

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12218 ) Change subject: docs: Add Gerrit HTTP endpoint instructions .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/12218/1/doc

[kudu-CR] [docs] Add docs for rack/location-awareness

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/12219/1/do

[kudu-CR] [docs] Add docs for rack/location-awareness

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. Patch Set 1: Verified+1 Docs-only change. -- To view, visit http://ge

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 16: > All the tests passed locally except ASAN. Failing on

[kudu-CR] [docs] Add docs for rack/location-awareness

Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12219 ) Change subject: [docs] Add docs for rack/location-awareness .. Removed reviewer Kudu Jenkins. -- To view, visit http://gerrit.c

[kudu-CR] [docs] Add docs for rack/location-awareness

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12219 Change subject: [docs] Add docs for rack/location-awareness .. [docs] Add docs for rack/location-awareness I stuck to the name "rack-aw

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 16: Code-Review+1 (2 comments) Just some minor nits. http://

[kudu-CR] docs: Add Gerrit HTTP endpoint instructions

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12218 ) Change subject: docs: Add Gerrit HTTP endpoint instructions .. Patch Set 1: Render: https://github.com/mpercy/kudu/blob/doc-gerrit-1/doc

[kudu-CR] docs: Add Gerrit HTTP endpoint instructions

Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12218 Change subject: docs: Add Gerrit HTTP endpoint instructions .. docs: Add Gerrit HTTP endpoint instructions Some users cannot use SSH to co

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 15: All the tests passed locally except ASAN. Failing on an unr

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#16). Change subject: KUDU-2636: LBM supports deleting dead containers

[kudu-CR] KUDU-2636: LBM supports deleting dead containers

helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead containers .. Patch Set 15: I'm sorry to have omitted this case! :( -- To view, visit