[kudu-CR] env: Add support for getting FS capacity

2017-03-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: env: Add support for getting FS capacity .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6255/1/src/kudu/util/env-test.cc

[kudu-CR] env: Add support for getting FS capacity

2017-03-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: env: Add support for getting FS capacity .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6255/1/src/kudu/util/env-test.cc File

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/6170/10//COMMIT_MSG Commit

[kudu-CR] KUDU-1905 - Allow reinserts on pk only tables

2017-03-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6258 to look at the new patch set (#4). Change subject: KUDU-1905 - Allow reinserts on pk only tables .. KUDU-1905 -

[kudu-CR] KUDU-1905 - Allow reinserts on pk only tables

2017-03-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1905 - Allow reinserts on pk only tables .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1905 - Allow reinserts on pk only tables

2017-03-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1905 - Allow reinserts on pk only tables .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6258/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] KUDU-1905 - Allow reinserts on pk only tables

2017-03-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6258 to look at the new patch set (#3). Change subject: KUDU-1905 - Allow reinserts on pk only tables .. KUDU-1905 -

[kudu-CR] KUDU-1905 - Allow reinserts on pk only tables

2017-03-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6258 to look at the new patch set (#2). Change subject: KUDU-1905 - Allow reinserts on pk only tables .. KUDU-1905 -

[kudu-CR] WIP: KUDU-1905 - Allow reinserts on pk only tables

2017-03-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6258 Change subject: WIP: KUDU-1905 - Allow reinserts on pk only tables .. WIP: KUDU-1905 - Allow reinserts on pk only tables Doing a

[kudu-CR](branch-1.2.x) KUDU-1893 Ensure evaluation of added columns

2017-03-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-1893 Ensure evaluation of added columns .. KUDU-1893 Ensure evaluation of added columns During a normal scan, a CFileIterator sets a flag to

[kudu-CR](branch-1.2.x) KUDU-1893 Ensure evaluation of added columns

2017-03-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6225 To unsubscribe, visit

[kudu-CR] [flaky tests] Allow for the master to take longer to start

2017-03-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: [flaky tests] Allow for the master to take longer to start .. [flaky tests] Allow for the master to take longer to start With the additional work

[kudu-CR] Make ExternalDaemon::StartProcess() handle fault injection

2017-03-02 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6211 to look at the new patch set (#6). Change subject: Make ExternalDaemon::StartProcess() handle fault injection ..

[kudu-CR] [flaky tests] Allow for the master to take longer to start

2017-03-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6230 Change subject: [flaky tests] Allow for the master to take longer to start .. [flaky tests] Allow for the master to take longer to

[kudu-CR] Make ExternalDaemon::StartProcess() handle fault injection

2017-03-02 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6211 to look at the new patch set (#4). Change subject: Make ExternalDaemon::StartProcess() handle fault injection ..

[kudu-CR] Make ExternalDaemon::StartProcess() handle fault injection

2017-03-02 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6211 to look at the new patch set (#5). Change subject: Make ExternalDaemon::StartProcess() handle fault injection ..

[kudu-CR] [ts recovery-itest] Reduce the number of rows written in TestChangeMaxCellSize

2017-03-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: [ts_recovery-itest] Reduce the number of rows written in TestChangeMaxCellSize .. [ts_recovery-itest] Reduce the number of rows written in

[kudu-CR] [ts recovery-itest] Reduce the number of rows written

2017-03-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6227 Change subject: [ts_recovery-itest] Reduce the number of rows written .. [ts_recovery-itest] Reduce the number of rows written

[kudu-CR] Make ExternalDaemon::StartProcess() handle fault injection

2017-03-02 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6211 to look at the new patch set (#3). Change subject: Make ExternalDaemon::StartProcess() handle fault injection ..

[kudu-CR] Make ExternalDaemon::StartProcess() handle fault injection

2017-03-02 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6211 to look at the new patch set (#2). Change subject: Make ExternalDaemon::StartProcess() handle fault injection ..

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-03-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-1893 Ensure evaluation of added columns .. KUDU-1893 Ensure evaluation of added columns During a normal scan, a CFileIterator sets a flag to

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-03-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/6129/8//COMMIT_MSG Commit Message: PS8,

[kudu-CR] WIP: Make ExternalDaemon::StartProcess() handle fault injection

2017-03-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6211 Change subject: WIP: Make ExternalDaemon::StartProcess() handle fault injection .. WIP: Make ExternalDaemon::StartProcess() handle

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-03-01 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080/#/c/6129/6/src/kudu/common/column_predicate.cc

[kudu-CR] [delete table-test] Disable log compression on some tests

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6200 Change subject: [delete_table-test] Disable log compression on some tests .. [delete_table-test] Disable log compression on some

[kudu-CR] [client-test] Reduce flakyness of TestWriteWithDeadTabletServer

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6198 Change subject: [client-test] Reduce flakyness of TestWriteWithDeadTabletServer .. [client-test] Reduce flakyness of

[kudu-CR] [delete table-test] Don't fail on multiple attempts to delete an orphaned tablet

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: [delete_table-test] Don't fail on multiple attempts to delete an orphaned tablet .. [delete_table-test] Don't fail on multiple attempts to delete an

[kudu-CR] [delete table-test] Don't fail on multiple attempts to delete an orphaned tablet

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6191 Change subject: [delete_table-test] Don't fail on multiple attempts to delete an orphaned tablet .. [delete_table-test] Don't

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 11: Code-Review+2 lgtm, assuming tests pass -- To view, visit

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6029 To unsubscribe, visit

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1904 Don't seek on empty RLE blocks .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6184/4/src/kudu/cfile/rle_block.h File

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1904 Don't seek on empty RLE blocks .. Patch Set 3: lgtm, just waiting for the commit that has coverage for this to +2 -- To view, visit

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1904 Don't seek on empty RLE blocks .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6184/2/src/kudu/cfile/rle_block.h File

[kudu-CR] Misc optimizations to BinaryPlainBlockDecoder

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Misc optimizations to BinaryPlainBlockDecoder .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6159 To unsubscribe, visit

[kudu-CR] Misc optimizations to BinaryPlainBlockDecoder

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Misc optimizations to BinaryPlainBlockDecoder .. Patch Set 4: doh! yeah, wrong rev. sorry about that -- To view, visit

[kudu-CR] Misc optimizations to BinaryPlainBlockDecoder

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Misc optimizations to BinaryPlainBlockDecoder .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6159/2/src/kudu/cfile/binary_plain_block.cc

[kudu-CR] Micro-optimizations to try to inline DeltaKey::DecodeFrom

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Micro-optimizations to try to inline DeltaKey::DecodeFrom .. Patch Set 3: Code-Review+2 (1 comment) tiny nit, feel free to +2 when you fix (or if my

[kudu-CR] [catalog manager] proper handling of catalog shutdown

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-1899. Fix support for empty string keys

2017-02-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1899. Fix support for empty string keys .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6163 To unsubscribe, visit

[kudu-CR] WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-02-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 1: (1 comment)

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

2017-02-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6134 To unsubscribe,

[kudu-CR] Micro-optimizations to try to inline DeltaKey::DecodeFrom

2017-02-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Micro-optimizations to try to inline DeltaKey::DecodeFrom .. Patch Set 1: (2 comments)

[kudu-CR] Misc optimizations to BinaryPlainBlockDecoder

2017-02-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Misc optimizations to BinaryPlainBlockDecoder .. Patch Set 2: (2 comments)

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

2017-02-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 4: (16 comments) http://gerrit.cloudera.org:8080/#/c/6134/4//COMMIT_MSG Commit Message:

[kudu-CR] WIP: [catalog manager] fixed deadlock on catalog shutdown

2017-02-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/6134/2//COMMIT_MSG Commit

[kudu-CR] WIP: [catalog manager] fixed deadlock on catalog shutdown

2017-02-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 2: could you post a failure trace in the commit message? -- To view, visit

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

2017-02-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 1: do you have a test that reproduces this bug? not saying we absolutely need it but it

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 20: Code-Review+2 (1 comment)

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6029/4/src/kudu/cfile/binary_dict_block.h File

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/cfile/cfile_reader.cc File

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 19: Code-Review+1 code lgtm, just waiting on those dist-test/cluster test

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/cfile/cfile_reader.cc File

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 18: (13 comments) http://gerrit.cloudera.org:8080/#/c/4363/18//COMMIT_MSG

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 17: (1 comment)

[kudu-CR] master: Do not acquire lock during CatalogManager::Init()

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: master: Do not acquire lock_ during CatalogManager::Init() .. Patch Set 4: Which follow up patch? Was this related to the "server-wide" op? Now that we

[kudu-CR] client-test-util: Increase ScanTableToStrings() timeout

2017-02-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: client-test-util: Increase ScanTableToStrings() timeout .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6104 To

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 16: (7 comments)

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 13: (11 comments)

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 12: (14 comments)

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 11: (2 comments)

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 9: (9 comments)

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. Patch Set 9: (23 comments) http://gerrit.cloudera.org:8080/#/c/4363/9//COMMIT_MSG Commit

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-16 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5965 to look at the new patch set (#8). Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 6: (1 comment)

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-16 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5965 to look at the new patch set (#7). Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type

[kudu-CR] [timestamp] Add a new TIMESTAMP NANOS type

2017-02-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#7). Change subject: [timestamp] Add a new TIMESTAMP_NANOS type .. [timestamp] Add a new TIMESTAMP_NANOS type This adds a new type to Kudu and adds the ability to use it in

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 6: (1 comment)

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 6: (1 comment)

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 6: (1 comment)

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 5: (7 comments)

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5965 to look at the new patch set (#6). Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type

[kudu-CR] [timestamp] Add a new TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TIMESTAMP_NANOS type .. Patch Set 6: Verified+1 unrelated flake RpcBench.BenchmarkCallsAsync -- To view, visit

[kudu-CR] Add a helper method to determine whether the OS is macOS to KuduTest

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a helper method to determine whether the OS is macOS to KuduTest .. Patch Set 3: Verified+1 unrelated flake -- To view, visit

[kudu-CR] [timestamp] Add a new TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5819 to look at the new patch set (#6). Change subject: [timestamp] Add a new TIMESTAMP_NANOS type .. [timestamp] Add a

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5965 to look at the new patch set (#5). Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 5: Verified+1 unrelated flake -- To view, visit

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 4: (3 comments)

[kudu-CR] Add a helper method to determine whether the OS is macOS to KuduTest

2017-02-14 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5981 to look at the new patch set (#3). Change subject: Add a helper method to determine whether the OS is macOS to KuduTest

[kudu-CR] Add a helper method to determine whether the OS is macOS to KuduTest

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a helper method to determine whether the OS is macOS to KuduTest .. Patch Set 1: (1 comment)

[kudu-CR] Add a helper method to determine whether the OS is macOS to KuduTest

2017-02-14 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5981 to look at the new patch set (#2). Change subject: Add a helper method to determine whether the OS is macOS to KuduTest

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. Patch Set 3: (16 comments)

[kudu-CR] [timestamp] Add a new TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TIMESTAMP_NANOS type .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/5819/3/src/kudu/client/schema.h File

[kudu-CR] [timestamp] Add a new TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5819 to look at the new patch set (#5). Change subject: [timestamp] Add a new TIMESTAMP_NANOS type .. [timestamp] Add a

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP NANOS type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#4). Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS type .. [timestamp] Add a new TimestampValue class to support the TIMESTAMP_NANOS

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP type

2017-02-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#3). Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP type .. [timestamp] Add a new TimestampValue class to support the TIMESTAMP type This

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5986/4/thirdparty/build-definitions.sh File

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5986/2/thirdparty/build-definitions.sh File

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP type

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP type .. Patch Set 2: Verified+1 unrelated java flake -- To view, visit

[kudu-CR] Refactor HybridClock and add a local clock mode

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Refactor HybridClock and add a local clock mode .. Patch Set 1: (1 comment) todd: just for internal tests and hidden + unsafe, yeah. mj: my problem with

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1870: Fix Boost build to respect CC/CXX .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5986/1/thirdparty/build-definitions.sh File

[kudu-CR] Refactor HybridClock and add a local clock mode

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Refactor HybridClock and add a local clock mode .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5982/1/src/kudu/server/hybrid_clock.cc

[kudu-CR] [timestamp] Add a new TIMESTAMP type

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Add a new TIMESTAMP type .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/5819/3/src/kudu/client/schema.h File

[kudu-CR] [timestamp] Add a new TIMESTAMP type

2017-02-13 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5819 to look at the new patch set (#4). Change subject: [timestamp] Add a new TIMESTAMP type .. [timestamp] Add a new

[kudu-CR] Refactor HybridClock and add a local clock mode

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5982 Change subject: Refactor HybridClock and add a local clock mode .. Refactor HybridClock and add a local clock mode Some test

[kudu-CR] Add a helper method to determine whether the OS is macOS to KuduTest

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5981 Change subject: Add a helper method to determine whether the OS is macOS to KuduTest .. Add a helper method to determine whether

[kudu-CR] WIP: Add a new TIMESTAMP type

2017-02-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: Add a new TIMESTAMP type .. Patch Set 3: (44 comments) Addressed all comments on the TimestampValue class (posted in another patch). Remaining

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP type

2017-02-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5965 Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP type .. [timestamp] Add a new TimestampValue

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 37: Code-Review+2 haven't actually tested this last rev on mac, assuming there weren't any new breakages

[kudu-CR] Add Google Breakpad support to Kudu

2017-02-07 Thread David Ribeiro Alves (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#34). Change subject: Add Google Breakpad support to Kudu ..

<    4   5   6   7   8   9   10   11   12   13   >