Re: Review Request 59105: Allowed leading zeros in input to stout's Version parser.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59105/ --- (Updated May 10, 2017, 4:08 a.m.) Review request for mesos and Benjamin

Review Request 59122: Cleaned up comments in stout's Version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59122/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 59067: Changed `#elif ...` to `#elif defined(...)` in Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59067/#review174414 --- Patch looks great! Reviews applied: [59067] Passed command:

Re: Review Request 59092: Added local resource provider driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59092/#review174404 --- include/mesos/v1/resource_provider.hpp Lines 39 (patched)

Re: Review Request 59101: Enabled authorization for v1 API call GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59101/#review174405 --- Patch looks great! Reviews applied: [58955, 58964, 59099, 59100,

Re: Review Request 59105: Allowed leading zeros in input to stout's Version parser.

> On May 10, 2017, 12:34 a.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/version.hpp > > Lines 53-57 (patched) > > > > > > Why move this comment down in this patch? Seems unrelated Well, I was

Re: Review Request 59105: Allowed leading zeros in input to stout's Version parser.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59105/#review174401 --- Fix it, then Ship it! Sorry, didn't see this until Adam pinged

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/ --- (Updated May 9, 2017, 11:59 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

> On May 9, 2017, 11:55 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > > Line 62 (original), 62 (patched) > > > > > > This is unnecessary? This comment is now on the `class

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/#review174391 --- Fix it, then Ship it! I can fix up the following the

Re: Review Request 59017: Added support for docker spec helper 'parseAuthConfig()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59017/#review174398 --- include/mesos/docker/spec.hpp Line 76 (original), 76 (patched)

Re: Review Request 59016: Fixed the comment style issue in docker/spec.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59016/#review174397 --- Ship it! Ship It! - Vinod Kone On May 4, 2017, 11:22 p.m.,

Re: Review Request 58967: Set the working directory to parent task's for DEBUG containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58967/#review174386 --- include/mesos/slave/containerizer.proto Lines 194 (patched)

Re: Review Request 58587: Clarified comments about resource operations through operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58587/ --- (Updated May 9, 2017, 3:29 p.m.) Review request for mesos, Anindya Sinha and

Re: Review Request 59114: Improved error reporting in status update manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59114/#review174385 --- Ship it! Ship It! - Vinod Kone On May 9, 2017, 10:11 p.m.,

Re: Review Request 58587: Clarified comments about resource operations through operator API.

> On May 2, 2017, 12:13 a.m., Michael Park wrote: > > src/master/http.cpp > > Lines 4884-4889 (patched) > > > > > > I'm not quite following this example. Specifically, I don't get what "a > > persistent volume can

Review Request 59114: Improved error reporting in status update manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59114/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 59110: Fixed `Version::validateIdentifier()` for Unicode edge case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59110/#review174382 --- Ship it! Ship It! - Neil Conway On May 9, 2017, 8:32 p.m.,

Re: Review Request 58587: Clarified comments about resource operations through operator API.

> On May 2, 2017, 12:13 a.m., Michael Park wrote: > > src/master/http.cpp > > Lines 4884-4889 (patched) > > > > > > I'm not quite following this example. Specifically, I don't get what "a > > persistent volume can

Re: Review Request 58821: Added a test that verifies a task and its check share the work dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58821/#review174378 --- src/tests/check_tests.cpp Lines 706-730 (patched)

Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58263/#review174376 --- Ship it! - Vinod Kone On May 9, 2017, 2:32 p.m., Alexander

Re: Review Request 59078: Fixed the MULTI_ROLE upgrade path for an old master and new agent.

> On May 9, 2017, 8:49 p.m., Michael Park wrote: > > src/slave/slave.cpp > > Line 4997 (original), 4997-4998 (patched) > > > > > > Maybe mention here that if the task does not have an allocation role, > > both

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58872/#review174374 --- Fix it, then Ship it! Before you commit this, it would be

Re: Review Request 59078: Fixed the MULTI_ROLE upgrade path for an old master and new agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59078/#review174372 --- Ship it! src/slave/slave.cpp Line 4997 (original), 4997-4998

Review Request 59110: Fixed `Version::validateIdentifier()` for Unicode edge case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59110/ --- Review request for mesos, Li Li and Neil Conway. Bugs: MESOS-7484

Review Request 59107: [WIP] Added extra debugging statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59107/ --- Review request for mesos. Repository: mesos Description --- Added extra

Review Request 59078: Fixed the MULTI_ROLE upgrade path for an old master and new agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59078/ --- Review request for mesos and Michael Park. Bugs: MESOS-7478

Review Request 59105: Allowed leading zeros in input to stout's Version parser.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59105/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7464

Re: Review Request 59097: Fixed flakiness in agent registration validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59097/#review174356 --- Ship it! Ship It! - James Peach On May 9, 2017, 6 p.m.,

Re: Review Request 59000: Added environment secret isolator.

> On May 8, 2017, 8:03 p.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 226 (patched) > > > > > > should this be "environment/secret" instead? i'm assuming there might > > be

Re: Review Request 58999: Added --secret_resolver flag to agent.

> On May 8, 2017, 8:05 p.m., Vinod Kone wrote: > > src/slave/main.cpp > > Line 450 (original), 463 (patched) > > > > > > If the pointer to resolver is only passed to the containerizer, how > > will the agent get

Re: Review Request 58999: Added --secret_resolver flag to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58999/ --- (Updated May 9, 2017, 2:11 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 59001: Added volume secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59001/ --- (Updated May 9, 2017, 2:11 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 59000: Added environment secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59000/ --- (Updated May 9, 2017, 2:11 p.m.) Review request for mesos, Gilbert Song, Greg

Re: Review Request 58760: Added default secret resolver module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58760/ --- (Updated May 9, 2017, 2:11 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58759: Introduced SecretResolver module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/ --- (Updated May 9, 2017, 2:10 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58263/#review174352 --- Ship it!

Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/ --- (Updated May 9, 2017, 6:08 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59097: Fixed flakiness in agent registration validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59097/ --- (Updated May 9, 2017, 6 p.m.) Review request for mesos, Jie Yu and James

Re: Review Request 52064: Support for multiple versions of docs.

> On May 9, 2017, 4:30 p.m., haosdent huang wrote: > > Hi, @tim Thanks a lot for your update. I am still reading you patch and > > have not finished. Could return my comments if it works at my side. Thanks > > a lot for your contributions. Thanks @haosdent, please let me know if you have any

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review174344 --- 3rdparty/libprocess/src/process.cpp Lines 955 (patched)

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review174335 --- Hi, @tim Thanks a lot for your update. I am still reading you

Review Request 59101: Enabled authorization for v1 API call GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59101/ --- Review request for mesos, Adam B and Greg Mann. Bugs: MESOS-7415

Review Request 59100: Enabled authorization for v1 API call GET_MAINTENANCE_SCHEDULE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59100/ --- Review request for mesos, Adam B and Greg Mann. Bugs: MESOS-7415

Re: Review Request 59099: Enabled authorization for v1 API call UPDATE_MAINTENANCE_SCHEDULE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59099/ --- (Updated May 9, 2017, 5:53 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 59099: Enabled authorization for v1 API call UPDATE_MAINTENANCE_SCHEDULE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59099/ --- (Updated May 9, 2017, 5:53 p.m.) Review request for mesos, Adam B and Greg

Review Request 59099: Enabled authorization for v1 API call UPDATE_MAINTENANCE_SCHEDULE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59099/ --- Review request for mesos, Adam B and Greg Mann. Bugs: MESOS-7415

Re: Review Request 59097: Fixed flakiness in agent registration validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59097/#review174327 --- This improves the reliability of this test on my normal dev

Re: Review Request 58964: Added authorization support for operator endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58964/ --- (Updated May 9, 2017, 5:48 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 58955: Adds authorization for the master's v1 API call SET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58955/ --- (Updated May 9, 2017, 5:43 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 59068: Updated release/versioning docs for "-dev" version scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59068/ --- (Updated May 9, 2017, 3:40 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 59068: Updated release/versioning docs for "-dev" version scheme.

> On May 8, 2017, 11:19 p.m., Vinod Kone wrote: > > docs/release-guide.md > > Lines 150 (patched) > > > > > > Shouldn't the release branch also have "-dev" suffix to indicate > > development of the next patch

Re: Review Request 58900: Changed the default fetcher cache directory.

> On May 8, 2017, 10:35 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp > > Lines 261 (patched) > > > > > > This patch is still missing cleanup for this directory. > > > > Before this patch,

Review Request 59097: Fixed flakiness in agent registration validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59097/ --- Review request for mesos, Jie Yu and James Peach. Bugs: MESOS-7441

Re: Review Request 58953: Added transitional allocator overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58953/#review174313 --- Ship it! Ship It! - Jan Schlicht On May 9, 2017, 4:46 p.m.,

Re: Review Request 59081: Updated master to use resource provider IDs in allocator calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59081/#review174311 --- Bad patch! Reviews applied: [59081, 58953, 58952, 58951, 58950,

Re: Review Request 59092: Added local resource provider driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59092/#review174305 --- include/mesos/v1/resource_provider.hpp Lines 37 (patched)

Re: Review Request 58953: Added transitional allocator overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58953/ --- (Updated May 9, 2017, 4:46 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 58952: Added test helper to disambiguate allocator method call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58952/ --- (Updated May 9, 2017, 4:46 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 58821: Added a test that verifies a task and its check share the work dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58821/ --- (Updated May 9, 2017, 2:32 p.m.) Review request for mesos, Gastón Kleiman, Jie

Re: Review Request 58818: Ensured DEBUG container shares MESOS_SANDBOX with its parent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58818/ --- (Updated May 9, 2017, 2:31 p.m.) Review request for mesos, Gastón Kleiman, Jie

Re: Review Request 58847: Checkpointed and recovered ContainerLaunchInfo for non-orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58847/ --- (Updated May 9, 2017, 2:31 p.m.) Review request for mesos, Gastón Kleiman, Jie

Re: Review Request 58967: Set the working directory to parent task's for DEBUG containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58967/ --- (Updated May 9, 2017, 2:32 p.m.) Review request for mesos, Gastón Kleiman, Jie

Re: Review Request 58718: Added a test that verifies a task's env var is seen by its check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58718/ --- (Updated May 9, 2017, 2:31 p.m.) Review request for mesos, Gastón Kleiman, Jie

Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58263/ --- (Updated May 9, 2017, 2:32 p.m.) Review request for mesos, Gastón Kleiman, Jie

Re: Review Request 58820: Explained how container working directory differs from its sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58820/ --- (Updated May 9, 2017, 2:31 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58819: Clarified the comment about Container.directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58819/ --- (Updated May 9, 2017, 2:31 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58262: Inherited environment from parent when launching a DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58262/ --- (Updated May 9, 2017, 2:31 p.m.) Review request for mesos, Gastón Kleiman, Jie

Re: Review Request 58817: Captured AgentID from the offer by reference in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58817/ --- (Updated May 9, 2017, 2:31 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 59094: Fixed an ordering style issue in automake file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59094/#review174304 --- Ship it! - Benjamin Bannier On May 9, 2017, 4:01 p.m., Jie

Review Request 59094: Fixed an ordering style issue in automake file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59094/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Repository: mesos

Review Request 59093: Added a general resource provider implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59093/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Bugs: MESOS-7480

Review Request 59092: Added local resource provider driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59092/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Bugs: MESOS-7469

Review Request 59091: Added resource provider protobufs to Java and Python bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59091/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Bugs: MESOS-7469

Re: Review Request 59083: Added resource provider actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59083/ --- (Updated May 9, 2017, 1:06 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 59083: Added resource provider actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59083/#review174301 --- Ship it! Ship It! - Jie Yu On May 9, 2017, 9:40 a.m., Jan

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review174294 --- Patch looks great! Reviews applied: [58719, 58720] Passed

Review Request 59090: Renabled some tests, fixed some errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59090/ --- Review request for mesos, Benjamin Mahler, Michael Park, and Neil Conway.

Review Request 59089: Changed hierarchical allocator to use QuotaTree.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59089/ --- Review request for mesos, Benjamin Mahler, Michael Park, and Neil Conway.

Review Request 59088: Implemented QuotaTree structure to be used by allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59088/ --- Review request for mesos, Benjamin Mahler, Michael Park, and Neil Conway.

Re: Review Request 59083: Added resource provider actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59083/ --- (Updated May 9, 2017, 11:40 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 59083: Added resource provider actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59083/ --- (Updated May 9, 2017, 11:37 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 59083: Added resource provider actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59083/#review174281 --- Can you update v1 API as well? - Jie Yu On May 9, 2017, 8:51

Re: Review Request 59012: Implemented passing the secret fetcher to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59012/#review174280 --- src/slave/containerizer/mesos/provisioner/provisioner.cpp Lines

Review Request 59083: Added resource provider actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59083/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Review Request 59082: Added provider ID to offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59082/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 58136: Cleaned up pattern matching in Resource operator==.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58136/#review174276 --- Ship it! Ship It! - Jie Yu On April 3, 2017, 7:57 a.m.,

Review Request 59081: Updated master to use resource provider IDs in allocator calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59081/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 58949: Introduced ResourceProviderInfo proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58949/#review174274 --- Ship it! Ship It! - Jan Schlicht On May 9, 2017, 9:58 a.m.,

Re: Review Request 58949: Introduced ResourceProviderInfo proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58949/ --- (Updated May 9, 2017, 9:58 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 59061: Fixed provisioner recover blockage by non-existing rootfses dir.

> On May 8, 2017, 8:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/paths.cpp > > Lines 210 (patched) > > > > > > Why `isdir`? not os::exists? > > Gilbert Song wrote: > Following the patern

Re: Review Request 59061: Fixed provisioner recover blockage by non-existing rootfses dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59061/#review174272 --- Ship it! Ship It! - Jie Yu On May 8, 2017, 7:51 p.m.,

Re: Review Request 59063: Changed `#elif ...` to `#elif defined(...)` in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59063/#review174271 --- Ship it! Ship It! - Jie Yu On May 8, 2017, 8:48 p.m.,

Re: Review Request 59015: Implemented passing docker config to URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/#review174270 --- As we discussed offline, let's not mess the URI struct. Instead,