---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75075/#review226629
---
Ship it!
Ship It!
- Benjamin Mahler
On July 2, 2024, 11:39
(patched)
<https://reviews.apache.org/r/75026/#comment314898>
might want to test some more cases here:
* allow all char devices but deny one?
- Benjamin Mahler
On June 3, 2024, 7:45 p.m., Jason Zhou
for
this variable to make sense here
Maybe instead we can just take in an argument of the deny block jump, and
this returns the size of the code generated (or maybe the caller can infer that
from
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75070/#review226624
---
Ship it!
Ship It!
- Benjamin Mahler
On July 2, 2024, 8:34
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75066/#review226623
---
Ship it!
Ship It!
- Benjamin Mahler
On July 2, 2024, 8:29
*"ubuntu"*"16.04"* ]]; then
CLANG_PKG=clang-3.5
else
CLANG_PKG=clang-10
fi
```
- Benjamin Mahler
On July 2, 2024, 8:09 p.m., Jason Zhou wrote:
>
> ---
> This is an automatical
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75063/#review226620
---
Ship it!
Ship It!
- Benjamin Mahler
On June 26, 2024, 10:18
tps://reviews.apache.org/r/75066/#comment314887>
do we still need this? does the comment need an update?
- Benjamin Mahler
On June 27, 2024, 2:06 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75062/#review226618
---
Ship it!
Ship It!
- Benjamin Mahler
On June 26, 2024, 10:34
tps://reviews.apache.org/r/75063/#comment314876>
this seems like something we should just fix?
I suppose this is a reasonable temporary workaround **if** we can't figure
out how to fix this quickly
- Benjamin Mahler
On June 25, 2024, 7:42 p.m., Jason Zhou
> On June 24, 2024, 6:31 p.m., Benjamin Mahler wrote:
> > support/mesos-build/entrypoint.sh
> > Lines 70 (patched)
> > <https://reviews.apache.org/r/75062/diff/1/?file=2289252#file2289252line70>
> >
> > hm.. is this supposed to be needed for dist
tps://reviews.apache.org/r/75063/#comment314863>
ditto here, mind commenting on why we are disabling java here?
- Benjamin Mahler
On June 24, 2024, 5:49 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail.
t
distcheck be performing what's missing that running `make` first solves?
- Benjamin Mahler
On June 24, 2024, 4:09 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
ing/link/link.cpp
Lines 342 (patched)
<https://reviews.apache.org/r/75057/#comment314846>
After multiple attempts to set the target MAC address, net::mac and ioctl
did not report the correct address
- Benjamin Mahler
On June 18, 2024, 8:51 p.m., Jason Zhou wrote:
>
> -
.
- Benjamin Mahler
On June 18, 2024, 11:15 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75058/
> --
ting/link/link.cpp
Lines 292-293 (patched)
<https://reviews.apache.org/r/75057/#comment314832>
ditto here, can we include the link name, the two mac addresses, and the
target mac address?
- Benjamin Mahler
On June 18, 2024, 8:5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75056/#review226569
---
Ship it!
Ship It!
- Benjamin Mahler
On June 18, 2024, 8:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75046/#review226538
---
Ship it!
Ship It!
- Benjamin Mahler
On June 12, 2024, 12:46
)
<https://reviews.apache.org/r/75046/#comment314778>
what about this one and the one in diagnosis.cpp?
- Benjamin Mahler
On June 11, 2024, 10:59 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75044/#review226535
---
Ship it!
Ship It!
- Benjamin Mahler
On June 10, 2024, 10:40
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75043/#review226534
---
Ship it!
Ship It!
- Benjamin Mahler
On June 10, 2024, 10:40
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75042/#review226533
---
Ship it!
Ship It!
- Benjamin Mahler
On June 10, 2024, 3:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75038/#review226528
---
Ship it!
Ship It!
- Benjamin Mahler
On June 7, 2024, 8:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75037/#review226526
---
Ship it!
Ship It!
- Benjamin Mahler
On June 7, 2024, 6:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75036/#review226527
---
Ship it!
Ship It!
- Benjamin Mahler
On June 7, 2024, 6:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75035/#review226525
---
Ship it!
Ship It!
- Benjamin Mahler
On June 6, 2024, 11:08
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75032/#review226521
---
Ship it!
Ship It!
- Benjamin Mahler
On June 6, 2024, 12:47
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75031/#review226514
---
Ship it!
- Benjamin Mahler
On June 5, 2024, 11:25 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75030/#review226513
---
Ship it!
Ship It!
- Benjamin Mahler
On June 5, 2024, 2:44
)
<https://reviews.apache.org/r/75029/#comment314764>
nit: trailing whitespace
- Benjamin Mahler
On June 5, 2024, 2:42 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75028/#review226509
---
Ship it!
Ship It!
- Benjamin Mahler
On June 4, 2024, 3:23
26 (patched)
<https://reviews.apache.org/r/75027/#comment314760>
Probably helps to document what this is for? I will land it as is without
it but please follow up with a patch that adds a comment :)
- Benjamin Mahler
On June 4, 2024, 3:22 p.m., Jason Zhou
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75023/#review226507
---
Ship it!
Ship It!
- Benjamin Mahler
On June 3, 2024, 9:48
)
<https://reviews.apache.org/r/75023/#comment314759>
stale?
- Benjamin Mahler
On May 30, 2024, 11:33 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75021/#review226496
---
Ship it!
Ship It!
- Benjamin Mahler
On May 29, 2024, 10:37
eserve the indentation here (4 space wrap)
- Benjamin Mahler
On May 29, 2024, 10:37 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75020/#review226493
---
Ship it!
Ship It!
- Benjamin Mahler
On May 29, 2024, 8:09
nes 26-27 (patched)
<https://reviews.apache.org/r/75006/#comment314685>
s/Map//
s/`_map`//
maybe CgroupsDeviceAccess and device_access_per_cgroup?
That way you have CgroupDeviceAccess (singular) and CgroupsDeviceAccess
(plural)
- Benjamin Mahler
On May 22, 2024, 8:2
after all? Looks more
python related?
- Benjamin Mahler
On May 29, 2024, 3:37 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75010/#review226486
---
Ship it!
Ship It!
- Benjamin Mahler
On May 23, 2024, 3:24
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75009/#review226485
---
Ship it!
Ship It!
- Benjamin Mahler
On May 23, 2024, 3:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75011/#review226484
---
Ship it!
Ship It!
- Benjamin Mahler
On May 23, 2024, 4:02
ps://reviews.apache.org/r/74998/#comment314677>
nit: keep open and close quotes on the same line
src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp
Lines 241 (patched)
<https://reviews.apache.org/r/74998/#comment314679>
nit: double newline?
- Benjamin Mahler
On Ma
ithout the
wrapping :)
src/slave/containerizer/mesos/isolators/cgroups2/controllers/perf_event.cpp
Lines 89 (patched)
<https://reviews.apache.org/r/74997/#comment314674>
nit: double newline between top level definitions in a file
- Benjamin Mahler
On May 17, 2024, 6:01 p.m., Jaso
//reviews.apache.org/r/74981/#comment314672>
nit: 4 space indent on parens wrapping
- Benjamin Mahler
On May 17, 2024, 9:46 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&g
10 (original), 810 (patched)
<https://reviews.apache.org/r/74981/#comment314664>
nit: indentation is off now
- Benjamin Mahler
On May 17, 2024, 8:43 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated
this in to the code as well for
posterity.
- Benjamin Mahler
On May 16, 2024, 11:45 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74994/#review226458
---
Ship it!
Ship It!
- Benjamin Mahler
On May 16, 2024, 3:07
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74993/#review226457
---
Ship it!
Ship It!
- Benjamin Mahler
On May 16, 2024, 3:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74989/#review226456
---
Ship it!
Ship It!
- Benjamin Mahler
On May 14, 2024, 9:58
)
<https://reviews.apache.org/r/74991/#comment314662>
nit: end with period
- Benjamin Mahler
On May 15, 2024, 1:07 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74992/#review226454
---
Ship it!
Ship It!
- Benjamin Mahler
On May 15, 2024, 9:19
, looks like the
comments aren't quite the same across the two
src/linux/cgroups2.hpp
Lines 301-302 (patched)
<https://reviews.apache.org/r/74985/#comment314660>
missing the .cpp change here? also feel free to pull this out in front as a
separate patch?
- Benjamin Mahler
On May 14
ine at end of file
+} // namespace mesos {
```
src/slave/containerizer/mesos/isolators/cgroups2/controllers/memory.cpp
Lines 280 (patched)
<https://reviews.apache.org/r/74979/#comment314659>
nit: extra whitespace here and below (you probably want to update your code
ed
etter explain what cache represents
src/slave/containerizer/mesos/isolators/cgroups2/controllers/memory.cpp
Lines 229-236 (patched)
<https://reviews.apache.org/r/74985/#comment314641>
Looks like this should be coming from memory.stat's unevictable stat
instead?
- Benjamin Mahler
On May 1
/#comment314637>
ditto here, need to handle missing hard limit
- Benjamin Mahler
On May 10, 2024, 10:21 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
testing and found that the
stat file reports hierarchical information. I'll add that prior to committing.
- Benjamin Mahler
On May 10, 2024, 10:48 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74984/#review226433
---
Ship it!
Ship It!
- Benjamin Mahler
On May 13, 2024, 2:43
-format was inconsistent
with the rest of our conventions.
- Benjamin Mahler
On March 7, 2024, 11:14 p.m., Devin Leamy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74910/#review226297
---
Ship it!
Ship It!
- Benjamin Mahler
On March 7, 2024, 3:07
gt; ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74919/
> ---
>
> (Updated Feb. 29, 2024, 11:14 p.m.)
>
&g
style
guidelines / conventions, but you can try it out going forward on lines you
edit specifically. This will need a significant rebase though against what I
committed
going forward just use it on lines you've edited, and I can make any style
tweaks as needed when landing
- Benjamin Mahler
se below with the other Try
src/tests/containerizer/cgroups2_tests.cpp
Lines 45 (patched)
<https://reviews.apache.org/r/74875/#comment314511>
hm.. not sure if we want the test to be mounting it, but let's keep it for
now and r
tps://reviews.apache.org/r/74874/#comment314499>
do we need these in the header? (i.e. available to callers as part of the
interface?)
src/linux/cgroups2.cpp
Lines 131-132 (original), 152-153 (patched)
<https://reviews.apache.org/r/74874/#comment314498>
whoops?
- Benjamin Mahler
On F
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74873/#review226256
---
Ship it!
Ship It!
- Benjamin Mahler
On Feb. 26, 2024, 10:12
/ Checks if the cgroup2 file systems is mounted at /sys/fs/cgroup.
-Try mounted_at_root();
-
-// Checks if the cgroup2 file systems is mounted.
+// Checks if the cgroup2 file systems is mounted at /sys/fs/cgroup,
+// returns an error if the mount is found at an unexpected location.
Try mounted();
> On Feb. 20, 2024, 4:43 a.m., Benjamin Mahler wrote:
> > src/linux/cgroups2.hpp
> > Lines 83-96 (patched)
> > <https://reviews.apache.org/r/74874/diff/1/?file=2285175#file2285175line83>
> >
> > hm.. this doesn't seem needed? the below can just be:
tps://reviews.apache.org/r/74871/#comment314495>
nit: remove the extra newline here?
src/tests/environment.cpp
Lines 233-245 (patched)
<https://reviews.apache.org/r/74871/#comment314496>
hm.. if `__linux__` this is always returning false..?
- Benjamin Mahler
On Feb. 27, 2024, 5:31
POINT
src/linux/cgroups2.cpp
Lines 47 (patched)
<https://reviews.apache.org/r/74872/#comment314493>
nit: brace on the next line on functions like this, I missed it for
enabled() so feel free to fix that here too :)
- Benjamin Mahler
On Feb. 26, 2024, 10:12
d)
<https://reviews.apache.org/r/74871/#comment314489>
nbd, but this could be `*user == "root"`
- Benjamin Mahler
On Feb. 27, 2024, 2:52 p.m., Devin Leamy wrote:
>
> ---
> This is an automatically generate
https://github.com/apache/mesos/blob/1.11.0/src/tests/environment.cpp#L162-L219
- Benjamin Mahler
On Feb. 26, 2024, 10:12 p.m., Devin Leamy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74870/#review226238
---
Ship it!
Ship It!
- Benjamin Mahler
On Feb. 26, 2024, 7:18
t, cgroup, control),
value);
```
- Benjamin Mahler
On Feb. 12, 2024, 5:05 p.m., Devin Leamy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
tps://reviews.apache.org/r/74873/#comment314470>
hm.. it doesn't seem like the caller needs to know about these, can you put
them in the .cpp file?
- Benjamin Mahler
On Feb. 12, 2024, 5:04 p.m., Devin Leamy wrote:
>
> ---
> This is a
d-only locating of the
mount if you only want to detect and use the existing one on the system.
- Benjamin Mahler
On Feb. 12, 2024, 5:04 p.m., Devin Leamy wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
em only when
we need them (as a general rule)
src/tests/containerizer/cgroups2_tests.cpp
Lines 32 (patched)
<https://reviews.apache.org/r/74871/#comment314464>
maybe your editor can automatically strip trailing whitespace?
- Benjamin Mahler
On Feb. 12, 2024, 5:02 p.m.,
4 (patched)
<https://reviews.apache.org/r/74870/#comment314462>
you could use `*supported` instead of .get(), which seems a bit more
readable (we didn't have the star operator when the cgroups v1 code was added)
- Benjamin Mahler
On Feb. 12, 2024, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74869/#review226220
---
Ship it!
Ship It!
- Benjamin Mahler
On Feb. 12, 2024, 4:59
PROCESS_LIBEV_NUM_IO_THREADS=1
$ make check -j16 TEST_DRIVER=""
GTEST_FILTER="-ProcessRemoteLinkTest.RemoteLinkLeak"
LIBPROCESS_LIBEV_NUM_IO_THREADS=32
```
Will follow up with some test(s) that leverage the reinitialize support in
libprocess, so that the testing doesn't need to be done manually.
Thanks,
Benjamin Mahler
_IO_THREADS=1
$ make check -j16 TEST_DRIVER=""
GTEST_FILTER="-ProcessRemoteLinkTest.RemoteLinkLeak"
LIBPROCESS_LIBEV_NUM_IO_THREADS=32
```
Will follow up with some test(s) that leverage the reinitialize support in
libprocess, so that the testing doesn't need to be done manually.
Thanks,
Benjamin Mahler
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73136/#review222475
---
On Jan. 12, 2021, 7:22 p.m., Benjamin Mahler wrote:
>
> ---
/
Changes: https://reviews.apache.org/r/73137/diff/1-2/
Testing
---
make check
Thanks,
Benjamin Mahler
-null but deleted
Since these live beyond the call to stop() finishing
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73137/#review222464
--------
e since we're just waiting for mark after.
- Benjamin Mahler
On Jan. 12, 2021, 1:23 a.m., Ilya Pronin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
=32
```
Will follow up with some test(s) that leverage the reinitialize support in
libprocess, so that the testing doesn't need to be done manually.
Thanks,
Benjamin Mahler
, since those need to be dynamic loops as well.
Diffs
-
3rdparty/libprocess/src/posix/libev/libev.cpp
b38e7a0f882a8c24950bdc6fd74a4d25fc68549e
Diff: https://reviews.apache.org/r/73137/diff/1/
Testing
---
make check
Thanks,
Benjamin Mahler
b38e7a0f882a8c24950bdc6fd74a4d25fc68549e
Diff: https://reviews.apache.org/r/73135/diff/1/
Testing
---
make check
Thanks,
Benjamin Mahler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72709/#review222064
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 4, 2020, 4:30
s 706 (patched)
<https://reviews.apache.org/r/72956/#comment311128>
could just use `foreachkey (`
```
foreachkey (const string& role, offerConstraints.role_constraints()) {
}
```
- Benjamin Mahler
On Oct. 14, 2020, 6:
don't know if we need the quotes here, since we're not showing a string
field:
`Suppressed roles {"foo", "bar"} are not ...`
- Benjamin Mahler
On Oct. 14, 2020, 6:16 p.m., Andrei Sekretenko wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72964/#review222058
---
Ship it!
Ship It!
- Benjamin Mahler
On Oct. 14, 2020, 6:20
)
<https://reviews.apache.org/r/72956/#comment30>
Ditto here from the last review, shouldn't this go into the validation.hpp
existing stateless validation?
- Benjamin Mahler
On Oct. 12, 2020, 8:15 p.m., Andrei Sekretenko
m.. shouldn't this stateless FrameworkInfo validation go in the existing
`validation::framework::valdiate(const FrameworkInfo&)` function in
master/validation.hpp?
- Benjamin Mahler
On Oct. 12, 2020, 8:
it. If we don't have a
solid answer, perhaps just add a TODO to figure out what we should do with it?
- Benjamin Mahler
On Oct. 13, 2020, 1:39 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To rep
3311 (patched)
<https://reviews.apache.org/r/72954/#comment311099>
for (
- Benjamin Mahler
On Oct. 12, 2020, 2:16 p.m., Andrei Sekretenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72953/#review222026
---
Ship it!
Ship It!
- Benjamin Mahler
On Oct. 12, 2020, 2:17
oaches:
* Ignore all non-device files, or
* Ignore `nvidia-caps` specifically, since we probably want to know in the
future if there's some other non device stuff getting added
- Benjamin Mahler
On Oct. 12, 2020, 1:50 a.m., Qian Zhang
che.org/r/72922/#comment311060>
Use javadoc style here? maybe make this clear that it's a note for us and
not the user looking at the interface?
- Benjamin Mahler
On Oct. 1, 2020, 2:01 p.m., Andrei Sekr
pache.org/r/72900/#comment311022>
The suppressed roles collection is gone now? (Not sure if it was specified
right originally)
- Benjamin Mahler
On Sept. 22, 2020, 6:09 p.m., Andrei Sekretenko wrote:
>
> ---
> Thi
), 367-369 (patched)
<https://reviews.apache.org/r/72874/#comment311020>
Note that this is the first rvalue reference in the driver interface. Which
is largely because we weren't yet on C++11 when most of this interface was
written.
- Benjamin Mahler
On Sept. 22, 2020, 5:57 p.m.,
1 - 100 of 2546 matches
Mail list logo
