On Thu, 11 Mar 2010 18:42:00 +1100, Minh Nguyen nguyenmi...@gmail.com wrote:
Third, in many cases, one can open a new ticket to improve the changes
introduced by a patch from an existing ticket. In such cases, I think
one can suggest this option to the patch author and leave it to them
to
On Mar 11, 2010, at 12:04 AM, Alex Ghitza wrote:
On Thu, 11 Mar 2010 18:42:00 +1100, Minh Nguyen
nguyenmi...@gmail.com wrote:
Third, in many cases, one can open a new ticket to improve the
changes
introduced by a patch from an existing ticket. In such cases, I think
one can suggest this
Robert Bradshaw wrote:
On Mar 11, 2010, at 12:04 AM, Alex Ghitza wrote:
On Thu, 11 Mar 2010 18:42:00 +1100, Minh Nguyen
nguyenmi...@gmail.com wrote:
Third, in many cases, one can open a new ticket to improve the changes
introduced by a patch from an existing ticket. In such cases, I think
one
Minh Nguyen wrote:
Hi Dima,
2) eventually, in order to prevent these things getting personal, it
might be good to have a possibility to anonymise reviewing.
Most of the time, reviewers are also people who contribute a lot to
improving a patch. We don't want make such contributors anonymous,
Alex Ghitza wrote:
On Thu, 11 Mar 2010 18:42:00 +1100, Minh Nguyen nguyenmi...@gmail.com wrote:
Third, in many cases, one can open a new ticket to improve the changes
introduced by a patch from an existing ticket. In such cases, I think
one can suggest this option to the patch author and leave
Hi
While you are at it,
To add a small epsilon to Minh's comments: it is fairly common for a
reviewer to add a small reviewer patch fixing docstrings or adding some
examples, etc. This could be a good alternative to getting frustrated
with the author for not making these changes
On Mar 11, 2010, at 4:41 AM, Florent Hivert wrote:
Hi
While you are at it,
To add a small epsilon to Minh's comments: it is fairly common for a
reviewer to add a small reviewer patch fixing docstrings or adding
some
examples, etc. This could be a good alternative to getting
Dear all,
I recently had a rather unpleasant experience reviewing a ticket that
shall remain unnamed. It went as follows. I suggested few
improvements, asked few questions. Some suggestions were implemented,
some plainly ignored, along with questions. I suggested few more
improvements, asked (and
On Wed, Mar 10, 2010 at 10:10 PM, Dima Pasechnik dimp...@gmail.com wrote:
Dear all,
I recently had a rather unpleasant experience reviewing a ticket that
shall remain unnamed. It went as follows. I suggested few
Given that sentence it is trivial to figure out what ticket you're
talking about:
Hi Dima,
On Thu, Mar 11, 2010 at 5:10 PM, Dima Pasechnik dimp...@gmail.com wrote:
SNIP
1) it would we good to have a moderator who can step in in such
cases.
Communication within any open source project is bound to be archived
somewhere on the Internet. Contributors need to realize that any
10 matches
Mail list logo
