On Sun, Nov 21, 2010 at 1:09 PM, Aaron S. Meurer wrote:
> You forgot to fix the whitespace (but don't worry, I just pushed in a fix).
Thanks!
Ondrej
--
You received this message because you are subscribed to the Google Groups
"sympy-patches" group.
To post to this group, send email to sympy-p
Hi Andre!
On Sun, Nov 21, 2010 at 10:23 AM, Andre de Fortier Smit
wrote:
> ---
> sympy/matrices/matrices.py | 26 --
> 1 files changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/sympy/matrices/matrices.py b/sympy/matrices/matrices.py
> index eb83faa..cc4491a 100
Cool. I like that we filter issues with a patch to this list. That
makes it easy for me to keep following it.
I think that's a good model, that issues with code, and pull request
get sent here, so that they get wider attention.
Ondrej
--
You received this message because you are subscribed to
On Sun, Oct 24, 2010 at 11:34 AM, Aaron S. Meurer wrote:
> Can you add sy...@googlecode.com to this list too? I actually set it up in
> Google Code a long time ago to send updates to this list whenever someone
> adds the NeedsReview tag to an issue, but it won't work unless that address
> can
Hi,
I have created an account sympy-notification
http://github.com/sympy-notification
and added it to the sympy group, so that whenever someone sends a pull
request, we get an email here into sympy-patches.
Ondrej
--
You received this message because you are subscribed to the Google Groups
"
On Wed, Oct 13, 2010 at 8:44 AM, Nicholas Kinar wrote:
>
>>> From 673c2059bfa95f3d85f93004c21de54ca56f9e06 Mon Sep 17 00:00:00 2001
>>> From: Nicholas J.S. Kinar
>>> Date: Tue, 12 Oct 2010 21:39:32 -0600
>>> Subject: [PATCH 1/1] Add note to the gotchas showing that expressions in
>>> sympy are im
On Tue, Oct 12, 2010 at 8:42 PM, Nicholas Kinar wrote:
> From 673c2059bfa95f3d85f93004c21de54ca56f9e06 Mon Sep 17 00:00:00 2001
> From: Nicholas J.S. Kinar
> Date: Tue, 12 Oct 2010 21:39:32 -0600
> Subject: [PATCH 1/1] Add note to the gotchas showing that expressions in
> sympy are immutable
>
>
Thanks Andy!
Ondrej
On Wed, Sep 29, 2010 at 7:27 AM, Andy Ray Terrel wrote:
> Okay this has been pushed in.
>
> On Thu, Sep 23, 2010 at 9:08 PM, Ondrej Certik wrote:
>> Hi,
>>
>> can you please test this pull request:
>>
>> http://github.com/sympy/sym
Hi,
can you please test this pull request:
http://github.com/sympy/sympy/pull/5
and give it some review?
It's a big chunk of code, so I would like more people to review it.
Just write your comments into the github's pull request and if you
agree with pushing this in, as it is.
Thanks,
Ondrej
On Fri, Sep 3, 2010 at 3:50 PM, Aaron S. Meurer wrote:
> On Sep 3, 2010, at 4:21 PM, Ondrej Certik wrote:
>
>> Hi,
>>
>> I have pushed this in, so the blame goes to my head. Some comments:
>>
>> On Fri, Sep 3, 2010 at 10:16 AM, Christian Muise
>>
Hi,
I have pushed this in, so the blame goes to my head. Some comments:
On Fri, Sep 3, 2010 at 10:16 AM, Christian Muise
wrote:
>> This is indeed very strange. According to issue 2046 (and my own
>> bisecting as well) it comes from this commit:
>>
>> commit dcbc2da31324e98c9cb3a4bf17c50f029774a
On Wed, Aug 11, 2010 at 8:39 PM, Ondrej Certik wrote:
> On Wed, Aug 11, 2010 at 3:53 PM, Brian Granger wrote:
>>
>>
>> On Wed, Aug 11, 2010 at 3:35 PM, Ondrej Certik wrote:
>>>
>>> On Wed, Aug 11, 2010 at 3:33 PM, Ondrej Certik wrote:
>>> >
On Wed, Aug 18, 2010 at 3:04 PM, Aaron S. Meurer wrote:
>
> On Aug 18, 2010, at 3:29 PM, Brian Granger wrote:
>
>> On Wed, Aug 18, 2010 at 2:22 PM, Ondrej Certik wrote:
>>> Hi Brian, Matt and Addison,
>>>
>>> I think the discussion wandered a b
On Wed, Aug 18, 2010 at 2:22 PM, Ondrej Certik wrote:
> Hi Brian, Matt and Addison,
>
> I think the discussion wandered a bit from the review.
>
> 1) Git history:
>
> Do you want to keep your history? Does the history bring any value to
> sympy? From what I understoo
Hi Brian, Matt and Addison,
I think the discussion wandered a bit from the review.
1) Git history:
Do you want to keep your history? Does the history bring any value to
sympy? From what I understood, many times it doesn't import, or tests
don't pass. So it seems to me there isn't really any valu
Hi Matt and Addison,
great job! Some comments below:
On Mon, Aug 16, 2010 at 12:19 PM, Matt Curry wrote:
> Addison and I have been working on adding features to sympy.physics
> for our GSoC project. We started off working on separate branches,
> but, as time progressed, our two branches merged t
On Wed, Aug 11, 2010 at 3:53 PM, Brian Granger wrote:
>
>
> On Wed, Aug 11, 2010 at 3:35 PM, Ondrej Certik wrote:
>>
>> On Wed, Aug 11, 2010 at 3:33 PM, Ondrej Certik wrote:
>> > Hi,
>> >
>> > I started implementing the energies, for the hydro
On Wed, Aug 11, 2010 at 3:33 PM, Ondrej Certik wrote:
> Hi,
>
> I started implementing the energies, for the hydrogen atom first:
>
> http://github.com/certik/sympy/commit/a9d53910dd2f0bfe9fe3a25614f3586faaadded0
>
> no tests/doctests so far, but I have a question: what wo
Hi,
I started implementing the energies, for the hydrogen atom first:
http://github.com/certik/sympy/commit/a9d53910dd2f0bfe9fe3a25614f3586faaadded0
no tests/doctests so far, but I have a question: what would be the
best API for that?
Just see that simple patch to get an idea about the implemen
Looks good. Thanks for taking the initiative Aaron!
Ondrej
On Wed, Jul 28, 2010 at 10:51 AM, Andy Ray Terrel wrote:
> I think the email is best and then people can CC themselves if necessary.
>
> -- Andy
>
> On Wed, Jul 28, 2010 at 12:49 PM, Aaron S. Meurer wrote:
>> OK, a question. I can set
On Tue, Jul 27, 2010 at 9:11 AM, Andy Ray Terrel wrote:
> On Tue, Jul 27, 2010 at 10:33 AM, Toon Verstraelen
> wrote:
>> On 07/26/2010 10:36 PM, Ųyvind Jensen wrote:
>>>
>>> I have uploaded my work on the C code printer, C code generator and the
>>> tensor module to smartbear for review:
>>>
>>>
On Tue, Jul 27, 2010 at 6:40 PM, Aaron S. Meurer wrote:
> On Jul 27, 2010, at 7:26 PM, Ondrej Certik wrote:
>
>> On Tue, Jul 27, 2010 at 4:34 PM, Aaron S. Meurer wrote:
>>>
>>> On Jul 27, 2010, at 5:16 PM, Ondrej Certik wrote:
>>>
>>>> On Tue, J
On Tue, Jul 27, 2010 at 4:34 PM, Aaron S. Meurer wrote:
>
> On Jul 27, 2010, at 5:16 PM, Ondrej Certik wrote:
>
>> On Tue, Jul 27, 2010 at 11:12 AM, Brian Granger wrote:
>>> Ondrej,
>>> I just looked through this and it looks great. Very nice. Once the base
On Tue, Jul 27, 2010 at 11:12 AM, Brian Granger wrote:
> Ondrej,
> I just looked through this and it looks great. Very nice. Once the base
> quantum stuff is done, we can integrate it with the hydrogen.py stuff, so
> that the following would work:
s = HState(n, l, m)
s
> |nlm>
rep
On Tue, Jul 27, 2010 at 9:11 AM, Andy Ray Terrel wrote:
> On Tue, Jul 27, 2010 at 10:33 AM, Toon Verstraelen
> wrote:
>> On 07/26/2010 10:36 PM, Ųyvind Jensen wrote:
>>>
>>> I have uploaded my work on the C code printer, C code generator and the
>>> tensor module to smartbear for review:
>>>
>>>
On Sun, Jul 25, 2010 at 12:34 PM, Brian Granger wrote:
> Hi,
> Here is the final version of my binary operator priority branch:
> http://github.com/ellisonbg/sympy/tree/priority
> To address comments I have:
> * Created a decorator @call_highest_priority that is in
> sympy.core.decorators to encap
Hi Matthew,
On Fri, Jul 23, 2010 at 8:48 PM, Ondrej Certik wrote:
> On Fri, Jul 23, 2010 at 8:37 PM, Matthew Brett
> wrote:
>> Hi,
>>
>>>> I also don't feel strongly either way. I would use "_imp_" though,
>>>> that seems to be the bes
On Mon, Jul 26, 2010 at 1:36 PM, Øyvind Jensen wrote:
> I have uploaded my work on the C code printer, C code generator and the
> tensor module to smartbear for review:
>
> http://hosted.smartbear.com/sympy/go?page=ReviewDisplay&reviewid=6
>
> The ability to create code that loops over array argum
Hi guys,
can you please review my branch here:
http://github.com/certik/sympy/tree/hydrogen
Thanks!
Ondrej
--
You received this message because you are subscribed to the Google Groups
"sympy-patches" group.
To post to this group, send email to sympy-patc...@googlegroups.com.
To unsubscribe f
On Fri, Jul 23, 2010 at 8:37 PM, Matthew Brett wrote:
> Hi,
>
>>> I also don't feel strongly either way. I would use "_imp_" though,
>>> that seems to be the best.
>>
>> It shall be so ;)
>
> Done; I also responded to Ondrej's github review, thanks for that,
Awesome. I am now going to Reno, so I'
On Fri, Jul 23, 2010 at 7:36 PM, Aaron S. Meurer wrote:
> I was referring specifically to "Never invent such names; only use them as
> documented." Using _imp_ (single underscores on either side) gives it the
> same "special ufunc-ey thing" appearance as the builtin __magic__ methods do,
> but
On Mon, Jul 19, 2010 at 7:50 PM, Matthew Brett wrote:
> Hi,
>
> On Mon, Jul 19, 2010 at 6:32 PM, Ondrej Certik wrote:
>> On Mon, Jul 19, 2010 at 6:27 PM, Matthew Brett
>> wrote:
>>> Hi,
>>>
>>>> Thanks for this. I just got back from Prague to
h in
>> python2.4 to 2.5. (2.4 doesn't accept tuple arguments).
>>
>> I've attached a patch.
>>
>> -- Andy
>>
>> On Sat, Jul 10, 2010 at 3:40 PM, Ondrej Certik wrote:
>>> It's in, thanks!
>>>
>>> On Sat, Jul 10,
Toon -- if you have time, please upload them to github, then we can
easily pull it.
Ondrej
On Wed, Jul 14, 2010 at 9:16 AM, Andy Ray Terrel wrote:
> Øyvind,
>
> Have these patches been added to a repo somewhere so I can push them
> in? I'm not sure which goes where.
>
> -- Andy
>
> On Sat, Jul
It's in, thanks!
On Sat, Jul 10, 2010 at 9:56 AM, Øyvind Jensen wrote:
> Here is a patch.
>
> Ø
>
>
> lø., 10.07.2010 kl. 05.49 -0700, skrev Øyvind Jensen:
>> Thanks, I'll fix it very soon.
>>
>> Øyvind
>>
>> On 9 Jul, 23:51, certik1 wrote:
>> > Hi,
>> >
>> > the new patches about codegen are aw
On Tue, Jul 6, 2010 at 4:46 AM, Aaron S. Meurer wrote:
>
> On Jul 5, 2010, at 4:28 PM, Ronan Lamy wrote:
>
>> Le lundi 05 juillet 2010 à 19:17 +0200, Øyvind Jensen a écrit :
Yep. I just got back from SciPy and I talked a lot with one of the
devs of theano:
http://deeplearning.
On Mon, Jul 5, 2010 at 5:16 AM, Øyvind Jensen wrote:
>
>
> On 4 Jul, 19:54, Ondrej Certik wrote:
>> On Sun, Jul 4, 2010 at 10:45 AM, Aaron S. Meurer wrote:
>>
>> >> Oops, you are right.
>>
>> >> I just fixed that. I forgot to run doctests, and
On Mon, Jul 5, 2010 at 8:57 AM, Aaron S. Meurer wrote:
> Looks good. All such warnings are gone in Python2.7rc2, and all tests pass
> (except for the ones from issue 1970).
> So now, it looks like except for cmp vs. key and reduce, the rest should be
> doable with the 2to3.py tool (except for may
On Sun, Jul 4, 2010 at 10:45 AM, Aaron S. Meurer wrote:
>> Oops, you are right.
>>
>> I just fixed that. I forgot to run doctests, and the reason is that I
>> got a failure in mpmath tests, some vizualization problem, when I run
>> it remotely.
>
> See issue 1956.
I just fixed that too.
Ondrej
py import lambdify" line
> from the docstring, which now causes doctest failures.
>
> Aaron Meurer
>
> On Jul 2, 2010, at 6:05 PM, Ondrej Certik wrote:
>
>> Hi Matthew!
>>
>> On Thu, Jul 1, 2010 at 1:53 PM, Matthew Brett
>> wrote:
>>>
On Fri, Jul 2, 2010 at 9:18 PM, smichr wrote:
>> > patch for issue 1694 needs review.
>> > It enhances solver capabilities and fix issues concerning fractions :
>
> I would like a chance to review this...I can do so in about 8 hours.
Please do so. I gave it +1 but I would like if you or Aaron cou
Hi Matthew!
On Thu, Jul 1, 2010 at 1:53 PM, Matthew Brett wrote:
> Hi,
>
> I posted to report a problem with lambdify and namespaces to the sympy
> mailing list a while ago:
>
> http://groups.google.com/group/sympy/browse_thread/thread/bb2c16413c49b6f9?fwc=2
>
> but was stirred by the silence to
On Thu, Jul 1, 2010 at 11:44 PM, nico wrote:
> Hi,
>
> patch for issue 1694 needs review.
> It enhances solver capabilities and fix issues concerning fractions :
>
> ex:
solve(1/x, x)
> []
solve(ln(x)/x, x)
> [1]
solve(ln(x)/(x-1), x)
> []
>
> Thanks,
Thanks, I replied in the is
On Tue, Jun 22, 2010 at 10:43 AM, Brian Granger wrote:
> Hi,
>
> I was wondering if there was a reason this patch was not applied?
>
> http://groups.google.com/group/sympy-patches/browse_thread/thread/e75a05616e1b5732
I think that we have forgot. Brian, do you have a push access to the
sympy repo
On Fri, Jun 18, 2010 at 1:19 PM, Christian Muise
wrote:
> Sounds good to me. It should be noted that speeding up the reasoner is
> almost entirely disjoint from the assumption interface rewrite --
> finished or not, the sat solver improvements don't depend on how you
> create your assumptions...ju
On Thu, Jun 17, 2010 at 3:23 PM, Ronan Lamy wrote:
> Le jeudi 17 juin 2010 à 14:02 -0700, Ondrej Certik a écrit :
>> Yes, in this branch we should brake compatibility. We should totally
>> get rid of the old assumptions, thus breaking compatibility. Make sure
>> that things w
Yes, in this branch we should brake compatibility. We should totally
get rid of the old assumptions, thus breaking compatibility. Make sure
that things work nicely, all tests pass and there are no hacks.
Then, for backwards compatibility, we could introduce the assumptions
into the constructors, t
On Thu, Jun 17, 2010 at 12:27 PM, Christian Muise
wrote:
> Ondrej, if you could provide feedback on these two commits, it would really
> help:
> - http://github.com/haz/sympy/commit/91bcb155b24fd354cfdc3b765823ba5041412dce
> - http://github.com/haz/sympy/commit/f0c8becedc87b324f293baea159a73c4057a
On Thu, Jun 17, 2010 at 8:19 AM, Christian Muise
wrote:
> So the main problems start to crop up when you start stripping out
> assumptions from the constructor of basic sympy objects. This breaks
> compatibility, and very quickly the number of errors goes up. You can view
> the natural progressi
Hi,
I've tried the disconnect-assumptions branch and I got some recursive
exception problems, so I did
git checkout HEAD~2
and then they disappeared, but I still got lots of other exceptions
and failures. Run the test using:
Then this branch here:
http://github.com/certik/sympy/tree/assum
giv
+1
On Sun, Jun 13, 2010 at 2:17 AM, Øyvind Jensen wrote:
> ---
> sympy/mpmath/tests/test_visualization.py | 8 ++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/sympy/mpmath/tests/test_visualization.py
> b/sympy/mpmath/tests/test_visualization.py
> index 7ecfb7e..4
On Thu, Jun 3, 2010 at 1:06 PM, Akshay Srinivasan
wrote:
> Okay, I used hasattr instead. I should really stop using quick expedients :)
> All the tests passed.
Looks good, it's in.
--
You received this message because you are subscribed to the Google Groups
"sympy-patches" group.
To post to th
On Thu, Jun 3, 2010 at 8:48 AM, Akshay Srinivasan
wrote:
> This patch fixes issue #1656
This looks good to me. Only I would replace this:
+try:
+#Try if you can extract symbols from the expression.
+syms = expr.atoms()
+for term in syms:
+namespace.update(
On Mon, May 10, 2010 at 4:56 AM, Vinzent Steinberg
wrote:
> 2010/5/10 smichr
>>
>> Only the commits before 1766 are really ready for pushing. I am still
>> pulling apart 1766.
>
> As I already said, it would be much easier if you could create another
> branch for review (1766-for-review) which co
On Sun, May 9, 2010 at 4:45 AM, smichr wrote:
> Hello,
>
> There are 17 commits that are waiting for review in my 1766 branch.
> They are listed below. When I got feedback in a review, I made changes
> and added another commit so, for example, 1778 has 3 parts. Those will
> be squashed together wh
On Wed, May 5, 2010 at 12:40 PM, Øyvind Jensen wrote:
> I cannot figure out how to fork that repo. Thought there should be a
> "fork"-button somewhere, but I see nothing. Anyway, The branch is here:
> jegerjensen/sympy/tree/fix_latex
Ah, I forgot that your first (or middle?) name is Jeger, so y
Hi,
the branch gives me these two minor doctest failures:
sympy/assumptions/assume.py[3] FFF[FAIL]
sympy/assumptions/handlers/order.py[1] .[OK]
sympy/assumptions/handlers/calculus.py[2] ..[
ensen wrote:
> I pushed it to the branch fix_latex
>
> ti., 04.05.2010 kl. 15.09 -0700, skrev Ondrej Certik:
>> +1, is it in your branch somewhere?
>>
>> Ondrej
>>
>> OnMon, May 3, 2010 at 3:32 AM, Øyvind Jensen wrote:
>> > Before: -1^{x}
>>
+1, is it in your branch somewhere?
Ondrej
OnMon, May 3, 2010 at 3:32 AM, Øyvind Jensen wrote:
> Before: -1^{x}
> Now: \left(-1\right)^{x}
>
> Added a test
> ---
> sympy/printing/latex.py | 3 ++-
> sympy/printing/tests/test_latex.py | 3 +++
> 2 files changed, 5 i
On Tue, May 4, 2010 at 3:07 PM, Ondrej Certik wrote:
> On Mon, May 3, 2010 at 2:42 AM, Vinzent Steinberg
> wrote:
>> This does not yet fix bin/test to use py.test if available.
>> There is one raises() test failing, but I don't know why.
>
> I am not sure it&#x
On Mon, May 3, 2010 at 2:42 AM, Vinzent Steinberg
wrote:
> This does not yet fix bin/test to use py.test if available.
> There is one raises() test failing, but I don't know why.
I am not sure it's a good idea to use py.test by default in bin/test,
because py.test is not backwards compatible. I w
On Fri, Apr 30, 2010 at 3:04 PM, Ronan Lamy wrote:
> Le vendredi 30 avril 2010 à 14:23 -0700, Ondrej Certik a écrit :
>> On Fri, Apr 30, 2010 at 6:26 AM, jegerjensen wrote:
>> >> Also, shouldn't this go into sympy.core?
>> >>
>> >> Ondrej
>&g
On Fri, Apr 30, 2010 at 6:26 AM, jegerjensen wrote:
>> Also, shouldn't this go into sympy.core?
>>
>> Ondrej
>> """
>
> That is probably a good idea. Where should we put the decorator
> _tuple_wrapper? Or should the decorator be removed? We could instead
> let sympify() wrap the tuples.
So this
Hi,
I am getting the following failures on linux:
sympy/solvers/tests/test_recurr.py[39] ...
[OK]
sympy/solvers/tests/test_solvers.py[18] ..F...F...
Well,
I am not sure that the change from:
-assert st == SymTuple((1,2,3,4))
to:
+assert st == SymTuple(1, 2, 3, 4)
is a good idea. In fact I think it's a bad idea, as we migrated from
Matrix(1,2, 3, 4) syntax to Matrix([1, 2, 3, 4]).
Also imho you want to be able to do tuple(SymTuple(
+1
On Tue, Apr 27, 2010 at 2:32 PM, Vinzent Steinberg
wrote:
> Signed-off-by: Vinzent Steinberg
> ---
> sympy/matrices/tests/test_matrices.py | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sympy/matrices/tests/test_matrices.py
> b/sympy/matrices/tests/test_matric
+1
On Tue, Apr 27, 2010 at 2:32 PM, Vinzent Steinberg
wrote:
> Signed-off-by: Vinzent Steinberg
> ---
> sympy/matrices/tests/test_matrices.py | 6 ++
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/sympy/matrices/tests/test_matrices.py
> b/sympy/matrices/tests/test_m
Yes, nice. +1
On Mon, Apr 26, 2010 at 8:52 AM, Vinzent Steinberg
wrote:
> As of 0.7.0, we do no longer support creating matrices without brackets.
> See issue 930.
>
> Signed-off-by: Vinzent Steinberg
> ---
> sympy/matrices/matrices.py | 15 +--
> 1 files changed, 1 insertions(+),
Yes, that'd be cool. Otherwise +1
On Mon, Apr 26, 2010 at 8:09 AM, Aaron S. Meurer wrote:
> Could you explain in the commit message what exactly this no longer allows?
>
> Aaron Meurer
> On Apr 26, 2010, at 6:49 AM, Vinzent Steinberg wrote:
>
>> Signed-off-by: Vinzent Steinberg
>> ---
>> sympy/m
All is good, it's in, thanks!
On Wed, Apr 14, 2010 at 10:07 AM, Ondrej Certik wrote:
> Running tests on it.
>
> On Wed, Apr 14, 2010 at 9:40 AM, Felix Kaiser wrote:
>> Here's the new patch.
>>
>> Felix
>>
>>
>> On 04/14/2010 12:07 AM, On
Running tests on it.
On Wed, Apr 14, 2010 at 9:40 AM, Felix Kaiser wrote:
> Here's the new patch.
>
> Felix
>
>
> On 04/14/2010 12:07 AM, Ondrej Certik wrote:
>> On Tue, Apr 13, 2010 at 12:41 PM, Felix Kaiser wrote:
>>
>>> Hi Ondrey,
>>>
On Tue, Apr 13, 2010 at 12:41 PM, Felix Kaiser wrote:
> Hi Ondrey,
>
> you are right, multiply_elementwise() is way more intuitive than
> hadamard(). Here's the updated patch.
Thanks, now this looks cool, I tested it and all tests pass. One more
thing, we require each new method and function to h
Hi Felix,
the patch looks good, my only concern is about the name, e.g. could
the method be called something like:
multiply_elementwise(), or something?
I've never heard about hadamard before. I think everybody understands
what multiply_elementwise() means though and also it would be easy to
fin
On Sun, Apr 4, 2010 at 11:34 PM, Øyvind Jensen wrote:
> Well, I think it can be useful, especially since the commutative
> property is lost if you do
>
s = Symbol(dummy.name, *dummy.assumptions0)
>
> But of course, it should not go in if I am the only one who is going to
> use it. I see you
On Thu, Apr 1, 2010 at 1:20 PM, Vinzent Steinberg
wrote:
> 2010/4/1 Aaron S. Meurer :
>> I like this idea. Maybe it doesn't necessarily have to be tied to Symbol.
>> If there is some kind of global assumptions table, or you are in some "with
>> Assume(x, Q.something):" context, then x.is_somet
On Sat, Mar 27, 2010 at 1:12 PM, Brian Granger wrote:
> Hi,
>
> I have put up a branch that fixes two things in the printers:
>
> http://github.com/ellisonbg/sympy/tree/printer
>
> * lambdify(Piecewise) now uses iff for Python 2.4 compat.
> * I added printmethod = "_pretty_" to the pretty printer
On Sat, Mar 27, 2010 at 12:54 AM, smichr wrote:
>
>
> On Mar 26, 8:38 pm, Vinzent Steinberg
> wrote:
>> I just tried to review the commits before the 'quartz' commit, I hope this
>> is to be reviewed, if not, please create a new branch with only the commits
>> to be reviewed. The 1766s and the 17
On Sat, Mar 27, 2010 at 12:16 AM, Priit Laes wrote:
> Ühel kenal päeval, L, 2010-03-27 kell 07:41, kirjutas Toon Verstraelen:
>> Hello,
>>
>> Could someone please review the patches of issue1356?
>> http://code.google.com/p/sympy/issues/detail?id=1356
>
> IMHO, it would be more pythonic if it retu
On Thu, Mar 25, 2010 at 9:34 AM, Brian Granger wrote:
> Ondrej,
>
>> I just don't like the way you resolved them. Seems like you were
>> merging branches, which both contained some of your patches and in
>> general it was a big mess. I fixed all of that and pushed things here:
>
> Yes, I think I
On Thu, Mar 25, 2010 at 12:13 AM, Toon Verstraelen
wrote:
> Right now only f77. f95 is one of the future options I'm thinkng of. Feel
> free to open a ticket, but I won't forget it anyway. It is mainly a matter
> of proper line wrapping.
Yes. f77 is fine, it should work in f95 too, doesn't it?
O
On Wed, Mar 24, 2010 at 11:30 PM, Toon Verstraelen
wrote:
> Ondrej Certik wrote:
>>
>> On Wed, Mar 24, 2010 at 4:22 PM, Aaron S. Meurer
>> wrote:
>>>
>>> I am testing your branch now. I also left some comments on your github.
>>>
>>> Does
On Wed, Mar 24, 2010 at 11:41 PM, Brian Granger wrote:
> Ondrej,
>
>> The tests seem to run fine. Only I'll try to rebase it, it will make
>> it easier to review. There are some conflicts, that I'll try to fix.
>
> I am a little surprised there were conflicts. I pulled from upstream
> and resolve
On Wed, Mar 24, 2010 at 9:58 PM, Brian Granger wrote:
> OK
>
> I have fixed all the doctests and also merged from upstream, so my
> branch should merge cleanly.
The tests seem to run fine. Only I'll try to rebase it, it will make
it easier to review. There are some conflicts, that I'll try to fix
On Wed, Mar 24, 2010 at 4:26 PM, Ondrej Certik wrote:
> On Wed, Mar 24, 2010 at 4:22 PM, Aaron S. Meurer wrote:
>> I am testing your branch now. I also left some comments on your github.
>>
>> Does the test_sage patch require sage to test? If it does, I won't be able
On Wed, Mar 24, 2010 at 4:22 PM, Aaron S. Meurer wrote:
> I am testing your branch now. I also left some comments on your github.
>
> Does the test_sage patch require sage to test? If it does, I won't be able
> to review that one, as I don't have sage installed.
It does. Seems like noone was a
Hi,
can someone please review my pu branch at github? It contains the
following patches:
$ git shortlog master..pu
Ondrej Certik (7):
test_sage: Use S() instead of sympify()
atan2(y, x) can now be converted to/from Sage
mpmath: test for sage_utils.bitcount
test_sage.py
On Wed, Mar 24, 2010 at 1:54 PM, Vinzent Steinberg
wrote:
> 2010/3/24 Aaron S. Meurer
>>
>> I'm actually more of a fan of github branches, because they are easier to
>> get (git fetch remote vs. download patch, git am patch, hope it works…).
>
> 'git am -3' should usually work. I like mails becau
On Wed, Mar 24, 2010 at 12:00 PM, Christian Muise
wrote:
> I thought it went through...sorry about that.
> -
> http://github.com/haz/sympy/commit/bf41a9fef4ec4e92f0e984a8f5bdece6db058deb
Is this in, or should I review it?
>
> I need to run, but I can submit the patch officially later today
> (
On Sun, Mar 21, 2010 at 9:00 PM, Christian Muise
wrote:
> Thanks for all the feedback. I've just submitted a new combined patch with
> the suggested test case included (makes sense to me to include it).
Where is the combined patch? Let me review it, unless it's already in.
Ondrej
--
You rece
Thanks! Sorry for the late reply.
Is this using f77, or f95 syntax?
Ondrej
On Fri, Mar 19, 2010 at 12:58 PM, Toon Verstraelen
wrote:
> Thanks alot!
>
> Vinzent Steinberg wrote:
>>
>> The patch looks fine to me, however I'm not familiar with fortran. But
>> no one objected so far, so I pushed it
On Sat, Mar 20, 2010 at 1:54 AM, Toon Verstraelen
wrote:
> Ondrej Certik wrote:
>>
>> On Fri, Mar 19, 2010 at 7:01 PM, Ondrej Certik wrote:
>>>
>>> Hi,
>>>
>>> please review my 2 patches in "pu" branch at github:
>>>
>&g
On Fri, Mar 19, 2010 at 11:36 PM, Toon Verstraelen
wrote:
> Hi,
>
> There is one warning remaining about a method in the pretty printing code
> that does not seem to be used anymore. I'm not sure how to handle it. The
> rest was trivial to fix.
The patch looks ok to me. I'll run all tests later t
On Fri, Mar 19, 2010 at 7:01 PM, Ondrej Certik wrote:
> Hi,
>
> please review my 2 patches in "pu" branch at github:
>
> * ee232d5 (HEAD, github/pu, pu) atan2(y, x) can now be converted to/from Sage
> * 17806ba test_sage: Use S() instead of sympify()
please review al
Hi,
please review my 2 patches in "pu" branch at github:
* ee232d5 (HEAD, github/pu, pu) atan2(y, x) can now be converted to/from Sage
* 17806ba test_sage: Use S() instead of sympify()
Thanks,
Ondrej
--
You received this message because you are subscribed to the Google Groups
"sympy-patches"
On Wed, Mar 17, 2010 at 11:52 PM, Priit Laes wrote:
> Ühel kenal päeval, K, 2010-03-17 kell 17:51, kirjutas Ondrej Certik:
>> On Wed, Mar 17, 2010 at 5:21 PM, Aaron Meurer wrote:
>> > I was actually referring to Priit's branch, but I guess polys will need to
>> &g
010, at 4:24 PM, Ondrej Certik wrote:
>
>> Hi Fernando,
>>
>> On Fri, Jan 1, 2010 at 12:47 PM, Fernando Perez
>> wrote:
>>> Hey Ondrej,
>>>
>>> I got that screenshot from David and noticed that isympy says
>>>
>>> (ipython-0.10
On Wed, Mar 17, 2010 at 5:21 PM, Aaron Meurer wrote:
> I was actually referring to Priit's branch, but I guess polys will need to
> fixed too. :)
Polys are now rebased and pass all tests, but you need the patches
from my polys7 branch at github. Those are hotfixes, so now we are
looking with Mat
On Wed, Mar 17, 2010 at 2:13 PM, Priit Laes wrote:
> Hey!
>
> Now that auditing support is in master, I went out there and picked some
> low-hanging fruit (unused imports) from the long list of issues reported
> by audit tool:
>
> 70 files changed, 87 insertions(+), 153 deletions(-)
>
> From 545 w
this group at
http://groups.google.com/group/sympy-patches?hl=en.
From 4f000a65d1c012f5afef88214a732b4882e41c64 Mon Sep 17 00:00:00 2001
From: Ondrej Certik
Date: Wed, 17 Mar 2010 15:19:45 -0700
Subject: [PATCH] isympy: mention IPython
Before we didn't mention IPython at all:
$ bin/i
On Wed, Mar 17, 2010 at 9:35 AM, Ondrej Certik wrote:
> On Wed, Mar 17, 2010 at 6:11 AM, Priit Laes wrote:
>> Hey,
>>
>> A while ago (last year sometime) I sent a review request about my
>> pyflakes branch to the list, but I dont really recall the outcome but
>
1 - 100 of 675 matches
Mail list logo
