Re: Jasper2: serious problem with tag declarations

2002-06-27 Thread Jan Luehe
Costin, - I have a bean:define id=a name=foo/ The generated code is: a = (java.lang.Object) pageContext.findAttribute(a); a = (java.lang.Object) pageContext.findAttribute(a); a = (java.lang.Object) pageContext.findAttribute(a); ( i.e. 3 times the same line ). Not a bug, but

Re: Jasper2: serious problem with tag declarations

2002-06-27 Thread costinm
On Thu, 27 Jun 2002, Jan Luehe wrote: Costin, - I have a bean:define id=a name=foo/ The generated code is: a = (java.lang.Object) pageContext.findAttribute(a); a = (java.lang.Object) pageContext.findAttribute(a); a = (java.lang.Object) pageContext.findAttribute(a); ( i.e.

Re: Jasper2: serious problem with tag declarations

2002-06-27 Thread Jan Luehe
Costin, - I have a bean:define id=a name=foo/ The generated code is: a = (java.lang.Object) pageContext.findAttribute(a); a = (java.lang.Object) pageContext.findAttribute(a); a = (java.lang.Object) pageContext.findAttribute(a); ( i.e. 3 times the same line ).

Re: Jasper2: serious problem with tag declarations

2002-06-27 Thread costinm
On Thu, 27 Jun 2002, Jan Luehe wrote: And I would bet most jsp implementations in use are doing exactly what jasper1 is doing - and changing this will create big problems ( while still beeing non-compiant with the spec, and completely counterintuitive ) But there also could be

Re: Jasper2: serious problem with tag declarations

2002-06-26 Thread costinm
I tried again, and it worked. There is still one error ( i.e. a page that worked before but no longer does ), but that may be legitimate. 2 more problems: - I have a bean:define id=a name=foo/ The generated code is: a = (java.lang.Object) pageContext.findAttribute(a); a = (java.lang.Object)

Re: Jasper2: serious problem with tag declarations

2002-06-26 Thread costinm
On Wed, 26 Jun 2002, Jan Luehe wrote: - in the same case, the 'a' variable is declared at the top of the file, even if it is AT_END. That brakes previous iterate that used the 'a' id. I believe this is a bug. According to the spec, the scope of an AT_END variable spans from the end

Re: Jasper2: serious problem with tag declarations

2002-06-26 Thread Kin-Man Chung
- in the same case, the 'a' variable is declared at the top of the file, even if it is AT_END. That brakes previous iterate that used the 'a' id. I believe this is a bug. According to the spec, the scope of an AT_END variable spans from the end element of the tag exposing it to

Re: Jasper2: serious problem with tag declarations

2002-06-24 Thread Kin-Man Chung
Costin, On Fri, 21 Jun 2002, Kin-Man Chung wrote: Use of scripting varibles in nested tag never work before, so obviously no body uses it much. I think the whole scripting variable in JSP1.2 is poorly designed, and not well understood. The failures are from an app that worked

Re: Jasper2: serious problem with tag declarations

2002-06-24 Thread costinm
On Mon, 24 Jun 2002, Kin-Man Chung wrote: Use of scripting varibles in nested tag never work before, so obviously no body uses it much. I think the whole scripting variable in JSP1.2 is poorly designed, and not well understood. The failures are from an app that worked perfectly

Re: Jasper2: serious problem with tag declarations

2002-06-24 Thread Kin-Man Chung
My problem is that code that worked with jasper1 no longer works with jasper2. And I believe the use case is valid and within the spec, and quite common. The latest failure is just 2 iterate tags and a condition tag - I think it should work. Costin With the Jan's patch last

Re: Jasper2: serious problem with tag declarations

2002-06-24 Thread costinm
On Mon, 24 Jun 2002, Kin-Man Chung wrote: With the Jan's patch last Friday, jasper 2 should handle those cases that used to work for japser1, as well as those those that cannot be handled by jasper1. If this is not the case, please let me know. The current failing case is ( used to work

Re: Jasper2: serious problem with tag declarations

2002-06-22 Thread Jan Luehe
Costin, If those variable declaration problems are fixed, I'll release a new 4.1.6 milestone as soon as I can fix the JNDI problems. Not yet... I attached the failed jsp. Costin [...] %@ page language=java % %@

RE: Jasper2: serious problem with tag declarations

2002-06-21 Thread Jan Luehe
Hi Costin, But there is still a problem - now if you have: logic:iterate id='i' /logic:iterate logic:iterate id='i' /logic:iterate ( i.e. the same variable name ), it will fail with duplicated declaration, the code will be: Object i; ... Object i; ( id is

Re: Jasper2: serious problem with tag declarations

2002-06-21 Thread Remy Maucherat
Jan Luehe wrote: Hi Costin, But there is still a problem - now if you have: logic:iterate id='i' /logic:iterate logic:iterate id='i' /logic:iterate ( i.e. the same variable name ), it will fail with duplicated declaration, the code will be: Object i; ... Object i; (

Re: Jasper2: serious problem with tag declarations

2002-06-21 Thread costinm
On Fri, 21 Jun 2002, Remy Maucherat wrote: If those variable declaration problems are fixed, I'll release a new 4.1.6 milestone as soon as I can fix the JNDI problems. Not yet... I attached the failed jsp. Costin package JspServ; import javax.servlet.*; import javax.servlet.http.*;

Re: Jasper2: serious problem with tag declarations

2002-06-21 Thread costinm
Thanks, I'll try it out. I'm a bit worried here - most of the stuff is pretty basic and common use of tags. Watchdog and the test suite was supposed to detect that withou any problems. I'll vote for 'alpha' status for the next build, and I hope more people will check their apps against it -

Re: Jasper2: serious problem with tag declarations

2002-06-21 Thread Kin-Man Chung
Costin, I'm a bit worried here - most of the stuff is pretty basic and common use of tags. Watchdog and the test suite was supposed to detect that withou any problems. Use of scripting varibles in nested tag never work before, so obviously no body uses it much. I think the whole

Re: Jasper2: serious problem with tag declarations

2002-06-21 Thread costinm
On Fri, 21 Jun 2002, Kin-Man Chung wrote: Use of scripting varibles in nested tag never work before, so obviously no body uses it much. I think the whole scripting variable in JSP1.2 is poorly designed, and not well understood. The failures are from an app that worked perfectly fine with

Re: Jasper2: serious problem with tag declarations

2002-06-21 Thread costinm
On Fri, 21 Jun 2002, Jan Luehe wrote: the current approach should be able to handle a NESTED 'foo' in 2 different tags, with different declared types, as long as one tag isn't nested inside the other. The current approach will generate code like this: { Integer foo; } {

RE: Jasper2: serious problem with tag declarations

2002-06-20 Thread Jan Luehe
Hi Costin, More info: The page is: %@ taglib uri=/WEB-INF/struts-logic.tld prefix=logic % logic:iterate id=id1 name=name1 property=prop1 logic:iterate id=id2 name=name2 property=prop2 Foo /logic:iterate /logic:iterate I get: a$jsp.java:75:25:75:25: Error:

RE: Jasper2: serious problem with tag declarations

2002-06-20 Thread costinm
Many thanks Jan and Kin-Man. But there is still a problem - now if you have: logic:iterate id='i' /logic:iterate logic:iterate id='i' /logic:iterate ( i.e. the same variable name ), it will fail with duplicated declaration, the code will be: Object i; ... Object i; ( id

RE: Jasper2: serious problem with tag declarations

2002-06-18 Thread Ken . Horn
for a few extra {}'s? -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] Sent: 18 June 2002 06:44 To: Tomcat Developers List; Kin-Man Chung Subject: Re: Jasper2: serious problem with tag declarations On Mon, 17 Jun 2002, Kin-Man Chung wrote: Costin, I am not aware

RE: Jasper2: serious problem with tag declarations

2002-06-18 Thread Kin-Man Chung
Date: Tue, 18 Jun 2002 11:04:10 +0100 From: [EMAIL PROTECTED] Subject: RE: Jasper2: serious problem with tag declarations To: [EMAIL PROTECTED] MIME-version: 1.0 X-MIMEOLE: Produced By Microsoft Exchange V6.0.5762.3 Content-transfer-encoding: quoted-printable Content-class: urn:content

RE: Jasper2: serious problem with tag declarations

2002-06-18 Thread costinm
PROTECTED] [mailto:[EMAIL PROTECTED]] Sent: 18 June 2002 06:44 To: Tomcat Developers List; Kin-Man Chung Subject: Re: Jasper2: serious problem with tag declarations On Mon, 17 Jun 2002, Kin-Man Chung wrote: Costin, I am not aware that id attribute is handled differently