Adding Kasper as Erik is on vacation.
http://codereview.chromium.org/149513
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
LGTM.
http://codereview.chromium.org/149513/diff/1/10
File tools/tickprocessor.js (right):
http://codereview.chromium.org/149513/diff/1/10#newcode387
Line 387: if (prevEntry && !('end' in prevEntry) &&
The 'end' in prevEntry stuff looks a bit weird to me. I think it would
be more common just to
LGTM.
http://codereview.chromium.org/149530/diff/1/2
File benchmarks/v1/run.html (right):
http://codereview.chromium.org/149530/diff/1/2#newcode67
Line 67: background:#d9;
Space after :.
http://codereview.chromium.org/149530/diff/1/2#newcode106
Line 106: function showWarning() {
showWarnin
Reviewers: Kevin Millikin,
Description:
Add regression test case for http://crbug.com/16276. Crashes
in both debug and release mode before r2435, but not after.
Please review this at http://codereview.chromium.org/155491
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected f
LGTM, with comments. I can make the changes, if you want. It looks
like the test result changes for x64 were mainly made in an earlier
changelist.
http://codereview.chromium.org/155346/diff/1/3
File src/x64/disasm-x64.cc (right):
http://codereview.chromium.org/155346/diff/1/3#newcode509
Line
On Tue, Jul 14, 2009 at 11:09 AM, wrote:
> LGTM, with comments. I can make the changes, if you want. It looks
> like the test result changes for x64 were mainly made in an earlier
> changelist.
Hey Bill,
If you take care of this CL that would be great! I only have single
comment: Why is the t
Nice. LGTM.
http://codereview.chromium.org/155491
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Author: kasp...@chromium.org
Date: Tue Jul 14 02:31:48 2009
New Revision: 2454
Modified:
branches/bleeding_edge/test/cctest/test-api.cc
Log:
Add regression test case for http://crbug.com/16276. Crashes
in both debug and release mode before r2435, but not after.
Review URL: http://codereview.
Thanks, Kasper!
http://codereview.chromium.org/149513/diff/1/10
File tools/tickprocessor.js (right):
http://codereview.chromium.org/149513/diff/1/10#newcode387
Line 387: if (prevEntry && !('end' in prevEntry) &&
On 2009/07/14 07:52:57, Kasper Lund wrote:
> The 'end' in prevEntry stuff looks a b
Author: mikhail.naga...@gmail.com
Date: Tue Jul 14 02:47:44 2009
New Revision: 2455
Modified:
branches/bleeding_edge/test/mjsunit/tools/codemap.js
branches/bleeding_edge/test/mjsunit/tools/profile.js
branches/bleeding_edge/test/mjsunit/tools/tickprocessor-test.default
branches/b
http://codereview.chromium.org/149542/diff/7/1008
File src/objects.cc (right):
http://codereview.chromium.org/149542/diff/7/1008#newcode212
Line 212: return Object::GetPropertyWithDefinedGetter(receiver,
On 2009/07/13 20:12:19, Mads Ager wrote:
> Since the debugger can cause GCs, you have to wra
Reviewers: Kasper Lund,
Message:
This is the same change list you already reviewed, with the comments
addressed.
Description:
Change tests status for x64, make test runner pass --arch flag to Scons,
add to x64 disassembler. Copied from
http://codereview.chromium.org/155346 so it can be committe
LGTM.
http://codereview.chromium.org/149608/diff/1/3
File test/cctest/cctest.status (right):
http://codereview.chromium.org/149608/diff/1/3#newcode111
Line 111: test-debug/CallFunctionInDebugger: SKIP
Any reasons for skipping this rather than letting it fail, crash,
timeout?
http://codereview.
Author: whe...@chromium.org
Date: Tue Jul 14 04:39:45 2009
New Revision: 2456
Modified:
branches/bleeding_edge/src/x64/assembler-x64.h
branches/bleeding_edge/src/x64/disasm-x64.cc
branches/bleeding_edge/test/cctest/cctest.status
branches/bleeding_edge/test/message/message.status
LGTM.
http://codereview.chromium.org/149530/diff/6/1003
File benchmarks/v1/run.html (right):
http://codereview.chromium.org/149530/diff/6/1003#newcode107
Line 107: // if anything goes wrong we will just catch the exception and
no
if -> If
http://codereview.chromium.org/149530
--~--~-~
Codereview.chromium.org won't let me log in, so I'll give the comments by
mail only.
On Tue, Jul 14, 2009 at 11:09, wrote:
> LGTM, with comments. I can make the changes, if you want. It looks
> like the test result changes for x64 were mainly made in an earlier
> changelist.
Yes, this just f
Author: sandh...@chromium.org
Date: Tue Jul 14 06:14:59 2009
New Revision: 2457
Modified:
data/benchmarks/v1/run.html
Log:
Added a warning shown if the viewed version is not the current version of
V8 benchmark suite. This change list is only for v1/run.html. I will add
changes for v2, v3 and
http://codereview.chromium.org/149530/diff/1/2
File benchmarks/v1/run.html (right):
http://codereview.chromium.org/149530/diff/1/2#newcode67
Line 67: background:#d9;
On 2009/07/14 08:01:42, Kasper Lund wrote:
> Space after :.
Done.
http://codereview.chromium.org/149530/diff/1/2#newcode106
http://codereview.chromium.org/149530/diff/6/1003
File benchmarks/v1/run.html (right):
http://codereview.chromium.org/149530/diff/6/1003#newcode107
Line 107: // if anything goes wrong we will just catch the exception and
no
On 2009/07/14 12:05:16, Kasper Lund wrote:
> if -> If
Done.
http://cod
Reviewers: Mads Ager,
Description:
Second of three CLs now changing v2, v3 and v4 of the benchmark suite
so that a warning is issued whenever the version run is not the latest
Please review this at http://codereview.chromium.org/149610
SVN Base: http://v8.googlecode.com/svn/data/
Affected file
Reviewers: Mads Ager,
Description:
Third and hopefully last of thrre CLs to issue a warning when an older
version of the benchmark suite is run. This last change updates
bleeding_edge.
Please review this at http://codereview.chromium.org/155496
SVN Base: http://v8.googlecode.com/svn/branches/bl
LGTM, with suggestions.
http://codereview.chromium.org/155496/diff/1/2
File benchmarks/run.html (right):
http://codereview.chromium.org/155496/diff/1/2#newcode58
Line 58: function ShowWarningIfObsolete() {
It might not be worth it to do this check if the banchmark is not
received over http (i.e
LGTM. My mistake - I did the change and then ran off without checking
the bots. Sorry about that.
-- Mads
On Mon, Jul 13, 2009 at 11:59 PM, Kevin Millikin wrote:
>
> LGTM.
>
> On 7/14/09, kasp...@chromium.org wrote:
>> Reviewers: Kevin Millikin,
>>
>> Description:
>> Update test expectations
Reviewers: Mads Ager,
Description:
Add heap log processing script originally written by Kevin.
Also, add user time into heap sample begin events to make '--log-gc'
flag alone sufficient for producing heap logs (previously, samples times
were extracted from scavenge events which are only logged w
Committed as change http://codereview.chromium.org/149608
Line 509: size left as is.
Line 622: op_size changed to immediate_size
Line 732: Suggested change made.
n 2009/07/14 09:09:22, William Hesse wrote:
> LGTM, with comments. I can make the changes, if you want. It looks
like the
> test
Reviewers: Mads Ager,
Message:
Changing the test to run faster may be a bad idea since one of the
constants is 4 billion, and smaller numbers may not hit the same issues.
Description:
Allow a slow test, array-splice, to timeout on ARM.
Please review this at http://codereview.chromium.org/155500
On 2009/07/14 09:55:17, Yury Semikhatsky wrote:
> http://codereview.chromium.org/149542/diff/7/1008
> File src/objects.cc (right):
> http://codereview.chromium.org/149542/diff/7/1008#newcode212
> Line 212: return Object::GetPropertyWithDefinedGetter(receiver,
> On 2009/07/13 20:12:19, Mads Ager w
LGTM
http://codereview.chromium.org/149611
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
LGTM!
http://codereview.chromium.org/149542/diff/1045/34
File src/debug.cc (right):
http://codereview.chromium.org/149542/diff/1045/34#newcode337
Line 337: // Step in through constructs call requires no changes to the
running code.
Not your change, but: constructs -> construct
http://coderevie
http://codereview.chromium.org/149542/diff/1045/34
File src/debug.cc (right):
http://codereview.chromium.org/149542/diff/1045/34#newcode337
Line 337: // Step in through constructs call requires no changes to the
running code.
On 2009/07/14 16:36:47, Mads Ager wrote:
> Not your change, but: const
Author: yu...@chromium.org
Date: Tue Jul 14 09:55:32 2009
New Revision: 2458
Added:
branches/bleeding_edge/test/mjsunit/debug-stepin-accessor.js
Modified:
branches/bleeding_edge/src/debug.cc
branches/bleeding_edge/src/objects.cc
branches/bleeding_edge/test/mjsunit/mjsunit.status
And Kasper,
I gather I should use CheckPrototypes when doing a second check, correct?
yours,
anton.
On Tue, Jul 14, 2009 at 10:46 PM, Anton Muhin wrote:
> Guys, sorry for bothering you w/ this CL another time, but in a hard
> way I learned that number field of LookupResult cannot be cached (due
Author: mikhail.naganov
Date: Tue Jul 14 11:31:31 2009
New Revision: 2459
Modified:
wiki/V8Profiler.wiki
Log:
Added entry for the Mac version
Modified: wiki/V8Profiler.wiki
==
--- wiki/V8Profiler.wiki(origin
Guys, sorry for bothering you w/ this CL another time, but in a hard
way I learned that number field of LookupResult cannot be cached (due
to transitions), so the thing I postponed for next CL had to be merged
into this one. May you have another look?
All v8 tests (except for regress-75 in debug
Reviewers: Mads Ager,
Description:
Adjust kPagesPerChunk to 16 instead of 64 on Android.
Renamed some macros to ANDROID.
Please review this at http://codereview.chromium.org/155538
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/compilation-cache.c
LGTM
http://codereview.chromium.org/155538/diff/1/2
File src/heap.cc (right):
http://codereview.chromium.org/155538/diff/1/2#newcode226
Line 226: lo_space_->Size(), lo_space_->Available());
Good catch, I should have caught that in the original review. :-)
http://codereview.chromium.org/155538
Author: f...@chromium.org
Date: Tue Jul 14 15:38:06 2009
New Revision: 2460
Modified:
branches/bleeding_edge/src/compilation-cache.cc
branches/bleeding_edge/src/heap.cc
branches/bleeding_edge/src/spaces.cc
branches/bleeding_edge/src/spaces.h
Log:
Adjust kPagesPerChunk to 16 inste
Reviewers: Søren Gjesse,
Message:
Updated per comments. Please double-check link 890. That's the way a
"return" is split in variables.h:181 ...
- Matt
On 2009/07/01 16:55:05, Søren Gjesse wrote:
> LGTM with a few comments.
> http://codereview.chromium.org/126109/diff/1/2
> File src/messages.j
Status: Accepted
Owner: kmilli...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 403 by kasp...@chromium.org: Stack height expectations mismatch
on try-catch-finally with continues
http://code.google.com/p/v8/issues/detail?id=403
do {
try {
continue;
} catch(e) {
Updates:
Status: Fixed
Comment #1 on issue 402 by kasp...@chromium.org: Latest v8.gyp file breaks
compilation in Chromium
http://code.google.com/p/v8/issues/detail?id=402
(No comment was entered for this change.)
--
You received this message because you are listed in the owner
or CC f
Comment #2 on issue 388 by kasp...@chromium.org: Some code is much slower
when the debugger is running
http://code.google.com/p/v8/issues/detail?id=388
What's the status of this?
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starre
Reviewers: Mads Ager, Kasper Lund,
Description:
Fasten global handles allocation.
Please review this at http://codereview.chromium.org/155540
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/global-handles.h
M src/global-handles.cc
--~--~--
42 matches
Mail list logo
