On 2013/10/14 18:53:14, danno wrote:
Can you try making this:
static const int kPrologueOffsetNotSet = -1;
a public static memory of Code in objects.h? That's better than
v8globals.h
Good plan. Done.
https://codereview.chromium.org/23480031/diff/109001/src/arm/full-codegen-arm.cc
File
https://codereview.chromium.org/27023003/diff/3001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/27023003/diff/3001/src/mark-compact.cc#newcode1010
src/mark-compact.cc:1010: isolate_-heap()-DecrementCodeGeneratedBytes(
On 2013/10/14 09:18:37, Michael
On 2013/10/07 10:56:12, rmcilroy wrote:
https://codereview.chromium.org/23480031/diff/97001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/23480031/diff/97001/src/ia32/full-codegen-ia32.cc#newcode171
src/ia32/full-codegen-ia32.cc
lgtm with one nit.
Nice, thanks!
https://codereview.chromium.org/27178002/diff/1/src/hydrogen-dce.cc
File src/hydrogen-dce.cc (right):
https://codereview.chromium.org/27178002/diff/1/src/hydrogen-dce.cc#newcode35
src/hydrogen-dce.cc:35: HValue* instr, ZoneListHValue** worklist) {
add an
Thanks Michael!
https://codereview.chromium.org/27023003/diff/3001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/27023003/diff/3001/src/heap.h#newcode2374
src/heap.h:2374: intptr_t full_codegen_bytes_;
On 2013/10/14 09:18:37, Michael Starzinger wrote:
nit: I know the
Reviewers: Michael Starzinger,
Message:
This was an idea Toon had. It seems to saves ~3KB (every little helps...)
on
descriptor arrays for Octane and doesn't cost any performance.
PTAL.
Description:
Return descriptor ownership after TrimDescriptorArray to allow resharing of
descriptor
Reviewers: Michael Starzinger,
Message:
PTAL.
Description:
Add histograms to track fraction of heap spaces and percentage of crankshaft
code.
BUG=None
Please review this at https://codereview.chromium.org/27023003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Add code age subtype tracking to --track-gc-object-stats
Adds counters which track the age of code in the heap during a gc if
--track-gc-object-stats is enabled.
- Splits RecordObjectStats into RecordObjectStats, RecordCodeSubTypeStats
https://codereview.chromium.org/23480031/diff/97001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/23480031/diff/97001/src/ia32/full-codegen-ia32.cc#newcode171
src/ia32/full-codegen-ia32.cc:171: __ nop();
On 2013/10/04 16:30:09, danno
Reviewers: Jakob,
Message:
As discussed re: https://codereview.chromium.org/24550008/, this fixes the
link
error on the Window's component build. Another option would be to explicitly
reference a symbol in default.cc somewhere else in v8 (e.g., api.cc), by
doing
something like:
bool
Thanks for looking into this. This works for the component build, but
unfortunately now fails in the single lib chromium build. Possible solution
inline.
https://codereview.chromium.org/26004003/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
lgtm
As discussed offline, this does actually work. Thanks!
https://codereview.chromium.org/26004003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2013/10/01 14:02:12, Jakob wrote:
lgtm
Hannes, do you have any comments?
https://codereview.chromium.org/24978006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Could someone land this when convenient please.
https://codereview.chromium.org/24978006/diff/15001/src/defaults.cc
File src/defaults.cc (right):
https://codereview.chromium.org/24978006/diff/15001/src/defaults.cc#newcode55
src/defaults.cc:55: if (physical_memory = 512ul * i::MB) {
On
I've re-structured the if/else branch to be more in line with my original
intention (as Jakob said, there the 2GB check I was doing was
effectively a
= 4GB check since there is not many systems with memory between 2-4GB.
PTAL.
Added support for x64 and ia32. This ended up being more complex than I
hoped
because on x64 I need to relocate the relative address call()'s once the
code is
placed at its final address. To do this, I need to enable the
RelocInfoIterator
to find the CODE_AGE_SEQUENCE relocinfo type at
Reviewers: Hannes Payer,
Description:
Fix performance regression caused by accidental change in default max young
space size.
BUG=None
Please review this at https://codereview.chromium.org/24989003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -3 lines):
Reviewers: Jakob, Hannes Payer,
Message:
As discussed with Jakob, this enables platforms with swap to be one bucket
up
in max heap sizes. It also introduces a 1-2GB bucket since previously the
step
between 512MB and 2GB sizes was quite large. PTAL.
Description:
Tweak default max heap
On 2013/09/23 12:58:34, rmcilroy wrote:
I've redo this to use code stubs which track whether code has been
executed
zero, once or multiple times. I didn't bother with a counter on the Code
object
as this didn't seem necessary given the stubs track this implicitly.
PTAL, let me know what
Reviewers: Hannes Payer,
Description:
Fix Windows build of defaults.cc.
BUG=None
Please review this at https://codereview.chromium.org/24762002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/defaults.cc
Index: src/defaults.cc
diff
, rmcilroy wrote:
On 2013/09/24 13:43:44, Hannes Payer wrote:
I think these two constants are not used anymore.
It's used for the code_range_size_ in heap.cc. I can change that to use
(kPointerSize == 8) if you prefer, but I think kIs64BitArch is clearer.
WDYT?
Ah, yes. Hmm, let's keep
On 2013/09/25 12:10:44, rmcilroy wrote:
On 2013/09/24 15:32:15, Hannes Payer wrote:
https://codereview.chromium.org/24269003/diff/18001/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/24269003/diff/18001/src/globals.h#newcode251
src/globals.h:251: const bool
https://codereview.chromium.org/24269003/diff/12001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/24269003/diff/12001/src/api.cc#newcode636
src/api.cc:636: bool ConfigureResourceConstraintsForCurrentPlatform(
On 2013/09/24 07:31:00, Hannes Payer wrote:
We had another
Can we adjust the title and the description of the CL?
Done.
Please don't spread that over all platform files. We're trying hard to
get rid
of them. Add it to platform-posix.cc (with appropriate #if's using V8_OS_*
defines) and platform-win32.cc only. Preferably you would add a SysInfo
Yes, please put this in another file to make it clear that it's not
part of
the core.
Done.
https://codereview.chromium.org/24269003/diff/23001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/24269003/diff/23001/src/heap.cc#newcode73
src/heap.cc:73:
https://codereview.chromium.org/24269003/diff/18001/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/24269003/diff/18001/src/globals.h#newcode251
src/globals.h:251: const bool kIs64BitArch = true;
On 2013/09/24 13:43:44, Hannes Payer wrote:
I think these two constants
()
// TODO(bmeurer) Initialized lazily because it depends on flags; can
// be fixed once the default isolate cleanup is done.
random_number_generator_(NULL),
- // TODO(rmcilroy) Currently setting this based on
- // FLAG_force_memory_constrained in Isolate::Init; move
https://codereview.chromium.org/24018009/diff/1/include/v8.h
File include/v8.h (left):
https://codereview.chromium.org/24018009/diff/1/include/v8.h#oldcode3755
include/v8.h:3755:
On 2013/09/23 11:38:43, Hannes Payer wrote:
Let's keep the last newline
Done
On 2013/09/23 12:45:04, Hannes Payer wrote:
LGTM, please change the title and the description of the cl
I did already ;). Could you land it please.
https://codereview.chromium.org/24018009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
On 2013/09/23 12:46:04, rmcilroy wrote:
On 2013/09/23 12:45:04, Hannes Payer wrote:
LGTM, please change the title and the description of the cl
I did already ;). Could you land it please.
Opps, but not the title it seems, done now.
https://codereview.chromium.org/24018009/
--
--
v8-dev
I've redo this to use code stubs which track whether code has been executed
zero, once or multiple times. I didn't bother with a counter on the Code
object
as this didn't seem necessary given the stubs track this implicitly.
PTAL, let me know what you think. If generally agreeable, I'll
As discussed this morning, I've moved this to a API call which sets device
specific heap sizes. WDYT?
I've based the code in platform-X.cc on code in chrome's base::SysInfo
class,
but I don't have the platforms available to test these - is there any way I
can
test these on trybots for the
On 2013/09/20 07:12:32, danno wrote:
I don't think adding more #ifdefs to V8 or adding memory_constrained is
the
right way to go. The core of V8 is not the best place to consolidate the
logic
for the multiple devices and configurations where it needs to run well.
Defaults
should be just
(rmcilroy): Ideally these should be set correctly in the
constructor
+// based on this flag, but the flag isn't setup correctly at that
point.
+max_semispace_size_ = DEFAULT_SEMISPACE_MAX_SIZE / 4;
+reserved_semispace_size_ = DEFAULT_SEMISPACE_MAX_SIZE / 4
https://codereview.chromium.org/24269003/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/24269003/diff/1/src/heap.cc#newcode75
src/heap.cc:75: #if defined(ANDROID) || V8_TARGET_ARCH_MIPS
On 2013/09/19 14:50:57, Hannes Payer wrote:
I never liked the ifdef here. Now
IIUC this is a glorified way to store exactly one bit of information,
namely
whether a code object is freshly generated and has never been aged before.
Wouldn't it be easier to store that bit of information in the code object
header? This could spare us from adding a NOP to every single method
Currently we still don't flush optimized code, so adding the bit to
OPTIMIZED_FUNCTION as well wouldn't make any difference right now. That
being
said, flushing of optimized code has been on our agenda for ages, and we
shouldn't build anything into the systems that makes flushing of optimized
Reviewers: Sven Panne,
Message:
Now with less static initializers...
Description:
Add flags to force or prevent setting of isolate.is_memory_constrained.
Enables MAYBE_BOOL flags for when you want to only do something if the flag
was explicitly set to true or false. Also cleans up JSArguments
Thanks. Could you land this for me please?
https://codereview.chromium.org/23890027/diff/6001/src/flags.cc
File src/flags.cc (right):
https://codereview.chromium.org/23890027/diff/6001/src/flags.cc#newcode421
src/flags.cc:421: PrintF(Setting %d\n, !is_bool);
On 2013/09/16 07:50:45, Sven Panne
On 2013/09/13 10:17:22, rmcilroy wrote:
On 2013/09/13 09:56:40, Hannes Payer wrote:
On 2013/09/13 09:30:50, rmcilroy_google wrote:
On 2013/09/13 06:24:25, Sven Panne wrote:
On 2013/09/12 18:16:24, Hannes Payer wrote:
All right, the patch looks fine. But I don't think we should do
On 2013/09/16 09:52:54, Sven Panne wrote:
Hmmm, we have test failures in cctest/test-flags, see e.g.
make -j32 ia32.debug.check TESTJOBS=cctest/test-flags
So we need one more review round. *Nothing* in v8 is easy... :-}
Whoops, I thought I'd run debug.check... Fixed and added some
https://codereview.chromium.org/23480031/diff/29001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/23480031/diff/29001/test/cctest/test-heap.cc#newcode1065
test/cctest/test-heap.cc:1065: // survive further).
On 2013/09/16 14:31:45, Hannes Payer
On 2013/09/13 06:24:25, Sven Panne wrote:
On 2013/09/12 18:16:24, Hannes Payer wrote:
All right, the patch looks fine. But I don't think we should do it for
non-memory-constrained devices, at least not now. Can we turn it on/off
based
on
such a memoy-constrained device check? Moreover it
On 2013/09/13 09:56:40, Hannes Payer wrote:
On 2013/09/13 09:30:50, rmcilroy_google wrote:
On 2013/09/13 06:24:25, Sven Panne wrote:
On 2013/09/12 18:16:24, Hannes Payer wrote:
All right, the patch looks fine. But I don't think we should do it
for
non-memory-constrained devices, at
Reviewers: Sven Panne, Hannes Payer,
Message:
As requested. This enables both forcing and preventing of the
memory_constrained flag. PTAL.
Description:
Add flags to force or prevent setting of isolate.is_memory_constrained.
Also, add a method of prohibiting illegal flag combinations.
https://codereview.chromium.org/21063002/diff/68001/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):
https://codereview.chromium.org/21063002/diff/68001/src/arm/codegen-arm.cc#newcode503
src/arm/codegen-arm.cc:503: r9,
On 2013/09/13 12:06:27, ulan wrote:
This can clobber r9, so the
On 2013/09/13 12:55:48, ulan wrote:
On 2013/09/13 12:16:43, rmcilroy_google wrote:
https://codereview.chromium.org/21063002/diff/68001/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):
https://codereview.chromium.org/21063002/diff/68001/src/arm/codegen-arm.cc#newcode503
Thanks for finding that issue Ulan! It does seem to have fixed it (I've been
running your crash script for 10mins and no crashes, where before it crashed
after 2mins).
https://codereview.chromium.org/21063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Thanks for finding that issue Ulan! It does seem to have fixed it (I've been
running your crash script for 10mins and no crashes, where before it crashed
after 2mins).
https://codereview.chromium.org/21063002/diff/68001/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):
On 2013/09/13 12:34:52, Sven Panne wrote:
Three-valued logic via 2 boolean + exclusion of one of the 4 possible
combined
values = not exactly a candidate for the next coding beauty
contest... ;-)
How about this instead - enabled the use of Maybebool flag types.
Also fixed an issue with the
Updated for all architectures. I'll report back with the performance
impact if
enabled for all devices.
https://codereview.chromium.org/23480031/diff/22001/src/ia32/codegen-ia32.cc
File src/ia32/codegen-ia32.cc (right):
On 2013/09/10 06:09:56, Sven Panne wrote:
LGTM with a nit.
https://codereview.chromium.org/23464022/diff/21001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/23464022/diff/21001/include/v8.h#newcode3816
include/v8.h:3816: Maybebool is_memory_constrained() { return
On 2013/09/09 07:17:09, Sven Panne wrote:
lgtm
Thanks Sven. Could you land this for me please?
https://codereview.chromium.org/23767009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
Reviewers: Hannes Payer,
Message:
I'll add support for other architectures if you think this looks OK.
Description:
Enable preaging of code objects for low-memory devices.
This change means that code which is never re-executed is garbage collected
more quickly (limiting heap growth), however,
Updated to use the Maybe template. PTAL.
https://codereview.chromium.org/23464022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
On 2013/09/06 07:38:00, Sven Panne wrote:
On 2013/09/05 18:29:59, rmcilroy wrote:
Sorry, I think we are misunderstanding. There is still only a single
ResourceConstraint (which is in-effect immutable and is treated as an
argument
object). There is no intention that if the embedder changes
Reviewers: Sven Panne,
Message:
As discussed, moving Maybe template into public header. Let me know if you
want
it moved elsewhere in this header or want a more detailed comment.
Description:
Move Maybe template into v8.h so it can be used by SetResourceConstraints
BUG=
Please review this
On 2013/09/05 08:49:45, Sven Panne wrote:
LGTM if there is no veto from Michael. I think the right way to proceed
is to
use the new predicate for a few low-memory-device CLs and perhaps
refactor the
external API a bit if possible. I am not 100% happy with the introduction
of
magic flags,
On 2013/09/05 17:28:37, Sven Panne wrote:
On 2013/09/05 15:36:39, rmcilroy wrote:
Thanks Sven. I've had to slightly change the API to take a pointer to a
boolean
so that the setResourceConstraints will not re-set
is_memory_constrained if
the
ResourceConstraint being passed didn't have
Thanks Sven and tfarina.
Sure thing, as I mentioned in the initial message,
https://codereview.chromium.org/23480031/ shows the first intended use of
this
flag. I envisage quite a few more, for example, reducing the amount of code
inlining, changing the parameters which decide between
https://codereview.chromium.org/23464022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
lgtm
https://codereview.chromium.org/23444033/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Sven Panne,
Message:
Hi Sven, could you please review this change. An example of how this flag
will
be used is in https://codereview.chromium.org/23480031/.
Description:
Add a ResourceConstraint for the embedder to specify that V8 is running on a
memory constrained device.
This
https://codereview.chromium.org/23694014/diff/1/src/mips/macro-assembler-mips.cc
File src/mips/macro-assembler-mips.cc (right):
https://codereview.chromium.org/23694014/diff/1/src/mips/macro-assembler-mips.cc#newcode1588
src/mips/macro-assembler-mips.cc:1588: not_in_int32_range);
Any particular
https://codereview.chromium.org/23129003/diff/11001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/23129003/diff/11001/src/arm/code-stubs-arm.cc#newcode683
src/arm/code-stubs-arm.cc:683: // with exponent because Bias + 1 = 1024
which is an
701 - 765 of 765 matches
Mail list logo
