Nir Soffer has posted comments on this change.
Change subject: storage: Clean up image links during teardownImage
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55164/2//COMMIT_MSG
Commit Message:
Line 10:
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Remove stale links to image directory
..
Patch Set 1:
* #1319987::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1319987::OK, public
Nir Soffer has posted comments on this change.
Change subject: storage: Clean up image links during teardownImage
..
Patch Set 2:
And please post this to master, we should fix it in master first.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: storage: Clean up image links during teardownImage
..
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/55164/2//COMMIT_MSG
Commit Message:
Edward Haas has posted comments on this change.
Change subject: net: Adding the netswitch module
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/55131
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: Adding the netswitch module
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Allon Mureinik has posted comments on this change.
Change subject: storage: Clean up image links during teardownImage
..
Patch Set 2: Code-Review+1
seems pretty straight forward to me.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: Clean up image links during teardownImage
..
Patch Set 2:
* #1319987::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1319987::OK, public
Allon Mureinik has posted comments on this change.
Change subject: storage:
..
Patch Set 1:
Shouldn't this be posted to master first?
--
To view, visit https://gerrit.ovirt.org/55164
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: storage:
..
Patch Set 1: Verified+1
Fixes the issue in bug 1319987
--
To view, visit https://gerrit.ovirt.org/55164
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: ovs: hook: fake bridgeless networks
..
Patch Set 5:
* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867FAILED, illegal change from ON_QA
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs: hook: fake bridgeless networks
..
ovs: hook: fake bridgeless networks
Engine expects host-only networks (e.g. display or migration networks)
to
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: hook: fake bridgeless networks
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55071
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: network tests: remove bonds after use
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: network tests: remove bonds after use
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55078
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage:
..
Patch Set 1: Verified-1
* #1319987::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1319987::OK, public bug
* Check
Adam Litke has uploaded a new change for review.
Change subject: storage:
..
storage:
In commit 736ab9 we began cleaning up volume links that were created in
/var/run/vdsm/images/... Unfortunately on block domains we are
Nir Soffer has posted comments on this change.
Change subject: virt: set correct permissions for hwrng device
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/54806/4/vdsm/supervdsm_api/udev.py
File
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/1/vdsm/virt/vmdevices/core.py
File
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/1/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:
Nir Soffer has posted comments on this change.
Change subject: fileUtils: tarCopy - avoid extracting the file modified time
..
Patch Set 1: Code-Review+1
(1 comment)
Looks good, see command about using long options.
gerrit-hooks has posted comments on this change.
Change subject: fileUtils: tarCopy - avoid extracting the file modified time
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Liron Aravot has uploaded a new change for review.
Change subject: fileUtils: tarCopy - avoid extracting the file modified time
..
fileUtils: tarCopy - avoid extracting the file modified time
We using fileUtils.tarCopy() when
gerrit-hooks has posted comments on this change.
Change subject: vm: make destroy on startup return earlier
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has uploaded a new change for review.
Change subject: vm: make destroy on startup return earlier
..
vm: make destroy on startup return earlier
Change-Id: I618eb03783d7059ae33d7b0a02542b99c8d8199b
Signed-off-by:
gerrit-hooks has posted comments on this change.
Change subject: vm: serialize destroy() and creation
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: HACK: BROKEN: patch to test destroy on startup
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has uploaded a new change for review.
Change subject: vm: serialize destroy() and creation
..
vm: serialize destroy() and creation
Change-Id: I234922e46791f5baf46fcb5c790a9d386ac92371
Signed-off-by: Francesco
gerrit-hooks has posted comments on this change.
Change subject: net: Adding the netswitch module
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: vm: improve safety between startup and shutdown
..
Patch Set 8:
(1 comment)
I don't want to push obfuscated changes. let me clean up this more.
Francesco Romani has posted comments on this change.
Change subject: vm: improve safety between startup and shutdown
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/44989/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 4: Code-Review+1
looks alright. please verify both over python3 and 2
--
To view, visit https://gerrit.ovirt.org/55065
To
gerrit-hooks has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Petr Horáček has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/55065/3/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55065/3/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
File
Petr Horáček has posted comments on this change.
Change subject: netinfo: cache: get() refactoring
..
Patch Set 2:
This will not be needed for OVS and therefore could be abandoned.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: spec: bump libguestfs-tools-c requirement
..
Patch Set 4: Verified+1
we have the package on CentOS 7:
[root@goji ~]# yum info libguestfs-tools-c
Loaded
gerrit-hooks has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Milan Zamazal has posted comments on this change.
Change subject: vm: improve safety between startup and shutdown
..
Patch Set 8:
(3 comments)
I can't say there is something clearly wrong with the change, but it looks a
bit
Petr Horáček has posted comments on this change.
Change subject: ovs: hook: fake bridgeless networks
..
Patch Set 4: Verified+1
Copying v+1, only comments and commit message were changed.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: ovs: hook: fake bridgeless networks
..
Patch Set 4:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check
Edward Haas has posted comments on this change.
Change subject: net: Adding the netswitch module
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/55131/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/1/vdsm/virt/vmdevices/core.py
File
Petr Horáček has posted comments on this change.
Change subject: net: Adding the netswitch module
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55131/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: hook: fake bridgeless networks
..
Patch Set 3: Code-Review-1
could you copy the comment tweaks of https://gerrit.ovirt.org/55066 into here?
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs: hook: fake bridgeless networks
..
ovs: hook: fake bridgeless networks
Engine expects host-only networks (e.g. display or migration networks)
to
gerrit-hooks has posted comments on this change.
Change subject: ovs: hook: fake bridgeless networks
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Artyom Lukianov has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/54102/6/vdsm_hooks/checkips/README
File
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 2: Code-Review-1
I don't agree - please use same api and import python3 suppress when available.
--
To view, visit
Jenkins CI has posted comments on this change.
Change subject: vm: use proper threading.Event()s
..
Patch Set 4: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 3
--
To view,
Francesco Romani has posted comments on this change.
Change subject: vm: improve safety between startup and shutdown
..
Patch Set 8: Code-Review-1
(1 comment)
the commit message is horrible
Martin Polednik has posted comments on this change.
Change subject: vm: use proper threading.Event()s
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54792
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: use proper threading.Event()s
..
Patch Set 4:
* #912390::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#912390::OK, public bug
* Check
Martin Polednik has posted comments on this change.
Change subject: vm: improve safety between startup and shutdown
..
Patch Set 7:
(9 comments)
Not-so-well worded message, and my gerrit doesn't show +1/-1 buttons.
gerrit-hooks has posted comments on this change.
Change subject: vm: improve safety between startup and shutdown
..
Patch Set 8:
* #912390::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#912390::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: HACK: BROKEN: patch to test destroy on startup
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Milan Zamazal has posted comments on this change.
Change subject: vm: use proper threading.Event()s
..
Patch Set 3: Code-Review+1
(Assuming you fix the commit message.)
--
To view, visit https://gerrit.ovirt.org/54792
To
Martin Polednik has posted comments on this change.
Change subject: vm: use proper threading.Event()s
..
Patch Set 3: Code-Review-1
You haven't really updated the commit message you -1'd yourself?
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: caps: allow root-requiring network caps
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: caps: allow root-requiring network caps
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/55135/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS1, Line 1866:
Francesco Romani has posted comments on this change.
Change subject: hostdev: use device setup instead of detach
..
Patch Set 1: Code-Review+1
once we get setup/teardown right, this is straightforward.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: sr-iov: use device setup instead of detach
..
Patch Set 1: Code-Review+1
once we get setup/teardown right, this is straightforward.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 1: Code-Review-1
(3 comments)
I like the idea, but we need to tune some details. -1 for visibility while we
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has uploaded a new change for review.
Change subject: sr-iov: use device setup instead of detach
..
sr-iov: use device setup instead of detach
SR-IOV devices require action before VM is started. We rename this
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: use device setup instead of detach
..
hostdev: use device setup instead of detach
Host devices require action before VM is started. We rename this
gerrit-hooks has posted comments on this change.
Change subject: sr-iov: use device setup instead of detach
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: hostdev: use device setup instead of detach
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Polednik has uploaded a new change for review.
Change subject: virt: add device setup and teardown
..
virt: add device setup and teardown
More and more devices require some action to be taken before VM is
started - even
Francesco Romani has posted comments on this change.
Change subject: vm: improve safety between startup and shutdown
..
Patch Set 7: Verified+1
verification:
- non regression: created and destroyed (poweroff) VM using
Francesco Romani has posted comments on this change.
Change subject: HACK: BROKEN: patch to test destroy on startup
..
Patch Set 1: Code-Review-2 Verified-1
should never ever be merged, posted as reference only.
--
To view,
Francesco Romani has posted comments on this change.
Change subject: vm: use proper threading.Event()s
..
Patch Set 3: Verified+1
verified with 44989
--
To view, visit https://gerrit.ovirt.org/54792
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: improve safety between startup and shutdown
..
Patch Set 7:
* #912390::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#912390::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: HACK: BROKEN: patch to test destroy on startup
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: use proper threading.Event()s
..
Patch Set 3:
* #912390::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#912390::OK, public bug
* Check
Francesco Romani has uploaded a new change for review.
Change subject: HACK: BROKEN: patch to test destroy on startup
..
HACK: BROKEN: patch to test destroy on startup
*** DON'T MERGE ***
This patch intentionally breaks
gerrit-hooks has posted comments on this change.
Change subject: fix pep8 1.4.6 errors for el7 build
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fix pep8 1.4.6 errors for el7 build
..
fix pep8 1.4.6 errors for el7 build
Change-Id: Ia949c05cb82c9d79f06144a3d28d1ed41294b55d
Signed-off-by: Yaniv
Dan Kenigsberg has posted comments on this change.
Change subject: fix pep8 1.4.6 errors for el7 build
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55052
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: fix pep8 1.4.6 errors for el7 build
..
Patch Set 1: Code-Review+2 Continuous-Integration+1
yuck. when would we have our own choice of pep8 tool?
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: hook: fake bridgeless networks
..
Patch Set 4: Code-Review+2 Verified+1
Copying scores
--
To view, visit https://gerrit.ovirt.org/55066
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: ovs: hook: fake bridgeless networks
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: caps: allow root-requiring network caps
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Edward Haas has posted comments on this change.
Change subject: net: Adding the netswitch module
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55131/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: caps: allow root-requiring network caps
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Edward Haas has posted comments on this change.
Change subject: net: Adding the netswitch module
..
Patch Set 1: Code-Review-1
Add unit tests
--
To view, visit https://gerrit.ovirt.org/55131
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: Adding the netswitch module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Edward Haas has uploaded a new change for review.
Change subject: net: Adding the netswitch module
..
net: Adding the netswitch module
netswitch is placed between the network api and the switches (legacy and
future ovs), acting
gerrit-hooks has posted comments on this change.
Change subject: netinfo: cache: get() refactoring
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Petr Horáček has posted comments on this change.
Change subject: ovs: hook: fake bridgeless networks
..
Patch Set 3: Verified+1
Passed OVS tests without a regression. 'bridgeless' OVS networks are listed in
caps as bridgeless
Dan Kenigsberg has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 2: -Code-Review
none of my comments merit a -1. they can be fixed in a follow up.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55065/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 918: return
Dan Kenigsberg has submitted this change and it was merged.
Change subject: cpuarch: Move PAGE_SIZE_BYTES to cpuarch
..
cpuarch: Move PAGE_SIZE_BYTES to cpuarch
This constant is mostly related to the CPU architecture.
gerrit-hooks has posted comments on this change.
Change subject: cpuarch: Move PAGE_SIZE_BYTES to cpuarch
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: cpuarch: Move PAGE_SIZE_BYTES to cpuarch
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54990
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: use proper threading.Event()s
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/54792/2//COMMIT_MSG
Commit Message:
PS2, Line 9: palin
plain
Francesco Romani has posted comments on this change.
Change subject: vm: use proper threading.Event()s
..
Patch Set 2:
jenkins failure is unrelated:
0:08:34.061 raise JsonRpcNoResponseError(methodName)
00:08:34.061
Petr Horáček has posted comments on this change.
Change subject: ovs: hook: fake bridgeless networks
..
Patch Set 3: Verified+1
Passed OVS tests without a regression. 'bridgeless' OVS networks are listed in
caps as bridgeless
Martin Polednik has posted comments on this change.
Change subject: hostdev: expose 'driver' attribute
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/55044/3/tests/devices/data/pci__00_1a_0.xml
File
1 - 100 of 147 matches
Mail list logo