Arik Hadas has posted comments on this change.
Change subject: [WIP] use libvirt domain xml prepared in advance
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65182/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Arik Hadas has uploaded a new change for review.
Change subject: [WIP] use libvirt domain xml prepared in advance
..
[WIP] use libvirt domain xml prepared in advance
Change-Id: I469fad3ca14a6b7f4675ef5c200175053f6dd4af
Arik Hadas has posted comments on this change.
Change subject: remove unused field in vm stats
..
Patch Set 2:
Francesco, I understand the aim to preserve backward compatibility - but I
think we should be realistic, I believe
Arik Hadas has posted comments on this change.
Change subject: remove unused fields in vm stats
..
Patch Set 1: -Verified
indeed, I didn't take MOM into account.
Martin, I guess MOM needs vmName only for logging, right? and
Arik Hadas has posted comments on this change.
Change subject: remove unused fields in vm stats
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64973
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: fix comment
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64972
To unsubscribe, visit https://gerrit.ovirt.org/settings
Arik Hadas has uploaded a new change for review.
Change subject: fix comment
..
fix comment
The comment on _getConfigVmStats mention the 'display' field
but this field is no longer set in this method, thus this
part is removed.
Arik Hadas has uploaded a new change for review.
Change subject: remove unused fields in vm stats
..
remove unused fields in vm stats
The values of 'vmName' and 'vmType' are not read by the engine,
thus removed. The value of
Arik Hadas has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py
File vdsm/API.py:
Line 263: """
Line 264:
Arik Hadas has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py
File vdsm/API.py:
Line 263: """
Line 264:
Arik Hadas has posted comments on this change.
Change subject: vm: always expect Vm devices to be sent
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60322
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56805
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: virt: Set timeout on boot menu
..
Patch Set 3:
I don't see why to make it configurable per-VM unless someone explicitly asks
for that.
but I agree with Nir that
Arik Hadas has posted comments on this change.
Change subject: vm: Support for non-ascii vm name
..
Patch Set 1: Code-Review+1
The engine does not use the name in VDSM and all interactions between the
engine and VDSM
Arik Hadas has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2: Code-Review+1
yeah, if memory snapshot is not taken along with disk snapshots, as it seems to
be the
Arik Hadas has posted comments on this change.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
Patch Set 1:
> @Michal/Arik - shouldn't we support previewing a memory snapshot
> without disks?
We
Arik Hadas has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 13:
Roy, Martin - seems like SLA stuff, please review
--
To view, visit
Arik Hadas has uploaded a new change for review.
Change subject: virt: hibernation - use r+ to open vm conf file
..
virt: hibernation - use r+ to open vm conf file
Complementary part of Ic6799e07898155fd4a630bfaf4151ea9ccdcee49
Arik Hadas has posted comments on this change.
Change subject: virt: hibernation - use r+ to open vm conf file
..
Patch Set 1:
or not to backport. I did it on master so hibernation and memory snapshot will
be consistent, but
Arik Hadas has posted comments on this change.
Change subject: virt: hibernation - use r+ to open vm conf file
..
Patch Set 1:
Nir, this is not really part of bz 1282239 and without bz we cannot backport -
do we want to
Arik Hadas has abandoned this change.
Change subject: virt: hibernation - use r+ to open vm conf file
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/48915
To unsubscribe, visit https://gerrit.ovirt.org/settings
Arik Hadas has posted comments on this change.
Change subject: virt: hibernation - use r+ to open vm conf file
..
Patch Set 2:
Done
--
To view, visit https://gerrit.ovirt.org/48826
To unsubscribe, visit
Arik Hadas has abandoned this change.
Change subject: proposal for bz 1282239
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/48844
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Arik Hadas has posted comments on this change.
Change subject: proposal for bz 1282239
..
Patch Set 4:
Yeah that's another option. Currently VDSM does not know that it operates on
metadata volume, if we break this assumption
Arik Hadas has uploaded a new change for review.
Change subject: virt: hibernation - use r+ to open vm conf file
..
virt: hibernation - use r+ to open vm conf file
Complementary part of Ic6799e07898155fd4a630bfaf4151ea9ccdcee49
Arik Hadas has posted comments on this change.
Change subject: virt: hibernation - use r+ to open vm conf file
..
Patch Set 2:
Done
--
To view, visit https://gerrit.ovirt.org/48826
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: virt: hibernation - use r+ to open vm conf file
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/48826
To unsubscribe, visit
Arik Hadas has uploaded a new change for review.
Change subject: proposal for bz 1282239
..
proposal for bz 1282239
Change-Id: Idace47c18673e250f3f612a20a15ae5c62565082
Signed-off-by: Arik Hadas
---
M
Arik Hadas has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 3: Code-Review+1
(2 comments)
minor comments inside. very important patch for import VMs using
Arik Hadas has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7: Code-Review-1
the verification is not complete - it is not enough to validate import of OVA
file, but import
Arik Hadas has posted comments on this change.
Change subject: v2v: Try to be nicer to other processes
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43817
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: v2v: Try to be nicer to other processes
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/43817
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: v2v: get VM information from OVA file
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/43271/4/vdsm/v2v.py
File vdsm/v2v.py:
Line 175: root =
Arik Hadas has posted comments on this change.
Change subject: v2v: Import VM from OVA file
..
Patch Set 2: Verified-1
(1 comment)
https://gerrit.ovirt.org/#/c/43367/2/vdsm/v2v.py
File vdsm/v2v.py:
Line 349: def
Arik Hadas has posted comments on this change.
Change subject: v2v: enable to use external virtio drivers for virtio
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/42996/2/vdsm/v2v.py
File vdsm/v2v.py:
Line 375:
Arik Hadas has posted comments on this change.
Change subject: v2v: handle exception on probing external VMs
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43259/1//COMMIT_MSG
Commit Message:
Line 7: v2v: handle
Arik Hadas has posted comments on this change.
Change subject: v2v: enable to use external virtio drivers for virtio
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42996
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: events: make sure to send only one event per status
..
Patch Set 2: Verified+1
(1 comment)
got one event for Down (the bug on engine side where the event is
Arik Hadas has posted comments on this change.
Change subject: events: send event explicitly after vm was started
..
Patch Set 2: Verified+1
with no polls, VM status is now switched to PoweringUp. Note that in such setup
and
Arik Hadas has posted comments on this change.
Change subject: virt: Additional reporting of CPU usage in ns
..
Patch Set 5:
is it possible that if I don't have guest-agent, I'll get the following error?
Arik Hadas has posted comments on this change.
Change subject: vm: add missing vm id to get stats of down vm
..
Patch Set 2:
@Francesco, I think the old code added the vm id automatically and now with
json it is not.
Arik Hadas has uploaded a new change for review.
Change subject: vm: add missing vm id to get stats of down vm
..
vm: add missing vm id to get stats of down vm
The stats that are returned for a VM which is down does not
Arik Hadas has posted comments on this change.
Change subject: vm: add missing vm id to get stats of down vm
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/37694
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: vm: leave VM responsive when sampling ends
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35902
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: Always use OOP when padding snapshot's memory volume
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26538/2//COMMIT_MSG
Commit Message:
Line 8:
Line 9:
Arik Hadas has posted comments on this change.
Change subject: always teardown snapshot's memory volume
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/26544
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: keep pauseCode when migrating paused VM
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/27801/3//COMMIT_MSG
Commit Message:
Line 6:
Line 7: keep
Arik Hadas has posted comments on this change.
Change subject: keep pauseCode when migrating paused VM
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27801/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1957:
Arik Hadas has posted comments on this change.
Change subject: keep pauseCode when migrating paused VM
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27801/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1957:
Arik Hadas has posted comments on this change.
Change subject: always teardown snapshot's memory volume
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/26544/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3649:
Arik Hadas has posted comments on this change.
Change subject: do not use OOP for padding snapshot's memory volume
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26538/1//COMMIT_MSG
Commit Message:
Line 3:
Arik Hadas has uploaded a new change for review.
Change subject: keep pauseCode when migrating paused VM
..
keep pauseCode when migrating paused VM
This patch fix a bug where the pauseCode is cleared on the destination
host
Arik Hadas has posted comments on this change.
Change subject: keep pauseCode when migrating paused VM
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/27801
To unsubscribe, visit
Hello Federico Simoncelli, Vinzenz Feenstra, Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/26594
to review the following change.
Change subject: pad memory volume only when the storage domain is file based
Arik Hadas has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/26594
To unsubscribe, visit
Arik Hadas has uploaded a new change for review.
Change subject: do not use OOP for padding snapshot's memory volume
..
do not use OOP for padding snapshot's memory volume
Change-Id: I2a94354e188019f3afd209633979ec5a5b35293b
Arik Hadas has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/26407/3/vdsm/virt/vm.py
File
Arik Hadas has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 3:
(3 comments)
http://gerrit.ovirt.org/#/c/26407/3/vdsm/virt/vm.py
File
Arik Hadas has uploaded a new change for review.
Change subject: pad memory volume only when the storage domain is file based
..
pad memory volume only when the storage domain is file based
Memory volume should be padded only
Arik Hadas has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/26407
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26407/2//COMMIT_MSG
Commit Message:
Line 8:
Arik Hadas has abandoned this change.
Change subject: remove irs_enable configuration attribute
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/21141
To unsubscribe, visit http://gerrit.ovirt.org/settings
Arik Hadas has uploaded a new change for review.
Change subject: create VMs in a bulk
..
create VMs in a bulk
Change-Id: Ifd50b9fc694ec7c84b3b39f3d11edb1495842244
Signed-off-by: Arik Hadas aha...@redhat.com
---
M vdsm/API.py
M
Arik Hadas has posted comments on this change.
Change subject: remove irs_enable configuration attribute
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21141
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: remove irs_enable configuration attribute
..
Patch Set 2:
(3 comments)
Commit Message
Line 5: CommitDate:
Arik Hadas has posted comments on this change.
Change subject: remove irs_enable configuration attribute
..
Patch Set 2:
(1 comment)
Commit Message
Line 5: CommitDate:
Arik Hadas has posted comments on this change.
Change subject: vm: Pause vm in case volume allocation is greater than lv size
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19719
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: reduce the time VM is paused in snapshot with RAM creation
..
Patch Set 2:
(1 comment)
Commit Message
Line 9:
Arik Hadas has posted comments on this change.
Change subject: reduce the time VM is paused in snapshot with RAM creation
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19296
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: reduce the time VM is paused in snapshot with RAM creation
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line
Arik Hadas has uploaded a new change for review.
Change subject: reduce the time VM is paused in snapshot with RAM creation
..
reduce the time VM is paused in snapshot with RAM creation
By using libvirt's
Arik Hadas has uploaded a new change for review.
Change subject: do not rely on default values on restoreFlags invocation
..
do not rely on default values on restoreFlags invocation
The signature of libvirt's verb
Arik Hadas has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1:
yes but the current dependencies configuration is ok since we require libvirt
=
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 20: Verified
--
To view, visit http://gerrit.ovirt.org/15072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 17: (7 inline comments)
File vdsm/BindingXMLRPC.py
Line 287:
Line
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 19: (2 inline comments)
File vdsm/vm.py
Line 3573: try:
Line
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 17: Verified
--
To view, visit http://gerrit.ovirt.org/15072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 18: Verified
--
To view, visit http://gerrit.ovirt.org/15072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 12: (8 inline comments)
File vdsm/vm.py
Line 2852: if
Arik Hadas has posted comments on this change.
Change subject: clientIF: automatically unpause vms in EIO when SD becomes
active
..
Patch Set 2: (2 inline comments)
File
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 10: (2 inline comments)
File vdsm/vm.py
Line 3536:
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 12: Verified
--
To view, visit http://gerrit.ovirt.org/15072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Arik Hadas has posted comments on this change.
Change subject: clientIF: automatically unpause vms in EIO when SD becomes
active
..
Patch Set 2: (1 inline comment)
File
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 9:
add padding to the memory dump file to handle qemu's truncation during export
--
To view, visit
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 9: (1 inline comment)
File vdsm/vm.py
Line 3578: # We are
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 7: (8 inline comments)
File vdsm/BindingXMLRPC.py
Line 279: def
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 6: (3 inline comments)
File vdsm/hooks.py
Line 188:
Line 189:
Line 190:
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/15072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Arik Hadas has uploaded a new change for review.
Change subject: fix for after_vm_dehibernate hook not being called
..
fix for after_vm_dehibernate hook not being called
Due to what seems to be a copy-paste or typo problem, the
Arik Hadas has posted comments on this change.
Change subject: fix for after_vm_dehibernate hook not being called
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15656
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 6:
modified the after/before_vm_dehibernate hooks to get parameters, and add
'backToSnapshot' parameter which is of boolean
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/15072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 1: (1 inline comment)
File vdsm/BindingXMLRPC.py
Line 279: def
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 3:
updated vdsmapi-schema.json but I'm not sure how to verify it..
--
To view, visit http://gerrit.ovirt.org/15072
To
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/15072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 1: (1 inline comment)
File vdsm/BindingXMLRPC.py
Line 279: def
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 1: (1 inline comment)
File vdsm/BindingXMLRPC.py
Line 279: def
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 1: (1 inline comment)
File vdsm/BindingXMLRPC.py
Line 279: def
Arik Hadas has uploaded a new change for review.
Change subject: RAM snapshots feature
..
RAM snapshots feature
This patch adds the ability to take live snapshot of a VM that includes
its memory state, and to restore memory
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15072
To unsubscribe, visit http://gerrit.ovirt.org/settings
100 matches
Mail list logo