Ayal Baron has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 38:
Dan, this is patchset number 37. The patch started out as seperate patches and
that didn't make sense (there is
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 39: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(1 comment)
File vdsm/vm.py
Line 1729: self.timeout
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 39:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6114/ : SUCCESS
Martin Betak has abandoned this change.
Change subject: vdsm: Reboot capability for VM
..
Abandoned
Abandoned in favor of a more lightweight patch http://gerrit.ovirt.org/22440
adding only guest agent reboot support without
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(1 comment)
File vdsm/vm.py
Line 1764: # flag for
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(6 comments)
File vdsm/vm.py
Line 1729:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 38: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 38:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5987/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(2 comments)
File vdsm/vm.py
Line 1729:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 38: Code-Review-1
Maybe it would be easier for me to follow if you move the current shutdown
implementation to the
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(6 comments)
I find it hard to digest the VmPowerDown class. To me it seems that it could be
replaced by a
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5874/ : SUCCESS
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File vdsm/vm.py
Line 1790:
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File client/vdsClient.py
Line 1922:
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File vdsm/vm.py
Line 1725:
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File vdsm/vm.py
Line 1726:
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35: Code-Review+1
I see just minor comments. +1
--
To view, visit http://gerrit.ovirt.org/15829
To
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(2 comments)
File client/vdsClient.py
Line 1922:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 36:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5859/ : SUCCESS
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 34:
(1 comment)
File vdsm/vm.py
Line 1747:
Line 1748:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4895/ : SUCCESS
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 34:
(1 comment)
File vdsm/vm.py
Line 1747:
Line 1748:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File vdsm/vm.py
Line 1790:
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 33:
(1 comment)
File vdsm/vm.py
Line 1780: while
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 33:
(1 comment)
File vdsm/vm.py
Line 1780: while not
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 34: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 34:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4876/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 32:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4800/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 33:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4802/ : SUCCESS
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 33: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 31: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 31:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4731/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 30:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4659/ : SUCCESS
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 30: Verified+1
The retry check success mechanism in VmPowerDown enabled us to drop support
for timeouts in
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 29:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4577/ : SUCCESS
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 28:
(4 comments)
File vdsm/vm.py
Line 1734:
Line 1735:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 28: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5039/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 27: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5010/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 26: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5007/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 25: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4669/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 25: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4537/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 24: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4406/ : SUCCESS
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
and we still have one working on engine as a backup, we'll use him as a last
resort;-)
--
To view,
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
+1 for tests and split
also please make sure the logic is to follow the grace period as configured in
all
Martin Sivák has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
Dan: IIRC the checkSuccess approach was just a convenient way of doing this
without having to pass the callback
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
Dan: First of all, sorry for this incomplete patch set. Its purpose was to
serve as a quick check if all the
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
Sorry folks, I think I got confused by the multiplicity of Martins..
--
To view, visit
Martin Sivák has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 22:
(6 comments)
Ok, I went through what we have now and it got so much bigger than what I saw
at the beginning.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4338/ : SUCCESS
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 22:
(1 comment)
File vdsm/guestIF.py
Line 298:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23: Code-Review-1
Martin, when I've asked for an explanation about the benefits of using
checkSuccess, I really
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 22: Code-Review-1
(7 comments)
File lib/vdsm/utils.py
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 22:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4287/ : SUCCESS
Peter V. Saveliev has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 22: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 22: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 20:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4280/ : SUCCESS
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 21: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 21:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4281/ : SUCCESS
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 19:
(1 comment)
File vdsm/vm.py
Line 2413: def
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 19: Code-Review-1
(1 comment)
File lib/vdsm/utils.py
Line
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 19:
(1 comment)
File vdsm/vm.py
Line 2413: def
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18: Code-Review-1
(1 comment)
File vdsm/vm.py
Line
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18: Code-Review-1
(1 comment)
File vdsm/vm.py
Line 1631:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18:
(1 comment)
File vdsm/vm.py
Line 1631:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 19:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4194/ : SUCCESS
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 19: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Peter V. Saveliev has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 19: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17: Code-Review-1
(1 comment)
-1 for visibility, awaiting answer.
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17:
(1 comment)
File vdsm/vm.py
Line 1631:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17:
(1 comment)
File vdsm/vm.py
Line 1619: return m
Giuseppe Vallarelli has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17: Code-Review-1
(1 comment)
File vdsm/vm.py
Line 1619:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4043/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18: -Code-Review
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4043/ : SUCCESS
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 16: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4018/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17:
(1 comment)
File vdsm/vm.py
Line 1619:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3954/ : SUCCESS
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 15: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3852/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 15:
(6 comments)
Generally it looks good, I appreciate your good will of adding docstrings you
might think
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14:
(7 comments)
File lib/vdsm/utils.py
Line 913:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2695/ : SUCCESS
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14: Verified
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Sivák has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe,
Martin Sivák has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 13: I would prefer that you didn't submit this
(1 inline comment)
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 12: (6 inline comments)
File lib/vdsm/utils.py
Line 929:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2546/ : SUCCESS
Martin Sivák has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 12: I would prefer that you didn't submit this
(7 inline comments)
I think it is reasonably good, but I have some
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 12: Verified
New callback design, with support of QEMU-GA.
--
To view, visit http://gerrit.ovirt.org/15829
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2470/ : SUCCESS
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 10: (1 inline comment)
File vdsm/vm.py
Line 4099: def
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
1 - 100 of 111 matches
Mail list logo
