Change in vdsm[master]: jsonrpc: Return back mistakenly removed line in _serveRequest

Milan Zamazal has abandoned this change. Change subject: jsonrpc: Return back mistakenly removed line in _serveRequest .. Abandoned Piotr was faster. :-) -- To view, visit https://gerrit.ovirt.org/59470 To unsubscribe, visit

Change in vdsm[master]: build: Make sure run_tests*.sh scripts are executable

Milan Zamazal has posted comments on this change. Change subject: build: Make sure run_tests*.sh scripts are executable .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/55949/5/build-aux/Makefile.subs File

Change in vdsm[master]: api: Move after_get_all_vm_stats hook from API to clientIF

Milan Zamazal has posted comments on this change. Change subject: api: Move after_get_all_vm_stats hook from API to clientIF .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/59393/1/vdsm/API.py File vdsm/API.py: Line

Change in vdsm[master]: API: allow setLogLevel to tune a specific logger

Milan Zamazal has posted comments on this change. Change subject: API: allow setLogLevel to tune a specific logger .. Patch Set 19: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/38426/15/vdsm/API.py File vdsm/API.py:

Change in vdsm[master]: build: Make sure run_tests*.sh scripts are executable

Milan Zamazal has posted comments on this change. Change subject: build: Make sure run_tests*.sh scripts are executable .. Patch Set 7: Verified+1 Verified by running the examples from the commit messages and checking relative

Change in vdsm[master]: git: Add .tox to .gitignore

Milan Zamazal has uploaded a new change for review. Change subject: git: Add .tox to .gitignore .. git: Add .tox to .gitignore Change-Id: I1fef9ed25526ff1d6ac5a87a648ef45e65203b0b Signed-off-by: Milan Zamazal

Change in vdsm[master]: build: Make sure run_tests*.sh scripts are executable

Milan Zamazal has posted comments on this change. Change subject: build: Make sure run_tests*.sh scripts are executable .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/55949/5/build-aux/Makefile.subs File

Change in vdsm[master]: rpc: Log important info from VM stats

Milan Zamazal has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 27: (3 comments) https://gerrit.ovirt.org/#/c/58465/26/tests/Makefile.am File tests/Makefile.am: PS26, Line

Change in vdsm[master]: tox: Exclude all dotted files from pep8 check

Milan Zamazal has uploaded a new change for review. Change subject: tox: Exclude all dotted files from pep8 check .. tox: Exclude all dotted files from pep8 check pep8 breaks on files in .ropeproject, created by Python rope

Change in vdsm[master]: rpc: Log RPC call summary on info level

Milan Zamazal has posted comments on this change. Change subject: rpc: Log RPC call summary on info level .. Patch Set 15: Verified+1 Verified that the calls are logged as expected. -- To view, visit

Change in vdsm[master]: logging: Introduce throttledlog

Milan Zamazal has posted comments on this change. Change subject: logging: Introduce throttledlog .. Patch Set 4: Verified+1 Verified by running the tests and by verifying the following patch. -- To view, visit

Change in vdsm[master]: virt: Correct disconnectAction parameter extraction

Milan Zamazal has posted comments on this change. Change subject: virt: Correct disconnectAction parameter extraction .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59692 To unsubscribe, visit

Change in vdsm[master]: rpc: Log also error codes of RPC calls

Milan Zamazal has posted comments on this change. Change subject: rpc: Log also error codes of RPC calls .. Patch Set 13: Verified+1 Verified that the response codes are logged as expected for both jsonrpc and xmlrpc, success

Change in vdsm[master]: git: Add .tox to .gitignore

Milan Zamazal has posted comments on this change. Change subject: git: Add .tox to .gitignore .. Patch Set 1: Verified+1 Verified that git ignores .tox directory. -- To view, visit https://gerrit.ovirt.org/59676 To

Change in vdsm[master]: tox: Exclude .ropeproject from pep8 check

Milan Zamazal has posted comments on this change. Change subject: tox: Exclude .ropeproject from pep8 check .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/59677/1//COMMIT_MSG Commit Message: Line 8: Line 9: pep8

Change in vdsm[master]: rpc: Log important info from VM stats

Milan Zamazal has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 27: Verified+1 Verified that all VM stats are logged periodically as expected. -- To view, visit

Change in vdsm[master]: tox: Exclude .ropeproject from pep8 check

Milan Zamazal has posted comments on this change. Change subject: tox: Exclude .ropeproject from pep8 check .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59677/2/tox.sh File tox.sh: Line 25: Line 26: if [

Change in vdsm[master]: virt: Limit the number of workers in executor

Milan Zamazal has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 14: Missing comma in a tuple added. -- To view, visit https://gerrit.ovirt.org/57754 To

Change in vdsm[master]: jsonrpc: Return back mistakenly removed line in _serveRequest

Milan Zamazal has uploaded a new change for review. Change subject: jsonrpc: Return back mistakenly removed line in _serveRequest .. jsonrpc: Return back mistakenly removed line in _serveRequest In commit f3ad425, one code line

Change in vdsm[master]: rpc: Use Suppressed class instead of logging workarounds

Milan Zamazal has posted comments on this change. Change subject: rpc: Use Suppressed class instead of logging workarounds .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/59078/5/lib/yajsonrpc/__init__.py File

Change in vdsm[master]: virt: Improve thread safety of discarding executor workers

Milan Zamazal has posted comments on this change. Change subject: virt: Improve thread safety of discarding executor workers .. Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/58146/6/lib/vdsm/executor.py File

Change in vdsm[master]: virt: Improve thread safety of discarding executor workers

Milan Zamazal has posted comments on this change. Change subject: virt: Improve thread safety of discarding executor workers .. Patch Set 9: (2 comments) I reworded and clarified the commit message.

Change in vdsm[master]: logging: throttledlog introduced

Milan Zamazal has uploaded a new change for review. Change subject: logging: throttledlog introduced .. logging: throttledlog introduced In some situations, we want to log interesting information. A natural place to retrieve

Change in vdsm[master]: rpc: Log important info from VM stats

Milan Zamazal has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 22: (4 comments) > Please separate the throttledlog and its test to another patch. Done.

Change in vdsm[master]: rpc: Log also error codes of RPC calls

Milan Zamazal has posted comments on this change. Change subject: rpc: Log also error codes of RPC calls .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/59234/4/lib/yajsonrpc/__init__.py File

Change in vdsm[master]: rpc: Log RPC call summary on info level

Milan Zamazal has posted comments on this change. Change subject: rpc: Log RPC call summary on info level .. Patch Set 10: We put _serveRequest responses into the context at a single place now, as was suggested in the

Change in vdsm[master]: logging: throttledlog introduced

Milan Zamazal has posted comments on this change. Change subject: logging: throttledlog introduced .. Patch Set 2: Unused import removed. -- To view, visit https://gerrit.ovirt.org/59461 To unsubscribe, visit

Change in vdsm[master]: logstat: Fix build by distributing contrib/logstat

Milan Zamazal has posted comments on this change. Change subject: logstat: Fix build by distributing contrib/logstat .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59507 To unsubscribe, visit

Change in vdsm[master]: rpc: Log important info from VM stats

Milan Zamazal has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 17: Based on Nir's suggestion and the recent discussion elsewhere, I drafted https://gerrit.ovirt.org/59339.

Change in vdsm[master]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

Milan Zamazal has uploaded a new change for review. Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to response .. jsonrpc: Pass JsonRpcInternalError instance, not class, to response If there is a

Change in vdsm[master]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

Milan Zamazal has posted comments on this change. Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to response .. Patch Set 1: Verified+1 The bug can be reproduced by changing `res' at the last line of

Change in vdsm[master]: rpc: Log important info from VM stats

Milan Zamazal has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/59339/1/lib/vdsm/rpc/bindingxmlrpc.py File

Change in vdsm[master]: doc: Typo fixes and other doc improvements in periodic.py

Milan Zamazal has uploaded a new change for review. Change subject: doc: Typo fixes and other doc improvements in periodic.py .. doc: Typo fixes and other doc improvements in periodic.py This is a documentation only change to

Change in vdsm[master]: virt: Limit the number of workers in executor

Milan Zamazal has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 13: (13 comments) https://gerrit.ovirt.org/#/c/57754/12/lib/vdsm/executor.py File

Change in vdsm[master]: virt: Add info about the number of run tasks in executor wor...

Milan Zamazal has posted comments on this change. Change subject: virt: Add info about the number of run tasks in executor workers .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59048/1/lib/vdsm/executor.py File

Change in vdsm[master]: virt: Add docstrings about Executor parameters and behavior

Milan Zamazal has posted comments on this change. Change subject: virt: Add docstrings about Executor parameters and behavior .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/57972/8/lib/vdsm/executor.py File

Change in vdsm[master]: lib: avoid circular references due to wrapping

Milan Zamazal has posted comments on this change. Change subject: lib: avoid circular references due to wrapping .. Patch Set 2: Making an object uncollectable (by having __del__ and reference to itself in it) is a problem

Change in vdsm[master]: virt: Don't create on non-x86 architectures

Milan Zamazal has uploaded a new change for review. Change subject: virt: Don't create on non-x86 architectures .. virt: Don't create on non-x86 architectures We introduced ovirt-vmconsole access to BIOS some time ago. But

Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

Milan Zamazal has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 4: Shallow copy is back; corresponding comments added to the code and commit message. -- To

Change in vdsm[master]: vm: make _deleteVm() more robust

Milan Zamazal has posted comments on this change. Change subject: vm: make _deleteVm() more robust .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51385 To unsubscribe, visit

Change in vdsm[master]: vm: make deleteVm private

Milan Zamazal has posted comments on this change. Change subject: vm: make deleteVm private .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51384 To unsubscribe, visit

Change in vdsm[master]: virt: Don't create on non-x86 architectures

Milan Zamazal has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51648/1/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line

Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

Milan Zamazal has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 4: Verified+1 Verified by running vdsClient 0 getAllVmStats and checking that reported

Change in vdsm[master]: virt: Don't create on non-x86 architectures

Milan Zamazal has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 2: Verified+1 Verified for x86 that useserial is still in the domain XML. -- To view, visit

Change in vdsm[master]: virt: Don't create on non-x86 architectures

Milan Zamazal has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/51648/2//COMMIT_MSG Commit Message: Line 5: CommitDate:

Change in vdsm[master]: utils: add weakmethod helper

Milan Zamazal has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/51865/4//COMMIT_MSG Commit Message: Line 13: an ... a ... Line 14:

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Milan Zamazal has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/51630/8//COMMIT_MSG Commit Message: Line 28: friandly

Change in vdsm[master]: tests: extend coverage for vmstats.disks()

Milan Zamazal has posted comments on this change. Change subject: tests: extend coverage for vmstats.disks() .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51854 To unsubscribe, visit

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Milan Zamazal has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51630 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: migration: use context manager for semaphore

Milan Zamazal has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51827 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: vm: safer handling of conf in restore

Milan Zamazal has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51829 To unsubscribe, visit

Change in vdsm[master]: virt: stats: make disk_rate more robust

Milan Zamazal has posted comments on this change. Change subject: virt: stats: make disk_rate more robust .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48493 To unsubscribe, visit

Change in vdsm[master]: virt: stats: make _disk_iops_bytes more robust

Milan Zamazal has posted comments on this change. Change subject: virt: stats: make _disk_iops_bytes more robust .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50594 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: virt: safer handling of migration parameters

Milan Zamazal has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51828 To unsubscribe, visit

Change in vdsm[master]: host: use cpuarch

Milan Zamazal has posted comments on this change. Change subject: host: use cpuarch .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51434 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: supervdsm: use cpuarch

Milan Zamazal has posted comments on this change. Change subject: supervdsm: use cpuarch .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51433 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: virt: stats: make compute_latency more robust

Milan Zamazal has posted comments on this change. Change subject: virt: stats: make compute_latency more robust .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50593 To unsubscribe, visit

Change in vdsm[master]: dsaversion: use cpuarch

Milan Zamazal has posted comments on this change. Change subject: dsaversion: use cpuarch .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51719 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: tests: improve vmstats.disks coverage

Milan Zamazal has posted comments on this change. Change subject: tests: improve vmstats.disks coverage .. Patch Set 4: (1 comment) I think the tests checking for missing stats are intended to report that corresponding

Change in vdsm[master]: vm: delete recovery file only after destroy()

Milan Zamazal has posted comments on this change. Change subject: vm: delete recovery file only after destroy() .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51799/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line

Change in vdsm[master]: vm: delete recovery file only after destroy()

Milan Zamazal has posted comments on this change. Change subject: vm: delete recovery file only after destroy() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51799 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: virt: Don't expose GuestAgent.guestInfo directly

Hello Nir Soffer, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/52335 to review the following change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. virt:

Change in vdsm[ovirt-3.6]: virt: Don't expose GuestAgent.guestInfo directly

Milan Zamazal has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 1: Verified+1 Verified by repeatedly invoking `vdsClient 0 getAllVmStats' and checking memUsage

Change in vdsm[ovirt-3.5]: vm: safer handling of conf in restore

Milan Zamazal has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52343 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: virt: safer handling of migration parameters

Milan Zamazal has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52342 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: migration: use context manager for semaphore

Milan Zamazal has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52341 To unsubscribe, visit

Change in vdsm[master]: tests: extend coverage for vmstats.disks()

Milan Zamazal has posted comments on this change. Change subject: tests: extend coverage for vmstats.disks() .. Patch Set 2: Code-Review-1 (2 comments) Fine for me except the PEP8 violation and the typo in the commit message.

Change in vdsm[master]: tests: improve vmstats.disks coverage

Milan Zamazal has posted comments on this change. Change subject: tests: improve vmstats.disks coverage .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50598 To unsubscribe, visit

Change in vdsm[master]: vm: Remove useless volume size monitoring

Milan Zamazal has posted comments on this change. Change subject: vm: Remove useless volume size monitoring .. Patch Set 1: Code-Review+1 Not that I completely understand everything here, but I can't see any obvious error.

Change in vdsm[master]: vm: devices: drop support for ancient Engines

Milan Zamazal has posted comments on this change. Change subject: vm: devices: drop support for ancient Engines .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49173 To unsubscribe, visit

Change in vdsm[master]: virt: Pass missing parameter on desktopLogoff

Milan Zamazal has posted comments on this change. Change subject: virt: Pass missing parameter on desktopLogoff .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59866 To unsubscribe, visit

Change in vdsm[master]: build: Make sure run_tests*.sh scripts are executable

Milan Zamazal has posted comments on this change. Change subject: build: Make sure run_tests*.sh scripts are executable .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/55949/7//COMMIT_MSG Commit Message: Line 19:

Change in vdsm[master]: api: Move after_get_all_vm_stats hook from API to clientIF

Milan Zamazal has uploaded a new change for review. Change subject: api: Move after_get_all_vm_stats hook from API to clientIF .. api: Move after_get_all_vm_stats hook from API to clientIF We call after_get_all_vm_stats in

Change in vdsm[master]: rpc: Log RPC call summary on info level

Milan Zamazal has posted comments on this change. Change subject: rpc: Log RPC call summary on info level .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/59080/3/lib/vdsm/rpc/bindingxmlrpc.py File

Change in vdsm[master]: rpc: Log important info from VM stats

Milan Zamazal has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 18: Based on several discussions and Nir's comments in the experimental draft patch referenced above, I

Change in vdsm[master]: rpc: Log also error codes of RPC calls

Milan Zamazal has posted comments on this change. Change subject: rpc: Log also error codes of RPC calls .. Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/59234/1/lib/vdsm/rpc/bindingxmlrpc.py File

Change in vdsm[master]: doc: Typo fixes in utils.monotonic_time docstring

Milan Zamazal has uploaded a new change for review. Change subject: doc: Typo fixes in utils.monotonic_time docstring .. doc: Typo fixes in utils.monotonic_time docstring Change-Id: I0dc1560e81783a7c169896c235b043f50484cc97

Change in vdsm[master]: doc: Typo fixes in utils.monotonic_time docstring

Milan Zamazal has posted comments on this change. Change subject: doc: Typo fixes in utils.monotonic_time docstring .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/59295/1/lib/vdsm/utils.py File lib/vdsm/utils.py:

Change in vdsm[master]: doc: Typo fixes in utils.monotonic_time docstring

Milan Zamazal has posted comments on this change. Change subject: doc: Typo fixes in utils.monotonic_time docstring .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59295/1/lib/vdsm/utils.py File lib/vdsm/utils.py:

Change in vdsm[master]: rpc: Log important info from VM stats

Milan Zamazal has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 1: Thank you, Nir, for the comments. I considered them when updating the corresponding patch in

Change in vdsm[master]: api: Move after_get_all_vm_stats hook from API to clientIF

Milan Zamazal has posted comments on this change. Change subject: api: Move after_get_all_vm_stats hook from API to clientIF .. Patch Set 1: So can we perform the logging in API.py or not? We should have logging and the

Change in vdsm[master]: api: Move after_get_all_vm_stats hook from API to clientIF

Milan Zamazal has posted comments on this change. Change subject: api: Move after_get_all_vm_stats hook from API to clientIF .. Patch Set 1: > Let's have both hooks in the same place. I think there's no disagreement about

Change in vdsm[master]: rpc: Log important info from VM stats

Milan Zamazal has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 19: Added missing absolute_import to throttledlog.py. -- To view, visit https://gerrit.ovirt.org/58465 To

Change in vdsm[master]: rpc: Log also error codes of RPC calls

Milan Zamazal has posted comments on this change. Change subject: rpc: Log also error codes of RPC calls .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/59234/4/lib/yajsonrpc/__init__.py File

Change in vdsm[master]: vm: Refine needsDriveMonitoring docstring

Milan Zamazal has posted comments on this change. Change subject: vm: Refine needsDriveMonitoring docstring .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59902 To unsubscribe, visit

Change in vdsm[master]: contrib: schema converter

Milan Zamazal has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 4: Looking at the converted output randomly with my limited knowledge, it looks basically fine to me. A couple of notes:

Change in vdsm[master]: virt: Fix of uninitialized variable access in Vm.setLinkAndN...

Milan Zamazal has posted comments on this change. Change subject: virt: Fix of uninitialized variable access in Vm.setLinkAndNetwork() .. Patch Set 2: I'm not sure how to verify this change as making a working test or run for

Change in vdsm[master]: virt: vm: Fix of _filterSnappableDiskDevices indentation

Milan Zamazal has uploaded a new change for review. Change subject: virt: vm: Fix of _filterSnappableDiskDevices indentation .. virt: vm: Fix of _filterSnappableDiskDevices indentation The function body is indented too much and

Change in vdsm[master]: virt: vm: Fix of _filterSnappableDiskDevices indentation

Milan Zamazal has posted comments on this change. Change subject: virt: vm: Fix of _filterSnappableDiskDevices indentation .. Patch Set 1: Verified+1 Verified by running tests. Although this code is not covered, vm.py is still

Change in vdsm[master]: logging: Don't crash on non-ASCII in SimpleLogAdapter

Milan Zamazal has abandoned this change. Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter .. Abandoned Superseded by https://gerrit.ovirt.org/48661. -- To view, visit https://gerrit.ovirt.org/48542 To

Change in vdsm[master]: periodic: ignore known-benign libvirt errors

Milan Zamazal has posted comments on this change. Change subject: periodic: ignore known-benign libvirt errors .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52884 To unsubscribe, visit

Change in vdsm[master]: virt: s/vm._dom.XMLDesc(0)/vm.xml/g

Milan Zamazal has posted comments on this change. Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g .. Patch Set 1: (2 comments) Nice change! Just a question about using @property.

Change in vdsm[master]: periodic: silence useless log

Milan Zamazal has posted comments on this change. Change subject: periodic: silence useless log .. Patch Set 2: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/52895/2//COMMIT_MSG Commit Message: Line 17: operation

Change in vdsm[master]: virt: migration: initialize SourceThread._destServer on __in...

Milan Zamazal has posted comments on this change. Change subject: virt: migration: initialize SourceThread._destServer on __init__ .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52897 To unsubscribe,

Change in vdsm[master]: vmstats: remove useless short stacktrace

Milan Zamazal has posted comments on this change. Change subject: vmstats: remove useless short stacktrace .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/52894/2//COMMIT_MSG Commit Message: Line 9:

Change in vdsm[master]: periodic: ignore known-benign libvirt errors

Milan Zamazal has posted comments on this change. Change subject: periodic: ignore known-benign libvirt errors .. Patch Set 4: Code-Review-1 (5 comments) The intention seems to be fine to me, just some clarification and/or

Change in vdsm[master]: Make VM._correctGraphicsConfiguration use DomainDescriptor

Milan Zamazal has posted comments on this change. Change subject: Make VM._correctGraphicsConfiguration use DomainDescriptor .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/52823/1/vdsm/virt/domain_descriptor.py File

Change in vdsm[master]: virt: Fix of uninitialized variable access in Vm.setLinkAndN...

Milan Zamazal has uploaded a new change for review. Change subject: virt: Fix of uninitialized variable access in Vm.setLinkAndNetwork() .. virt: Fix of uninitialized variable access in Vm.setLinkAndNetwork() Change-Id:

Change in vdsm[master]: vdsm: Remove unreachable code

Milan Zamazal has posted comments on this change. Change subject: vdsm: Remove unreachable code .. Patch Set 1: Code-Review-1 (1 comment) Good idea, just an objection about modifying the hook.

Change in vdsm[master]: vdsm: Remove unreachable code

Milan Zamazal has posted comments on this change. Change subject: vdsm: Remove unreachable code .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52980 To unsubscribe, visit

<    1   2   3   4   5   6   7   8   9   >