Re: [PATCH] d3dx9: Move object initialization into a separate function.

2013/10/9 Rico Schüller : > On 09.10.2013 01:12, Matteo Bruni wrote: >> >> Hi Rico, >> >> 2013/10/8 Rico Schüller : >>> >>> Hi, >>> >>> this moves the object initialization into a separate function, so it >>> could >

Re: [PATCH] d3dx9: Move object initialization into a separate function.

Hi Rico, 2013/10/8 Rico Schüller : > Hi, > > this moves the object initialization into a separate function, so it could > be used for strings and resources. It also removes the STATE_TYPE as we > could distinguish the types at the object level. > > 1. When an object has a destination, it points to

Re: [PATCH] d3dx9: Use struct d3dx_object for objects.

2013/9/24 Rico Schüller : > --- > dlls/d3dx9_36/effect.c | 248 > +++-- > 1 Datei geändert, 95 Zeilen hinzugefügt(+), 153 Zeilen entfernt(-) > I definitely like the direction this patch takes. @@ -5068,6 +5009,9 @@ static HRESULT d3dx9_parse_resource(s

Re: [PATCH] wined3d: Fix per-stage constant in GLSL fixed function pipeline + add tests. (try 2)

ted when needed. Tests > are also added. > > Thanks to Matteo Bruni for review and support. > > Try 2: > - update with latest git Hi, I have a few small nits still, please bear with me... > --- > dlls/d3d9/tests/visual.c | 80 >

Re: [PATCH 1/5] d3d8/tests: Add cnd instruction test.

2013/9/3 Henri Verbeet : > On 2 September 2013 23:04, Matteo Bruni wrote: >> +float quad1[] = { >> +-1.0, -1.0, 0.1, 0.0,0.0,1.0, >> + 0.0, -1.0, 0.1, 1.0,0.0,1.0, >> +-1.0,0.0, 0.1, 0.0,1.

Re: [PATCH 2/7] wined3d: Use PBOs for dynamic volumes (try 2)

2013/8/26 Stefan Dösinger : > Try 2: > *) Require only GPU access for buffers > *) Reduce number of checkGLcall invocations > *) Remove a return from an ERR case > --- > dlls/wined3d/utils.c | 1 + > dlls/wined3d/volume.c | 168 > - > d

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.

2013/8/1 Matteo Bruni : > Instead of generating an entry for the struct with the correct > members, the compiler generates TWO entries for sbnf, one with all its > fields in D3DXRS_FLOAT4 and the other with D3DXRS_BOOL. Which, if I'm > reading this correctly, makes 0

Re: d3dx9 [patch 1/2]: Implement D3DXCreatePolygon

2013/8/1 Nozomi Kodama : > +vertices = HeapAlloc(GetProcessHeap(), 0, 2 * (sides + 1) * sizeof(D3DXVECTOR3)); +if (!vertices) +{ +TRACE("Not memory enough for vertex buffer\n"); +polygon->lpVtbl->Release(polygon); +return E_OUTOFMEMORY; +} + +hr = polygo

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.

2013/8/1 Rico Schüller : > On 31.07.2013 00:14, Matteo Bruni wrote: >> >> 2013/7/30 Rico Schüller : >>> >>> Hi Matteo, >>> >>> please see the attached patch. >>> >>> >>> On 25.07.2013 16:13, Matteo Bruni wrote: >>

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.

2013/7/30 Rico Schüller : > Hi Matteo, > > please see the attached patch. > > > On 25.07.2013 16:13, Matteo Bruni wrote: >> >> 2013/7/24 Rico Schüller : >>> >>> --- >>> dlls/d3dx9_36/tests/shader.c | 308 >>> ++

Re: [1/1] kernel32: Implemented basic NUMA functions to replace the stubs

2013/7/30 Chris Moeller : > > On Jul 29, 2013, at 11:22 AM, Matteo Bruni wrote: > >> 2013/7/29 Chris Moeller : >>> without looking very deeply into the CRT source code. >> >> You're talking about MS source code, right? That makes you tainted for >>

Re: [1/1] kernel32: Implemented basic NUMA functions to replace the stubs

2013/7/29 Chris Moeller : > without looking very deeply into the CRT source code. You're talking about MS source code, right? That makes you tainted for contributing to Wine at the very least for C runtime-related code :( If you haven't looked into any other source code, this patch might be okay (

Re: [PATCH 3/5] d3dx9: Add support for structs to ID3DXConstantTable.

2013/7/24 Rico Schüller : > --- > dlls/d3dx9_36/shader.c | 79 > -- > 1 file changed, 77 insertions(+), 2 deletions(-) > So there was actually a logic (an insane one, but yeah...). Have you found any game actually using this? Annoying question: hav

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.

2013/7/24 Rico Schüller : > --- > dlls/d3dx9_36/tests/shader.c | 308 > +++ > 1 file changed, 308 insertions(+) > This is okay, but as a followup can you add some tests with mixed-type structs? Something like: struct { float f; int i; bool b; }

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

2013/6/24 Christian Costa : > Le 24/06/2013 09:24, Henri Verbeet a écrit : > >> On 23 June 2013 21:57, Christian Costa wrote: >>> >>> When D3DTA_CONSTANT is use in a texture stage, the generated shader uses >>> variables that are not defined making thus the compilation to fail. >>> This patch decl

Re: po: Update Italian translation (try 3)

2013/6/17 Fabian Ebner : > Typo fixed (finally) > --- > po/it.po | 40 ++-- > 1 file changed, 14 insertions(+), 26 deletions(-) > This one looks good to me, thanks :)

Re: po: Update Italian translation (try 2)

2013/6/17 Fabian Ebner : > Fixed a typo and a sentence, thanks to Matteo > --- > po/it.po | 40 ++-- > 1 file changed, 14 insertions(+), 26 deletions(-) #: jscript.rc:39 msgid "'return' statement outside of function" -msgstr "" +msgstr "Istruzione 'return' fo

Re: Update Italian translation

2013/6/16 Fabian Ebner : > --- > po/it.po | 40 ++-- > 1 file changed, 14 insertions(+), 26 deletions(-) #: joy.rc:42 msgid "" "After disabling or enabling a device, the connected joysticks won't be " "updated here until you restart this applet." msgstr

Re: [PATCH] d3dx9_36: Implement D3DXGetShaderInputSemantics + tests.

2013/6/12 Christian Costa : > >> > +HRESULT WINAPI D3DXGetShaderInputSemantics(const DWORD *byte_code, >> > D3DXSEMANTIC *semantics, UINT *count) >> > +{ >> > +const DWORD *ptr = byte_code; >> > +UINT i = 0; >> > + >> > +TRACE("byte_code = %p, semantics = %p, count = %p\n", byte_code, >

Re: [PATCH] d3dx9_36: Implement D3DXGetShaderInputSemantics + tests.

emantics(ptr ptr ptr) > @ stdcall D3DXGetShaderSamplers(ptr ptr ptr) > @ stdcall D3DXGetShaderSize(ptr) > diff --git a/dlls/d3dx9_36/shader.c b/dlls/d3dx9_36/shader.c > index 75bc9b5..3b71b4b 100644 > --- a/dlls/d3dx9_36/shader.c > +++ b/dlls/d3dx9_36/shader.c > @@ -1,6 +

Re: [PATCH] d3dcompiler: Add a LUT to find compilation targets info.

2013/5/2 Christian Costa : > > --- > dlls/d3dcompiler_43/compiler.c| 101 > +++-- > dlls/d3dcompiler_43/d3dcompiler_private.h |1 > 2 files changed, 81 insertions(+), 21 deletions(-) > > diff --git a/dlls/d3dcompiler_43/compiler.c b/dlls/d3dcompiler_43/com

Re: [PATCH 4/4] d3dx9_36: Remove todo in tests as it works now with last d3dxof fixes.

2013/4/29 Christian Costa : > > --- > dlls/d3dx9_36/tests/xfile.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/d3dx9_36/tests/xfile.c b/dlls/d3dx9_36/tests/xfile.c > index 1238bcd..e514a5f 100644 > --- a/dlls/d3dx9_36/tests/xfile.c > +++ b/dlls/d3dx9_36/tests/xf

Re: [PATCH 1/2] wined3d: Set GL_NONE for glReadBuffer / glDrawBuffer on FBO initialization.

2013/4/25 Henri Verbeet : > Seems ok, though a small comment explaining the issue this patch fixes > probably wouldn't hurt. A comment in the commit message or in the code? > On 25 April 2013 20:43, Matteo Bruni wrote: >> +if (target ==

Re: [PATCH 2/7] wined3d: Use ARB_internalformat_query2 to check for texture format rendering and blending support, where available.

Hrm, I sent the wrong version of the patch, I had actually moved the depth/stencil check earlier (so yeah, totally agree on that part). Also you're right about WINED3DFMT_FLAG_RENDERTARGET, for some reason I thought we were setting that in check_fbo_compat() but it's clearly not the case. I'm send

Re: d3dx9: Implement D3DXSHMultilpy5

2013/4/15 Nozomi Kodama : > Hello > > thanks for the review. > I don't think that calling defines is the way to go. Indeed, I tested my > patch and yours. Yours is about 12% slower than mine in my computer. > And now, we try to take care of efficiency of this dll. So, it is not the > time to incre

Re: [PATCH 8/8] wined3d: Skip non-textureable formats in check_fbo_compat().

2013/4/10 Henri Verbeet : > On 10 April 2013 17:53, Matteo Bruni wrote: >> The idea is that, since check_fbo_compat() creates a texture of the >> specified format to attach it to a test FBO and verify that it works >> correctly, it doesn't make sense to even try if the f

Re: [PATCH 1/2] wined3d: Handle texture types via ps/vs_compile_args

I guess it depends on what happens in D3D when the sampler type declared in the shader and the type of the texture bound to that sampler disagree, and it really matters only if all the current drivers have the same behavior in that regard. unbound_sampler_test() doesn't check what happens with mism

Re: [PATCH 1/8] wined3d: Remove useless glClearxxx calls.

2013/4/10 Henri Verbeet : > On 10 April 2013 01:35, Matteo Bruni wrote: >> -/* Clear the screen */ >> -gl_info->gl_ops.gl.p_glClearColor(1.0f, 0.0f, 0.0f, 0.0f); >> -checkGLcall("glClearColor"); >> -gl_info->gl_ops.gl.p_glClearIndex(0);

Re: [PATCH 8/8] wined3d: Skip non-textureable formats in check_fbo_compat().

2013/4/10 Henri Verbeet : > On 10 April 2013 01:35, Matteo Bruni wrote: >> --- >> dlls/wined3d/utils.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c >> index da8fc7b..5010676 100644 >> ---

Re: d3dx9 [patch 1/2, resend]: Floatify fabs into fabs

2013/4/7 Nozomi Kodama : > Both patches are fine for me (note that the email subject is missing an "f" but the actual patch has the correct title).

Re: d3dx9 [patch1/3, try 2]: Do not use relative error for small numbers

2013/4/1 Nozomi Kodama > > Since there are only at most 7 significant digits for a float, we must not be > too picky about the expected difference for small numbers > > -#define relative_error(exp, out) ((exp == 0.0f) ? fabs(exp - out) : > (fabs(1.0f - (out) / (exp > +#define relative_error

Re: d3dx9 [patch 1/2, try 3]: Implement D3DXSHEvalSphericalLight

2013/3/15 Nozomi Kodama : > Patch series is fine to me.

Re: d3dx9 [patch 1/2]: Implement D3DXSHEvalSphericalLight

2013/3/14 Nozomi Kodama : > No news about these patches? > > > Nozomi? > > Hmm, I was under the impression that these patches were already picked up in git, but I see I was mistaken. Anyway they look okay to me, except for a bit in the tests from the first patch that I noticed just now by reading

Re: d3dx9 [patch 1/2, try 3]: Implement D3DXSHEvalConeLight

2013/3/6 Nozomi Kodama : > hello > > Still problems with this patch? > > Nozomi. > FWIW, both patches are fine to me.

Re: d3dx9 [patch 1/2]: Implement D3DXSHEvalConeLight

2013/3/1 Nozomi Kodama : > Why is this patch marked as "not applied" by the testbot? > In my computer, with the latest git, it applies fine. > > Is there a problem with testbot? > > Nozomi > > Yeah, the old testbot has some issues. FWIW the patches applied just fine for me. Now, I know I'm going

Re: d3dx9: Avoid expensive computations

2013/2/26 Rico Schüller : > Hi Nozomi, > > this is pretty fast. Just some numbers (run time on my machine, so it might > not be that representative)... > > before: 43s > previous patch: 27s > this patch: 21s > native: 16s > > So from the speed point of view, it's a lot closer than the rest. > > Tho

Re: [PATCH 1/2] wined3d: Make (wined3d_)surface_depth_blt_fbo handle locations other than SFLAG_INTEXTURE.

2013/2/17 Henri Verbeet : > On 17 February 2013 18:10, Matteo Bruni wrote: >> @@ -6168,18 +6172,10 @@ HRESULT surface_load_location(struct wined3d_surface >> *surface, DWORD location, c >> >> if (surface->resource.usage & WINED3DUSAGE_DEPTHSTENCIL)

Re: d3dx9: Implement D3DXSHEvalConeLight

Hi, in addition to what I already told you in #winehackers (that is, please rename the test struct field red_in to red_out and red_out to red_expected, or something like that), you should take the chance to do some more cleanup. That means e.g. use "const" instead of "CONST" as Rico already sugges

Re: wined3d: Rebind texture before checking for its content in check_fbo_compat().

2013/1/26 Stefan Dösinger : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 2013-01-26 22:32, schrieb Matteo Bruni: >> + >> gl_info->fbo_ops.glFramebufferTexture2D(GL_FRAMEBUFFER, >> GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, tex, 0); > Do you really have

Re: [PATCH 3/3] d3dx9: Use all 32 bits as mask.

2013/1/10 Rico Schüller : > --- > dlls/d3dx9_36/texture.c | 6 +++--- > 1 Datei geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(- > > -DWORD i, v; > +DWORD i, v, mask32 = format->bits[c] == 32 ? -1 : ((1 << > format->bits[c]) - 1); Usually we prefer to use ~0U instead of -1

Re: d3dcompiler_43: Avoid signed-unsigned integer comparisons

2013/1/1 Andrew Talbot : > Changelog: > d3dcompiler_43: Avoid signed-unsigned integer comparisons. > > diff --git a/dlls/d3dcompiler_43/bytecodewriter.c > b/dlls/d3dcompiler_43/bytecodewriter.c > index d10f6bc..17289d2 100644 > --- a/dlls/d3dcompiler_43/bytecodewriter.c > +++ b/dlls/d3dcompile

Re: [PATCH 1/7] d3dx9: Handle invalid byte code in D3DXFindShaderComment().

2013/1/1 Rico Schüller : > --- > dlls/d3dx9_36/shader.c | 16 +++- > dlls/d3dx9_36/tests/shader.c | 21 + > 2 Dateien geändert, 32 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) > +static inline BOOL is_valid_bytecode(DWORD token) +{ +token &= 0x; +

Re: [PATCH] d3dx9_36/tests: Fix broken line test

2012/11/27 Detlef Riekenberg : > While inspecting a test failure, i found only > 3 possible results for the line test: > - d3dx9_36.dll not present > - all tests skipped > line.c:146: Tests skipped: Failed to create IDirect3DDevice9 object > 0x8876086c > - refcount test failed > line.c:113: Te

Re: ntdll: Fixed some heap allocation stalls

2012/11/3 Steaphan Greene : > On 11/03/2012 09:04 AM, Matteo Bruni wrote: >> >> 2012/11/2 Steaphan Greene: >>> >>> Running a game in wine showed it performing terribly. I traced this to >>> the >>> fact that it allocates and deallocates tiny mem

Re: ntdll: Fixed some heap allocation stalls

2012/11/2 Steaphan Greene : > Running a game in wine showed it performing terribly. I traced this to the > fact that it allocates and deallocates tiny memory chunks over and over (I > suspect it's in C++ and passing things by value everywhere). This led to > huge stalls because the heap bins were

Re: [3/5] d3dx9: Introduce a function for copying pixels.

2012/10/29 Christian Costa : > >> >> pixel_format = get_format_info(src_desc.Format); >> -if (pixel_format->type != FORMAT_ARGB) >> -{ >> -FIXME("Unsupported pixel format %#x\n", src_desc.Format); >> -return E_NOTIMPL; >> -} >> +if (pixel_format->type == FORMAT_

Re: [PATCH 3/5] wined3d: Implement WINED3DSIH_ROUND_NI in the GLSL shader backend.

2012/10/19 Henri Verbeet : > On 19 October 2012 15:20, Matteo Bruni wrote: >> 2012/10/18 Henri Verbeet : >>> --- >>> dlls/wined3d/glsl_shader.c |3 ++- >>> 1 files changed, 2 insertions(+), 1 deletions(-) >>> >>> diff --git a/dlls/wined3

Re: [PATCH 3/5] wined3d: Implement WINED3DSIH_ROUND_NI in the GLSL shader backend.

2012/10/18 Henri Verbeet : > --- > dlls/wined3d/glsl_shader.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c > index 57119e1..993b547 100644 > --- a/dlls/wined3d/glsl_shader.c > +++ b/dlls/wined3d/glsl_shader.

Re: [PATCH 2/6] d3dcompiler: Improve a Nvidia GPU recognition fallback.

Ehh, this patch should have been called something like "wined3d: Improve a Nvidia GPU recognition fallback.", but well...

Re: d3dx9_36 [try 3]: Implement D3DXSHRotate

2012/9/4 Rico Schüller : > On 04.09.2012 13:19, Nozomi Kodama wrote: > +FLOAT expected, in[100], out[100], > ... > +for (i = 0; i < 49; i++) > +in[i] = i + 1.01f; > > I guess this belongs together. > > I'd like to make some suggestions, please don't take it personally. > > When you

Re: wined3d: Use backup swapchain DC for devices created with desktop window.

2012/9/3 Henri Verbeet : > On 3 September 2012 00:51, Adam Jakubek wrote: >> Hi, >> >> This patch causes wined3d to use backup swapchain DC when >> IDirect3DDevice9 is created using the desktop window. >> Windows allows to create such device as long its type is >> D3DDEVTYPE_REF or D3DDEVTYPE_NULL

Re: [PATCH 4/4] wined3d: Improve post-pixelshader blending test. (Try 2)

> Screenshot: http://dl.dropbox.com/u/2701879/images/rayman2.png > > Regression test: > a488e574497d674631b4036d4b179ce349ddb764 is the first bad commit > commit a488e574497d674631b4036d4b179ce349ddb764 > Author: Matteo Bruni > Date: Wed Aug 15 00:38:26 2012 +0200 > > wi

Re: d3dx9_36: Implementation of D3DXSHRotateZ

2012/7/18 Nozomi Kodama : > Minor nitpicks, but nevertheless: > -@ stub D3DXSHRotateZ(ptr long long ptr) > +@ stdcall D3DXSHRotateZ(ptr long long ptr) ... > +FLOAT* WINAPI D3DXSHRotateZ(FLOAT *out, UINT order, FLOAT angle, CONST FLOAT > *in) I guess using "float" in the spec file for the third

Re: [PATCH 5/5] d3dcompiler: Implement basic expressions parsing.

2012/7/17 Stefan Dösinger : > Am Montag, 16. Juli 2012, 20:39:23 schrieb Matteo Bruni: >> +HLSL_IR_BINOP_MUL, >> ... >> +HLSL_IR_BINOP_DOT, > HLSL has 3 somewhat related multiplication operations: "*", "mul" and "dot". > Dot

Re: [PATCH 3/4] d3dx9/tests: Add effect parameter value GetMatrixPointerArray() test.

2012/7/8 Rico Schüller : > --- > dlls/d3dx9_36/tests/effect.c | 90 > ++ > 1 files changed, 90 insertions(+), 0 deletions(-) > Hi Rico, maybe it's just me misunderstanding this, but: +FLOAT fvalue[EFFECT_PARAMETER_VALUE_ARRAY_SIZE]; +D3DXMATRIX

Re: [4/5] d3dx9: Implement D3DXCreateVolumeTextureFromFileInMemoryEx.

2012/6/27 Józef Kucia : > --- > +    for (mip_level = 0; mip_level < mip_levels; mip_level++) > +    { > +        hr = calculate_dds_surface_size(src_info, width, height, &src_pitch, > &mip_level_size); > +        if (FAILED(hr)) return hr; ... > +        hr = D3DXLoadVolumeFromMemory(volume, pal

Re: [1/5] d3dx9: Implement D3DXLoadVolumeFromMemory.

2012/6/27 Józef Kucia : > --- Hi Józef, > +void copy_simple_data(const BYTE *src, UINT srcpitch, SIZE src_size, const > PixelFormatDesc *srcformat, > +BYTE *dest, UINT destpitch, SIZE dst_size, const PixelFormatDesc > *destformat, D3DCOLOR colorkey) DECLSPEC_HIDDEN; > + You are not act

Re: d3dx9_36 [patch 2 of 3]: Implementation of D3DXSHScale

2012/6/27 Nozomi Kodama : > -@ stub D3DXSHScale(ptr long ptr ptr) +@ stdcall D3DXSHScale(ptr long ptr ptr) ... +FLOAT* WINAPI D3DXSHScale(FLOAT *out, UINT order, CONST FLOAT *a, CONST FLOAT scale) The last parameter doesn't match between the function prototype and the spec entry. Also, apparently

Re: d3dx9_36 [patch 1of 2]: Implementation of D3DXSHDot

2012/6/19 Nozomi Kodama : +static void test_D3DXSHDot(void) +{ +unsigned int i; +FLOAT a[90], b[90], got; +CONST FLOAT expected[] = +{ 0.0f, 0.0f, 17.0f, 222.0f, 1300.0f, 5050.0f, 15225.0f, 38612.0f, 86352.0f, 175500.0f, }; + +for (i = 0; i < 90; i++) +{ +a[i] = (FL

Re: Re : d3dx9_36: D3DXQuaternionLn computes as if the norm of the input is 1

2012/6/13 Nozomi Kodama : >>>2012/6/12 Nozomi Kodama : >>> >>> +    if ( (pq->w >= 1.0f) || (pq->w == -1.0f) ) >> >>I think the second comparison should be '<=', if you want to avoid getting >> NaNs. > > I checked in Vista.  D3DX accepts -1.0f as input and returns what the patch > does. > > However

Re: d3dx9_36: D3DXQuaternionLn computes as if the norm of the input is 1

2012/6/12 Nozomi Kodama : > > +if ( (pq->w >= 1.0f) || (pq->w == -1.0f) ) I think the second comparison should be '<=', if you want to avoid getting NaNs.

Re: po: Update Italian translation

Hi Luca, just a couple of nitpicks: -"Nota: è raccomandato usare i pacchetti delle distribuzioni. Leggi http://wiki.winehq.org/Gecko\";>http://wiki.winehq.org/Gecko per i " -"dettagli." +"Nota: è raccomandato usare i pacchetti delle distribuzioni. Leggi http://wiki.winehq.org/Mono\";>http://wiki.w

Re: [PATCH 5/5] d3dcompiler: Parse variable declarations.

2012/6/5 Matteo Bruni : > 2012/6/5 Rico Schüller : >> Am 05.06.2012 13:08, schrieb Matteo Bruni: >> >>> 2012/6/5 Stefan Dösinger: >>>> >>>> Am Montag, 4. Juni 2012, 17:58:24 schrieb Matteo Bruni: >>>>> >>>>> +struct hlsl

Re: [PATCH 5/5] d3dcompiler: Parse variable declarations.

2012/6/5 Rico Schüller : > Am 05.06.2012 13:08, schrieb Matteo Bruni: > >> 2012/6/5 Stefan Dösinger: >>> >>> Am Montag, 4. Juni 2012, 17:58:24 schrieb Matteo Bruni: >>>> >>>> +struct hlsl_type >>>> +{ >>>> ... >>&

Re: [PATCH 5/5] d3dcompiler: Parse variable declarations.

2012/6/5 Stefan Dösinger : > Am Montag, 4. Juni 2012, 17:58:24 schrieb Matteo Bruni: >> +struct hlsl_type >> +{ >> ... >> +    unsigned int dimx; >> +    unsigned int dimy; >> ... >> +}; > One thing I noticed when I wrote my compiler was that a fl

Re: ddraw: Forward AddAttachedSurface to the correct equivalent

2012/5/14 Stefan Dösinger : > Am Sonntag, 13. Mai 2012, 20:39:27 schrieb David Adam: >> +    hr = ddraw_surface3_AddAttachedSurface(&This- >>IDirectDrawSurface3_iface, >> +            attachment_impl ? &attachment_impl->IDirectDrawSurface3_iface : > NULL); > It isn't immediately clear to me why Sur

Re: [5/8] d3dx9: Add DDS support in D3DXCreateTextureFromFile functions.

2012/5/10 Józef Kucia : > > I noticed that I put more and more texture functions tests in > tests/surface.c, because these tests needs the dds files which are in > tests/surface.c. I wonder if it would be better to copy needed dds > files to tests/texture.c and move texture function tests to their

Re: [5/8] d3dx9: Add DDS support in D3DXCreateTextureFromFile functions.

2012/5/9 Józef Kucia : > --- > +HRESULT load_texture_from_dds(IDirect3DTexture9 *texture, const void > *src_data, UINT srd_data_size, > +    const PALETTEENTRY *palette, DWORD filter, D3DCOLOR color_key, const > D3DXIMAGE_INFO *src_info) DECLSPEC_HIDDEN; ... > +HRESULT load_texture_from_dds(IDire

Re: [4/8] d3dx9: Implement D3DXCreateCubeTextureFromFileInMemoryEx.

2012/5/9 Józef Kucia : > +    mip_levels = min(src_info->MipLevels, > IDirect3DCubeTexture9_GetLevelCount(cube_texture)); > +    for (face = D3DCUBEMAP_FACE_POSITIVE_X; face <= > D3DCUBEMAP_FACE_NEGATIVE_Z; face++) > +    { > +        size = src_info->Width; > +        for (mip_level = 0; mip_lev

Re: [2/8] d3dx9: Check the size of a DDS file in D3DXGetImageInfoFromFileInMemory.

2012/5/9 Józef Kucia : > +static HRESULT get_image_info_from_dds(const void *buffer, UINT length, > D3DXIMAGE_INFO *info) >  { > +   UINT i; > +   UINT faces = 0; ... > +   /* calculate the expected length */ > +   width = info->Width; > +   height = info->Height; > +   for (i = 0; i < info->MipLe

Re: [1/8] d3dx9: Add missing pixel formats.

2012/5/9 Józef Kucia : > diff --git a/dlls/d3dx9_36/util.c b/dlls/d3dx9_36/util.c > index 4dbf44c..ad8a6ea 100644 > --- a/dlls/d3dx9_36/util.c > +++ b/dlls/d3dx9_36/util.c > @@ -62,6 +62,7 @@ static const PixelFormatDesc formats[] = >     {D3DFMT_G16R16,      {0, 16, 16,  0}, { 0,  0, 16,  0}, 4, 1

Re: [PATCH 5/5] d3dcompiler: Partially implement D3DCompile function.

2012/5/8 Henri Verbeet : > I realize compile_shader() is mostly a copy of assemble_shader(), but > nevertheless: > > On 8 May 2012 16:17, Matteo Bruni wrote: >> +struct bwriter_shader *parse_hlsl_shader(const char *text, enum shader_type >> type, DWORD version, > If t

Re: [3/3] d3dx9: Implement conversion from DDS pixel format to D3DFORMAT.

Il 26 aprile 2012 11:47, Józef Kucia ha scritto: >  static D3DFORMAT dds_pixel_format_to_d3dformat(const struct dds_pixel_format > *pixel_format) >  { > -    FIXME("Pixel format conversion not implemented.\n"); > +    if (pixel_format->flags & DDS_PF_FOURCC) > +        return dds_fourcc_to_d3dfor

Re: d3dx9/tests: Add DDS pixel format tests for D3DXGetImageInfoFromFileInMemory.

Il 19 aprile 2012 19:37, Józef Kucia ha scritto: > --- >  dlls/d3dx9_36/tests/surface.c |   65 > + >  1 files changed, 65 insertions(+), 0 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/surface.c b/dlls/d3dx9_36/tests/surface.c > index 87aa03e..51d6ebd 1

Re: GSoC 2012 - Implement a few missing functions in D3DX9

Il 20 marzo 2012 19:12, Christian Costa ha scritto: > Le 20/03/2012 18:43, Józef Kucia a écrit : > >> Hi there, >> >> I'm writing to discuss my project proposal for upcoming Google Summer >> of Code. I was recently playing with Wine, looking around in the code >> and searching through Wine bugzill

Re: wpp: Stop parsing single and double quoted string constants after a first newline character.

Il 14 marzo 2012 23:02, Józef Kucia ha scritto: > @@ -679,11 +649,23 @@ void pp_writestring(const char *format, ...) >                } >        } >  \\.      add_string(ppy_text, ppy_leng); > -\n       { > +\n             { >                newline(1); >                add_string(ppy_text, ppy_le

Re: Preprocessing asm shaders

Il 12 marzo 2012 22:13, Józef Kucia ha scritto: > Hi, > > I'm writing because I found a bug in asm shader preprocessor in Wine > and I'm not sure what's the best way to fix it. > > The D3DPreprocess function is an universal shader preprocess for HLSL > and asm shaders. In fact, it's C-like languag

Re: GSoC 2011 - introduction

Il 09 marzo 2012 23:41, Józef Kucia ha scritto: > Hi, > > My name is Józef Kucia. I'm a Masters student in Computer Science at > Wrocław University of Technology in Poland. I would like to apply for > Google Summer of Code this year. > I have a good knowledge of C and OpenGL. I also have limited >

Re: [PATCH 1/5] wined3d: Clamp fog coordinate in the vertex shader.

Il 08 marzo 2012 22:10, Stefan Dösinger ha scritto: > Am Donnerstag, 8. März 2012, 18:22:15 schrieb Matteo Bruni: >> -                shader_addline(buffer, "gl_FogFragCoord = OUT[%u].%c;\n", >> i, reg_mask[1]); >> +                shader_addline(buffer, "g

Re: OpenGL child windows (SketchUp)

Il 08 febbraio 2012 18:19, Brian Bloniarz ha scritto: > Hi all, > > I could use a little help fixing a window lag and screen corruption > issue in SketchUp: > http://bugs.winehq.org/show_bug.cgi?id=25912 > Long story short, I think the implementation of OpenGL child rendering > needs a small updat

Re: [PATCH 3/3] d3d9/tests: More D3DTSS_TEXTURETRANSFORMFLAGS projection tests.

2012/1/14 Saulius Krasuckas : > * On Tue, 27 Dec 2011, Matteo Bruni wrote: >> --- >>  dlls/d3d9/tests/visual.c |  388 >> -- >>  1 files changed, 269 insertions(+), 119 deletions(-) > > Hello Matteo, > > this is

Re: po: Update Italian translation

2012/1/4 Luca Bennati : > > > #: winmm.rc:34 > -#, fuzzy > msgid "There is no driver installed on your system!" > -msgstr "Non è stato installato nessun driver nel sistema !\n" > +msgstr "Non è presente nessun driver installato nel sistema!" Hi Luca, While your new translation is clearer than the

Re: [PATCH 4/4] d3dx9: Implement ID3DXBaseEffect::SetValue().

2011/12/13 Rico Schüller : > --- >  dlls/d3dx9_36/effect.c |   42 -- >  1 files changed, 40 insertions(+), 2 deletions(-) > > +TRACE("Copy %u bytes\n", param->bytes); > +memcpy(param->data, data, bytes); That trace is not corr

Re: [PATCH 2/4] d3dx9: Implement ID3DXBaseEffect::SetVector().

Hi Rico, 2011/12/13 Rico Schüller : > --- >  dlls/d3dx9_36/effect.c |   52 > +-- >  1 files changed, 49 insertions(+), 3 deletions(-) > > +static void set_vector(struct d3dx_parameter *param, CONST D3DXVECTOR4 > *vector) > +{ > +set_number((float *)

Re: [PATCH 2/5] d3d10: Implement D3D10StateBlockMaskDisableCapture().

2011/11/15 Henri Verbeet : > --- > +UINT end = start_idx + count; > +    start_idx += 7; > +    memset(&field[start_idx >> 3], 0, (end >> 3) - (start_idx >> 3)); Isn't that dangerous if count is < 7 (assuming that is a valid value)?

Re: [PATCH 3/3] wined3d: Report all FBO-attachable formats as suitable for render target usage.

2011/11/9 Matteo Bruni : > --- This patch is not correct, please ignore it...

Re: d3dx9_36/tests [patch 2/2, try 3]: Add tests for D3DXCreatePolygon

2011/11/9 David Adam : > Better, but there are still issues: +if( polygon ) polygon->lpVtbl->Release(polygon); +if( ppBuffer ) ID3DXBuffer_Release(ppBuffer); You aren't setting those pointers to NULL (and your test shows that D3DXCreatePolygon doesn't touch them when the call fails), so

Re: d3dx9_36 [patch 1/2, resent]: Implement D3DXCreatePolygon

2011/11/7 David Adam : > Hello, > > any problem with this patch > http://source.winehq.org/patches/data/80433 > > and this one > http://source.winehq.org/patches/data/80434 > > Thanks in advance > > David > > -- Forwarded message -- > From: David Adam > Date: 2011/10/30 > Subject:

Re: [1/2] d3dx9: Implemented non-equal declaration support in CloneMesh.

2011/10/24 Michael Mc Donnell : > On Mon, Oct 24, 2011 at 9:13 AM, Matteo Bruni > wrote: >> Hi Michael, >> >> +    for (i = 0; declaration1[i].Stream != 0xff; i++) >> +    { >> +        if (memcmp(&declaration1[i], &declaration2[i], >> sizeo

Re: [1/2] d3dx9: Implemented non-equal declaration support in CloneMesh.

Hi Michael, +for (i = 0; declaration1[i].Stream != 0xff; i++) +{ +if (memcmp(&declaration1[i], &declaration2[i], sizeof(*declaration1))) Doesn't that loop need to stop at the first end marker of either declaration? I.e. may the first vertex declaration be longer than the second on

Re: wined3d: Report every texture format as filterable and blendable.

2011/10/12 Dan Kegel : > Fails d3d9's visual tests here. > > os:     Linux 3.0.0-12-generic, Ubuntu 11.10 > gpu:    GeForce GT 240/PCI/SSE2 3.3.0 NVIDIA 280.13 > > On Wed, Oct 12, 2011 at 2:52 PM,   wrote: >> This is an experimental automated build and test service. >> Please feel free to ignore th

Re: d3dx9: CloneMesh test and improvements

2011/8/12 Octavian Voicu : > On Fri, Aug 12, 2011 at 12:59 PM, Michael Mc Donnell > wrote: >> >> Is it ok to use roundf and rintf? They're both C99 functions. > > Hello, > As far as I know C99 is not allowed. However, you can emulate round by > doing: > floorf(val + 0.5f) > According to [1] floorf

Re: d3dx9: CloneMesh test and improvements

2011/8/11 Michael Mc Donnell : > > +dst_ptr[0] = src->x < 0.0f ? (SHORT)ceilf(src->x * SHRT_MAX + > 0.5f) :(SHORT)floorf(src->x * SHRT_MAX + 0.5f); You can use roundf() instead. Actually, notice that maybe what you actually need for correct rounding is rintf() (which essentially match

Re: d3dx9: CloneMesh test and improvements

2011/8/8 Michael Mc Donnell : > Hi > > I've been working on a test and improvements for CloneMesh as part of > GSoC 2011. I would be grateful if anyone could comment on my work. > There are five test cases in the attached patch: > >  0. Basic mesh cloning. Declaration has position and normal, and t

Re: wined3d: Update GLSL spam filter for recent fglrx versions.

2011/8/3 Stefan Dösinger : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Am 03.08.2011 um 17:31 schrieb Matteo Bruni: > >> Users tend to get confused by those messages on the terminal. Since we >> already have code to filter irrelevant GLSL compiler mes

Re: [3/3] ddraw/tests: Add a couple of fog tests.

2011/7/27 Marvin : > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?

Re: d3dx9_36: Use SUCCEEDED instead of !FAILED.

2011/7/19 Michael Stefaniuc : > --- >  dlls/d3dx9_36/mesh.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c > index 94a291f..d8f72c4 100644 > --- a/dlls/d3dx9_36/mesh.c > +++ b/dlls/d3dx9_36/mesh.c > @@ -3376,7 +3376,7 @@ HR

Re: [PATCH 1/2] d3dx9_36: Added support for structs and arrays to ID3DXConstantTable (Try 2)

2011/7/14 Travis Athougies : > Needed for Assassin's Creed Brotherhood and Dead Space 2. > > Changes from last patch: >    - New way of distinguishing handles from strings >    - Support for parent constants in ID3DXConstantTable::GetConstantByName > and ID3DXConstantTable::GetConstant >    - Impl

Re: [PATCH 1/3] d3dx9/line: Implemented ID3DXLine's Draw method.

2011/6/30 Charles Welton : > --- > > +memcpy(buffer_mem, vertices, size); There is no need to allocate and write into your own buffer then copy the content, you can directly write into the vertex buffer. A more important issue: MSDN says "The ID3DXLine interface implements line drawing us

Re: [2/2] d3dx9_36: Implement and add tests for D3DXFloat16To32Array.

2011/6/29 Misha Koshelev : > --- ... > +else return sgn * powf(2, -14.0f) * ((float)m / 1024.0f); ... > +return sgn * powf(2, (float)e - 15.0f) * (1.0f + ((float)m / > 1024.0f)); I think you don't need the explicit casts here, the values should be automatically promoted to floats

  1   2   >