Resurecting this old thread as Andrew Davidson has been working on this import plan a bit more -> https://wiki.openstreetmap.org/w/index.php?title=Import%2FCatalogue%2FPSMA_Admin_Boundaries&type=revision&diff=2034132&oldid=1918537
Surfacing a few points from my review: 1. psma:loc_pid. Where this is a stable ID that is used as a reference, the existing ref tag is better for this. If we want to be more specific then ref:psma or something like that would work. No need to invent new tags here when one already exists, is well documented and in widespread use. 2. Regarding source tags on objects, this might be something I added originally, I can't remember, but I'm on the fence about it. While on one hand I can see it being helpful for mappers to understand where these were sourced from, over time as people make changes in OSM the source tag becomes inaccurate. I've seen this with existing source tags, where people generally don't remove them if updating based on a different source. Since you can always inspect the history to find the source, is there really any benefit to having these on each object? Given a whole bunch of other tags like contract details, website etc. for LGAs can be added to, a top level source tag is not perfect. I'm good with source:geometery on the ways, but not sure about source on the relations. 3. More of a question for Andrew Davidson, is the plan for the actual upload to go through the state borders and other ways already existing in OSM, and delete the one with FIXME from your candidates, and use the existing state border as part of the new relation? The "import" upload should immediately be correct and not a broken state until post-import changes clean things up, it should be uploaded clean in the first instance. So this means manually working on it in JOSM before uploading.
_______________________________________________ Talk-au mailing list Talk-au@openstreetmap.org https://lists.openstreetmap.org/listinfo/talk-au
