Re: [PATCH 1/3] MINOR: add list_append_word function

2016-05-13 Thread Willy Tarreau
I've merged all the series, thank you Maxime! Willy

Re: [PATCH] MEDIUM: init: allow directory as argument of -f

2016-05-13 Thread Willy Tarreau
Hi Maxime, On Sat, May 14, 2016 at 12:09:07AM +0200, Maxime de Roucy wrote: > Hello Willy, > > Le vendredi 13 mai 2016 à 19:22 +0200, Willy Tarreau a écrit : > > Maxime, could you please add a call to setlocale(LC_ALL, "") as > > suggested by Nenad before starting to scan the directories ? If >

Re: [PATCH] MEDIUM: init: allow directory as argument of -f

2016-05-13 Thread Maxime de Roucy
Hello Willy, Le vendredi 13 mai 2016 à 19:22 +0200, Willy Tarreau a écrit : > Maxime, could you please add a call to setlocale(LC_ALL, "") as > suggested by Nenad before starting to scan the directories ? If > something isn't 100% clear to you, do not hesitate to ask for more > details, you won't

[PATCH 1/3] MINOR: add list_append_word function

2016-05-13 Thread Maxime de Roucy
int list_append_word(struct list *li, const char *str, char **err) Append a copy of string (inside a wordlist) at the end of the list . The caller is responsible for freeing the and copy memory area using free(). On failure : return 0 and filled with an error message. ---

[PATCH 2/3] MEDIUM: init: use list_append_word in haproxy.c

2016-05-13 Thread Maxime de Roucy
replace LIST_ADDQ with list_append_word --- src/haproxy.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/haproxy.c b/src/haproxy.c index bfd542c..3166bba 100644 --- a/src/haproxy.c +++ b/src/haproxy.c @@ -561,6 +561,7 @@ void init(int argc, char

[PATCH 3/3] MEDIUM: init: allow directory as argument of -f

2016-05-13 Thread Maxime de Roucy
If -f argument is a directory add all the files (and only files) it containes to the config files list. These files are added in lexical order (respecting LC_COLLATE). Only files with ".cfg" extension are added. Only non hidden files (not prefixed with ".") are added. Symlink are followed. The -f

Re: Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Willy Tarreau
On Fri, May 13, 2016 at 11:25:28PM +0200, Cyril Bonté wrote: > > In the mean time, there may be a -fsomething option to disable a > > bogus optimization which causes this, but that's not easy to spot > > as it will depend on any side effect of other code :-/ > > I was trying to identify one, and

Re: Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Cyril Bonté
Le 13/05/2016 23:20, Willy Tarreau a écrit : On Fri, May 13, 2016 at 11:07:18PM +0200, Cyril Bonté wrote: At this point, I have an issue in the function str2listener() [cfgparse.c] In the port loop : for (; port <= end; port++) { [...] if (l->addr.ss_family == AF_INET) {

Re: Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Willy Tarreau
On Fri, May 13, 2016 at 11:07:18PM +0200, Cyril Bonté wrote: > At this point, I have an issue in the function str2listener() [cfgparse.c] > > In the port loop : > for (; port <= end; port++) { > [...] > if (l->addr.ss_family == AF_INET) { > [...] > Here, if I print the content of

Re: Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Cyril Bonté
Le 13/05/2016 22:14, Cyril Bonté a écrit : Hi all, Le 13/05/2016 21:24, Willy Tarreau a écrit : On Fri, May 13, 2016 at 10:09:04PM +0300, Arthur ??i??eic?? wrote: I will attach 2 traces, for 1.6.4 and for 1.6.5. So indeed in your traces, we see that 1.6.5 does bind(port=443, addr=0.0.0.0)

Re: Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Cyril Bonté
Hi all, Le 13/05/2016 21:24, Willy Tarreau a écrit : On Fri, May 13, 2016 at 10:09:04PM +0300, Arthur ??i??eic?? wrote: I will attach 2 traces, for 1.6.4 and for 1.6.5. So indeed in your traces, we see that 1.6.5 does bind(port=443, addr=0.0.0.0) while 1.6.4 has the correct address. At this

Re: Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Willy Tarreau
On Fri, May 13, 2016 at 10:09:04PM +0300, Arthur ??i??eic?? wrote: > I will attach 2 traces, for 1.6.4 and for 1.6.5. So indeed in your traces, we see that 1.6.5 does bind(port=443, addr=0.0.0.0) while 1.6.4 has the correct address. At this point your kernel is innocent. I don't see what could

Re: Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Willy Tarreau
On Fri, May 13, 2016 at 10:09:04PM +0300, Arthur ??i??eic?? wrote: > În ziua de vineri, 13 mai 2016, la 19:12:23 EEST, Willy Tarreau a scris: > > On Fri, May 13, 2016 at 06:59:49PM +0300, Arthur ??i??eic?? wrote: > > > I already went back and forth between the 2 versions to confirm that it's > > >

Re: Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Arthur Țițeică
În ziua de vineri, 13 mai 2016, la 19:12:23 EEST, Willy Tarreau a scris: > On Fri, May 13, 2016 at 06:59:49PM +0300, Arthur ??i??eic?? wrote: > > I already went back and forth between the 2 versions to confirm that it's > > still working fine in 1.6.4. > > But using a version that you rebuilt for

Re: [PATCH] MEDIUM: init: allow directory as argument of -f

2016-05-13 Thread Willy Tarreau
On Fri, May 13, 2016 at 07:15:11PM +0200, Nenad Merdanovic wrote: > Hello Willy, > > On 5/13/2016 7:04 PM, Willy Tarreau wrote: > > I don't know, I'm not fond of setting things in the back of the user like > > this. I don't even know if we have other parts that are currently sensitive > > to the

Re: [PATCH] MEDIUM: init: allow directory as argument of -f

2016-05-13 Thread Nenad Merdanovic
Hello Willy, On 5/13/2016 7:04 PM, Willy Tarreau wrote: > I don't know, I'm not fond of setting things in the back of the user like > this. I don't even know if we have other parts that are currently sensitive > to the locale and which could be affected. Wouldn't it be better to simply > add this

Re: Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Willy Tarreau
On Fri, May 13, 2016 at 06:59:49PM +0300, Arthur ??i??eic?? wrote: > I already went back and forth between the 2 versions to confirm that it's > still working fine in 1.6.4. But using a version that you rebuilt for this or the version that you had built some time ago ? I just want to ensure that

Re: 100% cpu , epoll_wait()

2016-05-13 Thread Willy Tarreau
Hi Lukas, On Fri, May 13, 2016 at 06:36:38PM +0200, Lukas Tribus wrote: > Not sure if that's what you meant by the other issue, but if there are still > buffer issues it may also caused the reported crash in zlib (since 1.6.4 but > also affects 1.6.5), that would be thread "Crash with kernel

Re: [PATCH] MEDIUM: init: allow directory as argument of -f

2016-05-13 Thread Willy Tarreau
On Fri, May 13, 2016 at 06:38:06PM +0200, Nenad Merdanovic wrote: > Hello Willy, > > On 5/13/2016 12:54 PM, Willy Tarreau wrote: > > Wait a minute, what do you mean by "different lower/upper case sorting" ? > > Do you mean that alphasort() ignores the case ? I'm seeing no mention about > > it in

Re: [PATCH] MEDIUM: init: allow directory as argument of -f

2016-05-13 Thread Nenad Merdanovic
Hello Willy, On 5/13/2016 12:54 PM, Willy Tarreau wrote: > Wait a minute, what do you mean by "different lower/upper case sorting" ? > Do you mean that alphasort() ignores the case ? I'm seeing no mention about > it in the man page, so I'm confused. If this is the case, it can be annoying > for

Re: 100% cpu , epoll_wait()

2016-05-13 Thread Lukas Tribus
Hi Willy, Am 13.05.2016 um 17:01 schrieb Willy Tarreau: Hi Sebastian, On Thu, May 12, 2016 at 09:58:22AM +0200, Sebastian Heid wrote: Hi Lukas, starting from around 200mbit/s in, haproxy processes (nbproc 6) are hitting 100% cpu regularly (noticed up to 3 processes at the same time with

Re: Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Arthur Țițeică
I already went back and forth between the 2 versions to confirm that it's still working fine in 1.6.4. When I get home I will try to start haproxy in debug mode and I will try to strace it (any help on this would be appreciated). If all fails I will reboot the server in a non-grsec kernel (4.5.2

Re: Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Willy Tarreau
On Fri, May 13, 2016 at 06:30:35PM +0300, Arthur ??i??eic?? wrote: > Hi, > > 1.6.4 worked fine with the same config. > > I noticed this because I have the same port bound on 127.0.0.1 too and > haproxy refused to start after upgrade. > > Another curious thing is that with haproxy bind on *two*

Re: Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Pavlos Parissis
On 13/05/2016 04:41 μμ, Arthur Țițeică wrote: > Hi, > > With the 1.6.5 upgrade I see that a configuration like this > > listen tcp-imap > bind 1.2.3.4:143 name imap-v4 > > will make haproxy listen on all ipv4 addresses instead. > > # ss -ltnp | column -t| grep

Re: Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Arthur Țițeică
Hi, 1.6.4 worked fine with the same config. I noticed this because I have the same port bound on 127.0.0.1 too and haproxy refused to start after upgrade. Another curious thing is that with haproxy bind on *two* ipv4 addresses I also see two *:143 in the 'ss' output. This is not specific to

Re: Adding backend server name as request header

2016-05-13 Thread Willy Tarreau
On Thu, May 12, 2016 at 11:09:09PM +0200, Dennis Jacobfeuerborn wrote: > Hi, > remember that this directive adds a request header and not a response > header i.e. you will not see this header in the response in the browser > but only in the request on the backend server that will serve the >

Re: Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Willy Tarreau
Hi Arthur, On Fri, May 13, 2016 at 05:41:50PM +0300, Arthur ??i??eic?? wrote: > Hi, > > With the 1.6.5 upgrade I see that a configuration like this > > listen tcp-imap > bind 1.2.3.4:143name imap-v4 > > will make haproxy listen on all ipv4 addresses instead. > > # ss -ltnp | column

Re: Regarding http basic authentication in haproxy

2016-05-13 Thread Willy Tarreau
On Fri, May 13, 2016 at 08:38:50AM +1000, Igor Cicimov wrote: > On 13 May 2016 4:19 am, "bln prasad" wrote: > > > > Hi, > > I've setup basic http authentication in the frontend. I'm finding that > it's asking for authentication for first time only when i access from the >

Re: Managing `Expect: 100-continue` in HAProxy?

2016-05-13 Thread Willy Tarreau
Hi James, On Fri, May 06, 2016 at 02:41:12PM -0700, James Brown wrote: > We've got HAProxy sitting in front of a menagerie of web servers, none > of which handle `Expect: 100-continue` in any way, shape, or form. > When someone hits us with a POST from cURL, there's a kind of > irritating 1

Re: 100% cpu , epoll_wait()

2016-05-13 Thread Willy Tarreau
Hi Sebastian, On Thu, May 12, 2016 at 09:58:22AM +0200, Sebastian Heid wrote: > Hi Lukas, > > starting from around 200mbit/s in, haproxy processes (nbproc 6) are > hitting 100% cpu regularly (noticed up to 3 processes at the same time with > 100%), but recover again on its own after some time.

胶东大樱桃,顺丰空运!

2016-05-13 Thread 胶东大樱桃
淘宝链接: https://item.taobao.com/item.htm?id=531564140475 胶东大樱桃,顺丰空运! 小女子的樱桃店新开张优惠多多! 你敢买我就敢减! 前100名订单再优惠10元! 淘宝链接: https://item.taobao.com/item.htm?id=531564140475 <<< image/jpeg; name="大樱桃.jpg": Unrecognized >>>

Re: Haproxy running on 100% CPU and slow downloads

2016-05-13 Thread Willy Tarreau
On Fri, May 13, 2016 at 07:32:36PM +0530, Sachin Shetty wrote: > In 24 hours all servers had connections growing, we have reverted the > patch for now. > > I have the show sess all output if you would like to see. Interestingly in the "show sess all" from yesterday I'm seeing only negative

Haproxy 1.6.5 listens on all IPv4 addresses

2016-05-13 Thread Arthur Țițeică
Hi, With the 1.6.5 upgrade I see that a configuration like this listen tcp-imap bind 1.2.3.4:143name imap-v4 will make haproxy listen on all ipv4 addresses instead. # ss -ltnp | column -t| grep 143 LISTEN 0 50 *:143 *:* users:(("haproxy",pid=13010,fd=19)) IPv6 works as

Re: Haproxy running on 100% CPU and slow downloads

2016-05-13 Thread Willy Tarreau
Hi Sachin, On Fri, May 13, 2016 at 07:32:36PM +0530, Sachin Shetty wrote: > In 24 hours all servers had connections growing, we have reverted the > patch for now. > > I have the show sess all output if you would like to see. Thank you very much, that's extremely useful. I'll probably get back

Re: Haproxy running on 100% CPU and slow downloads

2016-05-13 Thread Sachin Shetty
In 24 hours all servers had connections growing, we have reverted the patch for now. I have the show sess all output if you would like to see. Thanks Sachin On 5/12/16, 10:08 PM, "Sachin Shetty" wrote: >Hi Lukas, > >Attached output. > >Thanks >Sachin > >On 5/12/16, 7:41

Re: dynamically choosing back-end port

2016-05-13 Thread William Lallemand
Hi Derek, I have the same need and I'm working on the 'http-request set-dst' and 'http-request set-dst-port' actions to cover it. It would work in the same way as 'http-request set-src' do with the evaluation of an expression. On Thu, May 12, 2016 at 12:15:48PM -0700, Derek Brown wrote: > Hi-

Re: [PATCH] MEDIUM: init: allow directory as argument of -f

2016-05-13 Thread Willy Tarreau
On Fri, May 13, 2016 at 11:18:23AM +0200, Nenad Merdanovic wrote: > >> If the .cnf files contain rules that are sensitive to ordering, this > >> could be problematic. I am not saying we should change it, just to > >> consider it :) > > > > I've thought about this as well but figured that we'd

Re: [PATCH] MEDIUM: init: allow directory as argument of -f

2016-05-13 Thread Cyril Bonté
Hi all, Le 13/05/2016 08:07, Willy Tarreau a écrit : Hi Maxime, On Fri, May 13, 2016 at 12:48:43AM +0200, Maxime de Roucy wrote: If -f argument is a directory add all the files (and only files) it containes to the config files list. These files are added in lexical order (man alphasort). Only

Architectural Rendering - Architectural stories though images

2016-05-13 Thread SA Digital
Introducing you great architectural visualization company. View this email in your browser (http://us13.campaign-archive2.com/?u=8a11ba767c0a3d6cbbd1cf745=496793bc91=67ca1c05f0) Hi, I'm Tom Yang from Guangzhou Sea-Art Digital Technology Co., Ltd. We are a group of highly skilled experts from

Re: [PATCH] MEDIUM: init: allow directory as argument of -f

2016-05-13 Thread Nenad Merdanovic
Hello Willy, On 5/13/2016 11:04 AM, Willy Tarreau wrote: > Hi Nenad, > > On Fri, May 13, 2016 at 11:02:01AM +0200, Nenad Merdanovic wrote: >> Hello, >> >> On 5/13/2016 8:07 AM, Willy Tarreau wrote: >>> I think I'm fine with this one (I'll still wait a bit to let others >>> respond). >>> I just

Re: [PATCH] MEDIUM: init: allow directory as argument of -f

2016-05-13 Thread Willy Tarreau
Hi Nenad, On Fri, May 13, 2016 at 11:02:01AM +0200, Nenad Merdanovic wrote: > Hello, > > On 5/13/2016 8:07 AM, Willy Tarreau wrote: > > I think I'm fine with this one (I'll still wait a bit to let others > > respond). > > I just have one small request, please move the addition of > >

Re: [PATCH] MEDIUM: init: allow directory as argument of -f

2016-05-13 Thread Nenad Merdanovic
Hello, On 5/13/2016 8:07 AM, Willy Tarreau wrote: > I think I'm fine with this one (I'll still wait a bit to let others respond). > I just have one small request, please move the addition of list_append_word() > to its own patch : if later we use it to fix a bug which needs to be > backported,

Re: [PATCH] MEDIUM: init: allow directory as argument of -f

2016-05-13 Thread Willy Tarreau
Hi Maxime, On Fri, May 13, 2016 at 12:48:43AM +0200, Maxime de Roucy wrote: > If -f argument is a directory add all the files (and only files) it > containes to the config files list. > These files are added in lexical order (man alphasort). > Only files with ".cfg" extension are added. > Only