Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14435#discussion_r7461
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -167,6 +212,8 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14435#discussion_r73334011
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -692,11 +864,17 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14026#discussion_r69382788
--- Diff:
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/ConsumerStrategy.scala
---
@@ -79,8 +81,71 @@ private case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14031#discussion_r69382719
--- Diff: project/SparkBuild.scala ---
@@ -723,8 +723,8 @@ object Unidoc {
.map(_.filterNot(_.getCanonicalPath.contains("org/a
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14030#discussion_r69382676
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ForeachSinkSuite.scala
---
@@ -35,35 +35,109 @@ class ForeachSinkSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14030#discussion_r69382669
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ForeachSinkSuite.scala
---
@@ -35,35 +35,109 @@ class ForeachSinkSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14020#discussion_r69382827
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -264,7 +270,7 @@ private[hive] class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14030#discussion_r69382667
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ForeachSinkSuite.scala
---
@@ -35,35 +35,109 @@ class ForeachSinkSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390189
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/RandomForestClassifierSuite.scala
---
@@ -158,7 +159,7 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390204
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/evaluation/RegressionEvaluatorSuite.scala
---
@@ -42,9 +43,10 @@ class RegressionEvaluatorSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390216
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/CountVectorizerSuite.scala ---
@@ -44,7 +45,7 @@ class CountVectorizerSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69391151
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -52,23 +53,20 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69391139
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/VectorIndexerSuite.scala ---
@@ -102,7 +103,7 @@ class VectorIndexerSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69391176
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/util/MLUtilsSuite.scala ---
@@ -282,9 +281,7 @@ class MLUtilsSuite extends SparkFunSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390132
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -134,15 +135,14 @@ class GBTClassifierSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390144
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -55,7 +56,7 @@ class LogisticRegressionSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390147
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -869,8 +870,7 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390185
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -55,7 +56,7 @@ class OneVsRestSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390178
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/NaiveBayesSuite.scala
---
@@ -47,7 +48,7 @@ class NaiveBayesSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390388
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/NormalizerSuite.scala ---
@@ -61,7 +62,7 @@ class NormalizerSuite extends SparkFunSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390273
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/MinMaxScalerSuite.scala ---
@@ -57,8 +58,7 @@ class MinMaxScalerSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390423
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/OneHotEncoderSuite.scala ---
@@ -29,10 +29,11 @@ import org.apache.spark.sql.types
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69391120
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -39,7 +40,7 @@ class StringIndexerSuite
test
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390117
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/ClassifierSuite.scala
---
@@ -71,8 +71,7 @@ class ClassifierSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390173
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifierSuite.scala
---
@@ -116,7 +117,7 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69432798
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -55,7 +56,7 @@ class LogisticRegressionSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14680#discussion_r75073488
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -40,6 +40,8 @@ class TextFileFormat
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14680#discussion_r75182485
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -40,6 +40,8 @@ class TextFileFormat
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/16812#discussion_r99934599
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala
---
@@ -110,7 +110,11 @@ private[csv] class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/16812#discussion_r99935530
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -139,6 +140,20 @@ class CSVSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/16812#discussion_r99935349
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchemaSuite.scala
---
@@ -73,6 +73,12 @@ class
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/17042
[CORE][MINOR] Fix scaladoc
## What changes were proposed in this pull request?
Minor change to scaladoc of `HeartbeatReceiver` (the method is certainly
not for tests only
Github user jaceklaskowski closed the pull request at:
https://github.com/apache/spark/pull/17042
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/17042
Makes sense. Thanks @srowen!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14722
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14720#discussion_r75601795
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -865,6 +865,16 @@ class HiveQuerySuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14720#discussion_r75601779
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -87,6 +88,9 @@ private[hive] class HiveClientImpl
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14680
How about now @HyukjinKwon ? The more I look at it the more I think it
should calculated automatically out of the class name when constructor's
called. It's of little to no value
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14637#discussion_r75574292
--- Diff: project/SparkBuild.scala ---
@@ -56,9 +56,9 @@ object BuildCommons {
"tags", "sketch"
).map(Proj
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14680
Thanks @HyukjinKwon You're helping me a lot! I'll work on the unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14680
@rxin @HyukjinKwon Mind reviewing it again and letting me know what you
think? I know it's minor but would greatly appreciate having it merged at your
earliest convenience. Thanks
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14435#discussion_r73332573
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -53,6 +53,40 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14435#discussion_r7286
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -112,6 +152,11 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14435#discussion_r7585
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -495,6 +573,92 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14435#discussion_r7741
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -495,6 +573,92 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14435#discussion_r73334167
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -731,6 +909,20 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73336967
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2065,18 +2065,28 @@ object EliminateUnions
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337012
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2109,15 +2119,12 @@ object CleanupAliases
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337074
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -25,7 +27,8 @@ import
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337027
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2109,15 +2119,12 @@ object CleanupAliases
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337136
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337186
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r73337237
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -218,9 +221,44 @@ class AnalysisSuite
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/14808
[SPARK-17156][ML][EXAMPLE] Add multiclass logistic regression Scala Example
## What changes were proposed in this pull request?
New example for `MultinomialLogisticRegression` ML
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14891
Frankly, I'd not have bothered with the changes if I had not seen them
elsewhere. See
http://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.sql.Dataset
and look
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14958
Would be nice to have a test in Spark to see if the changes to snappy made
any sense to Spark (not that I'm against -- just as a safety measure that it
did improve things if possible
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14958
Fair enough. It was just an idea that would make the upgrade even more
super-needed. The issues that snappy has fixed could manifest in various ways
in Spark and while doing so could uncover
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14808
Any news on that @sethah? I've seen some discussions about the changes to
unify the interfaces, but am wondering how close the other PRs are so I could
help with that one myself
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14891
@srowen, anyone you'd recommend to accept the PR (after you accepted)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/14891
[SQL][DOC][MINOR] Add (Scala-specific) and (Java-specific)
## What changes were proposed in this pull request?
Adds (Scala-specific) and (Java-specific) to Scaladoc.
## How
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14808
Thanks @MLnick. What would you suggest with the PR then (after the comments
from @sethah)? Please guide.
---
If your project is set up for it, you can reply to this email and have your
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14808
@sethah I seem to have missed the other comment with the notes what has to
be done to make the PR an example for the change. Sorry.
Since I'm very new to it and the only way to learn
Github user jaceklaskowski closed the pull request at:
https://github.com/apache/spark/pull/14808
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/15353
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14808
@sethah Anything to improve the example. I'm open for suggestions and
improve the example (to learn that part better). Thanks!
---
If your project is set up for it, you can reply
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14681#discussion_r75074428
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/ui/StreamingJobProgressListenerSuite.scala
---
@@ -68,6 +68,7 @@ class
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/14680
[SPARK-17101][SQL] Provide format identifier for TextFileFormat
## What changes were proposed in this pull request?
Define the format identifier that is used in Optimized Logical
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14808
I don't mind adapting the example to the upcoming changes and I can work on
it. But..
SPARK-17163 has no Fix Version/s field assigned so I'm reading it that it's
not clear whether
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/14771
[SPARK-17199] Use CatalystConf.resolver for case-sensitivity comparison
## What changes were proposed in this pull request?
Use `CatalystConf.resolver` consistently for case
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/15257#discussion_r80858277
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -52,13 +53,51 @@ object Literal
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/15268
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/15257#discussion_r80663732
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -52,13 +53,51 @@ object Literal
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/15603
The test failure doesn't seem to be due to my change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/15603
[WEBUI][MINOR] Return types in methods + cleanup
## What changes were proposed in this pull request?
The main purpose of the change is to discuss the purpose of `SparkUITab`
class
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/15603
The build has just proved that my thinking was correct. I think I'll
propose few other (more agressive) changes to clean the code up a little bit
more. I'd appreciate any comments
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/15603#discussion_r84653856
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -93,15 +91,15 @@ private[spark] class SparkUI private (
/** Stop
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/15603#discussion_r84653954
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -135,7 +133,7 @@ private[spark] class SparkUI private (
private[spark
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/15603
Anything else you'd change/remove/add, Mr @srowen?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/15688#discussion_r85665836
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1636,15 +1635,23 @@ class DDLSuite extends QueryTest
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/15758
[MINOR] Remove calculation of bucket spec when not expected
## What changes were proposed in this pull request?
Remove calculation of bucket spec when asserted not to have one
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/15758
Thanks @rxin for looking into it. While reviewing that code I noticed the
call and thought I'd push it for review here since...`getBucketSpec` is
superfluous given `assertNotBucketed("
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/15603#discussion_r85516045
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -135,7 +133,7 @@ private[spark] class SparkUI private (
private[spark
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/15603#discussion_r85638347
--- Diff: core/src/test/scala/org/apache/spark/ui/UISuite.scala ---
@@ -179,16 +179,15 @@ class UISuite extends SparkFunSuite {
test("v
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/15603#discussion_r85638393
--- Diff: core/src/test/scala/org/apache/spark/ui/UISuite.scala ---
@@ -179,16 +179,15 @@ class UISuite extends SparkFunSuite {
test("v
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16250
Just to have the list of the reasons not to accept the changes:
1. @rxin "just fyi this is going to be slower than the original code."
2. @shivaram "Its
Github user jaceklaskowski closed the pull request at:
https://github.com/apache/spark/pull/16250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16309
Right. Testing ScalaTest 3.0.1 with the following sbt command:
```
sbt -Phadoop-2.3 -Pmesos -Pkinesis-asl -Pyarn -Phive-thriftserver -Phive
test:package streaming-kafka-0-8
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16309
Had to introduce changes to the tests given "Expired deprecations" in
[ScalaTest 3.0.0](http://www.scalatest.org/release_notes/3.0.0).
---
If your project is set up for it, you
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16309
Think the latest test failures are somehow related to:
```
Please set the environment variable SCALACTIC_FILL_FILE_PATHNAMES to yes at
compile time to enable this feature
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/16309
[SPARK-18896][TESTS] Suppress ScalaCheck warning
## What changes were proposed in this pull request?
Fixes ScalaCheck warning by upgrading to the latest 1.13.4 version
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16309
Just learnt about `export SPARK_TESTING=1` to avoid some test failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16309
Learnt about `./dev/test-dependencies.sh --replace-manifest` just now.
(Where's this all described?)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16309
Rebasing with master to trigger tests on Jenkins...(hoping this time they
pass)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16309
Hey @srowen, any idea about the following error? I'd appreciate any hints
to help me fix it.
```
[info] - can use a custom recovery mode factory (57 milliseconds)
Exception
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16309
@srowen Please help as I'm stuck with the `OutOfMemoryError: GC overhead
limit exceeded` error. Should Jenkins run the tests with 6g?
What's even more interesting is that the tests
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16309
The tests ran locally on my laptop have finished after...`7431 s` which is
2 hours (!)
```
[error] (sql/test:test) sbt.TestsFailedException: Tests unsuccessful
[error
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/16250
[CORE][MINOR] Stylistic changes in DAGScheduler (to ease comprehensioâ¦
## What changes were proposed in this pull request?
Stylistic changes in `DAGScheduler` to ease
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16145
@rxin @srowen Please re-review and act accordingly. Thanks a lot for your
help so far!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/16250#discussion_r91860470
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -333,16 +333,16 @@ class DAGScheduler(
// (so we don't
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/16250
Thanks @srowen for the review! I do understand your point and remember you
and @rxin have always been telling me that I should not touch code unless
there's a need for a change
301 - 400 of 589 matches
Mail list logo
