On Fri, 24 Jul 2015 17:08:48 +0200
win...@genial.ms wrote:
> > > I did look through all these miscellaneous files we have inside the
> > > repository:
> > > - I fixed a few minor issues, like wrong version number in docs.
> > > - packaging/debian and packaging/gentoo contain ancient files referring
> > > to freecol 0.3.0 and Java 1.4. These have been changed by the packagers
> > > meanwhile. We may want to delete them as we dont use them or update them
> > > to have newer examples for other packagers.
> > 
> > Go for it.
> 
> "A or B?"
> "Yes"
> *confused*
> I guess I'll delete them.

Yes, that was what I meant.  They were just baggage.
 
>>[developer.tex]
> I'd like to add it to the install, as it might attract new contributors.
> Lets see how far I get.

OK, however lets clear the release-critical things first.

> > > Its also weird that some translations are hardcoded in build.xml, when
> > > the helper would choose them automatically depending on how complete
> > > they are. Is that intentional?
> > 
> > No idea alas.  Sounds like it could be improved, but I am not sure it
> > buys us much.
>
> I would think if many translations are missing that would be a release
> blocker, but checking that enough are included is also dependent on getting
> the installer built first.

I am not sure that the hardcoding in build.xml necessarily means that that
is an exhaustive list of all translations included.  Notice how it uses
three letter codes, whereas we are using two letters on the files in
data/strings.  It might just be setting up a mapping between the 3-letter
and 2-letter cases.  I can not do a windows install to check this, but I
can look inside the java-installer, and AFAICT it contains all the files
in the strings directory.  This would have been equally broken in 0.11.3
though, so if you do a clean install of 0.11.3 and check what languages
are available that should make this clear.

> > > - We dont use 2 of the 3 font types we bundle
> > 
> > Which ones?
> 
> Imperator.ttf and Liberation*.ttf in data/base/resources/fonts are unused atm.

OK.  Liberation was introduced quite a while ago due to complaints about
the readability of the standard fonts.  I argued mildly against it at the
time on the grounds that it was likely to go unmaintained (which
turned out to be true:-) and that we should not package fonts but
just use what the user had selected for their desktop.  In my case, at
the time that would have been Liberation:-).  That idea failed as no one
was sure it could be done portably.  Also, as you mention, there was a
desire for FreeCol to look the same on all systems.  FTR I do not favour
that idea either, preferring to give user decisions priority, but it is not
that important.

However, that was with Java 1.5 IIRC. Good chance the readability problem
has solved itself, but I would not be the one to make that call. What I can
say is that I have not noticed a problem reading the standard text since
your font reworking, and I have rubbish eyesight.  So I do not see much to
be gained by re-enabling Liberation.

IIRC Imperator was in place when I joined the project, so I can not
comment much on it.  I will try your patch at some point post-release and
comment further then.

> We seem to have a mechanism for deactivating those fonts for CJK, Cyrillic
> and other languages.

Which further suggests to me that trying to achieve a uniform appearance
everywhere is futile.

> > > and I dont know if these
> > > should get used again and how to make sure there are no missing glyphs
> > > the currently used fonts Java provides have?
> > 
> > I think it is better to use the standard Java fonts where reasonably
> > possible, and delegate to them the responsibility of providing a rich
> > set of glyphs.  AFAICT they are pretty good ATM on linux at least.
> > Are you aware of missing glyph problems?
> 
> General cautiousness, as I'm aware most fonts only provide a limited
> subset of glyphs. Do you have a program that allows listing which glyphs
> for which characters are included in a ttf?

<insert gratuitous "Of course, linux has everything" comment:->

ttfdump might be what you want.  If I run it on Imperator.ttf I
get 1.5M of text which probably means something to someone who knows the
ttf format.  Let me know if you want the data.

I am trying to untangle the mail backlog, so I will respond to your later
message about the 3-dot character separately.

> I encourage you to backup the SVN once. The art files in there feel really
> valuable to me and I plan on using many later. For example, extracting 
> possibly
> layered high res graphics from psd files, where we currently only have ugly 
> baked
> lowres versions in git, which gets blurry on zooming in, should be done 
> someday.

Can I get you to do that, as you know what you want.  The "unused"
directory would be a good place to put them:-).  Speaking of which, in the
next release I am hoping to work on the ability to sail to other European
ports post-independence, and I always liked bg_europe.jpg and might find a
use for it.  So thanks for the reminder of it, and I now know where to
find it.

Cheers,
Mike Pope

Attachment: pgpVs5ztOoOnr.pgp
Description: OpenPGP digital signature

------------------------------------------------------------------------------
_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Reply via email to