On Fri, Mar 12, 2010 at 7:14 PM, Jani Taskinen <jani.taski...@iki.fi> wrote: > On 03/12/2010 08:08 PM, Stanislav Malyshev wrote: >> >> Hi! >> >>> Having tests in multiple branches is PITA. Hasn't anyone considered that >>> the best way would be to move all tests into their own repository >>> (directory..whatever :) in SVN..? Considering they are supposed to be >> >> Yes, but: some tests are version-dependant, some are not. And since we > > That's why we'd need to add some section to select the minimum version > required to run the test. > >> have this "output match" testing paradigm, it would probably keep being >> this way. If you're going to have branches in that SVN, how it would be >> different from what we have now? > > Considering what I said above about version check..why would you need > branches in it? And what/how does it matter what the tests output if it > needs to be same in any PHP version anyway..?
What you describe may work for PHP core features without external dependencies but will fail for anything with external dependencies. Many tests fail because they are written for a given platform, or even worst (from a portability point of view), only for a given configuration (library version, system version,etc.). And that's not about windows vs other, tests can work on a Debian/ubuntu version and fail on another. However the idea of shared tests is what I've been adovocating for some time already, to improve portability and BC checks. It requires to write true unit tests, and huge test including dozen of cases being tested in one test. It will also require to rewite many tests to output something when it fails instead of testing standard outpout with system dependent messages (think about localization too, which can affect behaviors as well). All in all I lilke the idea and will support it as much as I can. We have to keep in mind that it will need a couple of testfests to realize it(read: huge work, more like doing it from scratch for 40-60% of the existing test, rough estimation). Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
