[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 2: > Can we add a basic custo

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 2: > Sailesh: Even though it

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 3: Code-Review+2 preads add s

[Impala-ASF-CR] [DOCS] Added a link to impala kerberos doc in impala-shell options doc

2018-05-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10482 ) Change subject: [DOCS] Added a link to impala kerberos doc in impala-shell options doc .. Patch Set 1: Code-Review+2 -- To view, vis

[Impala-ASF-CR] [DOCS] Sentry is required for Impala to enable delegation

2018-05-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10451 ) Change subject: [DOCS] Sentry is required for Impala to enable delegation .. Patch Set 2: Is there a JIRA that states that delegation

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 4: > > preads add some overhe

[Impala-ASF-CR] [DOCS] Sentry is required for Impala to enable delegation

2018-05-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10451 ) Change subject: [DOCS] Sentry is required for Impala to enable delegation .. Patch Set 2: Code-Review+2 Thanks for sharing the info.

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 1: Should we run benchmarks to see if upgrading this causes any regressions?

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances() RPC per query.

2018-05-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() RPC per query. .. Patch Set 2: (9 comments) ht

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10480 To un

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. Patch Set 3: (2 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. Patch Set 5: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. Patch Set 6: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-7082: Show human readable size in query backend page

2018-05-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10523 ) Change subject: IMPALA-7082: Show human readable size in query backend page .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-05-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10529 Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error .. IMPALA-6990: TestClientSsl.test_tls_v12 fail

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-05-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10529 ) Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error .. IMPALA-6990: TestClientSsl.test_tls_v12 faili

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-05-29 Thread Sailesh Mukil (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10529 to look at the new patch set (#3). Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error .

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-05-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10529 ) Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error .. Patch Set 2: (2 comments) > (2 comments)

[Impala-ASF-CR] [DOCS] A typo fix in runtime filtering doc

2018-05-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10544 ) Change subject: [DOCS] A typo fix in runtime filtering doc .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-05-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10529 ) Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error .. Patch Set 3: Code-Review+1 > (5 comments)

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-05-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10529 ) Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error .. Patch Set 3: > > (5 comments) > > > > My

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-05-30 Thread Sailesh Mukil (Code Review)
Hello Michael Brown, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10529 to look at the new patch set (#4). Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error ..

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-05-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10529 ) Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error .. Patch Set 4: Code-Review+2 (5 comments) T

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-05-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 2: (2 comments) http://gerrit.clo

[Impala-ASF-CR] Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously

2018-05-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously .. Patch Set 1: Code-Review+2 -- To v

[Impala-ASF-CR] Revert "IMPALA-5893: Remove old kinit code for Impala 3"

2018-05-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10563 Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3" .. Revert "IMPALA-5893: Remove old kinit code for Impala 3" Th

[Impala-ASF-CR] Revert "IMPALA-5893: Remove old kinit code for Impala 3"

2018-05-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10563 ) Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3" .. Patch Set 1: > Is this a clean revert ? Yes, the revert w

[Impala-ASF-CR] IMPALA-7109: fix test multiple partitions same location paths

2018-06-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10575 ) Change subject: IMPALA-7109: fix test_multiple_partitions_same_location paths .. Patch Set 1: (1 comment) Was looking at IMPALA-6119,

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 3: (2 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-7109: fix test multiple partitions same location paths

2018-06-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10575 ) Change subject: IMPALA-7109: fix test_multiple_partitions_same_location paths .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-7109: fix test multiple partitions same location paths

2018-06-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10575 ) Change subject: IMPALA-7109: fix test_multiple_partitions_same_location paths .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 2: > Surely, we're not shipping fe/src/test/

[Impala-ASF-CR] IMPALA-7099: Don't set FILESYSTEM PREFIX for s3

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10595 ) Change subject: IMPALA-7099: Don't set FILESYSTEM_PREFIX for s3 .. Patch Set 2: Code-Review+2 Thanks for doing this! We should've idea

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 6: (2 comments) Just one more thi

[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 2: Code-Review+1 > My private build hit IMPA

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10560 To

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: > We hadn't really opened up commits yet, but this one seems safe. > I'm

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 3: Verified+1 > It's a whitespace-only change and it compiled. Thanks for t

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 9: Code-Review+1 > (1 comment) >

[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance

2018-06-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10669 Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. IMPALA-7157: Avoid unnecessarily pre

[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance

2018-06-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 ) Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. Patch Set 1: > Uploaded patch set

[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init

2018-06-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 ) Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance

2018-06-11 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10669 to look at the new patch set (#2). Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance ...

[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance

2018-06-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 ) Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. Patch Set 1: Code-Review+1 (2 comm

[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling

2018-06-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR](asf-site) IMPALA-7005: [DOCS] Noted which version the 3.0 changelog generated from

2018-06-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10687 ) Change subject: IMPALA-7005: [DOCS] Noted which version the 3.0 changelog generated from .. Patch Set 1: (1 comment) http://gerrit.c

[Impala-ASF-CR](asf-site) IMPALA-7005: [DOCS] Noted which version the 3.0 changelog generated from

2018-06-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10687 ) Change subject: IMPALA-7005: [DOCS] Noted which version the 3.0 changelog generated from .. Patch Set 2: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling

2018-06-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. Patch Set 7: Code-Review+1 (1 comment) One last comment. LG

[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance

2018-06-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 ) Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. Patch Set 3: Code-Review+2 Rebase,

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 11: Code-Review+1 (1 comment) Sor

[Impala-ASF-CR] IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed

2018-06-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10751 ) Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed .. Patch Set 1: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-7151: Rework ephemeral port assignment for be tests

2018-06-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10740 ) Change subject: IMPALA-7151: Rework ephemeral port assignment for be tests .. Patch Set 2: > Ping I'll have a first pass at this by E

[Impala-ASF-CR] IMPALA-7151: Rework ephemeral port assignment for be tests

2018-06-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10740 ) Change subject: IMPALA-7151: Rework ephemeral port assignment for be tests .. Patch Set 2: (7 comments) Thanks for doing this. This a

[Impala-ASF-CR] IMPALA-7151: Rework ephemeral port assignment for be tests

2018-06-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10740 ) Change subject: IMPALA-7151: Rework ephemeral port assignment for be tests .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-7151: Rework ephemeral port assignment for be tests

2018-06-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10740 ) Change subject: IMPALA-7151: Rework ephemeral port assignment for be tests .. Patch Set 4: Code-Review+2 (1 comment) LGTM. Please als

[Impala-ASF-CR] IMPALA-5202: Disallow PREPARE:WAIT debug action

2018-06-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10776 ) Change subject: IMPALA-5202: Disallow PREPARE:WAIT debug action .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] WIP: IMPALA-7163

2018-06-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/10781 ) Change subject: WIP: IMPALA-7163 .. WIP: IMPALA-7163 Change-Id: I27158dae217b0e22445377e5935eb71a906688b5 --- M be/src/runtime/coordinat

[Impala-ASF-CR] WIP: IMPALA-7163

2018-06-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. ( http://gerrit.cloudera.org:8080/10781 ) Change subject: WIP: IMPALA-7163 .. Abandoned Whoops, meant to push it as a draft to gerrit. This is not ready for review. Sorry for the noise

[Impala-ASF-CR] IMPALA-7200: Fix missing FILESYSTEM PREFIX hitting local dataload

2018-06-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10803 ) Change subject: IMPALA-7200: Fix missing FILESYSTEM_PREFIX hitting local dataload .. Patch Set 1: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-7207: make Coordinator::exec state an atomic enum

2018-06-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10811 ) Change subject: IMPALA-7207: make Coordinator::exec_state_ an atomic enum .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-7207: make Coordinator::exec state an atomic enum

2018-06-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10811 ) Change subject: IMPALA-7207: make Coordinator::exec_state_ an atomic enum .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. IMPALA-7163: Implement a state machine for the QuerySt

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 2: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated

2018-06-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10815 ) Change subject: IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated .. Patch Set 1: (1 co

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10827 Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. IMPALA-7215: Implement a templatized CountingBarrier Currently,

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-27 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10827 to look at the new patch set (#2). Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. IMPALA-7215

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-27 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10827 to look at the new patch set (#3). Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. IMPALA-7215

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 ) Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated

2018-06-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10815 ) Change subject: IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated .. Patch Set 6: Code-R

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10827 to look at the new patch set (#4). Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. IMPALA-7215

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 ) Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10827 ) Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. Patch Set 5: Code-Review+2 (4 comments) Thanks for the review

[Impala-ASF-CR] IMPALA-7215: Implement a templatized CountingBarrier

2018-06-28 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10827 to look at the new patch set (#5). Change subject: IMPALA-7215: Implement a templatized CountingBarrier .. IMPALA-7215

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-28 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#3). Change subject: IMPALA-7163: Implement a state machine for the QueryState class .

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 2: (13 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-06-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 2: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-06-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 1: Some high level questions:

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-06-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10843 Change subject: IMPALA-4784: Remove InProcessStatestore .. IMPALA-4784: Remove InProcessStatestore InProcessStatestore was only used by

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-06-29 Thread Sailesh Mukil (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10843 to look at the new patch set (#2). Change subject: IMPALA-4784: Remove InProcessStatestore .. IMPALA-4784: Remove

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-06-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10843 ) Change subject: IMPALA-4784: Remove InProcessStatestore .. Patch Set 2: Code-Review-1 Found a bug. Will upload a new patchset shortly.

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-06-29 Thread Sailesh Mukil (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10843 to look at the new patch set (#3). Change subject: IMPALA-4784: Remove InProcessStatestore .. IMPALA-4784: Remove

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-06-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10843 ) Change subject: IMPALA-4784: Remove InProcessStatestore .. Patch Set 3: This is ready for review now. -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-07-02 Thread Sailesh Mukil (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10843 to look at the new patch set (#4). Change subject: IMPALA-4784: Remove InProcessStatestore .. IMPALA-4784: Remove

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-07-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10843 ) Change subject: IMPALA-4784: Remove InProcessStatestore .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/10843/3/be/s

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-07-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10843 ) Change subject: IMPALA-4784: Remove InProcessStatestore .. Patch Set 6: Code-Review+2 Hit a clang-tidy issue. Rebase, carry +2. --

[Impala-ASF-CR] IMPALA-4784: Remove InProcessStatestore

2018-07-02 Thread Sailesh Mukil (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10843 to look at the new patch set (#6). Change subject: IMPALA-4784: Remove InProcessStatestore .

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-03 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#4). Change subject: IMPALA-7163: Implement a state machine for the QueryState class .

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 4: (19 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 4: (2 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-07-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 1: (5 comments) LGTM overall.

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-07-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. Patch Set 2: (37 comments) Did a first pass. Will have anothe

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10763 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 8: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-11 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#6). Change subject: IMPALA-7163: Implement a state machine for the QueryState class .

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 6: (15 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-07-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 3: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-7299: [DOCS] A known issue with IMPALA-7298

2018-07-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10952 ) Change subject: IMPALA-7299: [DOCS] A known issue with IMPALA-7298 .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-7299: [DOCS] A known issue with IMPALA-7298

2018-07-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10952 ) Change subject: IMPALA-7299: [DOCS] A known issue with IMPALA-7298 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-7298: Stop passing IP address as hostname in Kerberos principal

2018-07-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10980 ) Change subject: IMPALA-7298: Stop passing IP address as hostname in Kerberos principal .. Patch Set 1: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-7298: Stop passing IP address as hostname in Kerberos principal

2018-07-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10980 ) Change subject: IMPALA-7298: Stop passing IP address as hostname in Kerberos principal .. Patch Set 1: (1 comment) Patch LGTM. Thank

<    1   2   3   4   5   6   >