Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90857 --- Ship it! A few other minor nits, but I think we can commit this for

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90858 --- Patch looks great! Reviews applied: [36281] All tests passed. - M

Re: Review Request 36273: Doxygen-ification of comments in libprocess process headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36273/#review90852 --- Patch looks great! Reviews applied: [36273] All tests passed. - M

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

> On July 7, 2015, 5:01 p.m., Adam B wrote: > > docs/network-isolation.md, line 79 > > > > > > Why is this a fixed constant limit? Seems like we might want to adjust > > this depending on how many containers are runn

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review90848 --- Patch looks great! Reviews applied: [36226] All tests passed. - M

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/ --- (Updated July 8, 2015, 12:59 a.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 34138: AppC hash computation.

> On July 7, 2015, 3:56 p.m., Jiang Yan Xu wrote: > > 1. Agree that this is useful as a utility in libprocess. Not much overhead > > to move it over right? > > 2. It feels like something that could be exposed as a function rather than > > class, maybe a TODO. OK I realized that doing the afore

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

> On July 8, 2015, 12:01 a.m., Adam B wrote: > > docs/network-isolation.md, line 79 > > > > > > Why is this a fixed constant limit? Seems like we might want to adjust > > this depending on how many containers are run

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

> On July 7, 2015, 11:31 p.m., Jie Yu wrote: > > docs/network-isolation.md, line 7 > > > > > > Please do not delete the version information. Network monitoring is > > added in mesos 0.20 and network isolation is added

Re: Review Request 35947: Added a new API call 'updateAvailable' to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35947/#review90839 --- Ship it! src/master/allocator/mesos/hierarchical.hpp (lines 734 -

Re: Review Request 34139: AppC image discovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34139/#review90830 --- src/slave/containerizer/provisioners/appc/discovery.hpp (lines 43 -

Re: Review Request 36273: Doxygen-ification of comments in libprocess process headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36273/ --- (Updated July 7, 2015, 5:24 p.m.) Review request for mesos, Benjamin Hindman, A

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90837 --- Patch looks great! Reviews applied: [36282] All tests passed. - M

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 12:12 a.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

> On July 7, 2015, 11:43 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, lines 1-7 > > > > > > This should be the “Apache License Version 2.0” header instead which > > applies to libprocess a

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

> On July 7, 2015, 11:24 p.m., Till Toenshoff wrote: > > src/slave/containerizer/containerizer.hpp, line 152 > > > > > > Shouldnt it be called `includeOSEnvironment` instead? Bit unsure right > > now but please cons

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/ --- (Updated July 8, 2015, 12:03 a.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90827 --- Thanks for writing this up! I had a few minor suggestions and some q

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review90832 --- 3rdparty/libprocess/3rdparty/Makefile.am (lines 1 - 7)

Re: Review Request 36037: Adding /call endpoint to Master

> On July 3, 2015, 12:29 a.m., Ben Mahler wrote: > > I chatted with Isabel on IRC and asked her to break apart this change into > > more bite-sized chunks, so that we can do smaller reviews and get things > > committed incrementally: > > > > (1) Dummy /call handler on the master. > > (2) Valid

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90813 --- Ship it! Thanks Paul! This is great! It's a little hard to review

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90828 --- Bad patch! Reviews applied: [36281] Failed command: ./support/appl

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90826 --- Ship it! Barring Adams comment. src/slave/containerizer/container

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90819 --- docs/network-isolation.md (line 29)

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90822 --- Ship it! Looks like a simpler, more generic fix. Maybe external_con

Re: Review Request 36279: Doxygen-ification of comments in libprocess IO headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36279/#review90823 --- Patch looks great! Reviews applied: [36279] All tests passed. - M

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90821 --- Updated the review to use a new optional boolean flag. The docker br

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/ --- (Updated July 7, 2015, 11:05 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

> On July 7, 2015, 10:58 p.m., Joerg Schad wrote: > > src/slave/containerizer/docker.cpp, line 1544 > > > > > > Wouldn't it be easier --especially considering Adam's comment about > > MESOS-2832 and the --executor_

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

> On July 7, 2015, 10:58 p.m., Joerg Schad wrote: > > src/slave/containerizer/docker.cpp, line 1544 > > > > > > Wouldn't it be easier --especially considering Adam's comment about > > MESOS-2832 and the --executor_

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90814 --- src/slave/containerizer/docker.cpp (line 1544)

Re: Review Request 34138: AppC hash computation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34138/#review90791 --- 1. Agree that this is useful as a utility in libprocess. Not much ov

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90812 --- src/slave/containerizer/docker.hpp (line 239)

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90811 --- src/slave/containerizer/docker.cpp (line 1552)

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 2, 2015, 11:32 p.m., Ben Mahler wrote: > > src/linux/cgroups.hpp, lines 443-472 > > > > > > Thanks! > > > > (1) Do you mind updating my TODO on cgroups::stat() to reflect that > > cpuacct::stat is i

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90802 --- Question about MESOS-2832, but otherwise looks good. src/slave/con

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90798 --- docs/network-isolation.md (line 7)

Re: Review Request 36050: Added test authorizer module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/#review90808 --- src/tests/authorization_tests.cpp (line 62)

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review90803 --- include/mesos/authorizer/authorizer.hpp (lines 39 - 40)

Re: Review Request 36275: MESOS-3005: Fix SSL test hostname dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36275/#review90806 --- Patch looks great! Reviews applied: [36246, 36275] All tests passe

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

> On July 7, 2015, 9:32 p.m., Marco Massenzio wrote: > > support/post-reviews.py, line 173 > > > > > > note that here you will be printing the whole commit message, which in > > this case is not appropriate. > >

Re: Review Request 36282: Remove os environment for docker executor enviornment setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90796 --- Ship it! Looks good but see the issue below about moving this insid

Re: Review Request 36279: Doxygen-ification of comments in libprocess IO headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36279/ --- (Updated July 7, 2015, 3:14 p.m.) Review request for mesos, Benjamin Hindman, A

Re: Review Request 36049: Added support for modularized Authorizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review90774 --- There are some nits and slight inconsistencies but overall I think w

Re: Review Request 36275: MESOS-3005: Fix SSL test hostname dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36275/#review90792 --- Ship it! 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 312)

Re: Review Request 36275: MESOS-3005: Fix SSL test hostname dependency.

> On July 7, 2015, 10:08 p.m., Benjamin Hindman wrote: > > Added comment and committed, thanks. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36275/#review90792 -

Review Request 36282: Remove os environment for docker executor enviornment setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/ --- Review request for mesos, Benjamin Hindman and Joerg Schad. Bugs: MESOS-2996

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

> On July 7, 2015, 9:42 p.m., Vinod Kone wrote: > > support/post-reviews.py, line 173 > > > > > > Why 'format' instead of directly printing the message with a %s? Just > > curious. It's a more portable way of print

Re: Review Request 36246: SSL: Fix connection issue on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36246/#review90788 --- Ship it! Ship It! - Benjamin Hindman On July 7, 2015, 8:04 p.m.,

Re: Review Request 36267: MESOS-2943: Add comment for explicit return type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36267/#review90787 --- Ship it! Ship It! - Benjamin Hindman On July 7, 2015, 5:21 p.m.,

Review Request 36281: Document per-container unique egress flows and network queueing statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/ --- Review request for mesos, Ian Downes, Jie Yu, and Cong Wang. Repository: mesos

Re: Review Request 36277: MESOS-3002: Fix getOrElse compilation error for network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36277/#review90786 --- Ship it! Ship It! - Benjamin Hindman On July 7, 2015, 8:59 p.m.,

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/#review90785 --- support/post-reviews.py (line 170)

Re: Review Request 36277: MESOS-3002: Fix getOrElse compilation error for network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36277/#review90784 --- Patch looks great! Reviews applied: [36277] All tests passed. - M

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/#review90783 --- Ship it! Minor nit on error message - fix it and commit. Thanks for

Re: Review Request 36277: MESOS-3002: Fix getOrElse compilation error for network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36277/#review90782 --- Ship it! Ship It! - Adam B On July 7, 2015, 1:59 p.m., Joris Van

Re: Review Request 34141: AppC provsioning backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34141/#review90778 --- src/slave/containerizer/provisioners/appc/backend.cpp (line 139)

Re: Review Request 36275: MESOS-3005: Fix SSL test hostname dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36275/ --- (Updated July 7, 2015, 9:02 p.m.) Review request for mesos, Benjamin Hindman, A

Review Request 36277: MESOS-3002: Fix getOrElse compilation error for network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36277/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-3002 https://iss

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36269/#review90776 --- Patch looks great! Reviews applied: [36269] All tests passed. - M

Re: Review Request 36275: MESOS-3005: Fix SSL test hostname dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36275/ --- (Updated July 7, 2015, 8:04 p.m.) Review request for mesos, Benjamin Hindman, A

Re: Review Request 36246: SSL: Fix connection issue on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36246/ --- (Updated July 7, 2015, 8:04 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/#review90769 --- Patch looks great! Reviews applied: [35986] All tests passed. - M

Review Request 36275: MESOS-3005: Fix SSL test hostname dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36275/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Re: Review Request 36246: SSL: Fix connection issue on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36246/ --- (Updated July 7, 2015, 7:51 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 34142: AppC provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34142/ --- (Updated July 7, 2015, 12:43 p.m.) Review request for mesos, Chi Zhang, Paul Br

Re: Review Request 34141: AppC provsioning backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34141/ --- (Updated July 7, 2015, 12:43 p.m.) Review request for mesos, Chi Zhang, Paul Br

Re: Review Request 34139: AppC image discovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34139/ --- (Updated July 7, 2015, 12:42 p.m.) Review request for mesos, Chi Zhang, Paul Br

Re: Review Request 34140: AppC image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/ --- (Updated July 7, 2015, 12:43 p.m.) Review request for mesos, Chi Zhang, Paul Br

Re: Review Request 34138: AppC hash computation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34138/ --- (Updated July 7, 2015, 12:42 p.m.) Review request for mesos, Chi Zhang, Paul Br

Re: Review Request 34137: Add support for container image provisioners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/ --- (Updated July 7, 2015, 12:42 p.m.) Review request for mesos, Chi Zhang, Paul Br

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

> On July 7, 2015, 6:40 p.m., Vinod Kone wrote: > > CHANGELOG, line 337 > > > > > > I would just put this under deprecations section. > > > > Also, mind updating MESOS-2058 in deprecation section to do > >

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/ --- (Updated July 7, 2015, 7:07 p.m.) Review request for mesos, Adam B and Isabel J

Re: Review Request 36267: MESOS-2943: Add comment for explicit return type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36267/#review90761 --- Ship it! Ship It! - Artem Harutyunyan On July 7, 2015, 10:21 a.m

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

> On July 7, 2015, 11:40 a.m., Vinod Kone wrote: > > CHANGELOG, line 337 > > > > > > I would just put this under deprecations section. > > > > Also, mind updating MESOS-2058 in deprecation section to do > >

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review90757 --- Bad patch! Reviews applied: [32891, 31444] Failed command: ./suppo

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36269/#review90756 --- CHANGELOG (line 337)

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

> On July 7, 2015, 11:35 a.m., Adam B wrote: > > CHANGELOG, line 337 > > > > > > Do you actually want/need MESOS-2640 to go into 0.23.0? > > If so, MESOS-2640 should have its Target Version and Fix Version set to

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36269/#review90754 --- Do you actually want/need MESOS-2640 to go into 0.23.0? CHANGELOG

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/ --- (Updated July 7, 2015, 6:33 p.m.) Review request for mesos, Adam B and Isabel J

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/ --- (Updated July 7, 2015, 11:33 a.m.) Review request for mesos, Chi Zhang, Dominic

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/ --- (Updated July 7, 2015, 6:26 p.m.) Review request for mesos, Adam B and Isabel J

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

> On July 7, 2015, 1:30 a.m., Adam B wrote: > > src/common/attributes.cpp, lines 150-152 > > > > > > There's a subtle difference in behavior between strings::tokenize and > > strings::split. For tokenize, "Empty token

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/#review90741 --- Ship it! Looks great! Fix the log message and I'll commit it. src

Re: Review Request 36267: MESOS-2943: Add comment for explicit return type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36267/#review90744 --- Patch looks great! Reviews applied: [36267] All tests passed. - M

Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36269/ --- Review request for mesos and Adam B. Repository: mesos Description --- P

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/ --- (Updated July 7, 2015, 5:55 p.m.) Review request for mesos, Adam B and Isabel J

Re: Review Request 35981: Added persistent volume user guide.

> On June 30, 2015, 12:14 a.m., Adam B wrote: > > docs/persistent-volume.md, line 56 > > > > > > Can a volume/reservation created by one framework principal only be > > destroyed/unreserved by a framework scheduler usi

Re: Review Request 36204: Pass slave's total resources in ResourceUsage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36204/ --- (Updated July 7, 2015, 5:50 p.m.) Review request for mesos, Ben Mahler, Jie Yu,

Re: Review Request 36193: Improved Doxygen-Styleguide.

> On July 6, 2015, 6:47 p.m., Joseph Wu wrote: > > docs/mesos-doxygen-style-guide.md, line 17 > > > > > > It might be worthwhile to emphasize that markdown syntax can/should be > > used in with the comment blocks. I t

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/ --- (Updated July 7, 2015, 5:46 p.m.) Review request for mesos, Adam B and Isabel J

Review Request 36267: MESOS-2943: Add comment for explicit return type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36267/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Re: Review Request 36204: Pass slave's total resources in ResourceUsage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36204/#review90727 --- Ship it! LGTM! Could you please add a follow up patch to test this

Re: Review Request 36204: Pass slave's total resources in ResourceUsage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36204/#review90722 --- Patch looks great! Reviews applied: [36204] All tests passed. - M

Re: Review Request 36204: Pass slave's total resources in ResourceUsage.

> On July 6, 2015, 5:50 p.m., Jie Yu wrote: > > src/slave/slave.cpp, line 4379 > > > > > > Per my comments above, the logic here needs to be adjusted. We need to > > apply checkpointed resource to info.resources()

Re: Review Request 36204: Pass slave's total resources in ResourceUsage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36204/ --- (Updated July 7, 2015, 4:20 p.m.) Review request for mesos, Ben Mahler, Jie Yu,

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/#review90714 --- Patch looks great! Reviews applied: [35777] All tests passed. - M

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/ --- (Updated July 7, 2015, 3:19 p.m.) Review request for mesos, Benjamin Hindman, M

Re: Review Request 36245: Fix compilation error for clang-3.5 type deduction error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36245/#review90699 --- Ship it! Ship It! - Benjamin Hindman On July 7, 2015, 5:16 a.m.,

Re: Review Request 35981: Added persistent volume user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review90698 --- Patch looks great! Reviews applied: [32982, 35981] All tests passe

  1   2   >