oVirt Jenkins CI Server has posted comments on this change.
Change subject: before/after_update_device hook now receives custom properties
..
Patch Set 3: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit
Assaf Muller has posted comments on this change.
Change subject: before/after_update_device hook now receives custom properties
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/16408
To unsubscribe, visit htt
Assaf Muller has posted comments on this change.
Change subject: before/after_update_device hook now receives custom properties
..
Patch Set 3:
Thanks Dan, very good catch.
--
To view, visit http://gerrit.ovirt.org/16408
To u
Douglas Schilling Landgraf has abandoned this change.
Change subject: vdsmd.init: do not use previous libvirt logrotate
..
Patch Set 1: Abandoned
not required.
--
To view, visit http://gerrit.ovirt.org/16647
To unsubscribe, v
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsmd.init: do not use previous libvirt logrotate
..
vdsmd.init: do not use previous libvirt logrotate
In the past VDSM have been creating /var/log
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: /usr/lib/tmpfiles.d/vdsm.conf
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15707
To unsubscr
Dan Kenigsberg has posted comments on this change.
Change subject: spec: finer-grained libvirt requirement
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15761
To unsubscribe, vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: finer-grained libvirt requirement
..
spec: finer-grained libvirt requirement
Change-Id: I48e25ca9e307c2cde7f29b65c68ff6e122ec8f64
Signed-off-by:
Dan Kenigsberg has posted comments on this change.
Change subject: Rewrite isOvirt function
..
Patch Set 1:
but please note - it would be nice if you rename this function isOvirt ->
isOvirtNode, or something like that.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
..
Patch Set 24: (1 inline comment)
Fi
Dan Kenigsberg has posted comments on this change.
Change subject: Rewrite isOvirt function
..
Patch Set 1: Looks good to me, approved
I did not mind the original implementation, but if everybody finds this one
better - I do n
Dan Kenigsberg has posted comments on this change.
Change subject: Add balloon_min to VM.getVmBalloonInfo
..
Patch Set 17: Looks good to me, approved
Thanks.
--
To view, visit http://gerrit.ovirt.org/15799
To unsubscribe, vis
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add balloon_min to VM.getVmBalloonInfo
..
Add balloon_min to VM.getVmBalloonInfo
The balloon_min key will take its value from memGuaranteedSize
attribu
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool usage: Adding path variable to init script
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16549
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm-tool usage: Adding path variable to init script
..
vdsm-tool usage: Adding path variable to init script
Change-Id: Ia5c07ee9bdc99a5b6d491e2ca2be99
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsmd.init: do not use previous libvirt logrotate
..
vdsmd.init: do not use previous libvirt logrotate
In the past VDSM have been creating /var/log/lib
Dan Kenigsberg has posted comments on this change.
Change subject: vdsmd.init: do not use previous libvirt logrotate
..
Patch Set 3: Looks good to me, approved
Thanks!
--
To view, visit http://gerrit.ovirt.org/16528
To unsubs
Dan Kenigsberg has posted comments on this change.
Change subject: Qos feature: Adds bandwidth definition at configuration level.
..
Patch Set 16: Looks good to me, approved
Simple rebase, copying score.
--
To view, visit htt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Qos feature: Adds bandwidth definition at configuration level.
..
Qos feature: Adds bandwidth definition at configuration level.
Network definition whe
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Qos feature: Adds bandwidth definition at configuration level.
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/
Giuseppe Vallarelli has posted comments on this change.
Change subject: Qos feature: Adds bandwidth definition at configuration level.
..
Patch Set 16:
Please Dan give a final look I had to do another rebase where stuff have be
Giuseppe Vallarelli has posted comments on this change.
Change subject: Qos feature: Adds bandwidth definition at configuration level.
..
Patch Set 16: Verified
Fixing typo in configNetwork qosInboud -> qosInbound.
--
To view
oVirt Jenkins CI Server has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 20:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3276/ : SUCCESS
http://jenkins.ovirt.org
Martin Sivák has posted comments on this change.
Change subject: Add balloon_min to VM.getVmBalloonInfo
..
Patch Set 17: Verified
Verified by starting a VM with 312 guaranteed memory (HA tab in VM/edit) and
checking domxml on
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 19: (2 inline comments)
File vdsm/vm.py
Line 3573: try:
Line 357
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Qos feature: Adds bandwidth definition at configuration level.
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/
Yeela Kaplan has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 19: I would prefer that you didn't submit this
(2 inline comments)
File v
Sandro Bonazzola has posted comments on this change.
Change subject: vdsmd.init: do not use previous libvirt logrotate
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Multiple Gateways[5/2]: Iproute2 handles exceptions
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3274/ : SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Multiple Gateways[4/2]: Fixed ifdown bug for DHCP interfaces
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/327
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Multiple Gateways[3/2]: Re-did comms between dhclient and vdsm
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3
Antoni Segura Puimedon has posted comments on this change.
Change subject: Cleanup the usages of configWriter in configNetwork
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Assaf Muller has uploaded a new change for review.
Change subject: Multiple Gateways[5/2]: Iproute2 handles exceptions
..
Multiple Gateways[5/2]: Iproute2 handles exceptions
Iproute2.configure/removeSourceRoute now don't explode
Dan Kenigsberg has posted comments on this change.
Change subject: Qos feature: Adds bandwidth definition at configuration level.
..
Patch Set 14: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15724
To u
Mark Wu has posted comments on this change.
Change subject: Cleanup the usages of configWriter in configNetwork
..
Patch Set 2: No score
--
To view, visit http://gerrit.ovirt.org/16343
To unsubscribe, visit http://gerrit.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd.init: do not use previous libvirt logrotate
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3271/ : SUCCES
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: automatically unpause vms in EIO when SD becomes
active
..
Patch Set 4: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_ge
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd.init: do not use previous libvirt logrotate
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/16528
To unsubscribe, visit ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rewrite isOvirt function
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3268/ : SUCCESS
http://jenkins.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Cleanup the usages of configWriter in configNetwork
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3269/ : SUCC
Alon Bar-Lev has posted comments on this change.
Change subject: Rewrite isOvirt function
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/16616
To unsubscribe, visit ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool usage: Adding path variable to init script
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3267/ : SUC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
..
Patch Set 12: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerri
Dan Kenigsberg has posted comments on this change.
Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
..
Patch Set 12: Fails
(1 inline comment)
It is important to verify that with the default hidden
Mark Wu has posted comments on this change.
Change subject: Cleanup the usages of configWriter in configNetwork
..
Patch Set 2: Verified; I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/163
Giuseppe Vallarelli has posted comments on this change.
Change subject: Qos feature: Adds bandwidth definition at configuration level.
..
Patch Set 14:
Tested in this way:
Doing:
from vdsm import vdscli
connection = vdscli.con
Giuseppe Vallarelli has posted comments on this change.
Change subject: Qos feature: Adds bandwidth definition at configuration level.
..
Patch Set 14: Verified
--
To view, visit http://gerrit.ovirt.org/15724
To unsubscribe, v
Doron Fediuck has posted comments on this change.
Change subject: API: Add free memory to stats
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/16253
To unsubscribe, vi
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool usage: Adding path variable to init script
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/16549
To unsubscribe, visit http://gerr
Yaniv Bronhaim has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
..
Patch Set 24: (2 inline comments)
F
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Rewrite isOvirt function
..
Rewrite isOvirt function
Change-Id: I943594e8d2cb741f5400c8036b5af9f52ec13b38
Signed-off-by: Yaniv Bronhaim
---
M vdsm/ovirt_funct
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: verbs for managing services
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3264/ : SUCCESS
http://je
Giuseppe Vallarelli has posted comments on this change.
Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
..
Patch Set 11:
Build failure is related to the unhappy pep8 on different modules than the
Timothy Asir has posted comments on this change.
Change subject: gluster: verbs for managing services
..
Patch Set 24: Verified
--
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/sett
Giuseppe Vallarelli has posted comments on this change.
Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
..
Patch Set 11: Verified
Having found some edge cases lately, would be cool if someone else
Timothy Asir has posted comments on this change.
Change subject: gluster: verbs for managing services
..
Patch Set 23: (3 inline comments)
File client/vdsClientGluster.py
Lin
Moti Asayag has posted comments on this change.
Change subject: Remove mac address from host interface statistics
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Since the code is shared between t
Zhou Zheng Sheng has posted comments on this change.
Change subject: spec: restart systemd-modules-load.service on post installation
..
Patch Set 1: (2 inline comments)
Commi
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 17: (7 inline comments)
File vdsm/BindingXMLRPC.py
Line 287: """
Lin
Yaniv Bronhaim has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
..
Patch Set 23: (1 inline comment)
Fi
Dan Kenigsberg has posted comments on this change.
Change subject: vdsmd.init: do not use previous libvirt logrotate
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
minor suggestion
.
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init: Add init adapter
..
Patch Set 4: (1 inline comment)
File vdsm.spec.in
Line 757
Line 758
Line
Dan Kenigsberg has posted comments on this change.
Change subject: Remove mac address from host interface statistics
..
Patch Set 3: (1 inline comment)
File vdsm/sampling.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: restart systemd-modules-load.service on post installation
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init.in: break to pieces
..
Patch Set 9:
Thanks Alon!
I agree on most of your suggestions. I just have 1 different ideas and 1
question.
1. About put
Mark Wu has posted comments on this change.
Change subject: spec: restart systemd-modules-load.service on post installation
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/16610
To unsubscribe, visit http://
Mark Wu has uploaded a new change for review.
Change subject: spec: restart systemd-modules-load.service on post installation
..
spec: restart systemd-modules-load.service on post installation
It's observed that the needed modul
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
..
Patch Set 23:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
..
Patch Set 11: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerri
Giuseppe Vallarelli has posted comments on this change.
Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
..
Patch Set 11:
New fix reason is that bonding_masters should be filtered out and not
cons
Yaniv Bronhaim has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
..
Patch Set 23: (1 inline comment)
Fi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
..
Patch Set 22:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_g
Dan Kenigsberg has posted comments on this change.
Change subject: Decoupling libvirtconnection.py from clientIF.py
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16393
To unsubscribe, vis
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
..
Patch Set 10: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerri
Giuseppe Vallarelli has posted comments on this change.
Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
..
Patch Set 10:
Just covered a corner case where an empty '' pattern is associated to the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add balloon_min to VM.getVmBalloonInfo
..
Patch Set 17:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3258/ : SUCCESS
http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Decoupling libvirtconnection.py from clientIF.py
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3257/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: before/after_update_device hook now receives custom properties
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
..
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
..
Patch Set 9: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 19:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3255/ : SUCCESS
http://jenkins.ovirt.org
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add balloon_min to VM.getVmBalloonInfo
..
Patch Set 16:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3254/ : FAILURE
http://jenk
Moti Asayag has posted comments on this change.
Change subject: Monitor bridges using vdsStats
..
Patch Set 2: Looks good to me, but someone else must approve
Need to verify the proper impact on the engine side: If a required n
Sandro Bonazzola has posted comments on this change.
Change subject: vdsmd.init: do not use previous libvirt logrotate
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/16528
To unsubscribe, visit http://gerri
Moti Asayag has posted comments on this change.
Change subject: Remove mac address from host interface statistics
..
Patch Set 3: (1 inline comment)
File vdsm/sampling.py
Lin
Moti Asayag has posted comments on this change.
Change subject: Remove mac address from host interface statistics
..
Patch Set 3:
I agree with Mark. The engine populate the host's mac address by the
getVdsCaps, either from the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reduce the migration progress timeout
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3253/ : SUCCESS
htt
Vinzenz Feenstra has uploaded a new change for review.
Change subject: vdsm: Reduce the migration progress timeout
..
vdsm: Reduce the migration progress timeout
The progress of the migration should indicate a stuck migration
wa
88 matches
Mail list logo
