ADFFACES 481 Warning and Info icons don't display on PDAs
Hello, The icon component renders a skin specific icon. Each skin implementation exposes a set of customizable icons that can be overridden by a custom skin. Each icon is identified by name. name attribute is a name identifying which icon should be rendered. Valid values depend on the skin-family. Shortcut names exist for .AFRequiredIcon, .AFWarningIcon, .AFInfoIcon, and .AFErrorIcon. They are required, warning, info, and error respectively. For PDAs, warning and info' icons do not display. I have filed a JIRA (ADFFACES-481) in this regard : https://issues.apache.org/jira/browse/ADFFACES-481 and a patch is available. Can the appropriate commiters review and check-in the patch? Take Care, Piyush
Dependencies ?
Hi, When I run junit tests from the command prompt using : java -cp c:\Temp\trinidad-impl\trinidad-impl.jar; c:\Temp\trinidad-impl\trinidad-impl-test.jar; c:\Temp\trinidad-impl\jsf-api.jar; c:\Temp\trinidad-impl\jsf-impl.jar; c:\Temp\trinidad-impl\activation-1.1.jar; c:\Temp\trinidad-impl\commons-beanutils-1.7.0.jar; c:\Temp\trinidad-impl\commons-codec-1.3.jar; c:\Temp\trinidad-impl\commons-collections-3.1.jar; c:\Temp\trinidad-impl\commons-digester-1.6.jar; c:\Temp\trinidad-impl\commons-el-1.0.jar; c:\Temp\trinidad-impl\commons-lang-2.1.jar; c:\Temp\trinidad-impl\commons-logging-1.0.4.jar; c:\Temp\trinidad-impl\jsf-facelets-1.1.11.jar; c:\Temp\trinidad-impl\jstl-1.1.2.jar; c:\Temp\trinidad-impl\mail-1.4.jar; c:\Temp\trinidad-impl\myfaces-api-1.1.5.jar; c:\Temp\trinidad-impl\myfaces-impl-1.1.5.jar; c:\Temp\trinidad-impl\trinidad-api-test.jar; c:\Temp\trinidad-impl\trinidad-api.jar; c:\junit\junit3.8.1\junit.jar junit.swingui.TestRunner org.apache.myfaces.trinidadinternal.renderkit.CoreRenderKitTest I get the following error : Failed to invoke suite():java.lang.NoClassDefFoundError: javax/el/ELException Am I missing a JAR that contains ELException class ? I am using jsf 1.2 JARS for the impl and api. Take Care, Piyush
Re: Dependencies ?
(org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestC
ase$RendererTest)java.lang.IllegalStateException: Trying to attach
RequestContex
t to a thread that already had one. To enable stack traces of each
RequestContex
t attach/release call, enable Level.FINEST logging for the class
org.apache.myfa
ces.trinidad.context.RequestContext
at
org.apache.myfaces.trinidad.context.RequestContext.attach(RequestCont
ext.java:473)
at
org.apache.myfaces.trinidadinternal.renderkit.MRequestContext.init(
MRequestContext.java:47)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseT
est.setUp(RenderKitTestCase.java:156)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseT
est.run(RenderKitTestCase.java:143)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$Rende
rerTest.run(RenderKitTestCase.java:307)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase.run(R
enderKitTestCase.java:92)
5)
table-minimalSaf(org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestC
ase$RendererTest)java.lang.IllegalStateException: Trying to attach
RequestContex
t to a thread that already had one. To enable stack traces of each
RequestContex
t attach/release call, enable Level.FINEST logging for the class
org.apache.myfa
ces.trinidad.context.RequestContext
at
org.apache.myfaces.trinidad.context.RequestContext.attach(RequestCont
ext.java:473)
at
org.apache.myfaces.trinidadinternal.renderkit.MRequestContext.init(
MRequestContext.java:47)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseT
est.setUp(RenderKitTestCase.java:156)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseT
est.run(RenderKitTestCase.java:143)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$Rende
rerTest.run(RenderKitTestCase.java:307)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase.run(R
enderKitTestCase.java:92)
6)
table-minimalScrRdr(org.apache.myfaces.trinidadinternal.renderkit.RenderKitTe
stCase$RendererTest)java.lang.IllegalStateException: Trying to attach
RequestCon
text to a thread that already had one. To enable stack traces of each
RequestCon
text attach/release call, enable Level.FINEST logging for the class
org.apache.m
yfaces.trinidad.context.RequestContext
at
org.apache.myfaces.trinidad.context.RequestContext.attach(RequestCont
ext.java:473)
at
org.apache.myfaces.trinidadinternal.renderkit.MRequestContext.init(
MRequestContext.java:47)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseT
est.setUp(RenderKitTestCase.java:156)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseT
est.run(RenderKitTestCase.java:143)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$Rende
rerTest.run(RenderKitTestCase.java:307)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase.run(R
enderKitTestCase.java:92)
7)
table-minimalInacc(org.apache.myfaces.trinidadinternal.renderkit.RenderKitTes
tCase$RendererTest)java.lang.IllegalStateException: Trying to attach
RequestCont
ext to a thread that already had one. To enable stack traces of each
RequestCont
ext attach/release call, enable Level.FINEST logging for the class
org.apache.my
faces.trinidad.context.RequestContext
at
org.apache.myfaces.trinidad.context.RequestContext.attach(RequestCont
ext.java:473)
at
org.apache.myfaces.trinidadinternal.renderkit.MRequestContext.init(
MRequestContext.java:47)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseT
est.setUp(RenderKitTestCase.java:156)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseT
est.run(RenderKitTestCase.java:143)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$Rende
rerTest.run(RenderKitTestCase.java:307)
at
org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase.run(R
enderKitTestCase.java:92)
FAILURES!!!
Tests run: 64, Failures: 0, Errors: 7
EMMA: runtime coverage data merged into [C:\Temp\coverage\coverage.ec]
{in 32 ms
}
Mike Kienenberger wrote:
You're probably missing el-api.jar and el-ri.jar. You also need to
use either the JSF RI or MyFaces Core jar files, but not both.
On 4/24/07, Piyush Hari [EMAIL PROTECTED] wrote:
Hi,
When I run junit tests from the command prompt using :
java -cp c:\Temp\trinidad-impl\trinidad-impl.jar;
c:\Temp\trinidad-impl\trinidad-impl-test.jar;
c:\Temp\trinidad-impl\jsf-api.jar;
c:\Temp\trinidad-impl\jsf-impl.jar;
c:\Temp\trinidad-impl\activation-1.1.jar;
c:\Temp\trinidad-impl\commons-beanutils-1.7.0.jar;
c:\Temp\trinidad-impl\commons-codec-1.3.jar;
c:\Temp\trinidad-impl\commons-collections-3.1.jar;
c:\Temp\trinidad-impl\commons-digester-1.6.jar;
c:\Temp\trinidad-impl\commons-el-1.0.jar;
c:\Temp\trinidad-impl\commons-lang-2.1.jar;
c
Re: Dependencies ?
Thanks Adam. I changed it to 1.0.4 but it does not seem to solve the problem. Same stacktrace and same exception ( treeTable-minimalSaf(org.apache.myfaces.trinidadinternal.renderkit.RenderKi tTestCase$RendererTest)java.lang.IllegalStateException: Trying to attach Request Context to a thread that already had one. To enable stack traces of each Request Context attach/release call, enable Level.FINEST logging for the class org.apach e.myfaces.trinidad.context.RequestContext -Piyush Adam Winer wrote: I believe our JSF 1.2 code requires Shale Test 1.0.4, not 1.0.3. -- Adam On 4/24/07, Piyush Hari [EMAIL PROTECTED] wrote: Thanks for the reply Mike but this did not solve the problem. I had to include javaee.jar which I got when I installed Java EE 5 SDK on my machine. Also,I removed Myfaces jars and now just use JSF 1.2 Jars now. Thanks for that tip. Then, I had to include a few other JARS like shale-test etc. Now, when I run junit tests from command prompt after copying the necessary testScripts and golden files in the working directory, all the tests fail. Any leads ? Here is the command line followed by the stacktrace : C:\Java\jdk1.5.0_09\bin\java -Dtrinidad.renderkit.fulltests=lenient -Dorg.apache.myfaces.trinidad.ForceGolden=false -Dtrinidad.renderkit.scripts=C:/Temp/coverage/testScripts/ -Dtrinidad.renderkit.golden=C:/Temp/coverage/golden/ -Dtrinidad.renderkit.failures=C:/Temp/coverage/target/test-failures/ -cp c:\Temp\trinidad-impl\trinidad-impl.jar; c:\Temp\trinidad-impl\trinidad-impl-test.jar; c:\Temp\trinidad-impl\jsf-api.jar; c:\Temp\trinidad-impl\jsf-impl.jar; c:\Temp\trinidad-impl\activation-1.1.jar; c:\Temp\trinidad-impl\commons-beanutils-1.7.0.jar; c:\Temp\trinidad-impl\commons-codec-1.3.jar; c:\Temp\trinidad-impl\commons-collections-3.1.jar; c:\Temp\trinidad-impl\commons-digester-1.6.jar;c c:\Temp\trinidad-impl\commons-el-1.0.jar; c:\Temp\trinidad-impl\commons-lang-2.1.jar; c:\Temp\trinidad-impl\commons-logging-1.0.4.jar; c:\Temp\trinidad-impl\jsf-facelets-1.1.11.jar; c:\Temp\trinidad-impl\jstl-1.1.2.jar; c:\Temp\trinidad-impl\mail-1.4.jar; c:\Temp\trinidad-impl\myfaces-api-1.1.5.jar; c:\Temp\trinidad-impl\myfaces-impl-1.1.5.jar; c:\Temp\trinidad-impl\trinidad-api-test.jar; c:\Temp\trinidad-impl\trinidad-api.jar; c:\Temp\trinidad-impl\javaee.jar; c:\Temp\trinidad-impl\shale-test-1.0.3.jar; c:\junit\junit3.8.1\junit.jar; C:\emma-2.0.5312\lib\emma.jar; junit.textui.TestRunner org.apache.myfaces.trinidadinternal.renderkit.CoreRenderKitTest ** stack trace for table.xml golden file ** There were 7 errors: 1) table-minimal(org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase $RendererTest)java.lang.UnsupportedOperationException at javax.faces.context.FacesContext.getELContext(FacesContext.java:136) at javax.faces.component.UIViewRoot.setLocale(UIViewRoot.java:888) at org.apache.myfaces.trinidadinternal.renderkit.RenderKitBootstrap.crea teUIViewRoot(RenderKitBootstrap.java:49) at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseT est.setUp(RenderKitTestCase.java:162) at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseT est.run(RenderKitTestCase.java:143) at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$Rende rerTest.run(RenderKitTestCase.java:307) at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase.run(R enderKitTestCase.java:92) 2) table-minimalIE(org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCa se$RendererTest)java.lang.IllegalStateException: Trying to attach RequestContext to a thread that already had one. To enable stack traces of each RequestContext attach/release call, enable Level.FINEST logging for the class org.apache.myfac es.trinidad.context.RequestContext at org.apache.myfaces.trinidad.context.RequestContext.attach(RequestCont ext.java:473) at org.apache.myfaces.trinidadinternal.renderkit.MRequestContext.init( MRequestContext.java:47) at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseT est.setUp(RenderKitTestCase.java:156) at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$BaseT est.run(RenderKitTestCase.java:143) at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase$Rende rerTest.run(RenderKitTestCase.java:307) at org.apache.myfaces.trinidadinternal.renderkit.RenderKitTestCase.run(R enderKitTestCase.java:92) 3) table-minimalIERtl(org.apache.myfaces.trinidadinternal.renderkit.RenderKitTes tCase$RendererTest)java.lang.IllegalStateException: Trying to attach RequestCont ext to a thread that already had one. To enable stack traces of each RequestCont ext attach/release call, enable Level.FINEST logging for the class org.apache.my faces.trinidad.context.RequestContext at org.apache.myfaces.trinidad.context.RequestContext.attach(RequestCont ext.java:473
message and messageType in tr:message component
Hello, I am trying to use 'message' and 'messageType' attribute on a tr:message component. According to the trinidad documentation at : http://incubator.apache.org/adffaces/trinidad-api/tagdoc/tr_message.html these attributes are defined as follows: - message : The error, warning, or informational text. - messageType : The type of the message; acceptable values are error, warning, info, and none. Defaults to none. My code is: tr:message for=foo messageType=error message=This is an error message/ tr:inputText id=foo simple=true label=BigInteger field f:converter converterId=javax.faces.BigInteger/ /tr:inputText tr:commandButton id=message text=Submit/ I expect that after the user enters a NON-NUMBER (like foo) in the inputText, the error should display in the message component as This is an error message(message) with an error icon (because messageType=error). However, this does not happen. The first time I open a page, the message text (This is an error message) is already written. When I click submit after entering foo in the inputText, the message remains on screen and no error icon appears. Am I missing something obvious in the code ? I will greatly appreciate any response. Regards, Piyush
Remove maximumLength attribute from inputDate ?
Qiang, I am wondering where we are with this fix ? Are you planning to remove maximumLength attribute from inputDate any sooner ? Regards, -Piyush - Original Message - From: Gabrielle Crawford [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Monday, November 20, 2006 4:33 PM Subject: Re: Remove maximumLength attribute from inputDate +1. The converter understands strings of a certain format. Anything longer or shorter will give an error. I can't see how maximumLength is useful on inputDate. Thanks, Gab Qiang Fan wrote: Hi! InputDate component has an maximumLength attribute that specifies the maximum number of characters that can be entered into the edit field. Unlike inputText, inputDate will always have a converter (if the page does not specify, it has its default converter). Since the converter in inputDate can already ensure the maximum length of the string entered, the maximumLength attribute is not necessary. It should be removed from the API. Thanks. John Fan
Re: Remove maximumLength attribute from inputDate
you'l have to provide a patch file at that Jira once you are done with removing it.That will be reviewed by the commiters and included in the code. -Piyush - Original Message - From: Qiang Fan [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Wednesday, November 22, 2006 10:27 AM Subject: Re: Remove maximumLength attribute from inputDate An issue has already been opened in jira. The key number is ADFFACES-300http://issues.apache.org/jira/browse/ADFFACES-300. Is there any thing else I need to do? Thanks. John On 11/20/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: same here. can you open a ticket on jira for that? On 11/21/06, Gabrielle Crawford [EMAIL PROTECTED] wrote: +1. The converter understands strings of a certain format. Anything longer or shorter will give an error. I can't see how maximumLength is useful on inputDate. Thanks, Gab Qiang Fan wrote: Hi! InputDate component has an maximumLength attribute that specifies the maximum number of characters that can be entered into the edit field. Unlike inputText, inputDate will always have a converter (if the page does not specify, it has its default converter). Since the converter in inputDate can already ensure the maximum length of the string entered, the maximumLength attribute is not necessary. It should be removed from the API. Thanks. John Fan -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
Fw: Custom Skins for Different Form Factors
Resending it.. Please let know your opinion regarding adding @import support in Trinidad for importing skins (see below). thanks, Piyush - Original Message - From: Piyush Hari [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Wednesday, November 15, 2006 4:05 PM Subject: Re: Custom Skins for Different Form Factors Hello, I would like to revive the issue with creating custom PDA skins(see emails below). I propose adding the @import support so that a user can create plus-pda skin by extending the simple-pda and importing the plus-Desktop skin. please read the emails below and let me know what you think about this. I will create a JIRA for the same. Take Care, Piyush - Original Message - From: Jeanne Waldman [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Wednesday, August 23, 2006 1:44 PM Subject: Re: Custom Skins for Different Form Factors Hi Joey, We have simple-desktop and simple-pda skins. You can create a pda or desktop skin by specifying the render-kit-id in your skin. The pda skin extends simple-pda skin. The desktop skin extends simple-desktop. You created a plus-desktop skin that extends simple-desktop skin. You like that skin a lot and it has a lot of definitions. Now you need a pda version. You want to use the plus-desktop skin, but you want it to extend simple-pda instead. If you make your plus-pda skin extend plus-desktop skin, it will go through simple-desktop. (you've verified this, right?) You don't want that. You want your plus-pda skin to extend plus-desktop skin, but then you want that to go through simple-pda instead of simple-desktop. I've thought about this some and I think we need a concept of a render-kit-neutral skin. This skin, if picked, will default to extend simple-desktop. But if this skin is used as a base skin for plus-pda, it will eventually extend from simple-pda (the simple skin with the same render-kit-it). Another option is to allow imports in the skinning .css file. So you can import the stylesheet definitions. We have this feature in XSS, which is why you see simple-pda.xss imports simple-desktop.xss. I like the 'abstract' skin idea better. Resource bundles aren't a part of the css file, and you might want to inherit those, too. I don't know how hard/easy it is to implement these ideas. One question, how much will need to change if you forget extending simple-pda, and have your plus-pda skin extend plus-desktop which extends simple-desktop? If it is just a few fonts, then it might easy enough to go that route until we have something in place. Joseph Rozier wrote: Hello, The current method of skin inheritance leads to some issues when a developer wishes to create a skin family targetting desktop and PDA. There's no way to make a large number of changes that affect both desktop and pda in one place, and then tweak what needs to be tweaked for desktop or PDA. For example, I may want to change the color in both desktop and PDA, but I might want to change the font size to 20 for the desktop and 6 for the PDA. The reason for the problem is that each skin can only extend Trinidad's simple skin. There is no way to have an abstract plus skin that makes the common changes, and then have a plus-desktop skin and plus-pda skin that makes desktop/pda specific changes. (Also note that today things are a bit odder, because there's a simple-pda.xss that extends simple-desktop.xss. If I specify a skin in trinidad-skins.xml that is for use with the desktop RenderKit, its css inherits from simple-desktop.xss. If I instead specify its use for the pda RenderKit, its css inherits from simple-pda.xss. However, this doesn't lead to a solution because my plus.css may override a font that is specified in simple-desktop.xss or simple-pda.xss, so that font would now be used on both desktop and pda.) I'm hoping that the skinning experts can provide insights/solutions to this problem. Thanks, Joey
commandButton with icon on PDAs
Hello, commandButton with icon on PDAs displays only the IMAGE and not the inline text. In desktop, an image with an inline text can be displayed within a button. On PDAs, a commandButton gets rendered as in input HTML element as follow : jspx: af:commandButton text=Go to Component Guide page immediate=true icon=../../images/uplevel.gif action=guide/ rendered html: input type=image onclick=submitForm script src=../../images/uplevel.gif text=Go to Component Guide page For desktops : rendered html: button id=demoTemplate:_id12 class=x6j onclick=return false; img class=xrt src=../../images/uplevel.gif /button Button tag is not supported on PDA browsers. So, do we say that on PDAs either of a text or an image can be rendered but not both ?? -Piyush
-adfinternal-supportsDisabledOptions
Anyone knows what this capabiliy means for a browser ? capability name=-adfinternal-supportsDisabledOptions value=false/ -Piyush
Re: Custom Skins for Different Form Factors
Hello, I would like to revive the issue with creating custom PDA skins(see emails below). I propose adding the @import support so that a user can create plus-pda skin by extending the simple-pda and importing the plus-Desktop skin. please read the emails below and let me know what you think about this. I will create a JIRA for the same. Take Care, Piyush - Original Message - From: Jeanne Waldman [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Wednesday, August 23, 2006 1:44 PM Subject: Re: Custom Skins for Different Form Factors Hi Joey, We have simple-desktop and simple-pda skins. You can create a pda or desktop skin by specifying the render-kit-id in your skin. The pda skin extends simple-pda skin. The desktop skin extends simple-desktop. You created a plus-desktop skin that extends simple-desktop skin. You like that skin a lot and it has a lot of definitions. Now you need a pda version. You want to use the plus-desktop skin, but you want it to extend simple-pda instead. If you make your plus-pda skin extend plus-desktop skin, it will go through simple-desktop. (you've verified this, right?) You don't want that. You want your plus-pda skin to extend plus-desktop skin, but then you want that to go through simple-pda instead of simple-desktop. I've thought about this some and I think we need a concept of a render-kit-neutral skin. This skin, if picked, will default to extend simple-desktop. But if this skin is used as a base skin for plus-pda, it will eventually extend from simple-pda (the simple skin with the same render-kit-it). Another option is to allow imports in the skinning .css file. So you can import the stylesheet definitions. We have this feature in XSS, which is why you see simple-pda.xss imports simple-desktop.xss. I like the 'abstract' skin idea better. Resource bundles aren't a part of the css file, and you might want to inherit those, too. I don't know how hard/easy it is to implement these ideas. One question, how much will need to change if you forget extending simple-pda, and have your plus-pda skin extend plus-desktop which extends simple-desktop? If it is just a few fonts, then it might easy enough to go that route until we have something in place. Joseph Rozier wrote: Hello, The current method of skin inheritance leads to some issues when a developer wishes to create a skin family targetting desktop and PDA. There's no way to make a large number of changes that affect both desktop and pda in one place, and then tweak what needs to be tweaked for desktop or PDA. For example, I may want to change the color in both desktop and PDA, but I might want to change the font size to 20 for the desktop and 6 for the PDA. The reason for the problem is that each skin can only extend Trinidad's simple skin. There is no way to have an abstract plus skin that makes the common changes, and then have a plus-desktop skin and plus-pda skin that makes desktop/pda specific changes. (Also note that today things are a bit odder, because there's a simple-pda.xss that extends simple-desktop.xss. If I specify a skin in trinidad-skins.xml that is for use with the desktop RenderKit, its css inherits from simple-desktop.xss. If I instead specify its use for the pda RenderKit, its css inherits from simple-pda.xss. However, this doesn't lead to a solution because my plus.css may override a font that is specified in simple-desktop.xss or simple-pda.xss, so that font would now be used on both desktop and pda.) I'm hoping that the skinning experts can provide insights/solutions to this problem. Thanks, Joey
Re: Re: valueChangeListener of a selectBooleanCheckbox
Hi Adam,
Please note that valueChangeListener is called when it is UNCHECKED
and not called when it is CHECKED (reverse of what you wrote). This
happens consistently provided my bean is in SESSION scope.
-Piyush
On 11/10/06, Adam Winer [EMAIL PROTECTED] wrote:
Is it consistently that you don't get it when it's
unchecked, but do get it when it's checked?
-- Adam
On 11/9/06, Piyush Hari [EMAIL PROTECTED] wrote:
I am using Sun's implementation of JSF here and not MyFaces, if that makes
any difference ?
-Piyush
- Original Message -
From: Piyush Hari [EMAIL PROTECTED]
To: adffaces-dev@incubator.apache.org
Sent: Thursday, November 09, 2006 2:25 PM
Subject: valueChangeListener of a selectBooleanCheckbox
I run into a problem where my checkbox seems to lose its
ValueChangeListener on a mobile browser like Pocket IE, IE Mobile.
Here is what I have on my JSF page:
tr:form
tr:panelGroupLayout
tr:selectBooleanCheckbox text=selectBooleanCheckbox 1
label=Label 1
valueChangeListener=#{bean.valueChange}
id=check1
autoSubmit=true
/
/tr:form
I have a backing bean 'Bean' in 'session' scope that looks like this:
public class Bean {
public Bean() {}
public void valueChange(ValueChangeEvent valueChangeEvent) {
// Add event code here...
System.out.println(valueChange event is being called !);
}
}
When the page first comes up, I click on the checkbox. I DON'T see the
message valueChange event is being called. But when
I click again, the same ValueChangeListener gets invoked and displays the
message valueChange event is being called.
Does anybody know what I did wrong?
BTW, this works fine on Desktop applications. I am wondering why it does
not for mobile browsers. Does valueChangeListener for a checkBox has a
dependence on the type of Browser ?
Re: Re: Re: valueChangeListener of a selectBooleanCheckbox
Upon checking a check Box, getSubmittedValue() does not get called. Upon
unchecking it does get called.
HTTP request differs in t.o the attribute check1 (check1 being the
user-assigned ID of the checkBox). It does not get passed upon unchecking.
It gets passed with a value 't' upon checking.
Upon checking:
check1=t
org.apache.myfaces.trinidad.faces.FORM=_id1
org.apache.myfaces.trinidad.faces.STATE=%2138234b14
source=check1
event=check1
partialTargets=
partial=true
Upon Unchecking:
org.apache.myfaces.trinidad.faces.FORM=_id1
org.apache.myfaces.trinidad.faces.STATE=%2138234b14
source=check1
event=check1
partialTargets=
partial=true
I am investigating this further but if you have any suggestions, let me
know. Kindly note that Desktop browsers have the same HTTP requests and it
works there.
-Piyush
On 11/10/06, Adam Winer [EMAIL PROTECTED] wrote:
Puzzling. I'd suggest you have a look at what HTTP parameters
are getting sent, and what the Renderer's getSubmittedValue()
method returns.
-- Adam
On 11/10/06, piyush hari [EMAIL PROTECTED] wrote:
Hi Adam,
Please note that valueChangeListener is called when it is UNCHECKED
and not called when it is CHECKED (reverse of what you wrote). This
happens consistently provided my bean is in SESSION scope.
-Piyush
On 11/10/06, Adam Winer [EMAIL PROTECTED] wrote:
Is it consistently that you don't get it when it's
unchecked, but do get it when it's checked?
-- Adam
On 11/9/06, Piyush Hari [EMAIL PROTECTED] wrote:
I am using Sun's implementation of JSF here and not MyFaces, if that
makes
any difference ?
-Piyush
- Original Message -
From: Piyush Hari [EMAIL PROTECTED]
To: adffaces-dev@incubator.apache.org
Sent: Thursday, November 09, 2006 2:25 PM
Subject: valueChangeListener of a selectBooleanCheckbox
I run into a problem where my checkbox seems to lose its
ValueChangeListener on a mobile browser like Pocket IE, IE Mobile.
Here is what I have on my JSF page:
tr:form
tr:panelGroupLayout
tr:selectBooleanCheckbox text=selectBooleanCheckbox 1
label=Label 1
valueChangeListener=#{bean.valueChange}
id=check1
autoSubmit=true
/
/tr:form
I have a backing bean 'Bean' in 'session' scope that looks like
this:
public class Bean {
public Bean() {}
public void valueChange(ValueChangeEvent valueChangeEvent) {
// Add event code here...
System.out.println(valueChange event is being called !);
}
}
When the page first comes up, I click on the checkbox. I DON'T see
the
message valueChange event is being called. But when
I click again, the same ValueChangeListener gets invoked and
displays the
message valueChange event is being called.
Does anybody know what I did wrong?
BTW, this works fine on Desktop applications. I am wondering why
it does
not for mobile browsers. Does valueChangeListener for a checkBox
has a
dependence on the type of Browser ?
Re: Re: Re: Re: valueChangeListener of a selectBooleanCheckbox
When I remove the code that would submit the value each time it is checked (check1=t) from the Core.js , the valueChangeListener gets called properly. But, this is obviously not the right thing to do since the user might need to submit a value. -Piyush - Original Message - From: Adam Winer [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Friday, November 10, 2006 4:15 PM Subject: Re: Re: Re: Re: valueChangeListener of a selectBooleanCheckbox On 11/10/06, piyush hari [EMAIL PROTECTED] wrote: Upon checking a check Box, getSubmittedValue() does not get called. Upon unchecking it does get called. That should be investigated. HTTP request differs in t.o the attribute check1 (check1 being the user-assigned ID of the checkBox). It does not get passed upon unchecking. It gets passed with a value 't' upon checking. Upon checking: check1=t org.apache.myfaces.trinidad.faces.FORM=_id1 org.apache.myfaces.trinidad.faces.STATE=%2138234b14 source=check1 event=check1 partialTargets= partial=true Upon Unchecking: org.apache.myfaces.trinidad.faces.FORM=_id1 org.apache.myfaces.trinidad.faces.STATE=%2138234b14 source=check1 event=check1 partialTargets= partial=true Those look fine. -- Adam
Re: Re: Re: Re: valueChangeListener of a selectBooleanCheckbox
I dug up the mountain and found this mouse: There was a typo while building request string: do you see it ? else if (element.type == checkbox element.checked == true) datatosend += ( element.name + = + escape(element.value) + ); No...? Look at the space after '' and before the closing brackets :-) -Piyush - Original Message - From: Piyush Hari [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Friday, November 10, 2006 4:26 PM Subject: Re: Re: Re: Re: valueChangeListener of a selectBooleanCheckbox When I remove the code that would submit the value each time it is checked (check1=t) from the Core.js , the valueChangeListener gets called properly. But, this is obviously not the right thing to do since the user might need to submit a value. -Piyush - Original Message - From: Adam Winer [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Friday, November 10, 2006 4:15 PM Subject: Re: Re: Re: Re: valueChangeListener of a selectBooleanCheckbox On 11/10/06, piyush hari [EMAIL PROTECTED] wrote: Upon checking a check Box, getSubmittedValue() does not get called. Upon unchecking it does get called. That should be investigated. HTTP request differs in t.o the attribute check1 (check1 being the user-assigned ID of the checkBox). It does not get passed upon unchecking. It gets passed with a value 't' upon checking. Upon checking: check1=t org.apache.myfaces.trinidad.faces.FORM=_id1 org.apache.myfaces.trinidad.faces.STATE=%2138234b14 source=check1 event=check1 partialTargets= partial=true Upon Unchecking: org.apache.myfaces.trinidad.faces.FORM=_id1 org.apache.myfaces.trinidad.faces.STATE=%2138234b14 source=check1 event=check1 partialTargets= partial=true Those look fine. -- Adam
Re: Re: Re: Re: valueChangeListener of a selectBooleanCheckbox
quote () not brackets is what I meant :) (again a typo) -Piyush - Original Message - From: Piyush Hari [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Friday, November 10, 2006 5:40 PM Subject: Re: Re: Re: Re: valueChangeListener of a selectBooleanCheckbox I dug up the mountain and found this mouse: There was a typo while building request string: do you see it ? else if (element.type == checkbox element.checked == true) datatosend += ( element.name + = + escape(element.value) + ); No...? Look at the space after '' and before the closing brackets :-) -Piyush - Original Message - From: Piyush Hari [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Friday, November 10, 2006 4:26 PM Subject: Re: Re: Re: Re: valueChangeListener of a selectBooleanCheckbox When I remove the code that would submit the value each time it is checked (check1=t) from the Core.js , the valueChangeListener gets called properly. But, this is obviously not the right thing to do since the user might need to submit a value. -Piyush - Original Message - From: Adam Winer [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Friday, November 10, 2006 4:15 PM Subject: Re: Re: Re: Re: valueChangeListener of a selectBooleanCheckbox On 11/10/06, piyush hari [EMAIL PROTECTED] wrote: Upon checking a check Box, getSubmittedValue() does not get called. Upon unchecking it does get called. That should be investigated. HTTP request differs in t.o the attribute check1 (check1 being the user-assigned ID of the checkBox). It does not get passed upon unchecking. It gets passed with a value 't' upon checking. Upon checking: check1=t org.apache.myfaces.trinidad.faces.FORM=_id1 org.apache.myfaces.trinidad.faces.STATE=%2138234b14 source=check1 event=check1 partialTargets= partial=true Upon Unchecking: org.apache.myfaces.trinidad.faces.FORM=_id1 org.apache.myfaces.trinidad.faces.STATE=%2138234b14 source=check1 event=check1 partialTargets= partial=true Those look fine. -- Adam
valueChangeListener of a selectBooleanCheckbox
I run into a problem where my checkbox seems to lose its ValueChangeListener
on a mobile browser like Pocket IE, IE Mobile.
Here is what I have on my JSF page:
tr:form
tr:panelGroupLayout
tr:selectBooleanCheckbox text=selectBooleanCheckbox 1
label=Label 1
valueChangeListener=#{bean.valueChange}
id=check1
autoSubmit=true
/
/tr:form
I have a backing bean 'Bean' in 'session' scope that looks like this:
public class Bean {
public Bean() {}
public void valueChange(ValueChangeEvent valueChangeEvent) {
// Add event code here...
System.out.println(valueChange event is being called !);
}
}
When the page first comes up, I click on the checkbox. I DON'T see the
message valueChange event is being called. But when
I click again, the same ValueChangeListener gets invoked and displays the
message valueChange event is being called.
Does anybody know what I did wrong?
BTW, this works fine on Desktop applications. I am wondering why it does not
for mobile browsers. Does valueChangeListener for a checkBox has a
dependence on the type of Browser ?
Re: valueChangeListener of a selectBooleanCheckbox
I am using Sun's implementation of JSF here and not MyFaces, if that makes
any difference ?
-Piyush
- Original Message -
From: Piyush Hari [EMAIL PROTECTED]
To: adffaces-dev@incubator.apache.org
Sent: Thursday, November 09, 2006 2:25 PM
Subject: valueChangeListener of a selectBooleanCheckbox
I run into a problem where my checkbox seems to lose its
ValueChangeListener on a mobile browser like Pocket IE, IE Mobile.
Here is what I have on my JSF page:
tr:form
tr:panelGroupLayout
tr:selectBooleanCheckbox text=selectBooleanCheckbox 1
label=Label 1
valueChangeListener=#{bean.valueChange}
id=check1
autoSubmit=true
/
/tr:form
I have a backing bean 'Bean' in 'session' scope that looks like this:
public class Bean {
public Bean() {}
public void valueChange(ValueChangeEvent valueChangeEvent) {
// Add event code here...
System.out.println(valueChange event is being called !);
}
}
When the page first comes up, I click on the checkbox. I DON'T see the
message valueChange event is being called. But when
I click again, the same ValueChangeListener gets invoked and displays the
message valueChange event is being called.
Does anybody know what I did wrong?
BTW, this works fine on Desktop applications. I am wondering why it does
not for mobile browsers. Does valueChangeListener for a checkBox has a
dependence on the type of Browser ?
[Bug] Re: panelAccordion
I am sending this again . Please respond if you are facing similar issue or/and have solution/suggestions. Note : To test this bug, deploy trinidad-demo WAR file in your server and open showOneAccordion.jspx or showManyAccordion.jspx. You will have to click refresh after every click on the showDetailItem child to display its content. -Piyush - Original Message - From: Piyush Hari [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Friday, November 03, 2006 5:06 PM Subject: panelAccordion Hello, When I click on a showDetailItem child of a panelAccordion, showDetailItem children do not show up. On Refreshing the page they do. Is this a known issue ? I am observing this in all the browsers I tested - IE 7, Firefox - 1.5, Pocket IE, IE Mobile. My JSPX has : tr:panelAccordion discloseNone=true tr:showDetailItem text=Item1 tr:outputText value=output1/ /tr:showDetailItem tr:showDetailItem text=Item2 tr:outputText value=output2/ /tr:showDetailItem tr:showDetailItem text=Item3 tr:outputText value=output3/ /tr:showDetailItem /tr:panelAccordion -Piyush
panelAccordion
Hello, When I click on a showDetailItem child of a panelAccordion, showDetailItem children do not show up. On Refreshing the page they do. Is this a known issue ? I am observing this in all the browsers I tested - IE 7, Firefox - 1.5, Pocket IE, IE Mobile. My JSPX has : tr:panelAccordion discloseNone=true tr:showDetailItem text=Item1 tr:outputText value=output1/ /tr:showDetailItem tr:showDetailItem text=Item2 tr:outputText value=output2/ /tr:showDetailItem tr:showDetailItem text=Item3 tr:outputText value=output3/ /tr:showDetailItem /tr:panelAccordion -Piyush
goButton on a PDA
Hello, At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag : String element = useButtonTag ? button : a; I wonder why a link is renderered when browsers that don't support 'button' tag *CAN* support 'input' tag of type 'Button'. Shall I change this to input type ? -Piyush
Re: goButton on a PDA
no I meant : INPUT TYPE=BUTTON; VALUE=link button ONCLICK=window.location.href='http://www.computerhope.com' It works for all the PDA browsers I currently plan to support namely: Pocket IE, IE Mobile and BlackBerry. -Piyush On 10/27/06, Gabrielle Crawford [EMAIL PROTECTED] wrote: Do you mean something like this: a href=http://www.oracle.com;input type=button value=hi/input/a My recollection is that putting a link around a button didn't work in some pda's. I think since the time that was written the pda's have come a long way. If it works I say go for it. Thanks, Gabrielle Piyush Hari wrote: Hello, At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag : String element = useButtonTag ? button : a; I wonder why a link is renderered when browsers that don't support 'button' tag *CAN* support 'input' tag of type 'Button'. Shall I change this to input type ? -Piyush
Re: goButton on a PDA
no I meant : INPUT TYPE=BUTTON; VALUE=link button ONCLICK=window.location.href='http://www.computerhope.com' It works for all the PDA browsers I currently plan to support namely: Pocket IE, IE Mobile and BlackBerry. -Piyush - Original Message - From: Gabrielle Crawford [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Friday, October 27, 2006 5:37 PM Subject: Re: goButton on a PDA Do you mean something like this: a href=http://www.oracle.com;input type=button value=hi/input/a My recollection is that putting a link around a button didn't work in some pda's. I think since the time that was written the pda's have come a long way. If it works I say go for it. Thanks, Gabrielle Piyush Hari wrote: Hello, At present the following logic in GoButtonRenderer renders a goButton as a LINK (html 'a' tag) on PDAs because they don't support button tag : String element = useButtonTag ? button : a; I wonder why a link is renderered when browsers that don't support 'button' tag *CAN* support 'input' tag of type 'Button'. Shall I change this to input type ? -Piyush
trinidad build taking time
My trinidad build is taking a lot of time. It seems to get stuck here for a while. Anyone else, facing the same delay ? Is this related to the scheduled downtime ? [INFO] snapshot org.apache.myfaces.trinidadbuild:maven-faces-plugin:incubator-m1 -SNAPSHOT: checking for updates from people.apache-mirror [WARNING] repository metadata for: 'snapshot org.apache.myfaces.trinidadbuild:ma ven-faces-plugin:incubator-m1-SNAPSHOT' could not be retrieved from repository: people.apache-mirror due to an error: Error transferring file [INFO] Repository 'people.apache-mirror' will be blacklisted -Piyush
How do I tell which Renderer-class to use ?
I am creating a new rendering-class for NavigationPane for PDAs. How do I tell trinidad to use this instead of the existing class for rendering a NavigationPane on a PDA ? -Piyush
Re: How do I tell which Renderer-class to use ?
Thanks. I figured it out. You have to add the renderer in PdaRenderKit.java with the following parameters : (component family,render-type,renderer) To identify component family, render-Type corresponding to a component, you can see faces-Config.xml Thanks, -Piyush - Original Message - From: Matthias Wessendorf [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Wednesday, October 18, 2006 12:01 PM Subject: Re: How do I tell which Renderer-class to use ? I see navigationpane only in faces_major at least there is a pda render kit class which adds some renderes. take a look at that On 10/18/06, Piyush Hari [EMAIL PROTECTED] wrote: I am creating a new rendering-class for NavigationPane for PDAs. How do I tell trinidad to use this instead of the existing class for rendering a NavigationPane on a PDA ? -Piyush -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
Build Error - test failure
Hello, To fix a commandButton ,presently not rendering on a Pocket IE or IE Mobile browser, I changed the following agent capability in pocketie.xml from 'true' to 'false' capability name=-adfinternal-advancedForms value=false/ When I built with tests OFF, it worked fine - button displayed and fully functional. When I built it with tests ON, it gave me test failures. I copy-pasted the test failure files into the golden directory and built again. Again, it gave me test failures. Any leads on this ? How do I determine what is going wrong ? Here is the stack trace : [INFO] - --- [ERROR] BUILD ERROR [INFO] - --- [INFO] There are test failures. [INFO] - --- [INFO] Trace org.apache.maven.lifecycle.LifecycleExecutionException: There are test failures. at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:556) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:472) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:451) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:303) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:270) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:139) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:322) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:115) at org.apache.maven.cli.MavenCli.main(MavenCli.java:249) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) at org.codehaus.classworlds.Launcher.main(Launcher.java:375) Caused by: org.apache.maven.plugin.MojoExecutionException: There are test failures. at org.apache.maven.test.SurefirePlugin.execute(SurefirePlugin.java:389) at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:415) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:531) ... 16 more [INFO] - Regards, Piyush
Re: Build Error - test failure
I did mvn clean but it did not do any good. -Piyush - Original Message - From: Jeanne Waldman [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Tuesday, October 17, 2006 7:12 PM Subject: Re: Build Error - test failure I don't know, but I'd try doing a 'mvn clean' first. Did you do this? What were the golden file diffs? Maybe that will give a clue. Piyush Hari wrote: Hello, To fix a commandButton ,presently not rendering on a Pocket IE or IE Mobile browser, I changed the following agent capability in pocketie.xml from 'true' to 'false' capability name=-adfinternal-advancedForms value=false/ When I built with tests OFF, it worked fine - button displayed and fully functional. When I built it with tests ON, it gave me test failures. I copy-pasted the test failure files into the golden directory and built again. Again, it gave me test failures. Any leads on this ? How do I determine what is going wrong ? Here is the stack trace : [INFO] - --- [ERROR] BUILD ERROR [INFO] - --- [INFO] There are test failures. [INFO] - --- [INFO] Trace org.apache.maven.lifecycle.LifecycleExecutionException: There are test failures. at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:556) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:472) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:451) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:303) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:270) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:139) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:322) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:115) at org.apache.maven.cli.MavenCli.main(MavenCli.java:249) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) at org.codehaus.classworlds.Launcher.main(Launcher.java:375) Caused by: org.apache.maven.plugin.MojoExecutionException: There are test failures. at org.apache.maven.test.SurefirePlugin.execute(SurefirePlugin.java:389) at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:415) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:531) ... 16 more [INFO] - Regards, Piyush
Re: Build Error - test failure
surefire plugin is containing. changed something in the (j)unit test(s) ? What do you mean by this ? try to skip the test ... (just for the case ) I did. Skipping tests works fine. But, I want to do the tests as I am submitting the patch for an issue that should include test changes too. On 10/17/06, Piyush Hari [EMAIL PROTECTED] wrote: I did mvn clean but it did not do any good. -Piyush - Original Message - From: Jeanne Waldman [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Tuesday, October 17, 2006 7:12 PM Subject: Re: Build Error - test failure I don't know, but I'd try doing a 'mvn clean' first. Did you do this? What were the golden file diffs? Maybe that will give a clue. Piyush Hari wrote: Hello, To fix a commandButton ,presently not rendering on a Pocket IE or IE Mobile browser, I changed the following agent capability in pocketie.xml from 'true' to 'false' capability name=-adfinternal-advancedForms value=false/ When I built with tests OFF, it worked fine - button displayed and fully functional. When I built it with tests ON, it gave me test failures. I copy-pasted the test failure files into the golden directory and built again. Again, it gave me test failures. Any leads on this ? How do I determine what is going wrong ? Here is the stack trace : [INFO] - --- [ERROR] BUILD ERROR [INFO] - --- [INFO] There are test failures. [INFO] - --- [INFO] Trace org.apache.maven.lifecycle.LifecycleExecutionException: There are test failures. at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:556) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:472) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:451) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:303) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:270) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:139) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:322) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:115) at org.apache.maven.cli.MavenCli.main(MavenCli.java:249) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) at org.codehaus.classworlds.Launcher.main(Launcher.java:375) Caused by: org.apache.maven.plugin.MojoExecutionException: There are test failures. at org.apache.maven.test.SurefirePlugin.execute(SurefirePlugin.java:389) at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:415) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:531) ... 16 more [INFO] - Regards, Piyush -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
Re: Build Error - test failure
Thanks Mathias. surefire-reports under -impl provided me the key. href was being added twice for a goButton tag when rendered as an input HTML element. Thanks, -Piyush - Original Message - From: Matthias Wessendorf [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Tuesday, October 17, 2006 7:54 PM Subject: Re: Build Error - test failure in the -impl there is a target folder surefire reports test failer some folder like that may contain more infos On 10/17/06, Piyush Hari [EMAIL PROTECTED] wrote: I did not change any test. I guess my change causes some error in the tests already in place. Is there a way to detect that ? -Piyush - Original Message - From: Matthias Wessendorf [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Tuesday, October 17, 2006 7:40 PM Subject: Re: Build Error - test failure What do you mean by this ? did you change the unit test? or the change cause some *error* in your tests. that was a hint to focus on the test side of life :) -M -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
[Proposal] update unsupported-agent tag for PDA
Hello, The unsupported-agent tag generated in faces-config.xml indicates which agents DON'T support the component.This information isn't used at runtime--rather, it's a hint to JDeveloper which components to show/hide in the component palette you can drag and drop from. For example, chooseColor has an unsupported-agent that includes pda. So , chooseColor will not appear in Jdev when building a PDA app. We have to make sure to update the unsupported-agent values in Trinidad to reflect our current state. Therefore, I propose updating the unsupported-agent tags in Trinidad for PDAs. Regards, Piyush Hari
{Proposal] fix navigationPane layout on a PDA
Hello, The navigationPane component creates a series of navigation items representing one level in a navigation hierarchy. These items may either be added as children or a menu model may be bound to the navigationPane component. Currently, on a PDA, navigationItem in a tabs , bar and button mode does not display properly. Childern and separators get rendered in a new line and that occupies a lot of real screen estate and at the same time, is confusing to the user. I plan to fix this. I will go ahead and set up the JIRA for the same. Take Care, -Piyush
[Proposal] fix showDetail component with prompt facet on a PDA
Hello, The showDetail provides a means of toggling a group of components between being disclosed or undisclosed. On a desktop, it shows up as linked hide/show icon followed by a linked disclosed/undisclosed Text. If the prompt facet is present, this will be used instead of the disclosedText and undisclosedText attributes. On a PDA, it shows up as a linked disclosed/undisclosed Text only. There is no icon.Since the prompt facet can be anything, we need to add a linked icon (like the desktop) to enable user to toggle. I propose to fix this. I will go ahead and create a JIRA for this. Regards, Piyush
[Proposal] show separator icon and render last child for breadCrumbs on a PDA
Hello, A breadCrumbs component is used in hierarchical site layouts to indicate the path back to the root page of the hierarchy with links. A child representing the current page should be the last child. This child may or may not be rendered depending on variables like the device type or look and feel, but it should always be added. Currently, links of a breadCrumbs do not have a separator on a PDA. Therefore, they look untidy. I propose to fix this. Moreover, for PDAs, last item (current page link) is not rendered. It does not occupy a lot of screen estate. So, I will render this too. Let me know what you feel about this. I will go ahead and create the JIRA. Take Care, Piyush
[Proposal] enable indentation when panelHeaders are nested on PDA
Hello, A nested panelHeader (panelHeader within a panelHeader) is indented by 5 px spaces on a desktop. However, on a PDA it is not. I propose to fix this disparity by indenting a nested panelHeader. I will go ahead and create a JIRA for this. Take Care, Piyush Hari
[Proposal] display Error Message Icon on a PDA
Hello, When a validation error occurs on an input field, for ex : 'value not entered' when 'required' attribute is set to 'true' on an inputText, messages are rendered alongwith a Icon that is specific to the type of message (For ex : one icon for ERROR, one icon for INFORMATION). This appears fine on a Desktop. On a PDA, the error icon is missing, however, the message text does get rendered as in a desktop. Therefore, I propose displaying an Error Message Icon on a PDA. I will go ahead a create a JIRA for this. Take Care, -Piyush
messages component on PDAs
Hello, I have two questions regarding PDA renderers for messages component. 1) Can we make one common renderer for PDA and Desktop for a messages component ? Desktop and PDAs have different renderers for a messages component. They are both located in org-apache-myfacestrinidadinternal-ui-laf-base-pda/desktop-MessageboxRenderer.java With current trinidad code, on a desktop, the demo-app renders a message box that displays messageType (like Error) and the message (Label : Conversion Error) in the following format: (see desktop_messages.JPG) OnPocket PCs (PIE and IE mobile)PDA message box is not rendered and it displays nothing. I did not understand why in the first place we need a different renderer for PDAs ? So, I tried something different. I copied the contents of DESKTOP MessageBoxRenderer.java into the PDA MessageBoxRenderer.java of a PDA. And it worked !!! PDA displays errors in the desired format. Everything appears same as desktop exceptthe skin and the absence of Error Icon (X) on left of Label which I think are skinning issues. (see pda_messages.JSPX) 2) Since, limited screen size is a handicap on a PDA device, it does not make sense to show messages that are specific to a component (in this case an inputText) withintr:messages component (Label : Conversion Error)as well as below the component they belong to. (ex: Specified value is not a val). In that case, shall I alter the PDA renderer from 1)to exclude any messages being added to the messages component if they are specific to a component? Sincerely, Piyush Hari
Re: [Proposal] fix 'panelAccordion' component for non PPR enabled browsers like BlackBerry
Hi Matt, I tested with 'discloseNone=true'. It does not work. However, it seems I have discovered the bug. In CorePanelAccordionRenderer.java, for non-ppr browsers, submitForm() is called with argument event='show' hardcoded. This really should be event='event' (where event is the current 'show'/'hide' event).It worked fine after this patch. I will go ahead and make the patch available. Thanks, Piyush - Original Message - From: Matt Cooper [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Tuesday, September 26, 2006 4:37 PM Subject: Re: [Proposal] fix 'panelAccordion' component for non PPR enabled browsers like BlackBerry Hi Piyush, Can you try specifying discloseNone=true on the panelAccordion tag? Thanks, Matt On 9/26/06, piyush hari [EMAIL PROTECTED] wrote: Hello, The panelAccordion control can be used to display a group of contents belonging to a showDetailItem. Accordion bar(s) with panels representing showDetailItem children is displayed. The panel for the showDetailItem that is selected to be shown is shown as expanded and contents of selected showDetailItem is displayed. If none of the showDetailItem children are selected, the first showDetailItem that is enabled is considered to be selected. This component works fine for browsers that support Partial Page Rendering (PPR) like IE,Pocket IE,IE Mobile and Mozilla Firefox. However, it does not work for browsers that don't support partial page rendering. For ex: On Blackberry 4.0 , Clicking a showDetailItem child, shows the content, but clicking it again does not hide the content. Therefore, I propose to 'fix' this component for PPR-disabled browsers like BlackBerry 4.0 Let me know if you have any comments on this. I will go ahead and set up a JIRA for it. Thanks, Piyush Hari
Re: Pending PDA Patches
Hey Joey, I just realised that I had submitted patches for panelradio and panelChoice which had dependencies on other issues being commited. I cancelled those patches after I read Jeanne's and your e-mails. Thanks, Piyush - Original Message - From: Joseph Rozier [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Thursday, September 21, 2006 6:52 PM Subject: Re: Pending PDA Patches On 9/21/06, Jeanne Waldman [EMAIL PROTECTED] wrote: Hi Joey, I haven't had time to respond. I don't know what the dependency method should be. Your suggestion: Is it acceptable to locally apply the earlier patch that has not yet been committed and, in effect, include that patch in a new patch? I think this is acceptable, because I don't think this new patch would get reviewed until the first patch that it depends on gets checked in. So then when we review the second patch, the differences won't be the differences of both patches, just the second patch. Okay, that's the approach Piyush has been using, and documenting in the patch what other patches it is including. It could be an issue if the earlier patch is rejected or modified in some way, so we are trying to limit the dependencies to relatively independent patches. (Though that sounds oxymoronic, I suppose.) Take care, Joey - Jeanne Joseph Rozier wrote: Hello, I'm resending this since there was no response to the first one... I'd particularly appreciate a response to what the desired way to handle patch dependencies is, when one patch is dependent on another patch that has not yet been committed. (The review/committing of the outstanding PDA patches would be appreciated as well. :)) Thanks, Joey On 9/13/06, Joseph Rozier [EMAIL PROTECTED] wrote: Hello, The following two JIRAs have patches waiting to be reviewed/committed. https://issues.apache.org/jira/browse/ADFFACES-167 Add 'autoSubmit' support for basic input components on PDAs https://issues.apache.org/jira/browse/ADFFACES-110 Add Agent for BlackBerry Browser 4.0 (this has a fix to the original patch) Would it be possible to get these two patches committed? We have fixes for two other JIRAs (ADFFACES-172 and -173) ready to go, but they have dependencies on these patches. Also, for the future, what is the protocol for submitting patches that have dependencies on earlier patches that have not yet been committed. Is it acceptable to locally apply the earlier patch that has not yet been committed and, in effect, include that patch in a new patch? I can see how that would make patch reviewing a headache, but we're running into the issue where a lot of the PDA patches have dependences on earlier patches and it typically takes several days to get even minor changes reviewed and committed. Thanks, Joey
[Proposal] fix 'panelChoice' component for PDAs
Hello, The panelChoice control is used to display a group of contents belonging to a showDetailItem. A choice control with each individual option representing a showDetailItem child is displayed. An option within choice control corresponding to showDetailItem that is disclosed is shown as selected and contents of selected showDetailItem is displayed. If none of the showDetailItem children are selected, the first showDetailItem that is enabled is considered to be selected. This attribute is currently not supported on PDAs. Although it displays on a PDA, selecting any choices does not perorm an action. However, it works fine for desktop applications. Thus, I propose fixing panelChoice component in trinidad for PDAs. Let me know what you think about this. I will go ahead and set a JIRA if none of you have any objections. Regards, Piyush Hari
Re: [Proposal] fix 'panelTabbed' component on PDAs
By 'fixing' these components I meant to support their basic functionality. For ex: panelTabbed component does not submit the form on clicking on a PDA. This should be corrected. LF for these components corresponding to screen sizes are not bad either. I have been seing them on PIE, IE Mobile and BB and components rendered on a PDA are pretty understandable to the end user. -Piyush - Original Message - From: Adam Winer [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Saturday, September 16, 2006 11:10 PM Subject: Re: [Proposal] fix 'panelTabbed' component on PDAs It'd be great to have a working component here on PDAs. I wonder, how are you planning on fixing it? What'll the component look like, esp. with limited screen real estate? -- Adam On 9/16/06, piyush hari [EMAIL PROTECTED] wrote: Hello, The panelTabbed control can be used to display a group of contents that belongs to a showDetailItem that is shown. Tab bar(s) with tabs representing the showDetailItem children is displayed. The tab for the showDetailItem that is selected to be shown is highlighted and contents from the selected showDetailItem is displayed. If none of the showDetailItem children are selected, the first showDetailItem that is enabled is considered to be selected. This component is currently not supported on PDAs but works fine for desktop applications. Thus, I propose fixing panelTabbed component in trinidad for PDAs. Let me know what you think about this. I will go ahead and set a JIRA if none of you have objections. Regards, Piyush Hari
[Proposal] fix 'panelTabbed' component on PDAs
Hello, The panelTabbed control can be used to display a group of contents that belongs to a showDetailItem that is shown. Tab bar(s) with tabs representing the showDetailItem children is displayed. The tab for the showDetailItem that is selected to be shown is highlighted and contents from the selected showDetailItem is displayed. If none of the showDetailItem children are selected, the first showDetailItem that is enabled is considered to be selected. This component is currently not supported on PDAs but works fine for desktop applications. Thus, I propose fixing panelTabbed component in trinidad for PDAs. Let me know what you think about this. I will go ahead and set a JIRA if none of you have objections. Regards, Piyush Hari
[Proposal] fix 'defaultCommand' attribute for 'form' component for PDAs
Hello, 'defaultCommand' attribute on a 'form' component repreents the id attribute of the command button whose action would be invoked by default for 'form' submit on hitting enter on any of the input fields of the form. This attribute is currently not supported on PDAs but works fine for desktop applications. Thus, I propose fixing defaultCommand functionality for the 'form' component in trinidad for PDAs. Let me know what you think about this. I will go ahead and set a JIRA if none of you have any objections. Regards, Piyush Hari
[bug] Components of type 'select' do not get expected response on 'autoSubmit' on a PDA device
ello,
on autoSubmit a value in a select component (like selectOneChoice), ambiguous
data ('undefined') appears within XmlHTTP request string. On investigation, I
found that this was due to non-initialization of variable in Core.js.
var selectData=;
instead of
var selectData;
I will go ahead and file it as a bug and submit the patch.
-Piyush
Re: AW: [Proposal] 'initialFocusId' attribute support for document component on PDA]
Hi Thorsten ! I am e currently focusing on getting PDA functionality to match that of desktop within a tight project plan constraints, so I won't be able to look into the Facelets include issue atleast until the completion of the project. Thanks for pointing it out though. Take Care, Piyush Original Message Subject: AW: [Proposal] 'initialFocusId' attribute support for document component on PDA Date: Mon, 11 Sep 2006 08:53:54 +0200 From: Günther, Thorsten [EMAIL PROTECTED] Reply-To: adffaces-dev@incubator.apache.org To: adffaces-dev@incubator.apache.org Hi Piyush! There is another issue with the initialFocusId: When using Facelets and having tr:document in the template, focus on a field included from another xhtml page does not work as far as I can tell. Could this issue be addressed too in this effort? Thank you, Thorsten -Ursprüngliche Nachricht- Von: Piyush Hari [mailto:[EMAIL PROTECTED] Gesendet: Montag, 11. September 2006 04:59 An: adffaces-dev@incubator.apache.org Betreff: [Proposal] 'initialFocusId' attribute support for document component on PDA Hello, 'initialFocusId' attribute on a 'document' component represents the id of the component to which you want the focus to be when the full page renders. The accessibility-mode must be set to inaccessible for this feature to be on. This attribute is currently not supported on PDAs but works fine for desktop applications. Thus, I propose fixing initialFocusId functionality for the 'document' component in trinidad. Let me know what you think about this. I will go ahead and set a JIRA if none of you have objections. Regards, Piyush Hari
[Proposal] 'autoSubmit' support for basic input components on PDAs
Hello, 'autoSubmit' on the following basic trinidad components do not work when the device is a PDA. (grouped by browser): IE Mobile/Pocket IE - inputText inputListOfValues selectBooleanCheckbox selectBooleanRadio selectManyCheckbox selectManyListbox slectOneChoice selectOneListbox selectOneRadio BlackBerry 4.0+ selectBooleanRadio Thus, I would like to create a proposal for fixing autoSubmit functionality for the trinidad components mentioned above. Let me know what you think about this. I will go ahead and set a JIRA if none of you have objections. Regards, Piyush Hari
Re: trinidad build error
Thorsten, Thanks for the advice. But it did not work. Any other leeds ? Thanks, Piyush - Original Message - From: Günther, Thorsten [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Sunday, August 27, 2006 11:52 PM Subject: AW: trinidad build error Hi! I get such errors frequently. Simply run it again. It will restart where it failed. Perhaps it fails again retrieving a package but most probably not on the same. Regards, Thorsten -Ursprüngliche Nachricht- Von: Piyush Hari [mailto:[EMAIL PROTECTED] Gesendet: Montag, 28. August 2006 08:03 An: adffaces-dev@incubator.apache.org Betreff: trinidad build error I get the following error while after building trinidad. Is anyone of you getting it ? If so, any help will be appreciated. I did a checkout. Then mvn install on plugins (that worked fine). mvn install on trinidad throws the following error. Thanks, Piyush [ERROR] BUILD ERROR [INFO] - --- [INFO] Error building POM (may not be this project's POM). Project ID: org.apache:apache Reason: Error getting POM for 'org.apache:apache' from the repository: Error tra nsferring file org.apache:apache:pom:2 from the specified remote repositories: central (http://repo1.maven.org/maven2), central-mirror (http://stacy27.us.oracle.com/mirrors/www.ibiblio.org/maven2), java.net (https://maven-repository.dev.java.net/nonav/repository), java-net (https://maven-repository.dev.java.net/nonav/repository/), apache.snapshots (http://people.apache.org/maven-snapshot-repository), people.apache-mirror (http://stacy27.us.oracle.com/mirrors/people.apache.org/m aven-snapshot-repository), central-corporate-legacy (http://bali.us.oracle.com:2020/maven), central-corporate (http://stacy27.us.oracle.com/maven2), snapshots-corporate (http://stacy27.us.oracle.com/maven2-snapshots)
Re: RE skins with ADF-Faces
Thanks , but my faces-cofig.xml does contain these tags. I think this is
more of a file not found error. I place the skins/beach/beach.css within
Web-inf directory of my project . When i deploy, it does get included in the
WEB-INF directory of my application but the server throws a file not found
error.
SEVERE: Could not load style sheet: skins/purple/purpleSkin.css
java.io.FileNotFoundException: Unable to locate style sheet
skins/purple/purple
Skin.css in local styles directory
(C:\JDEVADF_MAIN.JM5_NT_060715.2210.3986\j2e
e\home\application-deployments\column\column\temp\adf\styles), or in context
root
(C:\JDEVADF_MAIN.JM5_NT_060715.2210.3986\j2ee\home\applications\column\column\
), or on the class path.
My application name is column.(context root). Also, I am not sure why it
looks for the skins in temp/adf/styles instead of looking for it in root ?
- Original Message -
From: [EMAIL PROTECTED]
To: adffaces-dev@incubator.apache.org
Sent: Wednesday, July 26, 2006 6:18 AM
Subject: RE skins with ADF-Faces
Can you verify that also in the faces-config.xml
The following is present
application
default-render-kit-idorg.apache.myfaces.adf.core/default-render-kit-id
/application
Also in the web.xml file, you should have something similar to this:
filter
filter-nameadfFaces/filter-name
filter-classorg.apache.myfaces.adf.webapp.AdfFacesFilter/filter-class
/filter
filter-mapping
filter-nameadfFaces/filter-name
servlet-namefaces/servlet-name
/filter-mapping
servlet
servlet-namefaces/servlet-name
servlet-classjavax.faces.webapp.FacesServlet/servlet-class
/servlet
servlet
servlet-nameresources/servlet-name
servlet-classorg.apache.myfaces.adf.webapp.ResourceServlet/servlet-class
/servlet
servlet-mapping
servlet-namefaces/servlet-name
url-pattern/faces/*/url-pattern
/servlet-mapping
servlet-mapping
servlet-nameresources/servlet-name
url-pattern/adf/*/url-pattern
/servlet-mapping
I remembered having trouble too when wanting to add a skin for tests pages
I was doing, and as far as I remembered, that was something I did near the
end to correct the problem.
Piyush Hari [EMAIL PROTECTED] a écrit sur 2006-07-26 02:28:27 :
I want to use a custom skin for the adf components.
Based on adf-faces-demo, this is what I did:
1) copy the skin files to the WEB-INF dir of the project
WEB-INF/skins/beach
WEB-INF/skins/purple
2)create an adf-faces-skins.xml
?xml version=1.0 encoding=ISO-8859-1?
skins xmlns=http://myfaces.apache.org/adf/view/faces/skin;
skin
id
purple.desktop
/id
family
purple
/family
render-kit-id
org.apache.myfaces.adf.desktop
/render-kit-id
style-sheet-name
skins/purple/purpleSkin.css
/style-sheet-name
bundle-name
org.apache.myfaces.adfdemo.resource.SkinBundle
/bundle-name
/skin
skin
id
beach.desktop
/id
family
beach
/family
render-kit-id
org.apache.myfaces.adf.desktop
/render-kit-id
style-sheet-name
skins/beach/beach.css
/style-sheet-name
/skin
/skins
3) create an adf-faces-config.xml with the following skin family tag
skin-familybeach/skin-family
When I run my app on desktop, it does not display my app in the beach
skin.
However, in the source it does refer to beach skin as
link rel=stylesheet charset=UTF-8 type=text/css
href=/tests-column-context-root/adf/styles/cache/beach-desktop-
${version}-en-gecko.cssAny
pointers to the solution of this problem ? -Piyush
PPR if PIE
PPR does not seem to work with Pocket IE. I am trying to figure out the issue. On debugging, I noticed that the partial targets (listening components) do not get sent in the request.Where does PPR partial targets for a Pocket Internet Explorer get included in the request. -Piyush
