[cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Patrick Gansterer]

Hi,

I've created a very simple patch to add the basic support for WindowsCE to 
CMake.
I does not provide any automatically architecture detection or so on, but 
enables user to use a vanilla CMake for compiling Windows CE projects.
If the patch gets accepted I'll write a few lines into the wiki.

- Patrick



0001-Added-very-basic-Windows-CE-Makefile-support.patch
Description: Binary data
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Brad King]

On 11/12/2011 4:18 PM, Patrick Gansterer wrote:

I've created a very simple patch to add the basic support for WindowsCE to 
CMake.
I does not provide any automatically architecture detection or so on, but 
enables user to use a vanilla CMake for compiling Windows CE projects.
If the patch gets accepted I'll write a few lines into the wiki.


Thanks for working on this.  The patch looks okay to me as it will not affect
current behavior.

Please change the variable "CMAKE_PLATFORM_DEFINES" to a private name (leading
_ perhaps) that does not appear to be something projects can use.

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Alexander Neundorf]

On Saturday 12 November 2011, Patrick Gansterer wrote:
> Hi,
> 
> I've created a very simple patch to add the basic support for WindowsCE to
> CMake. I does not provide any automatically architecture detection or so
> on, but enables user to use a vanilla CMake for compiling Windows CE
> projects. If the patch gets accepted I'll write a few lines into the wiki.
> 
> - Patrick

Looks ok from my side. I'm not sure it's complete.
It hardcodes the ARM architecture.
WinCE supports more than that, right ?
But maybe ARM covers most users, I don't know.

In one of the tickets below there is a patch which tries to detect the 
architecture and was not applied because of the way it tried to do this.

Should we considers the people which reported and commented on those bugs:
http://public.kitware.com/Bug/view.php?id=8486
http://public.kitware.com/Bug/view.php?id=8102
http://public.kitware.com/Bug/view.php?id=7919

They include patches, which are also in use by them.

Alex
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Patrick Gansterer]

Hi,

at first: Sorry for the very long delay.

On Mon, 14 Nov 2011 21:12:24 +0100, Alexander Neundorf wrote:

On Saturday 12 November 2011, Patrick Gansterer wrote:

Hi,

I've created a very simple patch to add the basic support for 
WindowsCE to
CMake. I does not provide any automatically architecture detection 
or so

on, but enables user to use a vanilla CMake for compiling Windows CE
projects. If the patch gets accepted I'll write a few lines into the 
wiki.


Looks ok from my side. I'm not sure it's complete.
It hardcodes the ARM architecture.
WinCE supports more than that, right ?
But maybe ARM covers most users, I don't know.

In one of the tickets below there is a patch which tries to detect 
the
architecture and was not applied because of the way it tried to do 
this.


Should we considers the people which reported and commented on those 
bugs:

http://public.kitware.com/Bug/view.php?id=8486
http://public.kitware.com/Bug/view.php?id=8102
http://public.kitware.com/Bug/view.php?id=7919

They include patches, which are also in use by them.


I know of of the other patches and my work is based on them (see als 
https://gitorious.org/~paroga/cmake/parogas-cmake).
But since there is not much progress on the mentioned bugs, I'll try to 
upstream my solution in small reviewable patches.


-- Patrick
From 4579b8be19c0afae66a78691b705b7fcb8d6a935 Mon Sep 17 00:00:00 2001
From: Patrick Gansterer 
Date: Sat, 14 Jul 2012 07:12:23 +0200
Subject: [PATCH] Added very basic Windows CE Makefile support

This patch enables CMake to create Makefiles targeting
Windows CE devices.
CMake needs to be run within an cross compile command prompt
and requires a toolchain file which sets CMAKE_SYSTEM_NAME
to "WindowsCE" and CMAKE_SYSTEM_PROCESSOR to the target
machine architecture (e.g. THUMB).
---
 Modules/Platform/Windows-cl.cmake   |   29 ++---
 Modules/Platform/WindowsCE-cl.cmake |   13 +
 Modules/Platform/WindowsCE.cmake|1 +
 3 files changed, 36 insertions(+), 7 deletions(-)
 create mode 100644 Modules/Platform/WindowsCE-cl.cmake
 create mode 100644 Modules/Platform/WindowsCE.cmake

diff --git a/Modules/Platform/Windows-cl.cmake 
b/Modules/Platform/Windows-cl.cmake
index be6abb6..691ac78 100644
--- a/Modules/Platform/Windows-cl.cmake
+++ b/Modules/Platform/Windows-cl.cmake
@@ -7,8 +7,13 @@ SET(WIN32 1)
 
 INCLUDE(Platform/cl)
 
-SET(CMAKE_CREATE_WIN32_EXE /subsystem:windows)
-SET(CMAKE_CREATE_CONSOLE_EXE /subsystem:console)
+IF(CMAKE_SYSTEM_NAME MATCHES "WindowsCE")
+  SET(CMAKE_CREATE_WIN32_EXE "/subsystem:windowsce /entry:WinMainCRTStartup")
+  SET(CMAKE_CREATE_CONSOLE_EXE "/subsystem:windowsce /entry:mainACRTStartup")
+ELSE(CMAKE_SYSTEM_NAME MATCHES "WindowsCE")
+  SET(CMAKE_CREATE_WIN32_EXE "/subsystem:windows")
+  SET(CMAKE_CREATE_CONSOLE_EXE "/subsystem:console")
+ENDIF(CMAKE_SYSTEM_NAME MATCHES "WindowsCE")
 
 IF(CMAKE_GENERATOR MATCHES "Visual Studio 6")
SET (CMAKE_NO_BUILD_TYPE 1)
@@ -152,18 +157,28 @@ IF(MSVC_VERSION GREATER 1310)
   SET(CMAKE_CXX_LINK_EXECUTABLE " -E vs_link_exe 
${CMAKE_CXX_LINK_EXECUTABLE}")
   SET(CMAKE_C_LINK_EXECUTABLE " -E vs_link_exe 
${CMAKE_C_LINK_EXECUTABLE}")
 
+  IF(CMAKE_SYSTEM_NAME MATCHES "WindowsCE")
+STRING(TOUPPER ${MSVC_ARCHITECTURE_FAMILY} MSVC_ARCHITECTURE_FAMILY_UPPER)
+SET(CMAKE_PLATFORM_DEFINES "/D_WIN32_WCE=0x500 /DUNDER_CE 
/D${MSVC_ARCHITECTURE_FAMILY} /D_${MSVC_ARCHITECTURE_FAMILY_UPPER}_")
+SET(CMAKE_C_STANDARD_LIBRARIES_INIT "coredll.lib corelibc.lib ole32.lib 
oleaut32.lib uuid.lib commctrl.lib ")
+SET(CMAKE_EXE_LINKER_FLAGS_INIT "${CMAKE_EXE_LINKER_FLAGS_INIT} 
/NODEFAULTLIB:oldnames.lib")
+  ELSE(CMAKE_SYSTEM_NAME MATCHES "WindowsCE")
+SET(CMAKE_PLATFORM_DEFINES "/DWIN32")
+SET(CMAKE_DEBUG_PLATFORM_DEFINES "/RTC1")
+SET(CMAKE_C_STANDARD_LIBRARIES_INIT "kernel32.lib user32.lib gdi32.lib 
winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib 
advapi32.lib ")
+  ENDIF(CMAKE_SYSTEM_NAME MATCHES "WindowsCE")
+
   SET(CMAKE_BUILD_TYPE_INIT Debug)
-  SET (CMAKE_CXX_FLAGS_INIT "/DWIN32 /D_WINDOWS /W3 /Zm1000 /EHsc /GR")
-  SET (CMAKE_CXX_FLAGS_DEBUG_INIT "/D_DEBUG /MDd /Zi /Ob0 /Od /RTC1")
+  SET (CMAKE_CXX_FLAGS_INIT "${CMAKE_PLATFORM_DEFINES} /D_WINDOWS /W3 /Zm1000 
/EHsc /GR")
+  SET (CMAKE_CXX_FLAGS_DEBUG_INIT "${CMAKE_DEBUG_PLATFORM_DEFINES} /D_DEBUG 
/MDd /Zi /Ob0 /Od")
   SET (CMAKE_CXX_FLAGS_MINSIZEREL_INIT "/MD /O1 /Ob1 /D NDEBUG")
   SET (CMAKE_CXX_FLAGS_RELEASE_INIT "/MD /O2 /Ob2 /D NDEBUG")
   SET (CMAKE_CXX_FLAGS_RELWITHDEBINFO_INIT "/MD /Zi /O2 /Ob1 /D NDEBUG")
-  SET (CMAKE_C_FLAGS_INIT "/DWIN32 /D_WINDOWS /W3 /Zm1000")
-  SET (CMAKE_C_FLAGS_DEBUG_INIT "/D_DEBUG /MDd /Zi  /Ob0 /Od /RTC1")
+  SET (CMAKE_C_FLAGS_INIT "${CMAKE_PLATFORM_DEFINES} /D_WINDOWS /W3 /Zm1000")
+  SET (CMAKE_C_FLAGS_DEBUG_INIT "${CMAKE_DEBUG_PLATFORM_DEFINES} /D_DEBUG /MDd 
/Zi  /Ob0 /Od")
   SET (CMAKE_C_FLAGS_MINSIZEREL_INIT "/MD /O1 /Ob1 /D NDEBUG")
   SET (CMAKE_C_FLAGS_RELEASE_INIT "/MD 

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Rolf Eike Beer]

Patrick Gansterer wrote:
> Hi,
> 
> at first: Sorry for the very long delay.

I do not really care for this, but just some minor stylistic nitpicks:

-in Modules/Platform/Windows-cl.cmake you initialize some variables in both 
branches of an if(). You should keep the order you set them the same in both 
branches as is makes comparing this much easier.

-you don't set CMAKE_DEBUG_PLATFORM_DEFINES for WinCE. I don't know if that is 
a bug or intentional. If it is a bug then set it, otherwise I would add a 
comment why this isn't needed.

Eike
-- 

signature.asc
Description: This is a digitally signed message part.
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Patrick Gansterer]

Hi,

On Sat, 14 Jul 2012 21:08:24 +0200, Rolf Eike Beer wrote:
-in Modules/Platform/Windows-cl.cmake you initialize some variables 
in both
branches of an if(). You should keep the order you set them the same 
in both

branches as is makes comparing this much easier.


Where exactly? I don't find it. :-/


-you don't set CMAKE_DEBUG_PLATFORM_DEFINES for WinCE. I don't know
if that is
a bug or intentional. If it is a bug then set it, otherwise I would 
add a

comment why this isn't needed.


The WinCE compier has no support for /RTC1.

This patch also includes the changes mentioned in 
http://public.kitware.com/pipermail/cmake-developers/2011-November/002510.html.


-- Patrick
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[David Cole]

On Sat, Jul 14, 2012 at 3:30 PM, Patrick Gansterer wrote:

> Hi,
>
>
> On Sat, 14 Jul 2012 21:08:24 +0200, Rolf Eike Beer wrote:
>
>> -in Modules/Platform/Windows-cl.**cmake you initialize some variables in
>> both
>> branches of an if(). You should keep the order you set them the same in
>> both
>> branches as is makes comparing this much easier.
>>
>
> Where exactly? I don't find it. :-/
>
>
>  -you don't set CMAKE_DEBUG_PLATFORM_DEFINES for WinCE. I don't know
>> if that is
>> a bug or intentional. If it is a bug then set it, otherwise I would add a
>> comment why this isn't needed.
>>
>
> The WinCE compier has no support for /RTC1.
>
> This patch also includes the changes mentioned in
> http://public.kitware.com/**pipermail/cmake-developers/**
> 2011-November/002510.html
> .
>
> -- Patrick
>
> --
>
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/**
> opensource/opensource.html
>
> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/**CMake_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/cgi-**bin/mailman/listinfo/cmake-**developers
>


Patrick,

Thanks for your work on this. I'll review this stuff on Monday or Tuesday
and apply the patches and merge to next if all looks well.

Part of the problem I've always had with "other platform" support on
Windows or Visual Studio is that we have literally ZERO dashboard coverage
of these platforms.

Is there any way you (or somebody else who cares about these platforms) can
set up a CMake dashboard to test the platform and to make sure that it
submits nightly so that if we change something surrounding this code, we
have a chance at catching unintended breakages *before* we make a CMake
release?

This thread, or one like it, probably deserves a cc to the users list as
well to see if somebody there can submit such dashboards. From the activity
in mantis, it does seem to be a popular issue. Lots of folks will be glad
to see stuff like this go in.


Thanks,
David
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Rolf Eike Beer]

Patrick Gansterer wrote:
> Hi,
> 
> On Sat, 14 Jul 2012 21:08:24 +0200, Rolf Eike Beer wrote:
> > -in Modules/Platform/Windows-cl.cmake you initialize some variables
> > in both
> > branches of an if(). You should keep the order you set them the same
> > in both
> > branches as is makes comparing this much easier.
> 
> Where exactly? I don't find it. :-/

Directly before that:

> > -you don't set CMAKE_DEBUG_PLATFORM_DEFINES for WinCE. I don't know
> > if that is
> > a bug or intentional. If it is a bug then set it, otherwise I would
> > add a
> > comment why this isn't needed.
> 
> The WinCE compier has no support for /RTC1.

But you don't add any of the other things you set for release configuration 
either, that's what wonders me.

Eike
-- 

signature.asc
Description: This is a digitally signed message part.
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Patrick Gansterer]

Hi,

Am 14.07.2012 um 22:08 schrieb David Cole:

> On Sat, Jul 14, 2012 at 3:30 PM, Patrick Gansterer  wrote:
> Hi,
> 
> 
> On Sat, 14 Jul 2012 21:08:24 +0200, Rolf Eike Beer wrote:
> -in Modules/Platform/Windows-cl.cmake you initialize some variables in both
> branches of an if(). You should keep the order you set them the same in both
> branches as is makes comparing this much easier.
> 
> Where exactly? I don't find it. :-/
> 
> 
> -you don't set CMAKE_DEBUG_PLATFORM_DEFINES for WinCE. I don't know
> if that is
> a bug or intentional. If it is a bug then set it, otherwise I would add a
> comment why this isn't needed.
> 
> The WinCE compier has no support for /RTC1.
> 
> This patch also includes the changes mentioned in 
> http://public.kitware.com/pipermail/cmake-developers/2011-November/002510.html.
> 
> -- Patrick
> 
> --
> 
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at 
> http://www.kitware.com/opensource/opensource.html
> 
> Please keep messages on-topic and check the CMake FAQ at: 
> http://www.cmake.org/Wiki/CMake_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
> 
> 
> Patrick,
> 
> Thanks for your work on this. I'll review this stuff on Monday or Tuesday and 
> apply the patches and merge to next if all looks well.
> 
> Part of the problem I've always had with "other platform" support on Windows 
> or Visual Studio is that we have literally ZERO dashboard coverage of these 
> platforms.
> 
> Is there any way you (or somebody else who cares about these platforms) can 
> set up a CMake dashboard to test the platform and to make sure that it 
> submits nightly so that if we change something surrounding this code, we have 
> a chance at catching unintended breakages *before* we make a CMake release?

I'll have a look at it and try to set something up.

> 
> This thread, or one like it, probably deserves a cc to the users list as well 
> to see if somebody there can submit such dashboards. From the activity in 
> mantis, it does seem to be a popular issue. Lots of folks will be glad to see 
> stuff like this go in.

-- Patrick

--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[David Cole]

On Sat, Jul 21, 2012 at 8:16 AM, Patrick Gansterer  wrote:
> Hi,
>
>
> On Sat, 21 Jul 2012 08:08:43 -0400, David Cole wrote:
>>
>> Do you have a local branch that has all 6 patches one on top of the other?
>>
>>
>> On Sat, Jul 21, 2012 at 7:49 AM, Patrick Gansterer 
>> wrote:
>>>
>>> Hi,
>>>
>>>
>>> On Sat, 21 Jul 2012 07:44:33 -0400, David Cole wrote:


 What branch did you base these on?

 They don't apply cleanly on top of master today.
>>>
>>>
>>>
>>> If I made no mistake the basic revision was the master branch of last
>>> weekend:
>>> 21b45ce16f88172eac3386f002fe112014053a36
>>>
>>> -- Patrick
>
>
> I pushed it as "ce" to https://gitorious.org/~paroga/cmake/parogas-cmake
> (git://gitorious.org/~paroga/cmake/parogas-cmake.git)
>
> BTW: Are there any plans to use gerrit for CMake too?
>
> -- Patrick


(cc'ing the CMake Developers list back in...)


OK, finally got it. Whew. Sometimes I could throw git straight out the window...

It merges to 'next' cleanly, and builds ok on my machine with Visual
Studio 9, but then one test fails... Looks like MSVC71 is somehow
getting defined for my msvc 9 build:


C:\...>ctest -j 8 -C Release --output-on-failure -R
CheckCompilerRelatedVariables


Test project C:/Users/davidcole/Dashboards/My Tests/CMake Win32-vs9-Release
Start 128: CheckCompilerRelatedVariables
1/1 Test #128: CheckCompilerRelatedVariables ***Failed0.07 sec
Internal cmake changing into directory:
C:/Users/davidcole/Dashboards/My Tests/CMake
Win32-vs9-Release/Tests/CheckCompilerRelatedVariables
Error: cmake execution failed
MSVC='1' is defined
MSVC60='' is NOT defined
MSVC70='' is NOT defined
MSVC71='1' is defined
MSVC80='' is NOT defined
MSVC90='1' is defined
MSVC10='' is NOT defined
MSVC11='' is NOT defined
CMake Error at CMakeLists.txt:61 (message):
  error: 2 MSVC** variables are defined -- exactly 1 expected


Configuring
Configuring incomplete, errors occurred!



0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.20 sec

The following tests FAILED:
128 - CheckCompilerRelatedVariables (Failed)
Errors while running CTest


I'll continue following up on this on Monday, (looking more closely at
the changes and trying to fix the failing test if you don't beat me to
it) -- but for now I have some other deadlines I have to meet.

Did you make any progress towards setting up a dashboard for this,
that demonstrates actually building some WinCE stuff with a toolchain
file?


Thanks,
David
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Patrick Gansterer]

Hi,

On Sat, 21 Jul 2012 09:30:58 -0400, David Cole wrote:
On Sat, Jul 21, 2012 at 8:16 AM, Patrick Gansterer 
 wrote:

Hi,


On Sat, 21 Jul 2012 08:08:43 -0400, David Cole wrote:


Do you have a local branch that has all 6 patches one on top of the 
other?



On Sat, Jul 21, 2012 at 7:49 AM, Patrick Gansterer 


wrote:


Hi,


On Sat, 21 Jul 2012 07:44:33 -0400, David Cole wrote:



What branch did you base these on?

They don't apply cleanly on top of master today.




If I made no mistake the basic revision was the master branch of 
last

weekend:
21b45ce16f88172eac3386f002fe112014053a36

-- Patrick



I pushed it as "ce" to 
https://gitorious.org/~paroga/cmake/parogas-cmake

(git://gitorious.org/~paroga/cmake/parogas-cmake.git)

BTW: Are there any plans to use gerrit for CMake too?

-- Patrick



(cc'ing the CMake Developers list back in...)


OK, finally got it. Whew. Sometimes I could throw git straight out
the window...

It merges to 'next' cleanly, and builds ok on my machine with Visual
Studio 9, but then one test fails... Looks like MSVC71 is somehow
getting defined for my msvc 9 build:
...
I'll continue following up on this on Monday, (looking more closely 
at
the changes and trying to fix the failing test if you don't beat me 
to

it) -- but for now I have some other deadlines I have to meet.


Uuups. Missed to stage the VS71 generator changes. ^^

I fixed it and pushed again to the same branch (with --force).


Did you make any progress towards setting up a dashboard for this,
that demonstrates actually building some WinCE stuff with a toolchain
file?


Is there any good example how to set up a cross compiling environment?
I changed a few files, but didn't find the correct ones until now. It 
still compiles for the host system and not for the target system.
If someone can give me a few hints, I can set up the machine in the 
next few days. Otherwise I'll need some time to read the code myself, 
but it's still on my todo list. :-)


-- Patrick
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[David Cole]

On Sat, Jul 21, 2012 at 9:48 AM, Patrick Gansterer  wrote:
> Hi,
>
>
> On Sat, 21 Jul 2012 09:30:58 -0400, David Cole wrote:
>>
>> On Sat, Jul 21, 2012 at 8:16 AM, Patrick Gansterer 
>> wrote:
>>>
>>> Hi,
>>>
>>>
>>> On Sat, 21 Jul 2012 08:08:43 -0400, David Cole wrote:


 Do you have a local branch that has all 6 patches one on top of the
 other?


 On Sat, Jul 21, 2012 at 7:49 AM, Patrick Gansterer 
 wrote:
>
>
> Hi,
>
>
> On Sat, 21 Jul 2012 07:44:33 -0400, David Cole wrote:
>>
>>
>>
>> What branch did you base these on?
>>
>> They don't apply cleanly on top of master today.
>
>
>
>
> If I made no mistake the basic revision was the master branch of last
> weekend:
> 21b45ce16f88172eac3386f002fe112014053a36
>
> -- Patrick
>>>
>>>
>>>
>>> I pushed it as "ce" to https://gitorious.org/~paroga/cmake/parogas-cmake
>>> (git://gitorious.org/~paroga/cmake/parogas-cmake.git)
>>>
>>> BTW: Are there any plans to use gerrit for CMake too?
>>>
>>> -- Patrick
>>
>>
>>
>> (cc'ing the CMake Developers list back in...)
>>
>>
>> OK, finally got it. Whew. Sometimes I could throw git straight out
>> the window...
>>
>> It merges to 'next' cleanly, and builds ok on my machine with Visual
>> Studio 9, but then one test fails... Looks like MSVC71 is somehow
>> getting defined for my msvc 9 build:
>> ...
>>
>> I'll continue following up on this on Monday, (looking more closely at
>> the changes and trying to fix the failing test if you don't beat me to
>> it) -- but for now I have some other deadlines I have to meet.
>
>
> Uuups. Missed to stage the VS71 generator changes. ^^
>
> I fixed it and pushed again to the same branch (with --force).
>
>
>> Did you make any progress towards setting up a dashboard for this,
>> that demonstrates actually building some WinCE stuff with a toolchain
>> file?
>
>
> Is there any good example how to set up a cross compiling environment?
> I changed a few files, but didn't find the correct ones until now. It still
> compiles for the host system and not for the target system.
> If someone can give me a few hints, I can set up the machine in the next few
> days. Otherwise I'll need some time to read the code myself, but it's still
> on my todo list. :-)
>
> -- Patrick

I merged this branch into my local 'next' and ran several vs9 and
vs10, 32- and 64-bit dashboards on Sunday:

  
http://open.cdash.org/index.php?project=CMake&date=2012-07-22&filtercount=1&showfilters=1&field1=site/string&compare1=63&value1=hut11

As you can see, there are test failures here and there, but I'm not
certain if those were problems that would have shown up before trying
this branch. I am re-running the dashboards today based strictly on
'next' without those changes for comparison.

And while those are running, I'll review the code changes to see if I
spot anything objectionable before we merge/push this to origin/next
and give it a whirl on the CMake nightly dashboards.


Thanks,
David
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Patrick Gansterer]

Hi,

is there any chance to get at least a few of this patches into trunk?
Is there anything I can do?
Can some help me in setting up a machine for the dashboard? I haven't 
found any easy way to set up sth cross-compiling and requireing addional 
definitons in the test files.


On Tue, 24 Jul 2012 10:26:30 -0400, David Cole wrote:

I merged this branch into my local 'next' and ran several vs9 and
vs10, 32- and 64-bit dashboards on Sunday:



http://open.cdash.org/index.php?project=CMake&date=2012-07-22&filtercount=1&showfilters=1&field1=site/string&compare1=63&value1=hut11

As you can see, there are test failures here and there, but I'm not
certain if those were problems that would have shown up before trying
this branch. I am re-running the dashboards today based strictly on
'next' without those changes for comparison.

And while those are running, I'll review the code changes to see if I
spot anything objectionable before we merge/push this to origin/next
and give it a whirl on the CMake nightly dashboards.


-- Patrick
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[David Cole]

Which particular patches are you talking about? Are there issues with
patches that are on the 2.8.10 roadmap yet?

I might be able to help you set up a machine for a dashboard. We should
probably have a subset of the test suite that gets executed specifically
for cross-compiling scenarios. (Setting up a dashboard is easy; making sure
it's testing what we want tested here may be a bit more difficult...)

Alex -- how is cross-compiling tested in general on an automatic basis? Is
it at all, or do we rely entirely on users to find issues with
cross-compiling scenarios?


Thx,
David


On Tue, Aug 21, 2012 at 8:50 AM, Patrick Gansterer wrote:

> Hi,
>
> is there any chance to get at least a few of this patches into trunk?
> Is there anything I can do?
> Can some help me in setting up a machine for the dashboard? I haven't
> found any easy way to set up sth cross-compiling and requireing addional
> definitons in the test files.
>
>
> On Tue, 24 Jul 2012 10:26:30 -0400, David Cole wrote:
>
>> I merged this branch into my local 'next' and ran several vs9 and
>> vs10, 32- and 64-bit dashboards on Sunday:
>>
>>
>>
>> http://open.cdash.org/index.**php?project=CMake&date=2012-**
>> 07-22&filtercount=1&**showfilters=1&field1=site/**
>> string&compare1=63&value1=**hut11
>>
>> As you can see, there are test failures here and there, but I'm not
>> certain if those were problems that would have shown up before trying
>> this branch. I am re-running the dashboards today based strictly on
>> 'next' without those changes for comparison.
>>
>> And while those are running, I'll review the code changes to see if I
>> spot anything objectionable before we merge/push this to origin/next
>> and give it a whirl on the CMake nightly dashboards.
>>
>
> -- Patrick
>
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Patrick Gansterer]

Hi,

On Tue, 21 Aug 2012 12:04:50 -0400, David Cole wrote:

Which particular patches are you talking about? Are there issues with
patches that are on the 2.8.10 roadmap yet?


About the patches I posted a few weeks ago. I don't see them in master 
or next branch. So my question is, how the can get there.
Maybe you can apply at least apply the "cleanup" patches, which don't 
add any new behaviour, so that I can get rid of "non official" changes. 
(E.g. "Cleanup AddPlatformDefinitions() of Visual Studio generators")



I might be able to help you set up a machine for a dashboard. We
should probably have a subset of the test suite that gets executed
specifically for cross-compiling scenarios. (Setting up a dashboard 
is

easy; making sure it's testing what we want tested here may be a bit
more difficult...)


I don't see much problem in setting up a machine for dashboard. The 
problem I see is the cross-compilation stuff.
I'd like to add the required pices for WinCE, but unfortunately I don't 
have the time to implement the whole cross compiling stuff into the test 
suite. Or at least I haven't found the correct place for the change(s) 
yet, so it works for the new generator.


-- Patrick
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[David Cole]

On Tue, Aug 21, 2012 at 12:34 PM, Patrick Gansterer wrote:

> Hi,
>
>
> On Tue, 21 Aug 2012 12:04:50 -0400, David Cole wrote:
>
>> Which particular patches are you talking about? Are there issues with
>> patches that are on the 2.8.10 roadmap yet?
>>
>
> About the patches I posted a few weeks ago. I don't see them in master or
> next branch. So my question is, how the can get there.
> Maybe you can apply at least apply the "cleanup" patches, which don't add
> any new behaviour, so that I can get rid of "non official" changes. (E.g.
> "Cleanup AddPlatformDefinitions() of Visual Studio generators")


OK -- I forgot I had tested those for you before the 2.8.9 release, but we
had test failures on those dashboards that I didn't track down at the time.

I'll re-run some dashboards right now on hut11.kitware again based on the
current 'master' branch first to get a baseline.

Then I'll point the source tree to your latest branch from your github and
run them again so we can compare apples to apples.

*Then* I can answer the question about when we can get them into 'next' and
'master'... :-)



>
>
>  I might be able to help you set up a machine for a dashboard. We
>> should probably have a subset of the test suite that gets executed
>> specifically for cross-compiling scenarios. (Setting up a dashboard is
>> easy; making sure it's testing what we want tested here may be a bit
>> more difficult...)
>>
>
> I don't see much problem in setting up a machine for dashboard. The
> problem I see is the cross-compilation stuff.
> I'd like to add the required pices for WinCE, but unfortunately I don't
> have the time to implement the whole cross compiling stuff into the test
> suite. Or at least I haven't found the correct place for the change(s) yet,
> so it works for the new generator.



I'm hoping Alex chimes in here with some good advice for executing a
cross-compiling toolchain as a dashboard test.


Thanks for your patience,
David
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[David Cole]

On Tue, Aug 21, 2012 at 1:33 PM, David Cole  wrote:

> On Tue, Aug 21, 2012 at 12:34 PM, Patrick Gansterer wrote:
>
>> Hi,
>>
>>
>> On Tue, 21 Aug 2012 12:04:50 -0400, David Cole wrote:
>>
>>> Which particular patches are you talking about? Are there issues with
>>> patches that are on the 2.8.10 roadmap yet?
>>>
>>
>> About the patches I posted a few weeks ago. I don't see them in master or
>> next branch. So my question is, how the can get there.
>> Maybe you can apply at least apply the "cleanup" patches, which don't add
>> any new behaviour, so that I can get rid of "non official" changes. (E.g.
>> "Cleanup AddPlatformDefinitions() of Visual Studio generators")
>
>
> OK -- I forgot I had tested those for you before the 2.8.9 release, but we
> had test failures on those dashboards that I didn't track down at the time.
>
> I'll re-run some dashboards right now on hut11.kitware again based on the
> current 'master' branch first to get a baseline.
>
>
I've done this much, and we have have some results from hut11.kitware today
(6 dashboards) that are based on current 'origin/master'


Then I'll point the source tree to your latest branch from your github and
> run them again so we can compare apples to apples.
>

I'm doing this now, but it's going to be a few hours until they are all
done. I've rebased your changes on top of today's origin/master, and
resolved the conflicts that I got. I pushed it here in the meantime if
anybody else wants to review it or pick it up for testing:
https://github.com/dlrdave/CMake/compare/ce



>
> *Then* I can answer the question about when we can get them into 'next'
> and 'master'... :-)
>
>
Just have to await the results now, and talk through it when they get here.



>
>
>>
>>
>>  I might be able to help you set up a machine for a dashboard. We
>>> should probably have a subset of the test suite that gets executed
>>> specifically for cross-compiling scenarios. (Setting up a dashboard is
>>> easy; making sure it's testing what we want tested here may be a bit
>>> more difficult...)
>>>
>>
>> I don't see much problem in setting up a machine for dashboard. The
>> problem I see is the cross-compilation stuff.
>> I'd like to add the required pices for WinCE, but unfortunately I don't
>> have the time to implement the whole cross compiling stuff into the test
>> suite. Or at least I haven't found the correct place for the change(s) yet,
>> so it works for the new generator.
>
>
>
> I'm hoping Alex chimes in here with some good advice for executing a
> cross-compiling toolchain as a dashboard test.
>
>
> Thanks for your patience,
> David
>
>
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[David Cole]

On Tue, Aug 21, 2012 at 5:34 PM, David Cole  wrote:

> On Tue, Aug 21, 2012 at 1:33 PM, David Cole wrote:
>
>> On Tue, Aug 21, 2012 at 12:34 PM, Patrick Gansterer wrote:
>>
>>> Hi,
>>>
>>>
>>> On Tue, 21 Aug 2012 12:04:50 -0400, David Cole wrote:
>>>
 Which particular patches are you talking about? Are there issues with
 patches that are on the 2.8.10 roadmap yet?

>>>
>>> About the patches I posted a few weeks ago. I don't see them in master
>>> or next branch. So my question is, how the can get there.
>>> Maybe you can apply at least apply the "cleanup" patches, which don't
>>> add any new behaviour, so that I can get rid of "non official" changes.
>>> (E.g. "Cleanup AddPlatformDefinitions() of Visual Studio generators")
>>
>>
>> OK -- I forgot I had tested those for you before the 2.8.9 release, but
>> we had test failures on those dashboards that I didn't track down at the
>> time.
>>
>> I'll re-run some dashboards right now on hut11.kitware again based on the
>> current 'master' branch first to get a baseline.
>>
>>
> I've done this much, and we have have some results from hut11.kitware
> today (6 dashboards) that are based on current 'origin/master'
>
>
> Then I'll point the source tree to your latest branch from your github and
>> run them again so we can compare apples to apples.
>>
>
> I'm doing this now, but it's going to be a few hours until they are all
> done. I've rebased your changes on top of today's origin/master, and
> resolved the conflicts that I got. I pushed it here in the meantime if
> anybody else wants to review it or pick it up for testing:
> https://github.com/dlrdave/CMake/compare/ce
>
>
>
>>
>> *Then* I can answer the question about when we can get them into 'next'
>> and 'master'... :-)
>>
>>
> Just have to await the results now, and talk through it when they get here.
>
>
>
>>
>>
>>>
>>>
>>>  I might be able to help you set up a machine for a dashboard. We
 should probably have a subset of the test suite that gets executed
 specifically for cross-compiling scenarios. (Setting up a dashboard is
 easy; making sure it's testing what we want tested here may be a bit
 more difficult...)

>>>
>>> I don't see much problem in setting up a machine for dashboard. The
>>> problem I see is the cross-compilation stuff.
>>> I'd like to add the required pices for WinCE, but unfortunately I don't
>>> have the time to implement the whole cross compiling stuff into the test
>>> suite. Or at least I haven't found the correct place for the change(s) yet,
>>> so it works for the new generator.
>>
>>
>>
>> I'm hoping Alex chimes in here with some good advice for executing a
>> cross-compiling toolchain as a dashboard test.
>>
>>
>> Thanks for your patience,
>> David
>>
>>
>
Brad merged one of your commits to 'next' today. [
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2c7a451de003782b1ba5e47ab377f33f1fa5c4e5
 ]

He's coincidentally working on getting compiler ID uniform everywhere at
the moment, and so it was easiest for him to take that change first and
base other work on that.

After things settle from his changes, we'll come back and visit the
WindowsCE specific portions of your topic branch.


Thanks for your patience,
David
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Patrick Gansterer]

Hi,

On Wed, 22 Aug 2012 16:46:02 -0400, David Cole wrote:

Brad merged one of your commits to 'next' today.


Cool.


He's coincidentally working on getting compiler ID uniform everywhere
at the moment, and so it was easiest for him to take that change 
first

and base other work on that.

After things settle from his changes, we'll come back and visit the
WindowsCE specific portions of your topic branch.


Do you think it's possible to merge 
0001-Added-very-basic-Windows-CE-Makefile-support.patch too?

This change would allow at least the usage with NMake Makefiles.

-- Patrick
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[David Cole]

On Wed, Aug 22, 2012 at 5:56 PM, Patrick Gansterer wrote:

> Hi,
>
>
> On Wed, 22 Aug 2012 16:46:02 -0400, David Cole wrote:
>
>> Brad merged one of your commits to 'next' today.
>>
>
> Cool.
>
>
>  He's coincidentally working on getting compiler ID uniform everywhere
>> at the moment, and so it was easiest for him to take that change first
>> and base other work on that.
>>
>> After things settle from his changes, we'll come back and visit the
>> WindowsCE specific portions of your topic branch.
>>
>
> Do you think it's possible to merge 
> 0001-Added-very-basic-Windows-**CE-Makefile-support.patch
> too?
> This change would allow at least the usage with NMake Makefiles.
>
> -- Patrick
>

Yes. After the changes that Brad is working on. Should be next week
sometime.
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Patrick Gansterer]

Hi,

On Wed, 22 Aug 2012 21:22:47 -0400, David Cole wrote:

On Wed, Aug 22, 2012 at 5:56 PM, Patrick Gansterer  wrote:


Hi,

On Wed, 22 Aug 2012 16:46:02 -0400, David Cole wrote:


Brad merged one of your commits to 'next' today.


Cool.


He's coincidentally working on getting compiler ID uniform
everywhere
at the moment, and so it was easiest for him to take that change
first
and base other work on that.

After things settle from his changes, we'll come back and visit
the
WindowsCE specific portions of your topic branch.


Do you think it's possible to merge
0001-Added-very-basic-Windows-CE-Makefile-support.patch too?
This change would allow at least the usage with NMake Makefiles.

-- Patrick


Yes. After the changes that Brad is working on. Should be next week
sometime.


I saw that Brad merged one of my changes. Are there any other changes 
the WinCE stuff depends on to get merged?


-- Patrick
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Brad King]

On 09/03/2012 10:52 AM, Patrick Gansterer wrote:
> I saw that Brad merged one of my changes. Are there any other changes 
> the WinCE stuff depends on to get merged?

Please rebase the remainder of the topic on upstream master, at
least as recent as commit 25b0d946.  Your changes will need to
account for at least this commit:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f3ddfef1

Sorry to create these conflicts for you but I've wanted to
modernize the MSVC platform files for years and the last barrier
was recently removed (by the ide-compiler-id topic).

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Patrick Gansterer]

On Mon, 03 Sep 2012 11:02:22 -0400, Brad King wrote:

On 09/03/2012 10:52 AM, Patrick Gansterer wrote:
I saw that Brad merged one of my changes. Are there any other 
changes

the WinCE stuff depends on to get merged?


Please rebase the remainder of the topic on upstream master, at
least as recent as commit 25b0d946.  Your changes will need to
account for at least this commit:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f3ddfef1

Sorry to create these conflicts for you but I've wanted to
modernize the MSVC platform files for years and the last barrier
was recently removed (by the ide-compiler-id topic).


I rebased the code and pushed it as "ce" to
https://gitorious.org/~paroga/cmake/parogas-cmake
(git://gitorious.org/~paroga/cmake/parogas-cmake.git)

-- Patrick
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Brad King]

On 09/04/2012 04:18 PM, Patrick Gansterer wrote:
> I rebased the code and pushed it as "ce" to
> https://gitorious.org/~paroga/cmake/parogas-cmake
> (git://gitorious.org/~paroga/cmake/parogas-cmake.git)

Thanks!  I'm looking at the first commit that adds the WindowsCE
platform files.  These lines look strange:

  set(MSVC_C_ARCHITECTURE_ID ${CMAKE_SYSTEM_PROCESSOR})
  set(MSVC_CXX_ARCHITECTURE_ID ${CMAKE_SYSTEM_PROCESSOR})

Normally the ARCHITECTURE_ID values are detected by

 Modules/CMakePlatformId.h.in

which is built by running CMAKE_(C|CXX)_COMPILER, which should
be set by the toolchain file to the proper compiler for WinCE.
Shouldn't that be taught about the architectures in question?

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Patrick Gansterer]

Hi,

On Tue, 04 Sep 2012 16:39:44 -0400, Brad King wrote:

On 09/04/2012 04:18 PM, Patrick Gansterer wrote:

I rebased the code and pushed it as "ce" to
https://gitorious.org/~paroga/cmake/parogas-cmake
(git://gitorious.org/~paroga/cmake/parogas-cmake.git)


Thanks!  I'm looking at the first commit that adds the WindowsCE
platform files.  These lines look strange:

  set(MSVC_C_ARCHITECTURE_ID ${CMAKE_SYSTEM_PROCESSOR})
  set(MSVC_CXX_ARCHITECTURE_ID ${CMAKE_SYSTEM_PROCESSOR})

Normally the ARCHITECTURE_ID values are detected by

 Modules/CMakePlatformId.h.in

which is built by running CMAKE_(C|CXX)_COMPILER, which should
be set by the toolchain file to the proper compiler for WinCE.
Shouldn't that be taught about the architectures in question?


Thanks for the feedback. I've updated my changes and pushed it to the 
same branch.


-- Patrick
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Brad King]

On 09/05/2012 04:26 AM, Patrick Gansterer wrote:
> Thanks for the feedback. I've updated my changes and pushed it to the 
> same branch.

Great, thanks.  I've pushed the platform file commits with minor tweaks:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e7cb8055
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=28d744c9

Please rebase the rest of the topic on those, or on master after
they make it there.

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Patrick Gansterer]

Hi,

On Wed, 05 Sep 2012 16:03:59 -0400, Brad King wrote:

On 09/05/2012 04:26 AM, Patrick Gansterer wrote:
Thanks for the feedback. I've updated my changes and pushed it to 
the

same branch.


Great, thanks.  I've pushed the platform file commits with minor 
tweaks:


 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e7cb8055
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=28d744c9

Please rebase the rest of the topic on those, or on master after
they make it there.


The topic meged a few hours ago. I rebased the code and pushed it again 
as "ce" to
https://gitorious.org/~paroga/cmake/parogas-cmake 
(git://gitorious.org/~paroga/cmake/parogas-cmake.git)


-- Patrick
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Brad King]

On 09/12/2012 09:00 AM, Patrick Gansterer wrote:
> The topic meged a few hours ago. I rebased the code and pushed it again 
> as "ce"

Thanks.

Normally cross compiling is done with a toolchain file and
sets CMAKE_CROSSCOMPILING.  Does that work for the NMake
generator now without this topic?

We need to figure out how to map that approach into the IDE
generators.  A setting like CMAKE_WINCE_SDK needs to be set
before any languages are enabled.  How should a user set it?

Please also add documentation for CMAKE_WINCE_SDK.

BTW, why is this hunk needed?

+  this->GetCMakeInstance()->AddCacheEntry("CMAKE_C_COMPILER",
+"cl", "", cmCacheManager::INTERNAL);
+  this->GetCMakeInstance()->AddCacheEntry("CMAKE_CXX_COMPILER",
+"cl", "", cmCacheManager::INTERNAL);

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Added very basic Windows CE Makefile support

[Patrick Gansterer]

Hi,

Am 13.09.2012 um 13:48 schrieb Brad King:

> On 09/12/2012 09:00 AM, Patrick Gansterer wrote:
>> The topic meged a few hours ago. I rebased the code and pushed it again 
>> as "ce"
> 
> Thanks.
> 
> Normally cross compiling is done with a toolchain file and
> sets CMAKE_CROSSCOMPILING.  Does that work for the NMake
> generator now without this topic?

Should work now for many parts. IMHO there are still a few parts which do not 
work 100% now. But I can figure it out with the current master.

> We need to figure out how to map that approach into the IDE
> generators.  A setting like CMAKE_WINCE_SDK needs to be set
> before any languages are enabled.  How should a user set it?

If you apply it to the other VS genertors we need to extend the list of 
generators with every SDK found (-G "Visual Studio 8 2005 ${CMAKE_WINCE_SDK}"). 
IMHO selecting the platform for the VS compiler with different compilers isn't 
perfect either (For every new VS version you get 2 (with ARM 3) new generator 
types).
Maybe we can extend the "-G parameter" with something like "-GP 
generatorPlatform" and remove the "Win64" and "ARM" VS generators?

> Please also add documentation for CMAKE_WINCE_SDK.
> 
> BTW, why is this hunk needed?
> 
> +  this->GetCMakeInstance()->AddCacheEntry("CMAKE_C_COMPILER",
> +"cl", "", cmCacheManager::INTERNAL);
> +  this->GetCMakeInstance()->AddCacheEntry("CMAKE_CXX_COMPILER",
> +"cl", "", cmCacheManager::INTERNAL);

Otherwiese Visual Studio catches the wrong compiler later. But maybe the CMake 
codebase improved in the meantime (the patch is based on v2.8.3).

-- Patrick 
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers