[GitHub] aditihilbert closed pull request #317: doc: Updates for BT5 and Mesh
aditihilbert closed pull request #317: doc: Updates for BT5 and Mesh URL: https://github.com/apache/mynewt-site/pull/317 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aditihilbert closed pull request #323: automated asf-site build
aditihilbert closed pull request #323: automated asf-site build URL: https://github.com/apache/mynewt-site/pull/323 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] stalehd commented on issue #545: Enable the external antenna for the SX1276 on the EE-02 board.
stalehd commented on issue #545: Enable the external antenna for the SX1276 on the EE-02 board. URL: https://github.com/apache/mynewt-core/pull/545#issuecomment-328973462 We've got a new version of EE-02 without the chip antenna. The chip antenna is *really* hard to tune since it uses the ground plane as part of the antenna. If you integrate EE-02 on to another board the ground plane gets bigger and the RF network on the PCB have to be re-tuned. At the same time the chip antenna requires free space around it to ensure a decent signal so it is hard to integrate the module in an enclosure. Rather than struggle with the antenna we went for the uFL connector and a simple whip antenna. They are easier to use in devices, require no additional tuning and are cheap :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gordonklaus commented on issue #545: Enable the external antenna for the SX1276 on the EE-02 board.
gordonklaus commented on issue #545: Enable the external antenna for the SX1276 on the EE-02 board. URL: https://github.com/apache/mynewt-core/pull/545#issuecomment-328970691 That's correct about the switching. I'm actually not sure that the internal antenna is useless, I shouldn't have said that. As I recall, it was very difficult to tune and it did behave poorly, and so it's actually been removed in a more recent version of the board. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wes3 commented on issue #545: Enable the external antenna for the SX1276 on the EE-02 board.
wes3 commented on issue #545: Enable the external antenna for the SX1276 on the EE-02 board. URL: https://github.com/apache/mynewt-core/pull/545#issuecomment-328989653 All sounds good. I will go ahead and merge this. Thanks for changing this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] utzig opened a new pull request #536: Works with new image format.
utzig opened a new pull request #536: Works with new image format. URL: https://github.com/apache/mynewt-core/pull/536 WIP This adds support for the new image header format (done by @mkiiskila). Please wait WIP removal to merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rymanluk commented on issue #534: nimble/sm: Use privacy device mode as default
rymanluk commented on issue #534: nimble/sm: Use privacy device mode as default URL: https://github.com/apache/mynewt-core/pull/534#issuecomment-327724705 test please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rymanluk opened a new pull request #537: nimble/controller: Fix scan long advertising packets
rymanluk opened a new pull request #537: nimble/controller: Fix scan long advertising packets URL: https://github.com/apache/mynewt-core/pull/537 This patch fixes corrupted long advertising data when BLE_EXT_ADV is used. It is allowed now that advertising data are in the chain of os_mbufs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cwanda opened a new pull request #322: 1.2 install updates
cwanda opened a new pull request #322: 1.2 install updates URL: https://github.com/apache/mynewt-site/pull/322 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aditihilbert closed pull request #334: automated asf-site build
aditihilbert closed pull request #334: automated asf-site build URL: https://github.com/apache/mynewt-site/pull/334 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mkiiskila closed pull request #35: image upload; add support for specifying max mtu to use for serial
mkiiskila closed pull request #35: image upload; add support for specifying max mtu to use for serial URL: https://github.com/apache/mynewt-newtmgr/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek closed pull request #571: hw/bsp: Add leds and buttons definitions for nRF52840 PDK
andrzej-kaczmarek closed pull request #571: hw/bsp: Add leds and buttons definitions for nRF52840 PDK URL: https://github.com/apache/mynewt-core/pull/571 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad opened a new pull request #574: Prevent newt compatility warning for 0.0.0
ccollins476ad opened a new pull request #574: Prevent newt compatility warning for 0.0.0 URL: https://github.com/apache/mynewt-core/pull/574 When the user's project.yml file specifies a floating version for a repo (e.g., 0-latest), newt records a fake version in the project.state file (e.g., 0.0.0). This is a problem when determining if the version of a newt is compatible with the current version of the repo, since the actual version is not known. This commit is a short-term workaround to prevent the warning from being displayed. It allows 0.0.0 of core to work with all versions of newt. A long term fix is needed: we need to be able to determine the actual version of the repo present in the user's project. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mkiiskila opened a new pull request #35: image upload; add support for specifying max mtu to use for serial
mkiiskila opened a new pull request #35: image upload; add support for specifying max mtu to use for serial URL: https://github.com/apache/mynewt-newtmgr/pull/35 newtmgr. Add '-e' flag to image upload which stops upload from starting with erase flash command. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek closed pull request #570: nimble/host: Fix invalid symbol name
andrzej-kaczmarek closed pull request #570: nimble/host: Fix invalid symbol name URL: https://github.com/apache/mynewt-core/pull/570 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek closed pull request #569: nimble/phy: Various fixes
andrzej-kaczmarek closed pull request #569: nimble/phy: Various fixes URL: https://github.com/apache/mynewt-core/pull/569 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mkiiskila closed pull request #32: fixes to work with 1.0 version of bootloader serial image upload
mkiiskila closed pull request #32: fixes to work with 1.0 version of bootloader serial image upload URL: https://github.com/apache/mynewt-newtmgr/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad closed pull request #34: nmxact - conn_cancel_evt listener uses wrong seq
ccollins476ad closed pull request #34: nmxact - conn_cancel_evt listener uses wrong seq URL: https://github.com/apache/mynewt-newtmgr/pull/34 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad closed pull request #33: nmxact - Stop syncer on xport startup.
ccollins476ad closed pull request #33: nmxact - Stop syncer on xport startup. URL: https://github.com/apache/mynewt-newtmgr/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad opened a new pull request #575: Remove obsolete app `apps/test`
ccollins476ad opened a new pull request #575: Remove obsolete app `apps/test` URL: https://github.com/apache/mynewt-core/pull/575 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek closed pull request #572: nimble/host: Add symbol for 'any' phy mask
andrzej-kaczmarek closed pull request #572: nimble/host: Add symbol for 'any' phy mask URL: https://github.com/apache/mynewt-core/pull/572 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek closed pull request #568: nimble/ll: Various fixes
andrzej-kaczmarek closed pull request #568: nimble/ll: Various fixes URL: https://github.com/apache/mynewt-core/pull/568 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek opened a new pull request #576: [MYNEWT-783] nimble/phy: Fix T_IFS on coded phy
andrzej-kaczmarek opened a new pull request #576: [MYNEWT-783] nimble/phy: Fix T_IFS on coded phy URL: https://github.com/apache/mynewt-core/pull/576 This changes T_IFS control from hardware to software. This is required in order to have proper T_IFS on LE Coded PHY since now we're ~16 usecs over the limit which means we can't maintain connection with other devices (except for another Mynewt). Basically what's need to be done is to schedule TXEN/RXEN using TIMER0 exactly 150 usecs after end of TX/RX which is stored in CC[2]. It's a bit more complicated though as we need to take into account various delays in TX/RX pipeline which are not specified in nRF documentation so they were measured instead - code used to do this is also included as I think it can be useful for debugging purposes later. The result is the same T_IFS on all phys: 150 +/- 1 usecs. In addition, code to calculate wfr timer is upgraded to be more precise by including pipeline delays. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek opened a new pull request #568: nimble/ll: Various fixes
andrzej-kaczmarek opened a new pull request #568: nimble/ll: Various fixes URL: https://github.com/apache/mynewt-core/pull/568 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek opened a new pull request #569: nimble/phy: Various fixes
andrzej-kaczmarek opened a new pull request #569: nimble/phy: Various fixes URL: https://github.com/apache/mynewt-core/pull/569 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wes3 commented on issue #576: [MYNEWT-783] nimble/phy: Fix T_IFS on coded phy
wes3 commented on issue #576: [MYNEWT-783] nimble/phy: Fix T_IFS on coded phy URL: https://github.com/apache/mynewt-core/pull/576#issuecomment-332371823 Looked through the changes and it seems good to me. Nothing that has to change so you can go ahead and merge it if you like. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek opened a new pull request #571: hw/bsp: Add leds and buttons definitions for nRF52840 PDK
andrzej-kaczmarek opened a new pull request #571: hw/bsp: Add leds and buttons definitions for nRF52840 PDK URL: https://github.com/apache/mynewt-core/pull/571 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek opened a new pull request #572: nimble/host: Add symbol for 'any' phy mask
andrzej-kaczmarek opened a new pull request #572: nimble/host: Add symbol for 'any' phy mask URL: https://github.com/apache/mynewt-core/pull/572 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs.
andrzej-kaczmarek commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332272818 @wes3 yes, this is exactly what I meant. this pin should be defined by a package which "owns" it so in our cases it's either lora or spitest and the name of syscfg val should be selected by this package. also I agree in case of lora pin this can be overriden in bsp which has it connected to some well known pin. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs.
gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332232087 @wes3 That sounds sensible. What about LORA_SPI_CS_PIN, should this be in any of the BSPs other than telee02? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad opened a new pull request #33: nmxact - Stop syncer on xport startup.
ccollins476ad opened a new pull request #33: nmxact - Stop syncer on xport startup. URL: https://github.com/apache/mynewt-newtmgr/pull/33 This prevents a hang that occurs due to the following sequence: 1. BLE transport successfully starts. 2. For some reason, the transport needs to be reset. 3. Blehostd fails to start. Step 3 triggers a transport shutdown. Prior to this change, the transport might appear to still be in sync, which causes the transport to send a `reset` command to blehostd. Since blehostd is not running, the code hangs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad opened a new pull request #34: nmxact - conn_cancel_evt listener uses wrong seq
ccollins476ad opened a new pull request #34: nmxact - conn_cancel_evt listener uses wrong seq URL: https://github.com/apache/mynewt-newtmgr/pull/34 When blehostd sends a `conn_cancel_evt` event, it uses the sequence number associated with the connection, not the sequence number corresponding to the `conn_cancel` request. Prior to this change, nmxact would listen for the `conn_cancel_evt` with a sequence number equal to that of the request. The event would never arrive, which caused the transport to be restarted. Now, the connect listener listens for the cancel event, in addition to the connect event. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wes3 commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs.
wes3 commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332234556 Gordon: based on the conversation you had with andrzej, I think the CS_PIN definition belongs in hw/drivers/lora/sx1276/syscfg.yml. I had thought you had moved it there but I did not see it in the commits (might have missed it). Overriding it in the BSP makes sense to me, or we can leave it to the target, but I think it fine if their is an override for it in the BSP. It can always be overridden in the target for folks who want to change the pin. As a minor nit, I think renaming this to be SX1276_CS_PIN might be a bit better as this chip could be used for non-lora purposes. Fine by me if you do not want to change the name. Well, I guess I would only do this if that definition is agreed to be moved into the sx1276 dir. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad closed pull request #575: Remove obsolete app `apps/test`
ccollins476ad closed pull request #575: Remove obsolete app `apps/test` URL: https://github.com/apache/mynewt-core/pull/575 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad closed pull request #574: Prevent newt compatility warning for 0.0.0
ccollins476ad closed pull request #574: Prevent newt compatility warning for 0.0.0 URL: https://github.com/apache/mynewt-core/pull/574 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jhedberg commented on a change in pull request #583: Mesh fixes and improvements
jhedberg commented on a change in pull request #583: Mesh fixes and improvements
URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141640738
##
File path: net/nimble/host/mesh/src/cfg.c
##
@@ -2913,6 +2913,8 @@ static void heartbeat_sub_set(struct bt_mesh_model
*model,
if (period_ms) {
cfg->hb_sub.expiry = k_uptime_get() + period_ms;
+ } else {
+ cfg->hb_sub.expiry = k_uptime_get();
}
Review comment:
Yes, expiry = 0 would be more appropriate
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] michal-narajowski commented on issue #583: Mesh fixes and improvements
michal-narajowski commented on issue #583: Mesh fixes and improvements URL: https://github.com/apache/mynewt-core/pull/583#issuecomment-332868196 > Do I understand right, that "mesh: fix setting period div right after receiving it" fixes a regression that was introduced by your earlier commit that moved the publish callback later in mod_publish()? I.e. that patch fixed on thing (accurate period timing) but broke another (updating the period). Yes, I should have stated that in the commit message. I will fix that and break that patch into two separate. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek closed pull request #585: nimble/host: Allow setting adv data when advertising
andrzej-kaczmarek closed pull request #585: nimble/host: Allow setting adv data when advertising URL: https://github.com/apache/mynewt-core/pull/585 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jhedberg commented on issue #583: Mesh fixes and improvements
jhedberg commented on issue #583: Mesh fixes and improvements URL: https://github.com/apache/mynewt-core/pull/583#issuecomment-332858579 As a general comment, could you try to keep app changes separate from stack changes. That makes it easier to port the fixes back to Zephyr. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jhedberg commented on a change in pull request #583: Mesh fixes and improvements
jhedberg commented on a change in pull request #583: Mesh fixes and improvements
URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141641730
##
File path: net/nimble/host/mesh/src/cfg.c
##
@@ -2913,6 +2913,8 @@ static void heartbeat_sub_set(struct bt_mesh_model
*model,
if (period_ms) {
cfg->hb_sub.expiry = k_uptime_get() + period_ms;
+ } else {
+ cfg->hb_sub.expiry = k_uptime_get();
}
Review comment:
Also note that this is not about invalid parameters. Messages with invalid
parameters should not yield any reaction at all by the implementation. Instead,
this particular code path is about disabling the subscription.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wes3 closed pull request #584: Remove some SPI_1_MASTER_SS_PIN defs that were missed.
wes3 closed pull request #584: Remove some SPI_1_MASTER_SS_PIN defs that were missed. URL: https://github.com/apache/mynewt-core/pull/584 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mkiiskila commented on issue #578: Update TinyCrypt to 0.2.8
mkiiskila commented on issue #578: Update TinyCrypt to 0.2.8 URL: https://github.com/apache/mynewt-core/pull/578#issuecomment-332887416 I opened a PR against tinycrypt for g_rng_function consolidation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad closed pull request #582: Native socket fixes
ccollins476ad closed pull request #582: Native socket fixes URL: https://github.com/apache/mynewt-core/pull/582 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jhedberg commented on issue #583: Mesh fixes and improvements
jhedberg commented on issue #583: Mesh fixes and improvements URL: https://github.com/apache/mynewt-core/pull/583#issuecomment-332954391 https://github.com/zephyrproject-rtos/zephyr/pull/4102 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad opened a new pull request #587: testutil - Clear message after failure reported
ccollins476ad opened a new pull request #587: testutil - Clear message after
failure reported
URL: https://github.com/apache/mynewt-core/pull/587
If a test case was reported with a message (e.g., an assertion failure),
the message gets duplicated for all subsequent test cases. For
example:
```
[pass] ble_os_test_suite/ble_os_disc_test_case
[pass] ble_os_test_suite/ble_gap_direct_connect_test_case
[pass] ble_os_test_suite/ble_gap_terminate_test_case
[FAIL] ble_hs_pvcy_test_suite_irk/ble_hs_pvcy_test_case_restore_irks
|net/nimble/host/test/src/ble_hs_pvcy_test.c:34| failed assertion: rc == 0
[pass] ble_sm_gen_test_suite/ble_sm_test_case_f4
|net/nimble/host/test/src/ble_hs_pvcy_test.c:34| failed assertion: rc == 0
[pass] ble_sm_gen_test_suite/ble_sm_test_case_f5
|net/nimble/host/test/src/ble_hs_pvcy_test.c:34| failed assertion: rc == 0
[pass] ble_sm_gen_test_suite/ble_sm_test_case_f6
|net/nimble/host/test/src/ble_hs_pvcy_test.c:34| failed assertion: rc == 0
[pass] ble_sm_gen_test_suite/ble_sm_test_case_g2
|net/nimble/host/test/src/ble_hs_pvcy_test.c:34| failed assertion: rc == 0
[pass] ble_sm_gen_test_suite/ble_sm_test_case_peer_fail_inval
```
The first three cases passed with no message. Then, the fourth failed
with a message ("failed assertion: rc == 0"). The subsequent test cases
incorrectly report the failure message from before.
This commit clears the message buffer after a case gets reported.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs.
gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332208840 @andrzej-kaczmarek That's correct. I was a bit uncertain about where this should be defined. You are right, it makes sense that it should be defined by the package that uses it. I will move the definition of SPI_0_MASTER_SS_PIN into sx1276. I will also rename it to LORA_SPI_CS_PIN (the SX1276 datasheet refers to it as Chip Select). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs.
gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332214902 @andrzej-kaczmarek There was one other usage of SPI_0_MASTER_SS_PIN: apps/spitest. It's a bit odd that it now references LORA_SPI_CS_PIN. Suggestions? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs.
andrzej-kaczmarek commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332189346 correct me if I'm wrong but SPI_0_MASTER_SS_PIN is a slave select pin so basically it can be virtually any pin which application controls anyway. so it should not be defined at mcu level as it does not make much sense there and honestly I'd remove this definition entirely. I see this syscfg val is only used now by lora driver, but in this case this driver should have its own syscfg val for defining SS pin number. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rymanluk commented on issue #565: mesh: Use privacy for mesh node
rymanluk commented on issue #565: mesh: Use privacy for mesh node URL: https://github.com/apache/mynewt-core/pull/565#issuecomment-333059781 @sjanc, agree will change it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sjanc closed pull request #578: Update TinyCrypt to 0.2.8
sjanc closed pull request #578: Update TinyCrypt to 0.2.8 URL: https://github.com/apache/mynewt-core/pull/578 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rymanluk opened a new pull request #589: mesh: Fix dropping valid proxy configuration messages
rymanluk opened a new pull request #589: mesh: Fix dropping valid proxy configuration messages URL: https://github.com/apache/mynewt-core/pull/589 Proxy configuration messages are allowed (in fact required) to use unassigned addresses, so they should be exempt from this check. Ported from Zephyr This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szymon-czapracki opened a new pull request #591: apps/blehr: Added heart-rate sensor app
szymon-czapracki opened a new pull request #591: apps/blehr: Added heart-rate sensor app URL: https://github.com/apache/mynewt-core/pull/591 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sjanc opened a new pull request #594: nimble: Don't hardcode TinyCrypt rand function
sjanc opened a new pull request #594: nimble: Don't hardcode TinyCrypt rand function URL: https://github.com/apache/mynewt-core/pull/594 TinyCrypt requires rand function to be implemented by user. Instead of hardcoding it, user is required to provide own implementation by uECC_set_rng. This allows to provide different implementations depending on supported features (eg BLE controller). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rymanluk closed pull request #565: mesh: Use privacy for mesh node
rymanluk closed pull request #565: mesh: Use privacy for mesh node URL: https://github.com/apache/mynewt-core/pull/565 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rymanluk closed pull request #589: mesh: Fix dropping valid proxy configuration messages
rymanluk closed pull request #589: mesh: Fix dropping valid proxy configuration messages URL: https://github.com/apache/mynewt-core/pull/589 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad closed pull request #593: BLE Host - Populate resolving list with persisted IRKs at startup
ccollins476ad closed pull request #593: BLE Host - Populate resolving list with persisted IRKs at startup URL: https://github.com/apache/mynewt-core/pull/593 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad closed pull request #587: testutil - Clear message after failure reported
ccollins476ad closed pull request #587: testutil - Clear message after failure reported URL: https://github.com/apache/mynewt-core/pull/587 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad opened a new pull request #593: BLE Host - Populate resolving list with persisted IRKs at startup
ccollins476ad opened a new pull request #593: BLE Host - Populate resolving list with persisted IRKs at startup URL: https://github.com/apache/mynewt-core/pull/593 (Jira ticket: https://issues.apache.org/jira/browse/MYNEWT-841) ### Prior to this commit: Identity information gets persisted during pairing, but it is never restored after a reboot. ### After commit: At startup and on stack reset, the host populates the resolving list with the persisted entries. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vrahane opened a new pull request #592: MYNEWT-845 Sensor shell: cputimer for itvl usecs
vrahane opened a new pull request #592: MYNEWT-845 Sensor shell: cputimer for itvl usecs URL: https://github.com/apache/mynewt-core/pull/592 - Fix the sensor shell interval option in command read to use microseconds directly for settign up the timer instead of converting it to ticks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vrahane closed pull request #592: MYNEWT-845 Sensor shell: cputimer for itvl usecs
vrahane closed pull request #592: MYNEWT-845 Sensor shell: cputimer for itvl usecs URL: https://github.com/apache/mynewt-core/pull/592 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sjanc closed pull request #590: mesh: Fix compilation with GCC 7.1
sjanc closed pull request #590: mesh: Fix compilation with GCC 7.1 URL: https://github.com/apache/mynewt-core/pull/590 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mlaz opened a new pull request #588: [WIP - Do not merge] Soft-PWM Driver
mlaz opened a new pull request #588: [WIP - Do not merge] Soft-PWM Driver URL: https://github.com/apache/mynewt-core/pull/588 This pull request adds a soft PWM driver. The driver is working but might need some definitions to be made on syscfg (i.e. the number of channels the the device supports), soft_pwm_get_resolution_bits() needs to be implemented as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad opened a new pull request #582: Native socket fixes
ccollins476ad opened a new pull request #582: Native socket fixes URL: https://github.com/apache/mynewt-core/pull/582 These are two unrelated changes to native_sockets. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wes3 closed pull request #573: Move SPI and I2C config definitions from BSPs to MCUs.
wes3 closed pull request #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rymanluk commented on a change in pull request #583: Mesh fixes and improvements
rymanluk commented on a change in pull request #583: Mesh fixes and improvements
URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141574897
##
File path: apps/blemesh/src/main.c
##
@@ -52,7 +54,83 @@ static struct bt_mesh_cfg cfg_srv = {
.relay_retransmit = BT_MESH_TRANSMIT(2, 20),
};
+static int
+fault_get_cur(struct bt_mesh_model *model,
+ uint8_t *test_id,
+ uint16_t *company_id,
+ uint8_t *faults,
+ uint8_t *fault_count)
+{
+uint8_t reg_faults[24] = { [0 ... 23] = 0xff };
+
+console_printf("fault_get_cur() has_reg_fault %u\n", has_reg_fault);
+
+*test_id = 0x00;
+*company_id = CID_VENDOR;
+
+*fault_count = min(*fault_count, sizeof(reg_faults));
+memcpy(faults, reg_faults, *fault_count);
+
+return 0;
+}
+
+static int
+fault_get_reg(struct bt_mesh_model *model,
+ uint16_t company_id,
+ uint8_t *test_id,
+ uint8_t *faults,
+ uint8_t *fault_count)
+{
+if (company_id != CID_VENDOR) {
+return -BLE_HS_EINVAL;
+}
+
+console_printf("fault_get_reg() has_reg_fault %u\n", has_reg_fault);
+
+*test_id = 0x00;
+
+if (has_reg_fault) {
+uint8_t reg_faults[24] = { [0 ... 23] = 0xff };
Review comment:
let's keep Mynewt coding style and declare it on beginning of the function
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rymanluk commented on a change in pull request #583: Mesh fixes and improvements
rymanluk commented on a change in pull request #583: Mesh fixes and improvements
URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141580918
##
File path: net/nimble/host/mesh/src/cfg.c
##
@@ -2913,6 +2913,8 @@ static void heartbeat_sub_set(struct bt_mesh_model
*model,
if (period_ms) {
cfg->hb_sub.expiry = k_uptime_get() + period_ms;
+ } else {
+ cfg->hb_sub.expiry = k_uptime_get();
}
Review comment:
shouldn't we set cfg->hb_sub.expiry = 0; instead?
@jhedberg fyi
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rymanluk commented on a change in pull request #583: Mesh fixes and improvements
rymanluk commented on a change in pull request #583: Mesh fixes and improvements
URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141585289
##
File path: net/nimble/host/mesh/src/health.c
##
@@ -99,6 +99,7 @@ static size_t health_get_current(struct bt_mesh_model *mod,
fault_count = 0;
} else {
sys_put_le16(company_id, company_ptr);
+ net_buf_simple_add(msg, fault_count);
Review comment:
Could you please extend commit msg by explanation why we need that?
if i undertstand it correctly fault_get_cur() gives application a pointer to
buffer where faults are written. If it succeed we need to update our os_mbuf
with with len of faults array written by application.
By the way, hope application does not exceed maximum faults array size.
Maybe it would be better to have os_mbuf (net_buf) in the callback instead
of *u8_t?
@jhedberg ^^
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sjanc commented on a change in pull request #583: Mesh fixes and improvements
sjanc commented on a change in pull request #583: Mesh fixes and improvements
URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141575355
##
File path: net/nimble/host/mesh/src/cfg.c
##
@@ -2913,6 +2913,8 @@ static void heartbeat_sub_set(struct bt_mesh_model
*model,
if (period_ms) {
cfg->hb_sub.expiry = k_uptime_get() + period_ms;
+ } else {
+ cfg->hb_sub.expiry = k_uptime_get();
}
Review comment:
you could just do
cfg->hb_sub.expiry = k_uptime_get() + period_ms;
without if-else
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rymanluk commented on a change in pull request #583: Mesh fixes and improvements
rymanluk commented on a change in pull request #583: Mesh fixes and improvements
URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141593137
##
File path: net/nimble/host/mesh/src/health.c
##
@@ -99,6 +99,7 @@ static size_t health_get_current(struct bt_mesh_model *mod,
fault_count = 0;
} else {
sys_put_le16(company_id, company_ptr);
+ net_buf_simple_add(msg, fault_count);
Review comment:
Ah I see that _count in the callback contains maximum bytes which can
be written to the buffer but still, worth to consider passing os_mbuf in the
callback.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] gordonklaus opened a new pull request #584: Remove some SPI_1_MASTER_SS_PIN defs that were missed.
gordonklaus opened a new pull request #584: Remove some SPI_1_MASTER_SS_PIN defs that were missed. URL: https://github.com/apache/mynewt-core/pull/584 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs.
gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332837084 @wes3 Ok, I submitted PRs for those repos. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jhedberg commented on a change in pull request #583: Mesh fixes and improvements
jhedberg commented on a change in pull request #583: Mesh fixes and improvements
URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141624317
##
File path: net/nimble/host/mesh/src/health.c
##
@@ -99,6 +99,7 @@ static size_t health_get_current(struct bt_mesh_model *mod,
fault_count = 0;
} else {
sys_put_le16(company_id, company_ptr);
+ net_buf_simple_add(msg, fault_count);
Review comment:
I think I didn't go with a net_buf since net_buf_tailroom() wouldn't
actually give you how many faults you can add to the buffer, since there needs
to be space for more mesh-internal data after that (in particular the MIC).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] andrzej-kaczmarek opened a new pull request #585: nimble/host: Allow setting adv data when advertising
andrzej-kaczmarek opened a new pull request #585: nimble/host: Allow setting adv data when advertising URL: https://github.com/apache/mynewt-core/pull/585 Not sure why this was not allowed, but it is perfectly ok to do so and controller will update data while advertising. And even if for some reason it won't, there will be proper error returned. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek commented on issue #585: nimble/host: Allow setting adv data when advertising
andrzej-kaczmarek commented on issue #585: nimble/host: Allow setting adv data when advertising URL: https://github.com/apache/mynewt-core/pull/585#issuecomment-332848749 @ccollins476ad I see that you added these checks in 3890be32 so let me know if there was any issue with this as updating advertising data while advertising works perfectly fine for me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rymanluk commented on a change in pull request #583: Mesh fixes and improvements
rymanluk commented on a change in pull request #583: Mesh fixes and improvements
URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141806332
##
File path: net/nimble/host/mesh/src/cfg.c
##
@@ -2886,18 +2886,22 @@ static void heartbeat_sub_set(struct bt_mesh_model
*model,
sub_period == 0x00) {
cfg->hb_sub.src = BT_MESH_ADDR_UNASSIGNED;
cfg->hb_sub.dst = BT_MESH_ADDR_UNASSIGNED;
+ cfg->hb_sub.min_hops = 0;
+ cfg->hb_sub.max_hops = 0;
+
period_ms = 0;
} else {
cfg->hb_sub.src = sub_src;
cfg->hb_sub.dst = sub_dst;
+ cfg->hb_sub.min_hops = 0x7f;
+ cfg->hb_sub.max_hops = 0;
+
period_ms = hb_pwr2(sub_period, 1) * 1000;
}
- BT_DBG("period_ms %u", period_ms);
+ cfg->hb_sub.count = 0;
Review comment:
indentation isssue
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] michal-narajowski closed pull request #583: Mesh fixes and improvements
michal-narajowski closed pull request #583: Mesh fixes and improvements URL: https://github.com/apache/mynewt-core/pull/583 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] utzig closed pull request #31: Adds a progressbar to image upload command
utzig closed pull request #31: Adds a progressbar to image upload command URL: https://github.com/apache/mynewt-newtmgr/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad closed pull request #30: Various improvements for recovering from transport failure
ccollins476ad closed pull request #30: Various improvements for recovering from transport failure URL: https://github.com/apache/mynewt-newtmgr/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gordonklaus opened a new pull request #573: Move SPI and I2C config definitions from BSPs to MCUs.
gordonklaus opened a new pull request #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573 Also add restrictions between I2C and SPI on nRF5x boards, as was already done for the EE-02. This is primarily a refactoring, but it could cause some builds to fail. In particular, any BSP not the core that defines these settings will see ?setting XXX redefined? errors. And any nRF5x app or target that had both I2C_0 and SPI_0 enabled (or _1) will run into the new restrictions. Otherwise, all settings (interfaces enabled, pin numbers) are unchanged, with one exception: The VBLUno boards had enabled I2C and SPI 0 and 1. To resolve the conflict, I disabled SPI, as at least I2C_0 seems like it ought to be enabled by default for the on-board OLED. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrzej-kaczmarek opened a new pull request #570: nimble/host: Fix invalid symbol name
andrzej-kaczmarek opened a new pull request #570: nimble/host: Fix invalid symbol name URL: https://github.com/apache/mynewt-core/pull/570 This can be considered API change but the symbol name is obviously invalid as it does not follow naming scheme so let's change it anyway. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sjanc commented on issue #578: Update TinyCrypt to 0.2.8
sjanc commented on issue #578: Update TinyCrypt to 0.2.8 URL: https://github.com/apache/mynewt-core/pull/578#issuecomment-332755171 yeah, I simply implemented default_CSPRNG() inside ble_sm_alg.c but maybe calling uECC_set_rng() is in fact better. I'll send PR for this. As for g_rng_function, I think this should be first done in upstream TC and then we can backport. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michal-narajowski opened a new pull request #583: Mesh fixes and improvements
michal-narajowski opened a new pull request #583: Mesh fixes and improvements URL: https://github.com/apache/mynewt-core/pull/583 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michal-narajowski commented on issue #583: Mesh fixes and improvements
michal-narajowski commented on issue #583: Mesh fixes and improvements URL: https://github.com/apache/mynewt-core/pull/583#issuecomment-332773828 @jhedberg FYI This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wes3 commented on issue #498: nordic: LF clock modifications
wes3 commented on issue #498: nordic: LF clock modifications URL: https://github.com/apache/mynewt-core/pull/498#issuecomment-324702633 Just an FYI: I tried to build a fair amount of targets but there are many that I did not build. I also did very limited testing of this fix so was hoping the community would help test :-) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wes3 opened a new pull request #498: nordic: LF clock modifications
wes3 opened a new pull request #498: nordic: LF clock modifications URL: https://github.com/apache/mynewt-core/pull/498 The following changes were made to the code regarding the LF clock for nordic platforms. The initial impetus for this change was that there was no support for using a synthesized 32kHz clock for nrf52 platforms. LF clock management was different between the nrf51 and nrf52 as well and this commit is intended to make them consistent. Here is a list of the changes made: 1) Always turn on the LF clock for nordic bsps/platforms. 2) Move the LF clock source syscfg definitions from the BSP into the mcu. 3) BSP now sets the proper LF clock based on the BSP hw (either external, synthesized or internal RC oscillator). 4) The OS will now always use the 32768 crystal for OS time. All code that dealt with it using a different clock source has been removed. 5) Both the nrf51 and nrf52 now use the same RTC time resources. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wes3 commented on issue #498: nordic: LF clock modifications
wes3 commented on issue #498: nordic: LF clock modifications URL: https://github.com/apache/mynewt-core/pull/498#issuecomment-324729774 Regarding Marko's comment: I have to say I really do not like the name/location of hal_system_clock_start(). I did not want to make that change as well here (not quite sure why other than not making too many changes all at once). I guess also I was not sure what to do. I was thinking that the code to turn on the clock would exist only in hal_bsp.c as a static function to be honest. This way we could remove the proto from hw/hal and not have it in mcu at all. I do agree with you though Marko: the current code should get modified to remove hal_system_clock_start() for hw/hal. Another possible issue with this change is that the code now always uses the LFCLK. I do not think this a big deal as generally I suspect folks will use nordic platforms w/BLE but I could envision cases where an application does not care about power consumption and wants to use the HFCLK for everything. This is currently not possible and if folks want to do that they are going to have to modify the code to handle this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad opened a new pull request #499: Remove NFFS_AREA_MAX constant from bsp.h.
ccollins476ad opened a new pull request #499: Remove NFFS_AREA_MAX constant from bsp.h. URL: https://github.com/apache/mynewt-core/pull/499 This value indicates the number of areas to allocate in the NFFS disk. Prior to this commit, this number was defined separately in each BSP's `bsp.h` file. Now, this `#define` is replaced by a syscfg setting: ``` NFFS_NUM_AREAS: description: > Number of areas to allocate in the NFFS disk. A smaller number is used if the flash hardware cannot support this value. value: 8 ``` The motivation for this change was to simplify BSP-creation for the purposes of documentation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad opened a new pull request #499: Remove NFFS_AREA_MAX constant from bsp.h.
ccollins476ad opened a new pull request #499: Remove NFFS_AREA_MAX constant from bsp.h. URL: https://github.com/apache/mynewt-core/pull/499 This value indicates the number of areas to allocate in the NFFS disk. Prior to this commit, this number was defined separately in each BSP's `bsp.h` file. Now, this `#define` is replaced by a syscfg setting: ``` NFFS_NUM_AREAS: description: > Number of areas to allocate in the NFFS disk. A smaller number is used if the flash hardware cannot support this value. value: 8 ``` The motivation for this change was to simplify BSP-creation for the purposes of documentation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] schilken opened a new pull request #502: add bsp for calliope mini board
schilken opened a new pull request #502: add bsp for calliope mini board URL: https://github.com/apache/mynewt-core/pull/502 I made FLASH_AREA_REBOOT_LOG much smaller and increased the size of the images to 117kB. Hope this is OK. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joebowbeer opened a new pull request #311: spelling fix
joebowbeer opened a new pull request #311: spelling fix URL: https://github.com/apache/mynewt-site/pull/311 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michal-narajowski commented on issue #88: [RFC] Add option to generate CMakeLists.txt file for a target
michal-narajowski commented on issue #88: [RFC] Add option to generate CMakeLists.txt file for a target URL: https://github.com/apache/mynewt-newt/pull/88#issuecomment-325356438 I fixed issues 2-7. As for the 1. I agree that it pollutes the project directory. Initially, I wanted to generate a file for each target, but CLion searches for CMakeLists.txt in the root directory and it didn't work for me. I'm not sure if it is something you can change in CLion, so I decided to change the path to root path. I hope that we can tweak this as more people start using this feature and sharing their experience. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vrahane opened a new pull request #505: [WIP, DO NOT MERGE] MYNEWT-828 SensorAPI: Sensor OIC notifications/triggers
vrahane opened a new pull request #505: [WIP, DO NOT MERGE] MYNEWT-828 SensorAPI: Sensor OIC notifications/triggers URL: https://github.com/apache/mynewt-core/pull/505 - Add API for setting threshold based on polling mechanism - Also allow the API to set thresholds based on interrupts mechanism - Design is as follows: i. It adds a list of structures sensor_traits_list to the sensor structure which keeps track of per type thresholds, oic resources, algorithm, etc. These thresholds are then compared with the readings from the sensor at the specific poll rates based on algorithms decided by the developer: and . : Sensor data is compared to thresholds making a window. : Sensor data is compared to thresholds based on watermarks Notifications are sent if conditions are satisfied as per the above algorithms. If a set_thresh callback is specified in the driver, this callback will get called which will enable interrupts based notifications for specific sensor drivers. An example of this can be seen in [hw/drivers/sensors/lis2dh12/src/lis2dh12.c](https://github.com/apache/mynewt-core/compare/master...vrahane:sensor_notif?expand=1#diff-18789c89dd99a5f02122ee67a80b82a1). ii. Syscfg : This is a new syscfg which enables or disables periodic observation of sensor resources. By default it is enabled in the sensors test app. iii. There were two fields added to : & which lets the developer specify the interrupt pins in the bsp along with the interface and chip select if any. iv. A lot of functions were added to the lis2dh12 driver to support interrupt functionality. (The current interrupt config for lis2dh12 enables the low thresh interrupts and high thresh interrupts but it somehow only generates an interrupt on a change in the accelerometer data crossing a threshold instead of generating one based on threshold regardless, this needs to be investigated further). Jira Ticket: https://issues.apache.org/jira/browse/MYNEWT-828 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sjanc opened a new pull request #503: Update TinyCrypt to 0.2.7
sjanc opened a new pull request #503: Update TinyCrypt to 0.2.7 URL: https://github.com/apache/mynewt-core/pull/503 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sjanc opened a new pull request #504: Update mbedTLS to 2.5.1
sjanc opened a new pull request #504: Update mbedTLS to 2.5.1 URL: https://github.com/apache/mynewt-core/pull/504 mbedtls_ecp_group_load_secp224r1 and mbedtls_ecp_group_load_secp256r1 Mynewt additions are removed. mbedtls_ecp_group_load is configurable with supported domains so there is little gain with specialized API. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mkiiskila commented on issue #504: Update mbedTLS to 2.5.1
mkiiskila commented on issue #504: Update mbedTLS to 2.5.1 URL: https://github.com/apache/mynewt-core/pull/504#issuecomment-325425320 Have you measured the size impact on secure bootloader with RSA and ECC224? Mynewt additions were added to address this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mkiiskila commented on a change in pull request #501: Fix warning for clicker and wifire boards
mkiiskila commented on a change in pull request #501: Fix warning for clicker and wifire boards URL: https://github.com/apache/mynewt-core/pull/501#discussion_r135573764 ## File path: hw/bsp/pic32mz2048_wi-fire/src/hal_bsp.c ## @@ -212,7 +212,7 @@ hal_bsp_init(void) #if MYNEWT_VAL(UART_3) rc = os_dev_create((struct os_dev *) _bsp_uart3, "uart3", -OS_DEV_INIT_PRIMARY, 0, uart_hal_init, _cfg); +OS_DEV_INIT_PRIMARY, 0, uart_hal_init, (void *)_cfg); Review comment: These void * typecasts of arguments are not needed for os_dev_create()/hal_spi_init(), as the function prototype already has declared that argument as void *. I recommend not adding them, as they're not needed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mkiiskila opened a new pull request #507: boot_serial; access uart driver directly instead of going through console.
mkiiskila opened a new pull request #507: boot_serial; access uart driver directly instead of going through console. URL: https://github.com/apache/mynewt-core/pull/507 This is for space savings. Before the change: objsize text data bss dec hex filename 16248 845352 2168454b4 /Users/marko/src2/incubator-mynewt-blinky/bin/targets/boot_nrf52_serial/app/apps/boot/boot.elf After the change: text data bss dec hex filename 14816 764996 198884db0 /Users/marko/src2/incubator-mynewt-blinky/bin/targets/boot_nrf52_serial/app/apps/boot/boot.elf This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad opened a new pull request #506: shell - Don't register NULL command.
ccollins476ad opened a new pull request #506: shell - Don't register NULL command. URL: https://github.com/apache/mynewt-core/pull/506 As pointed out by Chris Merck, a command entry with all-fields-null was getting registered. This made subsequently registered commands inaccessible. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad closed pull request #497: BLE Host - Don't abort reset if HCI restart fails.
ccollins476ad closed pull request #497: BLE Host - Don't abort reset if HCI restart fails. URL: https://github.com/apache/mynewt-core/pull/497 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccollins476ad opened a new pull request #497: BLE Host - Don't abort reset if HCI restart fails.
ccollins476ad opened a new pull request #497: BLE Host - Don't abort reset if HCI restart fails. URL: https://github.com/apache/mynewt-core/pull/497 While the host is resetting, it attempts to restart the HCI transport. This may involve some communication with hardware. For example, when the UART transport resets, it closes, reopens, and reconfigures the UART. ### Old behavior: If the HCI transport fails to restart due to a hardware failure, the host aborts its reset. As a consequence, stale connections remain open, and the reset callback does not get called. ### New behavior: The host restarts the HCI transport and assumes success. If the transport failed to reset, the host will reset itself again when it fails to sync with the controller. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
