Re: Spec reviews

[Xiaojian Zhou]

I think async review is also a good optio, if we can collect enough
feedbacks for the spec.

On Thu, May 28, 2015 at 9:57 AM, Gregory Chase  wrote:

> In marketing world, we have two time slots we typically use: US 8AM Pacific
> which provides an end of day time slot for EMEA as well, and 8PM Pacific
> which hits China at 11AM, and India at 830 AM.
>
> I recommend starting with these on an alternating basis.
>
> Alternatively, the PMC could hold a primary meeting at one timeslot, and
> then a shorter recap & comment meeting at the other time slot, alternating
> the primary and recap meetings.
>
> On Thu, May 28, 2015 at 9:51 AM, William Markito 
> wrote:
>
> > That's a great idea Justin!! +1
> >
> > Once we start having spec reviews, let's rotate...
> >
> > On Thu, May 28, 2015 at 4:06 AM, Josh Fischer  >
> > wrote:
> >
> > > I think spec reviews in Google a hangout is a great idea.  Can google
> > > hangouts be taped a viewed later on for individuals who could not make
> > the
> > > time slot or is it only available as it is broadcasted? If not, the
> > > rotational time slot works for me.
> > >
> > > +1
> > >
> > > -Josh
> > >
> > > Please excuse my brevity, this is sent from my phone.
> > > On May 28, 2015 5:57 AM, "Justin Erenkrantz" 
> > > wrote:
> > >
> > > > On Fri, May 22, 2015 at 5:44 PM, William Markito <
> wmark...@pivotal.io>
> > > > wrote:
> > > > > Folks,
> > > > >
> > > > >What do you think about doing some spec reviews through Google
> > > > hangout ?
> > > > >
> > > > >There are some JIRAs open that will have some specs attached but
> > it
> > > > > would also be nice if we had some discussions/presentations about
> the
> > > > > proposed specs.
> > > > >
> > > > >The idea would be to announce the hangouts here on the dev list
> > and
> > > > > share the notes after the meeting on the list as well.  That's not
> > > saying
> > > > > that discussions won't happen on the list, but just that some specs
> > > could
> > > > > be better discussed in a video conference.
> > > >
> > > > Part of the Incubation process is to encourage diverse participation,
> > > > so synchronous communication mechanisms should be embraced only with
> > > > extreme care.  If the only people who end up attending are those who
> > > > are employed by Pivotal, then, well, that's just an echo chamber.
> > > >
> > > > With synchronous communication methods, one particular sensitive
> point
> > > > is what timeslots work for folks - for example, I catch up on the
> > > > Geode lists outside of normal working hours.  Cloud Foundry After
> Dark
> > > > only happens at 8pm Pacific, which makes it near impossible for
> > > > Europeans or, even, East Coasters to participate.  I don't know what
> > > > the geographic dispersion is of folks are currently, but I do believe
> > > > that there are Gemfire communities in Europe and Asia.
> > > >
> > > > In a global footprint, an option that I've seen is that the some
> > > > communities try to do a rotation of their weekly - it will rotate
> > > > through 3 time slots - basically, Europe morning, US morning, and
> Asia
> > > > morning.  (They actually do something like US/EU/US/Asia to make it
> > > > slightly more predictable.)  And, it's understood that not everyone
> > > > will make every weekly.
> > > >
> > > > Also, Etherpad is a pretty good way to draft the minutes
> > > > collaboratively - the Ceph community has a pretty good process there:
> > > >
> > > > http://pad.ceph.com/p/performance_weekly
> > > >
> > > > HTH.  -- justin
> > > >
> > >
> >
> >
> >
> > --
> >
> > William Markito Oliveira
> >
> > -- For questions about Apache Geode, please write to
> > *dev@geode.incubator.apache.org
> > *
> >
>
>
>
> --
> Greg Chase
>
> Director of Product Marketing | Big Data
> http://www.pivotal.io/big-data
>
> Pivotal Software
> http://www.pivotal.io/
>
> 650-215-0477
> @GregChase
> Blog: http://geekmarketing.biz/
>

Re: Weird networking behavior on Amazon EC via OSv deployment

[Xiaojian Zhou]

Hi,

I did not use your image to reproduce, but for the 2 issues I think you can
try following 2 steps:
1) >> [warning 2015/08/16 04:36:15.260 GMT server3 
>> tid=0x4a] requested unicast receive buffer size of 65,535 but got
>> 32,767: This is an operating system limit. If you would like to change
>> it, please see your system administrator.

This error msg actually is not the root cause of the issue. To avoid the
error msg, you can modify sysctl.conf of your instance to add 2 lines:
# unicast buffer size
net.core.rmem_max = 2096304
net.core.wmem_max = 2096304

2) You might not open enough ports for tcp and udp. That could be the real
root cause. To do that, you can either turn the ports (1024-65535) from AWS
GUI interface or via following commands:
aws ec2 authorize-security-group-ingress --group-id your_security_group_id
--protocol tcp --port 22 --cidr 0.0.0.0/00
aws ec2 authorize-security-group-ingress --group-id your_security_group_id
--protocol tcp --port 1024-65535 --cidr 0.0.0.0/00
aws ec2 authorize-security-group-ingress --group-id your_security_group_id
--protocol udp --port 1024-65535 --cidr 0.0.0.0/00

Regards
Xiaojian Zhou


On Mon, Aug 17, 2015 at 4:20 PM, Roman Shaposhnik  wrote:

> Hi!
>
> I'm working on creating a Geode appliance for OSv
> along the same lines as what Cassandra has done
> (slides are at the bottom of the page: http://osv.io/)
>
> In my local environment everything works reasonably
> OK, but when I deploy on Amazon EC I run into:
>  https://groups.google.com/forum/#!topic/osv-dev/BpF0uSrMR-M
>
> I'd appreciate if somebody can let me know:
> #1 if there are well-known gotchas with Geode
>  and EC2 in general, especially when it comes
>  to networking
>
> #2 how can I turn on full tracing/debug output of
>  networking layer in order to potentially get additional
>  clues to what's going on
>
> Thanks,
> Roman.
>

Re: Weird networking behavior on Amazon EC via OSv deployment

[Xiaojian Zhou]

No. "ALL" does not count. I remembered that I have to manually specify the
range.

On Mon, Aug 17, 2015 at 6:06 PM, Roman Shaposhnik 
wrote:

> On Mon, Aug 17, 2015 at 5:40 PM, Xiaojian Zhou  wrote:
> > This error msg actually is not the root cause of the issue. To avoid the
> > error msg, you can modify sysctl.conf of your instance to add 2 lines:
> > # unicast buffer size
> > net.core.rmem_max = 2096304
> > net.core.wmem_max = 2096304
>
> Thanks for the suggestion, but I am actually not running it on Linux
> (or UNIX for that matter).
>
> > 2) You might not open enough ports for tcp and udp. That could be the
> real
> > root cause. To do that, you can either turn the ports (1024-65535) from
> AWS
> > GUI interface or via following commands:
> > aws ec2 authorize-security-group-ingress --group-id
> your_security_group_id
> > --protocol tcp --port 22 --cidr 0.0.0.0/00
> > aws ec2 authorize-security-group-ingress --group-id
> your_security_group_id
> > --protocol tcp --port 1024-65535 --cidr 0.0.0.0/00
> > aws ec2 authorize-security-group-ingress --group-id
> your_security_group_id
> > --protocol udp --port 1024-65535 --cidr 0.0.0.0/00
>
> Hm. That's a good point, but the security group I'm running it
> from has ALL the ports open so I guess it shouldn't be a problem
> then, right?
>
> Thanks,
> Roman.
>

Re: Review Request 37696: Fixing contents of partially written files

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37696/#review96102
---

Ship it!


Ship It!

- xiaojian zhou


On Aug. 21, 2015, 10:59 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37696/
> ---
> 
> (Updated Aug. 21, 2015, 10:59 p.m.)
> 
> 
> Review request for geode and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I added some tests of partially written files. The tests write to an
> output stream but don't close it, which mimics a partially written file
> because of the way the code works - it doesn't save the changes to the
> File object until OutputStream is closed.
> 
> I found that the metadata was inconsistent with the file contents for
> partially written files. I fixed that by deleting any chunks past the
> reported length of the file.
> 
> Making renames and deletes closer to atomic
> 
> It's important that when a file is renamed, the new file appears
> atomically with all of the data - according to the LuceneDirectory
> interface. It's also important that during a delete the file does not
> start missing chunks before it is actually deleted.
> 
> These changes address those two issues. I've introduced a UUID for the
> file that is used instead of the filename as part of the chunk id. When
> a file is renamed, the new file just points to the same UUID. Deletes
> delete the File object first and the chunks later.
> 
> There are still some dangling issues - namely that there can be dangling
> chunks for files that have been deleted. But I think the more severe
> issues with a lack of atomicity are resolved now.
> 
> I've added a couple of unit tests of partial renames and partial
> deletes. These tests work by wrapping the underlying "region" with a
> wrapper that throws a CacheClosedException after a certain number of
> operations have happened - essentially mimicking a member being closed
> or killed.
> 
> 
> Diffs
> -
> 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/ChunkKey.java
>  5564c02b0585fb74a1311b4f4510285180494d80 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/File.java
>  1f5edb746a85b22fb0d5ca479cf3ef0be64084a4 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileOutputStream.java
>  4006be21f0568fd48f1fbdc98c9c11045c488959 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystem.java
>  62b3708860e95cc71a328b0a5a00edc8c214 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemJUnitTest.java
>  b79bd1e1178b78a13bdc6750828895c68e149aaf 
> 
> Diff: https://reviews.apache.org/r/37696/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 37822: Adding an AsyncEventListener to write events to Lucene

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37822/#review96839
---



gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListener.java
 (line 57)
<https://reviews.apache.org/r/37822/#comment152521>

how to simulate invalidate, destroy, clear events? 

For example, what are actually cleared by a clear() event in AEQ?


- xiaojian zhou


On Aug. 27, 2015, 12:13 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37822/
> ---
> 
> (Updated Aug. 27, 2015, 12:13 a.m.)
> 
> 
> Review request for geode, Ashvin A and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding an implementation of the listener and a unit test. I also added
> several other interfaces for collaborators with this AsyncEventListener.
> 
> SingleIndexRepository - Interface for a single lucene index (in other
> words, a single index on a single bucket for a PR). This currently has
> methods for writing to the index.
> 
> RepositoryManager - interface for obtaining SingleIndexRepository
> objects based on a user region and a key.
> 
> ObjectToDocumentMapper - interface for translating a gemfire object
> into an indexable document.
> 
> 
> Diffs
> -
> 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListener.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/ObjectToDocumentMapper.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/RepositoryManager.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepository.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepositoryImpl.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListenerJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37822/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 37899: Implementing mapping objects to Lucene documents

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37899/#review96937
---

Ship it!


Ship It!

- xiaojian zhou


On Aug. 28, 2015, 6:33 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37899/
> ---
> 
> (Updated Aug. 28, 2015, 6:33 p.m.)
> 
> 
> Review request for geode, Ashvin A and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I've added an implementation of the code that converts and object to a
> document. As part of this, I renamed a couple of interfaces
> ObjectToDocumentMapper -> LuceneSerializer
> SingleIndexRepository -> IndexRepository
> 
> The LuceneSerializer is an interface I hope maybe we can allow users
> to implement if they want so they can customize how their object gets
> converted to a Document - for example for spatial indexing.
> 
> I've implemented the LuceneSerializer and added unit tests. I also
> implemented IndexRepository and added a unit test for that as well.
> 
> 
> Diffs
> -
> 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListener.java
>  1eca80ab148b071c26197846838645c639a6d6e9 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/ObjectToDocumentMapper.java
>  24612ca3b211b690d2ac0bffc2a809082cbd3dd8 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/RepositoryManager.java
>  a6879a9f039dee5c5240c072c21e8aac46325d62 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepository.java
>  f4cc4ef026403857efe2dcf891fe5376e350e0f2 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepositoryImpl.java
>  944cf41ad3597fe6d9b9b81fde58bcd971fbd58d 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/HeterogenousLuceneSerializer.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/LuceneSerializer.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxLuceneSerializer.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/SerializerUtil.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListenerJUnitTest.java
>  ca80db1b308b4403639638923976cb0f8be23542 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepositoryImplJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/HeterogenousLuceneSerializerJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxFieldMapperJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionFieldMapperJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/Type1.java
>  PRE-CREATION 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/Type2.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37899/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 38572: Fix CI failure for ShutdownAllDUnitTest

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38572/
---

(Updated Sept. 22, 2015, 5:50 p.m.)


Review request for geode and Darrel Schneider.


Changes
---

Add the fix:

existingSystemDisconnected = false


Bugs: geode-329
https://issues.apache.org/jira/browse/geode-329


Repository: geode


Description
---

There's a race conditition that 2 DS will be created when the current DS is 
disconnecting.


Diffs
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/DistributedSystem.java
 b7b2cd8 

Diff: https://reviews.apache.org/r/38572/diff/


Testing
---

precheckin


Thanks,

xiaojian zhou

Re: Review Request 38572: Fix CI failure for ShutdownAllDUnitTest

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38572/
---

(Updated Sept. 23, 2015, 11:51 p.m.)


Review request for geode and Darrel Schneider.


Changes
---

The previous fix will hang. Fixed it. 

We should only set existingSystemDisconnecte = true when wait() happened.


Bugs: geode-329
https://issues.apache.org/jira/browse/geode-329


Repository: geode


Description
---

There's a race conditition that 2 DS will be created when the current DS is 
disconnecting.


Diffs (updated)
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/DistributedSystem.java
 b7b2cd8 

Diff: https://reviews.apache.org/r/38572/diff/


Testing
---

precheckin


Thanks,

xiaojian zhou

Re: Review Request 38572: Fix CI failure for ShutdownAllDUnitTest

[Xiaojian Zhou]

Cannot change it to "while ..." because we will only loop when ever waited.

On Wed, Sep 23, 2015 at 5:06 PM, Darrel Schneider 
wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38572/#review100324
> ---
>
>
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/DistributedSystem.java
> (line 1587)
> <https://reviews.apache.org/r/38572/#comment157507>
>
> Change "boolean existingSystemDisconnected = false;" to "boolean
> existingSystemDisconnected;"
> since on the very next line you initialize it.
>
>
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/DistributedSystem.java
> (line 1619)
> <https://reviews.apache.org/r/38572/#comment157509>
>
> Change this loop from "do..while" to "while".
> Then you can get rid of the nested "if !existingSystems.isEmpty()"
> line (on line 1590).
>
>
> - Darrel Schneider
>
>
> On Sept. 23, 2015, 4:51 p.m., xiaojian zhou wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/38572/
> > ---
> >
> > (Updated Sept. 23, 2015, 4:51 p.m.)
> >
> >
> > Review request for geode and Darrel Schneider.
> >
> >
> > Bugs: geode-329
> > https://issues.apache.org/jira/browse/geode-329
> >
> >
> > Repository: geode
> >
> >
> > Description
> > ---
> >
> > There's a race conditition that 2 DS will be created when the current DS
> is disconnecting.
> >
> >
> > Diffs
> > -
> >
> >
>  
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/DistributedSystem.java
> b7b2cd8
> >
> > Diff: https://reviews.apache.org/r/38572/diff/
> >
> >
> > Testing
> > ---
> >
> > precheckin
> >
> >
> > Thanks,
> >
> > xiaojian zhou
> >
> >
>
>

Re: Review Request 38572: Fix CI failure for ShutdownAllDUnitTest

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38572/
---

(Updated Sept. 25, 2015, 11:25 p.m.)


Review request for geode and Darrel Schneider.


Changes
---

Why the "existingSystemConnected = true;" should be put inside "while 
isConnected()"?

In initialize(), "disconnected" is set true

Then in disconnect(), the "disConnecting" is set to true.

Then the connect() method will not enter the "while isConnected()" loop and 
will not wait(). 

This is the root cause of the hang. 

Now how to get rid of the disconnected member?

Actually addSystem(newSystem) has handled that. It added a new system into item 
0, then existingSystems = Collections.unmodifiableList(l);


Bugs: geode-329
https://issues.apache.org/jira/browse/geode-329


Repository: geode


Description
---

There's a race conditition that 2 DS will be created when the current DS is 
disconnecting.


Diffs (updated)
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/DistributedSystem.java
 b7b2cd8 

Diff: https://reviews.apache.org/r/38572/diff/


Testing
---

precheckin


Thanks,

xiaojian zhou

Re: Review Request 38572: Fix CI failure for ShutdownAllDUnitTest

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38572/
---

(Updated Sept. 28, 2015, 11:36 p.m.)


Review request for geode and Darrel Schneider.


Changes
---

initialize() did set connected=true. But disconnect() set the 
disconnecting=true. 

In IDS.isConnect(), there're following code:
if (this.isDisconnecting) {
  return false;
}
return this.isConnected;

So, the "while" in following code will never enter. 
-  if (existingSystem.isDisconnecting()) {
-while (existingSystem.isConnected()) {
i.e. the wait(500) was never called. Anyway, even the wait(500) is never 
called, in old code, there's chance to create 2 instances(current thread found 
a disconnecting one, it goes ahead to create a new one. Then the thread2 will 
find 2 ds)

With our latest code change, the wait(50) will really take effect.


Bugs: geode-329
https://issues.apache.org/jira/browse/geode-329


Repository: geode


Description
---

There's a race conditition that 2 DS will be created when the current DS is 
disconnecting.


Diffs (updated)
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/DistributedSystem.java
 b7b2cd8 

Diff: https://reviews.apache.org/r/38572/diff/


Testing
---

precheckin


Thanks,

xiaojian zhou

Re: Review Request 39020: GEODE-244: Fixing race in testRecoverRedundancyWithOfflinePersistenceSimulation

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39020/#review101605
---

Ship it!


Ship It!

- xiaojian zhou


On Oct. 5, 2015, 9:40 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39020/
> ---
> 
> (Updated Oct. 5, 2015, 9:40 p.m.)
> 
> 
> Review request for geode and Ashvin A.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The test recreates the persistent partitioned region, and then asserts
> that all buckets are recovered. But the buckets may be recovered
> asynchronously. Now the test will wait for the buckets to show up.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java
>  1b04ecb3fface8031108fd9655ae752e0a78e9b4 
> 
> Diff: https://reviews.apache.org/r/39020/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 39108: Hiding the lucene async event queue from the list of queues.

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39108/#review101833
---



gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
 (line 3961)
<https://reviews.apache.org/r/39108/#comment159343>

remove then add?



gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderAttributes.java
 (line 77)
<https://reviews.apache.org/r/39108/#comment159344>

Will there be any backward compatibility issue since we introduce a new 
attribute here?


- xiaojian zhou


On Oct. 7, 2015, 11:27 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39108/
> ---
> 
> (Updated Oct. 7, 2015, 11:27 p.m.)
> 
> 
> Review request for geode, Ashvin A and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I added a new flag to the queue - isMetaQueue, which controls whether a
> queue will show up in getAllQueues. This also has the effect of
> preventing the queue from showing up in a generated xml file.
> 
> This is necessary because our queue needs to be constructed with an
> async event listener that has a reference to the index. If the queue is
> generated and added to the xml, it will end up trying to create a
> listener before the index is created.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
>  f41321850f472d0566f89e20104e2420c930140e 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/AsyncEventQueueImpl.java
>  71e8d2a7d617d2542f123706f64a221f58c47163 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
>  6fe639b0daca33ab63e85bfb880dfd20a276513a 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java
>  3bd299296844ada13b44b73ead4605b015431726 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderAttributes.java
>  1d0b4f111595250b474ce7d2948998bcda9d9f06 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  60085e45346cdda7e473daf505760eb47a6f7cb8 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java
>  5ec2725e8f390ac9a3833df0b32c4c8581ab9370 
> 
> Diff: https://reviews.apache.org/r/39108/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 39108: Hiding the lucene async event queue from the list of queues.

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39108/#review101837
---

Ship it!


Since there's no backward compatibility issue and the "remove and add" are 
fixed. Others look good.

- xiaojian zhou


On Oct. 7, 2015, 11:27 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39108/
> ---
> 
> (Updated Oct. 7, 2015, 11:27 p.m.)
> 
> 
> Review request for geode, Ashvin A and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I added a new flag to the queue - isMetaQueue, which controls whether a
> queue will show up in getAllQueues. This also has the effect of
> preventing the queue from showing up in a generated xml file.
> 
> This is necessary because our queue needs to be constructed with an
> async event listener that has a reference to the index. If the queue is
> generated and added to the xml, it will end up trying to create a
> listener before the index is created.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
>  f41321850f472d0566f89e20104e2420c930140e 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/AsyncEventQueueImpl.java
>  71e8d2a7d617d2542f123706f64a221f58c47163 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
>  6fe639b0daca33ab63e85bfb880dfd20a276513a 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java
>  3bd299296844ada13b44b73ead4605b015431726 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderAttributes.java
>  1d0b4f111595250b474ce7d2948998bcda9d9f06 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  60085e45346cdda7e473daf505760eb47a6f7cb8 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java
>  5ec2725e8f390ac9a3833df0b32c4c8581ab9370 
> 
> Diff: https://reviews.apache.org/r/39108/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 39328: Adding an internal listener that can modify region attributes

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39328/#review102799
---

Ship it!


Ship It!

- xiaojian zhou


On Oct. 15, 2015, 5:18 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39328/
> ---
> 
> (Updated Oct. 15, 2015, 5:18 p.m.)
> 
> 
> Review request for geode, Ashvin A, Darrel Schneider, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This listener is attached to the cache and gets a callback before any
> region is created. This can be used by extensions to modify region
> attributes to create resources need for a region before the region is
> created.
> 
> This listener is needed to allow lucene to add an async event queue to the 
> region attributes at region creation time.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
>  b0f0f43be2d2beaac66256d5b07b0fd8c35ffe9c 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java
>  9e5bcd286f802d03bc558a03a33e5cfb100b4683 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionListener.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/RegionListenerJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39328/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 39329: Requiring lucene index to be created before the region

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39329/#review102811
---

Ship it!


Besides the comments, others look good.


gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java
 (line 78)
<https://reviews.apache.org/r/39329/#comment160582>

You assumed the region to be PR here, because only PR has 
getAttributesMutator().addAEQid(). 

It's ok, but we need to add a TODO for DR.


- xiaojian zhou


On Oct. 14, 2015, 9:21 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39329/
> ---
> 
> (Updated Oct. 14, 2015, 9:21 p.m.)
> 
> 
> Review request for geode, Ashvin A and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> At the moment, adding an AsyncEventQueue after a region is created has
> issues - See GEODE-404.
> 
> Therefore, in order to create a lucene index programmatically, the
> lucene index needs to be created before the region exists so that we can
> create the AEQ ahead of time.
> 
> With this change, when an LuceneIndex is created, the actual creation is
> deferred in a RegionListener callback. When the region is created, we
> add the AEQ to the region attributes and create the colocated regions.
> 
> 
> Diffs
> -
> 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/LuceneService.java
>  eed80d97dee539cc3bfb0f9778f957984f3340a7 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  2bf848f6685c21f4199245771c4be3d2a3ba4e83 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java
>  776d005b1091d58c1be46eb9a7a8113ba3daf0d0 
>   
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java
>  5520f96242ab02f14e0919144fc9aa3ed4166b92 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneRebalanceJUnitTest.java
>  478981f56aa4d4eec1a853f85c84014dfd05b5a6 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java
>  eff28130e2cd03de875b4debf6823a63cded2faa 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionReadPathDUnitTest.java
>  6e44b72574d0289f44bbd715ec84409f36fc9aeb 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexXmlGeneratorIntegrationJUnitTest.java
>  65c73f70e69c77bbfa8ef084b1c1712c5d31037b 
>   
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexXmlParserIntegrationJUnitTest.java
>  56a726f591f9df0cadd2d4fcf9413abe272e93ea 
> 
> Diff: https://reviews.apache.org/r/39329/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Review Request 39747: tombstone GC did not finished at the same time on different member

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39747/
---

Review request for geode and Dan Smith.


Bugs: GEODE-371
https://issues.apache.org/jira/browse/GEODE-371


Repository: geode


Description
---

GEODE-371:
The unfinished destroy operation is overwritten by the GII but the tombstone
is left in cache. TombstoneGC on different members are not finished at the
same time. When GII happened in this window, the expected deltaGII will 
become
full GII.

However, after discussed with the team, we decide not to fix, only to 
enhance
the test to wait until the time window is over.


Diffs
-

  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/GIIDeltaDUnitTest.java
 38fc3ab 

Diff: https://reviews.apache.org/r/39747/diff/


Testing
---

the dunit test


Thanks,

xiaojian zhou

Review Request 39763: need to add expected exception for the exception test

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39763/
---

Review request for geode and Dan Smith.


Bugs: GEODE-513
https://issues.apache.org/jira/browse/GEODE-513


Repository: geode


Description
---

The test is to trigger some exceptions. So for these exception should add 
expected exception to resolve the suspect strings.


Diffs
-

  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionSingleHopDUnitTest.java
 c0b0d3c 

Diff: https://reviews.apache.org/r/39763/diff/


Testing
---

the dunit test case


Thanks,

xiaojian zhou

Re: Review Request 39763: need to add expected exception for the exception test

[xiaojian zhou]

> On Oct. 29, 2015, 9:01 p.m., Darrel Schneider wrote:
> > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionSingleHopDUnitTest.java,
> >  line 257
> > <https://reviews.apache.org/r/39763/diff/1/?file=1112263#file1112263line257>
> >
> > Why are these exceptions expected?
> > The only exception I see this test throwing is:
> >   throw new FunctionInvocationTargetException(
> > "I have been thrown from TestFunction");
> > 
> > So why would we see IOException and SocketException?

The test will throw an FunctionInvocationTargetException() at server, and 
caused the client thought the endpont is crashed. Here is the error msg:

Redundant subscription endpoint gzhou-t440p.vmware.com:25790 crashed. 
Scheduling recovery.


So the disconnecting is expected.


- xiaojian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39763/#review104474
---


On Oct. 29, 2015, 6:02 p.m., xiaojian zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39763/
> ---
> 
> (Updated Oct. 29, 2015, 6:02 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Bugs: GEODE-513
> https://issues.apache.org/jira/browse/GEODE-513
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The test is to trigger some exceptions. So for these exception should add 
> expected exception to resolve the suspect strings.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionSingleHopDUnitTest.java
>  c0b0d3c 
> 
> Diff: https://reviews.apache.org/r/39763/diff/
> 
> 
> Testing
> ---
> 
> the dunit test case
> 
> 
> Thanks,
> 
> xiaojian zhou
> 
>

Re: Review Request 40272: GEODE-546: Resetting stats when AbstractGatewaySender is stopped

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40272/#review106488
---

Ship it!


Ship It!

- xiaojian zhou


On Nov. 13, 2015, 1:45 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40272/
> ---
> 
> (Updated Nov. 13, 2015, 1:45 a.m.)
> 
> 
> Review request for geode, Ashvin A and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-546: Resetting stats when AbstractGatewaySender is stopped
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java
>  bc1161888c795ac1a874899a63ba930c8fda48e6 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/asyncqueue/internal/SerialAsyncEventQueueImplJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40272/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 41058: GEODE-637: Additional tests for AsyncEventQueues

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41058/#review109224
---

Ship it!


Ship It!

- xiaojian zhou


On Dec. 7, 2015, 11:24 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41058/
> ---
> 
> (Updated Dec. 7, 2015, 11:24 p.m.)
> 
> 
> Review request for geode, Ashvin A and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-637: Additional tests for AsyncEventQueues
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/AsyncEventQueueTestBase.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerOffHeapDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventQueueStatsDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentAsyncEventQueueDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentAsyncEventQueueOffHeapDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/CommonParallelAsyncEventQueueDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/CommonParallelAsyncEventQueueOffHeapDUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41058/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Review Request 41332: Add CacheObserver for ShutdownAll and also let WAN to return CancelException

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41332/
---

Review request for geode and Dan Smith.


Repository: geode


Description
---

We need a cacheobserver for ShutdownAll. 

GatewayReceiverCommand will find the region of events will be null when 
shutdownall is on-going. In this case, it will throw CacheDestroyedException 
(i.e. subclass of CancelException) instead of RegionDestroyedException.


Diffs
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserver.java
 9cd6c28 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserverAdapter.java
 82c4507 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
 27bb813 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java
 6d252e4 

Diff: https://reviews.apache.org/r/41332/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 41332: Add CacheObserver for ShutdownAll and also let WAN to return CancelException

[Xiaojian Zhou]

There's another review request for close part code changes.
https://reviewboard.gemstone.com/r/3761/

GEODE-669 is just created.

On Mon, Dec 14, 2015 at 10:33 AM, Dan Smith  wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41332/#review110274
> ---
>
>
> Can you file a JIRA for this?
>
> Also, would it make sense to add this sort of logic to Cache.getRegion? It
> seems like there might be other code that is expecting to find a region
> that previously existed, and the only reason that it is gone is because of
> a shut down all.
>
> - Dan Smith
>
>
> On Dec. 14, 2015, 1:06 a.m., xiaojian zhou wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/41332/
> > ---
> >
> > (Updated Dec. 14, 2015, 1:06 a.m.)
> >
> >
> > Review request for geode and Dan Smith.
> >
> >
> > Repository: geode
> >
> >
> > Description
> > ---
> >
> > We need a cacheobserver for ShutdownAll.
> >
> > GatewayReceiverCommand will find the region of events will be null when
> shutdownall is on-going. In this case, it will throw
> CacheDestroyedException (i.e. subclass of CancelException) instead of
> RegionDestroyedException.
> >
> >
> > Diffs
> > -
> >
> >
>  
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserver.java
> 9cd6c28
> >
>  
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserverAdapter.java
> 82c4507
> >
>  
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
> 27bb813
> >
>  
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java
> 6d252e4
> >
> > Diff: https://reviews.apache.org/r/41332/diff/
> >
> >
> > Testing
> > ---
> >
> >
> > Thanks,
> >
> > xiaojian zhou
> >
> >
>
>

Re: Review Request 41492: GEODE-681: Measuring event queue size without using the stat for gfsh

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41492/#review110915
---



gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/stats/StatsKey.java
 
<https://reviews.apache.org/r/41492/#comment170910>

You removed this stats "eventQueueSize", vsd cannot show it any more. 

How about fix the size in stats too?


- xiaojian zhou


On Dec. 17, 2015, 2:43 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41492/
> ---
> 
> (Updated Dec. 17, 2015, 2:43 a.m.)
> 
> 
> Review request for geode, Ashvin A and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The eventQueueSize stat has issues with concurrent events during start
> and stop that are leading it to be inaccurate. To make gfsh and jmx
> correct,  measuring the queue size directly from the underlying region
> size.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java
>  422c150fbf1e34785f79bbad54b52cd61594e64c 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
>  b9d877e1a0fab318ae8c29e8ea076bf4d42fb051 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
>  94dc9e8708df08221d26791dd53ab0070657afae 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessor.java
>  16410cec806618eff49a3a4611e257cbfa8278a6 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/GatewaySenderMBeanBridge.java
>  0b6f4325998b56ba03ede0dc01350f941c7e606b 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/stats/StatsKey.java
>  50972923b5ff4842822ba30d039bb5c56f66509f 
> 
> Diff: https://reviews.apache.org/r/41492/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Review Request 41581: Shutdown a distributed system will close the cache in another thread, make sure the cache is really closed

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41581/
---

Review request for geode and Dan Smith.


Repository: geode


Description
---

It's not reproducing of GEODE-329. 

What happened is: The DistributedTestCase.disconnectFromDS() will close the 
cache in another thread. 

The next step to createPR(vm0, 0) should wait for the first cache is really 
closed. Otherwise, there's chance that the closing cache is still on going.


Diffs
-

  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
 39ffb11 

Diff: https://reviews.apache.org/r/41581/diff/


Testing
---

The dunit test


Thanks,

xiaojian zhou

Re: Review Request 41581: Shutdown a distributed system will close the cache in another thread, make sure the cache is really closed

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41581/
---

(Updated Dec. 21, 2015, 6:57 p.m.)


Review request for geode and Dan Smith.


Changes
---

used await()


Repository: geode


Description
---

It's not reproducing of GEODE-329. 

What happened is: The DistributedTestCase.disconnectFromDS() will close the 
cache in another thread. 

The next step to createPR(vm0, 0) should wait for the first cache is really 
closed. Otherwise, there's chance that the closing cache is still on going.


Diffs (updated)
-

  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
 39ffb11 

Diff: https://reviews.apache.org/r/41581/diff/


Testing
---

The dunit test


Thanks,

xiaojian zhou

Re: Review Request 41581: Shutdown a distributed system will close the cache in another thread, make sure the cache is really closed

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41581/
---

(Updated Dec. 21, 2015, 7:37 p.m.)


Review request for geode and Dan Smith.


Repository: geode


Description
---

It's not reproducing of GEODE-329. 

What happened is: The DistributedTestCase.disconnectFromDS() will close the 
cache in another thread. 

The next step to createPR(vm0, 0) should wait for the first cache is really 
closed. Otherwise, there's chance that the closing cache is still on going.


Diffs (updated)
-

  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
 39ffb11 

Diff: https://reviews.apache.org/r/41581/diff/


Testing
---

The dunit test


Thanks,

xiaojian zhou

Review Request 42099: Fix for Garmin issue

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42099/
---

Review request for geode, Bruce Schuchardt and Dan Smith.


Bugs: GEODE-774
https://issues.apache.org/jira/browse/GEODE-774


Repository: geode


Description
---

When a wan batch is retried, the operation will be rejected by primary bucket 
because it has seen it. But it will still distribute to the secondary bucket. 
Sometimes, the event could be accepted due to eventtracker timeout and clean up 
the recorded events. But this event does not contain a version tag and can 
never find its version tag in the system. 

The fix is not to distribute in this case. 

Following checking have been used in many other places:
if (event.getVersionTag() != null && event.getVersionTag().hasValidVersion())

I just introduced a few more.


Diffs
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java
 f487bd5 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java
 92b585a 

Diff: https://reviews.apache.org/r/42099/diff/


Testing
---

The in-house hydra test to reproduce it. 
precheckin.
A lot of wan hydra tests.


Thanks,

xiaojian zhou

Re: Review Request 42099: Fix for 52550 issue

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42099/
---

(Updated Jan. 9, 2016, 7:01 a.m.)


Review request for geode, Bruce Schuchardt and Dan Smith.


Summary (updated)
-

Fix for 52550 issue


Bugs: GEODE-774
https://issues.apache.org/jira/browse/GEODE-774


Repository: geode


Description
---

When a wan batch is retried, the operation will be rejected by primary bucket 
because it has seen it. But it will still distribute to the secondary bucket. 
Sometimes, the event could be accepted due to eventtracker timeout and clean up 
the recorded events. But this event does not contain a version tag and can 
never find its version tag in the system. 

The fix is not to distribute in this case. 

Following checking have been used in many other places:
if (event.getVersionTag() != null && event.getVersionTag().hasValidVersion())

I just introduced a few more.


Diffs
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java
 f487bd5 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java
 92b585a 

Diff: https://reviews.apache.org/r/42099/diff/


Testing
---

The in-house hydra test to reproduce it. 
precheckin.
A lot of wan hydra tests.


Thanks,

xiaojian zhou

Re: Review Request 42465: refactoring RegionVersionHolder.recordVersion()

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42465/#review115118
---



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolder2JUnitTest.java
 (line 148)
<https://reviews.apache.org/r/42465/#comment175976>

Special exception should be:
next=this.version+1, but previous will never be this.version. It could be 
this.version-1 or smaller. 

So your code should be:
 h.addException(h.getVersion()-1, h.getVersion()+1);
 
Other code changes look good. Make sure that with my suggested change, the 
test will still pass.


- xiaojian zhou


On Jan. 18, 2016, 6:29 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42465/
> ---
> 
> (Updated Jan. 18, 2016, 6:29 p.m.)
> 
> 
> Review request for geode, Dan Smith and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This is from a group refactoring session during a class taught by Michael 
> Feathers.  The old recordVersion code was difficult to understand and was 
> poorly tested.  New JUnit tests are now included that give 100% code coverage 
> for this algorithm.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolder.java
>  4872df2a06c0bf6c949204cf98074d9259d6413f 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolder2JUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42465/diff/
> 
> 
> Testing
> ---
> 
> precheckin including new tests
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 42465: refactoring RegionVersionHolder.recordVersion()

[Xiaojian Zhou]

I think Jinmei might be right. For the case of version == this.version + 1,
new code will call addOldVersion(). It will not do anything, but it's
different with old hehavior. In old logic, addOldVersion() will not be
called.

On Tue, Jan 19, 2016 at 8:57 AM, Jinmei Liao  wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42465/
>
> On January 19th, 2016, 4:40 p.m. UTC, *Jinmei Liao* wrote:
>
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolder.java
> <https://reviews.apache.org/r/42465/diff/2/?file=1200643#file1200643line331> 
> (Diff
> revision 2)
>
> private void addBitSetExceptions(int numBits, long newVersion) {
>
> 320
>
> if (this.version != version) {
>
> 331
>
>   private void recordVersionWithoutBitSet(long version) {
>
> Looks like in the recordVersionWithoutBitSet, in case when version == 
> this.version and version= this.version  + 1, we are still calling 
> this.addOlderVersion(version). Would this have any unexpected impact on the 
> end result?
>
> On January 19th, 2016, 4:46 p.m. UTC, *Bruce Schuchardt* wrote:
>
> I think that's intentional, for the "special exception" - though I'm still a 
> bit unclear about what this exception is supposed to be.  That's what the old 
> code was doing, in any case, and the refactoring is supposed to preserve the 
> old behavior.
>
> Oh, by looking more closely to the old behavior, in the case of 
> "version==this.version" it is calling addOlderVersion, but in the case 
> (version == this.version+1), it does not look like it's doing that..., or 
> maybe I am wrong. Just so that you can take a look. Thanks!
>
>
> - Jinmei
>
> On January 18th, 2016, 6:29 p.m. UTC, Bruce Schuchardt wrote:
> Review request for geode, Dan Smith and xiaojian zhou.
> By Bruce Schuchardt.
>
> *Updated Jan. 18, 2016, 6:29 p.m.*
> *Repository: * geode
> Description
>
> This is from a group refactoring session during a class taught by Michael 
> Feathers.  The old recordVersion code was difficult to understand and was 
> poorly tested.  New JUnit tests are now included that give 100% code coverage 
> for this algorithm.
>
> Testing
>
> precheckin including new tests
>
> Diffs
>
>- 
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolder.java
>(4872df2a06c0bf6c949204cf98074d9259d6413f)
>- 
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolder2JUnitTest.java
>(PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/42465/diff/>
>

Re: Review Request 42039: GEODE-716: Getting the bucket creation lock when setting the CacheLoader

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42039/#review115467
---

Ship it!


Ship It!

- xiaojian zhou


On Jan. 15, 2016, 1:55 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42039/
> ---
> 
> (Updated Jan. 15, 2016, 1:55 a.m.)
> 
> 
> Review request for geode, Ashvin A and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I've taken a two prong approach to this one. I'm fixing the bug, but 
> I'm also marking setCacheLoader as deprecated for partitioned regions.
> 
> Modifying the CacheLoader using AttributesMutator had a race condition
> with partitioned regions where a bucket might never get the new cache
> loader. By getting the bucket creation lock, we ensure that the bucket
> will either read the cache loader value after it has been set or the
> cache loader modification thread will set the cache loader on the
> bucket.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/AttributesMutator.java 
> e5bfdb179615a7b82a69d7a8a7305fd709f8702c 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java
>  33bc15886060335033c19e2d3fcaa82dcd0a 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionedRegionObserver.java
>  6f9ce1eb886ae176b51717bc01df91a0d7a95207 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionedRegionObserverAdapter.java
>  e806715b8fb6b0d97a42ddafe3962518ba0af32c 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStoreJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 41492: GEODE-681: Measuring event queue size without using the stat for gfsh

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41492/#review115474
---

Ship it!


Ship It!

- xiaojian zhou


On Jan. 16, 2016, 1:45 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41492/
> ---
> 
> (Updated Jan. 16, 2016, 1:45 a.m.)
> 
> 
> Review request for geode, Ashvin A and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The eventQueueSize stat has issues with concurrent events during start
> and stop that are leading it to be inaccurate. To make gfsh and jmx
> correct,  measuring the queue size directly from the underlying region
> size.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java
>  377f8e282e2b86e0dddefd485d5708e424088eed 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/SerialAsyncEventQueueImpl.java
>  8c8342c7869a6fb4315a544bbf42411be742b908 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java
>  422c150fbf1e34785f79bbad54b52cd61594e64c 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
>  b9d877e1a0fab318ae8c29e8ea076bf4d42fb051 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderAdvisor.java
>  60ed6c819f36e15f158e96bfdeb8f5c90962ef2c 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderEventProcessor.java
>  8d11079982af02c2583de3484bd8dbbf9111a135 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
>  94dc9e8708df08221d26791dd53ab0070657afae 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessor.java
>  16410cec806618eff49a3a4611e257cbfa8278a6 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/GatewaySenderMBeanBridge.java
>  0b6f4325998b56ba03ede0dc01350f941c7e606b 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/stats/StatsKey.java
>  50972923b5ff4842822ba30d039bb5c56f66509f 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/SortedListForAsyncQueueJUnitTest.java
>  bfd4ac38670a9e651d34803912d2eaf0a9a76703 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessorJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/management/bean/stats/GatewaySenderStatsJUnitTest.java
>  30b3a82f7a96773f6414d933f49b5da8090dc7ad 
> 
> Diff: https://reviews.apache.org/r/41492/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 42822: GEODE-864: Waiting for conflation thread in conflation tests

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42822/#review116478
---




gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
 (line 2165)
<https://reviews.apache.org/r/42822/#comment177495>

There is a pauseSender() and pauseSenderAndWaitForDispatcherToPause(). You 
just made the 2 methods identical. 

Was that purposely using pauseSender() here?

Others look good.


- xiaojian zhou


On Jan. 26, 2016, 8:47 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42822/
> ---
> 
> (Updated Jan. 26, 2016, 8:47 p.m.)
> 
> 
> Review request for geode, Barry Oglesby and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> For parallel queues, there is a actually a separate conflation thread
> that removes entries from the queue on conflation. The tests need to
> wait for this thread to finish it's work.
> 
> As part of this change, I refactored the ParallelWANConflationDUnitTest
> to remove a bunch of duplicate code, replaced the VM.invoke(String)
> calls with lambdas, and scaled the test down to create fewer buckets and
> do fewer puts so that it runs in 1/4 of the time.
> 
> 
> Diffs
> -
> 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
>  230c8d8ce6f903cf5e4b9c8bf42b87ca04271647 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANConflationDUnitTest.java
>  4acaaf4c5f24123db335e39ea56592717c9ea17c 
> 
> Diff: https://reviews.apache.org/r/42822/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Lambdas in dunits! Time to remove string invoke?

[Xiaojian Zhou]

+1

It saved a lot of trouble in tracing the method.

And introduced a simple interface can make such a big difference.

On Tue, Jan 26, 2016 at 3:22 PM, Kenneth Howe  wrote:

> +1
>
> Ken
>
>

Re: Review Request 42885: GEODE-872: Removing duplicate code from ConcurrentSerialGatewaySenderOperationsDUnitTest

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42885/#review116669
---


Ship it!




Ship It!

- xiaojian zhou


On Jan. 28, 2016, 12:43 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42885/
> ---
> 
> (Updated Jan. 28, 2016, 12:43 a.m.)
> 
> 
> Review request for geode, Barry Oglesby and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This test was almost an exact copy of
> SerialGatewaySenderOperationsDUnitTest, with a few lines changes. The
> non concurrent test had already fixed the suspect string, but the
> concurrent test did not. By throwing away the code from Concurrent* and
> making it extend the non-concurrent test, this bug is fixed.
> 
> The test has also been tuned to do fewer operations and take less time.
> 
> 
> Diffs
> -
> 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
>  0c32d1fee204544cae490da9c048713c65fe6d29 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentSerialGatewaySenderOperationsDUnitTest.java
>  b709334f7272cf50498e4d4ce910434691652343 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderOperationsDUnitTest.java
>  d30289b7ed2130b25be6b865f3516b466e28a820 
> 
> Diff: https://reviews.apache.org/r/42885/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 42886: GEODE-867: Ignore secondaries in waitForDispatcherToPause

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42886/#review116680
---


Ship it!




Ship It!

- xiaojian zhou


On Jan. 28, 2016, 12:46 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42886/
> ---
> 
> (Updated Jan. 28, 2016, 12:46 a.m.)
> 
> 
> Review request for geode, Barry Oglesby and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> For serial gateways, secondary dispatchers are already paused in waiting
> to become primary, so they don't flip the flag that indicates that the
> dispatcher is paused.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
>  c19857f60e2ededbba52193352dbca1fe1e402ca 
> 
> Diff: https://reviews.apache.org/r/42886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 42889: GEODE-865: CI Failure: ConcurrentParallelGatewaySenderOperation_2_DUnitTest.testParallelGatewaySenders_SingleNode_UserPR_localDestroy_RecreateRegion

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42889/#review116686
---




gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java
 (line 526)
<https://reviews.apache.org/r/42889/#comment177762>

I have been thinking of make this method more generic to be shared by all 
the WAN test cases and AEQ test cases. 

Others look good.


- xiaojian zhou


On Jan. 28, 2016, 1:37 a.m., Barry Oglesby wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42889/
> ---
> 
> (Updated Jan. 28, 2016, 1:37 a.m.)
> 
> 
> Review request for geode, Dan Smith and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-865: 
> ConcurrentParallelGatewaySenderOperation_2_DUnitTest.testParallelGatewaySenders_SingleNode_UserPR_localDestroy_RecreateRegion
> 
> - add lambda support (mostly but not completely done)
> - refactored similar behavior out into local methods
> 
> 
> Diffs
> -
> 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
>  230c8d8ce6f903cf5e4b9c8bf42b87ca04271647 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java
>  f770062e2a2fdb8c9d35cd2d4f76ac96fa56ac37 
> 
> Diff: https://reviews.apache.org/r/42889/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Barry Oglesby
> 
>

Re: Review Request 42892: GEODE-873: Allowing for possible retry in testParallelPregationHA

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42892/#review116687
---


Ship it!




Ship It!

- xiaojian zhou


On Jan. 28, 2016, 1:47 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42892/
> ---
> 
> (Updated Jan. 28, 2016, 1:47 a.m.)
> 
> 
> Review request for geode, Barry Oglesby and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> It's possible a put could be retried due to the member shutdown in this
> test. If there is a retry, the stats may get incremented by one more
> event.
> 
> 
> Diffs
> -
> 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java
>  4da0868da1d02008683ad1bbcec10f88f9ef77c2 
> 
> Diff: https://reviews.apache.org/r/42892/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 42977: GEODE-875: CI failure: ParallelGatewaySenderOperationsOffHeapDUnitTest.testParallelGatewaySender_SingleNode_UserPR_localDestroy_SimultenuousPut_RecreateRegion

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42977/#review117038
---




gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java
 (line 522)
<https://reviews.apache.org/r/42977/#comment178104>

I also think we can make these "ln" as parameter and make the method more 
generic. 

Any way, others look good, you can ship it.


- xiaojian zhou


On Jan. 29, 2016, 9:34 p.m., Barry Oglesby wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42977/
> ---
> 
> (Updated Jan. 29, 2016, 9:34 p.m.)
> 
> 
> Review request for geode, Dan Smith and xiaojian zhou.
> 
> 
> Bugs: GEODE-875
> https://issues.apache.org/jira/browse/GEODE-875
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-875: CI failure: 
> ParallelGatewaySenderOperationsOffHeapDUnitTest.testParallelGatewaySender_SingleNode_UserPR_localDestroy_SimultenuousPut_RecreateRegion
> 
> - deleted 
> testParallelGatewaySender_SingleNode_UserPR_localDestroy_SimultenuousPut_RecreateRegion
>  (useless test)
> - removed all methods from ParallelGatewaySenderOperationsDUnitTest that are 
> similar to ConcurrentParallelGatewaySenderOperation_2_DUnitTest
> - extended ConcurrentParallelGatewaySenderOperation_2_DUnitTest with 
> ParallelGatewaySenderOperation_2_DUnitTest for these removed methods with 
> overridden implementations of createSender and createSenders
> - extended ConcurrentParallelGatewaySenderOperation_2_DUnitTest with 
> ConcurrentParallelGatewaySenderOperation_2_OffHeapDUnitTest with overridden 
> implementation of isOffHeap
> - extended ParallelGatewaySenderOperation_2_DUnitTest with 
> ParallelGatewaySenderOperation_2_OffHeapDUnitTest with overridden 
> implementation of isOffHeap
> 
> 
> Diffs
> -
> 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
>  a212baa68b05e6fae3262f582340e71b1a7e69a5 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java
>  694fc1f93d8fdccaf02abe11d2b780d8d12a1c07 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/ConcurrentParallelGatewaySenderOperation_2_OffHeapDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/ParallelGatewaySenderOperation_2_OffHeapDUnitTest.java
>  PRE-CREATION 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderOperation_2_DUnitTest.java
>  PRE-CREATION 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderOperationsDUnitTest.java
>  19f6c4bf559b9238f369aaa06c4b8594a3439497 
> 
> Diff: https://reviews.apache.org/r/42977/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Barry Oglesby
> 
>

Re: Review Request 43016: GEODE-869 / 883

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43016/#review117175
---


Ship it!




Others look good. I only have one question: In your diff, you did not remove 
"testOutput {...}" section from open/build.gradle. We still need it?

- xiaojian zhou


On Jan. 30, 2016, 5:45 p.m., Anthony Baker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43016/
> ---
> 
> (Updated Jan. 30, 2016, 5:45 p.m.)
> 
> 
> Review request for geode, Dick Cavender, Kirk Lund, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-883: Reorganize code in gemfire-junit
> 
> Move the code from src/test to src/main so that dependenct projects
> can use the junit annotations and rules.  Update build dependencies
> from provided 'testOutput' to testCompile.
> 
> 
> GEODE-869: Include the source NOTICE in jar artifacts
> 
> 
> Diffs
> -
> 
>   gemfire-assembly/build.gradle 3b2594c2d7207e1d741c3f7eb4671b88576688a2 
>   gemfire-common/build.gradle e28ba445104f3ca337756236a6ad6c4264c753de 
>   gemfire-core/build.gradle 719435017aaa24168bb70e1a2e329cd4987a473f 
>   gemfire-cq/build.gradle 35ee0fa543751a4d412c2b35fa675bbbece4187a 
>   gemfire-junit/build.gradle PRE-CREATION 
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/ConditionalIgnore.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/IgnoreCondition.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/IgnoreUntil.java  
>   gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/Repeat.java  
>   gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/Retry.java  
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/ContainerTest.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/DistributedTest.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/DistributedTransactionsTest.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/HydraTest.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/IntegrationTest.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/PerformanceTest.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/UITest.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/UnitTest.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/WanTest.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/ConditionalIgnoreRule.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/ExpectedTimeout.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/ExpectedTimeoutRule.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/IgnoreUntilRule.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/RepeatRule.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/RetryRule.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/SerializableExternalResource.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/SerializableRuleChain.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/SerializableTemporaryFolder.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/SerializableTestName.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/SerializableTestRule.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/SerializableTestWatcher.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/SerializableTimeout.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/support/DefaultIgnoreCondition.java
>   
>   
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/support/IgnoreConditionEvaluationException.java
>   
>   gemfire-lucene/build.gradle 6218e55c73f771a46a74ae31606ce1ace5b2008f 
>   gemfire-pulse/build.gradle 3d694e580c49961ae94e4db086d0f50c9bd81a50 
>   gemfire-rebalancer/build.gradle 1f9bff8d7d37700627ca1b6e8aa74827d59b76d4 
>   gemfire-wan/build.gradle 35ee0fa543751a4d412c2b35fa675bbbece4187a 
>   gemfire-web/build.gradle 596590b1c96e016e2dd927a21dc50d2e373b62b2 
>   gradle/java.gradle 3ec105d7a37fd036527ea6f78c61f7dbcca3244d 
> 
> Diff: https://reviews.apache.org/r/43016/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Baker
> 
>

Re: Review Request 43129: GEODE-898: Fixing a race in SerialWANStatsDUnitTest

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43129/#review117577
---


Ship it!




Ship It!

- xiaojian zhou


On Feb. 3, 2016, 1:51 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43129/
> ---
> 
> (Updated Feb. 3, 2016, 1:51 a.m.)
> 
> 
> Review request for geode, Barry Oglesby and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> testSerialPropegationConflation was a pausing a sender, but not waiting
> for it to pause. It's possible some events could be sent while the pause
> was in progress.
> 
> 
> Diffs
> -
> 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANStatsDUnitTest.java
>  a142f82fbee1ffd2dd33de7c38cb07a5c618f776 
> 
> Diff: https://reviews.apache.org/r/43129/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Review Request 43227: if wan event retry caused the verstion tag is not created, do not distribute the event

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43227/
---

Review request for geode and Dan Smith.


Bugs: GEODE-774
https://issues.apache.org/jira/browse/GEODE-774


Repository: geode


Description
---

The GEODE-774's fix is enhanced. It will distribute when concurrentCheck is not 
enabled. 
And add junit test for both virtualPut and basicDestroy


Diffs
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java
 46c2eb3 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java
 98e72bd 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java
 fae381f 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java
 92b585a 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java
 9cf2f13 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
 256e293 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/BucketRegionJUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/43227/diff/


Testing
---

precheckin

Following BTs are running:
legacyDunit/batterytest.bt ;
smokeTest/batterytest.bt
newWan/newwanSanity.bt ;
newWan/newWanRebalance.bt ;
newWan/newWanEviction.bt
newWan/dispatcherthreads/queuePersist.bt;
newWan/dispatcherthreads/newWanDispatcherThreads.bt;
versioning/newWan/wanVersioning.bt;
newWan/newWanSenderOperations.bt;
newWan/wanParallelP2P.bt;
newWan/newWanSerialParReg.bt;
newWan/newWanParallelParReg.bt;
newWan/newWan.bt;
newWan/newWanBasic.bt;
newWan/newWanParRegHA.bt
parReg/parReg.bt
parReg/parRegHA.bt
parReg/parRegBridgePersist.bt
parReg/parRegHABridgePersist.bt


Thanks,

xiaojian zhou

Re: Review Request 43655: Not including gradle generated directories in the source distribution

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43655/#review119517
---


Ship it!




Ship It!

- xiaojian zhou


On Feb. 17, 2016, 6:32 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43655/
> ---
> 
> (Updated Feb. 17, 2016, 6:32 p.m.)
> 
> 
> Review request for geode, Anthony Baker and Mark Bretl.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Our nightly jenkins job builds a source distribution. But because it's
> set to use the current directory as the gradle home, gradle puts some
> files in the current directory that are then getting added to the
> nightly source distribution.
> 
> 
> Diffs
> -
> 
>   gemfire-assembly/build.gradle 72e97c5fcb20108f3e23bb1e856bf839ba9edd68 
> 
> Diff: https://reviews.apache.org/r/43655/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 43674: GEODE-969: Decreases WAN dunit log file size

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43674/#review119533
---


Ship it!




Ship It!

- xiaojian zhou


On Feb. 17, 2016, 8:44 p.m., Barry Oglesby wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43674/
> ---
> 
> (Updated Feb. 17, 2016, 8:44 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-969: Decreases WAN dunit log file size
> 
> Before these changes, the 
> ParallelWANPersistenceEnabledGatewaySenderOffHeapDUnitTest log file was 87MB, 
> 110MB, 325MB and 556MB.
> After these changes, the 
> ParallelWANPersistenceEnabledGatewaySenderOffHeapDUnitTest log file is 
> consistently ~17MB.
> 
> All of the GII messages noted in the bug are gone.
> 
> 
> Diffs
> -
> 
>   
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
>  17afcbbbcda4f863091309b63861b6ad268bffa4 
> 
> Diff: https://reviews.apache.org/r/43674/diff/
> 
> 
> Testing
> ---
> 
> ParallelWANPersistenceEnabledGatewaySenderOffHeapDUnitTest
> 
> 
> Thanks,
> 
> Barry Oglesby
> 
>

Review Request 44118: add more junt tests case to BucketRegionJUnitTest and introduce DistributedRegionJUnitTest

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44118/
---

Review request for geode and Dan Smith.


Repository: geode


Description
---

add case for afterInvalidate() and updateEntryVersion()
add DistributedRegionJUnitTest

refactor BucketRegonJUnitTest to be a subclass of DistributedRegionJUnitTest


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java 
69f61c4 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java
 021eba6 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/BucketRegionJUnitTest.java
 b2623fb 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/DistributedRegionJUnitTest.java
 PRE-CREATION 
  geode-core/src/test/java/com/gemstone/gemfire/test/fake/Fakes.java ffb4896 

Diff: https://reviews.apache.org/r/44118/diff/


Testing
---

junit tests


Thanks,

xiaojian zhou

Fwd: A shareable template to write mock-based junit test for gemfire legacy classes

[Xiaojian Zhou]

-- Forwarded message --
From: Xiaojian Zhou 
Date: Fri, Feb 26, 2016 at 5:31 PM
Subject: A shareable template to write mock-based junit test for gemfire
legacy classes
To: gemfire-dev 


Hi,

We've just added a chapter "Using Mockito to test region class" in
https://cwiki.apache.org/confluence/display/GEODE/Tips+and+Tricks+for+fixing+DUnit+test+failures
.

It introduced a template and 2 examples on how to write junit test for
DistributedRegion and BucketRegion.

The code can be shared and reused. More contributions are welcome.

Regards
Gester

Review Request 44306: shadowPR's entries do not have version tag

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44306/
---

Review request for geode and Dan Smith.


Bugs: GEODE-1042
https://issues.apache.org/jira/browse/GEODE-1042


Repository: geode


Description
---

shadowPR's entries do not have version tag, FetchEntriesMessage should check 
the versionTag==null in processChunk.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java
 0342164 

Diff: https://reviews.apache.org/r/44306/diff/


Testing
---

precheckin
the failed test itself


Thanks,

xiaojian zhou

Review Request 44412: specify logLevel in command line of geode for running dunit test

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44412/
---

Review request for geode, anilkumar gingade and Dan Smith.


Bugs: geode-1052
https://issues.apache.org/jira/browse/geode-1052


Repository: geode


Description
---

Need to tell the gradle of the commandline property. Then let gradle to tell 
the dunit test.


Diffs
-

  
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java
 65224e8 
  gradle/test.gradle d8af4ba 

Diff: https://reviews.apache.org/r/44412/diff/


Testing
---

precheckin and some dunit tests


Thanks,

xiaojian zhou

Review Request 44540: add junit test for procesChunk of FetchEntriesMessage

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44540/
---

Review request for geode and Dan Smith.


Bugs: geode-1042
https://issues.apache.org/jira/browse/geode-1042


Repository: geode


Description
---

Fix in geode-1042 modified procesChunk(). Add a junit test to cover the code 
changes.


Diffs
-

  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 
b6d8c49 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java
 fda15c4 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessageJUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/44540/diff/


Testing
---


Thanks,

xiaojian zhou

Review Request 44601: revoke the unnecessary code change in DistributedTestCase which caused side-effect

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44601/
---

Review request for geode and Dan Smith.


Bugs: GEODE-589
https://issues.apache.org/jira/browse/GEODE-589


Repository: geode


Description
---

The fix for GEODE-1052 on DistributedTestCase.java is unnecessary and it caused 
other tests fail.

Revoke this part.


Diffs
-

  
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java
 1203570 

Diff: https://reviews.apache.org/r/44601/diff/


Testing
---


Thanks,

xiaojian zhou

Review Request 45336: GEODE-920: Not to create CCN for gateway receiver

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45336/
---

Review request for geode, anilkumar gingade and Dan Smith.


Bugs: GEM-454, GEM-525 and GEODE-920
https://issues.apache.org/jira/browse/GEM-454
https://issues.apache.org/jira/browse/GEM-525
https://issues.apache.org/jira/browse/GEODE-920


Repository: geode


Description
---

It's both GEODE-920, GEM-454, GEM-525.

If gateway receiver is created before cache server, the notify subscriptions 
attributes can never been set, since CCN singleton is created by the gateway 
receiver.

The easy fix is not to let gateway receiver create the CCN singleton.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java
 34e3855 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HAContainerRegion.java
 8803c32 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java
 9f18f50 
  
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45336/diff/


Testing
---

- introduced new dunit test.
- precheckin
- regression tests:


Thanks,

xiaojian zhou

Re: Review Request 45336: GEODE-920: Not to create CCN for gateway receiver

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45336/
---

(Updated April 1, 2016, 12:37 a.m.)


Review request for geode, anilkumar gingade and Dan Smith.


Changes
---

This is a new fix based on a new idea. 

The CCN will  be created by even the gateway receiver. However, the haContainer 
will be kept null and wait for real cache server to initialize it.


Bugs: GEM-454, GEM-525 and GEODE-920
https://issues.apache.org/jira/browse/GEM-454
https://issues.apache.org/jira/browse/GEM-525
https://issues.apache.org/jira/browse/GEODE-920


Repository: geode


Description
---

It's both GEODE-920, GEM-454, GEM-525.

If gateway receiver is created before cache server, the notify subscriptions 
attributes can never been set, since CCN singleton is created by the gateway 
receiver.

The easy fix is not to let gateway receiver create the CCN singleton.


Diffs (updated)
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java
 9bd3faf 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 
95616fe 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HAContainerRegion.java
 3bed769 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java
 5b20e86 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java
 6ac4690 
  
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45336/diff/


Testing
---

- introduced new dunit test.
- precheckin
- regression tests:


Thanks,

xiaojian zhou

Re: Review Request 45336: GEODE-920: Not to create CCN for gateway receiver

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45336/
---

(Updated April 1, 2016, 10:11 p.m.)


Review request for geode, anilkumar gingade and Dan Smith.


Changes
---

fix based on anil's comments


Bugs: GEM-454, GEM-525 and GEODE-920
https://issues.apache.org/jira/browse/GEM-454
https://issues.apache.org/jira/browse/GEM-525
https://issues.apache.org/jira/browse/GEODE-920


Repository: geode


Description
---

It's both GEODE-920, GEM-454, GEM-525.

If gateway receiver is created before cache server, the notify subscriptions 
attributes can never been set, since CCN singleton is created by the gateway 
receiver.

The easy fix is not to let gateway receiver create the CCN singleton.


Diffs (updated)
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java
 9bd3faf 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 
8e30a7a 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HAContainerRegion.java
 3bed769 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java
 6ac4690 
  
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45336/diff/


Testing
---

- introduced new dunit test.
- precheckin
- regression tests:


Thanks,

xiaojian zhou

Re: Review Request 45880: Added Lucene Index creation on RR expects exception test. Minor refactoring

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45880/#review128143
---


Ship it!




No need to change "root" region to PR. But it's ok either way.

It's good.

- xiaojian zhou


On April 7, 2016, 5:22 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45880/
> ---
> 
> (Updated April 7, 2016, 5:22 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added a test that expects unsupported exception when creating a lucene index 
> on replicated region
> 
> Instead of a sleep/wait, instead will use awaitility to wait until async 
> queue size is 0.  The todo to flush the queue instead is still there and 
> should be easy to replace the awaitility call
> 
> Removed the createBasicCache code and merged it with getCache() (This will 
> hopefully remove any chance to accidently createBasicCache and then call 
> getCache() and end up with two caches).  
> 
> getCache() and getService() will now return the cache and luceneservice.
> 
> renamed a test to be slightly more descriptive.  createRegionFirst() to 
> cannotCreateLuceneIndexAfterRegionHasBeenCreated()
> 
> removed dead code on else block where a root region was being created even 
> though it was not supposed to be and it was also not being used.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAJUnitTest.java
>  405c986 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java
>  159fd46 
> 
> Diff: https://reviews.apache.org/r/45880/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Review Request 46065: clean up the lucene index support code for RR

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46065/
---

Review request for geode and Dan Smith.


Bugs: geode-1212
https://issues.apache.org/jira/browse/geode-1212


Repository: geode


Description
---

The objective is:
1) If tried to create LuceneIndex on a replicated region, should throw 
UnsupportedOperationException
2) No API to mislead user to create index on replicated region
3) add test case to verify

I did not remove the class LuceneIndexForReplicatedRegion, since it has 
implemented to throw UnsupportedOperationException for all its methods. This is 
also an option.


Diffs
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
 7002567 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneQueryImplJUnitTest.java
 3975ac3 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java
 159fd46 

Diff: https://reviews.apache.org/r/46065/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 46065: clean up the lucene index support code for RR

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46065/
---

(Updated April 12, 2016, 6:30 a.m.)


Review request for geode and Dan Smith.


Changes
---

update based on comments


Bugs: geode-1212
https://issues.apache.org/jira/browse/geode-1212


Repository: geode


Description
---

The objective is:
1) If tried to create LuceneIndex on a replicated region, should throw 
UnsupportedOperationException
2) No API to mislead user to create index on replicated region
3) add test case to verify

I did not remove the class LuceneIndexForReplicatedRegion, since it has 
implemented to throw UnsupportedOperationException for all its methods. This is 
also an option.


Diffs (updated)
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
 7002567 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java
 1a5dd1a 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneQueryImplJUnitTest.java
 3975ac3 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java
 159fd46 

Diff: https://reviews.apache.org/r/46065/diff/


Testing
---


Thanks,

xiaojian zhou

Re: [VOTE] RC2: Apache Geode (Incubating) second Milestone release - v1.0.0-incubating.M2

[Xiaojian Zhou]

+1

On Wed, Apr 13, 2016 at 3:55 PM, Dan Smith  wrote:

> This is second release candidate for Apache Geode, version
> 1.0.0-incubating.M1.
>
> *** Please download, test and vote by Monday, Apr 18, 0800 PST
>
> If you are wondering why you didn't see RC1, it's because I caught a
> mistake after I created the tag but before sending out the vote. Thanks for
> all the hard work going into this milestone!
>
> It fixes the following issues:
>
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420&version=12334709
>
> Note that we are voting upon the source (tag):
> rel/v1.0.0-incubating.M2.RC2
>
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M2.RC2
>
> Commit ID: 3ac74a4e2c72677ef7c85df77922c645c7cce598
>
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=commit;h=3ac74a4e2c72677ef7c85df77922c645c7cce598
>
> Source and binary files:
>
>
> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0-incubating.M2.RC2/
> <
> https://repository.apache.org/content/repositories/snapshots/org/apache/geode
> >
>
> Maven staging repo:
>
> https://repository.apache.org/content/repositories/orgapachegeode-1004/
> 
>
> Geode's KEYS file containing PGP keys we use to sign the release:
>
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=blob_plain;f=KEYS;hb=refs/heads/release/1.0.0-incubating.M2
> Release Key: pub   4096R/A1688D97 2016-01-20
> Fingerprint: 1776 0439 68F0 FD83 62C7  2CCF 444C 1D20 A168 8D97
>
> Thanks,
> Dan Smith
>

Re: Review Request 46239: UnitTest for LuceneIndexForPartitionedRegion

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46239/#review129067
---


Ship it!




Ship It!

- xiaojian zhou


On April 15, 2016, 12:16 a.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46239/
> ---
> 
> (Updated April 15, 2016, 12:16 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Not sure if this is needed at this point, but with this new unit test it gets 
> slightly more coverage in a fraction of the time (takes 2 seconds on my 
> laptop for 18 tests) it takes to run LuceneServiceImplJUnitTest (9 seconds 
> for 5 tests).  None of the cache calls are on a real cache so that gives some 
> speed savings, although as you can see, the difference is only in seconds at 
> this point.
> 
> Allows ability to test that double initialize calls do not invoke multiple 
> file region creates (which may have been hard to test before or is this case 
> even possible?)
> 
> refactored LuceneIndexForPartitionRegion so that a unit test for it could 
> test specific units, but also allowing tests for initialize() to be stubbed 
> out.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  25b63a4 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46239/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 46464: GEODE-1266: Removed Pivotal license header and also minor clean up

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46464/#review129846
---


Ship it!




Ship It!

- xiaojian zhou


On April 21, 2016, 12:17 a.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46464/
> ---
> 
> (Updated April 21, 2016, 12:17 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Removed unused import
> Removed debug logging
> 
> 
> Diffs
> -
> 
>   
> geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/RemoteCQTransactionDUnitTest.java
>  d617474 
> 
> Diff: https://reviews.apache.org/r/46464/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 46463: GEODE-1188: Lucene indexes can be created with partition redundant regions

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46463/#review129848
---


Ship it!




Ship It!

- xiaojian zhou


On April 20, 2016, 11:57 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46463/
> ---
> 
> (Updated April 20, 2016, 11:57 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added a test to test against all partition region types, not including proxy 
> types.  
> When specific partition region types need more robust/specific asserts, we 
> can add a specific test for that type and eventually remove this test if/when 
> all types are covered.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  4145459 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java
>  a85e617 
> 
> Diff: https://reviews.apache.org/r/46463/diff/
> 
> 
> Testing
> ---
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Review Request 46625: when there're multiple cache servers on the same jvm, keep the first proxy for the each client

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46625/
---

Review request for geode and anilkumar gingade.


Bugs: GEODE-1183
https://issues.apache.org/jira/browse/GEODE-1183


Repository: geode


Description
---

Current API allows us to create 2 cache servers on the same JVM, then the client
will try to create 2 queues to that JVM, one secondary and one primary.
But the proxy is actually the same (since there's only one client), so the
CCN keeps destroying and recreating the proxy.

To fix, we will keep the first proxy and reject the duplicate creating.
Then the secondary proxy will automatically become primary.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java
 1ba2294 
  
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java
 8bf819c 

Diff: https://reviews.apache.org/r/46625/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 46625: when there're multiple cache servers on the same jvm, keep the first proxy for the each client

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46625/
---

(Updated April 29, 2016, 4:04 p.m.)


Review request for geode and anilkumar gingade.


Changes
---

implemented review comments. 

add test for durable client.


Bugs: GEODE-1183
https://issues.apache.org/jira/browse/GEODE-1183


Repository: geode


Description
---

Current API allows us to create 2 cache servers on the same JVM, then the client
will try to create 2 queues to that JVM, one secondary and one primary.
But the proxy is actually the same (since there's only one client), so the
CCN keeps destroying and recreating the proxy.

To fix, we will keep the first proxy and reject the duplicate creating.
Then the secondary proxy will automatically become primary.


Diffs (updated)
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java
 1ba2294 
  
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java
 8bf819c 
  
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/46625/diff/


Testing
---


Thanks,

xiaojian zhou

Review Request 47004: a quick solution to wait for entry flushed into index

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47004/
---

Review request for geode and Dan Smith.


Bugs: geode-1351
https://issues.apache.org/jira/browse/geode-1351


Repository: geode


Description
---

This is for test purpose.

An advanced version will be implemented later using function execution.


Diffs
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java
 58a9b20 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java
 c467a18 

Diff: https://reviews.apache.org/r/47004/diff/


Testing
---


Thanks,

xiaojian zhou

Review Request 47046: The test code needs to be enhanced

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47046/
---

Review request for geode and Dan Smith.


Bugs: geode-1183
https://issues.apache.org/jira/browse/geode-1183


Repository: geode


Description
---

The test code is not mature enough. Sometimes it will fail when the primary is 
not yet setPrimary().


Diffs
-

  
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java
 684660b 

Diff: https://reviews.apache.org/r/47046/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 47046: The test code needs to be enhanced

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47046/
---

(Updated May 5, 2016, 11:58 p.m.)


Review request for geode and Dan Smith.


Changes
---

a new version of fix


Bugs: geode-1183
https://issues.apache.org/jira/browse/geode-1183


Repository: geode


Description
---

The test code is not mature enough. Sometimes it will fail when the primary is 
not yet setPrimary().


Diffs (updated)
-

  
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java
 684660b 

Diff: https://reviews.apache.org/r/47046/diff/


Testing
---


Thanks,

xiaojian zhou

Review Request 47083: transfer the system property for log4j from gradle to unit test framework

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47083/
---

Review request for geode and Dan Smith.


Bugs: geode-1360
https://issues.apache.org/jira/browse/geode-1360


Repository: geode


Description
---

The gradle need to accept the system property and send to test framework.

The test framework should accept the system property log4j.configurationFile


Diffs
-

  
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java
 be459b9 
  
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java
 dd532c4 
  gradle/test.gradle 2dd7521 

Diff: https://reviews.apache.org/r/47083/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 47083: transfer the system property for log4j from gradle to unit test framework

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47083/
---

(Updated May 10, 2016, 12:37 a.m.)


Review request for geode and Dan Smith.


Changes
---

fixed the bug in ProcessManager


Bugs: geode-1360
https://issues.apache.org/jira/browse/geode-1360


Repository: geode


Description
---

The gradle need to accept the system property and send to test framework.

The test framework should accept the system property log4j.configurationFile


Diffs (updated)
-

  
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java
 0c294ec 
  
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java
 dd532c4 
  gradle/test.gradle 2dd7521 

Diff: https://reviews.apache.org/r/47083/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 47148: GEODE-11: Adding package level javadocs for lucene

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47148/#review132530
---


Ship it!




Ship It!

- xiaojian zhou


On May 10, 2016, 1:13 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47148/
> ---
> 
> (Updated May 10, 2016, 1:13 a.m.)
> 
> 
> Review request for geode, Barry Oglesby, William Markito, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding package-info.java files to all of the lucene packages. The public
> API javadocs provide and overview of the what the lucene package does
> and where to start.
> 
> The internal javadocs provide an overview of the purpose of each
> internal package.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/package-info.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/distributed/package-info.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystem.java
>  44513f19553060f356d9ddbdbc497b1550b7b1d3 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/package-info.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/package-info.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/package-info.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/package-info.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/package-info.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/package-info.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Review Request 47220: This is bug in test code

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47220/
---

Review request for geode and anilkumar gingade.


Bugs: geode-1344
https://issues.apache.org/jira/browse/geode-1344


Repository: geode


Description
---

There're more than one thread that are try to connect and create proxy for 
durable client. It's possible that the reinitialize() is called more than once. 
But it should be at least once. 

I did not change the product code for durable client. It's my test code used 
wrong expectation.


Diffs
-

  
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java
 4fdd88d 

Diff: https://reviews.apache.org/r/47220/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 47220: This is bug in test code

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47220/
---

(Updated May 11, 2016, 8:04 p.m.)


Review request for geode and anilkumar gingade.


Changes
---

Fix the durable client, not to reinitialize() a primary proxy.


Bugs: geode-1344
https://issues.apache.org/jira/browse/geode-1344


Repository: geode


Description (updated)
---

There're more than one thread that are try to connect and create proxy for 
durable client. It's possible that the reinitialize() is called more than once. 
But it should be at least once.


Diffs (updated)
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java
 80d05ba 
  
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java
 4fdd88d 

Diff: https://reviews.apache.org/r/47220/diff/


Testing
---


Thanks,

xiaojian zhou

Review Request 47254: GEODE-1183: when there're 2 cacheserver on the same jvm, it will keep recreating or reinitializing the proxy

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47254/
---

Review request for geode, anilkumar gingade, Barry Oglesby, and Bruce 
Schuchardt.


Bugs: geode-1183
https://issues.apache.org/jira/browse/geode-1183


Repository: geode


Description
---

I found this bug in my test using 2 cache servers in one JVM. Our API allows 
user to do that. 

We had a lot of dicussion with anil and barry. However, we think it's better to 
invite people from jgroup team to review the fix too. 

When created 2 cache servers (server1 and server2) on the same JVM and turned 
on subscription, the client handshake will try to create a secondary on server1 
then primary on server2. 

However, when creating primary proxy on server2, it found the proxy already 
exists (i.e. the one for secondary). So our current code will delete the 
existing proxy and create a new one (if it's durable client, it will 
reinitialize). 

But the deletion will trigger the handshake thread to retry, recreate and 
delete the exiting one. It will keep doing that endlessly. According to my 
test, within one minute, there're hundreds of recreating. 

The fix is not to delete the "stale proxy" for normal client if its socket is 
still connecting.
Not to reinitialize the proxy if it's primary in case of durable client.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java
 1ba2294 
  
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java
 9557f0d 
  
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47254/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 47327: Fixing compile errors in eclipse

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47327/#review133008
---


Ship it!




You also fixed the 2 lines (one for classes, one for resources) in tomcat7. 
That's good.

- xiaojian zhou


On May 13, 2016, 12:14 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47327/
> ---
> 
> (Updated May 13, 2016, 12:14 a.m.)
> 
> 
> Review request for geode, Jens Deppe, Mark Bretl, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> We were seeing compile errors in eclipse due to:
> 1) Missing gradle output dirs in the extensions module. I removed those
> dirs from the eclipse classpath
> 
> 2) Access restrictions on things like Unsafe. This was caused by a
> change in gradle 2.12 to add the java 1.8 execution environment, rather
> than the direct JDK dependency, to the project. That turned on access
> restrictions in eclipse for  the execution environment.
> 
> 
> Diffs
> -
> 
>   extensions/geode-modules-tomcat7/build.gradle 
> 975c97672f2264d8fca75ae1d91934abc9e27180 
>   gradle/ide.gradle adaf8d98fcaf933c06b5acc2977ca5d37f3b1614 
> 
> Diff: https://reviews.apache.org/r/47327/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 47004: a quick solution to wait for entry flushed into index

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47004/
---

(Updated May 16, 2016, 5:39 a.m.)


Review request for geode, anilkumar gingade and Dan Smith.


Changes
---

apply reviewer's comments, added junit test and dunit tests


Bugs: geode-1351
https://issues.apache.org/jira/browse/geode-1351


Repository: geode


Description
---

This is for test purpose.

An advanced version will be implemented later using function execution.


Diffs (updated)
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListener.java
 9fdfd43 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java
 0b5f8fa 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java
 c467a18 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImplJUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47004/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 47004: a quick solution to wait for entry flushed into index

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47004/
---

(Updated May 16, 2016, 9:58 p.m.)


Review request for geode, anilkumar gingade and Dan Smith.


Changes
---

let it return a boolean and use it in a few test cases


Bugs: geode-1351
https://issues.apache.org/jira/browse/geode-1351


Repository: geode


Description
---

This is for test purpose.

An advanced version will be implemented later using function execution.


Diffs (updated)
-

  geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/LuceneIndex.java 
be329f7 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java
 981d9e4 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java
 b54f51b 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationIntegrationTest.java
 6429143 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java
 77d2a5c 

Diff: https://reviews.apache.org/r/47004/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 47503: GEODE-357: Remove third server from testInitiateFailoverByCacheOperationThreads_Secondary

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47503/#review133694
---


Ship it!




Ship It!

- xiaojian zhou


On May 17, 2016, 11:58 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47503/
> ---
> 
> (Updated May 17, 2016, 11:58 p.m.)
> 
> 
> Review request for geode and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This test was intermittently connecting to either 2 servers or 3. If the
> test never connected to the third server, it would fail waiting for the
> live server count to be 2.
> 
> Also cleaned up some code to use Awaitility and to have a lower ping
> interval, because the ping is what causes us to disconnect from the
> stopped server.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAStartupAndFailoverDUnitTest.java
>  13f2527b92088ba0c87021f07a81657315aef396 
> 
> Diff: https://reviews.apache.org/r/47503/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Review Request 47712: test perfield analyzer

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47712/
---

Review request for geode and Dan Smith.


Bugs: GEODE-1352
https://issues.apache.org/jira/browse/GEODE-1352


Repository: geode


Description
---

designed a lot cases to test query syntax related with analyzer


Diffs
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java
 1e2b63d 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java
 e589ef4 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/HeterogeneousLuceneSerializer.java
 a0319f4 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxLuceneSerializer.java
 c5c55a9 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java
 953f31f 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIntegrationTest.java
 c302460 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java
 15f5747 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java
 571049c 

Diff: https://reviews.apache.org/r/47712/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 47712: test perfield analyzer

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47712/
---

(Updated May 23, 2016, 6:22 a.m.)


Review request for geode and Dan Smith.


Changes
---

fixed a few more junit tests


Bugs: GEODE-1352
https://issues.apache.org/jira/browse/GEODE-1352


Repository: geode


Description
---

designed a lot cases to test query syntax related with analyzer


Diffs (updated)
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java
 1e2b63d 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java
 e589ef4 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/HeterogeneousLuceneSerializer.java
 a0319f4 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxLuceneSerializer.java
 c5c55a9 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java
 953f31f 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIntegrationTest.java
 c302460 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java
 15f5747 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProviderJUnitTest.java
 dded69c 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java
 70ec434 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java
 571049c 

Diff: https://reviews.apache.org/r/47712/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 47675: GEODE-1389, GEODE-1012: Cleaning up some persistence tests in LuceneIndexRecoveryHAIntegrationTest

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47675/#review134436
---


Ship it!




Ship It!

- xiaojian zhou


On May 20, 2016, 10:18 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47675/
> ---
> 
> (Updated May 20, 2016, 10:18 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, and 
> xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> There were two tests in LuceneIndexRecoveryHAIntegrationTest that used
> disk resources. Moved the overflow test too a LuceneQueriesPersistence
> suite, where it will be cleaned up by the DiskRule.
> 
> The recovery test was pretty much the same as an existing test in
> LuceneIndexCreationPersistent.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationPersistenceIntegrationTest.java
>  96b4e93eee313ae98fe9af6463b6e9fc3a7b35c3 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPersistenceIntegrationTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java
>  d32e6d858b1ee0599f257d5866635c38e0f9946c 
> 
> Diff: https://reviews.apache.org/r/47675/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Review Request 47803: field value could be null, need to handle this case

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47803/
---

Review request for geode and Dan Smith.


Bugs: GEODE-1453
https://issues.apache.org/jira/browse/GEODE-1453


Repository: geode


Description
---

The field value could be null, when creating index, we need to handle it.


Diffs
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxLuceneSerializer.java
 3990614 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java
 a76478c 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java
 4ebb9c4 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxFieldMapperJUnitTest.java
 278e818 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionFieldMapperJUnitTest.java
 c187022 

Diff: https://reviews.apache.org/r/47803/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 47908: GEODE-1460 RemoveAll fails with NPE in com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47908/#review135020
---




geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java
 (line 86)
<https://reviews.apache.org/r/47908/#comment28>

You should get rid of "synchronized" on the methods.

Others look good. 

Fit it and ship it.


- xiaojian zhou


On May 26, 2016, 5:23 p.m., Jianxia Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47908/
> ---
> 
> (Updated May 26, 2016, 5:23 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh 
> Khamesra, Udo Kohlmeyer, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Add a lock to synchronize two getInstance methods, so that they return either 
> null ccnSingleton or fully initialized ccnSingleton, i.e. haContainer is not 
> null if it is not gateway receiver.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java
>  80d05ba 
> 
> Diff: https://reviews.apache.org/r/47908/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jianxia Chen
> 
>

Re: Review Request 47911: GEODE-11: Adding a test of queries with redundancy

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47911/#review135037
---


Ship it!




Ship It!

- xiaojian zhou


On May 26, 2016, 6:22 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47911/
> ---
> 
> (Updated May 26, 2016, 6:22 p.m.)
> 
> 
> Review request for geode, Barry Oglesby and nabarun nag.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding a test of distributed queries on PRs with redundancy
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47911/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 47912: GEODE-11: Adding stats for lucene index updates and queries

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47912/#review135044
---




geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java
 (line 92)
<https://reviews.apache.org/r/47912/#comment200025>

I'm concerning about "stats" showed up in many constructor methods. 

The stats object should be keeped in LuceneIndexImpl object, then we use 
index object to reference it in other classes, such as RepositoryManager.


- xiaojian zhou


On May 26, 2016, 6:26 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47912/
> ---
> 
> (Updated May 26, 2016, 6:26 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, 
> nabarun nag, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding some initial stats for lucene indexes tracking updates and queries.
> 
> I haven't yet figured out how to update the documents stat, but I figured I 
> would get the easy stats checked in first. We're tracking updates, commits, 
> and query stats with this change.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  d22ca4a196df3b1a457b56c92da694bdbf792cc2 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java
>  c165085c83b38930bb970ac8f8e3f3fd8aa8808f 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStats.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java
>  57b8862d91cb0b825de27d67ff594c984fc8ca55 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java
>  065cc6a5c2b140a2fb383362d9e8d1316e903e8a 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java
>  194f3c7adfa32d0f2c8e9f18a27a3217d488560c 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStatsJUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java
>  4532d1651845c429bfa2b9f2f4eebf9e6e2bbdb2 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java
>  7bcc7619198c360d0ec3a5d887bb0b2b4a483d8d 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java
>  53c41616042dfe71febe7bc192c74f26f3938203 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java
>  cec76ba0533093c88d653879323acba4e1901c9e 
> 
> Diff: https://reviews.apache.org/r/47912/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 47908: GEODE-1460 RemoveAll fails with NPE in com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47908/#review135067
---


Ship it!




It looks good. 

Just one qestion, do we need to check if haContainer == null in 
HARegionQueue.java?

- xiaojian zhou


On May 26, 2016, 8:34 p.m., Jianxia Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47908/
> ---
> 
> (Updated May 26, 2016, 8:34 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh 
> Khamesra, Udo Kohlmeyer, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Add a lock to synchronize two getInstance methods, so that they return either 
> null ccnSingleton or fully initialized ccnSingleton, i.e. haContainer is not 
> null if it is not gateway receiver.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  62336f0 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java
>  80d05ba 
> 
> Diff: https://reviews.apache.org/r/47908/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jianxia Chen
> 
>

Re: Review Request 48086: GEODE-11: Adding a tool to dump the lucene index files

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48086/#review135709
---




geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java
 (line 49)
<https://reviews.apache.org/r/48086/#comment200756>

This feature will convert Gemfire file into java file for index. It's very 
useful. 

I think we should implement a method "convertToFile()" in LuceneIndexImpl 
to do this function execution. 

Then I can call: 
myIndex.convertToFile(diskDir) without know the detail syntax of 
FunctionService. 

BTW, I think it can be shipped. 

My above suggestion can be done in step2 after checked in current code.


- xiaojian zhou


On May 31, 2016, 7:16 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48086/
> ---
> 
> (Updated May 31, 2016, 7:16 p.m.)
> 
> 
> Review request for geode, Jason Huynh, nabarun nag, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding a function that will dump all of the files for the lucene index
> to disk, for examination with external tools like Luke.
> 
> 
> Diffs
> -
> 
>   
> geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/DiskDirRule.java
>  184619fe2332038b80d4769e88968023f6c55d63 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java
>  1f011a6b8650f98fd42fef71bd1593080fe91379 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFiles.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/File.java
>  2937af54631ed593ca9a5213dbcc6c964895731d 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystem.java
>  fdafcbecfc95ec4bb9e165d7073ebbcd783ca8ae 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepository.java
>  f1e63e096208724b935649f102f37a0be3245822 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java
>  3dbbc9415e176cdc8f0d9d02dc48aa93ddd20d3d 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesJUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemJUnitTest.java
>  1d936ca216bf06550e6ce552bdefa999a3c25a31 
> 
> Diff: https://reviews.apache.org/r/48086/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 48086: GEODE-11: Adding a tool to dump the lucene index files

[Xiaojian Zhou]

It will be even better to provide it as a public API, then the real
implementation could be put into LuceneIndexForPartitionedRegion.

Just be conservative, I suggested to put into LuceneIndexImpl as a internal
API. What I really want is a public API.

On Tue, May 31, 2016 at 4:28 PM, Dan Smith  wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48086/
>
> On May 31st, 2016, 11:01 p.m. UTC, *xiaojian zhou* wrote:
>
>
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java
> <https://reviews.apache.org/r/48086/diff/1/?file=1402210#file1402210line49> 
> (Diff
> revision 1)
>
> 49
>
> ResultCollector resultCollector= FunctionService
>
> This feature will convert Gemfire file into java file for index. It's very 
> useful.
>
> I think we should implement a method "convertToFile()" in LuceneIndexImpl to 
> do this function execution.
>
> Then I can call:
> myIndex.convertToFile(diskDir) without know the detail syntax of 
> FunctionService.
>
> BTW, I think it can be shipped.
>
> My above suggestion can be done in step2 after checked in current code.
>
> Seems like a good suggestion - are you thinking it should be part of the 
> public API (LuceneIndex interface), or just a method on the internal class?
>
>
> - Dan
>
> On May 31st, 2016, 7:16 p.m. UTC, Dan Smith wrote:
> Review request for geode, Jason Huynh, nabarun nag, and xiaojian zhou.
> By Dan Smith.
>
> *Updated May 31, 2016, 7:16 p.m.*
> *Repository: * geode
> Description
>
> Adding a function that will dump all of the files for the lucene index
> to disk, for examination with external tools like Luke.
>
> Diffs
>
>- 
> geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/DiskDirRule.java
>(184619fe2332038b80d4769e88968023f6c55d63)
>- 
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java
>(1f011a6b8650f98fd42fef71bd1593080fe91379)
>- 
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFiles.java
>(PRE-CREATION)
>- 
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/File.java
>(2937af54631ed593ca9a5213dbcc6c964895731d)
>- 
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystem.java
>(fdafcbecfc95ec4bb9e165d7073ebbcd783ca8ae)
>- 
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepository.java
>(f1e63e096208724b935649f102f37a0be3245822)
>- 
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java
>(3dbbc9415e176cdc8f0d9d02dc48aa93ddd20d3d)
>- 
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java
>(PRE-CREATION)
>- 
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesJUnitTest.java
>(PRE-CREATION)
>- 
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemJUnitTest.java
>(1d936ca216bf06550e6ce552bdefa999a3c25a31)
>
> View Diff <https://reviews.apache.org/r/48086/diff/>
>

Re: Review Request 48138: GEODE-11 Adding stats for the lucene file system.

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48138/#review135838
---


Ship it!




Ship It!

- xiaojian zhou


On June 1, 2016, 5:52 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48138/
> ---
> 
> (Updated June 1, 2016, 5:52 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Jason Huynh, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding stats to track changes to the lucene file system.
> 
> This adds the following stats:
> readBytes
> writtenBytes
> fileCreates
> temporaryFileCreates
> fileDeletes
> fileRenames
> 
> Also added a stat for totalHits to the LuceneIndexStats.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  8f2cb10a0dc2d930362473f575042ec25f04c7f2 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java
>  3b58a956857830a55f11fe11ac8a57adb3b53846 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStats.java
>  dab1b0f65c1ff38cd0a2ed09f0a981e82c39552e 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java
>  1b48316e9568f92ce02ca6fa34ebc90228736e63 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectory.java
>  28117bda74f10d8ec5c34707e935a31fadeca6a4 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystem.java
>  5f5218a9050157836e72d64ab5d9d4c7eeeb3346 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStats.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java
>  47e43b54eda9ea185650922a2c41572bce5af059 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java
>  b4de0c53a5cb94380443b44b31d2fc23405e3933 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStatsJUnitTest.java
>  6633f22ea162ee18abfdde837970821178830a5b 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java
>  f0ff7cae3f68fcdb1854e04d920e40818207088c 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectoryJUnitTest.java
>  e8118c538e624e8857579345f5f314ee7c4a10ce 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java
>  4cc2d5cb5cd3682a119e91f64bb4c7a508b8e759 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemJUnitTest.java
>  78bf1de500269d06b6670174883bf268441e126d 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStatsJUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java
>  f2a6bc44b0d19bb9df465c5df336cb5ff64d2e63 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java
>  934998550420cdd900fc59a0dc0f87a80473b4af 
> 
> Diff: https://reviews.apache.org/r/48138/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 48145: GEODE-11: Adding a method to LuceneIndexImpl to dump indexes

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48145/#review135848
---


Ship it!




Ship It!

- xiaojian zhou


On June 1, 2016, 6:34 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48145/
> ---
> 
> (Updated June 1, 2016, 6:34 p.m.)
> 
> 
> Review request for geode and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding a method to LuceneIndexImpl to invoke the DumpDirectoryFiles
> function and dump all of the index files to disk.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/InternalLuceneIndex.java
>  951b0f9eb1fcef187dd57e3379a4f1065e12cef4 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  8f2cb10a0dc2d930362473f575042ec25f04c7f2 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForReplicatedRegion.java
>  c24cb9d8a8da1b6bb9e9f34ad2c8255f2057cdae 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFiles.java
>  0d7b859c51bc2b701b866f87d9ea496a013e1762 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java
>  4ae1efec926b495c99097a467ebcfdd3a2de802e 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java
>  9f02f2b780067e742635e416286969145c8c4862 
> 
> Diff: https://reviews.apache.org/r/48145/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Proposal - provide a callback to compute statistics

[Xiaojian Zhou]

what's the difference btw supplier and sampler?

On Wed, Jun 1, 2016 at 4:12 PM, Dan Smith  wrote:

> Hi,
>
> I'd like to add some new methods to the Statistics interface to compute
> statistics using callbacks. My original motivation for this is to make it
> easy to record statistics that come from lucene for our lucene integration,
> but I think this could simplify recording statistics in a lot of places.
>
> The basic idea is that the user provides a callback that returns the value
> of the statistic. Geode will call the callback every sample interval to
> recompute the value.
>
> See the JIRA for more details:
> https://issues.apache.org/jira/browse/GEODE-1494
>
> Thoughts?
>
> -Dan
>

Re: Review Request 48432: GEODE-1494: Allowing stats to be measured with callbacks

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48432/#review137430
---


Ship it!




Ship It!

- xiaojian zhou


On June 9, 2016, 6:41 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48432/
> ---
> 
> (Updated June 9, 2016, 6:41 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Jason Huynh, 
> Jinmei Liao, Kirk Lund, and nabarun nag.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding support to measure statistics with suppliers that are sampled
> every sample interval. The suppliers are invoked in a separate thread
> than the stat sampler so that slow suppliers won't screw up all stats.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/com/gemstone/gemfire/Statistics.java 
> d7f45a50af7ce58e0d65bfd6300821b36864cc9b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DummyStatisticsImpl.java
>  83d40559ba652474630d04758696f2e9042910e7 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java 
> ebb4177c12f6d67ef2cafb76d7a3d765fb1139ea 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/StatSamplerStats.java 
> c70247939a50392e62e264bfb783a37c93a969ae 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsImpl.java 
> 2344d9315ca8b2b31e9eba35a350eca44a9b8bec 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsTypeImpl.java
>  2a29d46dfc260a40b018af5530a4f1e781e72274 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/CallbackSampler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/SampleCollector.java
>  dfb502bb0aa018a11ab26b10a35da2c5be7c10ac 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/LocalStatisticsImplJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/StatArchiveWriterReaderJUnitTest.java
>  bb15ff2ce747a37d87c95931d5e07cbce4ca7be6 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/StatSamplerJUnitTest.java
>  f2946b619c6272539ba00f10a9fb1444cc095231 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/CallbackSamplerJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/DummyStatistics.java
>  a1ea030443f096ba8f0bd8d5fb62a8183f20bcfd 
> 
> Diff: https://reviews.apache.org/r/48432/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Review Request 48701: add a test to query json object from geode-lucene

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48701/
---

Review request for geode and Dan Smith.


Bugs: GEODE-1545
https://issues.apache.org/jira/browse/GEODE-1545


Repository: geode


Description
---

add a test case


Diffs
-

  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java
 c26997d 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java
 0cf8953 

Diff: https://reviews.apache.org/r/48701/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 48701: add a test to query json object from geode-lucene

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48701/
---

(Updated June 14, 2016, 9:56 p.m.)


Review request for geode and Dan Smith.


Changes
---

updated the fix


Bugs: GEODE-1545
https://issues.apache.org/jira/browse/GEODE-1545


Repository: geode


Description
---

add a test case


Diffs (updated)
-

  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java
 c26997d 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java
 0cf8953 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/TestObject.java
 a2b249e 

Diff: https://reviews.apache.org/r/48701/diff/


Testing
---


Thanks,

xiaojian zhou

Review Request 48965: add a test case to run query on client

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48965/
---

Review request for geode and Dan Smith.


Bugs: GEODE-1572
https://issues.apache.org/jira/browse/GEODE-1572


Repository: geode


Description
---

Query from client should have beeen supported, but we need a test case for it.


Diffs
-

  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneDUnitTest.java
 565ec4f 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java
 26cd4aa 

Diff: https://reviews.apache.org/r/48965/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 48965: add a test case to run query on client

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48965/
---

(Updated June 20, 2016, 8:31 p.m.)


Review request for geode and Dan Smith.


Changes
---

clean up the diff


Bugs: GEODE-1572
https://issues.apache.org/jira/browse/GEODE-1572


Repository: geode


Description
---

Query from client should have beeen supported, but we need a test case for it.


Diffs (updated)
-

  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java
 26cd4aa 

Diff: https://reviews.apache.org/r/48965/diff/


Testing
---


Thanks,

xiaojian zhou

Review Request 49481: summarize the investigation results on numeric field range query into a integration test case

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49481/
---

Review request for geode, anilkumar gingade and Dan Smith.


Bugs: GEODE-11
https://issues.apache.org/jira/browse/GEODE-11


Repository: geode


Description
---

The code case archived following conclusions related with research on range 
query
1) lucene's QueryParser does not work for numeric range query
2) Need a IntPoint.newRangeQuery to do numeric range query for int field. 
Similar for float, double and long fields.
3) If field has 2 values with different types, lucene will throw IAE. 
4) Define a sample implementation for LuceneQueryProvider. This can also be 
used for demo or sample code for customer in the future.


Diffs
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneQueryFactoryImpl.java
 62b4f56 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java
 988e4f5 

Diff: https://reviews.apache.org/r/49481/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Review Request 49772: CI failure: LuceneQueriesClientDUnitTest.entriesFlushedToIndexAfterWaitForFlushCalled

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49772/#review141227
---


Ship it!




Ship It!

- xiaojian zhou


On July 7, 2016, 10:39 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49772/
> ---
> 
> (Updated July 7, 2016, 10:39 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The test was failing on a negative check to make sure the queue actually had 
> contents.  There were cases where the queue could be drained due to the 
> "slowness"/async pausing of the sender.
> 
> I also moved and rewrote this test out from LuceneQueriesBase as I didn't 
> think we needed to test flushing on multiple base region types.  Not sure if 
> commits stat is the correct one to check.  The docs stat was returning 0.
> 
> Also noticed that the pdx -> jsonstring conversion done in 
> LuceneTestUtilities wasn't actually using the converted jsonstring. Instead 
> we could avoid that entire if statement altogether.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java
>  7d7fa3d 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java
>  e817d3b 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java
>  8aca11c 
> 
> Diff: https://reviews.apache.org/r/49772/diff/
> 
> 
> Testing
> ---
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: How to commit the chinese documents to apache geode site?

[Xiaojian Zhou]

Do you mean to publish into geode wiki or check into geode source code?

On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou  wrote:

> Do you mean chinese file name or content in a PDF or text file?
>
> On Tue, Jul 12, 2016 at 3:28 AM, theseusyang 
> wrote:
>
>> Hi All,
>>
>> I have translated some chinese documents about geode installation,
>> deployment,features.
>> Now the main question is that How to put the chinese documents to apache
>> geode site?
>>
>> Does anybody know that?
>>
>> Thank you very much!
>>
>> theseus yang
>>
>>
>>
>> --
>> View this message in context:
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
>> Sent from the Apache Geode (Incubating) Developers Forum mailing list
>> archive at Nabble.com.
>>
>
>

Re: How to commit the chinese documents to apache geode site?

[Xiaojian Zhou]

Do you mean chinese file name or content in a PDF or text file?

On Tue, Jul 12, 2016 at 3:28 AM, theseusyang  wrote:

> Hi All,
>
> I have translated some chinese documents about geode installation,
> deployment,features.
> Now the main question is that How to put the chinese documents to apache
> geode site?
>
> Does anybody know that?
>
> Thank you very much!
>
> theseus yang
>
>
>
> --
> View this message in context:
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
> Sent from the Apache Geode (Incubating) Developers Forum mailing list
> archive at Nabble.com.
>

Re: How to commit the chinese documents to apache geode site?

[Xiaojian Zhou]

You can add a wiki page for geode with chinese characters. I just did some
test.

https://cwiki.apache.org/confluence/display/GEODE/Adding+Gfsh+command+or+parameter

I added some chinese characters into above document.

On Tue, Jul 12, 2016 at 9:33 AM, theseusyang  wrote:

> Yeah, xiaojian.
>
>
>
> 2016-07-12 23:53 GMT+08:00 Xiaojian Zhou [via Apache Geode (Incubating)
> Developers Forum] :
>
> > Do you mean to publish into geode wiki or check into geode source code?
> >
> > On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou <[hidden email]
> > <http:///user/SendEmail.jtp?type=node&node=7128&i=0>> wrote:
> >
> > > Do you mean chinese file name or content in a PDF or text file?
> > >
> > > On Tue, Jul 12, 2016 at 3:28 AM, theseusyang <[hidden email]
> > <http:///user/SendEmail.jtp?type=node&node=7128&i=1>>
> > > wrote:
> > >
> > >> Hi All,
> > >>
> > >> I have translated some chinese documents about geode installation,
> > >> deployment,features.
> > >> Now the main question is that How to put the chinese documents to
> > apache
> > >> geode site?
> > >>
> > >> Does anybody know that?
> > >>
> > >> Thank you very much!
> > >>
> > >> theseus yang
> > >>
> > >>
> > >>
> > >> --
> > >> View this message in context:
> > >>
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
> > >> Sent from the Apache Geode (Incubating) Developers Forum mailing list
> > >> archive at Nabble.com.
> > >>
> > >
> > >
> >
> >
> > --
> > If you reply to this email, your message will be added to the discussion
> > below:
> >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7128.html
> > To unsubscribe from How to commit the chinese documents to apache geode
> > site?, click here
> > <
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=7125&code=dGhlc2V1c3lhbmdAZ21haWwuY29tfDcxMjV8LTExNzY2NDM1NzU=
> >
> > .
> > NAML
> > <
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
> >
> >
>
>
>
>
> --
> View this message in context:
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7134.html
> Sent from the Apache Geode (Incubating) Developers Forum mailing list
> archive at Nabble.com.
>

Re: How to commit the chinese documents to apache geode site?

[Xiaojian Zhou]

If you don't have authority to add the page into geode's wiki, you can send
it to me.

On Tue, Jul 12, 2016 at 9:58 AM, Xiaojian Zhou  wrote:

> You can add a wiki page for geode with chinese characters. I just did some
> test.
>
>
> https://cwiki.apache.org/confluence/display/GEODE/Adding+Gfsh+command+or+parameter
>
> I added some chinese characters into above document.
>
> On Tue, Jul 12, 2016 at 9:33 AM, theseusyang 
> wrote:
>
>> Yeah, xiaojian.
>>
>>
>>
>> 2016-07-12 23:53 GMT+08:00 Xiaojian Zhou [via Apache Geode (Incubating)
>> Developers Forum] :
>>
>> > Do you mean to publish into geode wiki or check into geode source code?
>> >
>> > On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou <[hidden email]
>> > <http:///user/SendEmail.jtp?type=node&node=7128&i=0>> wrote:
>> >
>> > > Do you mean chinese file name or content in a PDF or text file?
>> > >
>> > > On Tue, Jul 12, 2016 at 3:28 AM, theseusyang <[hidden email]
>> > <http:///user/SendEmail.jtp?type=node&node=7128&i=1>>
>> > > wrote:
>> > >
>> > >> Hi All,
>> > >>
>> > >> I have translated some chinese documents about geode installation,
>> > >> deployment,features.
>> > >> Now the main question is that How to put the chinese documents to
>> > apache
>> > >> geode site?
>> > >>
>> > >> Does anybody know that?
>> > >>
>> > >> Thank you very much!
>> > >>
>> > >> theseus yang
>> > >>
>> > >>
>> > >>
>> > >> --
>> > >> View this message in context:
>> > >>
>> >
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125.html
>> > >> Sent from the Apache Geode (Incubating) Developers Forum mailing list
>> > >> archive at Nabble.com.
>> > >>
>> > >
>> > >
>> >
>> >
>> > --
>> > If you reply to this email, your message will be added to the discussion
>> > below:
>> >
>> >
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7128.html
>> > To unsubscribe from How to commit the chinese documents to apache geode
>> > site?, click here
>> > <
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=7125&code=dGhlc2V1c3lhbmdAZ21haWwuY29tfDcxMjV8LTExNzY2NDM1NzU=
>> >
>> > .
>> > NAML
>> > <
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
>> >
>> >
>>
>>
>>
>>
>> --
>> View this message in context:
>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/How-to-commit-the-chinese-documents-to-apache-geode-site-tp7125p7134.html
>> Sent from the Apache Geode (Incubating) Developers Forum mailing list
>> archive at Nabble.com.
>>
>
>