Re: Review Request 25819: post-reviews.py: use --no-color with git log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25819/#review53942 --- Patch looks great! Reviews applied: [25819] All tests passed. - Mesos ReviewBot On Sept. 19, 2014, 5:20 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25819/ --- (Updated Sept. 19, 2014, 5:20 a.m.) Review request for mesos and Ben Mahler. Repository: mesos-git Description --- Force git log to never emit colored output (for setups with colored output enabled by default). For example, the command git --no-pager log --pretty=oneline --reverse master..HEAD should generate output similiar to the following: ``` fa7e46cfc228e9f80e08d7c28a978d561fbba5a7 post-reviews.py: added --no-color to git log. - For setups that have colored output for git log. ``` However, in a setup where git emits colored output, the raw output would look like the following: ``` ^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m post-reviews.py: added --no-color to git log. - For setups that have colored output for git log. ``` The parser in post-review.py then picks '`^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m`' as the sha and crashes. The '--no-color' flag forces git to never emit colored output. Diffs - support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e Diff: https://reviews.apache.org/r/25819/diff/ Testing --- Created this review request using the updated script. Thanks, Kapil Arya
Re: Review Request 25818: Switch path::join() to be variadic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25818/#review53943 --- Bad patch! Reviews applied: [25789, 25818] Failed command: ./support/mesos-style.py Error: Checking 507 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp:29: Lines should be = 80 characters long [whitespace/line_length] [2] Total errors found: 1 - Mesos ReviewBot On Sept. 19, 2014, 5:32 a.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25818/ --- (Updated Sept. 19, 2014, 5:32 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Switch path::join() to be variadic Also fix a bug in strings::trim() where when the string was just characters to be trimmed, nothing would be trimmed. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8df0259a318a9171a9c045a223800e64f47 3rdparty/libprocess/3rdparty/stout/Makefile.am 2ee5a0bcc8bef0a5769dafc8ae54aea284993d6e 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a24d920c809e36a2a3da1810e52d0db101 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 Diff: https://reviews.apache.org/r/25818/diff/ Testing --- make check Thanks, Cody Maloney
Re: Review Request 25818: Switch path::join() to be variadic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25818/ --- (Updated Sept. 19, 2014, 6:59 a.m.) Review request for mesos and Benjamin Hindman. Changes --- Make lines the right length Repository: mesos-git Description --- Switch path::join() to be variadic Also fix a bug in strings::trim() where when the string was just characters to be trimmed, nothing would be trimmed. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8df0259a318a9171a9c045a223800e64f47 3rdparty/libprocess/3rdparty/stout/Makefile.am 2ee5a0bcc8bef0a5769dafc8ae54aea284993d6e 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a24d920c809e36a2a3da1810e52d0db101 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 Diff: https://reviews.apache.org/r/25818/diff/ Testing --- make check Thanks, Cody Maloney
Re: Review Request 25818: Switch path::join() to be variadic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/#review53945
---
Bad patch!
Reviews applied: [25789, 25818]
Failed command: make -j3 distcheck
Error:
make dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
if test -d mesos-0.21.0; then find mesos-0.21.0 -type d ! -perm -200 -exec
chmod u+w {} ';' rm -rf mesos-0.21.0 || { sleep 5 rm -rf
mesos-0.21.0; }; else :; fi
test -d mesos-0.21.0 || mkdir mesos-0.21.0
(cd 3rdparty make top_distdir=../mesos-0.21.0
distdir=../mesos-0.21.0/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd libprocess make top_distdir=../../mesos-0.21.0
distdir=../../mesos-0.21.0/3rdparty/libprocess \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d ../../mesos-0.21.0/3rdparty/libprocess || mkdir
../../mesos-0.21.0/3rdparty/libprocess
(cd 3rdparty make top_distdir=../../../mesos-0.21.0
distdir=../../../mesos-0.21.0/3rdparty/libprocess/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd stout make top_distdir=../../../../mesos-0.21.0
distdir=../../../../mesos-0.21.0/3rdparty/libprocess/3rdparty/stout \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[5]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[5]: *** No rule to make target `tests/path.cpp', needed by `distdir'.
Stop.
make[5]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[4]: *** [distdir] Error 1
make[4]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[3]: *** [distdir] Error 1
make[3]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[2]: *** [distdir] Error 1
make[2]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
make: *** [dist] Error 2
- Mesos ReviewBot
On Sept. 19, 2014, 6:59 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/
---
(Updated Sept. 19, 2014, 6:59 a.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
---
Switch path::join() to be variadic
Also fix a bug in strings::trim() where when the string was just characters
to be trimmed, nothing would be trimmed.
Diffs
-
3rdparty/libprocess/3rdparty/Makefile.am
bd1dc8df0259a318a9171a9c045a223800e64f47
3rdparty/libprocess/3rdparty/stout/Makefile.am
2ee5a0bcc8bef0a5769dafc8ae54aea284993d6e
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp
bc6920a24d920c809e36a2a3da1810e52d0db101
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5
Diff: https://reviews.apache.org/r/25818/diff/
Testing
---
make check
Thanks,
Cody Maloney
Re: Review Request 25789: Variadic strings join for c++11 and above
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/#review53949 --- Mostly just style stuff, after a quick cleanup we'll get this committed. Thanks Joris! 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp https://reviews.apache.org/r/25789/#comment93826 Just a minor thing getting use to the code base, we've used 'internal' instead of 'helper' in public header files for things we don't want to expose. 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp https://reviews.apache.org/r/25789/#comment93828 Another style aspect in our codebase, we just use 'T' rather than the more verbose 'TVal'. Or we'll vary the single letter if it matches the kind of argument well, in this case, just 'T' is sufficient. 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp https://reviews.apache.org/r/25789/#comment93827 Style wise, please move 'std::stringstream' to a newline, here and everywhere else please. 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp https://reviews.apache.org/r/25789/#comment93829 At first I was expecting strings::join to just be variadic on std::string (like the original strings::join functions). We have a 'stringify' operation that we use which ultimately just uses operator , will we get the same result with the std::string() conversion as we do with stringify? Irregardless, let's make sure that we have tests which are joining more than just strings if we expect to get more than just strings, and that the semantics are expected with stringify! 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp https://reviews.apache.org/r/25789/#comment93830 Maybe for consistency use 'tail' here instead of 'rest'? Also, style wise, please move .. to type as elsewhere. 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp https://reviews.apache.org/r/25789/#comment93831 Stylewise, we put each argument on their own line, thanks! - Benjamin Hindman On Sept. 19, 2014, 12:36 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/ --- (Updated Sept. 19, 2014, 12:36 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Add Variadic strings join for c++11 and above. There is a second version of the variadic join which takes a reference to a stringstream as a parameter. This is handy when strings::join is just a part of a larger string manipulation. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 Diff: https://reviews.apache.org/r/25789/diff/ Testing --- Ran make check for stout. Added test cases for join as these were missing. Thanks, Joris Van Remoortere
Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/#review53951 --- 3rdparty/libprocess/include/process/help.hpp https://reviews.apache.org/r/25798/#comment93832 Do we need the stringstream at all? Could we simplify these with: return strings::join(\n, std::forwardT(args)..., \n); - Benjamin Hindman On Sept. 19, 2014, 12:26 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/ --- (Updated Sept. 19, 2014, 12:26 a.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository: mesos-git Description --- Follow up from 25079. Reduces compile time overall by ~1/3rd. Move implementation of libprocess help into cpp file. Use strings::join to refactor macro expansion that was injecting lots of overhead even when the expanded functions were not used. Diffs - 3rdparty/libprocess/Makefile.am edbe54b 3rdparty/libprocess/include/process/help.hpp 4333b5b 3rdparty/libprocess/src/help.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25798/diff/ Testing --- make check on 3rdparty support/mesos-style.py Thanks, Joris Van Remoortere
Re: [VOTE] Release Apache Mesos 0.20.1 (rc3)
+1 make check on OSX 10.9.5, clang 3.5 (Xcode 6) -all tests passed On Sep 19, 2014, at 3:03 AM, Vinod Kone vinodk...@gmail.com wrote: +1 (binding) sudo make check on CentOS 5.5 w/ gcc-4.8.2 On Thu, Sep 18, 2014 at 4:05 PM, Adam Bordelon a...@mesosphere.io wrote: Hi all, Please vote on releasing the following candidate as Apache Mesos 0.20.1. 0.20.1 includes the following: Minor bug fixes for docker integration, network isolation, build, etc. The CHANGELOG for the release is available at: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.20.1-rc3 The candidate for Mesos 0.20.1 release is available at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz The tag to be voted on is 0.20.1-rc3: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.20.1-rc3 The MD5 checksum of the tarball can be found at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz.md5 The signature of the tarball can be found at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz.asc The PGP key used to sign the release is here: https://dist.apache.org/repos/dist/release/mesos/KEYS The JAR is up in Maven in a staging repository here: https://repository.apache.org/content/repositories/orgapachemesos-1036 Please vote on releasing this package as Apache Mesos 0.20.1! The vote is open until Mon Sep 22 17:00:00 PDT 2014 and passes if a majority of at least 3 +1 PMC votes are cast. [ ] +1 Release this package as Apache Mesos 0.20.1 [ ] -1 Do not release this package because ... Thanks, Adam and Bhuvan
Re: [VOTE] Release Apache Mesos 0.20.1 (rc3)
+1 (binding) On Friday, September 19, 2014, Till Toenshoff toensh...@me.com wrote: +1 make check on OSX 10.9.5, clang 3.5 (Xcode 6) -all tests passed On Sep 19, 2014, at 3:03 AM, Vinod Kone vinodk...@gmail.com javascript:_e(%7B%7D,'cvml','vinodk...@gmail.com'); wrote: +1 (binding) sudo make check on CentOS 5.5 w/ gcc-4.8.2 On Thu, Sep 18, 2014 at 4:05 PM, Adam Bordelon a...@mesosphere.io javascript:_e(%7B%7D,'cvml','a...@mesosphere.io'); wrote: Hi all, Please vote on releasing the following candidate as Apache Mesos 0.20.1. 0.20.1 includes the following: Minor bug fixes for docker integration, network isolation, build, etc. The CHANGELOG for the release is available at: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.20.1-rc3 The candidate for Mesos 0.20.1 release is available at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz The tag to be voted on is 0.20.1-rc3: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.20.1-rc3 The MD5 checksum of the tarball can be found at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz.md5 The signature of the tarball can be found at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz.asc The PGP key used to sign the release is here: https://dist.apache.org/repos/dist/release/mesos/KEYS The JAR is up in Maven in a staging repository here: https://repository.apache.org/content/repositories/orgapachemesos-1036 Please vote on releasing this package as Apache Mesos 0.20.1! The vote is open until Mon Sep 22 17:00:00 PDT 2014 and passes if a majority of at least 3 +1 PMC votes are cast. [ ] +1 Release this package as Apache Mesos 0.20.1 [ ] -1 Do not release this package because ... Thanks, Adam and Bhuvan
Re: Review Request 25818: Switch path::join() to be variadic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25818/ --- (Updated Sept. 19, 2014, 4:08 p.m.) Review request for mesos and Benjamin Hindman. Changes --- Fix build failure, adjust template parameter names and the like to match comments on 25789 Repository: mesos-git Description --- Switch path::join() to be variadic Also fix a bug in strings::trim() where when the string was just characters to be trimmed, nothing would be trimmed. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8df0259a318a9171a9c045a223800e64f47 3rdparty/libprocess/3rdparty/stout/Makefile.am 2ee5a0bcc8bef0a5769dafc8ae54aea284993d6e 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a24d920c809e36a2a3da1810e52d0db101 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 Diff: https://reviews.apache.org/r/25818/diff/ Testing --- make check Thanks, Cody Maloney
Re: [VOTE] Release Apache Mesos 0.20.1 (rc3)
+1 (binding) Make check on centos5 and centos6 (gcc48) On Thu, Sep 18, 2014 at 4:05 PM, Adam Bordelon a...@mesosphere.io wrote: Hi all, Please vote on releasing the following candidate as Apache Mesos 0.20.1. 0.20.1 includes the following: Minor bug fixes for docker integration, network isolation, build, etc. The CHANGELOG for the release is available at: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.20.1-rc3 The candidate for Mesos 0.20.1 release is available at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz The tag to be voted on is 0.20.1-rc3: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.20.1-rc3 The MD5 checksum of the tarball can be found at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz.md5 The signature of the tarball can be found at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz.asc The PGP key used to sign the release is here: https://dist.apache.org/repos/dist/release/mesos/KEYS The JAR is up in Maven in a staging repository here: https://repository.apache.org/content/repositories/orgapachemesos-1036 Please vote on releasing this package as Apache Mesos 0.20.1! The vote is open until Mon Sep 22 17:00:00 PDT 2014 and passes if a majority of at least 3 +1 PMC votes are cast. [ ] +1 Release this package as Apache Mesos 0.20.1 [ ] -1 Do not release this package because ... Thanks, Adam and Bhuvan
Re: Review Request 25818: Switch path::join() to be variadic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25818/#review53965 --- Patch looks great! Reviews applied: [25789, 25818] All tests passed. - Mesos ReviewBot On Sept. 19, 2014, 4:08 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25818/ --- (Updated Sept. 19, 2014, 4:08 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Switch path::join() to be variadic Also fix a bug in strings::trim() where when the string was just characters to be trimmed, nothing would be trimmed. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8df0259a318a9171a9c045a223800e64f47 3rdparty/libprocess/3rdparty/stout/Makefile.am 2ee5a0bcc8bef0a5769dafc8ae54aea284993d6e 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a24d920c809e36a2a3da1810e52d0db101 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 Diff: https://reviews.apache.org/r/25818/diff/ Testing --- make check Thanks, Cody Maloney
Re: [VOTE] Release Apache Mesos 0.20.1 (rc3)
+1 (non-binding) Make check on Ubuntu 12.04 with gcc 4.6.3 On 19 September 2014 17:37, Tim Chen t...@mesosphere.io wrote: +1 (non-binding) Make check on Centos 5.5, docker tests all passed too. Tim On Fri, Sep 19, 2014 at 9:17 AM, Jie Yu yujie@gmail.com wrote: +1 (binding) Make check on centos5 and centos6 (gcc48) On Thu, Sep 18, 2014 at 4:05 PM, Adam Bordelon a...@mesosphere.io wrote: Hi all, Please vote on releasing the following candidate as Apache Mesos 0.20.1. 0.20.1 includes the following: Minor bug fixes for docker integration, network isolation, build, etc. The CHANGELOG for the release is available at: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.20.1-rc3 The candidate for Mesos 0.20.1 release is available at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz The tag to be voted on is 0.20.1-rc3: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.20.1-rc3 The MD5 checksum of the tarball can be found at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz.md5 The signature of the tarball can be found at: https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc3/mesos-0.20.1.tar.gz.asc The PGP key used to sign the release is here: https://dist.apache.org/repos/dist/release/mesos/KEYS The JAR is up in Maven in a staging repository here: https://repository.apache.org/content/repositories/orgapachemesos-1036 Please vote on releasing this package as Apache Mesos 0.20.1! The vote is open until Mon Sep 22 17:00:00 PDT 2014 and passes if a majority of at least 3 +1 PMC votes are cast. [ ] +1 Release this package as Apache Mesos 0.20.1 [ ] -1 Do not release this package because ... Thanks, Adam and Bhuvan
Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script
On Sept. 18, 2014, 12:56 p.m., Cody Maloney wrote: m4/ax_cxx_compile_stdcxx_11.m4, line 76 https://reviews.apache.org/r/25448/diff/1/?file=682725#file682725line76 It would be good to probably have an assert or two here to ensure the move worked. assert(!p2); assert(p1); true, except the check only compiles the code. i've simplified further with that in mind (the if checks are unnecessary). - Dominic --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/#review53857 --- On Sept. 19, 2014, 10:48 a.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/ --- (Updated Sept. 19, 2014, 10:48 a.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1771 https://issues.apache.org/jira/browse/MESOS-1771 Repository: mesos-git Description --- Add check to configure script for std::unique_ptr and std::move Diffs - m4/ax_cxx_compile_stdcxx_11.m4 d4b662827b2d705feb71902bdc006ce14775fa95 Diff: https://reviews.apache.org/r/25448/diff/ Testing --- make check with g++-4.4 and clang++ (3.5) Thanks, Dominic Hamon
Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/ --- (Updated Sept. 19, 2014, 10:48 a.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1771 https://issues.apache.org/jira/browse/MESOS-1771 Repository: mesos-git Description --- Add check to configure script for std::unique_ptr and std::move Diffs (updated) - m4/ax_cxx_compile_stdcxx_11.m4 d4b662827b2d705feb71902bdc006ce14775fa95 Diff: https://reviews.apache.org/r/25448/diff/ Testing --- make check with g++-4.4 and clang++ (3.5) Thanks, Dominic Hamon
Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart
On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote: OK. I went through parts of this review but I have a bigger suggestion in mind, before I get too much into the weeds. I think it's worthwhile for you to write up a design doc similar to the framework info doc w.r.t. updating SlaveInfo. This will force you to think about the repercussions of changing each of the SlaveInfo fields on the Mesos stack (master/allocator/slave/tasks/executors). Are you game? Cody Maloney wrote: I'll work on a design doc later today. Will let you know when I have it. are you still on track for the design doc? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/#review53100 --- On Sept. 13, 2014, 12:33 a.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/ --- (Updated Sept. 13, 2014, 12:33 a.m.) Review request for mesos, Adam B, Benjamin Hindman, Patrick Reilly, and Vinod Kone. Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos-git Description --- Allows attributes and resources to be set to a superset of what they were previously on a slave restart. Incorporates all comments from: https://issues.apache.org/jira/browse/MESOS-1739 and the former review request: https://reviews.apache.org/r/25111/ Diffs - src/Makefile.am 9b973e5 src/common/attributes.hpp 0a043d5 src/common/attributes.cpp aab114e src/common/slaveinfo_utils.hpp PRE-CREATION src/common/slaveinfo_utils.cpp PRE-CREATION src/master/master.hpp b492600 src/master/master.cpp d5db24e src/slave/slave.cpp 1b3dc73 src/tests/attributes_tests.cpp 240a8ca src/tests/slave_tests.cpp 69be28f Diff: https://reviews.apache.org/r/25525/diff/ Testing --- make check on localhost Thanks, Cody Maloney
Re: Review Request 25218: Updated a comment and some syntax formatting.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25218/#review53976 --- Ship it! Ben, I'll commit this for you. - Vinod Kone On Aug. 31, 2014, 4:51 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25218/ --- (Updated Aug. 31, 2014, 4:51 p.m.) Review request for mesos, Dominic Hamon and Vinod Kone. Repository: mesos-git Description --- The GCC 4.7 comment was not clear to me so I updated it, please let me know if I still don't fully understand. Moreover, there were some syntax formatting that had been missed so I updated that. Diffs - 3rdparty/libprocess/configure.ac 2d13f2ac4184bf07285814ca5809406985da8027 configure.ac c4b43911f5f8f651ddf8f2e12c263849e07e8089 Diff: https://reviews.apache.org/r/25218/diff/ Testing --- Thanks, Benjamin Hindman
Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart
On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote: OK. I went through parts of this review but I have a bigger suggestion in mind, before I get too much into the weeds. I think it's worthwhile for you to write up a design doc similar to the framework info doc w.r.t. updating SlaveInfo. This will force you to think about the repercussions of changing each of the SlaveInfo fields on the Mesos stack (master/allocator/slave/tasks/executors). Are you game? Cody Maloney wrote: I'll work on a design doc later today. Will let you know when I have it. Vinod Kone wrote: are you still on track for the design doc? Yes. I have a draft now which I'm getting a first sanity check on at the moment, hopefully will have that by Tuesday of next week. Once that is done I'll send it out to you, and then mesos-dev as a whole. - Cody --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/#review53100 --- On Sept. 13, 2014, 12:33 a.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25525/ --- (Updated Sept. 13, 2014, 12:33 a.m.) Review request for mesos, Adam B, Benjamin Hindman, Patrick Reilly, and Vinod Kone. Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos-git Description --- Allows attributes and resources to be set to a superset of what they were previously on a slave restart. Incorporates all comments from: https://issues.apache.org/jira/browse/MESOS-1739 and the former review request: https://reviews.apache.org/r/25111/ Diffs - src/Makefile.am 9b973e5 src/common/attributes.hpp 0a043d5 src/common/attributes.cpp aab114e src/common/slaveinfo_utils.hpp PRE-CREATION src/common/slaveinfo_utils.cpp PRE-CREATION src/master/master.hpp b492600 src/master/master.cpp d5db24e src/slave/slave.cpp 1b3dc73 src/tests/attributes_tests.cpp 240a8ca src/tests/slave_tests.cpp 69be28f Diff: https://reviews.apache.org/r/25525/diff/ Testing --- make check on localhost Thanks, Cody Maloney
Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/#review53984 --- Patch looks great! Reviews applied: [25448] All tests passed. - Mesos ReviewBot On Sept. 19, 2014, 5:48 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/ --- (Updated Sept. 19, 2014, 5:48 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1771 https://issues.apache.org/jira/browse/MESOS-1771 Repository: mesos-git Description --- Add check to configure script for std::unique_ptr and std::move Diffs - m4/ax_cxx_compile_stdcxx_11.m4 d4b662827b2d705feb71902bdc006ce14775fa95 Diff: https://reviews.apache.org/r/25448/diff/ Testing --- make check with g++-4.4 and clang++ (3.5) Thanks, Dominic Hamon
Mesos Modules Design
Hi everyone, We have been iterating on a design for pluggable modules in Mesos lately and wanted to get a last round of feedback before putting out patch sets. Tim St Clair, Ben Hindman and I started the discussion (and work) on this subsystem https://issues.apache.org/jira/browse/MESOS-1224 and https://issues.apache.org/jira/browse/MESOS-1384. Kapil and Bernd took over the work (shepherded by Ben H and I) and have expanded on the original design to cope with api/modules/mesos versioning semantics and be extensible enough to cope future changes in the modules subsystem (dealing with modules dependencies, etc). The latest description of the modules system has been captured in: https://cwiki.apache.org/confluence/display/MESOS/DRAFT+Design+Doc+-+Mesos+Modules (for those of you who don't want to read through the JIRA threads). We have an implementation ready based on this design and will be sharing / starting review rounds start next week. Feel free to use this thread if you have any questions. Cheers, Niklas
Re: Review Request 25789: Variadic strings join for c++11 and above
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/ --- (Updated Sept. 19, 2014, 6:37 p.m.) Review request for mesos and Benjamin Hindman. Changes --- Add overloads of an internal::append function to support mixed type strings::join(). There are special overloads for string ands const char * to maintain performance. Added a test for mixed type strings::join(). Fixed style issues. Repository: mesos-git Description --- Add Variadic strings join for c++11 and above. There is a second version of the variadic join which takes a reference to a stringstream as a parameter. This is handy when strings::join is just a part of a larger string manipulation. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 Diff: https://reviews.apache.org/r/25789/diff/ Testing --- Ran make check for stout. Added test cases for join as these were missing. Thanks, Joris Van Remoortere
Re: Review Request 25789: Variadic strings join for c++11 and above
On Sept. 19, 2014, 10:25 a.m., Benjamin Hindman wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp, line 205 https://reviews.apache.org/r/25789/diff/4/?file=694225#file694225line205 At first I was expecting strings::join to just be variadic on std::string (like the original strings::join functions). We have a 'stringify' operation that we use which ultimately just uses operator , will we get the same result with the std::string() conversion as we do with stringify? Irregardless, let's make sure that we have tests which are joining more than just strings if we expect to get more than just strings, and that the semantics are expected with stringify! I made the variadic strings::join() more generic in that it now uses a helper function called append(). This in the general case falls back to stringify, but binds first to special versions for string and const char * that have low overhead. - Joris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/#review53949 --- On Sept. 19, 2014, 6:37 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/ --- (Updated Sept. 19, 2014, 6:37 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Add Variadic strings join for c++11 and above. There is a second version of the variadic join which takes a reference to a stringstream as a parameter. This is handy when strings::join is just a part of a larger string manipulation. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 Diff: https://reviews.apache.org/r/25789/diff/ Testing --- Ran make check for stout. Added test cases for join as these were missing. Thanks, Joris Van Remoortere
Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/ --- (Updated Sept. 19, 2014, 7:01 p.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Changes --- Simplify strings::join() invocation. Repository: mesos-git Description --- Follow up from 25079. Reduces compile time overall by ~1/3rd. Move implementation of libprocess help into cpp file. Use strings::join to refactor macro expansion that was injecting lots of overhead even when the expanded functions were not used. Diffs (updated) - 3rdparty/libprocess/Makefile.am edbe54b 3rdparty/libprocess/include/process/help.hpp 4333b5b 3rdparty/libprocess/src/help.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25798/diff/ Testing --- make check on 3rdparty support/mesos-style.py Thanks, Joris Van Remoortere
Re: Review Request 25569: Refactor test environment validations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/#review53993 --- src/tests/environment.cpp https://reviews.apache.org/r/25569/#comment93864 Sure, I didn't see any other possibility needed so I just merged it here. I can just return the TestInfo instead. - Timothy Chen On Sept. 16, 2014, 10:35 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/ --- (Updated Sept. 16, 2014, 10:35 p.m.) Review request for mesos and Ben Mahler. Repository: mesos-git Description --- Review: https://reviews.apache.org/r/25569 Diffs - src/tests/environment.cpp 2274251aaf653d83c2d03ef2186763978067a747 Diff: https://reviews.apache.org/r/25569/diff/ Testing --- make check Thanks, Timothy Chen
Review Request 25844: Ignore terminal task resources in the Master's Framework struct.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25844/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description --- During my refactor to hold on to terminal tasks in the master, I forgot to update the Framework's resource accounting to ignore these terminal tasks. Diffs - src/master/http.cpp 8db4d9a7565212e06b01dc0e1f801fc9c7ff509c src/master/master.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d Diff: https://reviews.apache.org/r/25844/diff/ Testing --- make check Thanks, Ben Mahler
Review Request 25843: Fixed an executor accounting bug in framework re-registration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1821 https://issues.apache.org/jira/browse/MESOS-1821 Repository: mesos-git Description --- `_reregisterFramework` was not adding empty executors to a newly re-registerd framework. This led to the CHECK failure in MESOS-1821. Diffs - src/master/master.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d src/tests/fault_tolerance_tests.cpp 6f4171a2c19673b1a676c08e867d504677097bcb Diff: https://reviews.apache.org/r/25843/diff/ Testing --- Added a test that catches the CHECK failure without the fix. make check Thanks, Ben Mahler
Re: Review Request 25843: Fixed an executor accounting bug in framework re-registration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843/#review54009 --- src/master/master.hpp https://reviews.apache.org/r/25843/#comment93875 what does the right solution look like here? having a single owner for task/executor information and having the FW and Slave structs reference it? - Dominic Hamon On Sept. 19, 2014, 12:57 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843/ --- (Updated Sept. 19, 2014, 12:57 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1821 https://issues.apache.org/jira/browse/MESOS-1821 Repository: mesos-git Description --- `_reregisterFramework` was not adding empty executors to a newly re-registerd framework. This led to the CHECK failure in MESOS-1821. Diffs - src/master/master.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d src/tests/fault_tolerance_tests.cpp 6f4171a2c19673b1a676c08e867d504677097bcb Diff: https://reviews.apache.org/r/25843/diff/ Testing --- Added a test that catches the CHECK failure without the fix. make check Thanks, Ben Mahler
Re: Mesos Modules Design
I'm sorry, but I'm still having a hard time understanding why this needs to be dynamic. If the mesos core is split into modules that are built as standalone libraries (static) then at link time the right combination of libraries can be bundled together to create the end result. If you want to get even smarter, we can have default versions that are linked in to the mesos core as weak symbols so later linked libraries can override the defaults. This may mean that we move to static linking across the board, but frankly there are a few benefits to that approach. With the approach as defined, does this mean that the default versions will also have to be reimplemented as modules? Has any effort been put into determining the performance overhead of the approach as specified? On Fri, Sep 19, 2014 at 11:35 AM, Niklas Nielsen nik...@mesosphere.io wrote: Hi everyone, We have been iterating on a design for pluggable modules in Mesos lately and wanted to get a last round of feedback before putting out patch sets. Tim St Clair, Ben Hindman and I started the discussion (and work) on this subsystem https://issues.apache.org/jira/browse/MESOS-1224 and https://issues.apache.org/jira/browse/MESOS-1384. Kapil and Bernd took over the work (shepherded by Ben H and I) and have expanded on the original design to cope with api/modules/mesos versioning semantics and be extensible enough to cope future changes in the modules subsystem (dealing with modules dependencies, etc). The latest description of the modules system has been captured in: https://cwiki.apache.org/confluence/display/MESOS/DRAFT+Design+Doc+-+Mesos+Modules (for those of you who don't want to read through the JIRA threads). We have an implementation ready based on this design and will be sharing / starting review rounds start next week. Feel free to use this thread if you have any questions. Cheers, Niklas -- Dominic Hamon | @mrdo | Twitter *There are no bad ideas; only good ideas that go horribly wrong.*
Re: Mesos Modules Design
The design was specifically tailored to allow non-modules to be used in lieu of modules. So nothing has to be reimplemented as a module. There may be some refactoring to abstract a class, though, but that’s usually a good idea anyway. On Sep 19, 2014, at 1:03 PM, Dominic Hamon dha...@twopensource.com wrote: I'm sorry, but I'm still having a hard time understanding why this needs to be dynamic. If the mesos core is split into modules that are built as standalone libraries (static) then at link time the right combination of libraries can be bundled together to create the end result. If you want to get even smarter, we can have default versions that are linked in to the mesos core as weak symbols so later linked libraries can override the defaults. This may mean that we move to static linking across the board, but frankly there are a few benefits to that approach. With the approach as defined, does this mean that the default versions will also have to be reimplemented as modules? Has any effort been put into determining the performance overhead of the approach as specified? On Fri, Sep 19, 2014 at 11:35 AM, Niklas Nielsen nik...@mesosphere.io wrote: Hi everyone, We have been iterating on a design for pluggable modules in Mesos lately and wanted to get a last round of feedback before putting out patch sets. Tim St Clair, Ben Hindman and I started the discussion (and work) on this subsystem https://issues.apache.org/jira/browse/MESOS-1224 and https://issues.apache.org/jira/browse/MESOS-1384. Kapil and Bernd took over the work (shepherded by Ben H and I) and have expanded on the original design to cope with api/modules/mesos versioning semantics and be extensible enough to cope future changes in the modules subsystem (dealing with modules dependencies, etc). The latest description of the modules system has been captured in: https://cwiki.apache.org/confluence/display/MESOS/DRAFT+Design+Doc+-+Mesos+Modules (for those of you who don't want to read through the JIRA threads). We have an implementation ready based on this design and will be sharing / starting review rounds start next week. Feel free to use this thread if you have any questions. Cheers, Niklas -- Dominic Hamon | @mrdo | Twitter *There are no bad ideas; only good ideas that go horribly wrong.*
Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/#review54017 --- Patch looks great! Reviews applied: [25789, 25798] All tests passed. - Mesos ReviewBot On Sept. 19, 2014, 7:01 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/ --- (Updated Sept. 19, 2014, 7:01 p.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository: mesos-git Description --- Follow up from 25079. Reduces compile time overall by ~1/3rd. Move implementation of libprocess help into cpp file. Use strings::join to refactor macro expansion that was injecting lots of overhead even when the expanded functions were not used. Diffs - 3rdparty/libprocess/Makefile.am edbe54b 3rdparty/libprocess/include/process/help.hpp 4333b5b 3rdparty/libprocess/src/help.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25798/diff/ Testing --- make check on 3rdparty support/mesos-style.py Thanks, Joris Van Remoortere
Review Request 25847: Refactor Libprocess: class Node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/ --- Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- Move class Node out of process.cpp and into its own header. Part of refactoring process.cpp. Diffs - 3rdparty/libprocess/include/Makefile.am 09f6e41 3rdparty/libprocess/include/process/node.hpp PRE-CREATION 3rdparty/libprocess/src/process.cpp 3ac56c7 Diff: https://reviews.apache.org/r/25847/diff/ Testing --- make check in libprocess support/mesos-stype.py Thanks, Joris Van Remoortere
Re: Review Request 25847: Refactor Libprocess: class Node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/#review54018 --- 3rdparty/libprocess/include/process/node.hpp https://reviews.apache.org/r/25847/#comment93890 worth renaming to IpPort? or Host? 3rdparty/libprocess/include/process/node.hpp https://reviews.apache.org/r/25847/#comment93888 uint64_t? start getting ipv6 support in... ;) - Dominic Hamon On Sept. 19, 2014, 1:31 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/ --- (Updated Sept. 19, 2014, 1:31 p.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- Move class Node out of process.cpp and into its own header. Part of refactoring process.cpp. Diffs - 3rdparty/libprocess/include/Makefile.am 09f6e41 3rdparty/libprocess/include/process/node.hpp PRE-CREATION 3rdparty/libprocess/src/process.cpp 3ac56c7 Diff: https://reviews.apache.org/r/25847/diff/ Testing --- make check in libprocess support/mesos-stype.py Thanks, Joris Van Remoortere
Review Request 25848: Introducing mesos modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, and Timothy St. Clair. Repository: mesos-git Description --- Adding a first class primitive, abstraction and process for dynamic library writing and loading can make it easier to extend inner workings of Mesos. Making it possible to have dynamic loadable resource allocators, isolators, containerizes, authenticators and much more. Diffs - include/mesos/module.hpp PRE-CREATION src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 src/examples/test_module.cpp PRE-CREATION src/module/manager.hpp PRE-CREATION src/module/manager.cpp PRE-CREATION src/slave/flags.hpp 21e00212bc402674eaea73b44b3f91df477a7213 src/slave/main.cpp 2c4d365a04acbcb382e978d811a318130484b3d5 src/tests/module.hpp PRE-CREATION src/tests/module_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25848/diff/ Testing --- Ran make check with added tests for verifying library/module loading and simple version check. Thanks, Kapil Arya
Re: Review Request 25844: Ignore terminal task resources in the Master's Framework struct.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25844/#review54020 --- Ship it! Ship It! - Vinod Kone On Sept. 19, 2014, 7:57 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25844/ --- (Updated Sept. 19, 2014, 7:57 p.m.) Review request for mesos and Vinod Kone. Repository: mesos-git Description --- During my refactor to hold on to terminal tasks in the master, I forgot to update the Framework's resource accounting to ignore these terminal tasks. Diffs - src/master/http.cpp 8db4d9a7565212e06b01dc0e1f801fc9c7ff509c src/master/master.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d Diff: https://reviews.apache.org/r/25844/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 25848: Introducing mesos modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/ --- (Updated Sept. 19, 2014, 4:40 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, and Timothy St. Clair. Changes --- Added MESOS-1384 in Bugs field. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Adding a first class primitive, abstraction and process for dynamic library writing and loading can make it easier to extend inner workings of Mesos. Making it possible to have dynamic loadable resource allocators, isolators, containerizes, authenticators and much more. Diffs - include/mesos/module.hpp PRE-CREATION src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 src/examples/test_module.cpp PRE-CREATION src/module/manager.hpp PRE-CREATION src/module/manager.cpp PRE-CREATION src/slave/flags.hpp 21e00212bc402674eaea73b44b3f91df477a7213 src/slave/main.cpp 2c4d365a04acbcb382e978d811a318130484b3d5 src/tests/module.hpp PRE-CREATION src/tests/module_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25848/diff/ Testing --- Ran make check with added tests for verifying library/module loading and simple version check. Thanks, Kapil Arya
Re: Review Request 25847: Refactor Libprocess: class Node
On Sept. 19, 2014, 8:32 p.m., Dominic Hamon wrote: 3rdparty/libprocess/include/process/node.hpp, line 32 https://reviews.apache.org/r/25847/diff/1/?file=697014#file697014line32 uint64_t? start getting ipv6 support in... ;) Still won't fit in ipv6 though :( - Nikita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/#review54018 --- On Sept. 19, 2014, 8:31 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/ --- (Updated Sept. 19, 2014, 8:31 p.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- Move class Node out of process.cpp and into its own header. Part of refactoring process.cpp. Diffs - 3rdparty/libprocess/include/Makefile.am 09f6e41 3rdparty/libprocess/include/process/node.hpp PRE-CREATION 3rdparty/libprocess/src/process.cpp 3ac56c7 Diff: https://reviews.apache.org/r/25847/diff/ Testing --- make check in libprocess support/mesos-stype.py Thanks, Joris Van Remoortere
Re: Review Request 25847: Refactor Libprocess: class Node
On Sept. 19, 2014, 8:32 p.m., Dominic Hamon wrote: 3rdparty/libprocess/include/process/node.hpp, line 32 https://reviews.apache.org/r/25847/diff/1/?file=697014#file697014line32 uint64_t? start getting ipv6 support in... ;) Nikita Vetoshkin wrote: Still won't fit in ipv6 though :( We can use code__uint128_t/code ; however, I am not sure if this is supported accross all our required compilers. The larger issue is that the uint32_t type is currently baked into the protobufs, so this would be a larger compatibility change. - Joris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/#review54018 --- On Sept. 19, 2014, 8:31 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/ --- (Updated Sept. 19, 2014, 8:31 p.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- Move class Node out of process.cpp and into its own header. Part of refactoring process.cpp. Diffs - 3rdparty/libprocess/include/Makefile.am 09f6e41 3rdparty/libprocess/include/process/node.hpp PRE-CREATION 3rdparty/libprocess/src/process.cpp 3ac56c7 Diff: https://reviews.apache.org/r/25847/diff/ Testing --- make check in libprocess support/mesos-stype.py Thanks, Joris Van Remoortere
Re: Review Request 25847: Refactor Libprocess: class Node
On Sept. 19, 2014, 1:32 p.m., Dominic Hamon wrote: 3rdparty/libprocess/include/process/node.hpp, line 32 https://reviews.apache.org/r/25847/diff/1/?file=697014#file697014line32 uint64_t? start getting ipv6 support in... ;) Nikita Vetoshkin wrote: Still won't fit in ipv6 though :( Joris Van Remoortere wrote: We can use code__uint128_t/code ; however, I am not sure if this is supported accross all our required compilers. The larger issue is that the uint32_t type is currently baked into the protobufs, so this would be a larger compatibility change. I would suggest to post-pone the ipv6 concerns to a full patch which supports it (and tests it). On Sept. 19, 2014, 1:32 p.m., Dominic Hamon wrote: 3rdparty/libprocess/include/process/node.hpp, line 11 https://reviews.apache.org/r/25847/diff/1/?file=697014#file697014line11 worth renaming to IpPort? or Host? With several concepts (including this) being inspired by Erlang conventions, I wouldn't change 'Node': http://www.erlang.org/doc/reference_manual/distributed.html - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/#review54018 --- On Sept. 19, 2014, 1:31 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/ --- (Updated Sept. 19, 2014, 1:31 p.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- Move class Node out of process.cpp and into its own header. Part of refactoring process.cpp. Diffs - 3rdparty/libprocess/include/Makefile.am 09f6e41 3rdparty/libprocess/include/process/node.hpp PRE-CREATION 3rdparty/libprocess/src/process.cpp 3ac56c7 Diff: https://reviews.apache.org/r/25847/diff/ Testing --- make check in libprocess support/mesos-stype.py Thanks, Joris Van Remoortere
Re: Review Request 25843: Fixed an executor accounting bug in framework re-registration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843/#review54024 --- Ship it! src/master/master.cpp https://reviews.apache.org/r/25843/#comment93904 kill the if. - Vinod Kone On Sept. 19, 2014, 7:57 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843/ --- (Updated Sept. 19, 2014, 7:57 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1821 https://issues.apache.org/jira/browse/MESOS-1821 Repository: mesos-git Description --- `_reregisterFramework` was not adding empty executors to a newly re-registerd framework. This led to the CHECK failure in MESOS-1821. Diffs - src/master/master.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d src/tests/fault_tolerance_tests.cpp 6f4171a2c19673b1a676c08e867d504677097bcb Diff: https://reviews.apache.org/r/25843/diff/ Testing --- Added a test that catches the CHECK failure without the fix. make check Thanks, Ben Mahler
Re: Review Request 25847: Refactor Libprocess: class Node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/#review54030 --- Ship it! Can you motivate it a bit in context of eventually reworking the libprocess transport/event: https://issues.apache.org/jira/browse/MESOS-1330 and down-sizing the 4000+ line process.cpp :-) 3rdparty/libprocess/include/process/node.hpp https://reviews.apache.org/r/25847/#comment93927 Know it is not yours, but these fit on a single line. Thanks! :) We try to use postfix underscore now to avoid clashes, https://www.gnu.org/software/libc/manual/html_node/Reserved-Names.html I will leave that up to you whether you want to address it here. - Niklas Nielsen On Sept. 19, 2014, 1:31 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/ --- (Updated Sept. 19, 2014, 1:31 p.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- Move class Node out of process.cpp and into its own header. Part of refactoring process.cpp. Diffs - 3rdparty/libprocess/include/Makefile.am 09f6e41 3rdparty/libprocess/include/process/node.hpp PRE-CREATION 3rdparty/libprocess/src/process.cpp 3ac56c7 Diff: https://reviews.apache.org/r/25847/diff/ Testing --- make check in libprocess support/mesos-stype.py Thanks, Joris Van Remoortere
Re: Mesos Modules Design
inline - Original Message - From: Dominic Hamon dha...@twopensource.com To: dev dev@mesos.apache.org Sent: Friday, September 19, 2014 3:03:52 PM Subject: Re: Mesos Modules Design I'm sorry, but I'm still having a hard time understanding why this needs to be dynamic. If the mesos core is split into modules that are built as standalone libraries (static) then at link time the right combination of libraries can be bundled together to create the end result. If you want to get even smarter, we can have default versions that are linked in to the mesos core as weak symbols so later linked libraries can override the defaults. This may mean that we move to static linking across the board, but frankly there are a few benefits to that approach. With the approach as defined, does this mean that the default versions will also have to be reimplemented as modules? That was never the intention. Defining boundaries for extensibility was the motivation. This iteration was simply to define the mechanics, it was not to replace/refactor the existing libraries. In fact, using simple factory mechanisms we could pretty easily allow static + dynamic to live side-by-side without changing the existing linkage. Has any effort been put into determining the performance overhead of the approach as specified? On Fri, Sep 19, 2014 at 11:35 AM, Niklas Nielsen nik...@mesosphere.io wrote: Hi everyone, We have been iterating on a design for pluggable modules in Mesos lately and wanted to get a last round of feedback before putting out patch sets. Tim St Clair, Ben Hindman and I started the discussion (and work) on this subsystem https://issues.apache.org/jira/browse/MESOS-1224 and https://issues.apache.org/jira/browse/MESOS-1384. Kapil and Bernd took over the work (shepherded by Ben H and I) and have expanded on the original design to cope with api/modules/mesos versioning semantics and be extensible enough to cope future changes in the modules subsystem (dealing with modules dependencies, etc). The latest description of the modules system has been captured in: https://cwiki.apache.org/confluence/display/MESOS/DRAFT+Design+Doc+-+Mesos+Modules (for those of you who don't want to read through the JIRA threads). We have an implementation ready based on this design and will be sharing / starting review rounds start next week. Feel free to use this thread if you have any questions. Cheers, Niklas -- Dominic Hamon | @mrdo | Twitter *There are no bad ideas; only good ideas that go horribly wrong.* -- Cheers, Timothy St. Clair Red Hat Inc.
Re: Mesos Modules Design
Hi Dominic, (response inlined) On 19 September 2014 13:03, Dominic Hamon dha...@twopensource.com wrote: I'm sorry, but I'm still having a hard time understanding why this needs to be dynamic. If the mesos core is split into modules that are built as standalone libraries (static) then at link time the right combination of libraries can be bundled together to create the end result. If you want to get even smarter, we can have default versions that are linked in to the mesos core as weak symbols so later linked libraries can override the defaults. This may mean that we move to static linking across the board, but frankly there are a few benefits to that approach. This works for some, but not all use cases. One use-case where it _does_ make sense to statically bake into the image could be: https://issues.apache.org/jira/browse/MESOS-1330 That be, you probably rarely want to swap network transport implementations in and out on per-run basis but will know up front which one to configure and use. On the other hand, having to relink and rebuilding give users a poor experience and makes it hard to select (or unselect) custom components. Using a prebuilt package and point against libraries is a pretty common work-flow: Apache web server relies heavily on modules from dynamic libraries. TL;DR I don't see the two approaches to be mutually exclusive and we can get a lot of leverage with the current design but we want to be able to do this with static linking too. (To Tim St Clair's point) With the approach as defined, does this mean that the default versions will also have to be reimplemented as modules? Not necessary. Mesos default implementations stays as is. See Bernd's comment. Has any effort been put into determining the performance overhead of the approach as specified? It won't affect Mesos if you are not using modules. The call sites will be virtual dispatches no matter whether you are using modules or internal/default implementations. There is a performance penalty of not being able to do global optimizations within the module, but that is the trade-off of implementing a dynamic loadable module. On Fri, Sep 19, 2014 at 11:35 AM, Niklas Nielsen nik...@mesosphere.io wrote: Hi everyone, We have been iterating on a design for pluggable modules in Mesos lately and wanted to get a last round of feedback before putting out patch sets. Tim St Clair, Ben Hindman and I started the discussion (and work) on this subsystem https://issues.apache.org/jira/browse/MESOS-1224 and https://issues.apache.org/jira/browse/MESOS-1384. Kapil and Bernd took over the work (shepherded by Ben H and I) and have expanded on the original design to cope with api/modules/mesos versioning semantics and be extensible enough to cope future changes in the modules subsystem (dealing with modules dependencies, etc). The latest description of the modules system has been captured in: https://cwiki.apache.org/confluence/display/MESOS/DRAFT+Design+Doc+-+Mesos+Modules (for those of you who don't want to read through the JIRA threads). We have an implementation ready based on this design and will be sharing / starting review rounds start next week. Feel free to use this thread if you have any questions. Cheers, Niklas -- Dominic Hamon | @mrdo | Twitter *There are no bad ideas; only good ideas that go horribly wrong.* Hope that helps; if not, we'd be happy to jump on a call. Niklas
Re: Review Request 25843: Fixed an executor accounting bug in framework re-registration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843/#review54034 --- Patch looks great! Reviews applied: [25844, 25843] All tests passed. - Mesos ReviewBot On Sept. 19, 2014, 7:57 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843/ --- (Updated Sept. 19, 2014, 7:57 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1821 https://issues.apache.org/jira/browse/MESOS-1821 Repository: mesos-git Description --- `_reregisterFramework` was not adding empty executors to a newly re-registerd framework. This led to the CHECK failure in MESOS-1821. Diffs - src/master/master.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d src/tests/fault_tolerance_tests.cpp 6f4171a2c19673b1a676c08e867d504677097bcb Diff: https://reviews.apache.org/r/25843/diff/ Testing --- Added a test that catches the CHECK failure without the fix. make check Thanks, Ben Mahler
Re: Review Request 25847: Refactor Libprocess: class Node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/ --- (Updated Sept. 19, 2014, 10:19 p.m.) Review request for mesos and Niklas Nielsen. Changes --- fix style issue. Repository: mesos-git Description --- Move class Node out of process.cpp and into its own header. Part of refactoring process.cpp. Diffs (updated) - 3rdparty/libprocess/include/Makefile.am 09f6e41 3rdparty/libprocess/include/process/node.hpp PRE-CREATION 3rdparty/libprocess/src/process.cpp 3ac56c7 Diff: https://reviews.apache.org/r/25847/diff/ Testing --- make check in libprocess support/mesos-stype.py Thanks, Joris Van Remoortere
Re: Review Request 25569: Refactor test environment validations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/ --- (Updated Sept. 19, 2014, 10:27 p.m.) Review request for mesos and Ben Mahler. Repository: mesos-git Description --- Review: https://reviews.apache.org/r/25569 Diffs (updated) - src/tests/environment.cpp 2274251aaf653d83c2d03ef2186763978067a747 Diff: https://reviews.apache.org/r/25569/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 25819: post-reviews.py: use --no-color with git log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25819/#review54042 --- Ship it! Thanks for updating the description on this one. - Ben Mahler On Sept. 19, 2014, 5:20 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25819/ --- (Updated Sept. 19, 2014, 5:20 a.m.) Review request for mesos and Ben Mahler. Repository: mesos-git Description --- Force git log to never emit colored output (for setups with colored output enabled by default). For example, the command git --no-pager log --pretty=oneline --reverse master..HEAD should generate output similiar to the following: ``` fa7e46cfc228e9f80e08d7c28a978d561fbba5a7 post-reviews.py: added --no-color to git log. - For setups that have colored output for git log. ``` However, in a setup where git emits colored output, the raw output would look like the following: ``` ^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m post-reviews.py: added --no-color to git log. - For setups that have colored output for git log. ``` The parser in post-review.py then picks '`^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m`' as the sha and crashes. The '--no-color' flag forces git to never emit colored output. Diffs - support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e Diff: https://reviews.apache.org/r/25819/diff/ Testing --- Created this review request using the updated script. Thanks, Kapil Arya
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2118
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2118/changes Changes: [bmahler] Ignore terminal task resources in the Master's Framework struct. [bmahler] Fixed an executor accounting bug in framework re-registration. -- [...truncated 2896 lines...] if gcc -DHAVE_CONFIG_H -I. -I. -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT cli.o -MD -MP -MF .deps/cli.Tpo -c -o cli.o `test -f 'src/cli.c' || echo './'`src/cli.c; \ then mv -f .deps/cli.Tpo .deps/cli.Po; else rm -f .deps/cli.Tpo; exit 1; fi /bin/bash ./libtool --tag=CC --mode=link gcc -Wall -Werror -g -O2 -D_GNU_SOURCE -o cli_st cli.o libzookeeper_st.la gcc -Wall -Werror -g -O2 -D_GNU_SOURCE -o cli_st cli.o ./.libs/libzookeeper_st.a -lm if gcc -DHAVE_CONFIG_H -I. -I. -I. -I./include -I./tests -I./generated -DTHREADED -g -O2 -D_GNU_SOURCE -MT cli_mt-cli.o -MD -MP -MF .deps/cli_mt-cli.Tpo -c -o cli_mt-cli.o `test -f 'src/cli.c' || echo './'`src/cli.c; \ then mv -f .deps/cli_mt-cli.Tpo .deps/cli_mt-cli.Po; else rm -f .deps/cli_mt-cli.Tpo; exit 1; fi /bin/bash ./libtool --tag=CC --mode=link gcc -Wall -Werror -g -O2 -D_GNU_SOURCE -o cli_mt cli_mt-cli.o libzookeeper_mt.la gcc -Wall -Werror -g -O2 -D_GNU_SOURCE -o cli_mt cli_mt-cli.o ./.libs/libzookeeper_mt.a -lm -lpthread if gcc -DHAVE_CONFIG_H -I. -I. -I. -I./include -I./tests -I./generated -DTHREADED -g -O2 -D_GNU_SOURCE -MT load_gen-load_gen.o -MD -MP -MF .deps/load_gen-load_gen.Tpo -c -o load_gen-load_gen.o `test -f 'src/load_gen.c' || echo './'`src/load_gen.c; \ then mv -f .deps/load_gen-load_gen.Tpo .deps/load_gen-load_gen.Po; else rm -f .deps/load_gen-load_gen.Tpo; exit 1; fi /bin/bash ./libtool --tag=CC --mode=link gcc -Wall -Werror -g -O2 -D_GNU_SOURCE -o load_gen load_gen-load_gen.o libzookeeper_mt.la gcc -Wall -Werror -g -O2 -D_GNU_SOURCE -o load_gen load_gen-load_gen.o ./.libs/libzookeeper_mt.a -lm -lpthread make[5]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty/zookeeper-3.4.5/src/c' make[4]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty/zookeeper-3.4.5/src/c' make[3]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty' make[2]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty' make[1]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/3rdparty' Making check in src make[1]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src' /bin/mkdir -p . ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include -I. --cpp_out=../include ../include/mesos/mesos.proto mv ../include/mesos/*.pb.cc . /bin/mkdir -p containerizer /bin/mkdir -p ../include/mesos/containerizer ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include -I. --cpp_out=../include ../include/mesos/containerizer/containerizer.proto mv ../include/mesos/containerizer/*.pb.cc containerizer /bin/mkdir -p scheduler /bin/mkdir -p ../include/mesos/scheduler ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include -I. --cpp_out=../include ../include/mesos/scheduler/scheduler.proto mv ../include/mesos/scheduler/*.pb.cc scheduler /bin/mkdir -p java/generated/org/apache/mesos ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include -I. --java_out=java/generated ../include/mesos/mesos.proto /bin/mkdir -p java/generated/org/apache/mesos/containerizer ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include -I. --java_out=java/generated ../include/mesos/containerizer/containerizer.proto /bin/mkdir -p python/interface/src/mesos/interface ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include/mesos \ -I../include -I. --python_out=python/interface/src/mesos/interface ../include/mesos/mesos.proto /bin/mkdir -p python/interface/src/mesos/interface ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include/mesos/containerizer \ -I../include -I. \ --python_out=python/interface/src/mesos/interface ../include/mesos/containerizer/containerizer.proto sed -e 's/mesos\.mesos_pb2/mesos_pb2/' python/interface/src/mesos/interface/containerizer_pb2.py python/interface/src/mesos/interface/containerizer_pb2.py /bin/mkdir -p messages ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include -I. --cpp_out=. messages/messages.proto /bin/mkdir -p messages ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protoc -I../include -I. --cpp_out=. messages/log.proto /bin/mkdir -p messages
Re: Review Request 25848: Introducing mesos modules.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54043
---
First pass
src/examples/test_module.cpp
https://reviews.apache.org/r/25848/#comment93939
The build bot failed this include - mind take a look?
src/examples/test_module.cpp
https://reviews.apache.org/r/25848/#comment93941
This file will probably serve as a template for new templates, so let's add
some comments on what the MESOS_MODULE_LIBRARY() and MESOS_MODULE() macros do.
src/examples/test_module.cpp
https://reviews.apache.org/r/25848/#comment93940
Mind throwing in a comment on what/where the example module is used?
src/examples/test_module.cpp
https://reviews.apache.org/r/25848/#comment93975
You could also throw in a comment here on what function declaration that
gets generated i.e. exported symbol name and return type.
src/module/manager.hpp
https://reviews.apache.org/r/25848/#comment93942
Mind mentioning where you get this configuration from i.e. --modules
src/module/manager.hpp
https://reviews.apache.org/r/25848/#comment93943
{ on it's own line
src/module/manager.hpp
https://reviews.apache.org/r/25848/#comment93967
End comment with period
src/module/manager.hpp
https://reviews.apache.org/r/25848/#comment93966
Isn't module implied by the module manager? How about -load() and
-contains() ?
src/module/manager.hpp
https://reviews.apache.org/r/25848/#comment93969
Can we find some ABI documentation that supports this claim and maybe throw
in a reference?
src/module/manager.hpp
https://reviews.apache.org/r/25848/#comment93944
{ on it's own line
src/module/manager.hpp
https://reviews.apache.org/r/25848/#comment93945
Newline between loadModuleLibrary and verify module role.
Also, isn't 'module' implied? loadLibrary / verifyRole would be a bit more
concise.
src/module/manager.hpp
https://reviews.apache.org/r/25848/#comment93946
You can use 'CHECK_NOTNULL(lib)-' to guard the libary pointer.
src/module/manager.hpp
https://reviews.apache.org/r/25848/#comment93970
Access to those need to be guarded, right? Or do you explicitally call out
that the module manager isn't thread safe?
src/module/manager.hpp
https://reviews.apache.org/r/25848/#comment93964
How about using shared_ptr's instead?
If not, how is cleaning up all the allocated libraries?
src/module/manager.cpp
https://reviews.apache.org/r/25848/#comment93971
newline after 'version.hpp'
src/module/manager.cpp
https://reviews.apache.org/r/25848/#comment93963
Ben, we did the module manager as a singleton. I know it is a uncommon
pattern in Mesos in general. Do you have any thoughts on this? We will need to
take care of thread-safety with whatever state we maintain in the module
manager.
src/module/manager.cpp
https://reviews.apache.org/r/25848/#comment93961
How about using shared_ptr instead of a raw pointer?
src/module/manager.cpp
https://reviews.apache.org/r/25848/#comment93962
Mind throwing this on a new line and indent 4 spaces? Here and below
src/module/manager.cpp
https://reviews.apache.org/r/25848/#comment93978
This block is very dense - mind spreading it out a little bit?
src/module/manager.cpp
https://reviews.apache.org/r/25848/#comment93957
Odd indentation here.
src/slave/flags.hpp
https://reviews.apache.org/r/25848/#comment93948
Let's tie the modules in after the core patch has landed. Also, we need to
it for both masters and slaves (alongside starting to wire up module loading
for isolators, authenticators, ...)
TL;DR Let's review the src/slave/flags.hpp and src/slave/main.cpp changes
(with a master equivalent) in a dependent patch.
In the new review, please expand the help text and throw in some examples.
You can put in the expected format as you listed in the module manager header.
src/slave/main.cpp
https://reviews.apache.org/r/25848/#comment93956
See comment above.
src/tests/module.hpp
https://reviews.apache.org/r/25848/#comment93949
Mind throwing in a comment on where this is implemented / how it is used?
src/tests/module.hpp
https://reviews.apache.org/r/25848/#comment93950
And perhaps highlight the virtual destructor's importance (in order to
clean up the object in the library's context). People are probably going to use
this as a template for writing new modules :-)
src/tests/module_tests.cpp
https://reviews.apache.org/r/25848/#comment93947
This seems to be repeated a couple of times - can we centralize in a local
helper?
src/tests/module_tests.cpp
https://reviews.apache.org/r/25848/#comment93955
When are you cleaning up this file? Use mktemp instead and kill the file
when you are done :-)
src/tests/module_tests.cpp
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2119
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2119/changes Changes: [bmahler] Fixed an issue with colored output in post-reviews.py. [niklas] Refactored Node class in libprocess. -- [...truncated 1055 lines...] checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for strings.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for unistd.h... yes checking minix/config.h usability... no checking minix/config.h presence... no checking for minix/config.h... no checking whether it is safe to define __EXTENSIONS__... yes checking C++ compiler flags.. use user-supplied: -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 checking whether __SUNPRO_CC is declared... no checking how to print strings... printf checking for a sed that does not truncate output... /bin/sed checking for fgrep... /bin/grep -F checking for ld used by gcc... /usr/bin/ld checking if the linker (/usr/bin/ld) is GNU ld... yes checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B checking the name lister (/usr/bin/nm -B) interface... BSD nm checking whether ln -s works... yes checking the maximum length of command line arguments... 3458764513820540925 checking whether the shell understands some XSI constructs... yes checking whether the shell understands +=... yes checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop checking for /usr/bin/ld option to reload object files... -r checking for objdump... objdump checking how to recognize dependent libraries... pass_all checking for dlltool... no checking how to associate runtime and link libraries... printf %s\n checking for ar... ar checking for archiver @FILE support... @ checking for strip... strip checking for ranlib... ranlib checking command to parse /usr/bin/nm -B output from gcc object... ok checking for sysroot... no checking for mt... mt checking if mt is a manifest tool... no checking for dlfcn.h... yes checking for objdir... .libs checking if gcc supports -fno-rtti -fno-exceptions... no checking for gcc option to produce PIC... -fPIC -DPIC checking if gcc PIC flag -fPIC -DPIC works... yes checking if gcc static flag -static works... yes checking if gcc supports -c -o file.o... yes checking if gcc supports -c -o file.o... (cached) yes checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes checking dynamic linker characteristics... GNU/Linux ld.so checking how to hardcode library paths into programs... immediate checking whether stripping libraries is possible... yes checking if libtool supports shared libraries... yes checking whether to build shared libraries... no checking whether to build static libraries... yes checking how to run the C++ preprocessor... g++ -E checking for ld used by g++... /usr/bin/ld -m elf_x86_64 checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes checking for g++ option to produce PIC... -fPIC -DPIC checking if g++ PIC flag -fPIC -DPIC works... yes checking if g++ static flag -static works... yes checking if g++ supports -c -o file.o... yes checking if g++ supports -c -o file.o... (cached) yes checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes checking dynamic linker characteristics... (cached) GNU/Linux ld.so checking how to hardcode library paths into programs... immediate checking for ANSI C header files... (cached) yes checking fcntl.h usability... yes checking fcntl.h presence... yes checking for fcntl.h... yes checking for inttypes.h... (cached) yes checking limits.h usability... yes checking limits.h presence... yes checking for limits.h... yes checking for stdlib.h... (cached) yes checking for unistd.h... (cached) yes checking for working memcmp... yes checking for working strtod... yes checking for ftruncate... yes checking for memset... yes checking for mkdir... yes checking for strchr... yes checking for strerror... yes checking for strtol... yes checking zlib version... ok (1.2.0.4 or later) checking for library containing zlibVersion... -lz checking for the pthreads library -lpthreads... no checking whether pthreads work without any flags... no checking whether pthreads work with -Kthread... no checking whether pthreads work with -kthread... no checking for the pthreads library -llthread... no checking whether pthreads work with -pthread... yes checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE checking if more special flags are required for pthreads... no checking whether to check for GCC pthread/shared
Re: Review Request 25847: Refactor Libprocess: class Node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/#review54050 --- Patch looks great! Reviews applied: [25847] All tests passed. - Mesos ReviewBot On Sept. 19, 2014, 10:19 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/ --- (Updated Sept. 19, 2014, 10:19 p.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- Move class Node out of process.cpp and into its own header. Part of refactoring process.cpp. Diffs - 3rdparty/libprocess/include/Makefile.am 09f6e41 3rdparty/libprocess/include/process/node.hpp PRE-CREATION 3rdparty/libprocess/src/process.cpp 3ac56c7 Diff: https://reviews.apache.org/r/25847/diff/ Testing --- make check in libprocess support/mesos-stype.py Thanks, Joris Van Remoortere
Re: Review Request 25569: Refactor test environment validations
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review54045
---
Thanks Tim, this is looking really nice!
Appreciate the patience, just one more round of cleanup and we should be all
set. :D
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93977
Can you remove this? We only have two callers, and the code is really
trivial in the callers. :)
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93976
This might be a bit more succinct:
// Returns whether the test should be filtered.
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93965
Curious why you want this vector version of matches.
It adds a method, and there is still more code in the call site than just
calling matches twice:
Current:
```
vectorstring patterns;
patterns.push_back(PortMappingIsolatorTest);
patterns.push_back(PortMappingMesosTest);
return matches(test, patterns) !isRoutingEnabled;
```
vs. removing vector matches:
```
return (matches(test, PortMappingIsolatorTest)
matches(test, PortMappingMesosTest)
!isRoutingEnabled;
```
Probably an if is a bit easier to read:
```
if (matches(test, PortMappingIsolatorTest) ||
matches(test, PortMappingMesosTest) {
return routingDisabled;
}
return false;
```
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93979
Could we avoid the need for a constructor and a member variable by calling
os::user() inside filter()? Let's avoid trying to optimize this since it's
likely not noticeably expensive.
IMO doing it all in filter() actually makes the code more readable as well.
:)
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93980
Can we avoid the need for the constructor + member variable here as well,
by doing it all in filter()?
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93972
We have 'enabled' in the name, so the 'is' seems redundant, the following
seem clear without the 'is' prefix:
'cgroupsEnabled', 'dockerEnabled', etc.
What do you think?
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93981
How about including the message for non-linux systems as well:
```
#ifdef __linux__
docker = Docker::create(flags.docker);
#else
docker = Error(Docker tests not supported on non-Linux systems);
#endif
if (docker.isError()) {
// print message;
}
```
Could we store the TryDocker as a member instead of converting to the
'isDockerEnabled' boolean? Doesn't look like the boolean is giving us very
much? It even lets us make the call to Docker::create vs Error(non linux) in
the initializer list.
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93984
Do you want to remove the std:: qualifiers here?
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93982
This is pretty implicit for non-Linux systems, in that we treat them as
having hierarchies.
Could we have the #ifdef in the filter() method to make this a bit more
clear?
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93983
Based on my other comment, how about just storing 'setstring hierarchies'
and checking .empty() in filter()? But inside a linux #ifdef! ;)
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93985
We can avoid the need for the Constructor and the member variable if we
just call these in filter().
The #ifdef inside filter will make things a bit clearer as well!
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93986
Ditto, can you avoid the constructor + member variable, and instead push
the #ifdef down into filter() to make things a bit clearer?
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93960
Leftover 'process::'?
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93958
Very clean, thanks Tim!
src/tests/environment.cpp
https://reviews.apache.org/r/25569/#comment93954
What about s/disabledTest/filtered/ ?
If disabledTest() returned a vector of strings as before you can do the
following here:
```
disabled += strings::join(:, filtered(unitTest, filters);
```
No clunky loop necessary. :)
I should have been a bit more clear in my previous comment, what I meant
was that we can do the strings::join here if we're not tacking on : in our
vector items in disabledTest(). Sound good?
- Ben Mahler
On Sept. 19, 2014, 10:27 p.m., Timothy Chen wrote:
Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25858/ --- Review request for mesos, Ben Mahler, Ian Downes, Timothy St. Clair, and Vinod Kone. Bugs: MESOS-1195 https://issues.apache.org/jira/browse/MESOS-1195 Repository: mesos-git Description --- A dynamic version after discussed with Tim. https://reviews.apache.org/r/25695 Did a few consistency fixes as well. Diffs - src/linux/cgroups.cpp 5093b4ca1ac17238234d96613b7f4ceab4373c48 src/slave/containerizer/isolators/cgroups/cpushare.hpp d4df5f37e8d2e356d35ca40d799197a47393fa9a src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad472a561e81422f980182fd24eb95701140a src/slave/containerizer/isolators/cgroups/mem.cpp fb3db88af7b2ffa79272743f571c4c021c619c48 src/slave/containerizer/isolators/cgroups/perf_event.cpp ff047d37c1b2e659b18b5d4a1e97301192d05e55 src/slave/slave.cpp 28eb02852ddcc10efe589a8069dba9c895bc160e Diff: https://reviews.apache.org/r/25858/diff/ Testing --- make check sudo make check Thanks, Jie Yu
Re: Review Request 25785: Add guide to becoming a committer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/#review54053 --- I think it's valuable to outline some guidelines for anybody interested in becoming a committer, but I don't think we should set too many strict rules and regulations around it. Other thoughts below. docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93988 I like how BenH words it as a committer is somebody who is committed to the project. That's the most important thing, whether they are c++ code committers, build committers, doc committers, website committers, etc. docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93998 Let's call out the kinds of things we expect for community participation (IRC, mailing lists, reviewing other patches/JIRAs, etc.) docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93994 10-20 non-trivial patches seems arbitrarily high. I've seen us call votes for contributors with as few as a dozen patches, and some of them may have been trivial by some definition. We should discuss what the actual (non-trivial) patch limit should be. I would be fine nominating somebody with 5 non-trivial patches if they are active in the community and committed to the project. If they are to be a docs or website committer, the requirements could be even less. Maybe we shouldn't even publish a hard limit publicly. Maybe anybody can ask to be nominated, and the existing committers can evaluate the requirements for that individual/role. docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93990 code is relative, since some committers don't even write/commit c++ code. docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment94002 Why do you even need to specify real names? An email address and github/jira/review-board handle should be sufficient. I'd nominate an pseudononymous contributor who's been writing awesome code for us. docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment94004 Why 10 days? Why not 1 week? How did you arrive at this number? docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93991 Or you need to show more community involvement on JIRA/RB, mailing lists, and/or IRC. docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment94005 You can also get access to the Jenkins server, the Maven repo, and possibly the github.com/mesos organization. docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93992 Does that mean we will be revoking committer status from the Berkeley guys who have moved on to other things and are no longer contributing to Mesos? docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93993 Has this process been used/defined previously, or are you proposing a new process here? How long does the revocation vote last? - Adam B On Sept. 18, 2014, 10:41 a.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/ --- (Updated Sept. 18, 2014, 10:41 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1815 https://issues.apache.org/jira/browse/MESOS-1815 Repository: mesos-git Description --- Add a guide to becoming a committer. Diffs - docs/becoming-a-committer.md PRE-CREATION Diff: https://reviews.apache.org/r/25785/diff/ Testing --- Thanks, Dominic Hamon
Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/ --- Review request for mesos, Adam B and Ben Mahler. Bugs: MESOS-1081 and MESOS-1811 https://issues.apache.org/jira/browse/MESOS-1081 https://issues.apache.org/jira/browse/MESOS-1811 Repository: mesos-git Description --- Made consistent what connected and active frameworks/slaves means. Fixed MESOS-1811 along the way. Diffs - src/master/http.cpp 8db4d9a7565212e06b01dc0e1f801fc9c7ff509c src/master/master.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d src/tests/fault_tolerance_tests.cpp 6f4171a2c19673b1a676c08e867d504677097bcb Diff: https://reviews.apache.org/r/25866/diff/ Testing --- make check Thanks, Vinod Kone
Review Request 25867: Updated ping message to embed the slave registered status.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1668 https://issues.apache.org/jira/browse/MESOS-1668 Repository: mesos-git Description --- Embeded slave registration status in ping message to solicit slave re-registration during one way master -- slave partition. Diffs - src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d src/messages/messages.proto 7cb3ce651997c04ef1ef95539098ed2a99270b11 src/slave/slave.hpp 4f3df5c49a8cf72fc7153158c9eb045196b6cf13 src/slave/slave.cpp 28eb02852ddcc10efe589a8069dba9c895bc160e src/tests/partition_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25867/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 25569: Refactor test environment validations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/#review54063 --- Patch looks great! Reviews applied: [25569] All tests passed. - Mesos ReviewBot On Sept. 19, 2014, 10:27 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/ --- (Updated Sept. 19, 2014, 10:27 p.m.) Review request for mesos and Ben Mahler. Repository: mesos-git Description --- Review: https://reviews.apache.org/r/25569 Diffs - src/tests/environment.cpp 2274251aaf653d83c2d03ef2186763978067a747 Diff: https://reviews.apache.org/r/25569/diff/ Testing --- make check Thanks, Timothy Chen
Review Request 25868: Refactor Libprocess: class ProcessReference
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25868/ --- Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- Move class ProcessReference out of process.cpp and into its own header. Part of refactoring process.cpp. Diffs - 3rdparty/libprocess/include/Makefile.am 542ae1c 3rdparty/libprocess/include/process/process_reference.hpp PRE-CREATION 3rdparty/libprocess/src/process.cpp 8adc809 Diff: https://reviews.apache.org/r/25868/diff/ Testing --- make check in 3rdparty/libprocess support/mesos-style.py Thanks, Joris Van Remoortere
Re: Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25858/#review54070 --- Patch looks great! Reviews applied: [25858] All tests passed. - Mesos ReviewBot On Sept. 20, 2014, 12:21 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25858/ --- (Updated Sept. 20, 2014, 12:21 a.m.) Review request for mesos, Ben Mahler, Ian Downes, Timothy St. Clair, and Vinod Kone. Bugs: MESOS-1195 https://issues.apache.org/jira/browse/MESOS-1195 Repository: mesos-git Description --- A dynamic version after discussed with Tim. https://reviews.apache.org/r/25695 Did a few consistency fixes as well. Diffs - src/linux/cgroups.cpp 5093b4ca1ac17238234d96613b7f4ceab4373c48 src/slave/containerizer/isolators/cgroups/cpushare.hpp d4df5f37e8d2e356d35ca40d799197a47393fa9a src/slave/containerizer/isolators/cgroups/cpushare.cpp b1cad472a561e81422f980182fd24eb95701140a src/slave/containerizer/isolators/cgroups/mem.cpp fb3db88af7b2ffa79272743f571c4c021c619c48 src/slave/containerizer/isolators/cgroups/perf_event.cpp ff047d37c1b2e659b18b5d4a1e97301192d05e55 src/slave/slave.cpp 28eb02852ddcc10efe589a8069dba9c895bc160e Diff: https://reviews.apache.org/r/25858/diff/ Testing --- make check sudo make check Thanks, Jie Yu
Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54072 --- Bad patch! Reviews applied: [25866] Failed command: git apply --index 25866.patch Error: error: patch failed: src/master/http.cpp:115 error: src/master/http.cpp: patch does not apply - Mesos ReviewBot On Sept. 20, 2014, 12:32 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/ --- (Updated Sept. 20, 2014, 12:32 a.m.) Review request for mesos, Adam B and Ben Mahler. Bugs: MESOS-1081 and MESOS-1811 https://issues.apache.org/jira/browse/MESOS-1081 https://issues.apache.org/jira/browse/MESOS-1811 Repository: mesos-git Description --- Made consistent what connected and active frameworks/slaves means. Fixed MESOS-1811 along the way. Diffs - src/master/http.cpp 8db4d9a7565212e06b01dc0e1f801fc9c7ff509c src/master/master.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d src/tests/fault_tolerance_tests.cpp 6f4171a2c19673b1a676c08e867d504677097bcb Diff: https://reviews.apache.org/r/25866/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 25868: Refactor Libprocess: class ProcessReference
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25868/#review54073 --- Patch looks great! Reviews applied: [25868] All tests passed. - Mesos ReviewBot On Sept. 20, 2014, 12:58 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25868/ --- (Updated Sept. 20, 2014, 12:58 a.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- Move class ProcessReference out of process.cpp and into its own header. Part of refactoring process.cpp. Diffs - 3rdparty/libprocess/include/Makefile.am 542ae1c 3rdparty/libprocess/include/process/process_reference.hpp PRE-CREATION 3rdparty/libprocess/src/process.cpp 8adc809 Diff: https://reviews.apache.org/r/25868/diff/ Testing --- make check in 3rdparty/libprocess support/mesos-style.py Thanks, Joris Van Remoortere
